[GitHub] eaglewatcherwb commented on a change in pull request #7412: [FLINK-10866][Runtime] 1. Explicitly enable qs server and proxy. 2. QS

2019-01-08 Thread GitBox
eaglewatcherwb commented on a change in pull request #7412: [FLINK-10866][Runtime] 1. Explicitly enable qs server and proxy. 2. QS URL: https://github.com/apache/flink/pull/7412#discussion_r246284001 ## File path:

[GitHub] TisonKun commented on issue #7303: [FLINK-10569] [tests] Get rid of Scheduler from valid tests

2019-01-08 Thread GitBox
TisonKun commented on issue #7303: [FLINK-10569] [tests] Get rid of Scheduler from valid tests URL: https://github.com/apache/flink/pull/7303#issuecomment-452601355 cc @tillrohrmann I'd like to finalize this pr. Since the rest of valid usages of `Scheduler` are in

[GitHub] sunjincheng121 commented on issue #7437: [FLINK-11278] [docs] Add documentation for TableAPI in scala-shell

2019-01-08 Thread GitBox
sunjincheng121 commented on issue #7437: [FLINK-11278] [docs] Add documentation for TableAPI in scala-shell URL: https://github.com/apache/flink/pull/7437#issuecomment-452600414 Thanks @WeiZhong94 and @hequn8128 ! LGTM. +1 to merged. Bests, Jincheng

[GitHub] WeiZhong94 commented on a change in pull request #7437: [FLINK-11278] [docs] Add documentation for TableAPI in scala-shell

2019-01-08 Thread GitBox
WeiZhong94 commented on a change in pull request #7437: [FLINK-11278] [docs] Add documentation for TableAPI in scala-shell URL: https://github.com/apache/flink/pull/7437#discussion_r246275229 ## File path: docs/ops/scala_shell.md ## @@ -85,6 +86,113 @@ Note, that in the

[GitHub] klion26 closed pull request #7421: [FLINK-11167][runtime] Optimize RocksDBListState#Put by removing the clear before put operation when input is not empty

2019-01-08 Thread GitBox
klion26 closed pull request #7421: [FLINK-11167][runtime] Optimize RocksDBListState#Put by removing the clear before put operation when input is not empty URL: https://github.com/apache/flink/pull/7421 This is a PR merged from a forked repository. As GitHub hides the original diff on

[GitHub] klion26 opened a new pull request #7421: [FLINK-11167][runtime] Optimize RocksDBListState#Put by removing the clear before put operation when input is not empty

2019-01-08 Thread GitBox
klion26 opened a new pull request #7421: [FLINK-11167][runtime] Optimize RocksDBListState#Put by removing the clear before put operation when input is not empty URL: https://github.com/apache/flink/pull/7421 ## What is the purpose of the change This pull request adjusts the clear's

[GitHub] sunjincheng121 commented on a change in pull request #7437: [FLINK-11278] [docs] Add documentation for TableAPI in scala-shell

2019-01-08 Thread GitBox
sunjincheng121 commented on a change in pull request #7437: [FLINK-11278] [docs] Add documentation for TableAPI in scala-shell URL: https://github.com/apache/flink/pull/7437#discussion_r246272212 ## File path: docs/ops/scala_shell.md ## @@ -85,6 +86,113 @@ Note, that in

[GitHub] WeiZhong94 commented on issue #7437: [FLINK-11278] [docs] Add documentation for TableAPI in scala-shell

2019-01-08 Thread GitBox
WeiZhong94 commented on issue #7437: [FLINK-11278] [docs] Add documentation for TableAPI in scala-shell URL: https://github.com/apache/flink/pull/7437#issuecomment-452587166 @hequn8128 Thanks for your review! I have updated the PR according to your comments.

[GitHub] hequn8128 commented on a change in pull request #7437: [FLINK-11278] [docs] Add documentation for TableAPI in scala-shell

2019-01-08 Thread GitBox
hequn8128 commented on a change in pull request #7437: [FLINK-11278] [docs] Add documentation for TableAPI in scala-shell URL: https://github.com/apache/flink/pull/7437#discussion_r246269302 ## File path: docs/ops/scala_shell.md ## @@ -36,9 +36,10 @@ cluster, please see

[GitHub] hequn8128 commented on a change in pull request #7437: [FLINK-11278] [docs] Add documentation for TableAPI in scala-shell

2019-01-08 Thread GitBox
hequn8128 commented on a change in pull request #7437: [FLINK-11278] [docs] Add documentation for TableAPI in scala-shell URL: https://github.com/apache/flink/pull/7437#discussion_r246269314 ## File path: docs/ops/scala_shell.md ## @@ -85,6 +86,113 @@ Note, that in the

[GitHub] hequn8128 commented on a change in pull request #7437: [FLINK-11278] [docs] Add documentation for TableAPI in scala-shell

2019-01-08 Thread GitBox
hequn8128 commented on a change in pull request #7437: [FLINK-11278] [docs] Add documentation for TableAPI in scala-shell URL: https://github.com/apache/flink/pull/7437#discussion_r246269294 ## File path: docs/ops/scala_shell.md ## @@ -36,9 +36,10 @@ cluster, please see

[GitHub] zhijiangW edited a comment on issue #7438: [FLINK-11282][network] Merge StreamRecordWriter into RecordWriter

2019-01-08 Thread GitBox
zhijiangW edited a comment on issue #7438: [FLINK-11282][network] Merge StreamRecordWriter into RecordWriter URL: https://github.com/apache/flink/pull/7438#issuecomment-452584460 @pnowojski , the motivation of this PR is for fixing the issue in #7199 . To do so we can unify the

[GitHub] zhijiangW commented on issue #7438: [FLINK-11282][network] Merge StreamRecordWriter into RecordWriter

2019-01-08 Thread GitBox
zhijiangW commented on issue #7438: [FLINK-11282][network] Merge StreamRecordWriter into RecordWriter URL: https://github.com/apache/flink/pull/7438#issuecomment-452584460 @pnowojski , the motivation of this PR is for fixing the issue in @ #7199 . To do so we can unify the

[jira] [Updated] (FLINK-11282) Merge StreamRecordWriter into RecordWriter

2019-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11282: --- Labels: pull-request-available (was: ) > Merge StreamRecordWriter into RecordWriter >

[GitHub] zhijiangW opened a new pull request #7438: [FLINK-11282][network] Merge StreamRecordWriter into RecordWriter

2019-01-08 Thread GitBox
zhijiangW opened a new pull request #7438: [FLINK-11282][network] Merge StreamRecordWriter into RecordWriter URL: https://github.com/apache/flink/pull/7438 ## What is the purpose of the change *It is reasonable for merging `StreamRecordWriter` into `RecordWriter`, because the

[GitHub] klion26 commented on a change in pull request #7412: [FLINK-10866][Runtime] 1. Explicitly enable qs server and proxy. 2. QS

2019-01-08 Thread GitBox
klion26 commented on a change in pull request #7412: [FLINK-10866][Runtime] 1. Explicitly enable qs server and proxy. 2. QS URL: https://github.com/apache/flink/pull/7412#discussion_r246266214 ## File path:

[jira] [Updated] (FLINK-11278) Add documentation for TableAPI in scala-shell

2019-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11278: --- Labels: pull-request-available (was: ) > Add documentation for TableAPI in scala-shell >

[GitHub] WeiZhong94 opened a new pull request #7437: [FLINK-11278] [docs] Add documentation for TableAPI in scala-shell

2019-01-08 Thread GitBox
WeiZhong94 opened a new pull request #7437: [FLINK-11278] [docs] Add documentation for TableAPI in scala-shell URL: https://github.com/apache/flink/pull/7437 ## What is the purpose of the change This pull request adds documentation for TableAPI in scala-shell. ## Brief

[GitHub] zjffdu commented on issue #6245: [FLINK-9718][scala-shell]. Add enviroment variable in start-scala-shell.sh and flink to enable remote debug

2019-01-08 Thread GitBox
zjffdu commented on issue #6245: [FLINK-9718][scala-shell]. Add enviroment variable in start-scala-shell.sh and flink to enable remote debug URL: https://github.com/apache/flink/pull/6245#issuecomment-452563277 @tillrohrmann @uce Could you help review it ? Thanks

[GitHub] zjffdu commented on issue #7229: [FLINK-11060][scala-shell] Unable to set number of task manager and slot per task manager in scala shell local mode

2019-01-08 Thread GitBox
zjffdu commented on issue #7229: [FLINK-11060][scala-shell] Unable to set number of task manager and slot per task manager in scala shell local mode URL: https://github.com/apache/flink/pull/7229#issuecomment-452563233 @tillrohrmann @uce Could you help review it ? Thanks

[GitHub] zjffdu commented on issue #7371: [FLINK-11224][scala-shell] Log is missing in scala-shell

2019-01-08 Thread GitBox
zjffdu commented on issue #7371: [FLINK-11224][scala-shell] Log is missing in scala-shell URL: https://github.com/apache/flink/pull/7371#issuecomment-452562192 @tillrohrmann @uce Could you help review this ? Thanks This is

[jira] [Assigned] (FLINK-11141) Key generation for RocksDBMapState can theoretically be ambiguous

2019-01-08 Thread Congxian Qiu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Congxian Qiu reassigned FLINK-11141: Assignee: Congxian Qiu > Key generation for RocksDBMapState can theoretically be

[jira] [Updated] (FLINK-11071) Dynamic proxy classes cannot be resolved when deserializing job graph

2019-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11071: --- Labels: pull-request-available (was: ) > Dynamic proxy classes cannot be resolved when

[GitHub] eaglewatcherwb opened a new pull request #7436: [FLINK-11071][core] add support for dynamic proxy classes resolution …

2019-01-08 Thread GitBox
eaglewatcherwb opened a new pull request #7436: [FLINK-11071][core] add support for dynamic proxy classes resolution … URL: https://github.com/apache/flink/pull/7436 …in job defination Change-Id: I5a7d9c489a15a2dcc0cf895e68a1d11ca57f68bc ## What is the purpose of the

[GitHub] TisonKun removed a comment on issue #7427: [hotfix] [test] Reduce test timeout to a reasonable value

2019-01-08 Thread GitBox
TisonKun removed a comment on issue #7427: [hotfix] [test] Reduce test timeout to a reasonable value URL: https://github.com/apache/flink/pull/7427#issuecomment-452274917 Re-trigger because `RocksDBStateBackendMigrationTest` failing like a known issue

[GitHub] TisonKun commented on issue #7340: [FLINK-11174] [prometheus] Flink Metrics Prometheus label values supp…

2019-01-08 Thread GitBox
TisonKun commented on issue #7340: [FLINK-11174] [prometheus] Flink Metrics Prometheus label values supp… URL: https://github.com/apache/flink/pull/7340#issuecomment-452550167 I think travis failed on irrelevant issue https://travis-ci.org/apache/flink/jobs/476813930

[jira] [Updated] (FLINK-11291) Reorganize the package of flink-cep module

2019-01-08 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-11291: Description: Currently, there is no package such as org.apache.flink.cep.api in flink-cep module and the

[jira] [Created] (FLINK-11291) Reorganize the package of flink-cep module

2019-01-08 Thread Dian Fu (JIRA)
Dian Fu created FLINK-11291: --- Summary: Reorganize the package of flink-cep module Key: FLINK-11291 URL: https://issues.apache.org/jira/browse/FLINK-11291 Project: Flink Issue Type: Task

[GitHub] kisimple commented on issue #7430: [FLINK-10848] Remove container requests after successful container allocation

2019-01-08 Thread GitBox
kisimple commented on issue #7430: [FLINK-10848] Remove container requests after successful container allocation URL: https://github.com/apache/flink/pull/7430#issuecomment-452549410 Changes look great from my side, just left a minor comment :)

[GitHub] hequn8128 commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API

2019-01-08 Thread GitBox
hequn8128 commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API URL: https://github.com/apache/flink/pull/7209#discussion_r246238933 ## File path: docs/dev/table/tableApi.md ## @@ -550,6 +550,82 @@

[GitHub] kisimple commented on a change in pull request #7430: [FLINK-10848] Remove container requests after successful container allocation

2019-01-08 Thread GitBox
kisimple commented on a change in pull request #7430: [FLINK-10848] Remove container requests after successful container allocation URL: https://github.com/apache/flink/pull/7430#discussion_r246241536 ## File path:

[jira] [Commented] (FLINK-11285) Change the modifier of CsvTableSourceFactoryBase.createTableSource and CsvTableSinkFactoryBase.createTableSink to private[flink]

2019-01-08 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737759#comment-16737759 ] Dian Fu commented on FLINK-11285: - [~twalthr] Currently the Descriptor related classes are all located

[GitHub] eaglewatcherwb commented on a change in pull request #7412: [FLINK-10866][Runtime] 1. Explicitly enable qs server and proxy. 2. QS

2019-01-08 Thread GitBox
eaglewatcherwb commented on a change in pull request #7412: [FLINK-10866][Runtime] 1. Explicitly enable qs server and proxy. 2. QS URL: https://github.com/apache/flink/pull/7412#discussion_r246241472 ## File path:

[GitHub] sunjincheng121 commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API

2019-01-08 Thread GitBox
sunjincheng121 commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API URL: https://github.com/apache/flink/pull/7209#discussion_r246240354 ## File path:

[GitHub] hequn8128 commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API

2019-01-08 Thread GitBox
hequn8128 commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API URL: https://github.com/apache/flink/pull/7209#discussion_r246239403 ## File path:

[jira] [Updated] (FLINK-11226) Lack of getKeySelector in Scala KeyedStream API unlike Java KeyedStream

2019-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11226: --- Labels: pull-request-available (was: ) > Lack of getKeySelector in Scala KeyedStream API

[GitHub] yanghua opened a new pull request #7435: [FLINK-11226] Lack of getKeySelector in Scala KeyedStream API unlike Java KeyedStream

2019-01-08 Thread GitBox
yanghua opened a new pull request #7435: [FLINK-11226] Lack of getKeySelector in Scala KeyedStream API unlike Java KeyedStream URL: https://github.com/apache/flink/pull/7435 ## What is the purpose of the change *This pull request provides a internal API `getKeySelector` for

[GitHub] hequn8128 commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API

2019-01-08 Thread GitBox
hequn8128 commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API URL: https://github.com/apache/flink/pull/7209#discussion_r246238933 ## File path: docs/dev/table/tableApi.md ## @@ -550,6 +550,82 @@

[jira] [Commented] (FLINK-11256) Referencing StreamNode objects directly in StreamEdge causes the sizes of JobGraph and TDD to become unnecessarily large

2019-01-08 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737749#comment-16737749 ] sunjincheng commented on FLINK-11256: - Hi [~sunhaibotb] Good catch! we really need to reduce the

[GitHub] dianfu closed pull request #7433: [FLINK-11285] [table] Change the modifier of CsvTableSourceFactoryBase.createTableSource and CsvTableSinkFactoryBase.createTableSink to private[flink]

2019-01-08 Thread GitBox
dianfu closed pull request #7433: [FLINK-11285] [table] Change the modifier of CsvTableSourceFactoryBase.createTableSource and CsvTableSinkFactoryBase.createTableSink to private[flink] URL: https://github.com/apache/flink/pull/7433 This is a PR merged from a forked repository. As GitHub

[jira] [Commented] (FLINK-11285) Change the modifier of CsvTableSourceFactoryBase.createTableSource and CsvTableSinkFactoryBase.createTableSink to private[flink]

2019-01-08 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737748#comment-16737748 ] Dian Fu commented on FLINK-11285: - [~twalthr] Thanks a lot for the comments. I think you are right. Will

[jira] [Closed] (FLINK-11285) Change the modifier of CsvTableSourceFactoryBase.createTableSource and CsvTableSinkFactoryBase.createTableSink to private[flink]

2019-01-08 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu closed FLINK-11285. --- Resolution: Not A Problem > Change the modifier of CsvTableSourceFactoryBase.createTableSource and >

[GitHub] hequn8128 commented on a change in pull request #7418: FLINK-11053 Documentation - update scala sample code for bucketing sink according

2019-01-08 Thread GitBox
hequn8128 commented on a change in pull request #7418: FLINK-11053 Documentation - update scala sample code for bucketing sink according URL: https://github.com/apache/flink/pull/7418#discussion_r246237842 ## File path: docs/dev/connectors/filesystem_sink.md ## @@ -117,11

[jira] [Assigned] (FLINK-11290) BatchTableEnvironment and StreamTableEnvironment should transparent to users

2019-01-08 Thread Wei Zhong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei Zhong reassigned FLINK-11290: - Assignee: Wei Zhong > BatchTableEnvironment and StreamTableEnvironment should transparent to

[jira] [Commented] (FLINK-11067) Port TableEnvironments to Java

2019-01-08 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737716#comment-16737716 ] sunjincheng commented on FLINK-11067: - Hi [~twalthr],  I totally agree to go step by step. And the

[GitHub] klion26 commented on issue #7421: [FLINK-11167][runtime] Optimize RocksDBListState#Put by removing the clear before put operation when input is not empty

2019-01-08 Thread GitBox
klion26 commented on issue #7421: [FLINK-11167][runtime] Optimize RocksDBListState#Put by removing the clear before put operation when input is not empty URL: https://github.com/apache/flink/pull/7421#issuecomment-452522870 @tzulitai thank you for the feedback, I've rebased master and

[jira] [Updated] (FLINK-11229) Support ScalarFunction for the where/filter clause.

2019-01-08 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-11229: Issue Type: Bug (was: Sub-task) Parent: (was: FLINK-10972) > Support ScalarFunction

[jira] [Created] (FLINK-11290) BatchTableEnvironment and StreamTableEnvironment should transparent to users

2019-01-08 Thread sunjincheng (JIRA)
sunjincheng created FLINK-11290: --- Summary: BatchTableEnvironment and StreamTableEnvironment should transparent to users Key: FLINK-11290 URL: https://issues.apache.org/jira/browse/FLINK-11290 Project:

[jira] [Updated] (FLINK-11290) BatchTableEnvironment and StreamTableEnvironment should transparent to users

2019-01-08 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-11290: Issue Type: Sub-task (was: Improvement) Parent: FLINK-10972 > BatchTableEnvironment and

[jira] [Updated] (FLINK-10972) Enhancements to Flink Table API

2019-01-08 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-10972: Description: [link title|http://example.com]With the continuous efforts from the community, the

[jira] [Commented] (FLINK-11220) Can not Select row time field in JOIN query

2019-01-08 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737693#comment-16737693 ] sunjincheng commented on FLINK-11220: - Yes, I think we also can improve the

[jira] [Commented] (FLINK-11187) StreamingFileSink with S3 backend transient socket timeout issues

2019-01-08 Thread Addison Higham (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737665#comment-16737665 ] Addison Higham commented on FLINK-11187: Hey [~kkl0u], I took a crack at making the relevant

[GitHub] bowenli86 commented on a change in pull request #7409: [FLINK-11064] [table] Setup a new flink-table module structure

2019-01-08 Thread GitBox
bowenli86 commented on a change in pull request #7409: [FLINK-11064] [table] Setup a new flink-table module structure URL: https://github.com/apache/flink/pull/7409#discussion_r246173465 ## File path: flink-table/flink-table-api-java/pom.xml ## @@ -0,0 +1,77 @@ + +

[jira] [Resolved] (FLINK-10700) Remove LegacyStandaloneClusterDescriptor

2019-01-08 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-10700. --- Resolution: Fixed Fixed via

[GitHub] tillrohrmann closed pull request #6946: [FLINK-10700] [cluster managerment] Remove LegacyStandaloneClusterDes…

2019-01-08 Thread GitBox
tillrohrmann closed pull request #6946: [FLINK-10700] [cluster managerment] Remove LegacyStandaloneClusterDes… URL: https://github.com/apache/flink/pull/6946 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] tillrohrmann commented on issue #6946: [FLINK-10700] [cluster managerment] Remove LegacyStandaloneClusterDes…

2019-01-08 Thread GitBox
tillrohrmann commented on issue #6946: [FLINK-10700] [cluster managerment] Remove LegacyStandaloneClusterDes… URL: https://github.com/apache/flink/pull/6946#issuecomment-452402551 The `StandaloneClusterClient` is still being used by `flink-storm`. We first need to remove this module

[jira] [Resolved] (FLINK-10555) Port AkkaSslITCase to new code base

2019-01-08 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-10555. --- Resolution: Fixed Fixed via 1072bbfe500999eb3e3710271f15ff53a534475d

[GitHub] asfgit closed pull request #6849: [FLINK-10555] [test] Port AkkaSslITCase to new code base

2019-01-08 Thread GitBox
asfgit closed pull request #6849: [FLINK-10555] [test] Port AkkaSslITCase to new code base URL: https://github.com/apache/flink/pull/6849 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[jira] [Updated] (FLINK-11269) Extend Download page to list optional components

2019-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11269: --- Labels: pull-request-available (was: ) > Extend Download page to list optional components

[jira] [Updated] (FLINK-11287) RocksDBListState should use actual registered state serializer instead of serializer provided by descriptor

2019-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11287: --- Labels: pull-request-available (was: ) > RocksDBListState should use actual registered

[GitHub] tzulitai opened a new pull request #7434: [FLINK-11287] [rocksdb] RocksDBListState should be using registered serializer in state meta infos

2019-01-08 Thread GitBox
tzulitai opened a new pull request #7434: [FLINK-11287] [rocksdb] RocksDBListState should be using registered serializer in state meta infos URL: https://github.com/apache/flink/pull/7434 ## What is the purpose of the change `RocksDBListState` was using the serializer provided by

[GitHub] tzulitai commented on a change in pull request #7020: [FLINK-10774] [Kafka] connection leak when partition discovery is disabled an…

2019-01-08 Thread GitBox
tzulitai commented on a change in pull request #7020: [FLINK-10774] [Kafka] connection leak when partition discovery is disabled an… URL: https://github.com/apache/flink/pull/7020#discussion_r246082400 ## File path:

[GitHub] tzulitai commented on a change in pull request #7020: [FLINK-10774] [Kafka] connection leak when partition discovery is disabled an…

2019-01-08 Thread GitBox
tzulitai commented on a change in pull request #7020: [FLINK-10774] [Kafka] connection leak when partition discovery is disabled an… URL: https://github.com/apache/flink/pull/7020#discussion_r246082400 ## File path:

[GitHub] tzulitai commented on a change in pull request #7020: [FLINK-10774] [Kafka] connection leak when partition discovery is disabled an…

2019-01-08 Thread GitBox
tzulitai commented on a change in pull request #7020: [FLINK-10774] [Kafka] connection leak when partition discovery is disabled an… URL: https://github.com/apache/flink/pull/7020#discussion_r246082400 ## File path:

[GitHub] 123avi commented on a change in pull request #7418: FLINK-11053 Documentation - update scala sample code for bucketing sink according

2019-01-08 Thread GitBox
123avi commented on a change in pull request #7418: FLINK-11053 Documentation - update scala sample code for bucketing sink according URL: https://github.com/apache/flink/pull/7418#discussion_r246046433 ## File path: docs/dev/connectors/filesystem_sink.md ## @@ -117,11

[jira] [Commented] (FLINK-11285) Change the modifier of CsvTableSourceFactoryBase.createTableSource and CsvTableSinkFactoryBase.createTableSink to private[flink]

2019-01-08 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737305#comment-16737305 ] Timo Walther commented on FLINK-11285: -- Actually, users should not use these classes at all.

[GitHub] tillrohrmann commented on a change in pull request #7020: [FLINK-10774] [Kafka] connection leak when partition discovery is disabled an…

2019-01-08 Thread GitBox
tillrohrmann commented on a change in pull request #7020: [FLINK-10774] [Kafka] connection leak when partition discovery is disabled an… URL: https://github.com/apache/flink/pull/7020#discussion_r246072609 ## File path:

[GitHub] tillrohrmann commented on a change in pull request #7020: [FLINK-10774] [Kafka] connection leak when partition discovery is disabled an…

2019-01-08 Thread GitBox
tillrohrmann commented on a change in pull request #7020: [FLINK-10774] [Kafka] connection leak when partition discovery is disabled an… URL: https://github.com/apache/flink/pull/7020#discussion_r246072202 ## File path:

[GitHub] tillrohrmann commented on a change in pull request #7020: [FLINK-10774] [Kafka] connection leak when partition discovery is disabled an…

2019-01-08 Thread GitBox
tillrohrmann commented on a change in pull request #7020: [FLINK-10774] [Kafka] connection leak when partition discovery is disabled an… URL: https://github.com/apache/flink/pull/7020#discussion_r246073731 ## File path:

[GitHub] tillrohrmann commented on a change in pull request #7020: [FLINK-10774] [Kafka] connection leak when partition discovery is disabled an…

2019-01-08 Thread GitBox
tillrohrmann commented on a change in pull request #7020: [FLINK-10774] [Kafka] connection leak when partition discovery is disabled an… URL: https://github.com/apache/flink/pull/7020#discussion_r246069474 ## File path:

[GitHub] tillrohrmann commented on a change in pull request #7020: [FLINK-10774] [Kafka] connection leak when partition discovery is disabled an…

2019-01-08 Thread GitBox
tillrohrmann commented on a change in pull request #7020: [FLINK-10774] [Kafka] connection leak when partition discovery is disabled an… URL: https://github.com/apache/flink/pull/7020#discussion_r246074960 ## File path:

[GitHub] tillrohrmann commented on a change in pull request #7020: [FLINK-10774] [Kafka] connection leak when partition discovery is disabled an…

2019-01-08 Thread GitBox
tillrohrmann commented on a change in pull request #7020: [FLINK-10774] [Kafka] connection leak when partition discovery is disabled an… URL: https://github.com/apache/flink/pull/7020#discussion_r246067761 ## File path:

[GitHub] Myasuka commented on a change in pull request #7009: [FLINK-10712] Support to restore state when using RestartPipelinedRegionStrategy

2019-01-08 Thread GitBox
Myasuka commented on a change in pull request #7009: [FLINK-10712] Support to restore state when using RestartPipelinedRegionStrategy URL: https://github.com/apache/flink/pull/7009#discussion_r246074413 ## File path:

[GitHub] asfgit closed pull request #7422: [FLINK-11073] (part 2) Introduce CompositeTypeSerializerSnapshot and migrate existing composite serializers' snapshots

2019-01-08 Thread GitBox
asfgit closed pull request #7422: [FLINK-11073] (part 2) Introduce CompositeTypeSerializerSnapshot and migrate existing composite serializers' snapshots URL: https://github.com/apache/flink/pull/7422 This is a PR merged from a forked repository. As GitHub hides the original diff on

[GitHub] tzulitai commented on issue #7422: [FLINK-11073] (part 2) Introduce CompositeTypeSerializerSnapshot and migrate existing composite serializers' snapshots

2019-01-08 Thread GitBox
tzulitai commented on issue #7422: [FLINK-11073] (part 2) Introduce CompositeTypeSerializerSnapshot and migrate existing composite serializers' snapshots URL: https://github.com/apache/flink/pull/7422#issuecomment-452369684 Travis passes on my local branch:

[GitHub] tillrohrmann commented on a change in pull request #7255: [FLINK-10945] Use InputDependencyConstraint to avoid resource dead…

2019-01-08 Thread GitBox
tillrohrmann commented on a change in pull request #7255: [FLINK-10945] Use InputDependencyConstraint to avoid resource dead… URL: https://github.com/apache/flink/pull/7255#discussion_r246052711 ## File path:

[GitHub] tillrohrmann commented on a change in pull request #7255: [FLINK-10945] Use InputDependencyConstraint to avoid resource dead…

2019-01-08 Thread GitBox
tillrohrmann commented on a change in pull request #7255: [FLINK-10945] Use InputDependencyConstraint to avoid resource dead… URL: https://github.com/apache/flink/pull/7255#discussion_r246064697 ## File path:

[GitHub] tillrohrmann commented on a change in pull request #7255: [FLINK-10945] Use InputDependencyConstraint to avoid resource dead…

2019-01-08 Thread GitBox
tillrohrmann commented on a change in pull request #7255: [FLINK-10945] Use InputDependencyConstraint to avoid resource dead… URL: https://github.com/apache/flink/pull/7255#discussion_r246055424 ## File path:

[GitHub] tillrohrmann commented on a change in pull request #7255: [FLINK-10945] Use InputDependencyConstraint to avoid resource dead…

2019-01-08 Thread GitBox
tillrohrmann commented on a change in pull request #7255: [FLINK-10945] Use InputDependencyConstraint to avoid resource dead… URL: https://github.com/apache/flink/pull/7255#discussion_r246052939 ## File path:

[GitHub] tillrohrmann commented on a change in pull request #7255: [FLINK-10945] Use InputDependencyConstraint to avoid resource dead…

2019-01-08 Thread GitBox
tillrohrmann commented on a change in pull request #7255: [FLINK-10945] Use InputDependencyConstraint to avoid resource dead… URL: https://github.com/apache/flink/pull/7255#discussion_r246054482 ## File path:

[jira] [Created] (FLINK-11289) Rework example module structure to account for licensing

2019-01-08 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-11289: Summary: Rework example module structure to account for licensing Key: FLINK-11289 URL: https://issues.apache.org/jira/browse/FLINK-11289 Project: Flink

[GitHub] zentol commented on issue #7277: [FLINK-11022] Add LICENSE & NOTICE files for 1.6

2019-01-08 Thread GitBox
zentol commented on issue #7277: [FLINK-11022] Add LICENSE & NOTICE files for 1.6 URL: https://github.com/apache/flink/pull/7277#issuecomment-452350379 @tillrohrmann I've addressed your comments. This is an automated message

[GitHub] zentol commented on a change in pull request #7277: [FLINK-11022] Add LICENSE & NOTICE files for 1.6

2019-01-08 Thread GitBox
zentol commented on a change in pull request #7277: [FLINK-11022] Add LICENSE & NOTICE files for 1.6 URL: https://github.com/apache/flink/pull/7277#discussion_r246050678 ## File path: NOTICE-binary ## @@ -0,0 +1,4297 @@ +//

[GitHub] 123avi commented on a change in pull request #7418: FLINK-11053 Documentation - update scala sample code for bucketing sink according

2019-01-08 Thread GitBox
123avi commented on a change in pull request #7418: FLINK-11053 Documentation - update scala sample code for bucketing sink according URL: https://github.com/apache/flink/pull/7418#discussion_r246046433 ## File path: docs/dev/connectors/filesystem_sink.md ## @@ -117,11

[GitHub] tzulitai commented on issue #7421: [FLINK-11167][runtime] Optimize RocksDBListState#Put by removing the clear before put operation when input is not empty

2019-01-08 Thread GitBox
tzulitai commented on issue #7421: [FLINK-11167][runtime] Optimize RocksDBListState#Put by removing the clear before put operation when input is not empty URL: https://github.com/apache/flink/pull/7421#issuecomment-452347247 FLINK-11280 is fixed and merged to master now.

[GitHub] 123avi commented on a change in pull request #7418: FLINK-11053 Documentation - update scala sample code for bucketing sink according

2019-01-08 Thread GitBox
123avi commented on a change in pull request #7418: FLINK-11053 Documentation - update scala sample code for bucketing sink according URL: https://github.com/apache/flink/pull/7418#discussion_r246046433 ## File path: docs/dev/connectors/filesystem_sink.md ## @@ -117,11

[GitHub] 123avi commented on a change in pull request #7418: FLINK-11053 Documentation - update scala sample code for bucketing sink according

2019-01-08 Thread GitBox
123avi commented on a change in pull request #7418: FLINK-11053 Documentation - update scala sample code for bucketing sink according URL: https://github.com/apache/flink/pull/7418#discussion_r246046433 ## File path: docs/dev/connectors/filesystem_sink.md ## @@ -117,11

[GitHub] azagrebin commented on a change in pull request #7320: [FLINK-11171] Avoid concurrent usage of StateSnapshotTransformer

2019-01-08 Thread GitBox
azagrebin commented on a change in pull request #7320: [FLINK-11171] Avoid concurrent usage of StateSnapshotTransformer URL: https://github.com/apache/flink/pull/7320#discussion_r246043385 ## File path:

[GitHub] azagrebin commented on a change in pull request #7320: [FLINK-11171] Avoid concurrent usage of StateSnapshotTransformer

2019-01-08 Thread GitBox
azagrebin commented on a change in pull request #7320: [FLINK-11171] Avoid concurrent usage of StateSnapshotTransformer URL: https://github.com/apache/flink/pull/7320#discussion_r246042589 ## File path:

[GitHub] tzulitai commented on a change in pull request #7320: [FLINK-11171] Avoid concurrent usage of StateSnapshotTransformer

2019-01-08 Thread GitBox
tzulitai commented on a change in pull request #7320: [FLINK-11171] Avoid concurrent usage of StateSnapshotTransformer URL: https://github.com/apache/flink/pull/7320#discussion_r246038610 ## File path:

[GitHub] xueyumusic commented on a change in pull request #6445: [FLINK-8302] [table] Add SHIFT_LEFT and SHIFT_RIGHT

2019-01-08 Thread GitBox
xueyumusic commented on a change in pull request #6445: [FLINK-8302] [table] Add SHIFT_LEFT and SHIFT_RIGHT URL: https://github.com/apache/flink/pull/6445#discussion_r246034932 ## File path:

[GitHub] azagrebin commented on a change in pull request #7320: [FLINK-11171] Avoid concurrent usage of StateSnapshotTransformer

2019-01-08 Thread GitBox
azagrebin commented on a change in pull request #7320: [FLINK-11171] Avoid concurrent usage of StateSnapshotTransformer URL: https://github.com/apache/flink/pull/7320#discussion_r246031875 ## File path:

[jira] [Commented] (FLINK-11279) Invalid week interval parsing in ExpressionParser

2019-01-08 Thread xuqianjin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737218#comment-16737218 ] xuqianjin commented on FLINK-11279: --- hi [~twalthr] Thank you very much Best, qianjin > Invalid week

[GitHub] hequn8128 commented on a change in pull request #7418: FLINK-11053 Documentation - update scala sample code for bucketing sink according

2019-01-08 Thread GitBox
hequn8128 commented on a change in pull request #7418: FLINK-11053 Documentation - update scala sample code for bucketing sink according URL: https://github.com/apache/flink/pull/7418#discussion_r246013215 ## File path: docs/dev/connectors/filesystem_sink.md ## @@ -117,11

[jira] [Updated] (FLINK-11287) RocksDBListState should use actual registered state serializer instead of serializer provided by descriptor

2019-01-08 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-11287: Summary: RocksDBListState should use actual registered state serializer instead

[GitHub] leesf commented on issue #7262: [FLINK-10478] Kafka Producer wrongly formats % for transaction ID

2019-01-08 Thread GitBox
leesf commented on issue #7262: [FLINK-10478] Kafka Producer wrongly formats % for transaction ID URL: https://github.com/apache/flink/pull/7262#issuecomment-452320417 cc @GJL @dawidwys This is an automated message from the

[GitHub] kl0u commented on issue #7287: [FLINK-11140][streaming] Fix empty child path check in Buckets

2019-01-08 Thread GitBox
kl0u commented on issue #7287: [FLINK-11140][streaming] Fix empty child path check in Buckets URL: https://github.com/apache/flink/pull/7287#issuecomment-452320005 Sorry, I just saw that you addressed the comments. I will review soon.

[jira] [Updated] (FLINK-11288) Add separate flink-ml module for building fat jar

2019-01-08 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-11288: - Summary: Add separate flink-ml module for building fat jar (was: Add separate flink-ml

[jira] [Created] (FLINK-11288) Add separate flink-ml for building fat jar

2019-01-08 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-11288: Summary: Add separate flink-ml for building fat jar Key: FLINK-11288 URL: https://issues.apache.org/jira/browse/FLINK-11288 Project: Flink Issue

[jira] [Commented] (FLINK-11286) Support to send StreamStatus.IDLE for non-source operators

2019-01-08 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737171#comment-16737171 ] vinoyang commented on FLINK-11286: -- OK, Let us listen to [~aljoscha] 's opinion. > Support to send

  1   2   3   >