[GitHub] [flink] JingsongLi commented on issue #8184: [FLINK-12211][table-planner-blink] Add more it cases to blink batch

2019-04-16 Thread GitBox
JingsongLi commented on issue #8184: [FLINK-12211][table-planner-blink] Add more it cases to blink batch URL: https://github.com/apache/flink/pull/8184#issuecomment-483947351 @wuchong Deduplicated cases and move some ITCases to expression test and Merge Class to Accelerate Testing

[GitHub] [flink] zhijiangW commented on issue #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes

2019-04-16 Thread GitBox
zhijiangW commented on issue #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes URL: https://github.com/apache/flink/pull/8181#issuecomment-483946313 After further thinking through this issue, the current created local/remote counter

[GitHub] [flink] JingsongLi commented on issue #8184: [FLINK-12211][table-planner-blink] Add more it cases to blink batch

2019-04-16 Thread GitBox
JingsongLi commented on issue #8184: [FLINK-12211][table-planner-blink] Add more it cases to blink batch URL: https://github.com/apache/flink/pull/8184#issuecomment-483933526 > The changes to lpad and rpad looks good to me. > > Btw, I would suggest to move tests in

[GitHub] [flink] flinkbot commented on issue #8192: [FLINK-12217][table] OperationTreeBuilder.map() should perform ExpressionResolver.resolve()

2019-04-16 Thread GitBox
flinkbot commented on issue #8192: [FLINK-12217][table] OperationTreeBuilder.map() should perform ExpressionResolver.resolve() URL: https://github.com/apache/flink/pull/8192#issuecomment-483933291 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help

[jira] [Updated] (FLINK-12217) OperationTreeBuilder.map() should perform ExpressionResolver.resolve()

2019-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12217: --- Labels: pull-request-available (was: ) > OperationTreeBuilder.map() should perform

[GitHub] [flink] hequn8128 opened a new pull request #8192: [FLINK-12217][table] OperationTreeBuilder.map() should perform ExpressionResolver.resolve()

2019-04-16 Thread GitBox
hequn8128 opened a new pull request #8192: [FLINK-12217][table] OperationTreeBuilder.map() should perform ExpressionResolver.resolve() URL: https://github.com/apache/flink/pull/8192 ## What is the purpose of the change This pull request fixes the problem for

[GitHub] [flink] JingsongLi commented on a change in pull request #8184: [FLINK-12211][table-planner-blink] Add more it cases to blink batch

2019-04-16 Thread GitBox
JingsongLi commented on a change in pull request #8184: [FLINK-12211][table-planner-blink] Add more it cases to blink batch URL: https://github.com/apache/flink/pull/8184#discussion_r276075315 ## File path:

[GitHub] [flink] zhijiangW commented on issue #8191: [FLINK-12213][network] Pass TaskManagerMetricGroup into constructor of NetworkEnvironment

2019-04-16 Thread GitBox
zhijiangW commented on issue #8191: [FLINK-12213][network] Pass TaskManagerMetricGroup into constructor of NetworkEnvironment URL: https://github.com/apache/flink/pull/8191#issuecomment-483932037 Considering my above comments, I added the `TaskManagerMetricGroup#close` during

[jira] [Created] (FLINK-12217) OperationTreeBuilder.map() should perform ExpressionResolver.resolve()

2019-04-16 Thread Hequn Cheng (JIRA)
Hequn Cheng created FLINK-12217: --- Summary: OperationTreeBuilder.map() should perform ExpressionResolver.resolve() Key: FLINK-12217 URL: https://issues.apache.org/jira/browse/FLINK-12217 Project: Flink

[jira] [Commented] (FLINK-12189) Fix bugs and typos in memory management related code

2019-04-16 Thread Liya Fan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819706#comment-16819706 ] Liya Fan commented on FLINK-12189: -- To make the PR easier to understand to review, I have split the

[jira] [Updated] (FLINK-11915) DataInputViewStream skip returns wrong value

2019-04-16 Thread Biao Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Biao Liu updated FLINK-11915: - Affects Version/s: 1.6.3 1.6.4 1.7.2

[jira] [Created] (FLINK-12216) Respect the number of bytes from input parameters in HybridMemorySegment

2019-04-16 Thread Liya Fan (JIRA)
Liya Fan created FLINK-12216: Summary: Respect the number of bytes from input parameters in HybridMemorySegment Key: FLINK-12216 URL: https://issues.apache.org/jira/browse/FLINK-12216 Project: Flink

[jira] [Assigned] (FLINK-11915) DataInputViewStream skip returns wrong value

2019-04-16 Thread Biao Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Biao Liu reassigned FLINK-11915: Assignee: Biao Liu > DataInputViewStream skip returns wrong value >

[jira] [Commented] (FLINK-11915) DataInputViewStream skip returns wrong value

2019-04-16 Thread Biao Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819704#comment-16819704 ] Biao Liu commented on FLINK-11915: -- Hi Andrew, Thank you for reporting and analyzing. It's indeed a

[GitHub] [flink] KurtYoung commented on a change in pull request #8176: [FLINK-12192] [table-planner-blink] Add support for generating optimized logical plan for grouping sets and distinct aggregate

2019-04-16 Thread GitBox
KurtYoung commented on a change in pull request #8176: [FLINK-12192] [table-planner-blink] Add support for generating optimized logical plan for grouping sets and distinct aggregate URL: https://github.com/apache/flink/pull/8176#discussion_r276071517 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8176: [FLINK-12192] [table-planner-blink] Add support for generating optimized logical plan for grouping sets and distinct aggregate

2019-04-16 Thread GitBox
KurtYoung commented on a change in pull request #8176: [FLINK-12192] [table-planner-blink] Add support for generating optimized logical plan for grouping sets and distinct aggregate URL: https://github.com/apache/flink/pull/8176#discussion_r276071545 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8184: [FLINK-12211][table-planner-blink] Add more it cases to blink batch

2019-04-16 Thread GitBox
KurtYoung commented on a change in pull request #8184: [FLINK-12211][table-planner-blink] Add more it cases to blink batch URL: https://github.com/apache/flink/pull/8184#discussion_r276068467 ## File path:

[jira] [Closed] (FLINK-12185) Add support for generating optimized logical plan for join on stream

2019-04-16 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-12185. -- Resolution: Fixed Fix Version/s: 1.9.0 fixed in 963799964d83c1e61dd053d50348ceb1df812699 >

[GitHub] [flink] KurtYoung merged pull request #8165: [FLINK-12185] [table-planner-blink] Add support for generating optimized logical plan for join on stream

2019-04-16 Thread GitBox
KurtYoung merged pull request #8165: [FLINK-12185] [table-planner-blink] Add support for generating optimized logical plan for join on stream URL: https://github.com/apache/flink/pull/8165 This is an automated message from

[jira] [Updated] (FLINK-12215) Introduce SqlProcessFunction for blink streaming runtime

2019-04-16 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-12215: Description: Currently, we are heavily using DataStream's {{KeyedProcessFunction}} when implementing

[jira] [Assigned] (FLINK-12215) Introduce SqlProcessFunction for blink streaming runtime

2019-04-16 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-12215: --- Assignee: Jark Wu > Introduce SqlProcessFunction for blink streaming runtime >

[jira] [Created] (FLINK-12215) Introduce SqlProcessFunction for blink streaming runtime

2019-04-16 Thread Jark Wu (JIRA)
Jark Wu created FLINK-12215: --- Summary: Introduce SqlProcessFunction for blink streaming runtime Key: FLINK-12215 URL: https://issues.apache.org/jira/browse/FLINK-12215 Project: Flink Issue Type:

[GitHub] [flink] yanghua commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator

2019-04-16 Thread GitBox
yanghua commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator URL: https://github.com/apache/flink/pull/7571#discussion_r276039489 ## File path:

[GitHub] [flink] liyafan82 commented on issue #8183: [FLINK-12210][Runtime]Fix the bug of redundant removing of '\r'

2019-04-16 Thread GitBox
liyafan82 commented on issue #8183: [FLINK-12210][Runtime]Fix the bug of redundant removing of '\r' URL: https://github.com/apache/flink/pull/8183#issuecomment-483905987 > I think you should add some tests to illustrate the specific situation? Good point. Thanks a lot. I will

[GitHub] [flink] JingsongLi commented on issue #8183: [FLINK-12210][Runtime]Fix the bug of redundant removing of '\r'

2019-04-16 Thread GitBox
JingsongLi commented on issue #8183: [FLINK-12210][Runtime]Fix the bug of redundant removing of '\r' URL: https://github.com/apache/flink/pull/8183#issuecomment-483904353 I think you should add some tests to illustrate the specific situation?

[GitHub] [flink] liyafan82 commented on a change in pull request #8183: [FLINK-12210][Runtime]Fix the bug of redundant removing of '\r'

2019-04-16 Thread GitBox
liyafan82 commented on a change in pull request #8183: [FLINK-12210][Runtime]Fix the bug of redundant removing of '\r' URL: https://github.com/apache/flink/pull/8183#discussion_r276051242 ## File path:

[jira] [Commented] (FLINK-11936) Remove AuxiliaryConverter pull-in from calcite and fix auxiliary converter issue.

2019-04-16 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819636#comment-16819636 ] Rong Rong commented on FLINK-11936: --- Sweet. I also think making it pluggable is a good approach. with

[GitHub] [flink] yanghua commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator

2019-04-16 Thread GitBox
yanghua commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator URL: https://github.com/apache/flink/pull/7571#discussion_r276039489 ## File path:

[GitHub] [flink] yanghua commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator

2019-04-16 Thread GitBox
yanghua commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator URL: https://github.com/apache/flink/pull/7571#discussion_r276036342 ## File path:

[jira] [Commented] (FLINK-12214) Add JobListener to capture job submission process

2019-04-16 Thread Jeff Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819578#comment-16819578 ] Jeff Zhang commented on FLINK-12214: [~till.rohrmann] I think this issue is orthogonal with

[GitHub] [flink] fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source

2019-04-16 Thread GitBox
fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source URL: https://github.com/apache/flink/pull/8064#discussion_r276010581 ## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/ParquetTableSource.java

[GitHub] [flink] fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source

2019-04-16 Thread GitBox
fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source URL: https://github.com/apache/flink/pull/8064#discussion_r276003801 ## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/ParquetTableSource.java

[GitHub] [flink] fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source

2019-04-16 Thread GitBox
fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source URL: https://github.com/apache/flink/pull/8064#discussion_r276004781 ## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/ParquetTableSource.java

[GitHub] [flink] fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source

2019-04-16 Thread GitBox
fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source URL: https://github.com/apache/flink/pull/8064#discussion_r276006730 ## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/ParquetTableSource.java

[GitHub] [flink] fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source

2019-04-16 Thread GitBox
fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source URL: https://github.com/apache/flink/pull/8064#discussion_r276007745 ## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/ParquetTableSource.java

[GitHub] [flink] fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source

2019-04-16 Thread GitBox
fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source URL: https://github.com/apache/flink/pull/8064#discussion_r276004996 ## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/ParquetTableSource.java

[GitHub] [flink] fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source

2019-04-16 Thread GitBox
fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source URL: https://github.com/apache/flink/pull/8064#discussion_r275995942 ## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/ParquetTableSource.java

[GitHub] [flink] fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source

2019-04-16 Thread GitBox
fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source URL: https://github.com/apache/flink/pull/8064#discussion_r276003882 ## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/ParquetTableSource.java

[GitHub] [flink] fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source

2019-04-16 Thread GitBox
fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source URL: https://github.com/apache/flink/pull/8064#discussion_r276003116 ## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/ParquetTableSource.java

[GitHub] [flink] fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source

2019-04-16 Thread GitBox
fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source URL: https://github.com/apache/flink/pull/8064#discussion_r276006622 ## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/ParquetTableSource.java

[GitHub] [flink] fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source

2019-04-16 Thread GitBox
fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source URL: https://github.com/apache/flink/pull/8064#discussion_r276002130 ## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/ParquetTableSource.java

[GitHub] [flink] fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source

2019-04-16 Thread GitBox
fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source URL: https://github.com/apache/flink/pull/8064#discussion_r275987317 ## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/ParquetTableSource.java

[GitHub] [flink] fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source

2019-04-16 Thread GitBox
fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source URL: https://github.com/apache/flink/pull/8064#discussion_r275994159 ## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/ParquetTableSource.java

[GitHub] [flink] fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source

2019-04-16 Thread GitBox
fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source URL: https://github.com/apache/flink/pull/8064#discussion_r275991752 ## File path: flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/ParquetTableSourceITCase.java

[GitHub] [flink] fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source

2019-04-16 Thread GitBox
fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source URL: https://github.com/apache/flink/pull/8064#discussion_r275999431 ## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/ParquetTableSource.java

[GitHub] [flink] fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source

2019-04-16 Thread GitBox
fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source URL: https://github.com/apache/flink/pull/8064#discussion_r275988055 ## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/ParquetTableSource.java

[GitHub] [flink] fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source

2019-04-16 Thread GitBox
fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source URL: https://github.com/apache/flink/pull/8064#discussion_r275985795 ## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/ParquetTableSource.java

[GitHub] [flink] fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source

2019-04-16 Thread GitBox
fhueske commented on a change in pull request #8064: [FLINK-7244] Add parquet table source URL: https://github.com/apache/flink/pull/8064#discussion_r275994008 ## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/ParquetTableSource.java

[jira] [Comment Edited] (FLINK-11974) Introduce StreamOperatorSubstitutor to help table perform the whole Operator CodeGen

2019-04-16 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819287#comment-16819287 ] Piotr Nowojski edited comment on FLINK-11974 at 4/16/19 7:08 PM: - I've

[jira] [Commented] (FLINK-8801) S3's eventual consistent read-after-write may fail yarn deployment of resources to S3

2019-04-16 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819326#comment-16819326 ] Steve Loughran commented on FLINK-8801: --- * s3a in hadoop 3.1+ lets you see etags as the file

[jira] [Commented] (FLINK-8801) S3's eventual consistent read-after-write may fail yarn deployment of resources to S3

2019-04-16 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819324#comment-16819324 ] Steve Loughran commented on FLINK-8801: --- we cant set times against objects as they are fixed on

[jira] [Commented] (FLINK-12214) Add JobListener to capture job submission process

2019-04-16 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819318#comment-16819318 ] Till Rohrmann commented on FLINK-12214: --- I think what you need is a better programmatic job

[jira] [Comment Edited] (FLINK-11974) Introduce StreamOperatorSubstitutor to help table perform the whole Operator CodeGen

2019-04-16 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819287#comment-16819287 ] Piotr Nowojski edited comment on FLINK-11974 at 4/16/19 5:14 PM: - I've

[jira] [Commented] (FLINK-11974) Introduce StreamOperatorSubstitutor to help table perform the whole Operator CodeGen

2019-04-16 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819287#comment-16819287 ] Piotr Nowojski commented on FLINK-11974: I've done a little bit more research and simplified

[jira] [Closed] (FLINK-12195) Incorrect resource time setting causes flink to fail to submit

2019-04-16 Thread tangshangwen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] tangshangwen closed FLINK-12195. Resolution: Resolved > Incorrect resource time setting causes flink to fail to submit >

[GitHub] [flink] haf edited a comment on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-04-16 Thread GitBox
haf edited a comment on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#issuecomment-481330654 When I run this code with Flink 1.7, I get this critical error when things crash:

[GitHub] [flink] haf edited a comment on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-04-16 Thread GitBox
haf edited a comment on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#issuecomment-483549547 @becketqin Hi! Any progress? @Xeli Can you e-mail me the other connector

[GitHub] [flink] xuefuz commented on issue #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-16 Thread GitBox
xuefuz commented on issue #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#issuecomment-483756077 PR is updated based on above discussions: 1. Changed existing exceptions to checked and added a

[GitHub] [flink] zhijiangW edited a comment on issue #8191: [FLINK-12213][network] Pass TaskManagerMetricGroup into constructor of NetworkEnvironment

2019-04-16 Thread GitBox
zhijiangW edited a comment on issue #8191: [FLINK-12213][network] Pass TaskManagerMetricGroup into constructor of NetworkEnvironment URL: https://github.com/apache/flink/pull/8191#issuecomment-483745947 I would double check whether the `TaskManagerMetricGroup` should be closed in

[GitHub] [flink] zhijiangW commented on issue #8191: [FLINK-12213][network] Pass TaskManagerMetricGroup into constructor of NetworkEnvironment

2019-04-16 Thread GitBox
zhijiangW commented on issue #8191: [FLINK-12213][network] Pass TaskManagerMetricGroup into constructor of NetworkEnvironment URL: https://github.com/apache/flink/pull/8191#issuecomment-483745947 I would double check whether the `TaskManagerMetricGroup` should be close in

[GitHub] [flink] flinkbot commented on issue #8191: [FLINK-12213][network] Pass TaskManagerMetricGroup into constructor of NetworkEnvironment

2019-04-16 Thread GitBox
flinkbot commented on issue #8191: [FLINK-12213][network] Pass TaskManagerMetricGroup into constructor of NetworkEnvironment URL: https://github.com/apache/flink/pull/8191#issuecomment-483741002 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the

[GitHub] [flink] walterddr commented on a change in pull request #8186: [FLINK-12198] Flink JDBC Connector: Update existing JDBCInputFormat t…

2019-04-16 Thread GitBox
walterddr commented on a change in pull request #8186: [FLINK-12198] Flink JDBC Connector: Update existing JDBCInputFormat t… URL: https://github.com/apache/flink/pull/8186#discussion_r275889475 ## File path:

[GitHub] [flink] flinkbot edited a comment on issue #8191: [FLINK-12213][network] Pass TaskManagerMetricGroup into constructor of NetworkEnvironment

2019-04-16 Thread GitBox
flinkbot edited a comment on issue #8191: [FLINK-12213][network] Pass TaskManagerMetricGroup into constructor of NetworkEnvironment URL: https://github.com/apache/flink/pull/8191#issuecomment-483741002 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I

[GitHub] [flink] zhijiangW commented on issue #8191: [FLINK-12213][network] Pass TaskManagerMetricGroup into constructor of NetworkEnvironment

2019-04-16 Thread GitBox
zhijiangW commented on issue #8191: [FLINK-12213][network] Pass TaskManagerMetricGroup into constructor of NetworkEnvironment URL: https://github.com/apache/flink/pull/8191#issuecomment-483740462 @flinkbot attention @azagrebin

[jira] [Updated] (FLINK-12213) Pass TaskManagerMetricGroup into constructor of NetworkEnvironment

2019-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12213: --- Labels: pull-request-available (was: ) > Pass TaskManagerMetricGroup into constructor of

[GitHub] [flink] zhijiangW opened a new pull request #8191: [FLINK-12213][network] Pass TaskManagerMetricGroup into constructor of NetworkEnvironment

2019-04-16 Thread GitBox
zhijiangW opened a new pull request #8191: [FLINK-12213][network] Pass TaskManagerMetricGroup into constructor of NetworkEnvironment URL: https://github.com/apache/flink/pull/8191 ## What is the purpose of the change *At the moment `NetworkEnvironment#getNetworkBufferPool` is called

[GitHub] [flink] shangwen commented on a change in pull request #8189: [FLINK-12195] [YARN] Incorrect resource time setting causes flink to fail to submit

2019-04-16 Thread GitBox
shangwen commented on a change in pull request #8189: [FLINK-12195] [YARN] Incorrect resource time setting causes flink to fail to submit URL: https://github.com/apache/flink/pull/8189#discussion_r275892412 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java

[jira] [Commented] (FLINK-12195) Incorrect resource time setting causes flink to fail to submit

2019-04-16 Thread tangshangwen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819237#comment-16819237 ] tangshangwen commented on FLINK-12195: -- Thanks [~till.rohrmann]! > Incorrect resource time setting

[jira] [Updated] (FLINK-12214) Add JobListener to capture job submission process

2019-04-16 Thread Jeff Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Zhang updated FLINK-12214: --- Description: Third party library would like to add some hook when submitting jobs. So it would be

[jira] [Comment Edited] (FLINK-12214) Add JobListener to capture job submission process

2019-04-16 Thread Jeff Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819215#comment-16819215 ] Jeff Zhang edited comment on FLINK-12214 at 4/16/19 4:22 PM: - Thanks for the

[jira] [Comment Edited] (FLINK-12214) Add JobListener to capture job submission process

2019-04-16 Thread Jeff Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819215#comment-16819215 ] Jeff Zhang edited comment on FLINK-12214 at 4/16/19 4:18 PM: - Thanks for the

[jira] [Commented] (FLINK-12195) Incorrect resource time setting causes flink to fail to submit

2019-04-16 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819216#comment-16819216 ] Till Rohrmann commented on FLINK-12195: --- Caused by changes introduced with FLINK-8801 > Incorrect

[jira] [Updated] (FLINK-12214) Add JobListener to capture job submission process

2019-04-16 Thread Jeff Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Zhang updated FLINK-12214: --- Description: Third party library would like to add some hook when submitting jobs. So it would be

[jira] [Commented] (FLINK-12195) Incorrect resource time setting causes flink to fail to submit

2019-04-16 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819214#comment-16819214 ] Till Rohrmann commented on FLINK-12195: --- The reason why we use the local modification timestamp is

[jira] [Updated] (FLINK-12214) Add JobListener to capture job submission process

2019-04-16 Thread Jeff Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Zhang updated FLINK-12214: --- Description: Third party library would like to add some hook when submitting jobs. So it would be

[jira] [Commented] (FLINK-12214) Add JobListener to capture job submission process

2019-04-16 Thread Jeff Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819215#comment-16819215 ] Jeff Zhang commented on FLINK-12214: Thanks for the comment, [~till.rohrmann]. The background is

[jira] [Updated] (FLINK-12214) Add JobListener to capture job submission process

2019-04-16 Thread Jeff Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Zhang updated FLINK-12214: --- Attachment: image-2019-04-17-00-15-16-750.png > Add JobListener to capture job submission process >

[jira] [Updated] (FLINK-12214) Add JobListener to capture job submission process

2019-04-16 Thread Jeff Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Zhang updated FLINK-12214: --- Description: Third party library would like to add some hook when submitting jobs. So it would be

[jira] [Updated] (FLINK-12195) Incorrect resource time setting causes flink to fail to submit

2019-04-16 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-12195: -- Component/s: FileSystems > Incorrect resource time setting causes flink to fail to submit >

[jira] [Updated] (FLINK-12214) Add JobListener to capture job submission process

2019-04-16 Thread Jeff Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Zhang updated FLINK-12214: --- Description: Third party library would like to add some hook when submitting jobs. So it would be

[jira] [Updated] (FLINK-12214) Add JobListener to capture job submission process

2019-04-16 Thread Jeff Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Zhang updated FLINK-12214: --- Attachment: image-2019-04-17-00-13-15-999.png > Add JobListener to capture job submission process >

[GitHub] [flink] azagrebin commented on a change in pull request #8189: [FLINK-12195] [YARN] Incorrect resource time setting causes flink to fail to submit

2019-04-16 Thread GitBox
azagrebin commented on a change in pull request #8189: [FLINK-12195] [YARN] Incorrect resource time setting causes flink to fail to submit URL: https://github.com/apache/flink/pull/8189#discussion_r275878797 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java

[jira] [Updated] (FLINK-12214) Add JobListener to capture job submission process

2019-04-16 Thread Jeff Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Zhang updated FLINK-12214: --- Attachment: image-2019-04-17-00-11-00-020.png > Add JobListener to capture job submission process >

[GitHub] [flink] StefanRRichter commented on issue #7813: [FLINK-10712] Support to restore state when using RestartPipelinedRegionStrategy

2019-04-16 Thread GitBox
StefanRRichter commented on issue #7813: [FLINK-10712] Support to restore state when using RestartPipelinedRegionStrategy URL: https://github.com/apache/flink/pull/7813#issuecomment-483727807 Will merge when Travis is green.

[jira] [Updated] (FLINK-12214) Add JobListener to capture job submission process

2019-04-16 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-12214: -- Component/s: Runtime / Coordination > Add JobListener to capture job submission process >

[GitHub] [flink] uce commented on issue #8188: [FLINK-11534] [container] Allow ExecutionMode configuration

2019-04-16 Thread GitBox
uce commented on issue #8188: [FLINK-11534] [container] Allow ExecutionMode configuration URL: https://github.com/apache/flink/pull/8188#issuecomment-483725587 Thanks for the quick review. I'll merge this after Travis gives a green light.

[GitHub] [flink] uce commented on a change in pull request #8188: [FLINK-11534] [container] Allow ExecutionMode configuration

2019-04-16 Thread GitBox
uce commented on a change in pull request #8188: [FLINK-11534] [container] Allow ExecutionMode configuration URL: https://github.com/apache/flink/pull/8188#discussion_r275875867 ## File path:

[jira] [Commented] (FLINK-12214) Add JobListener to capture job submission process

2019-04-16 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819182#comment-16819182 ] Till Rohrmann commented on FLINK-12214: --- Before starting working on issues please first reach out

[GitHub] [flink] tillrohrmann closed pull request #8190: [FLINK-12214]. Add JobListener to capture job submission process

2019-04-16 Thread GitBox
tillrohrmann closed pull request #8190: [FLINK-12214]. Add JobListener to capture job submission process URL: https://github.com/apache/flink/pull/8190 This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink] tillrohrmann commented on issue #8190: [FLINK-12214]. Add JobListener to capture job submission process

2019-04-16 Thread GitBox
tillrohrmann commented on issue #8190: [FLINK-12214]. Add JobListener to capture job submission process URL: https://github.com/apache/flink/pull/8190#issuecomment-483724513 @flinkbot disapprove consensus This is an

[GitHub] [flink] StefanRRichter commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator

2019-04-16 Thread GitBox
StefanRRichter commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator URL: https://github.com/apache/flink/pull/7571#discussion_r275792745 ## File path:

[GitHub] [flink] StefanRRichter commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator

2019-04-16 Thread GitBox
StefanRRichter commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator URL: https://github.com/apache/flink/pull/7571#discussion_r275866965 ## File path:

[GitHub] [flink] StefanRRichter commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator

2019-04-16 Thread GitBox
StefanRRichter commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator URL: https://github.com/apache/flink/pull/7571#discussion_r275867693 ## File path:

[GitHub] [flink] StefanRRichter commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator

2019-04-16 Thread GitBox
StefanRRichter commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator URL: https://github.com/apache/flink/pull/7571#discussion_r275870218 ## File path:

[GitHub] [flink] StefanRRichter commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator

2019-04-16 Thread GitBox
StefanRRichter commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator URL: https://github.com/apache/flink/pull/7571#discussion_r275791905 ## File path:

[GitHub] [flink] StefanRRichter commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator

2019-04-16 Thread GitBox
StefanRRichter commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator URL: https://github.com/apache/flink/pull/7571#discussion_r275867130 ## File path:

[GitHub] [flink] StefanRRichter commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator

2019-04-16 Thread GitBox
StefanRRichter commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator URL: https://github.com/apache/flink/pull/7571#discussion_r275867364 ## File path:

[GitHub] [flink] StefanRRichter commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator

2019-04-16 Thread GitBox
StefanRRichter commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator URL: https://github.com/apache/flink/pull/7571#discussion_r275871911 ## File path:

[GitHub] [flink] StefanRRichter commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator

2019-04-16 Thread GitBox
StefanRRichter commented on a change in pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator URL: https://github.com/apache/flink/pull/7571#discussion_r275868835 ## File path:

[GitHub] [flink] zjffdu commented on issue #8190: [FLINK-12214]. Add JobListener to capture job submission process

2019-04-16 Thread GitBox
zjffdu commented on issue #8190: [FLINK-12214]. Add JobListener to capture job submission process URL: https://github.com/apache/flink/pull/8190#issuecomment-483720812 @StephanEwen @tillrohrmann Could you help review this ? Thanks

  1   2   3   >