[GitHub] [flink] zhijiangW commented on issue #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes

2019-04-25 Thread GitBox
zhijiangW commented on issue #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes URL: https://github.com/apache/flink/pull/8181#issuecomment-486947869 Thanks for further review @azagrebin . I have pushed one fixup commit for addressing ab

[GitHub] [flink] lamber-ken edited a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-25 Thread GitBox
lamber-ken edited a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-486945344 @tillrohrmann, I have a new idea to fix the bug. The most essential reason

[jira] [Commented] (FLINK-12330) Add integrated Tox for ensuring compatibility with the python2/3 version

2019-04-25 Thread Fokko Driesprong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826702#comment-16826702 ] Fokko Driesprong commented on FLINK-12330: -- My personal preference is using Doc

[GitHub] [flink] lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-25 Thread GitBox
lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-486945344 @tillrohrmann, I have a new idea to fix the bug. The most essential reason is when

[jira] [Assigned] (FLINK-12333) Add documentation around save point with cancel lifecycle through REST

2019-04-25 Thread Yun Tang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang reassigned FLINK-12333: Assignee: Yun Tang > Add documentation around save point with cancel lifecycle through REST > --

[jira] [Commented] (FLINK-10929) Add support for Apache Arrow

2019-04-25 Thread Liya Fan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826677#comment-16826677 ] Liya Fan commented on FLINK-10929: -- HiĀ [Stephan Ewen|https://issues.apache.org/jira/se

[jira] [Assigned] (FLINK-12330) Add integrated Tox for ensuring compatibility with the python2/3 version

2019-04-25 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng reassigned FLINK-12330: --- Assignee: sunjincheng > Add integrated Tox for ensuring compatibility with the python2/3 ve

[jira] [Updated] (FLINK-12328) Invalid Express

2019-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12328: --- Labels: pull-request-available (was: ) > Invalid Express > --- > >

[GitHub] [flink] happyer closed pull request #8270: [FLINK-12328][test] remove invalid expression

2019-04-25 Thread GitBox
happyer closed pull request #8270: [FLINK-12328][test] remove invalid expression URL: https://github.com/apache/flink/pull/8270 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [flink] sunjincheng121 commented on issue #8225: FLINK-10984]Remove flink-shaded-hadoop from flink

2019-04-25 Thread GitBox
sunjincheng121 commented on issue #8225: FLINK-10984]Remove flink-shaded-hadoop from flink URL: https://github.com/apache/flink/pull/8225#issuecomment-486937897 Thanks for your Review @zentol! I have had updated the PR accordingly. And about download the `uber` JRA, I think your r

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8225: FLINK-10984]Remove flink-shaded-hadoop from flink

2019-04-25 Thread GitBox
sunjincheng121 commented on a change in pull request #8225: FLINK-10984]Remove flink-shaded-hadoop from flink URL: https://github.com/apache/flink/pull/8225#discussion_r278817480 ## File path: flink-dist/pom.xml ## @@ -428,9 +411,6 @@ under the License.

[GitHub] [flink] KurtYoung commented on a change in pull request #8275: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
KurtYoung commented on a change in pull request #8275: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8275#discussion_r278815850 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogFuncti

[GitHub] [flink] KurtYoung commented on a change in pull request #8275: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
KurtYoung commented on a change in pull request #8275: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8275#discussion_r278816704 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ReadableWrita

[GitHub] [flink] KurtYoung commented on a change in pull request #8275: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
KurtYoung commented on a change in pull request #8275: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8275#discussion_r278815825 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogFuncti

[GitHub] [flink] KurtYoung commented on a change in pull request #8275: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
KurtYoung commented on a change in pull request #8275: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8275#discussion_r278816869 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/GenericInMe

[GitHub] [flink] KurtYoung commented on a change in pull request #8275: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
KurtYoung commented on a change in pull request #8275: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8275#discussion_r278816442 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ReadableWrita

[GitHub] [flink] zhijiangW commented on issue #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment

2019-04-25 Thread GitBox
zhijiangW commented on issue #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment URL: https://github.com/apache/flink/pull/7822#issuecomment-486936180 I have pushed new fixup commit for addressing above comments. For the refactor

[GitHub] [flink] zhijiangW edited a comment on issue #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment

2019-04-25 Thread GitBox
zhijiangW edited a comment on issue #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment URL: https://github.com/apache/flink/pull/7822#issuecomment-486936180 Thanks for further review @azagrebin . I have pushed a new fixup commit f

[jira] [Closed] (FLINK-12328) Invalid Express

2019-04-25 Thread chauncy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chauncy closed FLINK-12328. --- Resolution: Invalid > Invalid Express > --- > > Key: FLINK-12328 >

[GitHub] [flink] zhijiangW commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment

2019-04-25 Thread GitBox
zhijiangW commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment URL: https://github.com/apache/flink/pull/7822#discussion_r278806215 ## File path: flink-runtime/src/main/java/org/apache/fli

[GitHub] [flink] zhijiangW commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment

2019-04-25 Thread GitBox
zhijiangW commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment URL: https://github.com/apache/flink/pull/7822#discussion_r278804998 ## File path: flink-runtime/src/test/java/org/apache/fli

[GitHub] [flink] xuefuz commented on issue #8275: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
xuefuz commented on issue #8275: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8275#issuecomment-486919103 This is to replace PR https://github.com/apache/flink/pull/8212. cc: @JingsongLi @KurtYoung --

[jira] [Commented] (FLINK-11974) Introduce StreamOperatorFactory to help table perform the whole Operator CodeGen

2019-04-25 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826621#comment-16826621 ] Kurt Young commented on FLINK-11974: Regarding #2: I'm wondering why we want to git

[GitHub] [flink] zhijiangW commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment

2019-04-25 Thread GitBox
zhijiangW commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment URL: https://github.com/apache/flink/pull/7822#discussion_r278800356 ## File path: flink-runtime/src/test/java/org/apache/fli

[GitHub] [flink] xuefuz commented on issue #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
xuefuz commented on issue #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212#issuecomment-486913258 I had to rebase my fork to resolve the conflicts. Doing so, however, I had to do a forced push, which avoided this PR. I created a n

[GitHub] [flink] flinkbot commented on issue #8275: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
flinkbot commented on issue #8275: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8275#issuecomment-486912987 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull req

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-25 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r278782559 ## File path: docs/dev/table/tableApi.md ##

[GitHub] [flink] xuefuz opened a new pull request #8275: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
xuefuz opened a new pull request #8275: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8275 ## What is the purpose of the change As a followup for FLINK-11474 and its PR#8007, this PR adds additional catalog APIs for function

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-25 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r278796916 ## File path: flink-python/flink-python-tab

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-25 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r278795877 ## File path: flink-python/flink-python-tabl

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-25 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r278782653 ## File path: flink-python/flink-python-tabl

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-25 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r278793531 ## File path: flink-python/flink-python-tabl

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-25 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r278793705 ## File path: flink-python/flink-python-tabl

[jira] [Commented] (FLINK-12319) StackOverFlowError in cep.nfa.sharedbuffer.SharedBuffer

2019-04-25 Thread Liya Fan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826610#comment-16826610 ] Liya Fan commented on FLINK-12319: -- Hi [~mpf], thanks again for the additional informat

[GitHub] [flink] Kejian-Li opened a new pull request #8274: [FLIKN-12306][Runtime] Change the name of variable log into LOG

2019-04-25 Thread GitBox
Kejian-Li opened a new pull request #8274: [FLIKN-12306][Runtime] Change the name of variable log into LOG URL: https://github.com/apache/flink/pull/8274 ## What is the purpose of the change A trivial improvement that changes the name of variable "log" into "LOG" to corr

[GitHub] [flink] flinkbot commented on issue #8274: [FLIKN-12306][Runtime] Change the name of variable log into LOG

2019-04-25 Thread GitBox
flinkbot commented on issue #8274: [FLIKN-12306][Runtime] Change the name of variable log into LOG URL: https://github.com/apache/flink/pull/8274#issuecomment-486910585 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your

[jira] [Commented] (FLINK-11935) Remove DateTimeUtils pull-in and fix datetime casting problem

2019-04-25 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826608#comment-16826608 ] vinoyang commented on FLINK-11935: -- Yes, what do you think? > Remove DateTimeUtils pul

[jira] [Commented] (FLINK-12334) change to MockStreamTask breaks OneInputStreamOperatorTestHarness

2019-04-25 Thread Liya Fan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826606#comment-16826606 ] Liya Fan commented on FLINK-12334: -- Hi [~cre...@gmail.com], thanks for opening this iss

[jira] [Commented] (FLINK-11611) Translate the "Batch Examples" page into Chinese

2019-04-25 Thread Xin Ma (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826605#comment-16826605 ] Xin Ma commented on FLINK-11611: Hi [~jark] I have completed the first translation. >

[jira] [Comment Edited] (FLINK-11935) Remove DateTimeUtils pull-in and fix datetime casting problem

2019-04-25 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826601#comment-16826601 ] Rong Rong edited comment on FLINK-11935 at 4/26/19 2:57 AM:

[jira] [Commented] (FLINK-11935) Remove DateTimeUtils pull-in and fix datetime casting problem

2019-04-25 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826601#comment-16826601 ] Rong Rong commented on FLINK-11935: --- hmm. I might've misunderstood some details. Are

[jira] [Commented] (FLINK-11935) Remove DateTimeUtils pull-in and fix datetime casting problem

2019-04-25 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826599#comment-16826599 ] vinoyang commented on FLINK-11935: -- Hi [~walterddr] Actually, my idea is to keep it as

[GitHub] [flink] shixiaogang commented on issue #8269: [FLINK-12285][test] Harden savepoint relevant test cases by explicitly canceling test job

2019-04-25 Thread GitBox
shixiaogang commented on issue #8269: [FLINK-12285][test] Harden savepoint relevant test cases by explicitly canceling test job URL: https://github.com/apache/flink/pull/8269#issuecomment-486906606 > most of these should have no positive effect since the `MiniClusterResource` is shut down

[jira] [Updated] (FLINK-11611) Translate the "Batch Examples" page into Chinese

2019-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11611: --- Labels: pull-request-available (was: ) > Translate the "Batch Examples" page into Chinese >

[GitHub] [flink] flinkbot commented on issue #8273: [FLINK-11611] [docs] Translate the "Batch Examples" page into Chinese

2019-04-25 Thread GitBox
flinkbot commented on issue #8273: [FLINK-11611] [docs] Translate the "Batch Examples" page into Chinese URL: https://github.com/apache/flink/pull/8273#issuecomment-486905909 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to revie

[GitHub] [flink] luvex opened a new pull request #8273: [FLINK-11611] [docs] Translate the "Batch Examples" page into Chinese

2019-04-25 Thread GitBox
luvex opened a new pull request #8273: [FLINK-11611] [docs] Translate the "Batch Examples" page into Chinese URL: https://github.com/apache/flink/pull/8273 ## What is the purpose of the change This pull request translates the batch example page into Chinese. ## Bri

[jira] [Comment Edited] (FLINK-11935) Remove DateTimeUtils pull-in and fix datetime casting problem

2019-04-25 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826516#comment-16826516 ] Rong Rong edited comment on FLINK-11935 at 4/26/19 2:19 AM:

[jira] [Comment Edited] (FLINK-11935) Remove DateTimeUtils pull-in and fix datetime casting problem

2019-04-25 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826516#comment-16826516 ] Rong Rong edited comment on FLINK-11935 at 4/26/19 2:18 AM:

[GitHub] [flink] xuefuz closed pull request #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
xuefuz closed pull request #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [flink] KurtYoung commented on a change in pull request #8179: [FLINK-12200] [Table-planner] Support UNNEST for MAP types

2019-04-25 Thread GitBox
KurtYoung commented on a change in pull request #8179: [FLINK-12200] [Table-planner] Support UNNEST for MAP types URL: https://github.com/apache/flink/pull/8179#discussion_r278783132 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/util/Explo

[GitHub] [flink] KurtYoung commented on a change in pull request #8179: [FLINK-12200] [Table-planner] Support UNNEST for MAP types

2019-04-25 Thread GitBox
KurtYoung commented on a change in pull request #8179: [FLINK-12200] [Table-planner] Support UNNEST for MAP types URL: https://github.com/apache/flink/pull/8179#discussion_r278782753 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/rules/logi

[GitHub] [flink] Myasuka commented on a change in pull request #8272: [FLINK-12274] Fix documentation to enable Queryable State

2019-04-25 Thread GitBox
Myasuka commented on a change in pull request #8272: [FLINK-12274] Fix documentation to enable Queryable State URL: https://github.com/apache/flink/pull/8272#discussion_r278782171 ## File path: docs/dev/stream/state/queryable_state.md ## @@ -69,10 +69,12 @@ response back t

[GitHub] [flink] Myasuka commented on a change in pull request #8272: [FLINK-12274] Fix documentation to enable Queryable State

2019-04-25 Thread GitBox
Myasuka commented on a change in pull request #8272: [FLINK-12274] Fix documentation to enable Queryable State URL: https://github.com/apache/flink/pull/8272#discussion_r278782171 ## File path: docs/dev/stream/state/queryable_state.md ## @@ -69,10 +69,12 @@ response back t

[GitHub] [flink] Myasuka commented on a change in pull request #8272: [FLINK-12274] Fix documentation to enable Queryable State

2019-04-25 Thread GitBox
Myasuka commented on a change in pull request #8272: [FLINK-12274] Fix documentation to enable Queryable State URL: https://github.com/apache/flink/pull/8272#discussion_r278782170 ## File path: docs/dev/stream/state/queryable_state.md ## @@ -69,10 +69,12 @@ response back t

[GitHub] [flink] JingsongLi commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
JingsongLi commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212#discussion_r278782161 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/GenericCat

[GitHub] [flink] JingsongLi commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
JingsongLi commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212#discussion_r278782143 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/GenericCat

[GitHub] [flink] tianchen92 commented on issue #8219: [FLINK-10441]Don't log warning when creating upload directory

2019-04-25 Thread GitBox
tianchen92 commented on issue #8219: [FLINK-10441]Don't log warning when creating upload directory URL: https://github.com/apache/flink/pull/8219#issuecomment-486890525 Thanks for your reply @zentol, I have resolved the comments, please have a look. --

[GitHub] [flink] flinkbot edited a comment on issue #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
flinkbot edited a comment on issue #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212#issuecomment-484544644 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your p

[GitHub] [flink] JingsongLi commented on issue #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
JingsongLi commented on issue #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212#issuecomment-486890255 @xuefuz please resolve the conflicts This is an automated messa

[GitHub] [flink] JingsongLi commented on issue #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
JingsongLi commented on issue #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212#issuecomment-486890214 @flinkbot attention @KurtYoung This is an automated message f

[GitHub] [flink] flinkbot edited a comment on issue #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-25 Thread GitBox
flinkbot edited a comment on issue #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#issuecomment-486582161 Thanks a lot for your contribution to the Apache Flink project. I'm th

[jira] [Commented] (FLINK-11935) Remove DateTimeUtils pull-in and fix datetime casting problem

2019-04-25 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826516#comment-16826516 ] Rong Rong commented on FLINK-11935: --- Hi [~yanghua], I understand what you said. I thin

[GitHub] [flink] flinkbot commented on issue #8272: [FLINK-12274] Fix documentation to enable Queryable State

2019-04-25 Thread GitBox
flinkbot commented on issue #8272: [FLINK-12274] Fix documentation to enable Queryable State URL: https://github.com/apache/flink/pull/8272#issuecomment-486846727 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull

[jira] [Updated] (FLINK-12274) Fix documentation to enable Queryable State

2019-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12274: --- Labels: pull-request-available (was: ) > Fix documentation to enable Queryable State >

[GitHub] [flink] PierreZ opened a new pull request #8272: [FLINK-12274] Fix documentation to enable Queryable State

2019-04-25 Thread GitBox
PierreZ opened a new pull request #8272: [FLINK-12274] Fix documentation to enable Queryable State URL: https://github.com/apache/flink/pull/8272 ## What is the purpose of the change Queryable state, since 1.8, now need to be enable through configuration. This add the right

[jira] [Created] (FLINK-12334) change to MockStreamTask breaks OneInputStreamOperatorTestHarness

2019-04-25 Thread Cliff Resnick (JIRA)
Cliff Resnick created FLINK-12334: - Summary: change to MockStreamTask breaks OneInputStreamOperatorTestHarness Key: FLINK-12334 URL: https://issues.apache.org/jira/browse/FLINK-12334 Project: Flink

[GitHub] [flink] xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212#discussion_r278722515 ## File path: flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/GenericInMemor

[GitHub] [flink] xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212#discussion_r278722430 ## File path: flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/GenericInMemor

[GitHub] [flink] xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212#discussion_r278722342 ## File path: flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/GenericInMemor

[GitHub] [flink] xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212#discussion_r278722293 ## File path: flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/GenericInMemor

[GitHub] [flink] xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212#discussion_r278722212 ## File path: flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/GenericInMemor

[GitHub] [flink] xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212#discussion_r278721994 ## File path: flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/GenericInMemor

[GitHub] [flink] xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212#discussion_r278721918 ## File path: flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/GenericInMemor

[GitHub] [flink] xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212#discussion_r278720766 ## File path: flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/GenericInMemor

[GitHub] [flink] bowenli86 commented on issue #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module

2019-04-25 Thread GitBox
bowenli86 commented on issue #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module URL: https://github.com/apache/flink/pull/8205#issuecomment-486795425 Thanks @zentol for the feedbacks! I've addressed them by b

[GitHub] [flink] lamber-ken commented on a change in pull request #8268: [FLINK-12246][runtime] Fix can't get max_attempts_history_size value when create ExecutionVertex

2019-04-25 Thread GitBox
lamber-ken commented on a change in pull request #8268: [FLINK-12246][runtime] Fix can't get max_attempts_history_size value when create ExecutionVertex URL: https://github.com/apache/flink/pull/8268#discussion_r278663085 ## File path: flink-runtime/src/main/java/org/apache/flink/r

[GitHub] [flink] lamber-ken commented on a change in pull request #8268: [FLINK-12246][runtime] Fix can't get max_attempts_history_size value when create ExecutionVertex

2019-04-25 Thread GitBox
lamber-ken commented on a change in pull request #8268: [FLINK-12246][runtime] Fix can't get max_attempts_history_size value when create ExecutionVertex URL: https://github.com/apache/flink/pull/8268#discussion_r278663085 ## File path: flink-runtime/src/main/java/org/apache/flink/r

[GitHub] [flink] lamber-ken commented on a change in pull request #8268: [FLINK-12246][runtime] Fix can't get max_attempts_history_size value when create ExecutionVertex

2019-04-25 Thread GitBox
lamber-ken commented on a change in pull request #8268: [FLINK-12246][runtime] Fix can't get max_attempts_history_size value when create ExecutionVertex URL: https://github.com/apache/flink/pull/8268#discussion_r278663085 ## File path: flink-runtime/src/main/java/org/apache/flink/r

[GitHub] [flink] lamber-ken commented on a change in pull request #8268: [FLINK-12246][runtime] Fix can't get max_attempts_history_size value when create ExecutionVertex

2019-04-25 Thread GitBox
lamber-ken commented on a change in pull request #8268: [FLINK-12246][runtime] Fix can't get max_attempts_history_size value when create ExecutionVertex URL: https://github.com/apache/flink/pull/8268#discussion_r278663085 ## File path: flink-runtime/src/main/java/org/apache/flink/r

[GitHub] [flink] lamber-ken commented on a change in pull request #8268: [FLINK-12246][runtime] Fix can't get max_attempts_history_size value when create ExecutionVertex

2019-04-25 Thread GitBox
lamber-ken commented on a change in pull request #8268: [FLINK-12246][runtime] Fix can't get max_attempts_history_size value when create ExecutionVertex URL: https://github.com/apache/flink/pull/8268#discussion_r278663085 ## File path: flink-runtime/src/main/java/org/apache/flink/r

[GitHub] [flink] bowenli86 commented on a change in pull request #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module

2019-04-25 Thread GitBox
bowenli86 commented on a change in pull request #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module URL: https://github.com/apache/flink/pull/8205#discussion_r278654915 ## File path: flink-connectors/f

[GitHub] [flink] bowenli86 commented on a change in pull request #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module

2019-04-25 Thread GitBox
bowenli86 commented on a change in pull request #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module URL: https://github.com/apache/flink/pull/8205#discussion_r278654915 ## File path: flink-connectors/f

[GitHub] [flink] azagrebin commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment

2019-04-25 Thread GitBox
azagrebin commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment URL: https://github.com/apache/flink/pull/7822#discussion_r278627976 ## File path: flink-runtime/src/main/java/org/apache/fli

[GitHub] [flink] azagrebin commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment

2019-04-25 Thread GitBox
azagrebin commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment URL: https://github.com/apache/flink/pull/7822#discussion_r278618535 ## File path: flink-runtime/src/test/java/org/apache/fli

[GitHub] [flink] azagrebin commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment

2019-04-25 Thread GitBox
azagrebin commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment URL: https://github.com/apache/flink/pull/7822#discussion_r278620145 ## File path: flink-runtime/src/test/java/org/apache/fli

[GitHub] [flink] azagrebin commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment

2019-04-25 Thread GitBox
azagrebin commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment URL: https://github.com/apache/flink/pull/7822#discussion_r278636171 ## File path: flink-runtime/src/main/java/org/apache/fli

[GitHub] [flink] art4ul commented on a change in pull request #8179: [FLINK-12200] [Table-planner] Support UNNEST for MAP types

2019-04-25 Thread GitBox
art4ul commented on a change in pull request #8179: [FLINK-12200] [Table-planner] Support UNNEST for MAP types URL: https://github.com/apache/flink/pull/8179#discussion_r278625671 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/rules/logical

[GitHub] [flink] lamber-ken edited a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-25 Thread GitBox
lamber-ken edited a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-486731333 @tillrohrmann, BTW, if you want to get the NPE stacktrace, you need to use

[GitHub] [flink] lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-25 Thread GitBox
lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-486731333 @tillrohrmann, BTW, if you want to get the NPE stacktrace, you need to use log4j a

[GitHub] [flink] azagrebin commented on a change in pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes

2019-04-25 Thread GitBox
azagrebin commented on a change in pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes URL: https://github.com/apache/flink/pull/8181#discussion_r278615592 ## File path: flink-runtime/src/test/java/org/apache/flink/runt

[GitHub] [flink] zhijiangW commented on a change in pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes

2019-04-25 Thread GitBox
zhijiangW commented on a change in pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes URL: https://github.com/apache/flink/pull/8181#discussion_r278614937 ## File path: flink-runtime/src/test/java/org/apache/flink/runt

[GitHub] [flink] lamber-ken removed a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-25 Thread GitBox
lamber-ken removed a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-486716231 @tillrohrmann, here is original NPE stacktrace. ``` java.lang.NullPoi

[GitHub] [flink] lamber-ken edited a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-25 Thread GitBox
lamber-ken edited a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-486714974 hi, @tillrohrmann **First**, the original exception is NPE which as

[GitHub] [flink] lamber-ken edited a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-25 Thread GitBox
lamber-ken edited a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-486714974 hi, @tillrohrmann **First**, the original exception is NPE which as

[GitHub] [flink] zhijiangW commented on a change in pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes

2019-04-25 Thread GitBox
zhijiangW commented on a change in pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes URL: https://github.com/apache/flink/pull/8181#discussion_r278611563 ## File path: flink-runtime/src/main/java/org/apache/flink/runt

[GitHub] [flink] lamber-ken edited a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-25 Thread GitBox
lamber-ken edited a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-486723700 > The `HistoryServerArchivist` is not supposed to throw any exceptions. If

[GitHub] [flink] zhijiangW commented on a change in pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes

2019-04-25 Thread GitBox
zhijiangW commented on a change in pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes URL: https://github.com/apache/flink/pull/8181#discussion_r278610658 ## File path: flink-runtime/src/test/java/org/apache/flink/runt

[GitHub] [flink] zhijiangW commented on a change in pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes

2019-04-25 Thread GitBox
zhijiangW commented on a change in pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes URL: https://github.com/apache/flink/pull/8181#discussion_r278610383 ## File path: flink-runtime/src/test/java/org/apache/flink/runt

[GitHub] [flink] lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-25 Thread GitBox
lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-486723700 > The `HistoryServerArchivist` is not supposed to throw any exceptions. If it does

[GitHub] [flink] TisonKun commented on issue #8264: [hotfix][yarn] userJarFiles can be a local variable

2019-04-25 Thread GitBox
TisonKun commented on issue #8264: [hotfix][yarn] userJarFiles can be a local variable URL: https://github.com/apache/flink/pull/8264#issuecomment-486719685 @tillrohrmann thanks for your review! I accidentally added a force push on this pr. Sorry and please check if conflict :( ---

  1   2   3   >