[jira] [Commented] (FLINK-12329) Netty thread deadlock bug of the SpilledSubpartitionView

2019-04-29 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829036#comment-16829036 ] Stephan Ewen commented on FLINK-12329: -- If we accept FLINK-12070, we don't need to

[jira] [Commented] (FLINK-12070) Make blocking result partitions consumable multiple times

2019-04-29 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829038#comment-16829038 ] Stephan Ewen commented on FLINK-12070: -- [~kevin.cyj] The pull request contains a ne

[GitHub] [flink] azagrebin commented on a change in pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes

2019-04-29 Thread GitBox
azagrebin commented on a change in pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes URL: https://github.com/apache/flink/pull/8181#discussion_r279282819 ## File path: flink-runtime/src/test/java/org/apache/flink/runt

[GitHub] [flink] flinkbot edited a comment on issue #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes

2019-04-29 Thread GitBox
flinkbot edited a comment on issue #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes URL: https://github.com/apache/flink/pull/8181#issuecomment-483518115 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot.

[GitHub] [flink] KurtYoung commented on a change in pull request #8302: [FLINK-12269][table-blink] Support Temporal Table Join in blink planner and runtime

2019-04-29 Thread GitBox
KurtYoung commented on a change in pull request #8302: [FLINK-12269][table-blink] Support Temporal Table Join in blink planner and runtime URL: https://github.com/apache/flink/pull/8302#discussion_r279277541 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apa

[GitHub] [flink] KurtYoung commented on a change in pull request #8302: [FLINK-12269][table-blink] Support Temporal Table Join in blink planner and runtime

2019-04-29 Thread GitBox
KurtYoung commented on a change in pull request #8302: [FLINK-12269][table-blink] Support Temporal Table Join in blink planner and runtime URL: https://github.com/apache/flink/pull/8302#discussion_r279279774 ## File path: flink-table/flink-table-planner-blink/src/test/resources/or

[GitHub] [flink] KurtYoung commented on a change in pull request #8302: [FLINK-12269][table-blink] Support Temporal Table Join in blink planner and runtime

2019-04-29 Thread GitBox
KurtYoung commented on a change in pull request #8302: [FLINK-12269][table-blink] Support Temporal Table Join in blink planner and runtime URL: https://github.com/apache/flink/pull/8302#discussion_r279277736 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/ap

[GitHub] [flink] azagrebin commented on issue #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes

2019-04-29 Thread GitBox
azagrebin commented on issue #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes URL: https://github.com/apache/flink/pull/8181#issuecomment-487504972 @flinkbot approve all @flinkbot attention @zentol ---

[GitHub] [flink] zhijiangW commented on issue #8310: [FLINK-12331][network] Introduce partition/gate setup to decouple task registration with NetworkEnvironment

2019-04-29 Thread GitBox
zhijiangW commented on issue #8310: [FLINK-12331][network] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8310#issuecomment-487502457 @flinkbot attention @azagrebin ---

[jira] [Commented] (FLINK-12070) Make blocking result partitions consumable multiple times

2019-04-29 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829035#comment-16829035 ] Stephan Ewen commented on FLINK-12070: -- [~Ryantaocer] The pages should not be throw

[GitHub] [flink] StefanRRichter commented on a change in pull request #8263: [FLINK-12296][StateBackend]Data loss silently in RocksDBStateBackend because of local directory collision

2019-04-29 Thread GitBox
StefanRRichter commented on a change in pull request #8263: [FLINK-12296][StateBackend]Data loss silently in RocksDBStateBackend because of local directory collision URL: https://github.com/apache/flink/pull/8263#discussion_r279277040 ## File path: flink-state-backends/flink-state

[GitHub] [flink] flinkbot commented on issue #8310: [FLINK-12331][network] Introduce partition/gate setup to decouple task registration with NetworkEnvironment

2019-04-29 Thread GitBox
flinkbot commented on issue #8310: [FLINK-12331][network] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8310#issuecomment-487501946 Thanks a lot for your contribution to the Apache Flink project. I'm the @flin

[jira] [Updated] (FLINK-12331) Introduce partition/gate setup to decouple task registration with NetworkEnvironment

2019-04-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12331: --- Labels: pull-request-available (was: ) > Introduce partition/gate setup to decouple task re

[GitHub] [flink] flinkbot edited a comment on issue #8310: [FLINK-12331][network] Introduce partition/gate setup to decouple task registration with NetworkEnvironment

2019-04-29 Thread GitBox
flinkbot edited a comment on issue #8310: [FLINK-12331][network] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8310#issuecomment-487501946 Thanks a lot for your contribution to the Apache Flink project. I'm the

[GitHub] [flink] StefanRRichter commented on a change in pull request #8263: [FLINK-12296][StateBackend]Data loss silently in RocksDBStateBackend because of local directory collision

2019-04-29 Thread GitBox
StefanRRichter commented on a change in pull request #8263: [FLINK-12296][StateBackend]Data loss silently in RocksDBStateBackend because of local directory collision URL: https://github.com/apache/flink/pull/8263#discussion_r279277040 ## File path: flink-state-backends/flink-state

[GitHub] [flink] zhijiangW opened a new pull request #8310: [FLINK-12331][network] Introduce partition/gate setup to decouple task registration with NetworkEnvironment

2019-04-29 Thread GitBox
zhijiangW opened a new pull request #8310: [FLINK-12331][network] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8310 ## What is the purpose of the change *In order to decouple task with `NetworkEnvironme

[GitHub] [flink] azagrebin commented on issue #8210: [FLINK-12203] Refactor ResultPartitionManager to break tie with Task

2019-04-29 Thread GitBox
azagrebin commented on issue #8210: [FLINK-12203] Refactor ResultPartitionManager to break tie with Task URL: https://github.com/apache/flink/pull/8210#issuecomment-487494179 @tillrohrmann I have pushed fix, I will monitor travis build until it is mergable

[jira] [Commented] (FLINK-12362) Recover container number config option for Flink on yarn job cluster mode in the doc

2019-04-29 Thread Tony Xintong Song (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829029#comment-16829029 ] Tony Xintong Song commented on FLINK-12362: --- Hi, [~yanghua], I don't understa

[GitHub] [flink] azagrebin edited a comment on issue #8210: [FLINK-12203] Refactor ResultPartitionManager to break tie with Task

2019-04-29 Thread GitBox
azagrebin edited a comment on issue #8210: [FLINK-12203] Refactor ResultPartitionManager to break tie with Task URL: https://github.com/apache/flink/pull/8210#issuecomment-487494179 @tillrohrmann thanks for retrying I have pushed fix, I will monitor travis build until it is mergable ---

[GitHub] [flink] StefanRRichter commented on a change in pull request #8263: [FLINK-12296][StateBackend]Data loss silently in RocksDBStateBackend because of local directory collision

2019-04-29 Thread GitBox
StefanRRichter commented on a change in pull request #8263: [FLINK-12296][StateBackend]Data loss silently in RocksDBStateBackend because of local directory collision URL: https://github.com/apache/flink/pull/8263#discussion_r279276307 ## File path: flink-state-backends/flink-state

[jira] [Closed] (FLINK-12350) RocksDBStateBackendTest doesn't cover the incremental checkpoint code path

2019-04-29 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-12350. -- Resolution: Fixed Fix Version/s: 1.8.1 Merged in: master: 9aeb4e5 release-1.8: 80207878

[jira] [Closed] (FLINK-12350) RocksDBStateBackendTest doesn't cover the incremental checkpoint code path

2019-04-29 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-12350. -- Resolution: Fixed Fix Version/s: 1.9.0 Merged in: master: 9aeb4e5 > RocksDBStateBacken

[jira] [Reopened] (FLINK-12350) RocksDBStateBackendTest doesn't cover the incremental checkpoint code path

2019-04-29 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter reopened FLINK-12350: > RocksDBStateBackendTest doesn't cover the incremental checkpoint code path > ---

[jira] [Closed] (FLINK-11167) Optimize RocksDBList#put for no empty input

2019-04-29 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-11167. -- Resolution: Implemented Fix Version/s: 1.9.0 Merged in: master: 03faeb9 > Optimize Roc

[GitHub] [flink] StefanRRichter merged pull request #8297: [FLINK-12350] [State Backends] RocksDBStateBackendTest doesn't cover the incremental checkpoint code path

2019-04-29 Thread GitBox
StefanRRichter merged pull request #8297: [FLINK-12350] [State Backends] RocksDBStateBackendTest doesn't cover the incremental checkpoint code path URL: https://github.com/apache/flink/pull/8297 This is an automated message

[GitHub] [flink] StefanRRichter merged pull request #7421: [FLINK-11167][runtime] Optimize RocksDBListState#Put by removing the clear before put operation when input is not empty

2019-04-29 Thread GitBox
StefanRRichter merged pull request #7421: [FLINK-11167][runtime] Optimize RocksDBListState#Put by removing the clear before put operation when input is not empty URL: https://github.com/apache/flink/pull/7421 This is an aut

[GitHub] [flink] StefanRRichter edited a comment on issue #7571: [FLINK-10724] Refactor failure handling in check point coordinator

2019-04-29 Thread GitBox
StefanRRichter edited a comment on issue #7571: [FLINK-10724] Refactor failure handling in check point coordinator URL: https://github.com/apache/flink/pull/7571#issuecomment-487486777 @yanghua thanks for your work here. I would try to review the remaining parts asap if they become availab

[GitHub] [flink] StefanRRichter commented on issue #7571: [FLINK-10724] Refactor failure handling in check point coordinator

2019-04-29 Thread GitBox
StefanRRichter commented on issue #7571: [FLINK-10724] Refactor failure handling in check point coordinator URL: https://github.com/apache/flink/pull/7571#issuecomment-487486777 @yanghua thanks for your work here. I would try to review the remaining parts asap if the become available. You

[jira] [Commented] (FLINK-12342) Yarn Resource Manager Acquires Too Many Containers

2019-04-29 Thread Zhenqiu Huang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829009#comment-16829009 ] Zhenqiu Huang commented on FLINK-12342: --- [^container.log] [~till.rohrmann] As t

[jira] [Updated] (FLINK-12342) Yarn Resource Manager Acquires Too Many Containers

2019-04-29 Thread Zhenqiu Huang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenqiu Huang updated FLINK-12342: -- Attachment: container.log > Yarn Resource Manager Acquires Too Many Containers > -

[jira] [Updated] (FLINK-12229) Implement Lazy Scheduling Strategy

2019-04-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12229: --- Labels: pull-request-available (was: ) > Implement Lazy Scheduling Strategy > -

[GitHub] [flink] flinkbot commented on issue #8309: [FLINK-12229] [runtime] Implement Lazy from Sources Scheduling Strategy

2019-04-29 Thread GitBox
flinkbot commented on issue #8309: [FLINK-12229] [runtime] Implement Lazy from Sources Scheduling Strategy URL: https://github.com/apache/flink/pull/8309#issuecomment-487486220 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to rev

[GitHub] [flink] eaglewatcherwb opened a new pull request #8309: [FLINK-12229] [runtime] Implement Lazy from Sources Scheduling Strategy

2019-04-29 Thread GitBox
eaglewatcherwb opened a new pull request #8309: [FLINK-12229] [runtime] Implement Lazy from Sources Scheduling Strategy URL: https://github.com/apache/flink/pull/8309 ## What is the purpose of the change *This pull request implements the LAZY_FROM_SOURCES scheduling strategy

[GitHub] [flink] lamber-ken commented on issue #7571: [FLINK-10724] Refactor failure handling in check point coordinator

2019-04-29 Thread GitBox
lamber-ken commented on issue #7571: [FLINK-10724] Refactor failure handling in check point coordinator URL: https://github.com/apache/flink/pull/7571#issuecomment-487484739 @yanghua, :+1: I've been following this issue for a long time. -

[GitHub] [flink] StephanEwen commented on issue #8271: [FLINK-8640][build][travis] Enable japicmp on Java 9

2019-04-29 Thread GitBox
StephanEwen commented on issue #8271: [FLINK-8640][build][travis] Enable japicmp on Java 9 URL: https://github.com/apache/flink/pull/8271#issuecomment-487484329 Looks good. +1 I assume that this seems to be a temporary fix until the Hadoop dependencies are part of `flink-shaded`?

[GitHub] [flink] yanghua commented on issue #7571: [FLINK-10724] Refactor failure handling in check point coordinator

2019-04-29 Thread GitBox
yanghua commented on issue #7571: [FLINK-10724] Refactor failure handling in check point coordinator URL: https://github.com/apache/flink/pull/7571#issuecomment-487485468 @StefanRRichter Thanks for helping me review this PR. I will start the second step as soon as possible. --

[jira] [Closed] (FLINK-10724) Refactor failure handling in check point coordinator

2019-04-29 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-10724. -- Resolution: Done Fix Version/s: 1.9.0 Merged in: master: c4b0e8f > Refactor failure ha

[GitHub] [flink] StefanRRichter merged pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator

2019-04-29 Thread GitBox
StefanRRichter merged pull request #7571: [FLINK-10724] Refactor failure handling in check point coordinator URL: https://github.com/apache/flink/pull/7571 This is an automated message from the Apache Git Service. To respond

[GitHub] [flink] lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-29 Thread GitBox
lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-487482734 Thanks for your review and suggestion @tillrohrmann. I had update the patch, can y

[GitHub] [flink] lamber-ken commented on a change in pull request #8268: [FLINK-12246][runtime] Fix can't get max_attempts_history_size value when create ExecutionVertex

2019-04-29 Thread GitBox
lamber-ken commented on a change in pull request #8268: [FLINK-12246][runtime] Fix can't get max_attempts_history_size value when create ExecutionVertex URL: https://github.com/apache/flink/pull/8268#discussion_r279011761 ## File path: flink-runtime/src/main/java/org/apache/flink/r

[GitHub] [flink] XuQianJin-Stars commented on issue #8276: [FLINK-12314] [docs-zh] Translate the "Type Serialization" page into …

2019-04-29 Thread GitBox
XuQianJin-Stars commented on issue #8276: [FLINK-12314] [docs-zh] Translate the "Type Serialization" page into … URL: https://github.com/apache/flink/pull/8276#issuecomment-487482359 Thank you for your work.The overall translation is very good. -

[GitHub] [flink] XuQianJin-Stars commented on a change in pull request #8276: [FLINK-12314] [docs-zh] Translate the "Type Serialization" page into …

2019-04-29 Thread GitBox
XuQianJin-Stars commented on a change in pull request #8276: [FLINK-12314] [docs-zh] Translate the "Type Serialization" page into … URL: https://github.com/apache/flink/pull/8276#discussion_r279252721 ## File path: docs/dev/types_serialization.zh.md ## @@ -24,180 +24,164 @

[jira] [Commented] (FLINK-12363) Refactor legacy rest handlers

2019-04-29 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16828984#comment-16828984 ] vinoyang commented on FLINK-12363: -- [~Zentol] what do you think? Is there any plan to r

[jira] [Commented] (FLINK-12362) Recover container number config option for Flink on yarn job cluster mode in the doc

2019-04-29 Thread Shaofeng SHI (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16828989#comment-16828989 ] Shaofeng SHI commented on FLINK-12362: -- Agree with Vino; At least I'm confusing whe

[jira] [Created] (FLINK-12363) Refactor legacy rest handlers

2019-04-29 Thread vinoyang (JIRA)
vinoyang created FLINK-12363: Summary: Refactor legacy rest handlers Key: FLINK-12363 URL: https://issues.apache.org/jira/browse/FLINK-12363 Project: Flink Issue Type: Task Components:

[jira] [Commented] (FLINK-12362) Recover container number config option for Flink on yarn job cluster mode in the doc

2019-04-29 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16828961#comment-16828961 ] vinoyang commented on FLINK-12362: -- Hi [~till.rohrmann] What's your opinion? > Recover

[GitHub] [flink] Aitozi commented on a change in pull request #8304: [hotfix]Harden TextInputFormatTest to avoid failure by uncleaned files

2019-04-29 Thread GitBox
Aitozi commented on a change in pull request #8304: [hotfix]Harden TextInputFormatTest to avoid failure by uncleaned files URL: https://github.com/apache/flink/pull/8304#discussion_r279252759 ## File path: flink-java/src/test/java/org/apache/flink/api/java/io/TextInputFormatTest.ja

[GitHub] [flink] zentol commented on a change in pull request #8304: [hotfix]Harden TextInputFormatTest to avoid failure by uncleaned files

2019-04-29 Thread GitBox
zentol commented on a change in pull request #8304: [hotfix]Harden TextInputFormatTest to avoid failure by uncleaned files URL: https://github.com/apache/flink/pull/8304#discussion_r279250579 ## File path: flink-java/src/test/java/org/apache/flink/api/java/io/TextInputFormatTest.ja

[jira] [Closed] (FLINK-12356) Optimise version experssion of flink-shaded-hadoop2(-uber)

2019-04-29 Thread Paul Lin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Lin closed FLINK-12356. Resolution: Won't Fix > Optimise version experssion of flink-shaded-hadoop2(-uber) > -

[jira] [Updated] (FLINK-12362) Recover container number config option for Flink on yarn job cluster mode in the doc

2019-04-29 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang updated FLINK-12362: - Summary: Recover container number config option for Flink on yarn job cluster mode in the doc (was: Add

[jira] [Created] (FLINK-12362) Add container number config option for Flink on yarn job cluster mode

2019-04-29 Thread vinoyang (JIRA)
vinoyang created FLINK-12362: Summary: Add container number config option for Flink on yarn job cluster mode Key: FLINK-12362 URL: https://issues.apache.org/jira/browse/FLINK-12362 Project: Flink

<    1   2   3   4