[GitHub] [flink] twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-05-14 Thread GitBox
twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r284110334 ## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/

[jira] [Commented] (FLINK-6755) Allow triggering Checkpoints through command line client

2019-05-14 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840103#comment-16840103 ] vinoyang commented on FLINK-6755: - Actually, the {{CheckpointConfig#enableExternalizedChe

[GitHub] [flink] WeiZhong94 commented on a change in pull request #8420: [FLINK-12408][python] Allow to define the data types in Python

2019-05-14 Thread GitBox
WeiZhong94 commented on a change in pull request #8420: [FLINK-12408][python] Allow to define the data types in Python URL: https://github.com/apache/flink/pull/8420#discussion_r284109844 ## File path: flink-python/pyflink/table/types.py ## @@ -15,172 +15,1803 @@ # See t

[GitHub] [flink] WeiZhong94 commented on a change in pull request #8420: [FLINK-12408][python] Allow to define the data types in Python

2019-05-14 Thread GitBox
WeiZhong94 commented on a change in pull request #8420: [FLINK-12408][python] Allow to define the data types in Python URL: https://github.com/apache/flink/pull/8420#discussion_r284108056 ## File path: flink-python/pyflink/table/types.py ## @@ -15,172 +15,1803 @@ # See t

[GitHub] [flink] WeiZhong94 commented on a change in pull request #8420: [FLINK-12408][python] Allow to define the data types in Python

2019-05-14 Thread GitBox
WeiZhong94 commented on a change in pull request #8420: [FLINK-12408][python] Allow to define the data types in Python URL: https://github.com/apache/flink/pull/8420#discussion_r284105552 ## File path: flink-python/pyflink/serializers.py ## @@ -0,0 +1,192 @@ +#

[jira] [Commented] (FLINK-12423) Add Timer metric type for flink-metrics module

2019-05-14 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840100#comment-16840100 ] Chesnay Schepler commented on FLINK-12423: -- Which of our currently supported me

[GitHub] [flink] twalthr commented on issue #8420: [FLINK-12408][python] Allow to define the data types in Python

2019-05-14 Thread GitBox
twalthr commented on issue #8420: [FLINK-12408][python] Allow to define the data types in Python URL: https://github.com/apache/flink/pull/8420#issuecomment-492528185 Thanks @dianfu. I would like to take a look soon. We should make the types consistent with the overall type strategy. I alr

[jira] [Commented] (FLINK-9431) Introduce TimeEnd State to flink cep

2019-05-14 Thread aitozi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840097#comment-16840097 ] aitozi commented on FLINK-9431: --- Thanks for your feedback [~dawidwys], I will think over th

[GitHub] [flink] zentol commented on issue #8412: [FLINK-12111][tests] Harden AbstractTaskManagerProcessFailureRecoveryTest

2019-05-14 Thread GitBox
zentol commented on issue #8412: [FLINK-12111][tests] Harden AbstractTaskManagerProcessFailureRecoveryTest URL: https://github.com/apache/flink/pull/8412#issuecomment-492525060 It weakens the test in some regards (as this kind of weird timing issues is no longer covered) but strengthens it

[GitHub] [flink] yanghua commented on issue #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro…

2019-05-14 Thread GitBox
yanghua commented on issue #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro… URL: https://github.com/apache/flink/pull/8439#issuecomment-492524238 @sunjincheng121 There is a very high-frequency test failure in table module may cause the Travis to fail. I have re

[jira] [Closed] (FLINK-12475) CommonTestUtils#printLog4jDebugConfig() should include timestamp

2019-05-14 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-12475. Resolution: Fixed master: b12e37728b701573f58b297ab96984bd63042594 > CommonTestUtils#prin

[GitHub] [flink] zentol merged pull request #8399: [FLINK-12475][tests] Include timestamp in generated log4j config

2019-05-14 Thread GitBox
zentol merged pull request #8399: [FLINK-12475][tests] Include timestamp in generated log4j config URL: https://github.com/apache/flink/pull/8399 This is an automated message from the Apache Git Service. To respond to the me

[jira] [Closed] (FLINK-11922) Support MetricReporter factories

2019-05-14 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-11922. Resolution: Fixed master: e63e4b9667e50c267555b64efa7c77db2d577f5b > Support MetricReport

[GitHub] [flink] dawidwys commented on a change in pull request #8404: [FLINK-11476][table] Create CatalogManager to manage multiple catalogs

2019-05-14 Thread GitBox
dawidwys commented on a change in pull request #8404: [FLINK-11476][table] Create CatalogManager to manage multiple catalogs URL: https://github.com/apache/flink/pull/8404#discussion_r284103981 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/

[GitHub] [flink] zentol merged pull request #8373: [FLINK-11922][metrics] Support MetricReporter factories

2019-05-14 Thread GitBox
zentol merged pull request #8373: [FLINK-11922][metrics] Support MetricReporter factories URL: https://github.com/apache/flink/pull/8373 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [flink] dawidwys commented on a change in pull request #8404: [FLINK-11476][table] Create CatalogManager to manage multiple catalogs

2019-05-14 Thread GitBox
dawidwys commented on a change in pull request #8404: [FLINK-11476][table] Create CatalogManager to manage multiple catalogs URL: https://github.com/apache/flink/pull/8404#discussion_r284103693 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/catal

[jira] [Comment Edited] (FLINK-5243) Implement an example for BipartiteGraph

2019-05-14 Thread Jasleen Kaur (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839939#comment-16839939 ] Jasleen Kaur edited comment on FLINK-5243 at 5/15/19 6:30 AM: -

[GitHub] [flink] dawidwys commented on a change in pull request #8404: [FLINK-11476][table] Create CatalogManager to manage multiple catalogs

2019-05-14 Thread GitBox
dawidwys commented on a change in pull request #8404: [FLINK-11476][table] Create CatalogManager to manage multiple catalogs URL: https://github.com/apache/flink/pull/8404#discussion_r283916005 ## File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/util

[GitHub] [flink] dawidwys commented on a change in pull request #8404: [FLINK-11476][table] Create CatalogManager to manage multiple catalogs

2019-05-14 Thread GitBox
dawidwys commented on a change in pull request #8404: [FLINK-11476][table] Create CatalogManager to manage multiple catalogs URL: https://github.com/apache/flink/pull/8404#discussion_r283916005 ## File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/util

[GitHub] [flink] yanghua commented on a change in pull request #8322: [FLINK-12364] Introduce a CheckpointFailureManager to centralized manage checkpoint failure

2019-05-14 Thread GitBox
yanghua commented on a change in pull request #8322: [FLINK-12364] Introduce a CheckpointFailureManager to centralized manage checkpoint failure URL: https://github.com/apache/flink/pull/8322#discussion_r284102152 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/c

[GitHub] [flink] yanghua commented on a change in pull request #8322: [FLINK-12364] Introduce a CheckpointFailureManager to centralized manage checkpoint failure

2019-05-14 Thread GitBox
yanghua commented on a change in pull request #8322: [FLINK-12364] Introduce a CheckpointFailureManager to centralized manage checkpoint failure URL: https://github.com/apache/flink/pull/8322#discussion_r284102152 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/c

[GitHub] [flink] sunjincheng121 commented on issue #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro…

2019-05-14 Thread GitBox
sunjincheng121 commented on issue #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro… URL: https://github.com/apache/flink/pull/8439#issuecomment-492519737 Will be merged after CI turn green. @flinkbot approve all ---

[GitHub] [flink] sunjincheng121 removed a comment on issue #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro…

2019-05-14 Thread GitBox
sunjincheng121 removed a comment on issue #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro… URL: https://github.com/apache/flink/pull/8439#issuecomment-492519337 Merging... @flinkbot approve all

[GitHub] [flink] sunjincheng121 commented on issue #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro…

2019-05-14 Thread GitBox
sunjincheng121 commented on issue #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro… URL: https://github.com/apache/flink/pull/8439#issuecomment-492519337 Merging... @flinkbot approve all This is

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro…

2019-05-14 Thread GitBox
sunjincheng121 commented on a change in pull request #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro… URL: https://github.com/apache/flink/pull/8439#discussion_r284100035 ## File path: flink-python/pyflink/table/tests/test_table_completeness.py

[jira] [Updated] (FLINK-12400) NullpointerException using SimpleStringSchema with Kafka

2019-05-14 Thread lamber-ken (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lamber-ken updated FLINK-12400: --- Environment: * Flink 1.7.2 job on 1.8 cluster * Kafka 0.10 with a topic in log-compaction was: Fl

[GitHub] [flink] c4emmmm commented on a change in pull request #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib

2019-05-14 Thread GitBox
c4e commented on a change in pull request #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib URL: https://github.com/apache/flink/pull/8402#discussion_r284097593 ## File path: flink-ml/flink-ml-api/pom.xml ## @@ -0,0 +1,45 @@ + + +http://maven.apache.

[GitHub] [flink] danny0405 commented on a change in pull request #8324: [FLINK-11921][table] Upgrade to calcite 1.19

2019-05-14 Thread GitBox
danny0405 commented on a change in pull request #8324: [FLINK-11921][table] Upgrade to calcite 1.19 URL: https://github.com/apache/flink/pull/8324#discussion_r284092827 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/calcite/avatica/util/DateTimeUtils.java #

[GitHub] [flink] danny0405 commented on a change in pull request #8324: [FLINK-11921][table] Upgrade to calcite 1.19

2019-05-14 Thread GitBox
danny0405 commented on a change in pull request #8324: [FLINK-11921][table] Upgrade to calcite 1.19 URL: https://github.com/apache/flink/pull/8324#discussion_r284092533 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql2rel/AuxiliaryConverter.java #

[GitHub] [flink] danny0405 commented on a change in pull request #8324: [FLINK-11921][table] Upgrade to calcite 1.19

2019-05-14 Thread GitBox
danny0405 commented on a change in pull request #8324: [FLINK-11921][table] Upgrade to calcite 1.19 URL: https://github.com/apache/flink/pull/8324#discussion_r284092533 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql2rel/AuxiliaryConverter.java #

[GitHub] [flink] danny0405 commented on a change in pull request #8324: [FLINK-11921][table] Upgrade to calcite 1.19

2019-05-14 Thread GitBox
danny0405 commented on a change in pull request #8324: [FLINK-11921][table] Upgrade to calcite 1.19 URL: https://github.com/apache/flink/pull/8324#discussion_r284092470 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/calcite/avatica/util/DateTimeUtils.java #

[GitHub] [flink] danny0405 commented on a change in pull request #8324: [FLINK-11921][table] Upgrade to calcite 1.19

2019-05-14 Thread GitBox
danny0405 commented on a change in pull request #8324: [FLINK-11921][table] Upgrade to calcite 1.19 URL: https://github.com/apache/flink/pull/8324#discussion_r284092067 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/calcite/avatica/util/DateTimeUtils.java #

[GitHub] [flink] danny0405 commented on a change in pull request #8324: [FLINK-11921][table] Upgrade to calcite 1.19

2019-05-14 Thread GitBox
danny0405 commented on a change in pull request #8324: [FLINK-11921][table] Upgrade to calcite 1.19 URL: https://github.com/apache/flink/pull/8324#discussion_r284091738 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/calcite/avatica/util/DateTimeUtils.java #

[GitHub] [flink] danny0405 commented on a change in pull request #8324: [FLINK-11921][table] Upgrade to calcite 1.19

2019-05-14 Thread GitBox
danny0405 commented on a change in pull request #8324: [FLINK-11921][table] Upgrade to calcite 1.19 URL: https://github.com/apache/flink/pull/8324#discussion_r284091655 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/calcite/avatica/util/DateTimeUtils.java #

[GitHub] [flink] danny0405 commented on a change in pull request #8324: [FLINK-11921][table] Upgrade to calcite 1.19

2019-05-14 Thread GitBox
danny0405 commented on a change in pull request #8324: [FLINK-11921][table] Upgrade to calcite 1.19 URL: https://github.com/apache/flink/pull/8324#discussion_r284091504 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/calcite/avatica/util/DateTimeUtils.java #

[GitHub] [flink] danny0405 commented on a change in pull request #8324: [FLINK-11921][table] Upgrade to calcite 1.19

2019-05-14 Thread GitBox
danny0405 commented on a change in pull request #8324: [FLINK-11921][table] Upgrade to calcite 1.19 URL: https://github.com/apache/flink/pull/8324#discussion_r284091403 ## File path: flink-table/flink-table-planner/pom.xml ## @@ -136,17 +136,17 @@ under the License.

[jira] [Assigned] (FLINK-11607) Translate the "DataStream API Tutorial" page into Chinese

2019-05-14 Thread Zhang Ziqiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhang Ziqiang reassigned FLINK-11607: - Assignee: Zhang Ziqiang (was: Benchao Li) > Translate the "DataStream API Tutorial" pa

[GitHub] [flink] dianfu commented on a change in pull request #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro…

2019-05-14 Thread GitBox
dianfu commented on a change in pull request #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro… URL: https://github.com/apache/flink/pull/8439#discussion_r284080392 ## File path: flink-python/pyflink/table/tests/test_environment_completeness.py ##

[GitHub] [flink] dianfu commented on a change in pull request #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro…

2019-05-14 Thread GitBox
dianfu commented on a change in pull request #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro… URL: https://github.com/apache/flink/pull/8439#discussion_r284080627 ## File path: flink-python/pyflink/table/tests/test_table_completeness.py ## @@ -

[GitHub] [flink] sunjincheng121 commented on issue #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro…

2019-05-14 Thread GitBox
sunjincheng121 commented on issue #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro… URL: https://github.com/apache/flink/pull/8439#issuecomment-492495197 Thanks for the quick review! @dianfu I have update the PR according your comments! Best, Ji

[GitHub] [flink] zhijiangW edited a comment on issue #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-14 Thread GitBox
zhijiangW edited a comment on issue #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#issuecomment-492491082 Thanks for the confirmation @azagrebin . 1. Yes, I have not thought through the changes caused by single channel in `Part

[GitHub] [flink] zhijiangW commented on issue #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-14 Thread GitBox
zhijiangW commented on issue #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#issuecomment-492491082 Thanks for the confirmation @azagrebin . 1. Yes, I have not thought through the changes caused by single channel in `PartitionIn

[GitHub] [flink] dianfu commented on a change in pull request #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro…

2019-05-14 Thread GitBox
dianfu commented on a change in pull request #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro… URL: https://github.com/apache/flink/pull/8439#discussion_r284063932 ## File path: flink-python/pyflink/testing/test_case_utils.py ## @@ -90,3 +92,82

[GitHub] [flink] dianfu commented on a change in pull request #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro…

2019-05-14 Thread GitBox
dianfu commented on a change in pull request #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro… URL: https://github.com/apache/flink/pull/8439#discussion_r284065527 ## File path: flink-python/pyflink/testing/test_case_utils.py ## @@ -90,3 +92,82

[GitHub] [flink] dianfu commented on a change in pull request #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro…

2019-05-14 Thread GitBox
dianfu commented on a change in pull request #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro… URL: https://github.com/apache/flink/pull/8439#discussion_r284064889 ## File path: flink-python/pyflink/testing/test_case_utils.py ## @@ -90,3 +92,82

[GitHub] [flink] dianfu commented on a change in pull request #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro…

2019-05-14 Thread GitBox
dianfu commented on a change in pull request #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro… URL: https://github.com/apache/flink/pull/8439#discussion_r284062971 ## File path: flink-python/pyflink/table/tests/test_environment_completeness.py ##

[GitHub] [flink] dianfu commented on a change in pull request #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro…

2019-05-14 Thread GitBox
dianfu commented on a change in pull request #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro… URL: https://github.com/apache/flink/pull/8439#discussion_r284064639 ## File path: flink-python/pyflink/testing/test_case_utils.py ## @@ -90,3 +92,82

[GitHub] [flink] dianfu commented on a change in pull request #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro…

2019-05-14 Thread GitBox
dianfu commented on a change in pull request #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro… URL: https://github.com/apache/flink/pull/8439#discussion_r284064278 ## File path: flink-python/pyflink/testing/test_case_utils.py ## @@ -90,3 +92,82

[GitHub] [flink] dianfu commented on a change in pull request #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro…

2019-05-14 Thread GitBox
dianfu commented on a change in pull request #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro… URL: https://github.com/apache/flink/pull/8439#discussion_r284064351 ## File path: flink-python/pyflink/testing/test_case_utils.py ## @@ -90,3 +92,82

[GitHub] [flink] Aitozi commented on issue #8441: [FLINK-12486][doc]clarify the storage of operator state and broadcast state individually

2019-05-14 Thread GitBox
Aitozi commented on issue #8441: [FLINK-12486][doc]clarify the storage of operator state and broadcast state individually URL: https://github.com/apache/flink/pull/8441#issuecomment-492476714 e.. I think I have also updated the `state_backends.zh.md`, what do you point to @klion26 ? -

[jira] [Commented] (FLINK-12202) Consider introducing batch metric register in NetworkEnviroment

2019-05-14 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839963#comment-16839963 ] zhijiang commented on FLINK-12202: -- Hey [~azagrebin], as we confirmed before, this tick

[GitHub] [flink] c4emmmm commented on a change in pull request #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib

2019-05-14 Thread GitBox
c4e commented on a change in pull request #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib URL: https://github.com/apache/flink/pull/8402#discussion_r284071237 ## File path: flink-ml/flink-ml-api/src/main/java/org/apache/flink/ml/api/core/Pipeline.java

[jira] [Updated] (FLINK-12127) Move network related options to NetworkEnvironmentOptions

2019-05-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12127: --- Labels: pull-request-available (was: ) > Move network related options to NetworkEnvironment

[GitHub] [flink] flinkbot commented on issue #8445: [FLINK-12127][network, config] Move network related options form TaskManagerOptions and NettyConfig into NetworkEnvironmentOptions

2019-05-14 Thread GitBox
flinkbot commented on issue #8445: [FLINK-12127][network,config] Move network related options form TaskManagerOptions and NettyConfig into NetworkEnvironmentOptions URL: https://github.com/apache/flink/pull/8445#issuecomment-492483428 Thanks a lot for your contribution to the Apache Flink

[GitHub] [flink] yanghua commented on a change in pull request #8322: [FLINK-12364] Introduce a CheckpointFailureManager to centralized manage checkpoint failure

2019-05-14 Thread GitBox
yanghua commented on a change in pull request #8322: [FLINK-12364] Introduce a CheckpointFailureManager to centralized manage checkpoint failure URL: https://github.com/apache/flink/pull/8322#discussion_r284070033 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/c

[GitHub] [flink] zhijiangW commented on issue #8445: [FLINK-12127][network, config] Move network related options form TaskManagerOptions and NettyConfig into NetworkEnvironmentOptions

2019-05-14 Thread GitBox
zhijiangW commented on issue #8445: [FLINK-12127][network,config] Move network related options form TaskManagerOptions and NettyConfig into NetworkEnvironmentOptions URL: https://github.com/apache/flink/pull/8445#issuecomment-492483315 @flinkbot attention @azagrebin --

[GitHub] [flink] zhijiangW opened a new pull request #8445: [FLINK-12127][network, config] Move network related options form TaskManagerOptions and NettyConfig into NetworkEnvironmentOptions

2019-05-14 Thread GitBox
zhijiangW opened a new pull request #8445: [FLINK-12127][network,config] Move network related options form TaskManagerOptions and NettyConfig into NetworkEnvironmentOptions URL: https://github.com/apache/flink/pull/8445 ## What is the purpose of the change *The introduced `NetworkEn

[jira] [Commented] (FLINK-5243) Implement an example for BipartiteGraph

2019-05-14 Thread Jasleen Kaur (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839939#comment-16839939 ] Jasleen Kaur commented on FLINK-5243: - Thanks [~ivan.mushketyk]. Could I implement bi

[GitHub] [flink] yanghua removed a comment on issue #8322: [FLINK-12364] Introduce a CheckpointFailureManager to centralized manage checkpoint failure

2019-05-14 Thread GitBox
yanghua removed a comment on issue #8322: [FLINK-12364] Introduce a CheckpointFailureManager to centralized manage checkpoint failure URL: https://github.com/apache/flink/pull/8322#issuecomment-492471326 Irrelevant test error, Have created an issue to report it, will trigger rebuild~

[GitHub] [flink] danny0405 commented on issue #8324: [FLINK-11921][table] Upgrade to calcite 1.19

2019-05-14 Thread GitBox
danny0405 commented on issue #8324: [FLINK-11921][table] Upgrade to calcite 1.19 URL: https://github.com/apache/flink/pull/8324#issuecomment-492478037 > @danny0405 Could you help to review this PR? Sure, i will try to finish this reviewing AFAIK. -

[GitHub] [flink] dianfu commented on a change in pull request #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro…

2019-05-14 Thread GitBox
dianfu commented on a change in pull request #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro… URL: https://github.com/apache/flink/pull/8439#discussion_r284063074 ## File path: flink-python/pyflink/testing/test_case_utils.py ## @@ -90,3 +92,82

[GitHub] [flink] dianfu commented on a change in pull request #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro…

2019-05-14 Thread GitBox
dianfu commented on a change in pull request #8439: [FLINK-12485][python] Add completeness test for Table and TableEnviro… URL: https://github.com/apache/flink/pull/8439#discussion_r284063742 ## File path: flink-python/pyflink/testing/test_case_utils.py ## @@ -90,3 +92,82

[GitHub] [flink] KurtYoung commented on issue #8324: [FLINK-11921][table] Upgrade to calcite 1.19

2019-05-14 Thread GitBox
KurtYoung commented on issue #8324: [FLINK-11921][table] Upgrade to calcite 1.19 URL: https://github.com/apache/flink/pull/8324#issuecomment-492471785 @danny0405 Could you help to review this PR? This is an automated message f

[jira] [Commented] (FLINK-11612) Translate the "Project Template for Java" page into Chinese

2019-05-14 Thread LakeShen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839915#comment-16839915 ] LakeShen commented on FLINK-11612: -- I will translate this page do my best > Translate

[jira] [Assigned] (FLINK-11612) Translate the "Project Template for Java" page into Chinese

2019-05-14 Thread LakeShen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] LakeShen reassigned FLINK-11612: Assignee: LakeShen > Translate the "Project Template for Java" page into Chinese > --

[GitHub] [flink] yanghua commented on issue #8322: [FLINK-12364] Introduce a CheckpointFailureManager to centralized manage checkpoint failure

2019-05-14 Thread GitBox
yanghua commented on issue #8322: [FLINK-12364] Introduce a CheckpointFailureManager to centralized manage checkpoint failure URL: https://github.com/apache/flink/pull/8322#issuecomment-492471326 Irrelevant test error, Have created an issue to report it, will trigger rebuild~

[jira] [Closed] (FLINK-12370) Integrated Travis for Python Table API

2019-05-14 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng closed FLINK-12370. --- Resolution: Fixed Fix Version/s: 1.9.0 Fixed in master: d95d395d92acca210e107663ed0e96c3285f0

[jira] [Created] (FLINK-12512) TableSourceTest#testNestedProject test failed

2019-05-14 Thread vinoyang (JIRA)
vinoyang created FLINK-12512: Summary: TableSourceTest#testNestedProject test failed Key: FLINK-12512 URL: https://issues.apache.org/jira/browse/FLINK-12512 Project: Flink Issue Type: Improvement

[GitHub] [flink] asfgit closed pull request #8392: [FLINK-12370][python][travis] Integrated Travis for Python Table API.

2019-05-14 Thread GitBox
asfgit closed pull request #8392: [FLINK-12370][python][travis] Integrated Travis for Python Table API. URL: https://github.com/apache/flink/pull/8392 This is an automated message from the Apache Git Service. To respond to t

[jira] [Closed] (FLINK-11840) Introduce FlinkLogicalSnapshot

2019-05-14 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-11840. -- Resolution: Duplicate Fix Version/s: 1.9.0 > Introduce FlinkLogicalSnapshot > -

[GitHub] [flink] dianfu commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

2019-05-14 Thread GitBox
dianfu commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r284057878 ## File path: flink-python/pyflink/table/table.py ## @@ -106,6 +113,344 @@ def where

[GitHub] [flink] klion26 commented on issue #8432: Release 1.8

2019-05-14 Thread GitBox
klion26 commented on issue #8432: Release 1.8 URL: https://github.com/apache/flink/pull/8432#issuecomment-492467084 @sxganapa could you please close this pr which wants to merge release-1.8 to master This is an automated mess

[GitHub] [flink] sunjincheng121 commented on issue #8392: [FLINK-12370][python][travis] Integrated Travis for Python Table API.

2019-05-14 Thread GitBox
sunjincheng121 commented on issue #8392: [FLINK-12370][python][travis] Integrated Travis for Python Table API. URL: https://github.com/apache/flink/pull/8392#issuecomment-492466610 Thanks for the fix @WeiZhong94 LGTM. +1 to merged @flinkbot approve all --

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

2019-05-14 Thread GitBox
sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r284055809 ## File path: flink-python/pyflink/table/tests/test_batch_table_api.py ## @@

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

2019-05-14 Thread GitBox
sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r284054367 ## File path: flink-python/pyflink/table/table.py ## @@ -106,6 +113,344 @@ d

[GitHub] [flink] asfgit closed pull request #8434: [FLINK-12234][hive] Support view related operations in HiveCatalog

2019-05-14 Thread GitBox
asfgit closed pull request #8434: [FLINK-12234][hive] Support view related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8434 This is an automated message from the Apache Git Service. To respond to the

[jira] [Closed] (FLINK-12234) Support view related operations in HiveCatalog

2019-05-14 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-12234. Resolution: Fixed merged in 1.9.0: 544903d5cc77d6f90e0d77cb21ebf008b435e444 > Support view related operat

[jira] [Closed] (FLINK-12505) Unify database operations to HiveCatalogBase from its subclasses

2019-05-14 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-12505. Resolution: Fixed merged in 1.9.0: f7ecfdbcdf0f1ab17097ebbe1d170b984961bf60 > Unify database operations t

[GitHub] [flink] asfgit closed pull request #8433: [FLINK-12505][hive] Unify database operations to HiveCatalogBase from its subclasses

2019-05-14 Thread GitBox
asfgit closed pull request #8433: [FLINK-12505][hive] Unify database operations to HiveCatalogBase from its subclasses URL: https://github.com/apache/flink/pull/8433 This is an automated message from the Apache Git Service.

[GitHub] [flink] bowenli86 commented on issue #8434: [FLINK-12234][hive] Support view related operations in HiveCatalog

2019-05-14 Thread GitBox
bowenli86 commented on issue #8434: [FLINK-12234][hive] Support view related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8434#issuecomment-492395614 merging... This is an automated message from the Apa

[GitHub] [flink] bowenli86 commented on issue #8433: [FLINK-12505][hive] Unify database operations to HiveCatalogBase from its subclasses

2019-05-14 Thread GitBox
bowenli86 commented on issue #8433: [FLINK-12505][hive] Unify database operations to HiveCatalogBase from its subclasses URL: https://github.com/apache/flink/pull/8433#issuecomment-492395677 merging... This is an automated me

[GitHub] [flink] bowenli86 commented on a change in pull request #8434: [FLINK-12234][hive] Support view related operations in HiveCatalog

2019-05-14 Thread GitBox
bowenli86 commented on a change in pull request #8434: [FLINK-12234][hive] Support view related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8434#discussion_r283981020 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/ca

[jira] [Created] (FLINK-12511) make variable "comment" in all catalog metadata classes final

2019-05-14 Thread Bowen Li (JIRA)
Bowen Li created FLINK-12511: Summary: make variable "comment" in all catalog metadata classes final Key: FLINK-12511 URL: https://issues.apache.org/jira/browse/FLINK-12511 Project: Flink Issue

[GitHub] [flink] bowenli86 commented on a change in pull request #8434: [FLINK-12234][hive] Support view related operations in HiveCatalog

2019-05-14 Thread GitBox
bowenli86 commented on a change in pull request #8434: [FLINK-12234][hive] Support view related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8434#discussion_r283981020 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/ca

[GitHub] [flink] sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation

2019-05-14 Thread GitBox
sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation URL: https://github.com/apache/flink/pull/8437#discussion_r283954075 ## File path: docs/dev/stream/testing.md ## @@ -23,138 +23,387 @@ specific language governing permissions

[GitHub] [flink] sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation

2019-05-14 Thread GitBox
sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation URL: https://github.com/apache/flink/pull/8437#discussion_r283959368 ## File path: docs/dev/stream/testing.md ## @@ -181,85 +430,76 @@ public class ExampleIntegrationTest exte

[GitHub] [flink] sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation

2019-05-14 Thread GitBox
sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation URL: https://github.com/apache/flink/pull/8437#discussion_r283957833 ## File path: docs/dev/stream/testing.md ## @@ -23,138 +23,387 @@ specific language governing permissions

[GitHub] [flink] sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation

2019-05-14 Thread GitBox
sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation URL: https://github.com/apache/flink/pull/8437#discussion_r283954443 ## File path: docs/dev/stream/testing.md ## @@ -23,138 +23,387 @@ specific language governing permissions

[GitHub] [flink] sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation

2019-05-14 Thread GitBox
sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation URL: https://github.com/apache/flink/pull/8437#discussion_r283958605 ## File path: docs/dev/stream/testing.md ## @@ -181,85 +430,76 @@ public class ExampleIntegrationTest exte

[GitHub] [flink] sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation

2019-05-14 Thread GitBox
sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation URL: https://github.com/apache/flink/pull/8437#discussion_r283963231 ## File path: docs/dev/stream/testing.md ## @@ -23,138 +23,387 @@ specific language governing permissions

[GitHub] [flink] sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation

2019-05-14 Thread GitBox
sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation URL: https://github.com/apache/flink/pull/8437#discussion_r283951933 ## File path: docs/dev/stream/testing.md ## @@ -23,138 +23,387 @@ specific language governing permissions

[GitHub] [flink] sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation

2019-05-14 Thread GitBox
sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation URL: https://github.com/apache/flink/pull/8437#discussion_r283962452 ## File path: docs/dev/stream/testing.md ## @@ -181,85 +430,76 @@ public class ExampleIntegrationTest exte

[GitHub] [flink] sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation

2019-05-14 Thread GitBox
sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation URL: https://github.com/apache/flink/pull/8437#discussion_r283958118 ## File path: docs/dev/stream/testing.md ## @@ -23,138 +23,387 @@ specific language governing permissions

[GitHub] [flink] sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation

2019-05-14 Thread GitBox
sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation URL: https://github.com/apache/flink/pull/8437#discussion_r283952634 ## File path: docs/dev/stream/testing.md ## @@ -23,138 +23,387 @@ specific language governing permissions

[GitHub] [flink] sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation

2019-05-14 Thread GitBox
sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation URL: https://github.com/apache/flink/pull/8437#discussion_r283961380 ## File path: docs/dev/stream/testing.md ## @@ -181,85 +430,76 @@ public class ExampleIntegrationTest exte

[GitHub] [flink] sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation

2019-05-14 Thread GitBox
sjwiesman commented on a change in pull request #8437: [FLINK-12508] Expand Testing Documentation URL: https://github.com/apache/flink/pull/8437#discussion_r283959906 ## File path: docs/dev/stream/testing.md ## @@ -181,85 +430,76 @@ public class ExampleIntegrationTest exte

[jira] [Updated] (FLINK-10190) Unable to use custom endpoint in Kinesis producer

2019-05-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10190: --- Labels: pull-request-available (was: ) > Unable to use custom endpoint in Kinesis producer

[GitHub] [flink] flinkbot commented on issue #8444: [FLINK-10190] [Kinesis Connector] Allow AWS_REGION to be supplied along with custom Kinesis endpoint

2019-05-14 Thread GitBox
flinkbot commented on issue #8444: [FLINK-10190] [Kinesis Connector] Allow AWS_REGION to be supplied along with custom Kinesis endpoint URL: https://github.com/apache/flink/pull/8444#issuecomment-492376902 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I

[GitHub] [flink] skidder opened a new pull request #8444: [FLINK-10190] [Kinesis Connector] Allow AWS_REGION to be supplied along with custom Kinesis endpoint

2019-05-14 Thread GitBox
skidder opened a new pull request #8444: [FLINK-10190] [Kinesis Connector] Allow AWS_REGION to be supplied along with custom Kinesis endpoint URL: https://github.com/apache/flink/pull/8444 ## What is the purpose of the change Allow an AWS region (e.g. `us-east-1`) to be supplied alon

[jira] [Commented] (FLINK-12504) NullPoint here NullPointException there.. It's every where

2019-05-14 Thread Ken Krugler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839718#comment-16839718 ] Ken Krugler commented on FLINK-12504: - If I Google "Flink user mailing list", the fi

  1   2   3   4   >