[GitHub] [flink] twalthr commented on a change in pull request #8521: [FLINK-12601][table] Make the DataStream & DataSet conversion to a Table independent from Calcite

2019-05-30 Thread GitBox
twalthr commented on a change in pull request #8521: [FLINK-12601][table] Make the DataStream & DataSet conversion to a Table independent from Calcite URL: https://github.com/apache/flink/pull/8521#discussion_r289271852 ## File path: flink-table/flink-table-api-java/src/main/java/o

[GitHub] [flink] twalthr commented on a change in pull request #8521: [FLINK-12601][table] Make the DataStream & DataSet conversion to a Table independent from Calcite

2019-05-30 Thread GitBox
twalthr commented on a change in pull request #8521: [FLINK-12601][table] Make the DataStream & DataSet conversion to a Table independent from Calcite URL: https://github.com/apache/flink/pull/8521#discussion_r289272108 ## File path: flink-table/flink-table-api-java/src/main/java/o

[GitHub] [flink] twalthr commented on a change in pull request #8521: [FLINK-12601][table] Make the DataStream & DataSet conversion to a Table independent from Calcite

2019-05-30 Thread GitBox
twalthr commented on a change in pull request #8521: [FLINK-12601][table] Make the DataStream & DataSet conversion to a Table independent from Calcite URL: https://github.com/apache/flink/pull/8521#discussion_r289273841 ## File path: flink-table/flink-table-api-java/src/main/java/o

[GitHub] [flink] twalthr commented on a change in pull request #8521: [FLINK-12601][table] Make the DataStream & DataSet conversion to a Table independent from Calcite

2019-05-30 Thread GitBox
twalthr commented on a change in pull request #8521: [FLINK-12601][table] Make the DataStream & DataSet conversion to a Table independent from Calcite URL: https://github.com/apache/flink/pull/8521#discussion_r289272740 ## File path: flink-table/flink-table-api-java/src/main/java/o

[GitHub] [flink] carp84 commented on a change in pull request #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor

2019-05-30 Thread GitBox
carp84 commented on a change in pull request #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor URL: https://github.com/apache/flink/pull/8570#discussion_r289273148 ## File path: flink-core/src/main/java/org/apache/flink/api/common/state

[GitHub] [flink] zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r289273088 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/NettyShuffleDescriptor.java #

[GitHub] [flink] wisgood commented on a change in pull request #8571: [FLINK-12682][connectors] StringWriter support custom row delimiter

2019-05-30 Thread GitBox
wisgood commented on a change in pull request #8571: [FLINK-12682][connectors] StringWriter support custom row delimiter URL: https://github.com/apache/flink/pull/8571#discussion_r289272376 ## File path: flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/str

[GitHub] [flink] zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r289272418 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/NettyShuffleDescriptor.java #

[GitHub] [flink] zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r289271987 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/NettyShuffleMaster.java #

[GitHub] [flink] zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r289271987 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/NettyShuffleMaster.java #

[GitHub] [flink] zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r289271987 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/NettyShuffleMaster.java #

[GitHub] [flink] danny0405 commented on a change in pull request #8548: [FLINK-6962] [table] Add create(drop) table SQL DDL

2019-05-30 Thread GitBox
danny0405 commented on a change in pull request #8548: [FLINK-6962] [table] Add create(drop) table SQL DDL URL: https://github.com/apache/flink/pull/8548#discussion_r289271036 ## File path: flink-table/flink-sql-parser/src/main/resources/META-INF/NOTICE ## @@ -0,0 +1,15 @@

[GitHub] [flink] zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r289271099 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/NettyShuffleMaster.java #

[GitHub] [flink] danny0405 commented on a change in pull request #8548: [FLINK-6962] [table] Add create(drop) table SQL DDL

2019-05-30 Thread GitBox
danny0405 commented on a change in pull request #8548: [FLINK-6962] [table] Add create(drop) table SQL DDL URL: https://github.com/apache/flink/pull/8548#discussion_r289270874 ## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/SqlProperty.java ###

[GitHub] [flink] danny0405 commented on a change in pull request #8548: [FLINK-6962] [table] Add create(drop) table SQL DDL

2019-05-30 Thread GitBox
danny0405 commented on a change in pull request #8548: [FLINK-6962] [table] Add create(drop) table SQL DDL URL: https://github.com/apache/flink/pull/8548#discussion_r289270278 ## File path: flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl ## @@ -0,0

[GitHub] [flink] danny0405 commented on a change in pull request #8548: [FLINK-6962] [table] Add create(drop) table SQL DDL

2019-05-30 Thread GitBox
danny0405 commented on a change in pull request #8548: [FLINK-6962] [table] Add create(drop) table SQL DDL URL: https://github.com/apache/flink/pull/8548#discussion_r289269858 ## File path: flink-table/flink-sql-parser/pom.xml ## @@ -0,0 +1,312 @@ + + +http://maven.apache.

[GitHub] [flink] zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r289269558 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/NettyShuffleMaster.java #

[GitHub] [flink] flinkbot commented on issue #8581: [FLINK-12254][table] Update value literals to new type system

2019-05-30 Thread GitBox
flinkbot commented on issue #8581: [FLINK-12254][table] Update value literals to new type system URL: https://github.com/apache/flink/pull/8581#issuecomment-497590727 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your

[GitHub] [flink] twalthr opened a new pull request #8581: [FLINK-12254][table] Update value literals to new type system

2019-05-30 Thread GitBox
twalthr opened a new pull request #8581: [FLINK-12254][table] Update value literals to new type system URL: https://github.com/apache/flink/pull/8581 ## What is the purpose of the change This PR updates `ValueLiteralExpression` and `nullOf` to the new type system. All existing test

[GitHub] [flink] zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r289266913 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/NettyShuffleDescriptor.java #

[jira] [Commented] (FLINK-10984) Move flink-shaded-hadoop to flink-shaded

2019-05-30 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16852693#comment-16852693 ] sunjincheng commented on FLINK-10984: - The flink-shaded 7.0 already released, and we

[GitHub] [flink] sunjincheng121 commented on issue #8225: FLINK-10984]Remove flink-shaded-hadoop from flink

2019-05-30 Thread GitBox
sunjincheng121 commented on issue #8225: FLINK-10984]Remove flink-shaded-hadoop from flink URL: https://github.com/apache/flink/pull/8225#issuecomment-497587659 The flink-shaded 7.0 already released, I'll rebase the code and let the CI passed. -

[jira] [Comment Edited] (FLINK-10984) Move flink-shaded-hadoop to flink-shaded

2019-05-30 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16852693#comment-16852693 ] sunjincheng edited comment on FLINK-10984 at 5/31/19 6:05 AM:

[GitHub] [flink] KurtYoung commented on a change in pull request #8548: [FLINK-6962] [table] Add create(drop) table SQL DDL

2019-05-30 Thread GitBox
KurtYoung commented on a change in pull request #8548: [FLINK-6962] [table] Add create(drop) table SQL DDL URL: https://github.com/apache/flink/pull/8548#discussion_r289223245 ## File path: flink-table/flink-sql-parser/pom.xml ## @@ -0,0 +1,312 @@ + + +http://maven.apache.

[GitHub] [flink] KurtYoung commented on a change in pull request #8548: [FLINK-6962] [table] Add create(drop) table SQL DDL

2019-05-30 Thread GitBox
KurtYoung commented on a change in pull request #8548: [FLINK-6962] [table] Add create(drop) table SQL DDL URL: https://github.com/apache/flink/pull/8548#discussion_r289265024 ## File path: flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl ## @@ -0,0

[GitHub] [flink] KurtYoung commented on a change in pull request #8548: [FLINK-6962] [table] Add create(drop) table SQL DDL

2019-05-30 Thread GitBox
KurtYoung commented on a change in pull request #8548: [FLINK-6962] [table] Add create(drop) table SQL DDL URL: https://github.com/apache/flink/pull/8548#discussion_r289225445 ## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTable.ja

[GitHub] [flink] KurtYoung commented on a change in pull request #8548: [FLINK-6962] [table] Add create(drop) table SQL DDL

2019-05-30 Thread GitBox
KurtYoung commented on a change in pull request #8548: [FLINK-6962] [table] Add create(drop) table SQL DDL URL: https://github.com/apache/flink/pull/8548#discussion_r289265552 ## File path: flink-table/flink-sql-parser/src/main/resources/META-INF/NOTICE ## @@ -0,0 +1,15 @@

[GitHub] [flink] KurtYoung commented on a change in pull request #8548: [FLINK-6962] [table] Add create(drop) table SQL DDL

2019-05-30 Thread GitBox
KurtYoung commented on a change in pull request #8548: [FLINK-6962] [table] Add create(drop) table SQL DDL URL: https://github.com/apache/flink/pull/8548#discussion_r289265380 ## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/SqlProperty.java ###

[GitHub] [flink] tzulitai edited a comment on issue #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor

2019-05-30 Thread GitBox
tzulitai edited a comment on issue #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor URL: https://github.com/apache/flink/pull/8570#issuecomment-497585843 One slight clarification regarding a comment that was mentioned in the description: ``

[GitHub] [flink] tzulitai edited a comment on issue #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor

2019-05-30 Thread GitBox
tzulitai edited a comment on issue #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor URL: https://github.com/apache/flink/pull/8570#issuecomment-497585843 One slight clarification regarding a comment that was mentioned in the description: ``

[GitHub] [flink] tzulitai commented on issue #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor

2019-05-30 Thread GitBox
tzulitai commented on issue #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor URL: https://github.com/apache/flink/pull/8570#issuecomment-497585843 One slight clarification regarding a comment that was mentioned in the description: ``` Th

[GitHub] [flink] tzulitai edited a comment on issue #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor

2019-05-30 Thread GitBox
tzulitai edited a comment on issue #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor URL: https://github.com/apache/flink/pull/8570#issuecomment-497585843 One slight clarification regarding a comment that was mentioned in the description: ``

[GitHub] [flink] liyafan82 commented on issue #8579: [FLINK-12687][Runtime / Operators] ByteHashSet is always in dense mode

2019-05-30 Thread GitBox
liyafan82 commented on issue #8579: [FLINK-12687][Runtime / Operators] ByteHashSet is always in dense mode URL: https://github.com/apache/flink/pull/8579#issuecomment-497585646 Hi @JingsongLi, would you please take a look? Th

[GitHub] [flink] zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r289264560 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/NettyShuffleMaster.java #

[GitHub] [flink] zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r289264560 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/NettyShuffleMaster.java #

[GitHub] [flink] tzulitai commented on a change in pull request #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor

2019-05-30 Thread GitBox
tzulitai commented on a change in pull request #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor URL: https://github.com/apache/flink/pull/8570#discussion_r289262686 ## File path: flink-core/src/test/java/org/apache/flink/api/common/sta

[GitHub] [flink] tzulitai commented on a change in pull request #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor

2019-05-30 Thread GitBox
tzulitai commented on a change in pull request #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor URL: https://github.com/apache/flink/pull/8570#discussion_r289264163 ## File path: flink-core/src/test/java/org/apache/flink/api/common/sta

[GitHub] [flink] tzulitai commented on a change in pull request #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor

2019-05-30 Thread GitBox
tzulitai commented on a change in pull request #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor URL: https://github.com/apache/flink/pull/8570#discussion_r289262391 ## File path: flink-core/src/main/java/org/apache/flink/api/common/sta

[GitHub] [flink] tzulitai commented on a change in pull request #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor

2019-05-30 Thread GitBox
tzulitai commented on a change in pull request #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor URL: https://github.com/apache/flink/pull/8570#discussion_r289263899 ## File path: flink-core/src/test/java/org/apache/flink/api/common/sta

[GitHub] [flink] tzulitai commented on a change in pull request #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor

2019-05-30 Thread GitBox
tzulitai commented on a change in pull request #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor URL: https://github.com/apache/flink/pull/8570#discussion_r289262323 ## File path: flink-core/src/main/java/org/apache/flink/api/common/sta

[GitHub] [flink] tzulitai commented on a change in pull request #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor

2019-05-30 Thread GitBox
tzulitai commented on a change in pull request #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor URL: https://github.com/apache/flink/pull/8570#discussion_r289262617 ## File path: flink-core/src/test/java/org/apache/flink/api/common/sta

[GitHub] [flink] tzulitai commented on a change in pull request #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor

2019-05-30 Thread GitBox
tzulitai commented on a change in pull request #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor URL: https://github.com/apache/flink/pull/8570#discussion_r289263588 ## File path: flink-core/src/main/java/org/apache/flink/api/common/sta

[GitHub] [flink] bowenli86 commented on issue #8567: [FLINK-12676][table][sql-client] Add descriptor, validator, and factory of GenericInMemoryCatalog for table discovery service

2019-05-30 Thread GitBox
bowenli86 commented on issue #8567: [FLINK-12676][table][sql-client] Add descriptor, validator, and factory of GenericInMemoryCatalog for table discovery service URL: https://github.com/apache/flink/pull/8567#issuecomment-497580939 @xuefuz can you take another look? --

[GitHub] [flink] bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement HiveInputFormat to read Hive tables

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement HiveInputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r289260306 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/batch/conn

[GitHub] [flink] bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement HiveInputFormat to read Hive tables

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement HiveInputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r289260559 ## File path: flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/batch/conn

[GitHub] [flink] bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement HiveInputFormat to read Hive tables

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement HiveInputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r289260297 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/batch/conn

[GitHub] [flink] bowenli86 commented on a change in pull request #8536: [FLINK-12568][hive] Implement OutputFormat to write Hive tables

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8536: [FLINK-12568][hive] Implement OutputFormat to write Hive tables URL: https://github.com/apache/flink/pull/8536#discussion_r289259721 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/batch/conne

[GitHub] [flink] bowenli86 commented on a change in pull request #8536: [FLINK-12568][hive] Implement OutputFormat to write Hive tables

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8536: [FLINK-12568][hive] Implement OutputFormat to write Hive tables URL: https://github.com/apache/flink/pull/8536#discussion_r289259721 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/batch/conne

[jira] [Commented] (FLINK-5243) Implement an example for BipartiteGraph

2019-05-30 Thread Jasleen Kaur (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16852672#comment-16852672 ] Jasleen Kaur commented on FLINK-5243: - [~greghogan] Thanks for your reply. I was plan

[GitHub] [flink] tzulitai edited a comment on issue #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor

2019-05-30 Thread GitBox
tzulitai edited a comment on issue #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor URL: https://github.com/apache/flink/pull/8570#issuecomment-497577479 @flinkbot approve consensus I'm approving the consensus to fix the problem like thi

[GitHub] [flink] tzulitai edited a comment on issue #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor

2019-05-30 Thread GitBox
tzulitai edited a comment on issue #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor URL: https://github.com/apache/flink/pull/8570#issuecomment-497577479 @flinkbot approve consensus I'm approving the consensus to fix the problem like thi

[jira] [Commented] (FLINK-12683) Provide task manager's location information for checkpoint coordinator specific log messages

2019-05-30 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16852668#comment-16852668 ] vinoyang commented on FLINK-12683: -- I think for logging, the good practice is that it s

[GitHub] [flink] tzulitai commented on issue #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor

2019-05-30 Thread GitBox
tzulitai commented on issue #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor URL: https://github.com/apache/flink/pull/8570#issuecomment-497577479 @flinkbot approve consensus I'm approving the consensus to fix the problem like this, befo

[GitHub] [flink] bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r289258274 ## File path: flink-connectors/flink-connector-hive/pom.xml ## @@ -423,4 +42

[GitHub] [flink] bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r289258387 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/ta

[GitHub] [flink] bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r289258244 ## File path: flink-connectors/flink-connector-hive/pom.xml ## @@ -423,4 +42

[GitHub] [flink] bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r289258274 ## File path: flink-connectors/flink-connector-hive/pom.xml ## @@ -423,4 +42

[GitHub] [flink] bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r289258121 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/ta

[GitHub] [flink] bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r289257720 ## File path: flink-connectors/flink-connector-hive/pom.xml ## @@ -423,4 +42

[GitHub] [flink] bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r289257545 ## File path: flink-connectors/flink-connector-hive/pom.xml ## @@ -423,4 +42

[GitHub] [flink] bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r289258121 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/ta

[GitHub] [flink] bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r289257720 ## File path: flink-connectors/flink-connector-hive/pom.xml ## @@ -423,4 +42

[GitHub] [flink] bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r289257545 ## File path: flink-connectors/flink-connector-hive/pom.xml ## @@ -423,4 +42

[jira] [Commented] (FLINK-11987) Kafka producer occasionally throws NullpointerException

2019-05-30 Thread Yu Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16852663#comment-16852663 ] Yu Li commented on FLINK-11987: --- Regarding the issue mentioned by [~chethanuk], from the p

[jira] [Commented] (FLINK-12683) Provide task manager's location information for checkpoint coordinator specific log messages

2019-05-30 Thread Congxian Qiu(klion26) (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16852658#comment-16852658 ] Congxian Qiu(klion26) commented on FLINK-12683: --- In my opinion, the jm log

[jira] [Commented] (FLINK-11987) Kafka producer occasionally throws NullpointerException

2019-05-30 Thread Yu Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16852656#comment-16852656 ] Yu Li commented on FLINK-11987: --- Have created FLINK-12688 to fix the issue from inside {{S

[GitHub] [flink] flinkbot commented on issue #8580: [FLINK-12683] Provide task manager location information for checkpoint coordinator specific log messages

2019-05-30 Thread GitBox
flinkbot commented on issue #8580: [FLINK-12683] Provide task manager location information for checkpoint coordinator specific log messages URL: https://github.com/apache/flink/pull/8580#issuecomment-497573926 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbo

[jira] [Created] (FLINK-12688) Make serializer lazy initialization thread safe in StateDescriptor

2019-05-30 Thread Yu Li (JIRA)
Yu Li created FLINK-12688: - Summary: Make serializer lazy initialization thread safe in StateDescriptor Key: FLINK-12688 URL: https://issues.apache.org/jira/browse/FLINK-12688 Project: Flink Issue T

[jira] [Updated] (FLINK-12683) Provide task manager's location information for checkpoint coordinator specific log messages

2019-05-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12683: --- Labels: pull-request-available (was: ) > Provide task manager's location information for ch

[GitHub] [flink] yanghua opened a new pull request #8580: [FLINK-12683] Provide task manager location information for checkpoint coordinator specific log messages

2019-05-30 Thread GitBox
yanghua opened a new pull request #8580: [FLINK-12683] Provide task manager location information for checkpoint coordinator specific log messages URL: https://github.com/apache/flink/pull/8580 ## What is the purpose of the change *This pull request provides task manager location info

[jira] [Updated] (FLINK-12687) ByteHashSet is always in dense mode

2019-05-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12687: --- Labels: pull-request-available (was: ) > ByteHashSet is always in dense mode >

[GitHub] [flink] flinkbot commented on issue #8579: [FLINK-12687][Runtime / Operators] ByteHashSet is always in dense mode

2019-05-30 Thread GitBox
flinkbot commented on issue #8579: [FLINK-12687][Runtime / Operators] ByteHashSet is always in dense mode URL: https://github.com/apache/flink/pull/8579#issuecomment-497573552 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to revi

[GitHub] [flink] liyafan82 opened a new pull request #8579: [FLINK-12687][Runtime / Operators] ByteHashSet is always in dense mode

2019-05-30 Thread GitBox
liyafan82 opened a new pull request #8579: [FLINK-12687][Runtime / Operators] ByteHashSet is always in dense mode URL: https://github.com/apache/flink/pull/8579 ## What is the purpose of the change Improve the performance and code structure for org.apache.flink.table.runtime

[jira] [Created] (FLINK-12687) ByteHashSet is always in dense mode

2019-05-30 Thread Liya Fan (JIRA)
Liya Fan created FLINK-12687: Summary: ByteHashSet is always in dense mode Key: FLINK-12687 URL: https://issues.apache.org/jira/browse/FLINK-12687 Project: Flink Issue Type: Improvement

[jira] [Created] (FLINK-12686) StreamGraph Supports Blink Batch Mode

2019-05-30 Thread Biao Liu (JIRA)
Biao Liu created FLINK-12686: Summary: StreamGraph Supports Blink Batch Mode Key: FLINK-12686 URL: https://issues.apache.org/jira/browse/FLINK-12686 Project: Flink Issue Type: Improvement

[jira] [Updated] (FLINK-12686) StreamGraph Supports Blink Batch Mode

2019-05-30 Thread Biao Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Biao Liu updated FLINK-12686: - Description: This is a part of merging Blink batch runner. I would like to improvement the StreamGraph t

[GitHub] [flink] zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r289249491 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/PartitionDescriptor.java

[GitHub] [flink] zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r289249256 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/PartitionDescriptor.java

[GitHub] [flink] zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r289247475 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ProducerDescriptor.java #

[GitHub] [flink] zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r289247275 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ProducerDescriptor.java #

[GitHub] [flink] zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r289247275 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ProducerDescriptor.java #

[GitHub] [flink] asfgit closed pull request #8531: [FLINK-12440][python] Add all connector support align Java Table API.

2019-05-30 Thread GitBox
asfgit closed pull request #8531: [FLINK-12440][python] Add all connector support align Java Table API. URL: https://github.com/apache/flink/pull/8531 This is an automated message from the Apache Git Service. To respond to t

[jira] [Closed] (FLINK-12440) Add all connector support align Java Table API

2019-05-30 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng closed FLINK-12440. --- Resolution: Fixed Fix Version/s: 1.9.0 Fixed in master: 836fdfff0db64ff8241f38e8dd362dd50a9d1

[GitHub] [flink] zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r289246143 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ShuffleMaster.java ## @@

[GitHub] [flink] lirui-apache commented on issue #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

2019-05-30 Thread GitBox
lirui-apache commented on issue #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#issuecomment-497560367 > For Hive versions, I think for now we can claim support only for versions like 1.2.1 explicitly. In theory

[GitHub] [flink] wisgood commented on a change in pull request #8571: [FLINK-12682][connectors] StringWriter support custom row delimiter

2019-05-30 Thread GitBox
wisgood commented on a change in pull request #8571: [FLINK-12682][connectors] StringWriter support custom row delimiter URL: https://github.com/apache/flink/pull/8571#discussion_r289245475 ## File path: flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/str

[GitHub] [flink] zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r289244295 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/deployment/InputGateDeploymentDescriptor.j

[GitHub] [flink] zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r289243434 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ShuffleDescriptor.java ##

[GitHub] [flink] zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r289242090 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/deployment/InputGateDeploymentDescriptor.j

[GitHub] [flink] sunjincheng121 commented on issue #8531: [FLINK-12440][python] Add all connector support align Java Table API.

2019-05-30 Thread GitBox
sunjincheng121 commented on issue #8531: [FLINK-12440][python] Add all connector support align Java Table API. URL: https://github.com/apache/flink/pull/8531#issuecomment-497555012 LGTM. +1 to merged. @flinkbot approve all

[GitHub] [flink] Myasuka commented on a change in pull request #8571: [FLINK-12682][connectors] StringWriter support custom row delimiter

2019-05-30 Thread GitBox
Myasuka commented on a change in pull request #8571: [FLINK-12682][connectors] StringWriter support custom row delimiter URL: https://github.com/apache/flink/pull/8571#discussion_r289240462 ## File path: flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/str

[jira] [Commented] (FLINK-12683) Provide task manager's location information for checkpoint coordinator specific log messages

2019-05-30 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16852600#comment-16852600 ] vinoyang commented on FLINK-12683: -- Hi [~klion26] Here is my plan: Changing these two

[GitHub] [flink] zhijiangW commented on a change in pull request #8566: [FLINK-12673][network] Introduce NetworkEnvironment.getUnreleasedPartitions instead of using getResultPartitionManager

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8566: [FLINK-12673][network] Introduce NetworkEnvironment.getUnreleasedPartitions instead of using getResultPartitionManager URL: https://github.com/apache/flink/pull/8566#discussion_r289239909 ## File path: flink-runtime/src/main/j

[jira] [Updated] (FLINK-12683) Provide task manager's location information for checkpoint coordinator specific log messages

2019-05-30 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang updated FLINK-12683: - Summary: Provide task manager's location information for checkpoint coordinator specific log messages (

[jira] [Updated] (FLINK-12683) Provide task manager's location information for checkpoint acknowledge log message

2019-05-30 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang updated FLINK-12683: - Summary: Provide task manager's location information for checkpoint acknowledge log message (was: Provi

[jira] [Commented] (FLINK-12683) Provide task manager's location information for checkpoint acknowledge message to improve the checkpoint log message

2019-05-30 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16852592#comment-16852592 ] vinoyang commented on FLINK-12683: -- [~klion26] you are right, thanks, will change this

[GitHub] [flink] flinkbot commented on issue #8578: [FLINK-12685] [table-planner-blink] Supports UNNEST query in blink planner

2019-05-30 Thread GitBox
flinkbot commented on issue #8578: [FLINK-12685] [table-planner-blink] Supports UNNEST query in blink planner URL: https://github.com/apache/flink/pull/8578#issuecomment-497551523 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[GitHub] [flink] godfreyhe opened a new pull request #8578: [FLINK-12685] [table-planner-blink] Supports UNNEST query in blink planner

2019-05-30 Thread GitBox
godfreyhe opened a new pull request #8578: [FLINK-12685] [table-planner-blink] Supports UNNEST query in blink planner URL: https://github.com/apache/flink/pull/8578 ## What is the purpose of the change *Supports UNNEST query in blink planner* ## Brief change log

[jira] [Updated] (FLINK-12685) Supports UNNEST query in blink planner

2019-05-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12685: --- Labels: pull-request-available (was: ) > Supports UNNEST query in blink planner > -

[GitHub] [flink] klion26 commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy

2019-05-30 Thread GitBox
klion26 commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy URL: https://github.com/apache/flink/pull/8573#discussion_r289237692 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/failove

  1   2   3   >