[GitHub] [flink] tzulitai edited a comment on issue #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor

2019-05-30 Thread GitBox
tzulitai edited a comment on issue #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor URL: https://github.com/apache/flink/pull/8570#issuecomment-497585843 One slight clarification regarding a comment that was mentioned in the description:

[GitHub] [flink] tzulitai edited a comment on issue #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor

2019-05-30 Thread GitBox
tzulitai edited a comment on issue #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor URL: https://github.com/apache/flink/pull/8570#issuecomment-497585843 One slight clarification regarding a comment that was mentioned in the description:

[GitHub] [flink] tzulitai edited a comment on issue #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor

2019-05-30 Thread GitBox
tzulitai edited a comment on issue #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor URL: https://github.com/apache/flink/pull/8570#issuecomment-497585843 One slight clarification regarding a comment that was mentioned in the description:

[GitHub] [flink] tzulitai commented on issue #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor

2019-05-30 Thread GitBox
tzulitai commented on issue #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor URL: https://github.com/apache/flink/pull/8570#issuecomment-497585843 One slight clarification regarding a comment that was mentioned in the description: ```

[GitHub] [flink] liyafan82 commented on issue #8579: [FLINK-12687][Runtime / Operators] ByteHashSet is always in dense mode

2019-05-30 Thread GitBox
liyafan82 commented on issue #8579: [FLINK-12687][Runtime / Operators] ByteHashSet is always in dense mode URL: https://github.com/apache/flink/pull/8579#issuecomment-497585646 Hi @JingsongLi, would you please take a look?

[GitHub] [flink] zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r289264560 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/NettyShuffleMaster.java

[GitHub] [flink] zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r289264560 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/NettyShuffleMaster.java

[GitHub] [flink] tzulitai commented on a change in pull request #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor

2019-05-30 Thread GitBox
tzulitai commented on a change in pull request #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor URL: https://github.com/apache/flink/pull/8570#discussion_r289262686 ## File path:

[GitHub] [flink] tzulitai commented on a change in pull request #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor

2019-05-30 Thread GitBox
tzulitai commented on a change in pull request #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor URL: https://github.com/apache/flink/pull/8570#discussion_r289264163 ## File path:

[GitHub] [flink] tzulitai commented on a change in pull request #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor

2019-05-30 Thread GitBox
tzulitai commented on a change in pull request #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor URL: https://github.com/apache/flink/pull/8570#discussion_r289262391 ## File path:

[GitHub] [flink] tzulitai commented on a change in pull request #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor

2019-05-30 Thread GitBox
tzulitai commented on a change in pull request #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor URL: https://github.com/apache/flink/pull/8570#discussion_r289263899 ## File path:

[GitHub] [flink] tzulitai commented on a change in pull request #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor

2019-05-30 Thread GitBox
tzulitai commented on a change in pull request #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor URL: https://github.com/apache/flink/pull/8570#discussion_r289262323 ## File path:

[GitHub] [flink] tzulitai commented on a change in pull request #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor

2019-05-30 Thread GitBox
tzulitai commented on a change in pull request #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor URL: https://github.com/apache/flink/pull/8570#discussion_r289262617 ## File path:

[GitHub] [flink] tzulitai commented on a change in pull request #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor

2019-05-30 Thread GitBox
tzulitai commented on a change in pull request #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor URL: https://github.com/apache/flink/pull/8570#discussion_r289263588 ## File path:

[GitHub] [flink] bowenli86 commented on issue #8567: [FLINK-12676][table][sql-client] Add descriptor, validator, and factory of GenericInMemoryCatalog for table discovery service

2019-05-30 Thread GitBox
bowenli86 commented on issue #8567: [FLINK-12676][table][sql-client] Add descriptor, validator, and factory of GenericInMemoryCatalog for table discovery service URL: https://github.com/apache/flink/pull/8567#issuecomment-497580939 @xuefuz can you take another look?

[GitHub] [flink] bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement HiveInputFormat to read Hive tables

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement HiveInputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r289260306 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement HiveInputFormat to read Hive tables

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement HiveInputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r289260559 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement HiveInputFormat to read Hive tables

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8522: [FLINK-12572][hive]Implement HiveInputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r289260297 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8536: [FLINK-12568][hive] Implement OutputFormat to write Hive tables

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8536: [FLINK-12568][hive] Implement OutputFormat to write Hive tables URL: https://github.com/apache/flink/pull/8536#discussion_r289259721 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8536: [FLINK-12568][hive] Implement OutputFormat to write Hive tables

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8536: [FLINK-12568][hive] Implement OutputFormat to write Hive tables URL: https://github.com/apache/flink/pull/8536#discussion_r289259721 ## File path:

[jira] [Commented] (FLINK-5243) Implement an example for BipartiteGraph

2019-05-30 Thread Jasleen Kaur (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852672#comment-16852672 ] Jasleen Kaur commented on FLINK-5243: - [~greghogan] Thanks for your reply. I was planning to

[GitHub] [flink] tzulitai edited a comment on issue #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor

2019-05-30 Thread GitBox
tzulitai edited a comment on issue #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor URL: https://github.com/apache/flink/pull/8570#issuecomment-497577479 @flinkbot approve consensus I'm approving the consensus to fix the problem like

[GitHub] [flink] tzulitai edited a comment on issue #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor

2019-05-30 Thread GitBox
tzulitai edited a comment on issue #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor URL: https://github.com/apache/flink/pull/8570#issuecomment-497577479 @flinkbot approve consensus I'm approving the consensus to fix the problem like

[jira] [Commented] (FLINK-12683) Provide task manager's location information for checkpoint coordinator specific log messages

2019-05-30 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852668#comment-16852668 ] vinoyang commented on FLINK-12683: -- I think for logging, the good practice is that it should provide

[GitHub] [flink] tzulitai commented on issue #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor

2019-05-30 Thread GitBox
tzulitai commented on issue #8570: [FLINK-12688] [state] Make serializer lazy initialization thread safe in StateDescriptor URL: https://github.com/apache/flink/pull/8570#issuecomment-497577479 @flinkbot approve consensus I'm approving the consensus to fix the problem like this,

[GitHub] [flink] bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r289258274 ## File path: flink-connectors/flink-connector-hive/pom.xml ## @@ -423,4

[GitHub] [flink] bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r289258387 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r289258244 ## File path: flink-connectors/flink-connector-hive/pom.xml ## @@ -423,4

[GitHub] [flink] bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r289258274 ## File path: flink-connectors/flink-connector-hive/pom.xml ## @@ -423,4

[GitHub] [flink] bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r289258121 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r289257720 ## File path: flink-connectors/flink-connector-hive/pom.xml ## @@ -423,4

[GitHub] [flink] bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r289257545 ## File path: flink-connectors/flink-connector-hive/pom.xml ## @@ -423,4

[GitHub] [flink] bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r289258121 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r289257720 ## File path: flink-connectors/flink-connector-hive/pom.xml ## @@ -423,4

[GitHub] [flink] bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#discussion_r289257545 ## File path: flink-connectors/flink-connector-hive/pom.xml ## @@ -423,4

[jira] [Commented] (FLINK-11987) Kafka producer occasionally throws NullpointerException

2019-05-30 Thread Yu Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852663#comment-16852663 ] Yu Li commented on FLINK-11987: --- Regarding the issue mentioned by [~chethanuk], from the posted stack the

[jira] [Commented] (FLINK-12683) Provide task manager's location information for checkpoint coordinator specific log messages

2019-05-30 Thread Congxian Qiu(klion26) (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852658#comment-16852658 ] Congxian Qiu(klion26) commented on FLINK-12683: --- In my opinion, the jm log of current

[jira] [Commented] (FLINK-11987) Kafka producer occasionally throws NullpointerException

2019-05-30 Thread Yu Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852656#comment-16852656 ] Yu Li commented on FLINK-11987: --- Have created FLINK-12688 to fix the issue from inside {{StateDescriptor}}

[GitHub] [flink] flinkbot commented on issue #8580: [FLINK-12683] Provide task manager location information for checkpoint coordinator specific log messages

2019-05-30 Thread GitBox
flinkbot commented on issue #8580: [FLINK-12683] Provide task manager location information for checkpoint coordinator specific log messages URL: https://github.com/apache/flink/pull/8580#issuecomment-497573926 Thanks a lot for your contribution to the Apache Flink project. I'm the

[jira] [Created] (FLINK-12688) Make serializer lazy initialization thread safe in StateDescriptor

2019-05-30 Thread Yu Li (JIRA)
Yu Li created FLINK-12688: - Summary: Make serializer lazy initialization thread safe in StateDescriptor Key: FLINK-12688 URL: https://issues.apache.org/jira/browse/FLINK-12688 Project: Flink Issue

[jira] [Updated] (FLINK-12683) Provide task manager's location information for checkpoint coordinator specific log messages

2019-05-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12683: --- Labels: pull-request-available (was: ) > Provide task manager's location information for

[GitHub] [flink] yanghua opened a new pull request #8580: [FLINK-12683] Provide task manager location information for checkpoint coordinator specific log messages

2019-05-30 Thread GitBox
yanghua opened a new pull request #8580: [FLINK-12683] Provide task manager location information for checkpoint coordinator specific log messages URL: https://github.com/apache/flink/pull/8580 ## What is the purpose of the change *This pull request provides task manager location

[jira] [Updated] (FLINK-12687) ByteHashSet is always in dense mode

2019-05-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12687: --- Labels: pull-request-available (was: ) > ByteHashSet is always in dense mode >

[GitHub] [flink] flinkbot commented on issue #8579: [FLINK-12687][Runtime / Operators] ByteHashSet is always in dense mode

2019-05-30 Thread GitBox
flinkbot commented on issue #8579: [FLINK-12687][Runtime / Operators] ByteHashSet is always in dense mode URL: https://github.com/apache/flink/pull/8579#issuecomment-497573552 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[GitHub] [flink] liyafan82 opened a new pull request #8579: [FLINK-12687][Runtime / Operators] ByteHashSet is always in dense mode

2019-05-30 Thread GitBox
liyafan82 opened a new pull request #8579: [FLINK-12687][Runtime / Operators] ByteHashSet is always in dense mode URL: https://github.com/apache/flink/pull/8579 ## What is the purpose of the change Improve the performance and code structure for

[jira] [Created] (FLINK-12687) ByteHashSet is always in dense mode

2019-05-30 Thread Liya Fan (JIRA)
Liya Fan created FLINK-12687: Summary: ByteHashSet is always in dense mode Key: FLINK-12687 URL: https://issues.apache.org/jira/browse/FLINK-12687 Project: Flink Issue Type: Improvement

[jira] [Updated] (FLINK-12686) StreamGraph Supports Blink Batch Mode

2019-05-30 Thread Biao Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Biao Liu updated FLINK-12686: - Description: This is a part of merging Blink batch runner. I would like to improvement the StreamGraph

[jira] [Created] (FLINK-12686) StreamGraph Supports Blink Batch Mode

2019-05-30 Thread Biao Liu (JIRA)
Biao Liu created FLINK-12686: Summary: StreamGraph Supports Blink Batch Mode Key: FLINK-12686 URL: https://issues.apache.org/jira/browse/FLINK-12686 Project: Flink Issue Type: Improvement

[GitHub] [flink] zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r289249491 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/PartitionDescriptor.java

[GitHub] [flink] zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r289249256 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/PartitionDescriptor.java

[GitHub] [flink] zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r289247475 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ProducerDescriptor.java

[GitHub] [flink] zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r289247275 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ProducerDescriptor.java

[GitHub] [flink] zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r289247275 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ProducerDescriptor.java

[GitHub] [flink] asfgit closed pull request #8531: [FLINK-12440][python] Add all connector support align Java Table API.

2019-05-30 Thread GitBox
asfgit closed pull request #8531: [FLINK-12440][python] Add all connector support align Java Table API. URL: https://github.com/apache/flink/pull/8531 This is an automated message from the Apache Git Service. To respond to

[jira] [Closed] (FLINK-12440) Add all connector support align Java Table API

2019-05-30 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng closed FLINK-12440. --- Resolution: Fixed Fix Version/s: 1.9.0 Fixed in master: 

[GitHub] [flink] zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r289246143 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ShuffleMaster.java ##

[GitHub] [flink] lirui-apache commented on issue #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

2019-05-30 Thread GitBox
lirui-apache commented on issue #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#issuecomment-497560367 > For Hive versions, I think for now we can claim support only for versions like 1.2.1 explicitly. In

[GitHub] [flink] wisgood commented on a change in pull request #8571: [FLINK-12682][connectors] StringWriter support custom row delimiter

2019-05-30 Thread GitBox
wisgood commented on a change in pull request #8571: [FLINK-12682][connectors] StringWriter support custom row delimiter URL: https://github.com/apache/flink/pull/8571#discussion_r289245475 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r289244295 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r289243434 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ShuffleDescriptor.java

[GitHub] [flink] zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r289242090 ## File path:

[GitHub] [flink] sunjincheng121 commented on issue #8531: [FLINK-12440][python] Add all connector support align Java Table API.

2019-05-30 Thread GitBox
sunjincheng121 commented on issue #8531: [FLINK-12440][python] Add all connector support align Java Table API. URL: https://github.com/apache/flink/pull/8531#issuecomment-497555012 LGTM. +1 to merged. @flinkbot approve all

[GitHub] [flink] Myasuka commented on a change in pull request #8571: [FLINK-12682][connectors] StringWriter support custom row delimiter

2019-05-30 Thread GitBox
Myasuka commented on a change in pull request #8571: [FLINK-12682][connectors] StringWriter support custom row delimiter URL: https://github.com/apache/flink/pull/8571#discussion_r289240462 ## File path:

[jira] [Commented] (FLINK-12683) Provide task manager's location information for checkpoint coordinator specific log messages

2019-05-30 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852600#comment-16852600 ] vinoyang commented on FLINK-12683: -- Hi [~klion26] Here is my plan: Changing these two methods'

[GitHub] [flink] zhijiangW commented on a change in pull request #8566: [FLINK-12673][network] Introduce NetworkEnvironment.getUnreleasedPartitions instead of using getResultPartitionManager

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8566: [FLINK-12673][network] Introduce NetworkEnvironment.getUnreleasedPartitions instead of using getResultPartitionManager URL: https://github.com/apache/flink/pull/8566#discussion_r289239909 ## File path:

[jira] [Updated] (FLINK-12683) Provide task manager's location information for checkpoint coordinator specific log messages

2019-05-30 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang updated FLINK-12683: - Summary: Provide task manager's location information for checkpoint coordinator specific log messages

[jira] [Updated] (FLINK-12683) Provide task manager's location information for checkpoint acknowledge log message

2019-05-30 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang updated FLINK-12683: - Summary: Provide task manager's location information for checkpoint acknowledge log message (was:

[jira] [Commented] (FLINK-12683) Provide task manager's location information for checkpoint acknowledge message to improve the checkpoint log message

2019-05-30 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852592#comment-16852592 ] vinoyang commented on FLINK-12683: -- [~klion26] you are right, thanks, will change this issue title. >

[GitHub] [flink] flinkbot commented on issue #8578: [FLINK-12685] [table-planner-blink] Supports UNNEST query in blink planner

2019-05-30 Thread GitBox
flinkbot commented on issue #8578: [FLINK-12685] [table-planner-blink] Supports UNNEST query in blink planner URL: https://github.com/apache/flink/pull/8578#issuecomment-497551523 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[GitHub] [flink] godfreyhe opened a new pull request #8578: [FLINK-12685] [table-planner-blink] Supports UNNEST query in blink planner

2019-05-30 Thread GitBox
godfreyhe opened a new pull request #8578: [FLINK-12685] [table-planner-blink] Supports UNNEST query in blink planner URL: https://github.com/apache/flink/pull/8578 ## What is the purpose of the change *Supports UNNEST query in blink planner* ## Brief change log

[jira] [Updated] (FLINK-12685) Supports UNNEST query in blink planner

2019-05-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12685: --- Labels: pull-request-available (was: ) > Supports UNNEST query in blink planner >

[GitHub] [flink] klion26 commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy

2019-05-30 Thread GitBox
klion26 commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy URL: https://github.com/apache/flink/pull/8573#discussion_r289237692 ## File path:

[GitHub] [flink] klion26 commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy

2019-05-30 Thread GitBox
klion26 commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy URL: https://github.com/apache/flink/pull/8573#discussion_r289237526 ## File path:

[GitHub] [flink] sunjincheng121 commented on issue #8474: [FLINK-12409][python] Adds from_elements in TableEnvironment

2019-05-30 Thread GitBox
sunjincheng121 commented on issue #8474: [FLINK-12409][python] Adds from_elements in TableEnvironment URL: https://github.com/apache/flink/pull/8474#issuecomment-497548692 Thanks for the quick updated! @dianfu LGTM. From my side, +1 to merged.

[jira] [Commented] (FLINK-12683) Provide task manager's location information for checkpoint acknowledge message to improve the checkpoint log message

2019-05-30 Thread Congxian Qiu(klion26) (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852572#comment-16852572 ] Congxian Qiu(klion26) commented on FLINK-12683: --- Please have a look at FLINK-1165.:) >

[jira] [Comment Edited] (FLINK-12683) Provide task manager's location information for checkpoint acknowledge message to improve the checkpoint log message

2019-05-30 Thread Congxian Qiu(klion26) (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852572#comment-16852572 ] Congxian Qiu(klion26) edited comment on FLINK-12683 at 5/31/19 2:03 AM:

[jira] [Created] (FLINK-12685) Supports UNNEST query in blink planner

2019-05-30 Thread godfrey he (JIRA)
godfrey he created FLINK-12685: -- Summary: Supports UNNEST query in blink planner Key: FLINK-12685 URL: https://issues.apache.org/jira/browse/FLINK-12685 Project: Flink Issue Type: New Feature

[jira] [Commented] (FLINK-10455) Potential Kafka producer leak in case of failures

2019-05-30 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852565#comment-16852565 ] sunjincheng commented on FLINK-10455: - Hi, [~cslotterback] thanks for your reply. and do not worry

[jira] [Assigned] (FLINK-10455) Potential Kafka producer leak in case of failures

2019-05-30 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng reassigned FLINK-10455: --- Assignee: Jiangjie Qin > Potential Kafka producer leak in case of failures >

[jira] [Commented] (FLINK-10455) Potential Kafka producer leak in case of failures

2019-05-30 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852563#comment-16852563 ] sunjincheng commented on FLINK-10455: - Hi [~becket_qin], I am very glad that you are willing to help

[GitHub] [flink] danny0405 commented on a change in pull request #8548: [FLINK-6962] [table] Add create(drop) table SQL DDL

2019-05-30 Thread GitBox
danny0405 commented on a change in pull request #8548: [FLINK-6962] [table] Add create(drop) table SQL DDL URL: https://github.com/apache/flink/pull/8548#discussion_r289230491 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8567: [FLINK-12676][table][sql-client] Add descriptor, validator, and factory of GenericInMemoryCatalog for table discovery service

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8567: [FLINK-12676][table][sql-client] Add descriptor, validator, and factory of GenericInMemoryCatalog for table discovery service URL: https://github.com/apache/flink/pull/8567#discussion_r289169055 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8567: [FLINK-12676][table][sql-client] Add descriptor, validator, and factory of GenericInMemoryCatalog for table discovery service

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8567: [FLINK-12676][table][sql-client] Add descriptor, validator, and factory of GenericInMemoryCatalog for table discovery service URL: https://github.com/apache/flink/pull/8567#discussion_r289166409 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8567: [FLINK-12676][table][sql-client] Add descriptor, validator, and factory of GenericInMemoryCatalog for table discovery service

2019-05-30 Thread GitBox
bowenli86 commented on a change in pull request #8567: [FLINK-12676][table][sql-client] Add descriptor, validator, and factory of GenericInMemoryCatalog for table discovery service URL: https://github.com/apache/flink/pull/8567#discussion_r289167578 ## File path:

[jira] [Created] (FLINK-12684) User defined configuration for per job clusters

2019-05-30 Thread Richard Moorhead (JIRA)
Richard Moorhead created FLINK-12684: Summary: User defined configuration for per job clusters Key: FLINK-12684 URL: https://issues.apache.org/jira/browse/FLINK-12684 Project: Flink

[jira] [Commented] (FLINK-10817) Upgrade presto dependency to support path-style access

2019-05-30 Thread Alexander Fedulov (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852258#comment-16852258 ] Alexander Fedulov commented on FLINK-10817: --- [~aljoscha] do you see anything that would block

[GitHub] [flink] xuefuz commented on issue #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS

2019-05-30 Thread GitBox
xuefuz commented on issue #8564: [FLINK-12649][hive] Add a shim layer to support multiple versions of HMS URL: https://github.com/apache/flink/pull/8564#issuecomment-497440703 For Hive versions, I think for now we can claim support only for versions like 1.2.1 explicitly. In theory is

[jira] [Commented] (FLINK-11921) Upgrade Calcite dependency to 1.19

2019-05-30 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852147#comment-16852147 ] Rong Rong commented on FLINK-11921: --- Hi [~twalthr], [~danny0405] and I discussed briefly that we will

[GitHub] [flink] xuefuz commented on a change in pull request #8567: [FLINK-12676][table][sql-client] Add descriptor, validator, and factory of GenericInMemoryCatalog for table discovery service

2019-05-30 Thread GitBox
xuefuz commented on a change in pull request #8567: [FLINK-12676][table][sql-client] Add descriptor, validator, and factory of GenericInMemoryCatalog for table discovery service URL: https://github.com/apache/flink/pull/8567#discussion_r289084623 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8567: [FLINK-12676][table][sql-client] Add descriptor, validator, and factory of GenericInMemoryCatalog for table discovery service

2019-05-30 Thread GitBox
xuefuz commented on a change in pull request #8567: [FLINK-12676][table][sql-client] Add descriptor, validator, and factory of GenericInMemoryCatalog for table discovery service URL: https://github.com/apache/flink/pull/8567#discussion_r289079158 ## File path:

[GitHub] [flink] flinkbot commented on issue #8577: [FLINK-10921] [kinesis] Shard watermark synchronization in Kinesis consumer

2019-05-30 Thread GitBox
flinkbot commented on issue #8577: [FLINK-10921] [kinesis] Shard watermark synchronization in Kinesis consumer URL: https://github.com/apache/flink/pull/8577#issuecomment-497399565 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[GitHub] [flink] tweise opened a new pull request #8577: [FLINK-10921] [kinesis] Shard watermark synchronization in Kinesis consumer

2019-05-30 Thread GitBox
tweise opened a new pull request #8577: [FLINK-10921] [kinesis] Shard watermark synchronization in Kinesis consumer URL: https://github.com/apache/flink/pull/8577 Backport https://github.com/apache/flink/pull/8517 This is an

[GitHub] [flink] xuefuz commented on a change in pull request #8567: [FLINK-12676][table][sql-client] Add descriptor, validator, and factory of GenericInMemoryCatalog for table discovery service

2019-05-30 Thread GitBox
xuefuz commented on a change in pull request #8567: [FLINK-12676][table][sql-client] Add descriptor, validator, and factory of GenericInMemoryCatalog for table discovery service URL: https://github.com/apache/flink/pull/8567#discussion_r289070336 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8567: [FLINK-12676][table][sql-client] Add descriptor, validator, and factory of GenericInMemoryCatalog for table discovery service

2019-05-30 Thread GitBox
xuefuz commented on a change in pull request #8567: [FLINK-12676][table][sql-client] Add descriptor, validator, and factory of GenericInMemoryCatalog for table discovery service URL: https://github.com/apache/flink/pull/8567#discussion_r289069456 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8567: [FLINK-12676][table][sql-client] Add descriptor, validator, and factory of GenericInMemoryCatalog for table discovery service

2019-05-30 Thread GitBox
xuefuz commented on a change in pull request #8567: [FLINK-12676][table][sql-client] Add descriptor, validator, and factory of GenericInMemoryCatalog for table discovery service URL: https://github.com/apache/flink/pull/8567#discussion_r289068202 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8320: [FLINK-12201][network, metrics] Introduce InputGateWithMetrics in Task to increment numBytesIn metric

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8320: [FLINK-12201][network,metrics] Introduce InputGateWithMetrics in Task to increment numBytesIn metric URL: https://github.com/apache/flink/pull/8320#discussion_r289016052 ## File path:

[GitHub] [flink] zhijiangW commented on issue #8518: [FLINK-12564][network] Remove getBufferProvider method from ResultPartitionWriter

2019-05-30 Thread GitBox
zhijiangW commented on issue #8518: [FLINK-12564][network] Remove getBufferProvider method from ResultPartitionWriter URL: https://github.com/apache/flink/pull/8518#issuecomment-497348585 @zentol Thanks for reviews and I pushed a fixup commit for removing `getBufferProvider` from

[GitHub] [flink] zhijiangW commented on a change in pull request #8518: [FLINK-12564][network] Remove getBufferProvider method from ResultPartitionWriter

2019-05-30 Thread GitBox
zhijiangW commented on a change in pull request #8518: [FLINK-12564][network] Remove getBufferProvider method from ResultPartitionWriter URL: https://github.com/apache/flink/pull/8518#discussion_r289011719 ## File path:

[GitHub] [flink] dianfu commented on issue #8474: [FLINK-12409][python] Adds from_elements in TableEnvironment

2019-05-30 Thread GitBox
dianfu commented on issue #8474: [FLINK-12409][python] Adds from_elements in TableEnvironment URL: https://github.com/apache/flink/pull/8474#issuecomment-497346537 @sunjincheng121 Thanks a lot for your review. Have updated the PR accordingly.

[GitHub] [flink] dianfu commented on a change in pull request #8474: [FLINK-12409][python] Adds from_elements in TableEnvironment

2019-05-30 Thread GitBox
dianfu commented on a change in pull request #8474: [FLINK-12409][python] Adds from_elements in TableEnvironment URL: https://github.com/apache/flink/pull/8474#discussion_r289010188 ## File path: docs/ops/cli.md ## @@ -100,40 +100,40 @@ These examples about how to submit

  1   2   3   >