[jira] [Commented] (FLINK-10817) Upgrade presto dependency to support path-style access

2019-06-04 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856413#comment-16856413 ] Chesnay Schepler commented on FLINK-10817: -- Could you not use the 1.8 version o

[jira] [Updated] (FLINK-12681) Provide an implementation of a thread-safe counter

2019-06-04 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-12681: - Component/s: (was: Connectors / ElasticSearch) > Provide an implementation of a thre

[jira] [Created] (FLINK-12735) Make shuffle environment implementation independent with IOManager

2019-06-04 Thread zhijiang (JIRA)
zhijiang created FLINK-12735: Summary: Make shuffle environment implementation independent with IOManager Key: FLINK-12735 URL: https://issues.apache.org/jira/browse/FLINK-12735 Project: Flink I

[GitHub] [flink] JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-06-04 Thread GitBox
JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290596646 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apa

[GitHub] [flink] twalthr commented on issue #8596: [FLINK-12254][table] Update table source and sinks to new type system

2019-06-04 Thread GitBox
twalthr commented on issue #8596: [FLINK-12254][table] Update table source and sinks to new type system URL: https://github.com/apache/flink/pull/8596#issuecomment-498957127 Thanks @dawidwys. Merging... This is an automated m

[GitHub] [flink] KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-06-04 Thread GitBox
KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290594004 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apac

[GitHub] [flink] JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-06-04 Thread GitBox
JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290590844 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apa

[GitHub] [flink] KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-06-04 Thread GitBox
KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290593795 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apac

[GitHub] [flink] asfgit closed pull request #8612: [FLINK-12726][table-common] Fix ANY type serialization

2019-06-04 Thread GitBox
asfgit closed pull request #8612: [FLINK-12726][table-common] Fix ANY type serialization URL: https://github.com/apache/flink/pull/8612 This is an automated message from the Apache Git Service. To respond to the message, ple

[jira] [Closed] (FLINK-12726) Fix ANY type serialization

2019-06-04 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-12726. Resolution: Fixed Fix Version/s: 1.9.0 Fixed in 1.9.0: 5f5f02b1272ceba5e72ac8bb29e3d260d66b

[GitHub] [flink] JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-06-04 Thread GitBox
JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290591671 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apa

[GitHub] [flink] JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-06-04 Thread GitBox
JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290590844 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apa

[GitHub] [flink] JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-06-04 Thread GitBox
JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290590844 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apa

[GitHub] [flink] JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-06-04 Thread GitBox
JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290590636 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apa

[GitHub] [flink] JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-06-04 Thread GitBox
JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290590585 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apa

[GitHub] [flink] JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-06-04 Thread GitBox
JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290590321 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apa

[GitHub] [flink] JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-06-04 Thread GitBox
JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290589983 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apa

[GitHub] [flink] lirui-apache commented on issue #8616: [FLINK-12718][hive] allow users to specify hive-site.xml location to configure hive metastore client in HiveCatalog

2019-06-04 Thread GitBox
lirui-apache commented on issue #8616: [FLINK-12718][hive] allow users to specify hive-site.xml location to configure hive metastore client in HiveCatalog URL: https://github.com/apache/flink/pull/8616#issuecomment-498946674 LGTM, thanks. ---

[GitHub] [flink] JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-06-04 Thread GitBox
JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290584736 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apa

[GitHub] [flink] JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-06-04 Thread GitBox
JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290584058 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apa

[GitHub] [flink] JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-06-04 Thread GitBox
JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290582852 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apa

[GitHub] [flink] JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-06-04 Thread GitBox
JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290579108 ## File path: flink-table/flink-table-planner-blink/src/main/java/org/apac

[GitHub] [flink] KurtYoung commented on a change in pull request #8294: [FLINK-12348][table-planner-blink]Use TableConfig in api module to replace TableConfig in blink-planner module.

2019-06-04 Thread GitBox
KurtYoung commented on a change in pull request #8294: [FLINK-12348][table-planner-blink]Use TableConfig in api module to replace TableConfig in blink-planner module. URL: https://github.com/apache/flink/pull/8294#discussion_r290578406 ## File path: flink-table/flink-table-planner

[GitHub] [flink] JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-06-04 Thread GitBox
JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290577508 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apa

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-04 Thread GitBox
zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290576941 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/Stream

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-04 Thread GitBox
zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290576205 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/ShuffleEnvironment

[GitHub] [flink] KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-06-04 Thread GitBox
KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290567350 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apac

[GitHub] [flink] KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-06-04 Thread GitBox
KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290568068 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apac

[GitHub] [flink] KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-06-04 Thread GitBox
KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290568801 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apac

[GitHub] [flink] KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-06-04 Thread GitBox
KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290568259 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apac

[GitHub] [flink] KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-06-04 Thread GitBox
KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290565250 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apac

[GitHub] [flink] KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-06-04 Thread GitBox
KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290575834 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apach

[GitHub] [flink] KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-06-04 Thread GitBox
KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290575554 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apach

[GitHub] [flink] KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-06-04 Thread GitBox
KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290569286 ## File path: flink-table/flink-table-planner-blink/src/main/java/org/apach

[GitHub] [flink] KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-06-04 Thread GitBox
KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290568945 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apac

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-04 Thread GitBox
zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290575983 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/ShuffleEnvironment

[GitHub] [flink] KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-06-04 Thread GitBox
KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290567916 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apac

[GitHub] [flink] KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-06-04 Thread GitBox
KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290568761 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apac

[GitHub] [flink] KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-06-04 Thread GitBox
KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290568189 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apac

[GitHub] [flink] KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-06-04 Thread GitBox
KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290568669 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apac

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-04 Thread GitBox
zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290575541 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/ShuffleEnvironment

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-04 Thread GitBox
zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290575541 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/ShuffleEnvironment

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-04 Thread GitBox
zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290575250 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/ShuffleEnvironment

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-04 Thread GitBox
zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290575205 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/ShuffleEnvironment

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-04 Thread GitBox
zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290575052 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/ShuffleEnvironment

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-04 Thread GitBox
zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290574817 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/ShuffleEnvironment

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-04 Thread GitBox
zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290574645 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/ShuffleEnvironment

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-04 Thread GitBox
zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290574532 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/ShuffleEnvironment

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-04 Thread GitBox
zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290574315 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/ShuffleEnvironment

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-04 Thread GitBox
zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290573784 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/ShuffleEnvironment

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-04 Thread GitBox
zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290573391 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/ShuffleEnvironment

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-04 Thread GitBox
zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290573231 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/ShuffleEnvironment

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-04 Thread GitBox
zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290572726 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/ShuffleEnvironment

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-04 Thread GitBox
zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290572426 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/ShuffleEnvironment

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-04 Thread GitBox
zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290572212 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/ShuffleEnvironment

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-04 Thread GitBox
zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290572080 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/TaskCh

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-04 Thread GitBox
zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290572037 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/Synchr

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-04 Thread GitBox
zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290571983 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/Stream

[jira] [Commented] (FLINK-9465) Separate timeout for savepoint and checkpoint

2019-06-04 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856306#comment-16856306 ] vinoyang commented on FLINK-9465: - [~kien_truong] About the savepoint timeout config opti

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-04 Thread GitBox
zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290571947 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/Stream

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-04 Thread GitBox
zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290571622 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment

[jira] [Updated] (FLINK-12734) remove getVolcanoPlanner method from FlinkOptimizeContext and RelNodeBlock does not depend on TableEnvironment

2019-06-04 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-12734: --- Description: there are two improvements: 1. remove {{getVolcanoPlanner}} method from {{FlinkOptimize

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-04 Thread GitBox
zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290571356 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment

[GitHub] [flink] flinkbot commented on issue #8619: [FLINK-12734] [table-planner-blink] remove getVolcanoPlanner method from FlinkOptimizeContext and RelNodeBlock does not depend on TableEnvironment

2019-06-04 Thread GitBox
flinkbot commented on issue #8619: [FLINK-12734] [table-planner-blink] remove getVolcanoPlanner method from FlinkOptimizeContext and RelNodeBlock does not depend on TableEnvironment URL: https://github.com/apache/flink/pull/8619#issuecomment-498926318 Thanks a lot for your contribution to

[jira] [Updated] (FLINK-12734) remove getVolcanoPlanner method from FlinkOptimizeContext and RelNodeBlock does not depend on TableEnvironment

2019-06-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12734: --- Labels: pull-request-available (was: ) > remove getVolcanoPlanner method from FlinkOptimize

[GitHub] [flink] godfreyhe opened a new pull request #8619: [FLINK-12734] [table-planner-blink] remove getVolcanoPlanner method from FlinkOptimizeContext and RelNodeBlock does not depend on TableEnvir

2019-06-04 Thread GitBox
godfreyhe opened a new pull request #8619: [FLINK-12734] [table-planner-blink] remove getVolcanoPlanner method from FlinkOptimizeContext and RelNodeBlock does not depend on TableEnvironment URL: https://github.com/apache/flink/pull/8619 ## What is the purpose of the change *remo

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-04 Thread GitBox
zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290570744 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-04 Thread GitBox
zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290570600 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment

[jira] [Commented] (FLINK-12733) Expose Rest API for TERMINATE/SUSPEND Job with Checkpoint

2019-06-04 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856296#comment-16856296 ] vinoyang commented on FLINK-12733: -- [~klion26] I think it would be better to discuss an

[jira] [Created] (FLINK-12734) remove getVolcanoPlanner method from FlinkOptimizeContext and RelNodeBlock does not depend on TableEnvironment

2019-06-04 Thread godfrey he (JIRA)
godfrey he created FLINK-12734: -- Summary: remove getVolcanoPlanner method from FlinkOptimizeContext and RelNodeBlock does not depend on TableEnvironment Key: FLINK-12734 URL: https://issues.apache.org/jira/browse/FLI

[GitHub] [flink] carp84 commented on a change in pull request #8617: [FLINK-12619][StateBackend]Support TERMINATE/SUSPEND Job with Checkpoint

2019-06-04 Thread GitBox
carp84 commented on a change in pull request #8617: [FLINK-12619][StateBackend]Support TERMINATE/SUSPEND Job with Checkpoint URL: https://github.com/apache/flink/pull/8617#discussion_r290567794 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/LegacySched

[GitHub] [flink] carp84 commented on a change in pull request #8617: [FLINK-12619][StateBackend]Support TERMINATE/SUSPEND Job with Checkpoint

2019-06-04 Thread GitBox
carp84 commented on a change in pull request #8617: [FLINK-12619][StateBackend]Support TERMINATE/SUSPEND Job with Checkpoint URL: https://github.com/apache/flink/pull/8617#discussion_r290563567 ## File path: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.

[GitHub] [flink] carp84 commented on a change in pull request #8617: [FLINK-12619][StateBackend]Support TERMINATE/SUSPEND Job with Checkpoint

2019-06-04 Thread GitBox
carp84 commented on a change in pull request #8617: [FLINK-12619][StateBackend]Support TERMINATE/SUSPEND Job with Checkpoint URL: https://github.com/apache/flink/pull/8617#discussion_r290567687 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/Checkpoint

[GitHub] [flink] carp84 commented on a change in pull request #8617: [FLINK-12619][StateBackend]Support TERMINATE/SUSPEND Job with Checkpoint

2019-06-04 Thread GitBox
carp84 commented on a change in pull request #8617: [FLINK-12619][StateBackend]Support TERMINATE/SUSPEND Job with Checkpoint URL: https://github.com/apache/flink/pull/8617#discussion_r290561763 ## File path: flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-04 Thread GitBox
zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290568555 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-04 Thread GitBox
zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290568168 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskManagerServi

[jira] [Assigned] (FLINK-12662) show jobs failover in history server as well

2019-06-04 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-12662: Assignee: vinoyang > show jobs failover in history server as well > -

[jira] [Commented] (FLINK-12662) show jobs failover in history server as well

2019-06-04 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856289#comment-16856289 ] vinoyang commented on FLINK-12662: -- Thanks [~till.rohrmann] for approving this issue. a

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-04 Thread GitBox
zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290567675 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/state/TaskExecutorLocalStateS

[GitHub] [flink] lirui-apache commented on issue #8610: [FLINK-12715][hive] Hive-1.2.1 build is broken

2019-06-04 Thread GitBox
lirui-apache commented on issue #8610: [FLINK-12715][hive] Hive-1.2.1 build is broken URL: https://github.com/apache/flink/pull/8610#issuecomment-498921767 I also prefer to keep HiveShim generic. Actually APIs in HiveShim like `getViews` and `getFunction` take a `IMetaStoreClient` as param

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-04 Thread GitBox
zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290567322 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/NetworkEnvironmen

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-04 Thread GitBox
zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290567072 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServi

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-04 Thread GitBox
zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290566895 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServi

[GitHub] [flink] Aitozi commented on issue #8280: [FLINK-12297]Harden ClosureCleaner to handle the wrapped function

2019-06-04 Thread GitBox
Aitozi commented on issue #8280: [FLINK-12297]Harden ClosureCleaner to handle the wrapped function URL: https://github.com/apache/flink/pull/8280#issuecomment-498920811 One way to my mind: set the scattered `clean()` method with the `TOP_LEVEL` to keep the old way, And set `checkSerializab

[GitHub] [flink] Aitozi edited a comment on issue #8280: [FLINK-12297]Harden ClosureCleaner to handle the wrapped function

2019-06-04 Thread GitBox
Aitozi edited a comment on issue #8280: [FLINK-12297]Harden ClosureCleaner to handle the wrapped function URL: https://github.com/apache/flink/pull/8280#issuecomment-498756627 I know you mean, and I think it's hard to config the scattered `clean()` used in functions like `connector`, `Patt

[GitHub] [flink] JingsongLi commented on a change in pull request #8578: [FLINK-12685] [table-planner-blink] Supports UNNEST query in blink planner

2019-06-04 Thread GitBox
JingsongLi commented on a change in pull request #8578: [FLINK-12685] [table-planner-blink] Supports UNNEST query in blink planner URL: https://github.com/apache/flink/pull/8578#discussion_r290563675 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flin

[GitHub] [flink] JingsongLi commented on a change in pull request #8578: [FLINK-12685] [table-planner-blink] Supports UNNEST query in blink planner

2019-06-04 Thread GitBox
JingsongLi commented on a change in pull request #8578: [FLINK-12685] [table-planner-blink] Supports UNNEST query in blink planner URL: https://github.com/apache/flink/pull/8578#discussion_r290565276 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flin

[GitHub] [flink] JingsongLi commented on a change in pull request #8578: [FLINK-12685] [table-planner-blink] Supports UNNEST query in blink planner

2019-06-04 Thread GitBox
JingsongLi commented on a change in pull request #8578: [FLINK-12685] [table-planner-blink] Supports UNNEST query in blink planner URL: https://github.com/apache/flink/pull/8578#discussion_r290564818 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flin

[GitHub] [flink] Aitozi removed a comment on issue #8280: [FLINK-12297]Harden ClosureCleaner to handle the wrapped function

2019-06-04 Thread GitBox
Aitozi removed a comment on issue #8280: [FLINK-12297]Harden ClosureCleaner to handle the wrapped function URL: https://github.com/apache/flink/pull/8280#issuecomment-498759646 I think it over again, it can be removed directly. And after this the clean method should not be directly used, i

[GitHub] [flink] JingsongLi commented on a change in pull request #8578: [FLINK-12685] [table-planner-blink] Supports UNNEST query in blink planner

2019-06-04 Thread GitBox
JingsongLi commented on a change in pull request #8578: [FLINK-12685] [table-planner-blink] Supports UNNEST query in blink planner URL: https://github.com/apache/flink/pull/8578#discussion_r290564411 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flin

[GitHub] [flink] JingsongLi commented on a change in pull request #8578: [FLINK-12685] [table-planner-blink] Supports UNNEST query in blink planner

2019-06-04 Thread GitBox
JingsongLi commented on a change in pull request #8578: [FLINK-12685] [table-planner-blink] Supports UNNEST query in blink planner URL: https://github.com/apache/flink/pull/8578#discussion_r290563400 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flin

[jira] [Commented] (FLINK-12662) show jobs failover in history server as well

2019-06-04 Thread Su Ralph (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856278#comment-16856278 ] Su Ralph commented on FLINK-12662: -- Thanks [~till.rohrmann]. That's good as well, and p

[jira] [Commented] (FLINK-9465) Separate timeout for savepoint and checkpoint

2019-06-04 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856276#comment-16856276 ] vinoyang commented on FLINK-9465: - [~till.rohrmann] thanks for approving this issue, I am

[GitHub] [flink] sunjincheng121 commented on issue #8550: [FLINK-12401][table] Support incremental emit under AccRetract mode for non-window streaming FlatAggregate on Table API

2019-06-04 Thread GitBox
sunjincheng121 commented on issue #8550: [FLINK-12401][table] Support incremental emit under AccRetract mode for non-window streaming FlatAggregate on Table API URL: https://github.com/apache/flink/pull/8550#issuecomment-498913495 Since the execution mode of the Stream operator has two mod

[GitHub] [flink] tzulitai commented on issue #8618: [FLINK-12732][state-processor-api] Add savepoint reader for consuming partitioned operator state

2019-06-04 Thread GitBox
tzulitai commented on issue #8618: [FLINK-12732][state-processor-api] Add savepoint reader for consuming partitioned operator state URL: https://github.com/apache/flink/pull/8618#issuecomment-498912234 @flinkbot approve description @flinkbot approve consensus --

[GitHub] [flink] tzulitai commented on issue #8615: [FLINK-12729][state-processor-api] Add state reader for consuming non-partitioned operator state

2019-06-04 Thread GitBox
tzulitai commented on issue #8615: [FLINK-12729][state-processor-api] Add state reader for consuming non-partitioned operator state URL: https://github.com/apache/flink/pull/8615#issuecomment-498911292 @flinkbot approve description @flinkbot approve consensus --

[jira] [Commented] (FLINK-12709) Implement RestartBackoffTimeStrategyFactoryLoader

2019-06-04 Thread Zhu Zhu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856258#comment-16856258 ] Zhu Zhu commented on FLINK-12709: - Thanks [~rmetzger]. Sorry for missing setting the re

[GitHub] [flink] carp84 commented on a change in pull request #8617: [FLINK-12619][StateBackend]Support TERMINATE/SUSPEND Job with Checkpoint

2019-06-04 Thread GitBox
carp84 commented on a change in pull request #8617: [FLINK-12619][StateBackend]Support TERMINATE/SUSPEND Job with Checkpoint URL: https://github.com/apache/flink/pull/8617#discussion_r290559979 ## File path: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java

[jira] [Commented] (FLINK-12608) Add getVertex/ResultPartitionOrThrow(ExecutionVertexID/IntermediateResultPartitionID) to SchedulingTopology

2019-06-04 Thread BoWang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856241#comment-16856241 ] BoWang commented on FLINK-12608: OK, thanks [~rmetzger]. > Add > getVertex/ResultParti

[jira] [Updated] (FLINK-12608) Add getVertex/ResultPartitionOrThrow(ExecutionVertexID/IntermediateResultPartitionID) to SchedulingTopology

2019-06-04 Thread BoWang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BoWang updated FLINK-12608: --- Affects Version/s: 1.9.0 > Add > getVertex/ResultPartitionOrThrow(ExecutionVertexID/IntermediateResultParti

  1   2   3   4   5   >