[jira] [Commented] (FLINK-12811) flink-table-planner-blink compile error

2019-06-11 Thread Liya Fan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861775#comment-16861775 ] Liya Fan commented on FLINK-12811: -- I tried two different versions of JDK1.8, but could not reproduce

[jira] [Comment Edited] (FLINK-12811) flink-table-planner-blink compile error

2019-06-11 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861774#comment-16861774 ] godfrey he edited comment on FLINK-12811 at 6/12/19 5:56 AM: - There are a

[jira] [Commented] (FLINK-12811) flink-table-planner-blink compile error

2019-06-11 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861774#comment-16861774 ] godfrey he commented on FLINK-12811: There are a few strange ERRORs:  1.    {code:java}

[jira] [Comment Edited] (FLINK-12811) flink-table-planner-blink compile error

2019-06-11 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861774#comment-16861774 ] godfrey he edited comment on FLINK-12811 at 6/12/19 5:47 AM: - There are a

[GitHub] [flink] wuchong commented on issue #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

2019-06-11 Thread GitBox
wuchong commented on issue #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#issuecomment-501128458 Hi @aljoscha , Thanks very much for the suggestions. Regarding to the `TableStats`. The

[GitHub] [flink] dianfu commented on a change in pull request #8623: [FLINK-12719][python] Add the Python catalog API

2019-06-11 Thread GitBox
dianfu commented on a change in pull request #8623: [FLINK-12719][python] Add the Python catalog API URL: https://github.com/apache/flink/pull/8623#discussion_r292751510 ## File path: flink-python/pyflink/table/catalog.py ## @@ -0,0 +1,904 @@

[GitHub] [flink] KurtYoung commented on issue #8700: [FLINK-12657][hive] Integrate Flink with Hive UDF

2019-06-11 Thread GitBox
KurtYoung commented on issue #8700: [FLINK-12657][hive] Integrate Flink with Hive UDF URL: https://github.com/apache/flink/pull/8700#issuecomment-501124974 @flinkbot attention @JingsongLi This is an automated message from

[GitHub] [flink] zentol commented on issue #8687: [FLINK-12612][coordination] Track stored partition on the TaskExecutor

2019-06-11 Thread GitBox
zentol commented on issue #8687: [FLINK-12612][coordination] Track stored partition on the TaskExecutor URL: https://github.com/apache/flink/pull/8687#issuecomment-501124068 Note that the commit about maintaining the jobmanager connection must not be merged until the release logic on the

[GitHub] [flink] flinkbot commented on issue #8700: [FLINK-12657][hive] Integrate Flink with Hive UDF

2019-06-11 Thread GitBox
flinkbot commented on issue #8700: [FLINK-12657][hive] Integrate Flink with Hive UDF URL: https://github.com/apache/flink/pull/8700#issuecomment-501123855 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull

[jira] [Updated] (FLINK-12657) Integrate Flink with Hive UDF

2019-06-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12657: --- Labels: pull-request-available (was: ) > Integrate Flink with Hive UDF >

[GitHub] [flink] bowenli86 opened a new pull request #8700: [FLINK-12657][hive] Integrate Flink with Hive UDF

2019-06-11 Thread GitBox
bowenli86 opened a new pull request #8700: [FLINK-12657][hive] Integrate Flink with Hive UDF URL: https://github.com/apache/flink/pull/8700 ## What is the purpose of the change This PR integrates Flink with Hive UDF. Background: given that integrating Flink with Hive

[GitHub] [flink] dianfu commented on a change in pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API

2019-06-11 Thread GitBox
dianfu commented on a change in pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API URL: https://github.com/apache/flink/pull/8681#discussion_r292270361 ## File path: flink-python/pyflink/common/checkpoint_config.py ## @@ -0,0

[GitHub] [flink] dianfu commented on a change in pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API

2019-06-11 Thread GitBox
dianfu commented on a change in pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API URL: https://github.com/apache/flink/pull/8681#discussion_r292287750 ## File path: flink-python/pyflink/streaming/stream_execution_environment.py

[GitHub] [flink] dianfu commented on a change in pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API

2019-06-11 Thread GitBox
dianfu commented on a change in pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API URL: https://github.com/apache/flink/pull/8681#discussion_r292261331 ## File path: flink-python/pyflink/batch/execution_environment.py ## @@

[GitHub] [flink] dianfu commented on a change in pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API

2019-06-11 Thread GitBox
dianfu commented on a change in pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API URL: https://github.com/apache/flink/pull/8681#discussion_r292254893 ## File path: flink-python/pyflink/common/checkpointing_mode.py ## @@ -0,0

[GitHub] [flink] dianfu commented on issue #8675: [FLINK-12716][python] Add an interactive shell for Python Table API

2019-06-11 Thread GitBox
dianfu commented on issue #8675: [FLINK-12716][python] Add an interactive shell for Python Table API URL: https://github.com/apache/flink/pull/8675#issuecomment-501117517 LGTM now. +1 This is an automated message from the

[GitHub] [flink] dianfu commented on a change in pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API

2019-06-11 Thread GitBox
dianfu commented on a change in pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API URL: https://github.com/apache/flink/pull/8681#discussion_r292262151 ## File path: flink-python/pyflink/batch/execution_environment.py ## @@

[GitHub] [flink] dianfu commented on a change in pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API

2019-06-11 Thread GitBox
dianfu commented on a change in pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API URL: https://github.com/apache/flink/pull/8681#discussion_r292742628 ## File path: flink-python/pyflink/common/state_backend.py ## @@ -0,0

[GitHub] [flink] dianfu commented on a change in pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API

2019-06-11 Thread GitBox
dianfu commented on a change in pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API URL: https://github.com/apache/flink/pull/8681#discussion_r292288418 ## File path: flink-python/pyflink/common/state_backend.py ## @@ -0,0

[GitHub] [flink] dianfu commented on a change in pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API

2019-06-11 Thread GitBox
dianfu commented on a change in pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API URL: https://github.com/apache/flink/pull/8681#discussion_r292257254 ## File path: flink-python/pyflink/common/execution_config.py ## @@ -0,0

[GitHub] [flink] dianfu commented on a change in pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API

2019-06-11 Thread GitBox
dianfu commented on a change in pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API URL: https://github.com/apache/flink/pull/8681#discussion_r292272021 ## File path: flink-python/pyflink/common/execution_config.py ## @@ -0,0

[GitHub] [flink] dianfu commented on a change in pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API

2019-06-11 Thread GitBox
dianfu commented on a change in pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API URL: https://github.com/apache/flink/pull/8681#discussion_r292271670 ## File path: flink-python/pyflink/common/execution_config.py ## @@ -0,0

[GitHub] [flink] dianfu commented on a change in pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API

2019-06-11 Thread GitBox
dianfu commented on a change in pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API URL: https://github.com/apache/flink/pull/8681#discussion_r292290488 ## File path: flink-python/pyflink/streaming/stream_execution_environment.py

[GitHub] [flink] dianfu commented on a change in pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API

2019-06-11 Thread GitBox
dianfu commented on a change in pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API URL: https://github.com/apache/flink/pull/8681#discussion_r292271434 ## File path: flink-python/pyflink/common/checkpoint_config.py ## @@ -0,0

[GitHub] [flink] zhijiangW commented on a change in pull request #8687: [FLINK-12612][coordination] Track stored partition on the TaskExecutor

2019-06-11 Thread GitBox
zhijiangW commented on a change in pull request #8687: [FLINK-12612][coordination] Track stored partition on the TaskExecutor URL: https://github.com/apache/flink/pull/8687#discussion_r292737466 ## File path:

[GitHub] [flink] dianfu commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API

2019-06-11 Thread GitBox
dianfu commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API URL: https://github.com/apache/flink/pull/8675#discussion_r292726089 ## File path: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java

[GitHub] [flink] liyafan82 commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-06-11 Thread GitBox
liyafan82 commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#discussion_r292741747 ## File path:

[GitHub] [flink] dianfu commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API

2019-06-11 Thread GitBox
dianfu commented on a change in pull request #8675: [FLINK-12716][python] Add an interactive shell for Python Table API URL: https://github.com/apache/flink/pull/8675#discussion_r292436962 ## File path:

[GitHub] [flink] Myasuka commented on issue #8693: [FLINK-8871] Support to cancel checkpoing via notification

2019-06-11 Thread GitBox
Myasuka commented on issue #8693: [FLINK-8871] Support to cancel checkpoing via notification URL: https://github.com/apache/flink/pull/8693#issuecomment-501113747 Previous check failed due to downloading kafka tar package unsuccessfully (please refer to build

[GitHub] [flink] shuai-xu commented on a change in pull request #8486: [FLINK-12372] [runtime] implement ExecutionSlotAllocator

2019-06-11 Thread GitBox
shuai-xu commented on a change in pull request #8486: [FLINK-12372] [runtime] implement ExecutionSlotAllocator URL: https://github.com/apache/flink/pull/8486#discussion_r292740235 ## File path:

[GitHub] [flink] becketqin commented on issue #8699: [FLINK-10455][Connectors/Kafka] Ensure all the KafkaProducers closed …

2019-06-11 Thread GitBox
becketqin commented on issue #8699: [FLINK-10455][Connectors/Kafka] Ensure all the KafkaProducers closed … URL: https://github.com/apache/flink/pull/8699#issuecomment-501112558 @flinkbot attention @pnowojski This is an

[GitHub] [flink] flinkbot commented on issue #8699: [FLINK-10455][Connectors/Kafka] Ensure all the KafkaProducers closed …

2019-06-11 Thread GitBox
flinkbot commented on issue #8699: [FLINK-10455][Connectors/Kafka] Ensure all the KafkaProducers closed … URL: https://github.com/apache/flink/pull/8699#issuecomment-501112402 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[GitHub] [flink] liyafan82 commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-06-11 Thread GitBox
liyafan82 commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#discussion_r292739356 ## File path:

[GitHub] [flink] becketqin opened a new pull request #8699: [FLINK-10455][Connectors/Kafka] Ensure all the KafkaProducers closed …

2019-06-11 Thread GitBox
becketqin opened a new pull request #8699: [FLINK-10455][Connectors/Kafka] Ensure all the KafkaProducers closed … URL: https://github.com/apache/flink/pull/8699 …on an exception The patch fixes the bugs reported in FLINK-10445 by making sure all the KafkaProducers are closed when

[GitHub] [flink] zhijiangW commented on a change in pull request #8687: [FLINK-12612][coordination] Track stored partition on the TaskExecutor

2019-06-11 Thread GitBox
zhijiangW commented on a change in pull request #8687: [FLINK-12612][coordination] Track stored partition on the TaskExecutor URL: https://github.com/apache/flink/pull/8687#discussion_r292737578 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8687: [FLINK-12612][coordination] Track stored partition on the TaskExecutor

2019-06-11 Thread GitBox
zhijiangW commented on a change in pull request #8687: [FLINK-12612][coordination] Track stored partition on the TaskExecutor URL: https://github.com/apache/flink/pull/8687#discussion_r292737466 ## File path:

[GitHub] [flink] flinkbot commented on issue #8698: [FLINK-12669][runtime] Implement FixedDelayRestartBackoffTimeStrategy

2019-06-11 Thread GitBox
flinkbot commented on issue #8698: [FLINK-12669][runtime] Implement FixedDelayRestartBackoffTimeStrategy URL: https://github.com/apache/flink/pull/8698#issuecomment-501109773 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[jira] [Updated] (FLINK-12669) Implement FixedDelayRestartBackoffTimeStrategy

2019-06-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12669: --- Labels: pull-request-available (was: ) > Implement FixedDelayRestartBackoffTimeStrategy >

[GitHub] [flink] eaglewatcherwb opened a new pull request #8698: [FLINK-12669][runtime] Implement FixedDelayRestartBackoffTimeStrategy

2019-06-11 Thread GitBox
eaglewatcherwb opened a new pull request #8698: [FLINK-12669][runtime] Implement FixedDelayRestartBackoffTimeStrategy URL: https://github.com/apache/flink/pull/8698 ## What is the purpose of the change *Implement FixedDelayRestartBackoffTimeStrategy.* ## Brief

[GitHub] [flink] asfgit closed pull request #8575: [FLINK-12583][python] Add all format support align with the Java Table API.

2019-06-11 Thread GitBox
asfgit closed pull request #8575: [FLINK-12583][python] Add all format support align with the Java Table API. URL: https://github.com/apache/flink/pull/8575 This is an automated message from the Apache Git Service. To

[jira] [Closed] (FLINK-12583) Add all format support align with the Java Table API

2019-06-11 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng closed FLINK-12583. --- Resolution: Fixed Fix Version/s: 1.9.0 Fixed in

[jira] [Created] (FLINK-12811) flink-table-planner-blink compile error

2019-06-11 Thread vinoyang (JIRA)
vinoyang created FLINK-12811: Summary: flink-table-planner-blink compile error Key: FLINK-12811 URL: https://issues.apache.org/jira/browse/FLINK-12811 Project: Flink Issue Type: Bug

[GitHub] [flink] tianchen92 opened a new pull request #8552: [FLINK-12631]:Check if proper JAR file in JobWithJars

2019-06-11 Thread GitBox
tianchen92 opened a new pull request #8552: [FLINK-12631]:Check if proper JAR file in JobWithJars URL: https://github.com/apache/flink/pull/8552 ## What is the purpose of the change *Related to FLINK-12631. Check if proper JAR file in JobWithJars.* ## Brief change log

[GitHub] [flink] tianchen92 closed pull request #8552: [FLINK-12631]:Check if proper JAR file in JobWithJars

2019-06-11 Thread GitBox
tianchen92 closed pull request #8552: [FLINK-12631]:Check if proper JAR file in JobWithJars URL: https://github.com/apache/flink/pull/8552 This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Comment Edited] (FLINK-12776) Ambiguous content in flink-dist NOTICE file

2019-06-11 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861680#comment-16861680 ] sunjincheng edited comment on FLINK-12776 at 6/12/19 3:34 AM: --  @stephan

[GitHub] [flink] bowenli86 edited a comment on issue #8614: [FLINK-12727][hive] Make HiveTableOutputFormat support writing partitioned table

2019-06-11 Thread GitBox
bowenli86 edited a comment on issue #8614: [FLINK-12727][hive] Make HiveTableOutputFormat support writing partitioned table URL: https://github.com/apache/flink/pull/8614#issuecomment-501107686 LGTM. Thanks @lirui-apache for your contribution! Will merge once CI turns green

[GitHub] [flink] bowenli86 commented on issue #8614: [FLINK-12727][hive] Make HiveTableOutputFormat support writing partitioned table

2019-06-11 Thread GitBox
bowenli86 commented on issue #8614: [FLINK-12727][hive] Make HiveTableOutputFormat support writing partitioned table URL: https://github.com/apache/flink/pull/8614#issuecomment-501107686 LGTM. Will merge once CI turns green

[GitHub] [flink] shuai-xu commented on a change in pull request #8486: [FLINK-12372] [runtime] implement ExecutionSlotAllocator

2019-06-11 Thread GitBox
shuai-xu commented on a change in pull request #8486: [FLINK-12372] [runtime] implement ExecutionSlotAllocator URL: https://github.com/apache/flink/pull/8486#discussion_r292734508 ## File path:

[GitHub] [flink] shuai-xu commented on a change in pull request #8486: [FLINK-12372] [runtime] implement ExecutionSlotAllocator

2019-06-11 Thread GitBox
shuai-xu commented on a change in pull request #8486: [FLINK-12372] [runtime] implement ExecutionSlotAllocator URL: https://github.com/apache/flink/pull/8486#discussion_r292734508 ## File path:

[GitHub] [flink] shuai-xu commented on a change in pull request #8486: [FLINK-12372] [runtime] implement ExecutionSlotAllocator

2019-06-11 Thread GitBox
shuai-xu commented on a change in pull request #8486: [FLINK-12372] [runtime] implement ExecutionSlotAllocator URL: https://github.com/apache/flink/pull/8486#discussion_r292734501 ## File path:

[GitHub] [flink] shuai-xu commented on a change in pull request #8486: [FLINK-12372] [runtime] implement ExecutionSlotAllocator

2019-06-11 Thread GitBox
shuai-xu commented on a change in pull request #8486: [FLINK-12372] [runtime] implement ExecutionSlotAllocator URL: https://github.com/apache/flink/pull/8486#discussion_r292734488 ## File path:

[GitHub] [flink] shuai-xu commented on a change in pull request #8486: [FLINK-12372] [runtime] implement ExecutionSlotAllocator

2019-06-11 Thread GitBox
shuai-xu commented on a change in pull request #8486: [FLINK-12372] [runtime] implement ExecutionSlotAllocator URL: https://github.com/apache/flink/pull/8486#discussion_r292734523 ## File path:

[GitHub] [flink] shuai-xu commented on a change in pull request #8486: [FLINK-12372] [runtime] implement ExecutionSlotAllocator

2019-06-11 Thread GitBox
shuai-xu commented on a change in pull request #8486: [FLINK-12372] [runtime] implement ExecutionSlotAllocator URL: https://github.com/apache/flink/pull/8486#discussion_r292734550 ## File path:

[GitHub] [flink] shuai-xu commented on a change in pull request #8486: [FLINK-12372] [runtime] implement ExecutionSlotAllocator

2019-06-11 Thread GitBox
shuai-xu commented on a change in pull request #8486: [FLINK-12372] [runtime] implement ExecutionSlotAllocator URL: https://github.com/apache/flink/pull/8486#discussion_r292734536 ## File path:

[GitHub] [flink] shuai-xu commented on a change in pull request #8486: [FLINK-12372] [runtime] implement ExecutionSlotAllocator

2019-06-11 Thread GitBox
shuai-xu commented on a change in pull request #8486: [FLINK-12372] [runtime] implement ExecutionSlotAllocator URL: https://github.com/apache/flink/pull/8486#discussion_r292734425 ## File path:

[GitHub] [flink] shuai-xu commented on a change in pull request #8486: [FLINK-12372] [runtime] implement ExecutionSlotAllocator

2019-06-11 Thread GitBox
shuai-xu commented on a change in pull request #8486: [FLINK-12372] [runtime] implement ExecutionSlotAllocator URL: https://github.com/apache/flink/pull/8486#discussion_r292734436 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #8697: [FLINK-12810][table-planner-blink] Support to run a TableAPI query like 'table.select('a, 'b, 'c)'

2019-06-11 Thread GitBox
JingsongLi commented on a change in pull request #8697: [FLINK-12810][table-planner-blink] Support to run a TableAPI query like 'table.select('a, 'b, 'c)' URL: https://github.com/apache/flink/pull/8697#discussion_r292734264 ## File path: tools/maven/suppressions.xml ##

[jira] [Comment Edited] (FLINK-12776) Ambiguous content in flink-dist NOTICE file

2019-06-11 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861680#comment-16861680 ] sunjincheng edited comment on FLINK-12776 at 6/12/19 3:22 AM: -- @stephan

[jira] [Comment Edited] (FLINK-12776) Ambiguous content in flink-dist NOTICE file

2019-06-11 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861680#comment-16861680 ] sunjincheng edited comment on FLINK-12776 at 6/12/19 3:20 AM: -- @stephan

[GitHub] [flink] liyafan82 commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-06-11 Thread GitBox
liyafan82 commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#discussion_r292733061 ## File path:

[GitHub] [flink] wuchong commented on issue #8695: [FLINK-12805][FLINK-12808][FLINK-12809][table-api] Introduce PartitionableTableSource and PartitionableTableSink and OverwritableTableSink

2019-06-11 Thread GitBox
wuchong commented on issue #8695: [FLINK-12805][FLINK-12808][FLINK-12809][table-api] Introduce PartitionableTableSource and PartitionableTableSink and OverwritableTableSink URL: https://github.com/apache/flink/pull/8695#issuecomment-501104064 Sure @KurtYoung , I have split into 3 commits.

[GitHub] [flink] lirui-apache commented on issue #8614: [FLINK-12727][hive] Make HiveTableOutputFormat support writing partitioned table

2019-06-11 Thread GitBox
lirui-apache commented on issue #8614: [FLINK-12727][hive] Make HiveTableOutputFormat support writing partitioned table URL: https://github.com/apache/flink/pull/8614#issuecomment-501103952 Update to address comments. I moved creating Hive partition to `HiveTableUtil`, so that we don't

[GitHub] [flink] flinkbot commented on issue #8697: [FLINK-12810][table-planner-blink] Support to run a TableAPI query like 'table.select('a, 'b, 'c)'

2019-06-11 Thread GitBox
flinkbot commented on issue #8697: [FLINK-12810][table-planner-blink] Support to run a TableAPI query like 'table.select('a, 'b, 'c)' URL: https://github.com/apache/flink/pull/8697#issuecomment-501102816 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I

[GitHub] [flink] beyond1920 opened a new pull request #8697: [FLINK-12810][table-planner-blink] Support to run a TableAPI query like 'table.select('a, 'b, 'c)'

2019-06-11 Thread GitBox
beyond1920 opened a new pull request #8697: [FLINK-12810][table-planner-blink] Support to run a TableAPI query like 'table.select('a, 'b, 'c)' URL: https://github.com/apache/flink/pull/8697 ## What is the purpose of the change The pr aims to support to run a TableAPI query like

[jira] [Updated] (FLINK-12810) Support to run a TableAPI query like 'table.select('a, 'b, 'c)'

2019-06-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12810: --- Labels: pull-request-available (was: ) > Support to run a TableAPI query like

[GitHub] [flink] liyafan82 commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-06-11 Thread GitBox
liyafan82 commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#discussion_r292731260 ## File path:

[jira] [Created] (FLINK-12810) Support to run a TableAPI query like 'table.select('a, 'b, 'c)'

2019-06-11 Thread Jing Zhang (JIRA)
Jing Zhang created FLINK-12810: -- Summary: Support to run a TableAPI query like 'table.select('a, 'b, 'c)' Key: FLINK-12810 URL: https://issues.apache.org/jira/browse/FLINK-12810 Project: Flink

[GitHub] [flink] JingsongLi commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-06-11 Thread GitBox
JingsongLi commented on a change in pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#discussion_r292730302 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

2019-06-11 Thread GitBox
wuchong commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#discussion_r292728154 ## File path:

[GitHub] [flink] sunhaibotb removed a comment on issue #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface

2019-06-11 Thread GitBox
sunhaibotb removed a comment on issue #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface URL: https://github.com/apache/flink/pull/8124#issuecomment-501094648 The PR has been updated. @pnowojski

[GitHub] [flink] wuchong commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

2019-06-11 Thread GitBox
wuchong commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#discussion_r292726510 ## File path:

[jira] [Assigned] (FLINK-12806) Remove beta feature remark from the Universal Kafka connector

2019-06-11 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-12806: Assignee: vinoyang > Remove beta feature remark from the Universal Kafka connector >

[GitHub] [flink] JingsongLi commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

2019-06-11 Thread GitBox
JingsongLi commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#discussion_r292725578 ## File path:

[GitHub] [flink] lirui-apache commented on a change in pull request #8614: [FLINK-12727][hive] Make HiveTableOutputFormat support writing partitioned table

2019-06-11 Thread GitBox
lirui-apache commented on a change in pull request #8614: [FLINK-12727][hive] Make HiveTableOutputFormat support writing partitioned table URL: https://github.com/apache/flink/pull/8614#discussion_r292725211 ## File path:

[GitHub] [flink] lirui-apache commented on a change in pull request #8614: [FLINK-12727][hive] Make HiveTableOutputFormat support writing partitioned table

2019-06-11 Thread GitBox
lirui-apache commented on a change in pull request #8614: [FLINK-12727][hive] Make HiveTableOutputFormat support writing partitioned table URL: https://github.com/apache/flink/pull/8614#discussion_r292725038 ## File path:

[GitHub] [flink] sunjincheng121 commented on issue #8575: [FLINK-12583][python] Add all format support align with the Java Table API.

2019-06-11 Thread GitBox
sunjincheng121 commented on issue #8575: [FLINK-12583][python] Add all format support align with the Java Table API. URL: https://github.com/apache/flink/pull/8575#issuecomment-501094783 It will be merged after my branch CI change green.

[GitHub] [flink] sunhaibotb commented on issue #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface

2019-06-11 Thread GitBox
sunhaibotb commented on issue #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface URL: https://github.com/apache/flink/pull/8124#issuecomment-501094648 The PR has been updated. @pnowojski

[jira] [Commented] (FLINK-12776) Ambiguous content in flink-dist NOTICE file

2019-06-11 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861680#comment-16861680 ] sunjincheng commented on FLINK-12776: - @stephan already brings up the discussion for `Deprecate

[GitHub] [flink] JingsongLi commented on issue #8689: [FLINK-12802][table-runtime-blink] Reducing the Code of BinaryString

2019-06-11 Thread GitBox
JingsongLi commented on issue #8689: [FLINK-12802][table-runtime-blink] Reducing the Code of BinaryString URL: https://github.com/apache/flink/pull/8689#issuecomment-501093166 > I haven't go through the changes, but one thing comes to my mind, which is we can follow jdk String's

[GitHub] [flink] KurtYoung commented on issue #8695: [FLINK-12805][FLINK-12808][FLINK-12809][table-api] Introduce PartitionableTableSource and PartitionableTableSink and OverwritableTableSink

2019-06-11 Thread GitBox
KurtYoung commented on issue #8695: [FLINK-12805][FLINK-12808][FLINK-12809][table-api] Introduce PartitionableTableSource and PartitionableTableSink and OverwritableTableSink URL: https://github.com/apache/flink/pull/8695#issuecomment-501093155 split to 3 commits?

[GitHub] [flink] dianfu commented on issue #8609: [FLINK-12541][container][python] Add support for Python jobs in build script

2019-06-11 Thread GitBox
dianfu commented on issue #8609: [FLINK-12541][container][python] Add support for Python jobs in build script URL: https://github.com/apache/flink/pull/8609#issuecomment-501092870 @sunjincheng121 Make sense to me as `--opt-jars` is not a must have option. Considering that the table JAR

[GitHub] [flink] JingsongLi commented on a change in pull request #8689: [FLINK-12802][table-runtime-blink] Reducing the Code of BinaryString

2019-06-11 Thread GitBox
JingsongLi commented on a change in pull request #8689: [FLINK-12802][table-runtime-blink] Reducing the Code of BinaryString URL: https://github.com/apache/flink/pull/8689#discussion_r292723105 ## File path:

[jira] [Commented] (FLINK-12785) RocksDB savepoint recovery can use a lot of unmanaged memory

2019-06-11 Thread Congxian Qiu(klion26) (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861675#comment-16861675 ] Congxian Qiu(klion26) commented on FLINK-12785: --- [~mikekap] thanks for the input, I'll

[jira] [Assigned] (FLINK-12785) RocksDB savepoint recovery can use a lot of unmanaged memory

2019-06-11 Thread Congxian Qiu(klion26) (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Congxian Qiu(klion26) reassigned FLINK-12785: - Assignee: Congxian Qiu(klion26) > RocksDB savepoint recovery can use a

[GitHub] [flink] sunjincheng121 commented on issue #8609: [FLINK-12541][container][python] Add support for Python jobs in build script

2019-06-11 Thread GitBox
sunjincheng121 commented on issue #8609: [FLINK-12541][container][python] Add support for Python jobs in build script URL: https://github.com/apache/flink/pull/8609#issuecomment-501088506 I think we can remove the `--opt-jars` due to we @StephanEwen already bring up the discussion for put

[GitHub] [flink] KurtYoung commented on a change in pull request #8689: [FLINK-12802][table-runtime-blink] Reducing the Code of BinaryString

2019-06-11 Thread GitBox
KurtYoung commented on a change in pull request #8689: [FLINK-12802][table-runtime-blink] Reducing the Code of BinaryString URL: https://github.com/apache/flink/pull/8689#discussion_r292715228 ## File path:

[GitHub] [flink] Aitozi commented on issue #8280: [FLINK-12297]Harden ClosureCleaner to handle the wrapped function

2019-06-11 Thread GitBox
Aitozi commented on issue #8280: [FLINK-12297]Harden ClosureCleaner to handle the wrapped function URL: https://github.com/apache/flink/pull/8280#issuecomment-501073568 Hi @aljoscha The case you post can not past is due to the check below, because a closure can be hidden in any class as

[GitHub] [flink] mans2singh commented on a change in pull request #8668: [FLINK-12784][metrics] Support retention policy for InfluxDB metrics …

2019-06-11 Thread GitBox
mans2singh commented on a change in pull request #8668: [FLINK-12784][metrics] Support retention policy for InfluxDB metrics … URL: https://github.com/apache/flink/pull/8668#discussion_r292700412 ## File path:

[GitHub] [flink] mans2singh commented on a change in pull request #8668: [FLINK-12784][metrics] Support retention policy for InfluxDB metrics …

2019-06-11 Thread GitBox
mans2singh commented on a change in pull request #8668: [FLINK-12784][metrics] Support retention policy for InfluxDB metrics … URL: https://github.com/apache/flink/pull/8668#discussion_r292700619 ## File path:

[GitHub] [flink] mans2singh commented on a change in pull request #8668: [FLINK-12784][metrics] Support retention policy for InfluxDB metrics …

2019-06-11 Thread GitBox
mans2singh commented on a change in pull request #8668: [FLINK-12784][metrics] Support retention policy for InfluxDB metrics … URL: https://github.com/apache/flink/pull/8668#discussion_r292700476 ## File path:

[GitHub] [flink] mans2singh commented on a change in pull request #8668: [FLINK-12784][metrics] Support retention policy for InfluxDB metrics …

2019-06-11 Thread GitBox
mans2singh commented on a change in pull request #8668: [FLINK-12784][metrics] Support retention policy for InfluxDB metrics … URL: https://github.com/apache/flink/pull/8668#discussion_r292700412 ## File path:

[GitHub] [flink] mans2singh commented on a change in pull request #8668: [FLINK-12784][metrics] Support retention policy for InfluxDB metrics …

2019-06-11 Thread GitBox
mans2singh commented on a change in pull request #8668: [FLINK-12784][metrics] Support retention policy for InfluxDB metrics … URL: https://github.com/apache/flink/pull/8668#discussion_r292700272 ## File path: docs/monitoring/metrics.md ## @@ -658,6 +658,7 @@ Parameters:

[jira] [Commented] (FLINK-12785) RocksDB savepoint recovery can use a lot of unmanaged memory

2019-06-11 Thread Mike Kaplinskiy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861347#comment-16861347 ] Mike Kaplinskiy commented on FLINK-12785: - [~klion26] you can go ahead. I know that the 

[GitHub] [flink] flinkbot commented on issue #8696: [FLINK-12624][table][sql] Make Flink case-insensitive to meta object names

2019-06-11 Thread GitBox
flinkbot commented on issue #8696: [FLINK-12624][table][sql] Make Flink case-insensitive to meta object names URL: https://github.com/apache/flink/pull/8696#issuecomment-500966464 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[jira] [Updated] (FLINK-12624) Make Flink case-insensitive to meta object names

2019-06-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12624: --- Labels: pull-request-available (was: ) > Make Flink case-insensitive to meta object names

[GitHub] [flink] bowenli86 opened a new pull request #8696: [FLINK-12624][table][sql] Make Flink case-insensitive to meta object names

2019-06-11 Thread GitBox
bowenli86 opened a new pull request #8696: [FLINK-12624][table][sql] Make Flink case-insensitive to meta object names URL: https://github.com/apache/flink/pull/8696 ## What is the purpose of the change Note that this is not a final PR. I'm testing it This PR makes Flink

[GitHub] [flink] bowenli86 commented on a change in pull request #8614: [FLINK-12727][hive] Make HiveTableOutputFormat support writing partitioned table

2019-06-11 Thread GitBox
bowenli86 commented on a change in pull request #8614: [FLINK-12727][hive] Make HiveTableOutputFormat support writing partitioned table URL: https://github.com/apache/flink/pull/8614#discussion_r292560318 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8614: [FLINK-12727][hive] Make HiveTableOutputFormat support writing partitioned table

2019-06-11 Thread GitBox
bowenli86 commented on a change in pull request #8614: [FLINK-12727][hive] Make HiveTableOutputFormat support writing partitioned table URL: https://github.com/apache/flink/pull/8614#discussion_r292561357 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8614: [FLINK-12727][hive] Make HiveTableOutputFormat support writing partitioned table

2019-06-11 Thread GitBox
bowenli86 commented on a change in pull request #8614: [FLINK-12727][hive] Make HiveTableOutputFormat support writing partitioned table URL: https://github.com/apache/flink/pull/8614#discussion_r29210 ## File path:

[GitHub] [flink] aljoscha commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

2019-06-11 Thread GitBox
aljoscha commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#discussion_r292531966 ## File path:

  1   2   3   4   >