[jira] [Commented] (FLINK-12886) Support container memory segment

2019-06-19 Thread Liya Fan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867398#comment-16867398 ] Liya Fan commented on FLINK-12886: -- Hi [~lzljs3620320], thanks for your comments. Pleas

[GitHub] [flink] knaufk edited a comment on issue #8609: [FLINK-12541][container][python] Add support for Python jobs in build script

2019-06-19 Thread GitBox
knaufk edited a comment on issue #8609: [FLINK-12541][container][python] Add support for Python jobs in build script URL: https://github.com/apache/flink/pull/8609#issuecomment-503469415 FYI: This change broke `test_docker_embedded_job.sh` and `test_kubernetes_embedded_job.sh` as they were

[GitHub] [flink] knaufk commented on issue #8609: [FLINK-12541][container][python] Add support for Python jobs in build script

2019-06-19 Thread GitBox
knaufk commented on issue #8609: [FLINK-12541][container][python] Add support for Python jobs in build script URL: https://github.com/apache/flink/pull/8609#issuecomment-503469415 FYI: This change broke `test_docker_embedded_job.sh` and `test_kubernetes_embedded_job.sh` as they were still

[GitHub] [flink] zhijiangW commented on issue #8778: [FLINK-12615][coordination] Track partitions on JM

2019-06-19 Thread GitBox
zhijiangW commented on issue #8778: [FLINK-12615][coordination] Track partitions on JM URL: https://github.com/apache/flink/pull/8778#issuecomment-503467360 I am not sure why they are not shown outside, but inline codes we could see these comments. I would double check and submit them agai

[jira] [Closed] (FLINK-12878) Add travis profile for flink-table-planner-blink/flink-table-runtime-blink

2019-06-19 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-12878. -- Resolution: Fixed Fix Version/s: 1.9.0 merged in 1.9.0: 72fd15c784ad6f5e29e73eb06c565694d52c2c4

[GitHub] [flink] zentol commented on issue #8778: [FLINK-12615][coordination] Track partitions on JM

2019-06-19 Thread GitBox
zentol commented on issue #8778: [FLINK-12615][coordination] Track partitions on JM URL: https://github.com/apache/flink/pull/8778#issuecomment-503465611 @zhijiangW I don't see any comment of yours, did something go wrong when submitting the review? ---

[GitHub] [flink] KurtYoung merged pull request #8772: [FLINK-12878] [travis] Move flink-table-planner-blink/flink-table-runtime-blink to separate profile

2019-06-19 Thread GitBox
KurtYoung merged pull request #8772: [FLINK-12878] [travis] Move flink-table-planner-blink/flink-table-runtime-blink to separate profile URL: https://github.com/apache/flink/pull/8772 This is an automated message from the Ap

[GitHub] [flink] liyafan82 commented on a change in pull request #8689: [FLINK-12802][table-runtime-blink] Reducing the Code of BinaryString

2019-06-19 Thread GitBox
liyafan82 commented on a change in pull request #8689: [FLINK-12802][table-runtime-blink] Reducing the Code of BinaryString URL: https://github.com/apache/flink/pull/8689#discussion_r295182445 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/

[GitHub] [flink] TisonKun edited a comment on issue #8759: [FLINK-12868][yarn] Fix yarn cluster can not be deployed if plugins dir does not exist

2019-06-19 Thread GitBox
TisonKun edited a comment on issue #8759: [FLINK-12868][yarn] Fix yarn cluster can not be deployed if plugins dir does not exist URL: https://github.com/apache/flink/pull/8759#issuecomment-503463284 Hi @pnowojski , as you said "plugins dir should be optional", isn't this option decided by

[GitHub] [flink] liyafan82 commented on issue #8408: [FLINK-12223][Runtime]HeapMemorySegment.getArray should return null a…

2019-06-19 Thread GitBox
liyafan82 commented on issue #8408: [FLINK-12223][Runtime]HeapMemorySegment.getArray should return null a… URL: https://github.com/apache/flink/pull/8408#issuecomment-503463909 @flinkbot attention @StephanEwen This is an aut

[GitHub] [flink] liyafan82 commented on a change in pull request #8173: [FLINK-12189][Runtime]Fix bugs and typos in memory management related…

2019-06-19 Thread GitBox
liyafan82 commented on a change in pull request #8173: [FLINK-12189][Runtime]Fix bugs and typos in memory management related… URL: https://github.com/apache/flink/pull/8173#discussion_r295180168 ## File path: flink-core/src/main/java/org/apache/flink/core/memory/MemorySegment.java

[GitHub] [flink] liyafan82 closed pull request #8173: [FLINK-12189][Runtime]Fix bugs and typos in memory management related…

2019-06-19 Thread GitBox
liyafan82 closed pull request #8173: [FLINK-12189][Runtime]Fix bugs and typos in memory management related… URL: https://github.com/apache/flink/pull/8173 This is an automated message from the Apache Git Service. To respond

[GitHub] [flink] TisonKun commented on issue #8759: [FLINK-12868][yarn] Fix yarn cluster can not be deployed if plugins dir does not exist

2019-06-19 Thread GitBox
TisonKun commented on issue #8759: [FLINK-12868][yarn] Fix yarn cluster can not be deployed if plugins dir does not exist URL: https://github.com/apache/flink/pull/8759#issuecomment-503463284 Hi @pnowojski , as you said "plugins dir should be optional", isn't this option decided by whether

[GitHub] [flink] shuiqiangchen commented on a change in pull request #8756: [FLINK-12406] [Runtime] Report BLOCKING_PERSISTENT result partition meta back to client

2019-06-19 Thread GitBox
shuiqiangchen commented on a change in pull request #8756: [FLINK-12406] [Runtime] Report BLOCKING_PERSISTENT result partition meta back to client URL: https://github.com/apache/flink/pull/8756#discussion_r295178853 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime

[GitHub] [flink] shuiqiangchen commented on a change in pull request #8756: [FLINK-12406] [Runtime] Report BLOCKING_PERSISTENT result partition meta back to client

2019-06-19 Thread GitBox
shuiqiangchen commented on a change in pull request #8756: [FLINK-12406] [Runtime] Report BLOCKING_PERSISTENT result partition meta back to client URL: https://github.com/apache/flink/pull/8756#discussion_r295177854 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime

[GitHub] [flink] shuiqiangchen commented on a change in pull request #8756: [FLINK-12406] [Runtime] Report BLOCKING_PERSISTENT result partition meta back to client

2019-06-19 Thread GitBox
shuiqiangchen commented on a change in pull request #8756: [FLINK-12406] [Runtime] Report BLOCKING_PERSISTENT result partition meta back to client URL: https://github.com/apache/flink/pull/8756#discussion_r295178320 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime

[GitHub] [flink] shuiqiangchen commented on a change in pull request #8756: [FLINK-12406] [Runtime] Report BLOCKING_PERSISTENT result partition meta back to client

2019-06-19 Thread GitBox
shuiqiangchen commented on a change in pull request #8756: [FLINK-12406] [Runtime] Report BLOCKING_PERSISTENT result partition meta back to client URL: https://github.com/apache/flink/pull/8756#discussion_r295178145 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime

[GitHub] [flink] shuiqiangchen commented on a change in pull request #8756: [FLINK-12406] [Runtime] Report BLOCKING_PERSISTENT result partition meta back to client

2019-06-19 Thread GitBox
shuiqiangchen commented on a change in pull request #8756: [FLINK-12406] [Runtime] Report BLOCKING_PERSISTENT result partition meta back to client URL: https://github.com/apache/flink/pull/8756#discussion_r295178145 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime

[GitHub] [flink] shuiqiangchen commented on a change in pull request #8756: [FLINK-12406] [Runtime] Report BLOCKING_PERSISTENT result partition meta back to client

2019-06-19 Thread GitBox
shuiqiangchen commented on a change in pull request #8756: [FLINK-12406] [Runtime] Report BLOCKING_PERSISTENT result partition meta back to client URL: https://github.com/apache/flink/pull/8756#discussion_r295177854 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime

[GitHub] [flink] dawidwys commented on a change in pull request #8707: [FLINK-12815] [table-planner-blink] Supports CatalogManager in blink planner

2019-06-19 Thread GitBox
dawidwys commented on a change in pull request #8707: [FLINK-12815] [table-planner-blink] Supports CatalogManager in blink planner URL: https://github.com/apache/flink/pull/8707#discussion_r295175502 ## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink

[GitHub] [flink] dawidwys commented on a change in pull request #8707: [FLINK-12815] [table-planner-blink] Supports CatalogManager in blink planner

2019-06-19 Thread GitBox
dawidwys commented on a change in pull request #8707: [FLINK-12815] [table-planner-blink] Supports CatalogManager in blink planner URL: https://github.com/apache/flink/pull/8707#discussion_r295175502 ## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink

[GitHub] [flink] dawidwys commented on a change in pull request #8707: [FLINK-12815] [table-planner-blink] Supports CatalogManager in blink planner

2019-06-19 Thread GitBox
dawidwys commented on a change in pull request #8707: [FLINK-12815] [table-planner-blink] Supports CatalogManager in blink planner URL: https://github.com/apache/flink/pull/8707#discussion_r295174789 ## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink

[GitHub] [flink] dawidwys commented on a change in pull request #8707: [FLINK-12815] [table-planner-blink] Supports CatalogManager in blink planner

2019-06-19 Thread GitBox
dawidwys commented on a change in pull request #8707: [FLINK-12815] [table-planner-blink] Supports CatalogManager in blink planner URL: https://github.com/apache/flink/pull/8707#discussion_r295173029 ## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink

[GitHub] [flink] tzulitai commented on issue #8686: [FLINK-11869] Make buffer size in checkpoint stream factory configurable

2019-06-19 Thread GitBox
tzulitai commented on issue #8686: [FLINK-11869] Make buffer size in checkpoint stream factory configurable URL: https://github.com/apache/flink/pull/8686#issuecomment-503459099 Merging ... This is an automated message from t

[jira] [Created] (FLINK-12897) Improve the Python Table API docs by adding more examples

2019-06-19 Thread Dian Fu (JIRA)
Dian Fu created FLINK-12897: --- Summary: Improve the Python Table API docs by adding more examples Key: FLINK-12897 URL: https://issues.apache.org/jira/browse/FLINK-12897 Project: Flink Issue Type: S

[GitHub] [flink] dianfu commented on a change in pull request #8774: [FLINK-12720][python] Add the Python Table API Sphinx docs

2019-06-19 Thread GitBox
dianfu commented on a change in pull request #8774: [FLINK-12720][python] Add the Python Table API Sphinx docs URL: https://github.com/apache/flink/pull/8774#discussion_r295174043 ## File path: flink-python/docs/pyflink.table.rst ## @@ -0,0 +1,46 @@ +.. ##

[jira] [Closed] (FLINK-12874) Improve the semantics of zero length character strings

2019-06-19 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-12874. Resolution: Fixed Fix Version/s: 1.9.0 Fixed in 1.9.0: 2a3ac580abf5b32c341fe921c1eacbb395b2

[GitHub] [flink] asfgit closed pull request #8781: [FLINK-12874][table-common] Improve the semantics of zero length strings

2019-06-19 Thread GitBox
asfgit closed pull request #8781: [FLINK-12874][table-common] Improve the semantics of zero length strings URL: https://github.com/apache/flink/pull/8781 This is an automated message from the Apache Git Service. To respond t

[GitHub] [flink] c4emmmm commented on a change in pull request #8776: [FLINK-12881][ml] Add more functionalities for ML Params and ParamInfo class

2019-06-19 Thread GitBox
c4e commented on a change in pull request #8776: [FLINK-12881][ml] Add more functionalities for ML Params and ParamInfo class URL: https://github.com/apache/flink/pull/8776#discussion_r295173128 ## File path: flink-ml-parent/flink-ml-api/src/test/java/org/apache/flink/ml/api/mi

[GitHub] [flink] flinkbot commented on issue #8790: [FLINK-12710][table] Prepare expressions for a new resolved expression

2019-06-19 Thread GitBox
flinkbot commented on issue #8790: [FLINK-12710][table] Prepare expressions for a new resolved expression URL: https://github.com/apache/flink/pull/8790#issuecomment-503454928 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to revi

[GitHub] [flink] dawidwys commented on a change in pull request #8707: [FLINK-12815] [table-planner-blink] Supports CatalogManager in blink planner

2019-06-19 Thread GitBox
dawidwys commented on a change in pull request #8707: [FLINK-12815] [table-planner-blink] Supports CatalogManager in blink planner URL: https://github.com/apache/flink/pull/8707#discussion_r295169272 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flin

[GitHub] [flink] JingsongLi commented on a change in pull request #8781: [FLINK-12874][table-common] Improve the semantics of zero length strings

2019-06-19 Thread GitBox
JingsongLi commented on a change in pull request #8781: [FLINK-12874][table-common] Improve the semantics of zero length strings URL: https://github.com/apache/flink/pull/8781#discussion_r295169573 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/ty

[GitHub] [flink] twalthr commented on a change in pull request #8781: [FLINK-12874][table-common] Improve the semantics of zero length strings

2019-06-19 Thread GitBox
twalthr commented on a change in pull request #8781: [FLINK-12874][table-common] Improve the semantics of zero length strings URL: https://github.com/apache/flink/pull/8781#discussion_r295168960 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types

[jira] [Updated] (FLINK-12710) Unify built-in and user-defined functions in the API modules

2019-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12710: --- Labels: pull-request-available (was: ) > Unify built-in and user-defined functions in the A

[GitHub] [flink] twalthr opened a new pull request #8790: [FLINK-12710][table] Prepare expressions for a new resolved expression

2019-06-19 Thread GitBox
twalthr opened a new pull request #8790: [FLINK-12710][table] Prepare expressions for a new resolved expression URL: https://github.com/apache/flink/pull/8790 ## What is the purpose of the change This PR is preparation work for FLINK-12710 that will introduce a new expression with r

[jira] [Commented] (FLINK-12849) Add support for build Python Docs in Buildbot

2019-06-19 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867329#comment-16867329 ] Chesnay Schepler commented on FLINK-12849: -- There's no way to open a PR for svn

[jira] [Issue Comment Deleted] (FLINK-12849) Add support for build Python Docs in Buildbot

2019-06-19 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-12849: Comment: was deleted (was: In this PR we should modify the Buildbot code(the repo is SVN), I have

[jira] [Commented] (FLINK-12849) Add support for build Python Docs in Buildbot

2019-06-19 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867328#comment-16867328 ] sunjincheng commented on FLINK-12849: - I will add the follows changes(flink.conf): {

[GitHub] [flink] becketqin commented on issue #8535: [FLINK-11693] Add KafkaSerializationSchema that uses ProducerRecord

2019-06-19 Thread GitBox
becketqin commented on issue #8535: [FLINK-11693] Add KafkaSerializationSchema that uses ProducerRecord URL: https://github.com/apache/flink/pull/8535#issuecomment-503452762 @aljoscha Thanks for the pointer the earlier PR. The solution in my mind was slightly different from but pretty simi

[GitHub] [flink] becketqin edited a comment on issue #8535: [FLINK-11693] Add KafkaSerializationSchema that uses ProducerRecord

2019-06-19 Thread GitBox
becketqin edited a comment on issue #8535: [FLINK-11693] Add KafkaSerializationSchema that uses ProducerRecord URL: https://github.com/apache/flink/pull/8535#issuecomment-503452762 @aljoscha Thanks for the pointer to the earlier PR. The solution in my mind was slightly different from but p

[GitHub] [flink] zentol closed pull request #8787: Test travis compile

2019-06-19 Thread GitBox
zentol closed pull request #8787: Test travis compile URL: https://github.com/apache/flink/pull/8787 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] azagrebin commented on a change in pull request #8759: [FLINK-12868][yarn] Fix yarn cluster can not be deployed if plugins dir does not exist

2019-06-19 Thread GitBox
azagrebin commented on a change in pull request #8759: [FLINK-12868][yarn] Fix yarn cluster can not be deployed if plugins dir does not exist URL: https://github.com/apache/flink/pull/8759#discussion_r295165032 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/clus

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8774: [FLINK-12720][python] Add the Python Table API Sphinx docs

2019-06-19 Thread GitBox
sunjincheng121 commented on a change in pull request #8774: [FLINK-12720][python] Add the Python Table API Sphinx docs URL: https://github.com/apache/flink/pull/8774#discussion_r295163763 ## File path: flink-python/dev/lint-python.sh ## @@ -244,6 +244,28 @@ function instal

[GitHub] [flink] dawidwys commented on a change in pull request #8781: [FLINK-12874][table-common] Improve the semantics of zero length strings

2019-06-19 Thread GitBox
dawidwys commented on a change in pull request #8781: [FLINK-12874][table-common] Improve the semantics of zero length strings URL: https://github.com/apache/flink/pull/8781#discussion_r295162812 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/type

[jira] [Commented] (FLINK-12896) Missing some information in History Server

2019-06-19 Thread xymaqingxiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867317#comment-16867317 ] xymaqingxiang commented on FLINK-12896: --- [~Zentol] [~klion26]  I'm sorry to bother

[jira] [Created] (FLINK-12896) Missing some information in History Server

2019-06-19 Thread xymaqingxiang (JIRA)
xymaqingxiang created FLINK-12896: - Summary: Missing some information in History Server Key: FLINK-12896 URL: https://issues.apache.org/jira/browse/FLINK-12896 Project: Flink Issue Type: Bug

[GitHub] [flink] azagrebin commented on issue #8789: [FLINK-12890] Add partition lifecycle related Shuffle API

2019-06-19 Thread GitBox
azagrebin commented on issue #8789: [FLINK-12890] Add partition lifecycle related Shuffle API URL: https://github.com/apache/flink/pull/8789#issuecomment-503446542 @flinkbot attention @tillrohrmann @zentol @zhijiangW This is

[jira] [Commented] (FLINK-12886) Support container memory segment

2019-06-19 Thread Jingsong Lee (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867311#comment-16867311 ] Jingsong Lee commented on FLINK-12886: -- Hi [~fan_li_ya], Thanks for your proposal.

[GitHub] [flink] flinkbot commented on issue #8789: [FLINK-12890] Add partition lifecycle related Shuffle API

2019-06-19 Thread GitBox
flinkbot commented on issue #8789: [FLINK-12890] Add partition lifecycle related Shuffle API URL: https://github.com/apache/flink/pull/8789#issuecomment-503445604 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull

[jira] [Updated] (FLINK-12849) Add support for build Python Docs in Buildbot

2019-06-19 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-12849: Description: We should add the Python Doc for Python API, and add the link to the web page. i.e.:

[jira] [Updated] (FLINK-12890) Add partition lifecycle related Shuffle API

2019-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12890: --- Labels: pull-request-available (was: ) > Add partition lifecycle related Shuffle API >

[GitHub] [flink] azagrebin opened a new pull request #8789: [FLINK-12890] Add partition lifecycle related Shuffle API

2019-06-19 Thread GitBox
azagrebin opened a new pull request #8789: [FLINK-12890] Add partition lifecycle related Shuffle API URL: https://github.com/apache/flink/pull/8789 ## What is the purpose of the change At the moment we have `ShuffleEnvironment.releasePartitions` which is used to release locally occu

[jira] [Commented] (FLINK-12849) Add support for build Python Docs in Buildbot

2019-06-19 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867307#comment-16867307 ] sunjincheng commented on FLINK-12849: - In this PR we should modify the Buildbot code

[GitHub] [flink] lirui-apache commented on issue #8766: [FLINK-12664][hive] Implement TableSink to write Hive tables

2019-06-19 Thread GitBox
lirui-apache commented on issue #8766: [FLINK-12664][hive] Implement TableSink to write Hive tables URL: https://github.com/apache/flink/pull/8766#issuecomment-50324 Thanks @xuefuz and @bowenli86 for the review. PR updated accordingly. Regarding when `getOutputFormat()` is called

[jira] [Assigned] (FLINK-12849) Add support for build Python Docs in Buildbot

2019-06-19 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng reassigned FLINK-12849: --- Assignee: sunjincheng > Add support for build Python Docs in Buildbot > ---

[jira] [Updated] (FLINK-12890) Add partition lifecycle related Shuffle API

2019-06-19 Thread Andrey Zagrebin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Zagrebin updated FLINK-12890: Description: At the moment we have ShuffleEnvironment.releasePartitions which is used to

[GitHub] [flink] WeiZhong94 commented on issue #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API

2019-06-19 Thread GitBox
WeiZhong94 commented on issue #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API URL: https://github.com/apache/flink/pull/8681#issuecomment-503442826 @dianfu Thanks for your review again! I have addressed you comments. -

[GitHub] [flink] maidangdang44 commented on issue #7262: [FLINK-10478] Kafka Producer wrongly formats % for transaction ID

2019-06-19 Thread GitBox
maidangdang44 commented on issue #7262: [FLINK-10478] Kafka Producer wrongly formats % for transaction ID URL: https://github.com/apache/flink/pull/7262#issuecomment-503441669 Why hasn't this PR been merged? Is there a better solution? I encountered the same problem in flink-1.7.2, so I ha

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8774: [FLINK-12720][python] Add the Python Table API Sphinx docs

2019-06-19 Thread GitBox
sunjincheng121 commented on a change in pull request #8774: [FLINK-12720][python] Add the Python Table API Sphinx docs URL: https://github.com/apache/flink/pull/8774#discussion_r295144305 ## File path: flink-python/docs/pyflink.table.rst ## @@ -0,0 +1,46 @@ +.. ##

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8774: [FLINK-12720][python] Add the Python Table API Sphinx docs

2019-06-19 Thread GitBox
sunjincheng121 commented on a change in pull request #8774: [FLINK-12720][python] Add the Python Table API Sphinx docs URL: https://github.com/apache/flink/pull/8774#discussion_r295142015 ## File path: flink-python/docs/pyflink.table.rst ## @@ -0,0 +1,46 @@ +.. ##

[GitHub] [flink] godfreyhe commented on issue #8707: [FLINK-12815] [table-planner-blink] Supports CatalogManager in blink planner

2019-06-19 Thread GitBox
godfreyhe commented on issue #8707: [FLINK-12815] [table-planner-blink] Supports CatalogManager in blink planner URL: https://github.com/apache/flink/pull/8707#issuecomment-503439414 @dawidwys do you have any other suggestions? this PR has blocked other blink merging work, I hope to speed

[GitHub] [flink] sunhaibotb edited a comment on issue #8731: [FLINK-11878][runtime] Implement the runtime handling of BoundedOneInput and BoundedMultiInput

2019-06-19 Thread GitBox
sunhaibotb edited a comment on issue #8731: [FLINK-11878][runtime] Implement the runtime handling of BoundedOneInput and BoundedMultiInput URL: https://github.com/apache/flink/pull/8731#issuecomment-503042115 The PR has been update. Please review it, thank you very much. @pnowojski -

[GitHub] [flink] sunhaibotb edited a comment on issue #8471: [FLINK-12529][runtime] Release record-deserializer buffers timely to improve the efficiency of heap usage on taskmanager

2019-06-19 Thread GitBox
sunhaibotb edited a comment on issue #8471: [FLINK-12529][runtime] Release record-deserializer buffers timely to improve the efficiency of heap usage on taskmanager URL: https://github.com/apache/flink/pull/8471#issuecomment-503433529 The PR has been rebased on the latest master because th

<    1   2   3   4