[GitHub] [flink] XuPingyong commented on a change in pull request #8937: [FLINK-13040] promote blink table config and add to document

2019-07-01 Thread GitBox
XuPingyong commented on a change in pull request #8937: [FLINK-13040] promote blink table config and add to document URL: https://github.com/apache/flink/pull/8937#discussion_r299327232 ## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/api/Pla

[GitHub] [flink] dawidwys commented on a change in pull request #8929: [FLINK-13028][table] Move expression resolver to flink-table-api-java

2019-07-01 Thread GitBox
dawidwys commented on a change in pull request #8929: [FLINK-13028][table] Move expression resolver to flink-table-api-java URL: https://github.com/apache/flink/pull/8929#discussion_r299327183 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/expre

[GitHub] [flink] becketqin commented on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-07-01 Thread GitBox
becketqin commented on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#issuecomment-507544552 @Xeli Just to let you know, I am reviewing the patch. Hopefully we can check this in b

[jira] [Updated] (FLINK-13051) Drop the non-selectable two-input StreamTask and Processor

2019-07-01 Thread Haibo Sun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haibo Sun updated FLINK-13051: -- Description: After `StreamTwoInputSelectableProcessor` supports `CheckpointBarrierHandler`, we should

[GitHub] [flink] XuPingyong commented on a change in pull request #8937: [FLINK-13040] promote blink table config and add to document

2019-07-01 Thread GitBox
XuPingyong commented on a change in pull request #8937: [FLINK-13040] promote blink table config and add to document URL: https://github.com/apache/flink/pull/8937#discussion_r299323887 ## File path: flink-docs/src/main/java/org/apache/flink/docs/configuration/ConfigOptionsDocGener

[GitHub] [flink] XuPingyong commented on a change in pull request #8937: [FLINK-13040] promote blink table config and add to document

2019-07-01 Thread GitBox
XuPingyong commented on a change in pull request #8937: [FLINK-13040] promote blink table config and add to document URL: https://github.com/apache/flink/pull/8937#discussion_r299323832 ## File path: flink-annotations/src/main/java/org/apache/flink/annotation/docs/Documentation.jav

[GitHub] [flink] XuPingyong commented on a change in pull request #8937: [FLINK-13040] promote blink table config and add to document

2019-07-01 Thread GitBox
XuPingyong commented on a change in pull request #8937: [FLINK-13040] promote blink table config and add to document URL: https://github.com/apache/flink/pull/8937#discussion_r299323740 ## File path: docs/ops/config.md ## @@ -183,6 +183,12 @@ unless user define a `OptionsF

[GitHub] [flink] twalthr commented on a change in pull request #8929: [FLINK-13028][table] Move expression resolver to flink-table-api-java

2019-07-01 Thread GitBox
twalthr commented on a change in pull request #8929: [FLINK-13028][table] Move expression resolver to flink-table-api-java URL: https://github.com/apache/flink/pull/8929#discussion_r299323172 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/expres

[GitHub] [flink] XuPingyong commented on a change in pull request #8937: [FLINK-13040] promote blink table config and add to document

2019-07-01 Thread GitBox
XuPingyong commented on a change in pull request #8937: [FLINK-13040] promote blink table config and add to document URL: https://github.com/apache/flink/pull/8937#discussion_r299322319 ## File path: flink-annotations/src/main/java/org/apache/flink/annotation/docs/Documentation.jav

[GitHub] [flink] XuPingyong commented on a change in pull request #8937: [FLINK-13040] promote blink table config and add to document

2019-07-01 Thread GitBox
XuPingyong commented on a change in pull request #8937: [FLINK-13040] promote blink table config and add to document URL: https://github.com/apache/flink/pull/8937#discussion_r299322273 ## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/api/Pla

[GitHub] [flink] XuPingyong commented on issue #8937: [FLINK-13040] promote blink table config and add to document

2019-07-01 Thread GitBox
XuPingyong commented on issue #8937: [FLINK-13040] promote blink table config and add to document URL: https://github.com/apache/flink/pull/8937#issuecomment-507541037 Thanks @zentol , I have fixed according to your comments.

[jira] [Created] (FLINK-13051) Drop the non-selectable two-input StreamTask and Processor

2019-07-01 Thread Haibo Sun (JIRA)
Haibo Sun created FLINK-13051: - Summary: Drop the non-selectable two-input StreamTask and Processor Key: FLINK-13051 URL: https://issues.apache.org/jira/browse/FLINK-13051 Project: Flink Issue Ty

[GitHub] [flink] flinkbot commented on issue #8942: [FLINK-13049][table-planner-blink] Port planner expressions to blink-planner from flink-planner

2019-07-01 Thread GitBox
flinkbot commented on issue #8942: [FLINK-13049][table-planner-blink] Port planner expressions to blink-planner from flink-planner URL: https://github.com/apache/flink/pull/8942#issuecomment-507539575 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help

[jira] [Updated] (FLINK-13049) Port planner expressions to blink-planner from flink-planner

2019-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13049: --- Labels: pull-request-available (was: ) > Port planner expressions to blink-planner from fli

[GitHub] [flink] JingsongLi opened a new pull request #8942: [FLINK-13049][table-planner-blink] Port planner expressions to blink-planner from flink-planner

2019-07-01 Thread GitBox
JingsongLi opened a new pull request #8942: [FLINK-13049][table-planner-blink] Port planner expressions to blink-planner from flink-planner URL: https://github.com/apache/flink/pull/8942 ## What is the purpose of the change Port planner expressions to blink-planner from flink-pla

[GitHub] [flink] c4emmmm commented on issue #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge

2019-07-01 Thread GitBox
c4e commented on issue #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge URL: https://github.com/apache/flink/pull/8872#issuecomment-507537975 > Thanks @c4e . > > I think we should also add a `CsvTableSourceITCase` in blink-planner to verify the lookup and sc

[jira] [Commented] (FLINK-11637) Translate "Checkpoints" page into Chinese

2019-07-01 Thread yelun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876701#comment-16876701 ] yelun commented on FLINK-11637: --- [~WangHW] sorry,I will push recently > Translate "Checkp

[GitHub] [flink] liyafan82 commented on a change in pull request #8854: [FLINK-12959][table-planner-blink] Use BoundedInput and InputSelectable in blink and implement hash join

2019-07-01 Thread GitBox
liyafan82 commented on a change in pull request #8854: [FLINK-12959][table-planner-blink] Use BoundedInput and InputSelectable in blink and implement hash join URL: https://github.com/apache/flink/pull/8854#discussion_r299301202 ## File path: flink-table/flink-table-planner-blink/

[GitHub] [flink] wuchong commented on a change in pull request #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge

2019-07-01 Thread GitBox
wuchong commented on a change in pull request #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge URL: https://github.com/apache/flink/pull/8872#discussion_r299042764 ## File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/sinks/CsvT

[GitHub] [flink] wuchong commented on a change in pull request #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge

2019-07-01 Thread GitBox
wuchong commented on a change in pull request #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge URL: https://github.com/apache/flink/pull/8872#discussion_r299291809 ## File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/api/TableSourceTe

[GitHub] [flink] wuchong commented on a change in pull request #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge

2019-07-01 Thread GitBox
wuchong commented on a change in pull request #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge URL: https://github.com/apache/flink/pull/8872#discussion_r299288495 ## File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/sources/Cs

[GitHub] [flink] wuchong commented on a change in pull request #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge

2019-07-01 Thread GitBox
wuchong commented on a change in pull request #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge URL: https://github.com/apache/flink/pull/8872#discussion_r299039477 ## File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/sinks/CsvT

[GitHub] [flink] wuchong commented on a change in pull request #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge

2019-07-01 Thread GitBox
wuchong commented on a change in pull request #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge URL: https://github.com/apache/flink/pull/8872#discussion_r299042550 ## File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/sinks/CsvT

[GitHub] [flink] wuchong commented on a change in pull request #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge

2019-07-01 Thread GitBox
wuchong commented on a change in pull request #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge URL: https://github.com/apache/flink/pull/8872#discussion_r299291487 ## File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/sources/Cs

[GitHub] [flink] wuchong commented on a change in pull request #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge

2019-07-01 Thread GitBox
wuchong commented on a change in pull request #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge URL: https://github.com/apache/flink/pull/8872#discussion_r299288657 ## File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/sources/Cs

[GitHub] [flink] wuchong commented on a change in pull request #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge

2019-07-01 Thread GitBox
wuchong commented on a change in pull request #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge URL: https://github.com/apache/flink/pull/8872#discussion_r299042199 ## File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/sinks/CsvT

[GitHub] [flink] wuchong commented on a change in pull request #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge

2019-07-01 Thread GitBox
wuchong commented on a change in pull request #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge URL: https://github.com/apache/flink/pull/8872#discussion_r298953595 ## File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/sinks/CsvT

[GitHub] [flink] wuchong commented on a change in pull request #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge

2019-07-01 Thread GitBox
wuchong commented on a change in pull request #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge URL: https://github.com/apache/flink/pull/8872#discussion_r299287964 ## File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/sources/Cs

[GitHub] [flink] wuchong commented on a change in pull request #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge

2019-07-01 Thread GitBox
wuchong commented on a change in pull request #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge URL: https://github.com/apache/flink/pull/8872#discussion_r299282489 ## File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/sinks/CsvT

[GitHub] [flink] wuchong commented on a change in pull request #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge

2019-07-01 Thread GitBox
wuchong commented on a change in pull request #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge URL: https://github.com/apache/flink/pull/8872#discussion_r299290566 ## File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/sources/Cs

[GitHub] [flink] wuchong commented on a change in pull request #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge

2019-07-01 Thread GitBox
wuchong commented on a change in pull request #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge URL: https://github.com/apache/flink/pull/8872#discussion_r299288200 ## File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/sources/Cs

[GitHub] [flink] wuchong commented on a change in pull request #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge

2019-07-01 Thread GitBox
wuchong commented on a change in pull request #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge URL: https://github.com/apache/flink/pull/8872#discussion_r299296911 ## File path: flink-python/pyflink/table/sinks.py ## @@ -49,24 +49,20 @@ class CsvTableSink(

[GitHub] [flink] ifndef-SleePy commented on a change in pull request #8931: [FLINK-13041] Make ScheduleMode configurable via ExecutionConfig

2019-07-01 Thread GitBox
ifndef-SleePy commented on a change in pull request #8931: [FLINK-13041] Make ScheduleMode configurable via ExecutionConfig URL: https://github.com/apache/flink/pull/8931#discussion_r299295760 ## File path: flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java

[GitHub] [flink] ifndef-SleePy commented on a change in pull request #8931: [FLINK-13041] Make ScheduleMode configurable via ExecutionConfig

2019-07-01 Thread GitBox
ifndef-SleePy commented on a change in pull request #8931: [FLINK-13041] Make ScheduleMode configurable via ExecutionConfig URL: https://github.com/apache/flink/pull/8931#discussion_r299295760 ## File path: flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java

[GitHub] [flink] zhijiangW commented on issue #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

2019-07-01 Thread GitBox
zhijiangW commented on issue #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#issuecomment-507508370 Thanks for the updates @Aitozi ! I left some other comments for tests.

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

2019-07-01 Thread GitBox
zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r299290395 ## File path: flink-runtime/src/test/java/org/apache/fli

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

2019-07-01 Thread GitBox
zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r299293975 ## File path: flink-runtime/src/test/java/org/apache/fli

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

2019-07-01 Thread GitBox
zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r299293436 ## File path: flink-runtime/src/test/java/org/apache/fli

[jira] [Assigned] (FLINK-13035) LocalStreamEnvironment shall launch actuall task solts

2019-07-01 Thread Wong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wong reassigned FLINK-13035: Assignee: Wong > LocalStreamEnvironment shall launch actuall task solts > --

[GitHub] [flink] KurtYoung commented on a change in pull request #8832: [FLINK-12937] [table-planner-blink] Introduce join reorder planner rules in blink planner

2019-07-01 Thread GitBox
KurtYoung commented on a change in pull request #8832: [FLINK-12937] [table-planner-blink] Introduce join reorder planner rules in blink planner URL: https://github.com/apache/flink/pull/8832#discussion_r299292745 ## File path: flink-table/flink-table-planner-blink/src/main/scala/o

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

2019-07-01 Thread GitBox
zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r299292724 ## File path: flink-runtime/src/test/java/org/apache/fli

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

2019-07-01 Thread GitBox
zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r299292571 ## File path: flink-runtime/src/test/java/org/apache/fli

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

2019-07-01 Thread GitBox
zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r299292261 ## File path: flink-runtime/src/test/java/org/apache/fli

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

2019-07-01 Thread GitBox
zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r299290827 ## File path: flink-runtime/src/test/java/org/apache/fli

[GitHub] [flink] zhuzhurk commented on a change in pull request #8931: [FLINK-13041] Make ScheduleMode configurable via ExecutionConfig

2019-07-01 Thread GitBox
zhuzhurk commented on a change in pull request #8931: [FLINK-13041] Make ScheduleMode configurable via ExecutionConfig URL: https://github.com/apache/flink/pull/8931#discussion_r299290712 ## File path: flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java #

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

2019-07-01 Thread GitBox
zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r299290642 ## File path: flink-runtime/src/test/java/org/apache/fli

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

2019-07-01 Thread GitBox
zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r299290478 ## File path: flink-runtime/src/test/java/org/apache/fli

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

2019-07-01 Thread GitBox
zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r299290395 ## File path: flink-runtime/src/test/java/org/apache/fli

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

2019-07-01 Thread GitBox
zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r299290244 ## File path: flink-runtime/src/test/java/org/apache/fli

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

2019-07-01 Thread GitBox
zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r299290244 ## File path: flink-runtime/src/test/java/org/apache/fli

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

2019-07-01 Thread GitBox
zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r299289710 ## File path: flink-runtime/src/test/java/org/apache/fli

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

2019-07-01 Thread GitBox
zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r299289630 ## File path: flink-runtime/src/test/java/org/apache/fli

[jira] [Commented] (FLINK-13011) Release the PyFlink into PyPI

2019-07-01 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876629#comment-16876629 ] sunjincheng commented on FLINK-13011: - Thanks [~dian.fu] :) That's great! > Release

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

2019-07-01 Thread GitBox
zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r299288165 ## File path: flink-runtime/src/test/java/org/apache/fli

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

2019-07-01 Thread GitBox
zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r299287676 ## File path: flink-runtime/src/test/java/org/apache/fli

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

2019-07-01 Thread GitBox
zhijiangW commented on a change in pull request #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r299287578 ## File path: flink-runtime/src/test/java/org/apache/fli

[GitHub] [flink] c4emmmm commented on issue #8526: [FLINK-12597][ml] Remove the legacy flink-libraries/flink-ml

2019-07-01 Thread GitBox
c4e commented on issue #8526: [FLINK-12597][ml] Remove the legacy flink-libraries/flink-ml URL: https://github.com/apache/flink/pull/8526#issuecomment-507495317 > @c4e Agreed, fell free to pull in my commit from #8827 or I can reopen the PR. As part of FLIP-42 we are restructuring

[jira] [Commented] (FLINK-13050) Counting more checkpoint failure reason in CheckpointFailureManager

2019-07-01 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876617#comment-16876617 ] vinoyang commented on FLINK-13050: -- cc [~pnowojski] [~azagrebin] WDYT? > Counting more

[jira] [Created] (FLINK-13050) Counting more checkpoint failure reason in CheckpointFailureManager

2019-07-01 Thread vinoyang (JIRA)
vinoyang created FLINK-13050: Summary: Counting more checkpoint failure reason in CheckpointFailureManager Key: FLINK-13050 URL: https://issues.apache.org/jira/browse/FLINK-13050 Project: Flink

[GitHub] [flink] liyafan82 closed pull request #8934: [FLINK-12628][Runtime / Coordination] Check test failure if partitionhas no consumers in Execution.getPartitionMaxParallelism

2019-07-01 Thread GitBox
liyafan82 closed pull request #8934: [FLINK-12628][Runtime / Coordination] Check test failure if partitionhas no consumers in Execution.getPartitionMaxParallelism URL: https://github.com/apache/flink/pull/8934 This is an au

[GitHub] [flink] liyafan82 opened a new pull request #8934: [FLINK-12628][Runtime / Coordination] Check test failure if partitionhas no consumers in Execution.getPartitionMaxParallelism

2019-07-01 Thread GitBox
liyafan82 opened a new pull request #8934: [FLINK-12628][Runtime / Coordination] Check test failure if partitionhas no consumers in Execution.getPartitionMaxParallelism URL: https://github.com/apache/flink/pull/8934 ## What is the purpose of the change Resolve issue FLINK-12

[GitHub] [flink] liyafan82 commented on a change in pull request #8934: [FLINK-12628][Runtime / Coordination] Check test failure if partitionhas no consumers in Execution.getPartitionMaxParallelism

2019-07-01 Thread GitBox
liyafan82 commented on a change in pull request #8934: [FLINK-12628][Runtime / Coordination] Check test failure if partitionhas no consumers in Execution.getPartitionMaxParallelism URL: https://github.com/apache/flink/pull/8934#discussion_r299282016 ## File path: flink-runtime/src

[GitHub] [flink] liyafan82 commented on a change in pull request #8936: [FLINK-13043][Library / CEP] Fix the bug of parsing Dewey number from string

2019-07-01 Thread GitBox
liyafan82 commented on a change in pull request #8936: [FLINK-13043][Library / CEP] Fix the bug of parsing Dewey number from string URL: https://github.com/apache/flink/pull/8936#discussion_r299281233 ## File path: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/De

[GitHub] [flink] bowenli86 commented on a change in pull request #8940: [FLINK-13047][table] Fix the Optional.orElse() usage issue in Databas…

2019-07-01 Thread GitBox
bowenli86 commented on a change in pull request #8940: [FLINK-13047][table] Fix the Optional.orElse() usage issue in Databas… URL: https://github.com/apache/flink/pull/8940#discussion_r299279990 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/cata

[jira] [Commented] (FLINK-13037) Translate "Concepts -> Glossary" page into Chinese

2019-07-01 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876607#comment-16876607 ] Jark Wu commented on FLINK-13037: - Hi [~knaufk], could you link the prerequisite issue w

[GitHub] [flink] ifndef-SleePy closed pull request #8894: [FLINK-12961][datastream] Providing an internal execution method of StreamExecutionEnvironment accepting StreamGraph as input parameter

2019-07-01 Thread GitBox
ifndef-SleePy closed pull request #8894: [FLINK-12961][datastream] Providing an internal execution method of StreamExecutionEnvironment accepting StreamGraph as input parameter URL: https://github.com/apache/flink/pull/8894 ---

[GitHub] [flink] ifndef-SleePy commented on issue #8894: [FLINK-12961][datastream] Providing an internal execution method of StreamExecutionEnvironment accepting StreamGraph as input parameter

2019-07-01 Thread GitBox
ifndef-SleePy commented on issue #8894: [FLINK-12961][datastream] Providing an internal execution method of StreamExecutionEnvironment accepting StreamGraph as input parameter URL: https://github.com/apache/flink/pull/8894#issuecomment-507490234 Abandon this PR since we think alternative

[jira] [Updated] (FLINK-13037) Translate "Concepts -> Glossary" page into Chinese

2019-07-01 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-13037: Component/s: Documentation chinese-translation > Translate "Concepts -> Glossary" page in

[jira] [Created] (FLINK-13049) Port planner expressions to blink-planner from flink-planner

2019-07-01 Thread Jingsong Lee (JIRA)
Jingsong Lee created FLINK-13049: Summary: Port planner expressions to blink-planner from flink-planner Key: FLINK-13049 URL: https://issues.apache.org/jira/browse/FLINK-13049 Project: Flink

[GitHub] [flink] xuefuz commented on issue #8926: [FLINK-13021][table][hive] unify catalog partition implementations

2019-07-01 Thread GitBox
xuefuz commented on issue #8926: [FLINK-13021][table][hive] unify catalog partition implementations URL: https://github.com/apache/flink/pull/8926#issuecomment-507481283 Okay. thanks for the explanation. I guess both don't matter much right now. Let's review on comments when we do DDL. --

[GitHub] [flink] xuefuz commented on a change in pull request #8940: [FLINK-13047][table] Fix the Optional.orElse() usage issue in Databas…

2019-07-01 Thread GitBox
xuefuz commented on a change in pull request #8940: [FLINK-13047][table] Fix the Optional.orElse() usage issue in Databas… URL: https://github.com/apache/flink/pull/8940#discussion_r299262699 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/catalog

[GitHub] [flink] asfgit closed pull request #8669: [FLINK-11147][table][docs] Add documentation for TableAggregate Function

2019-07-01 Thread GitBox
asfgit closed pull request #8669: [FLINK-11147][table][docs] Add documentation for TableAggregate Function URL: https://github.com/apache/flink/pull/8669 This is an automated message from the Apache Git Service. To respond t

[jira] [Closed] (FLINK-11147) Add documentation for TableAggregate Function

2019-07-01 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng closed FLINK-11147. --- Resolution: Fixed Fix Version/s: 1.9.0 Fixed in master : 6a12908b15c398e37f8603cd84e0d30e14d0

[GitHub] [flink] bowenli86 commented on issue #8926: [FLINK-13021][table][hive] unify catalog partition implementations

2019-07-01 Thread GitBox
bowenli86 commented on issue #8926: [FLINK-13021][table][hive] unify catalog partition implementations URL: https://github.com/apache/flink/pull/8926#issuecomment-507466762 Good questions. > 1. I saw a few configuration files for Hive (table/db, etc) and each has just few constants.

[GitHub] [flink] flinkbot edited a comment on issue #8669: [FLINK-11147][table][docs] Add documentation for TableAggregate Function

2019-07-01 Thread GitBox
flinkbot edited a comment on issue #8669: [FLINK-11147][table][docs] Add documentation for TableAggregate Function URL: https://github.com/apache/flink/pull/8669#issuecomment-500274671 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[GitHub] [flink] bowenli86 commented on a change in pull request #8940: [FLINK-13047][table] Fix the Optional.orElse() usage issue in Databas…

2019-07-01 Thread GitBox
bowenli86 commented on a change in pull request #8940: [FLINK-13047][table] Fix the Optional.orElse() usage issue in Databas… URL: https://github.com/apache/flink/pull/8940#discussion_r299256624 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/cata

[GitHub] [flink] bowenli86 commented on a change in pull request #8940: [FLINK-13047][table] Fix the Optional.orElse() usage issue in Databas…

2019-07-01 Thread GitBox
bowenli86 commented on a change in pull request #8940: [FLINK-13047][table] Fix the Optional.orElse() usage issue in Databas… URL: https://github.com/apache/flink/pull/8940#discussion_r299256624 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/cata

[GitHub] [flink] flinkbot commented on issue #8941: [FLINK-13048][hive] support decimal in Flink's integration with Hive …

2019-07-01 Thread GitBox
flinkbot commented on issue #8941: [FLINK-13048][hive] support decimal in Flink's integration with Hive … URL: https://github.com/apache/flink/pull/8941#issuecomment-507462215 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to revi

[jira] [Updated] (FLINK-13048) support decimal in Flink's integration with Hive user defined functions

2019-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13048: --- Labels: pull-request-available (was: ) > support decimal in Flink's integration with Hive u

[GitHub] [flink] bowenli86 opened a new pull request #8941: [FLINK-13048][hive] support decimal in Flink's integration with Hive …

2019-07-01 Thread GitBox
bowenli86 opened a new pull request #8941: [FLINK-13048][hive] support decimal in Flink's integration with Hive … URL: https://github.com/apache/flink/pull/8941 …user defined functions ## What is the purpose of the change This PR adds support for decimal in Flink's integration

[GitHub] [flink] bowenli86 commented on issue #8941: [FLINK-13048][hive] support decimal in Flink's integration with Hive …

2019-07-01 Thread GitBox
bowenli86 commented on issue #8941: [FLINK-13048][hive] support decimal in Flink's integration with Hive … URL: https://github.com/apache/flink/pull/8941#issuecomment-507461988 cc @xuefuz @JingsongLi @lirui-apache @zjuwangg

[jira] [Created] (FLINK-13048) support decimal in Flink's integration with Hive user defined functions

2019-07-01 Thread Bowen Li (JIRA)
Bowen Li created FLINK-13048: Summary: support decimal in Flink's integration with Hive user defined functions Key: FLINK-13048 URL: https://issues.apache.org/jira/browse/FLINK-13048 Project: Flink

[GitHub] [flink] xuefuz commented on a change in pull request #8926: [FLINK-13021][table][hive] unify catalog partition implementations

2019-07-01 Thread GitBox
xuefuz commented on a change in pull request #8926: [FLINK-13021][table][hive] unify catalog partition implementations URL: https://github.com/apache/flink/pull/8926#discussion_r299243763 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catal

[GitHub] [flink] flinkbot commented on issue #8940: [FLINK-13047][table] Fix the Optional.orElse() usage issue in Databas…

2019-07-01 Thread GitBox
flinkbot commented on issue #8940: [FLINK-13047][table] Fix the Optional.orElse() usage issue in Databas… URL: https://github.com/apache/flink/pull/8940#issuecomment-507448909 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to revi

[jira] [Updated] (FLINK-13047) Fix the Optional.orElse() usage issue in DatabaseCalciteSchema

2019-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13047: --- Labels: pull-request-available (was: ) > Fix the Optional.orElse() usage issue in DatabaseC

[GitHub] [flink] xuefuz commented on issue #8940: [FLINK-13047][table] Fix the Optional.orElse() usage issue in Databas…

2019-07-01 Thread GitBox
xuefuz commented on issue #8940: [FLINK-13047][table] Fix the Optional.orElse() usage issue in Databas… URL: https://github.com/apache/flink/pull/8940#issuecomment-507448645 cc: @bowenli86 @lirui-apache @zjuwangg This is an

[GitHub] [flink] xuefuz opened a new pull request #8940: [FLINK-13047][table] Fix the Optional.orElse() usage issue in Databas…

2019-07-01 Thread GitBox
xuefuz opened a new pull request #8940: [FLINK-13047][table] Fix the Optional.orElse() usage issue in Databas… URL: https://github.com/apache/flink/pull/8940 …eCalciteSchema ## What is the purpose of the change [FLINK-13047][table] Fix the Optional.orElse() usage issue

[jira] [Created] (FLINK-13047) Fix the Optional.orElse() usage issue in DatabaseCalciteSchema

2019-07-01 Thread Xuefu Zhang (JIRA)
Xuefu Zhang created FLINK-13047: --- Summary: Fix the Optional.orElse() usage issue in DatabaseCalciteSchema Key: FLINK-13047 URL: https://issues.apache.org/jira/browse/FLINK-13047 Project: Flink

[jira] [Comment Edited] (FLINK-5478) Redis Sink Connector should allow update of command without reinstatiation

2019-07-01 Thread Ton van Bart (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876472#comment-16876472 ] Ton van Bart edited comment on FLINK-5478 at 7/1/19 8:28 PM: -

[jira] [Comment Edited] (FLINK-5478) Redis Sink Connector should allow update of command without reinstatiation

2019-07-01 Thread Ton van Bart (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876472#comment-16876472 ] Ton van Bart edited comment on FLINK-5478 at 7/1/19 8:27 PM: -

[jira] [Commented] (FLINK-5478) Redis Sink Connector should allow update of command without reinstatiation

2019-07-01 Thread Ton van Bart (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876472#comment-16876472 ] Ton van Bart commented on FLINK-5478: - I think calling {{getCommandDescription()}} on

[GitHub] [flink] flinkbot commented on issue #8939: [FLINK-13046][hive] rename hive-site-path to hive-conf-dir to be cons…

2019-07-01 Thread GitBox
flinkbot commented on issue #8939: [FLINK-13046][hive] rename hive-site-path to hive-conf-dir to be cons… URL: https://github.com/apache/flink/pull/8939#issuecomment-507400400 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to revi

[jira] [Updated] (FLINK-13046) rename hive-site-path to hive-conf-dir to be consistent with standard name in Hive

2019-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13046: --- Labels: pull-request-available (was: ) > rename hive-site-path to hive-conf-dir to be consi

[GitHub] [flink] bowenli86 commented on issue #8939: [FLINK-13046][hive] rename hive-site-path to hive-conf-dir to be cons…

2019-07-01 Thread GitBox
bowenli86 commented on issue #8939: [FLINK-13046][hive] rename hive-site-path to hive-conf-dir to be cons… URL: https://github.com/apache/flink/pull/8939#issuecomment-507400080 cc @xuefuz @lirui-apache @zjuwangg This is an a

[GitHub] [flink] bowenli86 opened a new pull request #8939: [FLINK-13046][hive] rename hive-site-path to hive-conf-dir to be cons…

2019-07-01 Thread GitBox
bowenli86 opened a new pull request #8939: [FLINK-13046][hive] rename hive-site-path to hive-conf-dir to be cons… URL: https://github.com/apache/flink/pull/8939 …istent with standard name in Hive ## What is the purpose of the change This PR renames the SQL CLI config key for H

[GitHub] [flink] bowenli86 commented on issue #8926: [FLINK-13021][table][hive] unify catalog partition implementations

2019-07-01 Thread GitBox
bowenli86 commented on issue #8926: [FLINK-13021][table][hive] unify catalog partition implementations URL: https://github.com/apache/flink/pull/8926#issuecomment-507395104 cc @xuefuz @lirui-apache @zjuwangg This is an autom

[jira] [Created] (FLINK-13046) rename hive-site-path to hive-conf-dir to be consistent with standard name in Hive

2019-07-01 Thread Bowen Li (JIRA)
Bowen Li created FLINK-13046: Summary: rename hive-site-path to hive-conf-dir to be consistent with standard name in Hive Key: FLINK-13046 URL: https://issues.apache.org/jira/browse/FLINK-13046 Project: F

[GitHub] [flink] flinkbot edited a comment on issue #8920: [FLINK-13024][table] integrate FunctionCatalog with CatalogManager

2019-07-01 Thread GitBox
flinkbot edited a comment on issue #8920: [FLINK-13024][table] integrate FunctionCatalog with CatalogManager URL: https://github.com/apache/flink/pull/8920#issuecomment-506515812 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to r

[GitHub] [flink] bowenli86 commented on issue #8920: [FLINK-13024][table] integrate FunctionCatalog with CatalogManager

2019-07-01 Thread GitBox
bowenli86 commented on issue #8920: [FLINK-13024][table] integrate FunctionCatalog with CatalogManager URL: https://github.com/apache/flink/pull/8920#issuecomment-507386500 @flinkbot attention @twalthr @dawidwys This is an a

[GitHub] [flink] flinkbot edited a comment on issue #8911: [FLINK-12995][hive] Add Hive-1.2.1 build to Travis

2019-07-01 Thread GitBox
flinkbot edited a comment on issue #8911: [FLINK-12995][hive] Add Hive-1.2.1 build to Travis URL: https://github.com/apache/flink/pull/8911#issuecomment-506262493 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull

  1   2   3   4   >