[GitHub] [flink] flinkbot edited a comment on issue #9738: [FLINK-13746]Whitelist [Terror] to avoid end to end test failure in e…

2019-09-20 Thread GitBox
flinkbot edited a comment on issue #9738: [FLINK-13746]Whitelist [Terror] to avoid end to end test failure in e… URL: https://github.com/apache/flink/pull/9738#issuecomment-533770354 ## CI report: * b13b6edb9952c74ba5b68d0f64bd6393534c73ea : SUCCESS [Build](https://travis-ci.com

[GitHub] [flink] flinkbot edited a comment on issue #9738: [FLINK-13746]Whitelist [Terror] to avoid end to end test failure in e…

2019-09-20 Thread GitBox
flinkbot edited a comment on issue #9738: [FLINK-13746]Whitelist [Terror] to avoid end to end test failure in e… URL: https://github.com/apache/flink/pull/9738#issuecomment-533770354 ## CI report: * b13b6edb9952c74ba5b68d0f64bd6393534c73ea : PENDING [Build](https://travis-ci.com

[GitHub] [flink] flinkbot commented on issue #9738: [FLINK-13746]Whitelist [Terror] to avoid end to end test failure in e…

2019-09-20 Thread GitBox
flinkbot commented on issue #9738: [FLINK-13746]Whitelist [Terror] to avoid end to end test failure in e… URL: https://github.com/apache/flink/pull/9738#issuecomment-533770354 ## CI report: * b13b6edb9952c74ba5b68d0f64bd6393534c73ea : UNKNOWN

[jira] [Commented] (FLINK-13746) Elasticsearch (v2.3.5) sink end-to-end test fails on Travis

2019-09-20 Thread Zijie Lu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934921#comment-16934921 ] Zijie Lu commented on FLINK-13746: -- I have submitted a pull request [https://github.com

[GitHub] [flink] flinkbot commented on issue #9738: [FLINK-13746]Whitelist [Terror] to avoid end to end test failure in e…

2019-09-20 Thread GitBox
flinkbot commented on issue #9738: [FLINK-13746]Whitelist [Terror] to avoid end to end test failure in e… URL: https://github.com/apache/flink/pull/9738#issuecomment-533770121 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to revi

[jira] [Updated] (FLINK-13746) Elasticsearch (v2.3.5) sink end-to-end test fails on Travis

2019-09-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13746: --- Labels: pull-request-available test-stability (was: test-stability) > Elasticsearch (v2.3.5

[GitHub] [flink] TszKitLo40 opened a new pull request #9738: [FLINK-13746]Whitelist [Terror] to avoid end to end test failure in e…

2019-09-20 Thread GitBox
TszKitLo40 opened a new pull request #9738: [FLINK-13746]Whitelist [Terror] to avoid end to end test failure in e… URL: https://github.com/apache/flink/pull/9738 …s 2.3.5 ## What is the purpose of the change *(For example: This pull request makes task deployment go thr

[GitHub] [flink] lirui-apache commented on a change in pull request #9721: [FLINK-14129][hive] HiveTableSource should implement ProjectableTable…

2019-09-20 Thread GitBox
lirui-apache commented on a change in pull request #9721: [FLINK-14129][hive] HiveTableSource should implement ProjectableTable… URL: https://github.com/apache/flink/pull/9721#discussion_r326846024 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/c

[GitHub] [flink] flinkbot edited a comment on issue #9416: [FLINK-13646][build system] Add basic ARM CI job definition

2019-09-20 Thread GitBox
flinkbot edited a comment on issue #9416: [FLINK-13646][build system] Add basic ARM CI job definition URL: https://github.com/apache/flink/pull/9416#issuecomment-520285701 ## CI report: * dbf749f0d0c3167265287b182dd1ea7b4aed84c1 : FAILURE [Build](https://travis-ci.com/flink-ci/f

[GitHub] [flink] flinkbot edited a comment on issue #9416: [FLINK-13646][build system] Add basic ARM CI job definition

2019-09-20 Thread GitBox
flinkbot edited a comment on issue #9416: [FLINK-13646][build system] Add basic ARM CI job definition URL: https://github.com/apache/flink/pull/9416#issuecomment-520285701 ## CI report: * dbf749f0d0c3167265287b182dd1ea7b4aed84c1 : FAILURE [Build](https://travis-ci.com/flink-ci/f

[jira] [Updated] (FLINK-14159) flink rocksdb StreamCompressionDecorator not right

2019-09-20 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jackylau updated FLINK-14159: - Description: I think the current flink rocksdb StreamCompressionDecorator is not right when calling met

[jira] [Comment Edited] (FLINK-14159) flink rocksdb StreamCompressionDecorator not right

2019-09-20 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934884#comment-16934884 ] jackylau edited comment on FLINK-14159 at 9/21/19 2:36 AM: --- I

[jira] [Commented] (FLINK-14159) flink rocksdb StreamCompressionDecorator not right

2019-09-20 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934884#comment-16934884 ] jackylau commented on FLINK-14159: -- who is responsible for , and who can see this issue

[GitHub] [flink] flinkbot edited a comment on issue #9416: [FLINK-13646][build system] Add basic ARM CI job definition

2019-09-20 Thread GitBox
flinkbot edited a comment on issue #9416: [FLINK-13646][build system] Add basic ARM CI job definition URL: https://github.com/apache/flink/pull/9416#issuecomment-520285701 ## CI report: * dbf749f0d0c3167265287b182dd1ea7b4aed84c1 : FAILURE [Build](https://travis-ci.com/flink-ci/f

[jira] [Created] (FLINK-14159) flink rocksdb StreamCompressionDecorator not right

2019-09-20 Thread jackylau (Jira)
jackylau created FLINK-14159: Summary: flink rocksdb StreamCompressionDecorator not right Key: FLINK-14159 URL: https://issues.apache.org/jira/browse/FLINK-14159 Project: Flink Issue Type: Bug

[GitHub] [flink] wangxiyuan commented on issue #9416: [FLINK-13646][build system] Add basic ARM CI job definition

2019-09-20 Thread GitBox
wangxiyuan commented on issue #9416: [FLINK-13646][build system] Add basic ARM CI job definition URL: https://github.com/apache/flink/pull/9416#issuecomment-533758675 check_arm This is an automated message from the Apache Git

[GitHub] [flink] flinkbot edited a comment on issue #9737: [FLINK-14158] Update Mesos scheduler to make leaseOfferExpiration and declinedOfferRefuse duration configurable

2019-09-20 Thread GitBox
flinkbot edited a comment on issue #9737: [FLINK-14158] Update Mesos scheduler to make leaseOfferExpiration and declinedOfferRefuse duration configurable URL: https://github.com/apache/flink/pull/9737#issuecomment-533692308 ## CI report: * 6570149a99fac86e45cc3b0c9a83b32ff7b32365

[GitHub] [flink] flinkbot edited a comment on issue #9737: [FLINK-14158] Update Mesos scheduler to make leaseOfferExpiration and declinedOfferRefuse duration configurable

2019-09-20 Thread GitBox
flinkbot edited a comment on issue #9737: [FLINK-14158] Update Mesos scheduler to make leaseOfferExpiration and declinedOfferRefuse duration configurable URL: https://github.com/apache/flink/pull/9737#issuecomment-533692308 ## CI report: * 6570149a99fac86e45cc3b0c9a83b32ff7b32365

[GitHub] [flink] bowenli86 commented on a change in pull request #9721: [FLINK-14129][hive] HiveTableSource should implement ProjectableTable…

2019-09-20 Thread GitBox
bowenli86 commented on a change in pull request #9721: [FLINK-14129][hive] HiveTableSource should implement ProjectableTable… URL: https://github.com/apache/flink/pull/9721#discussion_r326790235 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/conn

[GitHub] [flink] flinkbot commented on issue #9737: [FLINK-14158] Update Mesos scheduler to make leaseOfferExpiration and declinedOfferRefuse duration configurable

2019-09-20 Thread GitBox
flinkbot commented on issue #9737: [FLINK-14158] Update Mesos scheduler to make leaseOfferExpiration and declinedOfferRefuse duration configurable URL: https://github.com/apache/flink/pull/9737#issuecomment-533692308 ## CI report: * 6570149a99fac86e45cc3b0c9a83b32ff7b32365 : UNKN

[GitHub] [flink] kl0u commented on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink

2019-09-20 Thread GitBox
kl0u commented on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink URL: https://github.com/apache/flink/pull/9581#issuecomment-533688638 @tweise It would be nice if it can be addressed before merging

[GitHub] [flink] flinkbot commented on issue #9737: [FLINK-14158] Update Mesos scheduler to make leaseOfferExpiration and declinedOfferRefuse duration configurable

2019-09-20 Thread GitBox
flinkbot commented on issue #9737: [FLINK-14158] Update Mesos scheduler to make leaseOfferExpiration and declinedOfferRefuse duration configurable URL: https://github.com/apache/flink/pull/9737#issuecomment-533687706 Thanks a lot for your contribution to the Apache Flink project. I'm the @

[jira] [Updated] (FLINK-14158) Update Mesos configs to add leaseOfferExpiration and declinedOfferRefuse durations

2019-09-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-14158: --- Labels: pull-request-available (was: ) > Update Mesos configs to add leaseOfferExpiration a

[GitHub] [flink] piyushnarang opened a new pull request #9737: [FLINK-14158] Update Mesos scheduler to make leaseOfferExpiration and declinedOfferRefuse duration configurable

2019-09-20 Thread GitBox
piyushnarang opened a new pull request #9737: [FLINK-14158] Update Mesos scheduler to make leaseOfferExpiration and declinedOfferRefuse duration configurable URL: https://github.com/apache/flink/pull/9737 ## What is the purpose of the change While debugging some Flink on Mes

[jira] [Created] (FLINK-14158) Update Mesos configs to add leaseOfferExpiration and declinedOfferRefuse durations

2019-09-20 Thread Piyush Narang (Jira)
Piyush Narang created FLINK-14158: - Summary: Update Mesos configs to add leaseOfferExpiration and declinedOfferRefuse durations Key: FLINK-14158 URL: https://issues.apache.org/jira/browse/FLINK-14158

[GitHub] [flink] tweise commented on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink

2019-09-20 Thread GitBox
tweise commented on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink URL: https://github.com/apache/flink/pull/9581#issuecomment-533679202 @kl0u thanks for working through this. Should the constructo

[GitHub] [flink] yxu-valleytider removed a comment on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink

2019-09-20 Thread GitBox
yxu-valleytider removed a comment on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink URL: https://github.com/apache/flink/pull/9581#issuecomment-533666729 🚀 ---

[GitHub] [flink] yxu-valleytider commented on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink

2019-09-20 Thread GitBox
yxu-valleytider commented on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink URL: https://github.com/apache/flink/pull/9581#issuecomment-533666729 🚀 ---

[GitHub] [flink] yxu-valleytider commented on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink

2019-09-20 Thread GitBox
yxu-valleytider commented on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink URL: https://github.com/apache/flink/pull/9581#issuecomment-533666702 > @yxu-valleytider I think we can merge this PR as

[GitHub] [flink] flinkbot edited a comment on issue #9726: [FLINK-14113][client] Remove class JobWithJars

2019-09-20 Thread GitBox
flinkbot edited a comment on issue #9726: [FLINK-14113][client] Remove class JobWithJars URL: https://github.com/apache/flink/pull/9726#issuecomment-533472035 ## CI report: * 9d72829c8c3697d2e2582005ba60863d525ffc66 : UNKNOWN * 49a801cce0eb397c0248250d986ce99ade485941 : SUCCES

[GitHub] [flink] flinkbot edited a comment on issue #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools

2019-09-20 Thread GitBox
flinkbot edited a comment on issue #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools URL: https://github.com/apache/flink/pull/9693#issuecomment-531808855 ## CI report: * 62ad65e31df8f36747991513ab89504126758af6 : CANCELED [Build](https://travis-ci.com/flin

[GitHub] [flink] flinkbot edited a comment on issue #9468: [FLINK-13689] [Connectors/ElasticSearch] Fix thread leak when elasticsearch6 rest high level cli…

2019-09-20 Thread GitBox
flinkbot edited a comment on issue #9468: [FLINK-13689] [Connectors/ElasticSearch] Fix thread leak when elasticsearch6 rest high level cli… URL: https://github.com/apache/flink/pull/9468#issuecomment-522106295 ## CI report: * 78654e8f80aa0b1a01654e7684f4610eb1d3aff4 : SUCCESS [

[GitHub] [flink] aljoscha commented on a change in pull request #9726: [FLINK-14113][client] Remove class JobWithJars

2019-09-20 Thread GitBox
aljoscha commented on a change in pull request #9726: [FLINK-14113][client] Remove class JobWithJars URL: https://github.com/apache/flink/pull/9726#discussion_r326714019 ## File path: flink-clients/src/main/java/org/apache/flink/client/ClientUtils.java ## @@ -124,6 +47,7 @

[GitHub] [flink] flinkbot edited a comment on issue #9726: [FLINK-14113][client] Remove class JobWithJars

2019-09-20 Thread GitBox
flinkbot edited a comment on issue #9726: [FLINK-14113][client] Remove class JobWithJars URL: https://github.com/apache/flink/pull/9726#issuecomment-533472035 ## CI report: * 9d72829c8c3697d2e2582005ba60863d525ffc66 : UNKNOWN * 49a801cce0eb397c0248250d986ce99ade485941 : SUCCES

[GitHub] [flink] flinkbot edited a comment on issue #9726: [FLINK-14113][client] Remove class JobWithJars

2019-09-20 Thread GitBox
flinkbot edited a comment on issue #9726: [FLINK-14113][client] Remove class JobWithJars URL: https://github.com/apache/flink/pull/9726#issuecomment-533472035 ## CI report: * 9d72829c8c3697d2e2582005ba60863d525ffc66 : UNKNOWN * 49a801cce0eb397c0248250d986ce99ade485941 : SUCCES

[GitHub] [flink] flinkbot edited a comment on issue #9468: [FLINK-13689] [Connectors/ElasticSearch] Fix thread leak when elasticsearch6 rest high level cli…

2019-09-20 Thread GitBox
flinkbot edited a comment on issue #9468: [FLINK-13689] [Connectors/ElasticSearch] Fix thread leak when elasticsearch6 rest high level cli… URL: https://github.com/apache/flink/pull/9468#issuecomment-522106295 ## CI report: * 78654e8f80aa0b1a01654e7684f4610eb1d3aff4 : SUCCESS [

[GitHub] [flink] flinkbot edited a comment on issue #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools

2019-09-20 Thread GitBox
flinkbot edited a comment on issue #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools URL: https://github.com/apache/flink/pull/9693#issuecomment-531808855 ## CI report: * 62ad65e31df8f36747991513ab89504126758af6 : CANCELED [Build](https://travis-ci.com/flin

[GitHub] [flink] TisonKun commented on a change in pull request #9727: [FLINK-14145] Fix getLatestCheckpoint(true) returns wrong checkpoint

2019-09-20 Thread GitBox
TisonKun commented on a change in pull request #9727: [FLINK-14145] Fix getLatestCheckpoint(true) returns wrong checkpoint URL: https://github.com/apache/flink/pull/9727#discussion_r326695695 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedChe

[GitHub] [flink] flinkbot edited a comment on issue #9468: [FLINK-13689] [Connectors/ElasticSearch] Fix thread leak when elasticsearch6 rest high level cli…

2019-09-20 Thread GitBox
flinkbot edited a comment on issue #9468: [FLINK-13689] [Connectors/ElasticSearch] Fix thread leak when elasticsearch6 rest high level cli… URL: https://github.com/apache/flink/pull/9468#issuecomment-522106295 ## CI report: * 78654e8f80aa0b1a01654e7684f4610eb1d3aff4 : SUCCESS [

[GitHub] [flink] flinkbot edited a comment on issue #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools

2019-09-20 Thread GitBox
flinkbot edited a comment on issue #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools URL: https://github.com/apache/flink/pull/9693#issuecomment-531808855 ## CI report: * 62ad65e31df8f36747991513ab89504126758af6 : CANCELED [Build](https://travis-ci.com/flin

[GitHub] [flink] TisonKun commented on a change in pull request #9726: [FLINK-14113][client] Remove class JobWithJars

2019-09-20 Thread GitBox
TisonKun commented on a change in pull request #9726: [FLINK-14113][client] Remove class JobWithJars URL: https://github.com/apache/flink/pull/9726#discussion_r326691424 ## File path: flink-clients/src/main/java/org/apache/flink/client/ClientUtils.java ## @@ -124,6 +47,7 @

[GitHub] [flink] TisonKun commented on a change in pull request #9726: [FLINK-14113][client] Remove class JobWithJars

2019-09-20 Thread GitBox
TisonKun commented on a change in pull request #9726: [FLINK-14113][client] Remove class JobWithJars URL: https://github.com/apache/flink/pull/9726#discussion_r326691424 ## File path: flink-clients/src/main/java/org/apache/flink/client/ClientUtils.java ## @@ -124,6 +47,7 @

[GitHub] [flink] ex00 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-09-20 Thread GitBox
ex00 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#discussion_r326684479 ## File path: flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/AlgoOperator.java ##

[GitHub] [flink] ex00 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-09-20 Thread GitBox
ex00 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#discussion_r326669328 ## File path: flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/AlgoOperator.java ##

[GitHub] [flink] ex00 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-09-20 Thread GitBox
ex00 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#discussion_r32594 ## File path: flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/AlgoOperator.java ##

[GitHub] [flink] ex00 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-09-20 Thread GitBox
ex00 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#discussion_r326674127 ## File path: flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/batchoperator/source/TableSo

[GitHub] [flink] ex00 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-09-20 Thread GitBox
ex00 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#discussion_r326669328 ## File path: flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/AlgoOperator.java ##

[GitHub] [flink] ex00 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-09-20 Thread GitBox
ex00 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#discussion_r326684479 ## File path: flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/AlgoOperator.java ##

[GitHub] [flink] flinkbot edited a comment on issue #9727: [FLINK-14145] Fix getLatestCheckpoint(true) returns wrong checkpoint

2019-09-20 Thread GitBox
flinkbot edited a comment on issue #9727: [FLINK-14145] Fix getLatestCheckpoint(true) returns wrong checkpoint URL: https://github.com/apache/flink/pull/9727#issuecomment-533484572 ## CI report: * 31a78ba191c36561f073b0b5a0a2c1b6aa2d18a0 : SUCCESS [Build](https://travis-ci.com/f

[GitHub] [flink] gyfora commented on issue #9727: [FLINK-14145] Fix getLatestCheckpoint(true) returns wrong checkpoint

2019-09-20 Thread GitBox
gyfora commented on issue #9727: [FLINK-14145] Fix getLatestCheckpoint(true) returns wrong checkpoint URL: https://github.com/apache/flink/pull/9727#issuecomment-533599941 > Thanks for your updates @gyfora. Tests part looks good to me. I will share my version of `getLatestCheckpoint`. You'

[GitHub] [flink] azagrebin commented on issue #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools

2019-09-20 Thread GitBox
azagrebin commented on issue #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools URL: https://github.com/apache/flink/pull/9693#issuecomment-533599524 Thanks for the review @KarmaGYZ I have updated the PR.

[GitHub] [flink] aljoscha commented on a change in pull request #9726: [FLINK-14113][client] Remove class JobWithJars

2019-09-20 Thread GitBox
aljoscha commented on a change in pull request #9726: [FLINK-14113][client] Remove class JobWithJars URL: https://github.com/apache/flink/pull/9726#discussion_r326609037 ## File path: flink-clients/src/main/java/org/apache/flink/client/ClientUtils.java ## @@ -124,6 +47,7 @

[GitHub] [flink] gyfora commented on a change in pull request #9727: [FLINK-14145] Fix getLatestCheckpoint(true) returns wrong checkpoint

2019-09-20 Thread GitBox
gyfora commented on a change in pull request #9727: [FLINK-14145] Fix getLatestCheckpoint(true) returns wrong checkpoint URL: https://github.com/apache/flink/pull/9727#discussion_r326680093 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheck

[GitHub] [flink] azagrebin commented on a change in pull request #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools

2019-09-20 Thread GitBox
azagrebin commented on a change in pull request #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools URL: https://github.com/apache/flink/pull/9693#discussion_r326679037 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/memory/MemoryManager.java

[GitHub] [flink] azagrebin commented on a change in pull request #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools

2019-09-20 Thread GitBox
azagrebin commented on a change in pull request #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools URL: https://github.com/apache/flink/pull/9693#discussion_r326676164 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/memory/MemoryManager.java

[GitHub] [flink] azagrebin commented on a change in pull request #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools

2019-09-20 Thread GitBox
azagrebin commented on a change in pull request #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools URL: https://github.com/apache/flink/pull/9693#discussion_r326675307 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/memory/MemoryManager.java

[GitHub] [flink] azagrebin commented on a change in pull request #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools

2019-09-20 Thread GitBox
azagrebin commented on a change in pull request #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools URL: https://github.com/apache/flink/pull/9693#discussion_r326675307 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/memory/MemoryManager.java

[GitHub] [flink] azagrebin commented on a change in pull request #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools

2019-09-20 Thread GitBox
azagrebin commented on a change in pull request #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools URL: https://github.com/apache/flink/pull/9693#discussion_r326673300 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/memory/MemoryManager.java

[GitHub] [flink] azagrebin commented on a change in pull request #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools

2019-09-20 Thread GitBox
azagrebin commented on a change in pull request #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools URL: https://github.com/apache/flink/pull/9693#discussion_r326673300 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/memory/MemoryManager.java

[GitHub] [flink] azagrebin commented on a change in pull request #8479: [FLINK-11193][State Backends]Use user passed configuration overriding default configuration loading from file

2019-09-20 Thread GitBox
azagrebin commented on a change in pull request #8479: [FLINK-11193][State Backends]Use user passed configuration overriding default configuration loading from file URL: https://github.com/apache/flink/pull/8479#discussion_r323107972 ## File path: flink-state-backends/flink-stateb

[GitHub] [flink] azagrebin commented on a change in pull request #8479: [FLINK-11193][State Backends]Use user passed configuration overriding default configuration loading from file

2019-09-20 Thread GitBox
azagrebin commented on a change in pull request #8479: [FLINK-11193][State Backends]Use user passed configuration overriding default configuration loading from file URL: https://github.com/apache/flink/pull/8479#discussion_r323107474 ## File path: flink-state-backends/flink-stateb

[GitHub] [flink] azagrebin commented on a change in pull request #8479: [FLINK-11193][State Backends]Use user passed configuration overriding default configuration loading from file

2019-09-20 Thread GitBox
azagrebin commented on a change in pull request #8479: [FLINK-11193][State Backends]Use user passed configuration overriding default configuration loading from file URL: https://github.com/apache/flink/pull/8479#discussion_r323108356 ## File path: flink-state-backends/flink-stateb

[GitHub] [flink] flinkbot edited a comment on issue #9727: [FLINK-14145] Fix getLatestCheckpoint(true) returns wrong checkpoint

2019-09-20 Thread GitBox
flinkbot edited a comment on issue #9727: [FLINK-14145] Fix getLatestCheckpoint(true) returns wrong checkpoint URL: https://github.com/apache/flink/pull/9727#issuecomment-533484572 ## CI report: * 31a78ba191c36561f073b0b5a0a2c1b6aa2d18a0 : SUCCESS [Build](https://travis-ci.com/f

[GitHub] [flink] flinkbot edited a comment on issue #9736: [FLINK-14157] Disable StreamingFileSink e2e test for java 11

2019-09-20 Thread GitBox
flinkbot edited a comment on issue #9736: [FLINK-14157] Disable StreamingFileSink e2e test for java 11 URL: https://github.com/apache/flink/pull/9736#issuecomment-533561281 ## CI report: * c8f2280889a4f076dc56329912b7890c8f828dd7 : SUCCESS [Build](https://travis-ci.com/flink-ci/

[GitHub] [flink] flinkbot edited a comment on issue #9735: [FLINK-14156][runtime] Submit timer trigger letters to task's mailbox with operator's precedence

2019-09-20 Thread GitBox
flinkbot edited a comment on issue #9735: [FLINK-14156][runtime] Submit timer trigger letters to task's mailbox with operator's precedence URL: https://github.com/apache/flink/pull/9735#issuecomment-533554096 ## CI report: * 51167d9aaf8082150738dc5bd8b9e2319dd01570 : SUCCESS [Bu

[GitHub] [flink] 1u0 commented on a change in pull request #9727: [FLINK-14145] Fix getLatestCheckpoint(true) returns wrong checkpoint

2019-09-20 Thread GitBox
1u0 commented on a change in pull request #9727: [FLINK-14145] Fix getLatestCheckpoint(true) returns wrong checkpoint URL: https://github.com/apache/flink/pull/9727#discussion_r326659911 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpoi

[GitHub] [flink] flinkbot edited a comment on issue #9727: [FLINK-14145] Fix getLatestCheckpoint(true) returns wrong checkpoint

2019-09-20 Thread GitBox
flinkbot edited a comment on issue #9727: [FLINK-14145] Fix getLatestCheckpoint(true) returns wrong checkpoint URL: https://github.com/apache/flink/pull/9727#issuecomment-533484572 ## CI report: * 31a78ba191c36561f073b0b5a0a2c1b6aa2d18a0 : SUCCESS [Build](https://travis-ci.com/f

[jira] [Commented] (FLINK-14123) Change taskmanager.memory.fraction default value to 0.6

2019-09-20 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934441#comment-16934441 ] Stephan Ewen commented on FLINK-14123: -- Would the behavior be the same when using G

[GitHub] [flink] gyfora commented on issue #9727: [FLINK-14145] Fix getLatestCheckpoint(true) returns wrong checkpoint

2019-09-20 Thread GitBox
gyfora commented on issue #9727: [FLINK-14145] Fix getLatestCheckpoint(true) returns wrong checkpoint URL: https://github.com/apache/flink/pull/9727#issuecomment-533572489 @TisonKun @1u0 I pushed a new commit that addresses the comments + adds more tests --

[GitHub] [flink] flinkbot edited a comment on issue #9734: [FLINK-14155][ml] Add a wrapper class of a JSON library to provide the unified json format.

2019-09-20 Thread GitBox
flinkbot edited a comment on issue #9734: [FLINK-14155][ml] Add a wrapper class of a JSON library to provide the unified json format. URL: https://github.com/apache/flink/pull/9734#issuecomment-533547640 ## CI report: * d0eb5e2b5a8f664a1de56dbe0ea3aa592452b7c2 : SUCCESS [Build](

[GitHub] [flink] flinkbot edited a comment on issue #9736: [FLINK-14157] Disable StreamingFileSink e2e test for java 11

2019-09-20 Thread GitBox
flinkbot edited a comment on issue #9736: [FLINK-14157] Disable StreamingFileSink e2e test for java 11 URL: https://github.com/apache/flink/pull/9736#issuecomment-533561281 ## CI report: * c8f2280889a4f076dc56329912b7890c8f828dd7 : PENDING [Build](https://travis-ci.com/flink-ci/

[GitHub] [flink] flinkbot edited a comment on issue #9733: [FLINK-14154][ml] Add the class for multivariate Gaussian Distribution.

2019-09-20 Thread GitBox
flinkbot edited a comment on issue #9733: [FLINK-14154][ml] Add the class for multivariate Gaussian Distribution. URL: https://github.com/apache/flink/pull/9733#issuecomment-533547601 ## CI report: * ea3d0cd6da22ebd2846bf0f3a2fa1d9f21964675 : SUCCESS [Build](https://travis-ci.co

[GitHub] [flink] zhuzhurk commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-20 Thread GitBox
zhuzhurk commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#discussion_r326644539 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java

[jira] [Closed] (FLINK-14096) Merge NewClusterClient into ClusterClient

2019-09-20 Thread tison (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] tison closed FLINK-14096. - Resolution: Resolved master via 1c20b8397299b17279e30ed4dca1f9efe6b8d9ec > Merge NewClusterClient into ClusterC

[GitHub] [flink] kl0u commented on issue #9701: [FLINK-14096][client] Merge NewClusterClient into ClusterClient

2019-09-20 Thread GitBox
kl0u commented on issue #9701: [FLINK-14096][client] Merge NewClusterClient into ClusterClient URL: https://github.com/apache/flink/pull/9701#issuecomment-533562510 Thanks @TisonKun ! This is an automated message from the Apa

[GitHub] [flink] TisonKun merged pull request #9701: [FLINK-14096][client] Merge NewClusterClient into ClusterClient

2019-09-20 Thread GitBox
TisonKun merged pull request #9701: [FLINK-14096][client] Merge NewClusterClient into ClusterClient URL: https://github.com/apache/flink/pull/9701 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [flink] kl0u closed pull request #9695: [FLINK-13748][S3][build] Fix jaxb relocation for S3.

2019-09-20 Thread GitBox
kl0u closed pull request #9695: [FLINK-13748][S3][build] Fix jaxb relocation for S3. URL: https://github.com/apache/flink/pull/9695 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] flinkbot edited a comment on issue #9735: [FLINK-14156][runtime] Submit timer trigger letters to task's mailbox with operator's precedence

2019-09-20 Thread GitBox
flinkbot edited a comment on issue #9735: [FLINK-14156][runtime] Submit timer trigger letters to task's mailbox with operator's precedence URL: https://github.com/apache/flink/pull/9735#issuecomment-533554096 ## CI report: * 51167d9aaf8082150738dc5bd8b9e2319dd01570 : PENDING [Bu

[GitHub] [flink] flinkbot commented on issue #9736: [FLINK-14157] Disable StreamingFileSink e2e test for java 11

2019-09-20 Thread GitBox
flinkbot commented on issue #9736: [FLINK-14157] Disable StreamingFileSink e2e test for java 11 URL: https://github.com/apache/flink/pull/9736#issuecomment-533561281 ## CI report: * c8f2280889a4f076dc56329912b7890c8f828dd7 : UNKNOWN --

[GitHub] [flink] 1u0 commented on a change in pull request #9717: [FLINK-14044] [runtime] Reducing synchronization in AsyncWaitOperator

2019-09-20 Thread GitBox
1u0 commented on a change in pull request #9717: [FLINK-14044] [runtime] Reducing synchronization in AsyncWaitOperator URL: https://github.com/apache/flink/pull/9717#discussion_r326635582 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/asyn

[GitHub] [flink] TisonKun commented on issue #9701: [FLINK-14096][client] Merge NewClusterClient into ClusterClient

2019-09-20 Thread GitBox
TisonKun commented on issue #9701: [FLINK-14096][client] Merge NewClusterClient into ClusterClient URL: https://github.com/apache/flink/pull/9701#issuecomment-533559645 Thanks for your explanation @kl0u. Then I will try to merge this pull request myself :-) ---

[jira] [Commented] (FLINK-14140) The Flink Logo Displayed in Flink Python Shell is Broken

2019-09-20 Thread Hequn Cheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934409#comment-16934409 ] Hequn Cheng commented on FLINK-14140: - [~zhongwei] Thanks a lot for the checking. Th

[GitHub] [flink] hequn8128 commented on issue #9725: [FLINK-14140][python] Fix the broken flink logo in flink python shell.

2019-09-20 Thread GitBox
hequn8128 commented on issue #9725: [FLINK-14140][python] Fix the broken flink logo in flink python shell. URL: https://github.com/apache/flink/pull/9725#issuecomment-533558849 @WeiZhong94 Thanks a lot for the fixing. LGTM. Merging...

[GitHub] [flink] pnowojski edited a comment on issue #9706: [FLINK-14118][runtime]Reduce the unnecessary flushing when there is no data available for flush.

2019-09-20 Thread GitBox
pnowojski edited a comment on issue #9706: [FLINK-14118][runtime]Reduce the unnecessary flushing when there is no data available for flush. URL: https://github.com/apache/flink/pull/9706#issuecomment-533557963 Could you either show that this change improves some existing benchmarks or add

[GitHub] [flink] pnowojski commented on a change in pull request #9706: [FLINK-14118][runtime]Reduce the unnecessary flushing when there is no data available for flush.

2019-09-20 Thread GitBox
pnowojski commented on a change in pull request #9706: [FLINK-14118][runtime]Reduce the unnecessary flushing when there is no data available for flush. URL: https://github.com/apache/flink/pull/9706#discussion_r326623064 ## File path: flink-runtime/src/main/java/org/apache/flink/r

[GitHub] [flink] pnowojski commented on issue #9706: [FLINK-14118][runtime]Reduce the unnecessary flushing when there is no data available for flush.

2019-09-20 Thread GitBox
pnowojski commented on issue #9706: [FLINK-14118][runtime]Reduce the unnecessary flushing when there is no data available for flush. URL: https://github.com/apache/flink/pull/9706#issuecomment-533557963 Could you provide at least results of `networkThroughput` benchmark with `1000,1ms` par

[GitHub] [flink] flinkbot commented on issue #9736: [FLINK-14157] Disable StreamingFileSink e2e test for java 11

2019-09-20 Thread GitBox
flinkbot commented on issue #9736: [FLINK-14157] Disable StreamingFileSink e2e test for java 11 URL: https://github.com/apache/flink/pull/9736#issuecomment-533557856 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pu

[jira] [Updated] (FLINK-14157) Temporarily remove S3 StreamingFileSink end-to-end test

2019-09-20 Thread Kostas Kloudas (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas updated FLINK-14157: --- Description: This issue temporarily disables the failing test for Java 11 so that we can hav

[GitHub] [flink] flinkbot edited a comment on issue #9717: [FLINK-14044] [runtime] Reducing synchronization in AsyncWaitOperator

2019-09-20 Thread GitBox
flinkbot edited a comment on issue #9717: [FLINK-14044] [runtime] Reducing synchronization in AsyncWaitOperator URL: https://github.com/apache/flink/pull/9717#issuecomment-533068819 ## CI report: * 9cfda801891969ac460f45ea639d636b519f22db : FAILURE [Build](https://travis-ci.com/

[GitHub] [flink] gyfora edited a comment on issue #9727: [FLINK-14145] Fix getLatestCheckpoint(true) returns wrong checkpoint

2019-09-20 Thread GitBox
gyfora edited a comment on issue #9727: [FLINK-14145] Fix getLatestCheckpoint(true) returns wrong checkpoint URL: https://github.com/apache/flink/pull/9727#issuecomment-533556876 Sure I can probably clean this up a bit. I wanted to the minimal change that makes this correct so I added the

[jira] [Updated] (FLINK-14157) Temporarily remove S3 StreamingFileSink end-to-end test

2019-09-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-14157: --- Labels: pull-request-available (was: ) > Temporarily remove S3 StreamingFileSink end-to-end

[GitHub] [flink] gyfora commented on issue #9727: [FLINK-14145] Fix getLatestCheckpoint(true) returns wrong checkpoint

2019-09-20 Thread GitBox
gyfora commented on issue #9727: [FLINK-14145] Fix getLatestCheckpoint(true) returns wrong checkpoint URL: https://github.com/apache/flink/pull/9727#issuecomment-533556876 Sure I can probably clean this up if a bit. I wanted to the minimal change that makes this correct so I added the expl

[GitHub] [flink] kl0u opened a new pull request #9736: [FLINK-14157] Disable StreamingFileSink e2e test for java 11

2019-09-20 Thread GitBox
kl0u opened a new pull request #9736: [FLINK-14157] Disable StreamingFileSink e2e test for java 11 URL: https://github.com/apache/flink/pull/9736 ## What is the purpose of the change This PR disables the `StreamingFileSink` S3 test for java 11 and removes the `jaxb` relocations for

[GitHub] [flink] flinkbot edited a comment on issue #9733: [FLINK-14154][ml] Add the class for multivariate Gaussian Distribution.

2019-09-20 Thread GitBox
flinkbot edited a comment on issue #9733: [FLINK-14154][ml] Add the class for multivariate Gaussian Distribution. URL: https://github.com/apache/flink/pull/9733#issuecomment-533547601 ## CI report: * ea3d0cd6da22ebd2846bf0f3a2fa1d9f21964675 : PENDING [Build](https://travis-ci.co

[GitHub] [flink] flinkbot commented on issue #9735: [FLINK-14156][runtime] Submit timer trigger letters to task's mailbox with operator's precedence

2019-09-20 Thread GitBox
flinkbot commented on issue #9735: [FLINK-14156][runtime] Submit timer trigger letters to task's mailbox with operator's precedence URL: https://github.com/apache/flink/pull/9735#issuecomment-533554096 ## CI report: * 51167d9aaf8082150738dc5bd8b9e2319dd01570 : UNKNOWN --

[GitHub] [flink] flinkbot edited a comment on issue #9734: [FLINK-14155][ml] Add a wrapper class of a JSON library to provide the unified json format.

2019-09-20 Thread GitBox
flinkbot edited a comment on issue #9734: [FLINK-14155][ml] Add a wrapper class of a JSON library to provide the unified json format. URL: https://github.com/apache/flink/pull/9734#issuecomment-533547640 ## CI report: * d0eb5e2b5a8f664a1de56dbe0ea3aa592452b7c2 : PENDING [Build](

[GitHub] [flink] flinkbot edited a comment on issue #9730: [FLINK-14151][ml] Add class for DocHashIDFVectorizerModelMapper.

2019-09-20 Thread GitBox
flinkbot edited a comment on issue #9730: [FLINK-14151][ml] Add class for DocHashIDFVectorizerModelMapper. URL: https://github.com/apache/flink/pull/9730#issuecomment-533540803 ## CI report: * 67cf93e4ddd84ac53a64ac2e27950eda8fb1f1b2 : FAILURE [Build](https://travis-ci.com/flink

[GitHub] [flink] flinkbot edited a comment on issue #9731: [FLINK-14152][ml] Add class for DocCountVectorizerMapper.

2019-09-20 Thread GitBox
flinkbot edited a comment on issue #9731: [FLINK-14152][ml] Add class for DocCountVectorizerMapper. URL: https://github.com/apache/flink/pull/9731#issuecomment-533540895 ## CI report: * 3ae6c348886b5e395e6701407e5667d682e9bdde : FAILURE [Build](https://travis-ci.com/flink-ci/fli

[GitHub] [flink] hequn8128 commented on a change in pull request #9707: [FLINK-14015][python] Introduces PythonScalarFunctionOperator to execute Python user-defined functions

2019-09-20 Thread GitBox
hequn8128 commented on a change in pull request #9707: [FLINK-14015][python] Introduces PythonScalarFunctionOperator to execute Python user-defined functions URL: https://github.com/apache/flink/pull/9707#discussion_r326549641 ## File path: flink-python/src/main/java/org/apache/fli

[jira] [Commented] (FLINK-14118) Reduce the unnecessary flushing when there is no data available for flush

2019-09-20 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934395#comment-16934395 ] Piotr Nowojski commented on FLINK-14118: As I wrote in the PR, I would be afraid

  1   2   3   4   >