[GitHub] [flink] JingsongLi commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects

2019-10-28 Thread GitBox
JingsongLi commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects URL: https://github.com/apache/flink/pull/9971#discussion_r339436930 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/d

[jira] [Created] (FLINK-14543) Support partition for temporary table

2019-10-28 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-14543: Summary: Support partition for temporary table Key: FLINK-14543 URL: https://issues.apache.org/jira/browse/FLINK-14543 Project: Flink Issue Type: Sub-task

[GitHub] [flink] dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects

2019-10-28 Thread GitBox
dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects URL: https://github.com/apache/flink/pull/9971#discussion_r339436274 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api

[jira] [Comment Edited] (FLINK-14539) Unique key metadata should be ketp when using concat or concat_ws in some cases

2019-10-28 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16960843#comment-16960843 ] Jark Wu edited comment on FLINK-14539 at 10/28/19 8:01 AM: --- Hi

[jira] [Commented] (FLINK-14539) Unique key metadata should be ketp when using concat or concat_ws in some cases

2019-10-28 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16960843#comment-16960843 ] Jark Wu commented on FLINK-14539: - Hi [~KevinZwx], I think RexBiVisitor is fine. Some

[GitHub] [flink] flinkbot commented on issue #10011: [FLINK-14267][table] Introduce RowCsvOutputFormat to new CSV module

2019-10-28 Thread GitBox
flinkbot commented on issue #10011: [FLINK-14267][table] Introduce RowCsvOutputFormat to new CSV module URL: https://github.com/apache/flink/pull/10011#issuecomment-546832997 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to revie

[GitHub] [flink] pnowojski commented on issue #9853: [FLINK-13904][checkpointing] Avoid competition of checkpoint triggering

2019-10-28 Thread GitBox
pnowojski commented on issue #9853: [FLINK-13904][checkpointing] Avoid competition of checkpoint triggering URL: https://github.com/apache/flink/pull/9853#issuecomment-546832298 > The order of commit history on this Github PR (at-least in my Chrome) is not same with my private branch

[jira] [Updated] (FLINK-14267) Introduce RowCsvOutputFormat to new CSV module

2019-10-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-14267: --- Labels: pull-request-available (was: ) > Introduce RowCsvOutputFormat to new CSV module > -

[GitHub] [flink] JingsongLi opened a new pull request #10011: [FLINK-14267][table] Introduce RowCsvOutputFormat to new CSV module

2019-10-28 Thread GitBox
JingsongLi opened a new pull request #10011: [FLINK-14267][table] Introduce RowCsvOutputFormat to new CSV module URL: https://github.com/apache/flink/pull/10011 # What is the purpose of the change Now, we have an old CSV, but that is not standard CSV support. we should support the R

[GitHub] [flink] dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects

2019-10-28 Thread GitBox
dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects URL: https://github.com/apache/flink/pull/9971#discussion_r339425618 ## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/tabl

[GitHub] [flink] dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects

2019-10-28 Thread GitBox
dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects URL: https://github.com/apache/flink/pull/9971#discussion_r339431711 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/cat

[GitHub] [flink] dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects

2019-10-28 Thread GitBox
dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects URL: https://github.com/apache/flink/pull/9971#discussion_r339422940 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/del

[GitHub] [flink] flinkbot edited a comment on issue #9876: [FLINK-14134][table] Introduce LimitableTableSource for optimizing limit

2019-10-28 Thread GitBox
flinkbot edited a comment on issue #9876: [FLINK-14134][table] Introduce LimitableTableSource for optimizing limit URL: https://github.com/apache/flink/pull/9876#issuecomment-540462303 ## CI report: * 3eca02d54759452fdc285687c7aedbf2199a7b46 : FAILURE [Build](https://travis-ci.c

[GitHub] [flink] flinkbot edited a comment on issue #9864: [FLINK-14254][table] Introduce FileSystemOutputFormat for batch

2019-10-28 Thread GitBox
flinkbot edited a comment on issue #9864: [FLINK-14254][table] Introduce FileSystemOutputFormat for batch URL: https://github.com/apache/flink/pull/9864#issuecomment-539910284 ## CI report: * e66114b1aa73a82b4c6bcf5c3a16baedb598f8c3 : FAILURE [Build](https://travis-ci.com/flink-

[GitHub] [flink] dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects

2019-10-28 Thread GitBox
dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects URL: https://github.com/apache/flink/pull/9971#discussion_r339431711 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/cat

[GitHub] [flink] flinkbot edited a comment on issue #10001: [FLINK-14535][table-planner-blink] Fix distinct key type for DecimalT…

2019-10-28 Thread GitBox
flinkbot edited a comment on issue #10001: [FLINK-14535][table-planner-blink] Fix distinct key type for DecimalT… URL: https://github.com/apache/flink/pull/10001#issuecomment-546558980 ## CI report: * 74748e2c09f1b2b0b9bfb3c1850cd71696d30df8 : FAILURE [Build](https://travis-ci.c

[GitHub] [flink] flinkbot edited a comment on issue #9995: [FLINK-14526][hive] Support Hive version 1.1.0 and 1.1.1

2019-10-28 Thread GitBox
flinkbot edited a comment on issue #9995: [FLINK-14526][hive] Support Hive version 1.1.0 and 1.1.1 URL: https://github.com/apache/flink/pull/9995#issuecomment-546323476 ## CI report: * 5f0728f214a49413f94ef838a9e40dda023ebb8b : SUCCESS [Build](https://travis-ci.com/flink-ci/flin

[GitHub] [flink] dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects

2019-10-28 Thread GitBox
dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects URL: https://github.com/apache/flink/pull/9971#discussion_r339430273 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/des

[GitHub] [flink] flinkbot edited a comment on issue #9733: [FLINK-14154][ml] Add the class for multivariate Gaussian Distribution.

2019-10-28 Thread GitBox
flinkbot edited a comment on issue #9733: [FLINK-14154][ml] Add the class for multivariate Gaussian Distribution. URL: https://github.com/apache/flink/pull/9733#issuecomment-533547601 ## CI report: * ea3d0cd6da22ebd2846bf0f3a2fa1d9f21964675 : SUCCESS [Build](https://travis-ci.co

[GitHub] [flink] pnowojski commented on a change in pull request #9912: [FLINK-14370][kafka][test-stability] Fix the cascading failure in kaProducerTestBase.

2019-10-28 Thread GitBox
pnowojski commented on a change in pull request #9912: [FLINK-14370][kafka][test-stability] Fix the cascading failure in kaProducerTestBase. URL: https://github.com/apache/flink/pull/9912#discussion_r339430003 ## File path: flink-connectors/flink-connector-kafka-base/src/test/java

[GitHub] [flink] gyfora commented on a change in pull request #10010: [FLINK-10435][yarn]Client sporadically hangs after Ctrl + C

2019-10-28 Thread GitBox
gyfora commented on a change in pull request #10010: [FLINK-10435][yarn]Client sporadically hangs after Ctrl + C URL: https://github.com/apache/flink/pull/10010#discussion_r339429351 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java ##

[GitHub] [flink] gyfora commented on a change in pull request #10010: [FLINK-10435][yarn]Client sporadically hangs after Ctrl + C

2019-10-28 Thread GitBox
gyfora commented on a change in pull request #10010: [FLINK-10435][yarn]Client sporadically hangs after Ctrl + C URL: https://github.com/apache/flink/pull/10010#discussion_r339429351 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java ##

[GitHub] [flink] dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects

2019-10-28 Thread GitBox
dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects URL: https://github.com/apache/flink/pull/9971#discussion_r339427857 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/des

[GitHub] [flink] dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects

2019-10-28 Thread GitBox
dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects URL: https://github.com/apache/flink/pull/9971#discussion_r339427857 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/des

[GitHub] [flink] dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects

2019-10-28 Thread GitBox
dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects URL: https://github.com/apache/flink/pull/9971#discussion_r339427016 ## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/tabl

[GitHub] [flink] dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects

2019-10-28 Thread GitBox
dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects URL: https://github.com/apache/flink/pull/9971#discussion_r339426445 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/cat

[GitHub] [flink] dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects

2019-10-28 Thread GitBox
dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects URL: https://github.com/apache/flink/pull/9971#discussion_r339426468 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/cat

[GitHub] [flink] dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects

2019-10-28 Thread GitBox
dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects URL: https://github.com/apache/flink/pull/9971#discussion_r339426086 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/cat

[GitHub] [flink] docete commented on issue #10001: [FLINK-14535][table-planner-blink] Fix distinct key type for DecimalT…

2019-10-28 Thread GitBox
docete commented on issue #10001: [FLINK-14535][table-planner-blink] Fix distinct key type for DecimalT… URL: https://github.com/apache/flink/pull/10001#issuecomment-546824345 @wuchong @JingsongLi Thanks for your review. Please have another look. ---

[GitHub] [flink] dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects

2019-10-28 Thread GitBox
dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects URL: https://github.com/apache/flink/pull/9971#discussion_r339425618 ## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/tabl

[GitHub] [flink] wuchong commented on a change in pull request #9976: [FLINK-14493][core] Introduce data types to ConfigOptions.

2019-10-28 Thread GitBox
wuchong commented on a change in pull request #9976: [FLINK-14493][core] Introduce data types to ConfigOptions. URL: https://github.com/apache/flink/pull/9976#discussion_r339425139 ## File path: flink-core/src/main/java/org/apache/flink/configuration/Configuration.java ##

[GitHub] [flink] wuchong commented on a change in pull request #9976: [FLINK-14493][core] Introduce data types to ConfigOptions.

2019-10-28 Thread GitBox
wuchong commented on a change in pull request #9976: [FLINK-14493][core] Introduce data types to ConfigOptions. URL: https://github.com/apache/flink/pull/9976#discussion_r339425139 ## File path: flink-core/src/main/java/org/apache/flink/configuration/Configuration.java ##

[GitHub] [flink] dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects

2019-10-28 Thread GitBox
dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects URL: https://github.com/apache/flink/pull/9971#discussion_r339425177 ## File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/ta

[GitHub] [flink] lirui-apache commented on issue #9995: [FLINK-14526][hive] Support Hive version 1.1.0 and 1.1.1

2019-10-28 Thread GitBox
lirui-apache commented on issue #9995: [FLINK-14526][hive] Support Hive version 1.1.0 and 1.1.1 URL: https://github.com/apache/flink/pull/9995#issuecomment-546823192 PR updated to address comments. Also verified tests pass for all our profiles. @xuefuz @bowenli86 please take a look. Tha

[GitHub] [flink] dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects

2019-10-28 Thread GitBox
dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects URL: https://github.com/apache/flink/pull/9971#discussion_r339424993 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/cat

[GitHub] [flink] flinkbot edited a comment on issue #9733: [FLINK-14154][ml] Add the class for multivariate Gaussian Distribution.

2019-10-28 Thread GitBox
flinkbot edited a comment on issue #9733: [FLINK-14154][ml] Add the class for multivariate Gaussian Distribution. URL: https://github.com/apache/flink/pull/9733#issuecomment-533547601 ## CI report: * ea3d0cd6da22ebd2846bf0f3a2fa1d9f21964675 : SUCCESS [Build](https://travis-ci.co

[GitHub] [flink] dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects

2019-10-28 Thread GitBox
dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects URL: https://github.com/apache/flink/pull/9971#discussion_r339423233 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/tab

[GitHub] [flink] dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects

2019-10-28 Thread GitBox
dawidwys commented on a change in pull request #9971: [FLINK-14490][table] Add methods for interacting with temporary objects URL: https://github.com/apache/flink/pull/9971#discussion_r339422940 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/del

[jira] [Created] (FLINK-14542) YarnConfiguration initialization problem

2019-10-28 Thread lisen (Jira)
lisen created FLINK-14542: - Summary: YarnConfiguration initialization problem Key: FLINK-14542 URL: https://issues.apache.org/jira/browse/FLINK-14542 Project: Flink Issue Type: Bug Componen

[jira] [Commented] (FLINK-14525) buffer pool is destroyed

2019-10-28 Thread zhijiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16960815#comment-16960815 ] zhijiang commented on FLINK-14525: -- The above stack trace is not helpful for tracing th

[GitHub] [flink] xuyang1706 commented on issue #9733: [FLINK-14154][ml] Add the class for multivariate Gaussian Distribution.

2019-10-28 Thread GitBox
xuyang1706 commented on issue #9733: [FLINK-14154][ml] Add the class for multivariate Gaussian Distribution. URL: https://github.com/apache/flink/pull/9733#issuecomment-546818317 > Thanks for the contribution @xuyang1706 overall the approach looks good to me. I have some questions/comments

[GitHub] [flink] xuyang1706 commented on a change in pull request #9733: [FLINK-14154][ml] Add the class for multivariate Gaussian Distribution.

2019-10-28 Thread GitBox
xuyang1706 commented on a change in pull request #9733: [FLINK-14154][ml] Add the class for multivariate Gaussian Distribution. URL: https://github.com/apache/flink/pull/9733#discussion_r339420618 ## File path: flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/s

[GitHub] [flink] xuyang1706 commented on a change in pull request #9733: [FLINK-14154][ml] Add the class for multivariate Gaussian Distribution.

2019-10-28 Thread GitBox
xuyang1706 commented on a change in pull request #9733: [FLINK-14154][ml] Add the class for multivariate Gaussian Distribution. URL: https://github.com/apache/flink/pull/9733#discussion_r339420471 ## File path: flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/s

[GitHub] [flink] xuyang1706 commented on a change in pull request #9733: [FLINK-14154][ml] Add the class for multivariate Gaussian Distribution.

2019-10-28 Thread GitBox
xuyang1706 commented on a change in pull request #9733: [FLINK-14154][ml] Add the class for multivariate Gaussian Distribution. URL: https://github.com/apache/flink/pull/9733#discussion_r339420214 ## File path: flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/s

[GitHub] [flink] xuyang1706 commented on a change in pull request #9733: [FLINK-14154][ml] Add the class for multivariate Gaussian Distribution.

2019-10-28 Thread GitBox
xuyang1706 commented on a change in pull request #9733: [FLINK-14154][ml] Add the class for multivariate Gaussian Distribution. URL: https://github.com/apache/flink/pull/9733#discussion_r339420287 ## File path: flink-ml-parent/flink-ml-lib/src/test/java/org/apache/flink/ml/common/s

<    1   2   3   4