[GitHub] [flink] becketqin commented on a change in pull request #12234: [FLINK-16986][coordination] Provide exactly-once guaranteed around checkpoints and operator event sending

2020-05-29 Thread GitBox
becketqin commented on a change in pull request #12234: URL: https://github.com/apache/flink/pull/12234#discussion_r432805261 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/OperatorCoordinatorHolder.java ## @@ -99,29 +187,110 @@

[jira] [Commented] (FLINK-17091) AvroRow(De)SerializationSchema doesn't support new Timestamp conversion classes

2020-05-29 Thread Paul Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120097#comment-17120097 ] Paul Lin commented on FLINK-17091: -- [~jark] I checked AvroRowDataDeserializationSchema, and yes, the

[jira] [Commented] (FLINK-16085) Translate "Joins in Continuous Queries" page of "Streaming Concepts" into Chinese

2020-05-29 Thread Authuir (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120086#comment-17120086 ] Authuir commented on FLINK-16085: - Hi [~jark], sorry for the delay. Actually it's nearing completion.

[GitHub] [flink] flinkbot edited a comment on pull request #12413: [FLINK-16198][core] Fix FileUtilsTest fails on MacOS

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12413: URL: https://github.com/apache/flink/pull/12413#issuecomment-636264630 ## CI report: * 9495b0c78ae7f16e5f5fa0c0e7baa265942b742f Azure:

[jira] [Commented] (FLINK-17895) Default value of rows-per-second in datagen can be limited

2020-05-29 Thread liufangliang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120077#comment-17120077 ] liufangliang commented on FLINK-17895: -- [~lzljs3620320] can you add a description? > Default value

[jira] [Commented] (FLINK-17736) Add flink CEP examples

2020-05-29 Thread liufangliang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120076#comment-17120076 ] liufangliang commented on FLINK-17736: -- [~lzljs3620320] Can you add a description? > Add flink CEP

[GitHub] [flink] flinkbot commented on pull request #12413: [FLINK-16198][core] Fix FileUtilsTest fails on MacOS

2020-05-29 Thread GitBox
flinkbot commented on pull request #12413: URL: https://github.com/apache/flink/pull/12413#issuecomment-636264630 ## CI report: * 9495b0c78ae7f16e5f5fa0c0e7baa265942b742f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[jira] [Created] (FLINK-18039) Change SourceCoordinator to handle resetToCheckpoint() call after started.

2020-05-29 Thread Jiangjie Qin (Jira)
Jiangjie Qin created FLINK-18039: Summary: Change SourceCoordinator to handle resetToCheckpoint() call after started. Key: FLINK-18039 URL: https://issues.apache.org/jira/browse/FLINK-18039 Project:

[GitHub] [flink] flinkbot commented on pull request #12413: [FLINK-16198][core] Fix FileUtilsTest fails on MacOS

2020-05-29 Thread GitBox
flinkbot commented on pull request #12413: URL: https://github.com/apache/flink/pull/12413#issuecomment-636263706 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-16198) FileUtilsTest fails on Mac OS

2020-05-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-16198: --- Labels: pull-request-available starter (was: starter) > FileUtilsTest fails on Mac OS >

[GitHub] [flink] fishzhe opened a new pull request #12413: [FLINK-16198][core] Fix FileUtilsTest fails on MacOS

2020-05-29 Thread GitBox
fishzhe opened a new pull request #12413: URL: https://github.com/apache/flink/pull/12413 ## What is the purpose of the change Fix FileUtilsTest fails on MacOS ## Brief change log -*Fix concurrent delete failure on MacOS* -*Fix relative compression path

[jira] [Commented] (FLINK-18036) Chinese documentation build is broken

2020-05-29 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120005#comment-17120005 ] Jark Wu commented on FLINK-18036: - [~wuxuyang78], do you want to fix this one together? > Chinese

[GitHub] [flink] AHeise commented on a change in pull request #12353: [FLINK-17322][network] Fixes BroadcastRecordWriter overwriting memory segments on first finished BufferConsumer.

2020-05-29 Thread GitBox
AHeise commented on a change in pull request #12353: URL: https://github.com/apache/flink/pull/12353#discussion_r43276 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/BroadcastRecordWriter.java ## @@ -130,7 +132,7 @@ public

[jira] [Created] (FLINK-18038) StateBackendLoader logs application-defined state before it is fully configured

2020-05-29 Thread Steve Bairos (Jira)
Steve Bairos created FLINK-18038: Summary: StateBackendLoader logs application-defined state before it is fully configured Key: FLINK-18038 URL: https://issues.apache.org/jira/browse/FLINK-18038

[GitHub] [flink] flinkbot edited a comment on pull request #12285: [FLINK-17445][State Processor] Add Scala support for OperatorTransformation

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12285: URL: https://github.com/apache/flink/pull/12285#issuecomment-632360179 ## CI report: * a61851595a23f50e7a282e702bf28cdcabe3e3d8 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12380: [FLINK-17581][docs-zh] Update translation of S3 documentation

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12380: URL: https://github.com/apache/flink/pull/12380#issuecomment-635291205 ## CI report: * 823086d411e78ab2510834f96e7203d313026d9c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12234: [FLINK-16986][coordination] Provide exactly-once guaranteed around checkpoints and operator event sending

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12234: URL: https://github.com/apache/flink/pull/12234#issuecomment-630433269 ## CI report: * fe27eb7b98b31454c615e1ae2f07082825a10da3 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12401: [FLINK-16057] Optimize ContinuousFileReaderOperator

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12401: URL: https://github.com/apache/flink/pull/12401#issuecomment-635845764 ## CI report: * 3bde38fba011e5c786da8f072543b673a5b25eb0 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12234: [FLINK-16986][coordination] Provide exactly-once guaranteed around checkpoints and operator event sending

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12234: URL: https://github.com/apache/flink/pull/12234#issuecomment-630433269 ## CI report: * 90e782a60c9a9514716b2a2b501f133847b9dcc2 Azure:

[GitHub] [flink] StephanEwen commented on pull request #12234: [FLINK-16986][coordination] Provide exactly-once guaranteed around checkpoints and operator event sending

2020-05-29 Thread GitBox
StephanEwen commented on pull request #12234: URL: https://github.com/apache/flink/pull/12234#issuecomment-636172362 Updated the PR to address the issue raised by @becketqin This required a change in the `OperatorCoordinator` interface. To explain why, let's revisit the semantics

[GitHub] [flink] flinkbot edited a comment on pull request #12234: [FLINK-16986][coordination] Provide exactly-once guaranteed around checkpoints and operator event sending

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12234: URL: https://github.com/apache/flink/pull/12234#issuecomment-630433269 ## CI report: * 90e782a60c9a9514716b2a2b501f133847b9dcc2 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12412: [FLINK-18011] Make WatermarkStrategy/WatermarkStrategies more ergonomic

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12412: URL: https://github.com/apache/flink/pull/12412#issuecomment-636063842 ## CI report: * 55b61138a63ce9fde288910e00e533798c8cbaec Azure:

[GitHub] [flink] StephanEwen commented on a change in pull request #12234: [FLINK-16986][coordination] Provide exactly-once guaranteed around checkpoints and operator event sending

2020-05-29 Thread GitBox
StephanEwen commented on a change in pull request #12234: URL: https://github.com/apache/flink/pull/12234#discussion_r432706623 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/OperatorCoordinatorCheckpoints.java ## @@ -58,7 +58,17 @@

[GitHub] [flink] TengHu commented on a change in pull request #12297: [FLINK-12855] [streaming-java][window-assigners] Add functionality that staggers panes on partitions to distribute workload.

2020-05-29 Thread GitBox
TengHu commented on a change in pull request #12297: URL: https://github.com/apache/flink/pull/12297#discussion_r432696612 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/TumblingProcessingTimeWindows.java ## @@ -46,28

[GitHub] [flink] TengHu commented on a change in pull request #12297: [FLINK-12855] [streaming-java][window-assigners] Add functionality that staggers panes on partitions to distribute workload.

2020-05-29 Thread GitBox
TengHu commented on a change in pull request #12297: URL: https://github.com/apache/flink/pull/12297#discussion_r432696612 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/TumblingProcessingTimeWindows.java ## @@ -46,28

[jira] [Commented] (FLINK-17923) It will throw MemoryAllocationException if rocksdb statebackend and Python UDF are used in the same slot

2020-05-29 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119890#comment-17119890 ] Dian Fu commented on FLINK-17923: - We assume that the Python worker uses task off-heap memory in this

[jira] [Commented] (FLINK-17923) It will throw MemoryAllocationException if rocksdb statebackend and Python UDF are used in the same slot

2020-05-29 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119883#comment-17119883 ] Stephan Ewen commented on FLINK-17923: -- I think my suggestion from above is not a feasible for for

[jira] [Commented] (FLINK-17923) It will throw MemoryAllocationException if rocksdb statebackend and Python UDF are used in the same slot

2020-05-29 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119880#comment-17119880 ] Stephan Ewen commented on FLINK-17923: -- We could think about making the Python Processes the

[GitHub] [flink] flinkbot edited a comment on pull request #12285: [FLINK-17445][State Processor] Add Scala support for OperatorTransformation

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12285: URL: https://github.com/apache/flink/pull/12285#issuecomment-632360179 ## CI report: * 67e45d0cd91f2a0f3b7f233e9fb5006933ccad8b Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12285: [FLINK-17445][State Processor] Add Scala support for OperatorTransformation

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12285: URL: https://github.com/apache/flink/pull/12285#issuecomment-632360179 ## CI report: * 67e45d0cd91f2a0f3b7f233e9fb5006933ccad8b Azure:

[GitHub] [flink] carp84 commented on pull request #12368: [FLINK-15507][state backends] Activate local recovery by default (on release-1.11)

2020-05-29 Thread GitBox
carp84 commented on pull request #12368: URL: https://github.com/apache/flink/pull/12368#issuecomment-636120661 We've decided to postpone FLINK-15507 to 1.12.0 to have more thorough discussions, thus closing the PR directly (w/o merging).

[GitHub] [flink] carp84 closed pull request #12368: [FLINK-15507][state backends] Activate local recovery by default (on release-1.11)

2020-05-29 Thread GitBox
carp84 closed pull request #12368: URL: https://github.com/apache/flink/pull/12368 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (FLINK-15507) Activate local recovery for RocksDB backends by default

2020-05-29 Thread Yu Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Li updated FLINK-15507: -- Fix Version/s: (was: 1.11.0) 1.12.0 Priority: Critical (was: Blocker) Thanks

[GitHub] [flink] carp84 commented on pull request #12312: [FLINK-15507][state backends] Activate local recovery by default

2020-05-29 Thread GitBox
carp84 commented on pull request #12312: URL: https://github.com/apache/flink/pull/12312#issuecomment-636120242 We've decided to postpone FLINK-15507 to 1.12.0 to have more thorough discussions, thus won't merge the PR at the moment.

[GitHub] [flink] flinkbot edited a comment on pull request #12380: [FLINK-17581][docs-zh] Update translation of S3 documentation

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12380: URL: https://github.com/apache/flink/pull/12380#issuecomment-635291205 ## CI report: * 4bd1784410abe95638fafa4e1e46c086a6d59663 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12146: [FLINK-17968][hbase] Fix Hadoop Configuration is not properly serialized in HBaseRowInputFormat

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12146: URL: https://github.com/apache/flink/pull/12146#issuecomment-628508688 ## CI report: * 59820867eb46cdb2870ca6500ac93858923590f9 Azure:

[jira] [Commented] (FLINK-17800) RocksDB optimizeForPointLookup results in missing time windows

2020-05-29 Thread Yu Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119803#comment-17119803 ] Yu Li commented on FLINK-17800: --- Thanks for debugging and locating the root cause [~yunta]. >From the

[GitHub] [flink] flinkbot edited a comment on pull request #12380: [FLINK-17581][docs-zh] Update translation of S3 documentation

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12380: URL: https://github.com/apache/flink/pull/12380#issuecomment-635291205 ## CI report: * 4bd1784410abe95638fafa4e1e46c086a6d59663 Azure:

[GitHub] [flink] wydhcws commented on pull request #12380: [FLINK-17581][docs-zh] Update translation of S3 documentation

2020-05-29 Thread GitBox
wydhcws commented on pull request #12380: URL: https://github.com/apache/flink/pull/12380#issuecomment-636096206 Thanks for your patience and careful . I've fixed the problem. @klion26 This is an automated message

[GitHub] [flink] wydhcws commented on a change in pull request #12380: [FLINK-17581][docs-zh] Update translation of S3 documentation

2020-05-29 Thread GitBox
wydhcws commented on a change in pull request #12380: URL: https://github.com/apache/flink/pull/12380#discussion_r432635762 ## File path: docs/ops/filesystems/s3.zh.md ## @@ -58,11 +58,15 @@ env.setStateBackend(new FsStateBackend("s3:///")); Flink 提供两种文件系统用来与 S3

[GitHub] [flink] wydhcws commented on a change in pull request #12380: [FLINK-17581][docs-zh] Update translation of S3 documentation

2020-05-29 Thread GitBox
wydhcws commented on a change in pull request #12380: URL: https://github.com/apache/flink/pull/12380#discussion_r432635557 ## File path: docs/ops/filesystems/s3.zh.md ## @@ -58,11 +58,15 @@ env.setStateBackend(new FsStateBackend("s3:///")); Flink 提供两种文件系统用来与 S3

[GitHub] [flink] rkhachatryan commented on a change in pull request #12401: [FLINK-16057] Optimize ContinuousFileReaderOperator

2020-05-29 Thread GitBox
rkhachatryan commented on a change in pull request #12401: URL: https://github.com/apache/flink/pull/12401#discussion_r432618358 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/MailboxProcessor.java ## @@ -114,6 +114,7 @@

[GitHub] [flink] flinkbot edited a comment on pull request #12401: [FLINK-16057] Optimize ContinuousFileReaderOperator

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12401: URL: https://github.com/apache/flink/pull/12401#issuecomment-635845764 ## CI report: * 5ae178ffebe69903ebe8d09bdd8709c299c86dc0 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12411: [FLINK-18005][table] Implement type inference for CAST

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12411: URL: https://github.com/apache/flink/pull/12411#issuecomment-63596 ## CI report: * a09af4cc6d36cdc635ac9f216c23d5a81266118e Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12379: [FLINK-18001][table-planner] Add a new test base for evaluating functions

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12379: URL: https://github.com/apache/flink/pull/12379#issuecomment-635291122 ## CI report: * f9fe38e9d7bc846467f0d713a00b1fcf7d5321e0 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12412: [FLINK-18011] Make WatermarkStrategy/WatermarkStrategies more ergonomic

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12412: URL: https://github.com/apache/flink/pull/12412#issuecomment-636063842 ## CI report: * 55b61138a63ce9fde288910e00e533798c8cbaec Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12401: [FLINK-16057] Optimize ContinuousFileReaderOperator

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12401: URL: https://github.com/apache/flink/pull/12401#issuecomment-635845764 ## CI report: * 5ae178ffebe69903ebe8d09bdd8709c299c86dc0 Azure:

[GitHub] [flink] flinkbot commented on pull request #12412: [FLINK-18011] Make WatermarkStrategy/WatermarkStrategies more ergonomic

2020-05-29 Thread GitBox
flinkbot commented on pull request #12412: URL: https://github.com/apache/flink/pull/12412#issuecomment-636063842 ## CI report: * 55b61138a63ce9fde288910e00e533798c8cbaec UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[jira] [Created] (FLINK-18037) The doc of StreamTaskNetworkInput.java may has a redundant 'status'

2020-05-29 Thread ZhuShang (Jira)
ZhuShang created FLINK-18037: Summary: The doc of StreamTaskNetworkInput.java may has a redundant 'status' Key: FLINK-18037 URL: https://issues.apache.org/jira/browse/FLINK-18037 Project: Flink

[GitHub] [flink] walterddr commented on a change in pull request #11586: [FLINK-5552][runtime] make JMXServer static per JVM

2020-05-29 Thread GitBox
walterddr commented on a change in pull request #11586: URL: https://github.com/apache/flink/pull/11586#discussion_r432582640 ## File path: flink-core/src/main/java/org/apache/flink/configuration/JMXServerOptions.java ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache

[GitHub] [flink] walterddr commented on a change in pull request #11586: [FLINK-5552][runtime] make JMXServer static per JVM

2020-05-29 Thread GitBox
walterddr commented on a change in pull request #11586: URL: https://github.com/apache/flink/pull/11586#discussion_r432582640 ## File path: flink-core/src/main/java/org/apache/flink/configuration/JMXServerOptions.java ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache

[GitHub] [flink] walterddr commented on a change in pull request #11586: [FLINK-5552][runtime] make JMXServer static per JVM

2020-05-29 Thread GitBox
walterddr commented on a change in pull request #11586: URL: https://github.com/apache/flink/pull/11586#discussion_r432582640 ## File path: flink-core/src/main/java/org/apache/flink/configuration/JMXServerOptions.java ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache

[GitHub] [flink] walterddr commented on a change in pull request #11586: [FLINK-5552][runtime] make JMXServer static per JVM

2020-05-29 Thread GitBox
walterddr commented on a change in pull request #11586: URL: https://github.com/apache/flink/pull/11586#discussion_r432579859 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/management/JMXServer.java ## @@ -0,0 +1,239 @@ +/* + * Licensed to the Apache

[GitHub] [flink] zhijiangW commented on a change in pull request #12353: [FLINK-17322][network] Fixes BroadcastRecordWriter overwriting memory segments on first finished BufferConsumer.

2020-05-29 Thread GitBox
zhijiangW commented on a change in pull request #12353: URL: https://github.com/apache/flink/pull/12353#discussion_r432575584 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/BroadcastRecordWriter.java ## @@ -130,7 +132,7 @@ public

[GitHub] [flink] zhijiangW commented on a change in pull request #12353: [FLINK-17322][network] Fixes BroadcastRecordWriter overwriting memory segments on first finished BufferConsumer.

2020-05-29 Thread GitBox
zhijiangW commented on a change in pull request #12353: URL: https://github.com/apache/flink/pull/12353#discussion_r432575584 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/BroadcastRecordWriter.java ## @@ -130,7 +132,7 @@ public

[GitHub] [flink] flinkbot commented on pull request #12412: [FLINK-18011] Make WatermarkStrategy/WatermarkStrategies more ergonomic

2020-05-29 Thread GitBox
flinkbot commented on pull request #12412: URL: https://github.com/apache/flink/pull/12412#issuecomment-636047460 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-18011) Make WatermarkStrategy/WatermarkStrategies more ergonomic

2020-05-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-18011: --- Labels: pull-request-available (was: ) > Make WatermarkStrategy/WatermarkStrategies more

[GitHub] [flink] aljoscha commented on pull request #12412: [FLINK-18011] Make WatermarkStrategy/WatermarkStrategies more ergonomic

2020-05-29 Thread GitBox
aljoscha commented on pull request #12412: URL: https://github.com/apache/flink/pull/12412#issuecomment-636046671 By now I'm wondering wether we should make `WatermarkStrategy` `@PublicEvolving`. This is an automated

[GitHub] [flink] aljoscha opened a new pull request #12412: [FLINK-18011] Make WatermarkStrategy/WatermarkStrategies more ergonomic

2020-05-29 Thread GitBox
aljoscha opened a new pull request #12412: URL: https://github.com/apache/flink/pull/12412 ## What is the purpose of the change From the Jira issue: Currently, we have an interface `WatermarkStrategy`, which is a `TimestampAssignerSupplier` and `WatermarkGeneratorSupplier`. The

[GitHub] [flink] zhijiangW commented on a change in pull request #12353: [FLINK-17322][network] Fixes BroadcastRecordWriter overwriting memory segments on first finished BufferConsumer.

2020-05-29 Thread GitBox
zhijiangW commented on a change in pull request #12353: URL: https://github.com/apache/flink/pull/12353#discussion_r432575584 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/BroadcastRecordWriter.java ## @@ -130,7 +132,7 @@ public

[GitHub] [flink] flinkbot edited a comment on pull request #12379: [FLINK-18001][table-planner] Add a new test base for evaluating functions

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12379: URL: https://github.com/apache/flink/pull/12379#issuecomment-635291122 ## CI report: * 4735a8269768a6732018f9ca18ac7448defd6db8 Azure:

[GitHub] [flink] zhijiangW commented on a change in pull request #12353: [FLINK-17322][network] Fixes BroadcastRecordWriter overwriting memory segments on first finished BufferConsumer.

2020-05-29 Thread GitBox
zhijiangW commented on a change in pull request #12353: URL: https://github.com/apache/flink/pull/12353#discussion_r432575584 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/BroadcastRecordWriter.java ## @@ -130,7 +132,7 @@ public

[jira] [Commented] (FLINK-18036) Chinese documentation build is broken

2020-05-29 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119714#comment-17119714 ] Aljoscha Krettek commented on FLINK-18036: -- Yes, that's the same issue. > Chinese

[GitHub] [flink] flinkbot edited a comment on pull request #12379: [FLINK-18001][table-planner] Add a new test base for evaluating functions

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12379: URL: https://github.com/apache/flink/pull/12379#issuecomment-635291122 ## CI report: * 4735a8269768a6732018f9ca18ac7448defd6db8 Azure:

[GitHub] [flink] zhijiangW edited a comment on pull request #12406: [FLINK-17994][checkpointing] Fix the race condition between CheckpointBarrierUnaligner#processBarrier and #notifyBarrierReceived

2020-05-29 Thread GitBox
zhijiangW edited a comment on pull request #12406: URL: https://github.com/apache/flink/pull/12406#issuecomment-636036676 Thanks for the efficient review @pnowojski ! >As far as I understand it, it's not a full fix, as EndOfPartitionEvents or checkpoint barrier cancellation markers

[GitHub] [flink] flinkbot edited a comment on pull request #12406: [FLINK-17994][checkpointing] Fix the race condition between CheckpointBarrierUnaligner#processBarrier and #notifyBarrierReceived

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12406: URL: https://github.com/apache/flink/pull/12406#issuecomment-635907759 ## CI report: * bee02498f028f38676813dde3b99d318ace084aa Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12408: [FLINK-15547][hive] Add test for avro table

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12408: URL: https://github.com/apache/flink/pull/12408#issuecomment-635936224 ## CI report: * c66db1484851da00f3b54b1d8302b60053f97c88 Azure:

[GitHub] [flink] zhijiangW edited a comment on pull request #12406: [FLINK-17994][checkpointing] Fix the race condition between CheckpointBarrierUnaligner#processBarrier and #notifyBarrierReceived

2020-05-29 Thread GitBox
zhijiangW edited a comment on pull request #12406: URL: https://github.com/apache/flink/pull/12406#issuecomment-636036676 Thanks for the efficient review @pnowojski ! >As far as I understand it, it's not a full fix, as EndOfPartitionEvents or checkpoint barrier cancellation markers

[GitHub] [flink] zhijiangW commented on pull request #12406: [FLINK-17994][checkpointing] Fix the race condition between CheckpointBarrierUnaligner#processBarrier and #notifyBarrierReceived

2020-05-29 Thread GitBox
zhijiangW commented on pull request #12406: URL: https://github.com/apache/flink/pull/12406#issuecomment-636036676 >As far as I understand it, it's not a full fix, as EndOfPartitionEvents or checkpoint barrier cancellation markers can still cause the same race condition, and you want to

[jira] [Commented] (FLINK-17706) Clarify licensing situation for flink-benchmarks

2020-05-29 Thread Roman Grebennikov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119704#comment-17119704 ] Roman Grebennikov commented on FLINK-17706: --- I'm ok with licensing my contributions to the

[GitHub] [flink] zhijiangW commented on a change in pull request #12406: [FLINK-17994][checkpointing] Fix the race condition between CheckpointBarrierUnaligner#processBarrier and #notifyBarrierReceiv

2020-05-29 Thread GitBox
zhijiangW commented on a change in pull request #12406: URL: https://github.com/apache/flink/pull/12406#discussion_r432561333 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java ## @@ -164,33 +158,32 @@ public

[GitHub] [flink] zhijiangW commented on a change in pull request #12406: [FLINK-17994][checkpointing] Fix the race condition between CheckpointBarrierUnaligner#processBarrier and #notifyBarrierReceiv

2020-05-29 Thread GitBox
zhijiangW commented on a change in pull request #12406: URL: https://github.com/apache/flink/pull/12406#discussion_r432559532 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnalignerTest.java ## @@ -639,4 +673,79 @@

[jira] [Assigned] (FLINK-17918) Jobs with two input operators are loosing data with unaligned checkpoints

2020-05-29 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski reassigned FLINK-17918: -- Assignee: Arvid Heise (was: Yingjie Cao) > Jobs with two input operators are

[jira] [Closed] (FLINK-17842) Performance regression on 19.05.2020

2020-05-29 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-17842. -- Resolution: Fixed 2nd fixed merged to release-1.11 as acb16cbdc3 and to master as 955a683 >

[GitHub] [flink] pnowojski merged pull request #12407: [FLINK-17842][network] Remove NextRecordResponse to improve deserialisation performance

2020-05-29 Thread GitBox
pnowojski merged pull request #12407: URL: https://github.com/apache/flink/pull/12407 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] twalthr commented on pull request #12379: [FLINK-18001][table-planner] Add a new test base for evaluating functions

2020-05-29 Thread GitBox
twalthr commented on pull request #12379: URL: https://github.com/apache/flink/pull/12379#issuecomment-636015882 Thanks @dawidwys. I will check what I can do and merge this once I get a green build. This is an automated

[GitHub] [flink] flinkbot edited a comment on pull request #12407: [FLINK-17842][network] Remove NextRecordResponse to improve deserialisation performance

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12407: URL: https://github.com/apache/flink/pull/12407#issuecomment-635920790 ## CI report: * cc1b0b49d02982ca88dfea41393cbbf34748806b Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12409: [FLINK-18035][runtime] Use fixed thread pool

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12409: URL: https://github.com/apache/flink/pull/12409#issuecomment-635946066 ## CI report: * ab960b968d07be175fe6a94f130f4d1f0fd051b3 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12256: [FLINK-17018][runtime] Allocates slots in bulks for pipelined region scheduling

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12256: URL: https://github.com/apache/flink/pull/12256#issuecomment-631025695 ## CI report: * 8ba2a2eb65072f71c66055c3f86549a061eb1514 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12406: [FLINK-17994][checkpointing] Fix the race condition between CheckpointBarrierUnaligner#processBarrier and #notifyBarrierReceived

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12406: URL: https://github.com/apache/flink/pull/12406#issuecomment-635907759 ## CI report: * 67af5b88a2032e6515d41c26586f2fba88cbcd0e Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12381: [FLINK-17941][sql-client] Switching catalog or database doesn't work …

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12381: URL: https://github.com/apache/flink/pull/12381#issuecomment-635335584 ## CI report: * 007076ff616543b838b538001432546667c78be9 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12146: [FLINK-17968][hbase] Fix Hadoop Configuration is not properly serialized in HBaseRowInputFormat

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12146: URL: https://github.com/apache/flink/pull/12146#issuecomment-628508688 ## CI report: * 2e9f1a46dd294b87fc5577a36d1fdd634ac3c64e Azure:

[jira] [Comment Edited] (FLINK-17500) Deploy JobGraph from file in StandaloneClusterEntrypoint

2020-05-29 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119656#comment-17119656 ] Fabian Paul edited comment on FLINK-17500 at 5/29/20, 2:21 PM: --- Sorry for

[jira] [Comment Edited] (FLINK-17500) Deploy JobGraph from file in StandaloneClusterEntrypoint

2020-05-29 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119656#comment-17119656 ] Fabian Paul edited comment on FLINK-17500 at 5/29/20, 2:21 PM: --- Sorry for

[jira] [Commented] (FLINK-17500) Deploy JobGraph from file in StandaloneClusterEntrypoint

2020-05-29 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119656#comment-17119656 ] Fabian Paul commented on FLINK-17500: - Sorry for the late reply and obviously no progress from my

[GitHub] [flink] flinkbot edited a comment on pull request #12407: [FLINK-17842][network] Remove NextRecordResponse to improve deserialisation performance

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12407: URL: https://github.com/apache/flink/pull/12407#issuecomment-635920790 ## CI report: * cc1b0b49d02982ca88dfea41393cbbf34748806b Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12146: [FLINK-17968][hbase] Fix Hadoop Configuration is not properly serialized in HBaseRowInputFormat

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12146: URL: https://github.com/apache/flink/pull/12146#issuecomment-628508688 ## CI report: * 2e9f1a46dd294b87fc5577a36d1fdd634ac3c64e Azure:

[jira] [Commented] (FLINK-17961) Create an Elasticsearch source

2020-05-29 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119635#comment-17119635 ] Etienne Chauchot commented on FLINK-17961: -- Thanks Aljoscha for commenting. ES has data streams

[jira] [Commented] (FLINK-17853) JobGraph is not getting deleted after Job cancelation

2020-05-29 Thread Fritz Budiyanto (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119634#comment-17119634 ] Fritz Budiyanto commented on FLINK-17853: - Thanks. We will migrate to 1.10. Feel free to close

[GitHub] [flink] AHeise commented on a change in pull request #12353: [FLINK-17322][network] Fixes BroadcastRecordWriter overwriting memory segments on first finished BufferConsumer.

2020-05-29 Thread GitBox
AHeise commented on a change in pull request #12353: URL: https://github.com/apache/flink/pull/12353#discussion_r432502570 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/BroadcastRecordWriter.java ## @@ -130,7 +132,7 @@ public

[jira] [Updated] (FLINK-17952) Confusing exception was thrown when old planner and batch mode is used via EnvironmentSettings

2020-05-29 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-17952: Summary: Confusing exception was thrown when old planner and batch mode is used via EnvironmentSettings

[jira] [Closed] (FLINK-17952) Improve the error message when old planner and batch mode is used via EnvironmentSettings

2020-05-29 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu closed FLINK-17952. --- Resolution: Fixed Merged to: - master via be049121e861837485993e5d6756b7b0266959ee - release-1.11 via

[jira] [Commented] (FLINK-17968) Hadoop Configuration is not properly serialized in HBaseRowInputFormat

2020-05-29 Thread tartarus (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119622#comment-17119622 ] tartarus commented on FLINK-17968: -- I removed the logic of generating hbase-site.xml in the unit test,

[GitHub] [flink] Tartarus0zm commented on pull request #12146: [FLINK-17968][hbase] Fix Hadoop Configuration is not properly serialized in HBaseRowInputFormat

2020-05-29 Thread GitBox
Tartarus0zm commented on pull request #12146: URL: https://github.com/apache/flink/pull/12146#issuecomment-635982323 @wuchong @rmetzger I removed the logic of generating hbase-site.xml in the unit test, and must set Hbase configuration when initialize HbaseInputFormat . please take a look

[GitHub] [flink] flinkbot edited a comment on pull request #12402: Update state.zh.md

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12402: URL: https://github.com/apache/flink/pull/12402#issuecomment-635881017 ## CI report: * 6ce66868a5bb54a61083ed11703e33d9225229d1 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12405: [FLINK-16816][table sql/runtime] Add timestamp and date array test for DataFormatConverters.

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12405: URL: https://github.com/apache/flink/pull/12405#issuecomment-635889281 ## CI report: * aa0011aa6dbce3a0c6bdcafdba284d0bcb0d862c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12144: URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376 ## CI report: * d36b959fb16a91c15babda10dd884cbbdec58420 UNKNOWN * 35f180a59746b17b3b965254b8bcdcb21e75a3c5 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12410: [FLINK-13782][table-api] Implement type strategies for IF ELSE expression

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12410: URL: https://github.com/apache/flink/pull/12410#issuecomment-635946149 ## CI report: * 05965a6250f3873dfccc7e226ffb64d40d3a599d Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12403: [FLINK-18030][hive] Hive UDF doesn't accept empty string literal para…

2020-05-29 Thread GitBox
flinkbot edited a comment on pull request #12403: URL: https://github.com/apache/flink/pull/12403#issuecomment-635881099 ## CI report: * 0e667a3bd702288955808b79493a09244513d202 Azure:

[GitHub] [flink] dianfu closed pull request #12400: [FLINK-17952][python] Fix the bug that exception was thrown when creating BatchTableEnvironment via EnvironmentSettings with old planner.

2020-05-29 Thread GitBox
dianfu closed pull request #12400: URL: https://github.com/apache/flink/pull/12400 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

  1   2   3   4   >