[GitHub] [flink-web] morsapaes commented on pull request #364: Add blog post for Pandas support in PyFlink.

2020-08-04 Thread GitBox
morsapaes commented on pull request #364: URL: https://github.com/apache/flink-web/pull/364#issuecomment-668417608 Thanks, @dianfu ! 🎈 Just a reminder for the future to update the blogpost date (and, if possible, also the name of the file/images).

[GitHub] [flink] azagrebin commented on pull request #13028: [FLINK-18739] Implement MergingSharedSlotProfileRetriever

2020-08-04 Thread GitBox
azagrebin commented on pull request #13028: URL: https://github.com/apache/flink/pull/13028#issuecomment-668421378 Thanks for the review @zhuzhurk I have addressed the comments This is an automated message from the Apache

[GitHub] [flink] flinkbot edited a comment on pull request #12917: [FLINK-18355][tests] Simplify tests of SlotPoolImpl

2020-08-04 Thread GitBox
flinkbot edited a comment on pull request #12917: URL: https://github.com/apache/flink/pull/12917#issuecomment-659940433 ## CI report: * da7fb96fc00acda2a4c103f5f177efb9bd9be8be UNKNOWN * 217c88f0f382bf45143dcce82a089568528dad34 Azure: [FAILURE](https://dev.azure.com/apache-fl

[GitHub] [flink] flinkbot edited a comment on pull request #13028: [FLINK-18739] Implement MergingSharedSlotProfileRetriever

2020-08-04 Thread GitBox
flinkbot edited a comment on pull request #13028: URL: https://github.com/apache/flink/pull/13028#issuecomment-666235055 ## CI report: * eb0a8e585b2aba939c4a43ba409566f3df287848 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Updated] (FLINK-18548) Dimension table do not support computed column

2020-08-04 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-18548: --- Parent: FLINK-16824 Issue Type: Sub-task (was: Improvement) > Dimension table do not suppor

[jira] [Updated] (FLINK-15366) Improve FlinkCalcMergeRule to merge calc nodes better

2020-08-04 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-15366: --- Parent: FLINK-16824 Issue Type: Sub-task (was: Bug) > Improve FlinkCalcMergeRule to merge c

[GitHub] [flink] shuttie commented on pull request #12929: [FLINK-18631] [serialization] Serializer for scala sealed trait hierarchies

2020-08-04 Thread GitBox
shuttie commented on pull request #12929: URL: https://github.com/apache/flink/pull/12929#issuecomment-668430416 @rmetzger is there any chance that this PR can be reviewed? This is an automated message from the Apache Git Se

[GitHub] [flink-web] dianfu commented on pull request #364: Add blog post for Pandas support in PyFlink.

2020-08-04 Thread GitBox
dianfu commented on pull request #364: URL: https://github.com/apache/flink-web/pull/364#issuecomment-668433733 @morsapaes Thanks a lot for the kind reminder. Updated the blogpost date. This is an automated message from the A

[GitHub] [flink] flinkbot edited a comment on pull request #13028: [FLINK-18739] Implement MergingSharedSlotProfileRetriever

2020-08-04 Thread GitBox
flinkbot edited a comment on pull request #13028: URL: https://github.com/apache/flink/pull/13028#issuecomment-666235055 ## CI report: * 926fb3518b1b611b53901b4b9fcc834a0c0f9da1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] rmetzger commented on pull request #12929: [FLINK-18631] [serialization] Serializer for scala sealed trait hierarchies

2020-08-04 Thread GitBox
rmetzger commented on pull request #12929: URL: https://github.com/apache/flink/pull/12929#issuecomment-668435866 Sorry for the delay. I try to find somebody who can take a look. This is an automated message from the Apache G

[jira] [Updated] (FLINK-18808) Task-level numRecordsOut metric may be underestimated

2020-08-04 Thread ming li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ming li updated FLINK-18808: Description: At present, we only register task-level numRecordsOut metric by reusing operator output reco

[jira] [Commented] (FLINK-17001) Support LIKE clause in CREATE TABLE

2020-08-04 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170627#comment-17170627 ] Dian Fu commented on FLINK-17001: - [~dwysakowicz] It seems that this feature is already

[GitHub] [flink] pnowojski merged pull request #13045: [FLINK-18748][checkpointing] trigger unperiodic checkpoint immediately

2020-08-04 Thread GitBox
pnowojski merged pull request #13045: URL: https://github.com/apache/flink/pull/13045 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Commented] (FLINK-18748) Savepoint would be queued unexpected if pendingCheckpoints less than maxConcurrentCheckpoints

2020-08-04 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170632#comment-17170632 ] Piotr Nowojski commented on FLINK-18748: merged to master as e422d42e09^ and e42

[jira] [Created] (FLINK-18809) Update internal aggregate functions to new type system

2020-08-04 Thread Timo Walther (Jira)
Timo Walther created FLINK-18809: Summary: Update internal aggregate functions to new type system Key: FLINK-18809 URL: https://issues.apache.org/jira/browse/FLINK-18809 Project: Flink Issue

[GitHub] [flink] flinkbot edited a comment on pull request #12917: [FLINK-18355][tests] Simplify tests of SlotPoolImpl

2020-08-04 Thread GitBox
flinkbot edited a comment on pull request #12917: URL: https://github.com/apache/flink/pull/12917#issuecomment-659940433 ## CI report: * da7fb96fc00acda2a4c103f5f177efb9bd9be8be UNKNOWN * 217c88f0f382bf45143dcce82a089568528dad34 Azure: [FAILURE](https://dev.azure.com/apache-fl

[GitHub] [flink] flinkbot edited a comment on pull request #13009: [FLINK-18690][runtime] Implement LocalInputPreferredSlotSharingStrategy

2020-08-04 Thread GitBox
flinkbot edited a comment on pull request #13009: URL: https://github.com/apache/flink/pull/13009#issuecomment-665109698 ## CI report: * 557e982407c488191ade7cc66807662796b3a306 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Commented] (FLINK-15350) develop JDBC catalogs to connect to relational databases

2020-08-04 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170633#comment-17170633 ] Dian Fu commented on FLINK-15350: - [~phoenixjiangnan] It seems that this feature is alre

[GitHub] [flink] flinkbot edited a comment on pull request #13054: [FLINK-15803][table] Support DataViews in FLIP-65 aggregate functions

2020-08-04 Thread GitBox
flinkbot edited a comment on pull request #13054: URL: https://github.com/apache/flink/pull/13054#issuecomment-668030431 ## CI report: * abedb100f5f02dc3249f58f8fb06e6f16f7246fb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Commented] (FLINK-11890) Replace Table API string-based expressions by a Java DSL

2020-08-04 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-11890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170635#comment-17170635 ] Dian Fu commented on FLINK-11890: - [~dwysakowicz] It seems that the feature is already f

[jira] [Closed] (FLINK-18748) Savepoint would be queued unexpected if pendingCheckpoints less than maxConcurrentCheckpoints

2020-08-04 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-18748. -- Fix Version/s: 1.11.2 1.12.0 Resolution: Fixed merged to release-1.1

[jira] [Commented] (FLINK-18748) Savepoint would be queued unexpected if pendingCheckpoints less than maxConcurrentCheckpoints

2020-08-04 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170641#comment-17170641 ] Piotr Nowojski commented on FLINK-18748: Thanks for the contribution [~wayland]

[jira] [Commented] (FLINK-17073) Slow checkpoint cleanup causing OOMs

2020-08-04 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170643#comment-17170643 ] Etienne Chauchot commented on FLINK-17073: -- Hi Roman, thanks for your feedback.

[GitHub] [flink] flinkbot edited a comment on pull request #13054: [FLINK-15803][table] Support DataViews in FLIP-65 aggregate functions

2020-08-04 Thread GitBox
flinkbot edited a comment on pull request #13054: URL: https://github.com/apache/flink/pull/13054#issuecomment-668030431 ## CI report: * abedb100f5f02dc3249f58f8fb06e6f16f7246fb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] tillrohrmann commented on pull request #13042: [FLINK-16510] Allow overriding of graceful with forceful shutdown

2020-08-04 Thread GitBox
tillrohrmann commented on pull request #13042: URL: https://github.com/apache/flink/pull/13042#issuecomment-668452463 Fair points. If it should ever become a problem that we set a custom `SecurityManager` we might have to revisit this problem. +1 for making the mechanism available fo

[jira] [Commented] (FLINK-12130) Apply command line options to configuration before installing security modules

2020-08-04 Thread silence (Jira)
[ https://issues.apache.org/jira/browse/FLINK-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170648#comment-17170648 ] silence commented on FLINK-12130: - Have we solved it? It can be reproduced in the new ve

[GitHub] [flink] flinkbot edited a comment on pull request #12917: [FLINK-18355][tests] Simplify tests of SlotPoolImpl

2020-08-04 Thread GitBox
flinkbot edited a comment on pull request #12917: URL: https://github.com/apache/flink/pull/12917#issuecomment-659940433 ## CI report: * da7fb96fc00acda2a4c103f5f177efb9bd9be8be UNKNOWN * 217c88f0f382bf45143dcce82a089568528dad34 Azure: [FAILURE](https://dev.azure.com/apache-fl

[GitHub] [flink] flinkbot edited a comment on pull request #13018: [FLINK-18709][Coordination] Implement PhysicalSlotProvider

2020-08-04 Thread GitBox
flinkbot edited a comment on pull request #13018: URL: https://github.com/apache/flink/pull/13018#issuecomment-665565029 ## CI report: * 82cf917b212932113f018bd05fc02c3f6379 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] tillrohrmann commented on a change in pull request #13055: [FLINK-18677] Added handling of suspended or lost connections

2020-08-04 Thread GitBox
tillrohrmann commented on a change in pull request #13055: URL: https://github.com/apache/flink/pull/13055#discussion_r464889065 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/ZooKeeperLeaderElectionConnectionHandlingTest.java ## @@ -0,0 +1,1

[GitHub] [flink] wangyang0918 commented on pull request #12240: [FLINK-15792][k8s] Make Flink logs accessible via kubectl logs per default

2020-08-04 Thread GitBox
wangyang0918 commented on pull request #12240: URL: https://github.com/apache/flink/pull/12240#issuecomment-668467089 cc @tillrohrmann, i have rebased the latest master and could you have a look at your convenience. This is

[GitHub] [flink] flinkbot edited a comment on pull request #12240: [FLINK-15792][k8s] Make Flink logs accessible via kubectl logs per default

2020-08-04 Thread GitBox
flinkbot edited a comment on pull request #12240: URL: https://github.com/apache/flink/pull/12240#issuecomment-630661048 ## CI report: * f040c9efbb64404807c9fb94b5329c7c6c7aa865 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #13018: [FLINK-18709][Coordination] Implement PhysicalSlotProvider

2020-08-04 Thread GitBox
flinkbot edited a comment on pull request #13018: URL: https://github.com/apache/flink/pull/13018#issuecomment-665565029 ## CI report: * 82cf917b212932113f018bd05fc02c3f6379 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Commented] (FLINK-17073) Slow checkpoint cleanup causing OOMs

2020-08-04 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170657#comment-17170657 ] Roman Khachatryan commented on FLINK-17073: --- Hi Etienne,  You're right, I mis

[GitHub] [flink] twentyworld commented on pull request #12237: [FLINK-17290] [chinese-translation, Documentation / Training] Transla…

2020-08-04 Thread GitBox
twentyworld commented on pull request #12237: URL: https://github.com/apache/flink/pull/12237#issuecomment-668474902 thanks a lot for all of you guys’ comments. This is an automated message from the Apache Git Service. To res

[GitHub] [flink] tillrohrmann commented on pull request #12240: [FLINK-15792][k8s] Make Flink logs accessible via kubectl logs per default

2020-08-04 Thread GitBox
tillrohrmann commented on pull request #12240: URL: https://github.com/apache/flink/pull/12240#issuecomment-668476098 Thanks for rebasing the PR @wangyang0918. Me or someone from my team will take a look at it shortly. This

[GitHub] [flink] flinkbot edited a comment on pull request #12240: [FLINK-15792][k8s] Make Flink logs accessible via kubectl logs per default

2020-08-04 Thread GitBox
flinkbot edited a comment on pull request #12240: URL: https://github.com/apache/flink/pull/12240#issuecomment-630661048 ## CI report: * f040c9efbb64404807c9fb94b5329c7c6c7aa865 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #13018: [FLINK-18709][Coordination] Implement PhysicalSlotProvider

2020-08-04 Thread GitBox
flinkbot edited a comment on pull request #13018: URL: https://github.com/apache/flink/pull/13018#issuecomment-665565029 ## CI report: * 82cf917b212932113f018bd05fc02c3f6379 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #12917: [FLINK-18355][tests] Simplify tests of SlotPoolImpl

2020-08-04 Thread GitBox
flinkbot edited a comment on pull request #12917: URL: https://github.com/apache/flink/pull/12917#issuecomment-659940433 ## CI report: * da7fb96fc00acda2a4c103f5f177efb9bd9be8be UNKNOWN * 217c88f0f382bf45143dcce82a089568528dad34 Azure: [FAILURE](https://dev.azure.com/apache-fl

[GitHub] [flink-statefun] igalshilman commented on a change in pull request #128: [hotfix] fix python sdk example

2020-08-04 Thread GitBox
igalshilman commented on a change in pull request #128: URL: https://github.com/apache/flink-statefun/pull/128#discussion_r464908122 ## File path: docs/sdk/python.md ## @@ -132,23 +132,23 @@ The delayed message is non-blocking so functions will continue to process record The

[GitHub] [flink] hequn8128 commented on a change in pull request #13029: [FLINK-18763][python] Support basic TypeInformation for Python DataSt…

2020-08-04 Thread GitBox
hequn8128 commented on a change in pull request #13029: URL: https://github.com/apache/flink/pull/13029#discussion_r464911311 ## File path: flink-python/pyflink/common/typeinfo.py ## @@ -0,0 +1,523 @@ +

[GitHub] [flink] diohabara opened a new pull request #13057: [hotfix][docsFix typo and correct the grammar

2020-08-04 Thread GitBox
diohabara opened a new pull request #13057: URL: https://github.com/apache/flink/pull/13057 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[GitHub] [flink] shuiqiangchen commented on a change in pull request #13029: [FLINK-18763][python] Support basic TypeInformation for Python DataSt…

2020-08-04 Thread GitBox
shuiqiangchen commented on a change in pull request #13029: URL: https://github.com/apache/flink/pull/13029#discussion_r464914190 ## File path: flink-python/pyflink/common/typeinfo.py ## @@ -0,0 +1,523 @@ +

[jira] [Commented] (FLINK-18681) The jar package version conflict causes the task to continue to increase and grab resources

2020-08-04 Thread wangtaiyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170669#comment-17170669 ] wangtaiyang commented on FLINK-18681: - RM log is attached > The jar package version

[GitHub] [flink] flinkbot commented on pull request #13057: [hotfix][docsFix typo and correct the grammar

2020-08-04 Thread GitBox
flinkbot commented on pull request #13057: URL: https://github.com/apache/flink/pull/13057#issuecomment-668483814 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[GitHub] [flink] flinkbot commented on pull request #13057: [hotfix][docsFix typo and correct the grammar

2020-08-04 Thread GitBox
flinkbot commented on pull request #13057: URL: https://github.com/apache/flink/pull/13057#issuecomment-668487041 ## CI report: * 768fa60772f66987aae6dce8c021144c56149548 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] shuiqiangchen commented on pull request #13029: [FLINK-18763][python] Support basic TypeInformation for Python DataSt…

2020-08-04 Thread GitBox
shuiqiangchen commented on pull request #13029: URL: https://github.com/apache/flink/pull/13029#issuecomment-668490867 @hequn8128 Thank you for your comments, I have updated the code, please take a look at it. This is an aut

[GitHub] [flink] tillrohrmann closed pull request #13041: FLINK-18793 Fix Typo for api.common.eventtime.WatermarkStrategy Description

2020-08-04 Thread GitBox
tillrohrmann closed pull request #13041: URL: https://github.com/apache/flink/pull/13041 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Updated] (FLINK-18793) Fix Typo for api.common.eventtime.WatermarkStrategy Description

2020-08-04 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-18793: -- Issue Type: Improvement (was: Bug) > Fix Typo for api.common.eventtime.WatermarkStrategy Desc

[GitHub] [flink] flinkbot edited a comment on pull request #12962: [FLINK-18694] Add unaligned checkpoint config to web ui

2020-08-04 Thread GitBox
flinkbot edited a comment on pull request #12962: URL: https://github.com/apache/flink/pull/12962#issuecomment-662526701 ## CI report: * d2275584151f5a0a342af15e1d06f33da1237d62 UNKNOWN * d49f2f7ffe75a2e39dc3b8925831c60b56683952 Azure: [SUCCESS](https://dev.azure.com/apache-fl

[GitHub] [flink] flinkbot edited a comment on pull request #13029: [FLINK-18763][python] Support basic TypeInformation for Python DataSt…

2020-08-04 Thread GitBox
flinkbot edited a comment on pull request #13029: URL: https://github.com/apache/flink/pull/13029#issuecomment-666332680 ## CI report: * 1a3c5b93a697dea00a2e8237deb03b5848ffb1a9 UNKNOWN * be7e94a339fb20d1cee374495d8d8c1ac0af3c7b Azure: [FAILURE](https://dev.azure.com/apache-fl

[GitHub] [flink] flinkbot edited a comment on pull request #13057: [hotfix][docs]Fix typo and correct the grammar

2020-08-04 Thread GitBox
flinkbot edited a comment on pull request #13057: URL: https://github.com/apache/flink/pull/13057#issuecomment-668487041 ## CI report: * 768fa60772f66987aae6dce8c021144c56149548 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #13054: [FLINK-15803][table] Support DataViews in FLIP-65 aggregate functions

2020-08-04 Thread GitBox
flinkbot edited a comment on pull request #13054: URL: https://github.com/apache/flink/pull/13054#issuecomment-668030431 ## CI report: * abedb100f5f02dc3249f58f8fb06e6f16f7246fb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Closed] (FLINK-18793) Fix Typo for api.common.eventtime.WatermarkStrategy Description

2020-08-04 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-18793. - Fix Version/s: (was: 1.11.1) 1.11.2 1.12.0 Resol

[jira] [Updated] (FLINK-18426) Incompatible deprecated key type for registration cluster options

2020-08-04 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-18426: Fix Version/s: (was: 1.11.0) 1.11.1 > Incompatible deprecated key type for registra

[jira] [Updated] (FLINK-18426) Incompatible deprecated key type for registration cluster options

2020-08-04 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-18426: Fix Version/s: (was: 1.11.1) 1.11.0 > Incompatible deprecated key type for registra

[GitHub] [flink] AHeise commented on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.

2020-08-04 Thread GitBox
AHeise commented on pull request #13027: URL: https://github.com/apache/flink/pull/13027#issuecomment-668501769 > Could you summarize what the problem was that caused the performance regression? For some reason, not setting a parent classloader in the wrapper is much slower. I canno

[GitHub] [flink] AHeise edited a comment on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.

2020-08-04 Thread GitBox
AHeise edited a comment on pull request #13027: URL: https://github.com/apache/flink/pull/13027#issuecomment-668501769 > Could you summarize what the problem was that caused the performance regression? For some reason, not setting a parent classloader in the wrapper is much slower.

[GitHub] [flink] AHeise commented on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.

2020-08-04 Thread GitBox
AHeise commented on pull request #13027: URL: https://github.com/apache/flink/pull/13027#issuecomment-668503396 There was also a [classloader leak in ORC](https://issues.apache.org/jira/browse/ORC-653), for which I added a workaround. -

[GitHub] [flink] flinkbot edited a comment on pull request #13029: [FLINK-18763][python] Support basic TypeInformation for Python DataSt…

2020-08-04 Thread GitBox
flinkbot edited a comment on pull request #13029: URL: https://github.com/apache/flink/pull/13029#issuecomment-666332680 ## CI report: * 1a3c5b93a697dea00a2e8237deb03b5848ffb1a9 UNKNOWN * be7e94a339fb20d1cee374495d8d8c1ac0af3c7b Azure: [FAILURE](https://dev.azure.com/apache-fl

[GitHub] [flink] flinkbot edited a comment on pull request #13054: [FLINK-15803][table] Support DataViews in FLIP-65 aggregate functions

2020-08-04 Thread GitBox
flinkbot edited a comment on pull request #13054: URL: https://github.com/apache/flink/pull/13054#issuecomment-668030431 ## CI report: * abedb100f5f02dc3249f58f8fb06e6f16f7246fb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.

2020-08-04 Thread GitBox
flinkbot edited a comment on pull request #13027: URL: https://github.com/apache/flink/pull/13027#issuecomment-666225612 ## CI report: * 47ea974f8307084c080c6d343bf7b22296ed8b44 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] wuchong commented on pull request #12908: [FLINK-18449][table sql/api]Kafka topic discovery & partition discove…

2020-08-04 Thread GitBox
wuchong commented on pull request #12908: URL: https://github.com/apache/flink/pull/12908#issuecomment-668505104 Btw, could you add an integration test for this? This is an automated message from the Apache Git Service. To r

[GitHub] [flink] flinkbot edited a comment on pull request #13029: [FLINK-18763][python] Support basic TypeInformation for Python DataSt…

2020-08-04 Thread GitBox
flinkbot edited a comment on pull request #13029: URL: https://github.com/apache/flink/pull/13029#issuecomment-666332680 ## CI report: * 1a3c5b93a697dea00a2e8237deb03b5848ffb1a9 UNKNOWN * 943ff7e98177dec676272e44eae6e8fb1a1fcd2a Azure: [FAILURE](https://dev.azure.com/apache-fl

[GitHub] [flink] flinkbot edited a comment on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.

2020-08-04 Thread GitBox
flinkbot edited a comment on pull request #13027: URL: https://github.com/apache/flink/pull/13027#issuecomment-666225612 ## CI report: * 47ea974f8307084c080c6d343bf7b22296ed8b44 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Updated] (FLINK-18548) support flexible syntax for Temporal table

2020-08-04 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-18548: --- Summary: support flexible syntax for Temporal table (was: Dimension table do not support computed c

[GitHub] [flink] echauchot commented on pull request #13040: [FLINK-17073] [checkpointing] checkpointing backpressure if there are too many checkpoints to clean

2020-08-04 Thread GitBox
echauchot commented on pull request #13040: URL: https://github.com/apache/flink/pull/13040#issuecomment-668518373 @ifndef-SleePy I applied your suggestions of the design doc PTAL. Also is the test I added enough ? This is

[GitHub] [flink] flinkbot edited a comment on pull request #13027: [FLINK-16245] Decoupling user classloader from context classloader.

2020-08-04 Thread GitBox
flinkbot edited a comment on pull request #13027: URL: https://github.com/apache/flink/pull/13027#issuecomment-666225612 ## CI report: * c03925d4b90fc68ef1d8a6d4189960724cd398cd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #13040: [FLINK-17073] [checkpointing] checkpointing backpressure if there are too many checkpoints to clean

2020-08-04 Thread GitBox
flinkbot edited a comment on pull request #13040: URL: https://github.com/apache/flink/pull/13040#issuecomment-667140037 ## CI report: * 31abcb25fdf72394dbfa91d0ba9e151968375ad7 UNKNOWN * 12aef53ea5dd1cbd52ad5dfd2351eff66e159669 Azure: [SUCCESS](https://dev.azure.com/apache-fl

[jira] [Created] (FLINK-18810) Golang remote functions SDK

2020-08-04 Thread Francesco Guardiani (Jira)
Francesco Guardiani created FLINK-18810: --- Summary: Golang remote functions SDK Key: FLINK-18810 URL: https://issues.apache.org/jira/browse/FLINK-18810 Project: Flink Issue Type: New Fea

[jira] [Updated] (FLINK-18548) support flexible syntax for Temporal table

2020-08-04 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-18548: --- Description: The reason why Flink does not support computed column in dimension(temporal) table is

[GitHub] [flink] flinkbot edited a comment on pull request #13040: [FLINK-17073] [checkpointing] checkpointing backpressure if there are too many checkpoints to clean

2020-08-04 Thread GitBox
flinkbot edited a comment on pull request #13040: URL: https://github.com/apache/flink/pull/13040#issuecomment-667140037 ## CI report: * 31abcb25fdf72394dbfa91d0ba9e151968375ad7 UNKNOWN * 12aef53ea5dd1cbd52ad5dfd2351eff66e159669 Azure: [SUCCESS](https://dev.azure.com/apache-fl

[GitHub] [flink] wangyang0918 opened a new pull request #13058: [FLINK-18749][k8s] Correct dependencies in Kubernetes pom

2020-08-04 Thread GitBox
wangyang0918 opened a new pull request #13058: URL: https://github.com/apache/flink/pull/13058 ## What is the purpose of the change Inspired when developing this https://github.com/apache/flink/pull/12995/commits/8519f65321ba24c5164196a67a05d98fb268f490, i find some unused d

[jira] [Commented] (FLINK-18749) Correct dependencies in Kubernetes pom

2020-08-04 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170725#comment-17170725 ] Yang Wang commented on FLINK-18749: --- [~trohrmann] Yes, it is also a issue for master b

[jira] [Updated] (FLINK-18749) Correct dependencies in Kubernetes pom

2020-08-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-18749: --- Labels: pull-request-available (was: ) > Correct dependencies in Kubernetes pom > -

[GitHub] [flink] flinkbot commented on pull request #13058: [FLINK-18749][k8s] Correct dependencies in Kubernetes pom

2020-08-04 Thread GitBox
flinkbot commented on pull request #13058: URL: https://github.com/apache/flink/pull/13058#issuecomment-668534179 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[GitHub] [flink] flinkbot edited a comment on pull request #13040: [FLINK-17073] [checkpointing] checkpointing backpressure if there are too many checkpoints to clean

2020-08-04 Thread GitBox
flinkbot edited a comment on pull request #13040: URL: https://github.com/apache/flink/pull/13040#issuecomment-667140037 ## CI report: * 31abcb25fdf72394dbfa91d0ba9e151968375ad7 UNKNOWN * db99952f8166cb4d6337dcb3815e72ff2b49604b UNKNOWN * 8e83ba02f7e800375070d1556c938614b1d4

[GitHub] [flink] flinkbot commented on pull request #13058: [FLINK-18749][k8s] Correct dependencies in Kubernetes pom

2020-08-04 Thread GitBox
flinkbot commented on pull request #13058: URL: https://github.com/apache/flink/pull/13058#issuecomment-668542483 ## CI report: * d1596d1c5c10b64f52ecc80488dfa5a7b6d59a5d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] flinkbot edited a comment on pull request #13054: [FLINK-15803][table] Support DataViews in FLIP-65 aggregate functions

2020-08-04 Thread GitBox
flinkbot edited a comment on pull request #13054: URL: https://github.com/apache/flink/pull/13054#issuecomment-668030431 ## CI report: * 61fb866575b128a4814bcd2e9b7de0b64e2e7dbd Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] dawidwys commented on a change in pull request #13054: [FLINK-15803][table] Support DataViews in FLIP-65 aggregate functions

2020-08-04 Thread GitBox
dawidwys commented on a change in pull request #13054: URL: https://github.com/apache/flink/pull/13054#discussion_r464985112 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/CodeGeneratorContext.scala ## @@ -671,28 +677,

[jira] [Created] (FLINK-18811) if a disk is damaged, taskmanager should choose another disk for temp dir , rather than throw an IOException, which causes flink job restart over and over again

2020-08-04 Thread Kai Chen (Jira)
Kai Chen created FLINK-18811: Summary: if a disk is damaged, taskmanager should choose another disk for temp dir , rather than throw an IOException, which causes flink job restart over and over again Key: FLINK-18811

[GitHub] [flink] twalthr commented on a change in pull request #13054: [FLINK-15803][table] Support DataViews in FLIP-65 aggregate functions

2020-08-04 Thread GitBox
twalthr commented on a change in pull request #13054: URL: https://github.com/apache/flink/pull/13054#discussion_r464988360 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/CodeGeneratorContext.scala ## @@ -671,28 +677,3

[GitHub] [flink] flinkbot edited a comment on pull request #13058: [FLINK-18749][k8s] Correct dependencies in Kubernetes pom

2020-08-04 Thread GitBox
flinkbot edited a comment on pull request #13058: URL: https://github.com/apache/flink/pull/13058#issuecomment-668542483 ## CI report: * d1596d1c5c10b64f52ecc80488dfa5a7b6d59a5d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] dawidwys commented on a change in pull request #13054: [FLINK-15803][table] Support DataViews in FLIP-65 aggregate functions

2020-08-04 Thread GitBox
dawidwys commented on a change in pull request #13054: URL: https://github.com/apache/flink/pull/13054#discussion_r464991883 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/agg/AggsHandlerCodeGenerator.scala ## @@ -1206

[GitHub] [flink] hequn8128 commented on pull request #13029: [FLINK-18763][python] Support basic TypeInformation for Python DataSt…

2020-08-04 Thread GitBox
hequn8128 commented on pull request #13029: URL: https://github.com/apache/flink/pull/13029#issuecomment-668553682 @shuiqiangchen Thanks a lot for the update. Please check the test azure test failures. This is an automated

[GitHub] [flink] hequn8128 edited a comment on pull request #13029: [FLINK-18763][python] Support basic TypeInformation for Python DataSt…

2020-08-04 Thread GitBox
hequn8128 edited a comment on pull request #13029: URL: https://github.com/apache/flink/pull/13029#issuecomment-668553682 @shuiqiangchen Thanks a lot for the update. Please check the azure test failures. This is an automate

[GitHub] [flink] dawidwys commented on a change in pull request #13054: [FLINK-15803][table] Support DataViews in FLIP-65 aggregate functions

2020-08-04 Thread GitBox
dawidwys commented on a change in pull request #13054: URL: https://github.com/apache/flink/pull/13054#discussion_r46479 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/CodeGeneratorContext.scala ## @@ -671,28 +677,

[jira] [Commented] (FLINK-15170) WebFrontendITCase.testCancelYarn fails on travis

2020-08-04 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170758#comment-17170758 ] Dian Fu commented on FLINK-15170: - Another instance on 1.10: https://travis-ci.org/gith

[GitHub] [flink] dawidwys commented on a change in pull request #13054: [FLINK-15803][table] Support DataViews in FLIP-65 aggregate functions

2020-08-04 Thread GitBox
dawidwys commented on a change in pull request #13054: URL: https://github.com/apache/flink/pull/13054#discussion_r465004837 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/typeutils/ExternalSerializer.java ## @@ -0,0 +1,226 @@

[GitHub] [flink] danny0405 commented on pull request #13050: [FLINK-18750][table] SqlValidatorException thrown when select from a …

2020-08-04 Thread GitBox
danny0405 commented on pull request #13050: URL: https://github.com/apache/flink/pull/13050#issuecomment-668563373 > Are we planning to bump Calcite version for 1.12? @wuchong @twalthr > > If we do, I'd prefer we do not add this workaround. If we don't the PR looks good to me

[jira] [Commented] (FLINK-18800) Avro serialization schema doesn't support Kafka key/value serialization

2020-08-04 Thread Mohammad Hossein Gerami (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170767#comment-17170767 ] Mohammad Hossein Gerami commented on FLINK-18800: - I would like to imple

[GitHub] [flink] flinkbot edited a comment on pull request #13029: [FLINK-18763][python] Support basic TypeInformation for Python DataSt…

2020-08-04 Thread GitBox
flinkbot edited a comment on pull request #13029: URL: https://github.com/apache/flink/pull/13029#issuecomment-666332680 ## CI report: * 1a3c5b93a697dea00a2e8237deb03b5848ffb1a9 UNKNOWN * 943ff7e98177dec676272e44eae6e8fb1a1fcd2a Azure: [FAILURE](https://dev.azure.com/apache-fl

[jira] [Updated] (FLINK-18689) Deterministic Slot Sharing

2020-08-04 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-18689: Fix Version/s: 1.12.0 > Deterministic Slot Sharing > -- > > Key: F

[GitHub] [flink] twalthr commented on pull request #13050: [FLINK-18750][table] SqlValidatorException thrown when select from a …

2020-08-04 Thread GitBox
twalthr commented on pull request #13050: URL: https://github.com/apache/flink/pull/13050#issuecomment-668568181 We will release Flink 1.12 end of October. We should bump the Calcite version until then. This is an automated

[GitHub] [flink] dawidwys commented on a change in pull request #13054: [FLINK-15803][table] Support DataViews in FLIP-65 aggregate functions

2020-08-04 Thread GitBox
dawidwys commented on a change in pull request #13054: URL: https://github.com/apache/flink/pull/13054#discussion_r465012717 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/dataview/ListView.java ## @@ -156,17 +173,49 @@ public boolean equ

[GitHub] [flink] twalthr commented on pull request #13050: [FLINK-18750][table] SqlValidatorException thrown when select from a …

2020-08-04 Thread GitBox
twalthr commented on pull request #13050: URL: https://github.com/apache/flink/pull/13050#issuecomment-668570075 Could you name a few of these breaking changes? I know about the dropped windows but what else? This is an auto

[GitHub] [flink] twalthr edited a comment on pull request #13050: [FLINK-18750][table] SqlValidatorException thrown when select from a …

2020-08-04 Thread GitBox
twalthr edited a comment on pull request #13050: URL: https://github.com/apache/flink/pull/13050#issuecomment-668568181 We will release Flink 1.12 end of October. We should bump the Calcite version until then. The longer we wait, the more difficult will an upgrade be in the future. We shou

[GitHub] [flink] dawidwys commented on a change in pull request #13054: [FLINK-15803][table] Support DataViews in FLIP-65 aggregate functions

2020-08-04 Thread GitBox
dawidwys commented on a change in pull request #13054: URL: https://github.com/apache/flink/pull/13054#discussion_r465018429 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/extraction/DataTypeExtractor.java ## @@ -595,4 +605,36 @@ privat

[GitHub] [flink] flinkbot edited a comment on pull request #13018: [FLINK-18709][Coordination] Implement PhysicalSlotProvider

2020-08-04 Thread GitBox
flinkbot edited a comment on pull request #13018: URL: https://github.com/apache/flink/pull/13018#issuecomment-665565029 ## CI report: * 5b80f298328d69da9966e584c9b93b71fe2d12e3 UNKNOWN * 15bf316c4e7c1e8ec5c6a62daf9b1c3af55bdc41 Azure: [SUCCESS](https://dev.azure.com/apache-fl

[GitHub] [flink] flinkbot edited a comment on pull request #13029: [FLINK-18763][python] Support basic TypeInformation for Python DataSt…

2020-08-04 Thread GitBox
flinkbot edited a comment on pull request #13029: URL: https://github.com/apache/flink/pull/13029#issuecomment-666332680 ## CI report: * 1a3c5b93a697dea00a2e8237deb03b5848ffb1a9 UNKNOWN * 943ff7e98177dec676272e44eae6e8fb1a1fcd2a Azure: [FAILURE](https://dev.azure.com/apache-fl

[jira] [Updated] (FLINK-18749) Correct dependencies in Kubernetes pom

2020-08-04 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-18749: -- Fix Version/s: 1.12.0 > Correct dependencies in Kubernetes pom > -

  1   2   3   >