wangyang0918 commented on a change in pull request #13186:
URL: https://github.com/apache/flink/pull/13186#discussion_r476203060
##
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManagerDriver.java
##
@@ -0,0 +1,325 @@
+/*
+ * Licensed
JingsongLi commented on pull request #13216:
URL: https://github.com/apache/flink/pull/13216#issuecomment-679840920
This PR changed behavior: Planner use Java SPI to load temporary source/sink
instead of Catalog.getTableFactory.
I think it is the right work to do, but I think this can be
tillrohrmann commented on a change in pull request #12899:
URL: https://github.com/apache/flink/pull/12899#discussion_r476217310
##
File path: docs/ops/deployment/native_kubernetes.md
##
@@ -211,6 +211,77 @@ $ ./bin/flink run-application -p 8 -t
kubernetes-application \
loc
flinkbot edited a comment on pull request #13227:
URL: https://github.com/apache/flink/pull/13227#issuecomment-679046587
## CI report:
* 213695b1635186819bcde49ed3c94f0238943ee2 Azure:
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result
flinkbot edited a comment on pull request #13172:
URL: https://github.com/apache/flink/pull/13172#issuecomment-674806621
## CI report:
* 78b0ad2216677f31e8ab3844cb3632dc479591dc Azure:
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result
[
https://issues.apache.org/jira/browse/FLINK-19022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183768#comment-17183768
]
Till Rohrmann commented on FLINK-19022:
---
Yes, for 3) we also need to pass a {{Fata
Myracle commented on pull request #13227:
URL: https://github.com/apache/flink/pull/13227#issuecomment-679832482
@flinkbot run azure
This is an automated message from the Apache Git Service.
To respond to the message, please
RocMarshal commented on a change in pull request #13172:
URL: https://github.com/apache/flink/pull/13172#discussion_r476208584
##
File path: docs/dev/migration.zh.md
##
@@ -25,18 +25,18 @@ under the License.
* This will be replaced by the TOC
{:toc}
-See the [older migratio
flinkbot edited a comment on pull request #13050:
URL: https://github.com/apache/flink/pull/13050#issuecomment-667904442
## CI report:
* 0aa2e599db47cf035f6d7cf0389e7caa273b5880 Azure:
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result
RocMarshal commented on a change in pull request #13172:
URL: https://github.com/apache/flink/pull/13172#discussion_r47620
##
File path: docs/dev/migration.zh.md
##
@@ -25,18 +25,18 @@ under the License.
* This will be replaced by the TOC
{:toc}
-See the [older migratio
tillrohrmann commented on a change in pull request #13217:
URL: https://github.com/apache/flink/pull/13217#discussion_r476207888
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherJob.java
##
@@ -0,0 +1,256 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/FLINK-18959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183761#comment-17183761
]
Till Rohrmann commented on FLINK-18959:
---
This is true [~Jiangang]. Was this the re
flinkbot edited a comment on pull request #13235:
URL: https://github.com/apache/flink/pull/13235#issuecomment-679625638
## CI report:
* 96c1c36cfd2ee8926f97dd48fa88d6fe3e0bdaba Azure:
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result
[
https://issues.apache.org/jira/browse/FLINK-19009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Liu updated FLINK-19009:
--
Comment: was deleted
(was: I think I can fix this bug, but first we need to reach a consensus on the
flinkbot edited a comment on pull request #6787:
URL: https://github.com/apache/flink/pull/6787#issuecomment-679502953
## CI report:
* 71aa0e61536786901c6770adadd6f87b146a01db Travis:
[SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/181219241)
Bot commands
klion26 commented on a change in pull request #13172:
URL: https://github.com/apache/flink/pull/13172#discussion_r476181673
##
File path: docs/dev/migration.zh.md
##
@@ -25,18 +25,18 @@ under the License.
* This will be replaced by the TOC
{:toc}
-See the [older migration
-
flinkbot edited a comment on pull request #13235:
URL: https://github.com/apache/flink/pull/13235#issuecomment-679625638
## CI report:
* 96c1c36cfd2ee8926f97dd48fa88d6fe3e0bdaba Azure:
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result
liupc commented on pull request #13141:
URL: https://github.com/apache/flink/pull/13141#issuecomment-679635208
gentle ping~ @wuchong
This is an automated message from the Apache Git Service.
To respond to the message, please
flinkbot commented on pull request #13235:
URL: https://github.com/apache/flink/pull/13235#issuecomment-679625638
## CI report:
* 96c1c36cfd2ee8926f97dd48fa88d6fe3e0bdaba UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot r
[
https://issues.apache.org/jira/browse/FLINK-18974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183734#comment-17183734
]
Roc Marshal edited comment on FLINK-18974 at 8/25/20, 4:49 AM:
---
[
https://issues.apache.org/jira/browse/FLINK-18974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183734#comment-17183734
]
Roc Marshal commented on FLINK-18974:
-
[~ZhuShang]
OK, I'm willing to review it
flinkbot commented on pull request #13235:
URL: https://github.com/apache/flink/pull/13235#issuecomment-679610701
Thanks a lot for your contribution to the Apache Flink project. I'm the
@flinkbot. I help the community
to review your pull request. We will use this comment to track the pro
[
https://issues.apache.org/jira/browse/FLINK-19036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-19036:
---
Labels: pull-request-available translation-zh (was: translation-zh)
> Translate page 'Appli
RocMarshal commented on pull request #13235:
URL: https://github.com/apache/flink/pull/13235#issuecomment-679609380
Hi @xccui
Could you help me to review this PR if you have free time?
Thank you.
This is an automated m
RocMarshal opened a new pull request #13235:
URL: https://github.com/apache/flink/pull/13235
## What is the purpose of the change
*Translate page 'Application Profiling & Debugging' of 'Debugging &
Monitoring' into Chinese*
## Brief change log
*Translate pag
[
https://issues.apache.org/jira/browse/FLINK-18909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183720#comment-17183720
]
Jingsong Lee edited comment on FLINK-18909 at 8/25/20, 4:20 AM:
--
[
https://issues.apache.org/jira/browse/FLINK-18909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183720#comment-17183720
]
Jingsong Lee commented on FLINK-18909:
--
SequenceGenerator can not accept too huge r
flinkbot edited a comment on pull request #13227:
URL: https://github.com/apache/flink/pull/13227#issuecomment-679046587
## CI report:
* 213695b1635186819bcde49ed3c94f0238943ee2 Azure:
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result
[
https://issues.apache.org/jira/browse/FLINK-17397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183715#comment-17183715
]
Jingsong Lee commented on FLINK-17397:
--
Conceptually, support {{ScanTableSource}}
flinkbot edited a comment on pull request #6787:
URL: https://github.com/apache/flink/pull/6787#issuecomment-679502953
## CI report:
* 71aa0e61536786901c6770adadd6f87b146a01db Travis:
[PENDING](https://travis-ci.com/github/flink-ci/flink/builds/181219241)
Bot commands
[
https://issues.apache.org/jira/browse/FLINK-18974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183705#comment-17183705
]
Pua commented on FLINK-18974:
-
[~RocMarshal] could you or someone else hava a review?
> Tra
flinkbot commented on pull request #6787:
URL: https://github.com/apache/flink/pull/6787#issuecomment-679502953
## CI report:
* 71aa0e61536786901c6770adadd6f87b146a01db UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run
tobegit3hub commented on pull request #6787:
URL: https://github.com/apache/flink/pull/6787#issuecomment-679489828
Any update for this PR? We are really looking for these APIs to convert
append stream or upsert stream back to Table objects.
dianfu commented on pull request #13034:
URL: https://github.com/apache/flink/pull/13034#issuecomment-679479779
@kezhuw Thanks for your comments.
- Regarding to "retrying 5 times", I think that's enough considering the
frequency of this issue(it occurs two times in the last two weeks).
[
https://issues.apache.org/jira/browse/FLINK-18851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183692#comment-17183692
]
goutham commented on FLINK-18851:
-
I can pick this up. pls assign this issue to me.
> A
flinkbot edited a comment on pull request #13050:
URL: https://github.com/apache/flink/pull/13050#issuecomment-667904442
## CI report:
* efe2b4b092cbce31dee74b4261ca7a20904b2000 Azure:
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result
flinkbot edited a comment on pull request #13227:
URL: https://github.com/apache/flink/pull/13227#issuecomment-679046587
## CI report:
* 17b779c8ed6e12edd9f6da41860a1b52c8a8390c Azure:
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result
flinkbot edited a comment on pull request #13227:
URL: https://github.com/apache/flink/pull/13227#issuecomment-679046587
## CI report:
* 17b779c8ed6e12edd9f6da41860a1b52c8a8390c Azure:
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result
flinkbot edited a comment on pull request #13050:
URL: https://github.com/apache/flink/pull/13050#issuecomment-667904442
## CI report:
* efe2b4b092cbce31dee74b4261ca7a20904b2000 Azure:
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result
[
https://issues.apache.org/jira/browse/FLINK-18742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183685#comment-17183685
]
Matt Wang edited comment on FLINK-18742 at 8/25/20, 2:30 AM:
-
[
https://issues.apache.org/jira/browse/FLINK-19037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183687#comment-17183687
]
Yang Wang commented on FLINK-19037:
---
Maybe FLINK-17024 is also related. +1 to forward
[
https://issues.apache.org/jira/browse/FLINK-18742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183685#comment-17183685
]
Matt Wang commented on FLINK-18742:
---
[~rmetzger] The `CoreOptions.CHECK_LEAKED_CLASSLO
[
https://issues.apache.org/jira/browse/FLINK-17397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183684#comment-17183684
]
Jark Wu commented on FLINK-17397:
-
The fundamental need from the user and me is support
[
https://issues.apache.org/jira/browse/FLINK-17397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183684#comment-17183684
]
Jark Wu edited comment on FLINK-17397 at 8/25/20, 2:28 AM:
---
Th
[
https://issues.apache.org/jira/browse/FLINK-18959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183683#comment-17183683
]
Liu commented on FLINK-18959:
-
Thanks for the reply, [~trohrmann] and [~aljoscha]. After rev
[
https://issues.apache.org/jira/browse/FLINK-17330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhu Zhu closed FLINK-17330.
---
Resolution: Fixed
Done via
c2bb9808178f9b28742a0738280552df209f
c0f382f5f0072441ef8933f6993f1c34168004d6
zhuzhurk merged pull request #13205:
URL: https://github.com/apache/flink/pull/13205
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
danny0405 commented on a change in pull request #13050:
URL: https://github.com/apache/flink/pull/13050#discussion_r476063925
##
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/utils/Expander.java
##
@@ -70,30 +75,43 @@ public stat
zhuzhurk merged pull request #366:
URL: https://github.com/apache/flink-web/pull/366
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
zhuzhurk commented on pull request #366:
URL: https://github.com/apache/flink-web/pull/366#issuecomment-679459626
Thanks for reviewing @uce @Myasuka
We can announce the release today. I have updated the date to 2020-08-25 and
will merge the change soon.
---
danny0405 commented on a change in pull request #13050:
URL: https://github.com/apache/flink/pull/13050#discussion_r476063925
##
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/utils/Expander.java
##
@@ -70,30 +75,43 @@ public stat
[
https://issues.apache.org/jira/browse/FLINK-19012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183673#comment-17183673
]
Dian Fu commented on FLINK-19012:
-
Upgrade to "Critical" as this issue seems not occur a
[
https://issues.apache.org/jira/browse/FLINK-19012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dian Fu updated FLINK-19012:
Fix Version/s: 1.12.0
> E2E test fails with "Cannot register Closeable, this
> subtaskCheckpointCoordinat
[
https://issues.apache.org/jira/browse/FLINK-19012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dian Fu updated FLINK-19012:
Priority: Critical (was: Major)
> E2E test fails with "Cannot register Closeable, this
> subtaskCheckpoi
zhoulii commented on pull request #12899:
URL: https://github.com/apache/flink/pull/12899#issuecomment-679456963
Hi @tillrohrmann , thanks for reviewing this pr. I add some description
about how to use Secrets in native_kubernetes.md and update the code on your
advice.
--
[
https://issues.apache.org/jira/browse/FLINK-17274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183671#comment-17183671
]
Dian Fu commented on FLINK-17274:
-
[https://dev.azure.com/apache-flink/apache-flink/_bui
[
https://issues.apache.org/jira/browse/FLINK-19012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183670#comment-17183670
]
Dian Fu commented on FLINK-19012:
-
[https://dev.azure.com/apache-flink/apache-flink/_bui
zhoulii commented on a change in pull request #12899:
URL: https://github.com/apache/flink/pull/12899#discussion_r476053520
##
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesSecretEnvVar.java
##
@@ -0,0 +1,50 @@
+/*
+ * Lic
[
https://issues.apache.org/jira/browse/FLINK-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shuiqiang Chen updated FLINK-19041:
---
Description: We failed to set merged configurations into
DataStreamTwoInputPythonStatelessFu
zhoulii commented on a change in pull request #12899:
URL: https://github.com/apache/flink/pull/12899#discussion_r476053086
##
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/parameters/KubernetesParameters.java
##
@@ -110,4 +110,14 @@
zhoulii commented on a change in pull request #12899:
URL: https://github.com/apache/flink/pull/12899#discussion_r476052791
##
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/parameters/KubernetesParameters.java
##
@@ -110,4 +110,14 @@
zhoulii commented on a change in pull request #12899:
URL: https://github.com/apache/flink/pull/12899#discussion_r476051896
##
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/decorators/MountSecretsDecorator.java
##
@@ -0,0 +1,92 @@
+/*
+ * Lic
zhoulii commented on a change in pull request #12899:
URL: https://github.com/apache/flink/pull/12899#discussion_r476052224
##
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/decorators/EnvSecretsDecorator.java
##
@@ -0,0 +1,61 @@
+/*
+ * Licen
zhoulii commented on a change in pull request #12899:
URL: https://github.com/apache/flink/pull/12899#discussion_r476051560
##
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##
@@ -221,6 +221,21 @@
/** D
zhoulii commented on a change in pull request #12899:
URL: https://github.com/apache/flink/pull/12899#discussion_r476050973
##
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##
@@ -221,6 +221,21 @@
/** D
Shuiqiang Chen created FLINK-19041:
--
Summary: Add dependency management for ConnectedStream in Python
DataStream API.
Key: FLINK-19041
URL: https://issues.apache.org/jira/browse/FLINK-19041
Project:
flinkbot edited a comment on pull request #13228:
URL: https://github.com/apache/flink/pull/13228#issuecomment-679099456
## CI report:
* 67942d0ea538985ec25cecf7cefdc1bec0c1b53b Azure:
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result
[
https://issues.apache.org/jira/browse/FLINK-19005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183623#comment-17183623
]
Chesnay Schepler commented on FLINK-19005:
--
My conclusion is that Flink is not
flinkbot edited a comment on pull request #13205:
URL: https://github.com/apache/flink/pull/13205#issuecomment-677463515
## CI report:
* 8617ce6c0c5e0b4e8ba01aae58b1ef5cff2f02e6 Azure:
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result
flinkbot edited a comment on pull request #13233:
URL: https://github.com/apache/flink/pull/13233#issuecomment-679234273
## CI report:
* f2538ea4babc43852365b6a3fde86f823873106c Azure:
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result
flinkbot edited a comment on pull request #13228:
URL: https://github.com/apache/flink/pull/13228#issuecomment-679099456
## CI report:
* f0bb8a255816919a6578a6994499757075ab371b Azure:
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result
flinkbot edited a comment on pull request #13228:
URL: https://github.com/apache/flink/pull/13228#issuecomment-679099456
## CI report:
* f0bb8a255816919a6578a6994499757075ab371b Azure:
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result
flinkbot edited a comment on pull request #13231:
URL: https://github.com/apache/flink/pull/13231#issuecomment-679197180
## CI report:
* faa0726d771536cfdb669d86bc5310e82946f527 Azure:
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result
flinkbot edited a comment on pull request #13217:
URL: https://github.com/apache/flink/pull/13217#issuecomment-678285884
## CI report:
* 3655fcea1966bfbcb85c86d6a159c354f20d6cc7 UNKNOWN
* 52a49f0b0840aa9220de72d64c50a6b33f6adf92 Azure:
[FAILURE](https://dev.azure.com/apache-fl
flinkbot edited a comment on pull request #13217:
URL: https://github.com/apache/flink/pull/13217#issuecomment-678285884
## CI report:
* 3655fcea1966bfbcb85c86d6a159c354f20d6cc7 UNKNOWN
* 9127b879bec8dc1c05176c1acb89680c0e7baf04 Azure:
[FAILURE](https://dev.azure.com/apache-fl
rmetzger commented on a change in pull request #13217:
URL: https://github.com/apache/flink/pull/13217#discussion_r475791446
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
##
@@ -350,71 +341,42 @@ private boolean isPartialResource
flinkbot edited a comment on pull request #13232:
URL: https://github.com/apache/flink/pull/13232#issuecomment-679225070
## CI report:
* dd7743539c7ed5c45d93fc8b3c12e2db8b7af65e Azure:
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result
[
https://issues.apache.org/jira/browse/FLINK-18742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Metzger reopened FLINK-18742:
I reverted the commit on release-1.11 because it broke the branch:
https://github.com/apache/
[
https://issues.apache.org/jira/browse/FLINK-18742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Metzger updated FLINK-18742:
---
Fix Version/s: (was: 1.11.2)
> Some configuration args do not take effect at client
> --
flinkbot edited a comment on pull request #13234:
URL: https://github.com/apache/flink/pull/13234#issuecomment-679243226
## CI report:
* e1c13bbc1899c7c2d7e94d26cdeb47deddf76b50 Azure:
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result
flinkbot edited a comment on pull request #13205:
URL: https://github.com/apache/flink/pull/13205#issuecomment-677463515
## CI report:
* b6ec9981ff3880e61df71fc37459026dcaafb950 Azure:
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result
[
https://issues.apache.org/jira/browse/FLINK-18970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-18970.
> Adding Junit TestMarkers
>
>
> Key: FLINK-18970
>
[
https://issues.apache.org/jira/browse/FLINK-18970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler updated FLINK-18970:
-
Fix Version/s: (was: 1.11.1)
> Adding Junit TestMarkers
>
>
StephanEwen commented on pull request #13233:
URL: https://github.com/apache/flink/pull/13233#issuecomment-679245209
Looks good to me, too.
Minor comment: I think it is fine to not put the `close()` in a `finally`
block in tests, if this makes the test structure a bit more complex, b
flinkbot edited a comment on pull request #13229:
URL: https://github.com/apache/flink/pull/13229#issuecomment-679107131
## CI report:
* c7b217fe81e2a5480bb1155422bfa44a4278dc8f Azure:
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result
flinkbot edited a comment on pull request #13205:
URL: https://github.com/apache/flink/pull/13205#issuecomment-677463515
## CI report:
* b6ec9981ff3880e61df71fc37459026dcaafb950 Azure:
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result
flinkbot commented on pull request #13234:
URL: https://github.com/apache/flink/pull/13234#issuecomment-679243226
## CI report:
* e1c13bbc1899c7c2d7e94d26cdeb47deddf76b50 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot r
flinkbot edited a comment on pull request #13233:
URL: https://github.com/apache/flink/pull/13233#issuecomment-679234273
## CI report:
* f2538ea4babc43852365b6a3fde86f823873106c Azure:
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result
flinkbot commented on pull request #13234:
URL: https://github.com/apache/flink/pull/13234#issuecomment-679234288
Thanks a lot for your contribution to the Apache Flink project. I'm the
@flinkbot. I help the community
to review your pull request. We will use this comment to track the pro
flinkbot commented on pull request #13233:
URL: https://github.com/apache/flink/pull/13233#issuecomment-679234273
## CI report:
* f2538ea4babc43852365b6a3fde86f823873106c UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot r
flinkbot edited a comment on pull request #13181:
URL: https://github.com/apache/flink/pull/13181#issuecomment-675091412
## CI report:
* 9e7d2cb792556814b91b8f580d9a1cbe98433274 Azure:
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result
flinkbot edited a comment on pull request #13232:
URL: https://github.com/apache/flink/pull/13232#issuecomment-679225070
## CI report:
* dd7743539c7ed5c45d93fc8b3c12e2db8b7af65e Azure:
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result
[
https://issues.apache.org/jira/browse/FLINK-18905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-18905:
---
Labels: pull-request-available (was: )
> Add runtime support for multiple input operator ch
wangzzu removed a comment on pull request #13233:
URL: https://github.com/apache/flink/pull/13233#issuecomment-679231489
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on
pnowojski opened a new pull request #13234:
URL: https://github.com/apache/flink/pull/13234
This PR adds a possibility to chain `SourceOperator` with
`MultipleInputStreamTask`. Currently checkpointing, watermarks or metrics are
not tested (part of another ticket).
## Brief change lo
wangzzu commented on pull request #13233:
URL: https://github.com/apache/flink/pull/13233#issuecomment-679231489
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
zhuzhurk commented on a change in pull request #13205:
URL: https://github.com/apache/flink/pull/13205#discussion_r475734143
##
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/failover/flip1/StronglyConnectedComponentsComputeUtilsTest.java
##
@@
[
https://issues.apache.org/jira/browse/FLINK-18970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
goutham resolved FLINK-18970.
-
Resolution: Not A Problem
> Adding Junit TestMarkers
>
>
> Key:
[
https://issues.apache.org/jira/browse/FLINK-18970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183413#comment-17183413
]
goutham commented on FLINK-18970:
-
Thanks [~sewen].. this helps.. we can close this issu
flinkbot commented on pull request #13232:
URL: https://github.com/apache/flink/pull/13232#issuecomment-679225070
## CI report:
* dd7743539c7ed5c45d93fc8b3c12e2db8b7af65e UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot r
1 - 100 of 329 matches
Mail list logo
