[GitHub] [flink] zentol merged pull request #13406: [FLINK-19243][elasticsearch] Bump snakeyaml to 1.27

2020-09-22 Thread GitBox
zentol merged pull request #13406: URL: https://github.com/apache/flink/pull/13406 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [flink] miklosgergely commented on a change in pull request #13128: [FLINK-18795][hbase] Support for HBase 2

2020-09-22 Thread GitBox
miklosgergely commented on a change in pull request #13128: URL: https://github.com/apache/flink/pull/13128#discussion_r493240313 ## File path: flink-connectors/flink-sql-connector-hbase-2.2/src/main/resources/hbase-default.xml ## @@ -0,0 +1,1558 @@ + + + + + + + + +

[jira] [Closed] (FLINK-19311) Add ResourceRequirement(s)

2020-09-22 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-19311. Resolution: Fixed master: b443bf7e349df65125e9923add9013aab3ee5c9e > Add ResourceRequirem

[GitHub] [flink] zentol merged pull request #13453: [FLINK-19311][coordination] Add ResourceRequirement(s)

2020-09-22 Thread GitBox
zentol merged pull request #13453: URL: https://github.com/apache/flink/pull/13453 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [flink] flinkbot edited a comment on pull request #13458: FLINK-18851 [runtime] Add checkpoint type to checkpoint history entries in Web UI

2020-09-22 Thread GitBox
flinkbot edited a comment on pull request #13458: URL: https://github.com/apache/flink/pull/13458#issuecomment-697041219 ## CI report: * 5922cdb5a2b87889a53f95a4f7902e6dc7f5b63a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Commented] (FLINK-19358) when submit job on application mode with HA,the jobid will be 0000000000

2020-09-22 Thread Kostas Kloudas (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200605#comment-17200605 ] Kostas Kloudas commented on FLINK-19358: [~zhangjun] When launching an applicati

[jira] [Closed] (FLINK-16147) Add watermarkExprOutputType in WatermarkSpec#toString method

2020-09-22 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-16147. Resolution: Fixed Fixed in 1.12.0: 77be200551fbd6cdd19f0c292a715d1d4da92f4f > Add watermarkExprOu

[GitHub] [flink] flinkbot edited a comment on pull request #13327: [FLINK-19134][python] Add BasicArrayTypeInfo and coder for PrimitiveArrayTypeInfo for Python DataStream API.

2020-09-22 Thread GitBox
flinkbot edited a comment on pull request #13327: URL: https://github.com/apache/flink/pull/13327#issuecomment-687006937 ## CI report: * 2684468e6cc397456950f4fdada171cbbe6730a9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] twalthr closed pull request #11125: [FLINK-16147][Flink-Table-Common] WatermarkSepc#toString contain watermarkExprOutputType field

2020-09-22 Thread GitBox
twalthr closed pull request #11125: URL: https://github.com/apache/flink/pull/11125 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] gm7y8 commented on pull request #13458: FLINK-18851 [runtime] Add checkpoint type to checkpoint history entries in Web UI

2020-09-22 Thread GitBox
gm7y8 commented on pull request #13458: URL: https://github.com/apache/flink/pull/13458#issuecomment-697169263 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message, please lo

[jira] [Commented] (FLINK-19370) FileSourceTextLinesITCase.testContinuousTextFileSource is instable

2020-09-22 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200600#comment-17200600 ] Dian Fu commented on FLINK-19370: - cc [~sewen], this seems an instable case introduced i

[jira] [Updated] (FLINK-19370) FileSourceTextLinesITCase.testContinuousTextFileSource is instable

2020-09-22 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-19370: Summary: FileSourceTextLinesITCase.testContinuousTextFileSource is instable (was: FileSourceTextLinesITCa

[jira] [Updated] (FLINK-19370) FileSourceTextLinesITCase.testContinuousTextFileSource failed

2020-09-22 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-19370: Component/s: Tests > FileSourceTextLinesITCase.testContinuousTextFileSource failed > -

[jira] [Updated] (FLINK-19370) FileSourceTextLinesITCase.testContinuousTextFileSource failed

2020-09-22 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-19370: Labels: test-stability (was: ) > FileSourceTextLinesITCase.testContinuousTextFileSource failed >

[jira] [Created] (FLINK-19370) FileSourceTextLinesITCase.testContinuousTextFileSource failed

2020-09-22 Thread Dian Fu (Jira)
Dian Fu created FLINK-19370: --- Summary: FileSourceTextLinesITCase.testContinuousTextFileSource failed Key: FLINK-19370 URL: https://issues.apache.org/jira/browse/FLINK-19370 Project: Flink Issue Ty

[GitHub] [flink] shuiqiangchen commented on pull request #13327: [FLINK-19134][python] Add BasicArrayTypeInfo and coder for PrimitiveArrayTypeInfo for Python DataStream API.

2020-09-22 Thread GitBox
shuiqiangchen commented on pull request #13327: URL: https://github.com/apache/flink/pull/13327#issuecomment-697165122 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [flink] Jiayi-Liao commented on pull request #13412: [FLINK-19069] execute finalizeOnMaster with io executor to avoid hea…

2020-09-22 Thread GitBox
Jiayi-Liao commented on pull request #13412: URL: https://github.com/apache/flink/pull/13412#issuecomment-697164743 @rmetzger The test fails because we don't use a real `executor` as the `jobMasterMainThreadExecutor`, see #ComponentMainThreadExecutorServiceAdapter#forMainThread(), which me

[jira] [Commented] (FLINK-19291) Meeting `SchemaParseException` when use `AvroSchemaConverter` converts flink logical type

2020-09-22 Thread xiaozilong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200596#comment-17200596 ] xiaozilong commented on FLINK-19291: okay:D > Meeting `SchemaParseException` when u

[GitHub] [flink] flinkbot edited a comment on pull request #13327: [FLINK-19134][python] Add BasicArrayTypeInfo and coder for PrimitiveArrayTypeInfo for Python DataStream API.

2020-09-22 Thread GitBox
flinkbot edited a comment on pull request #13327: URL: https://github.com/apache/flink/pull/13327#issuecomment-687006937 ## CI report: * 2684468e6cc397456950f4fdada171cbbe6730a9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #13459: [FLINK-18199] [chinese-translation]: translate FileSystem SQL Connector page into Chinese

2020-09-22 Thread GitBox
flinkbot edited a comment on pull request #13459: URL: https://github.com/apache/flink/pull/13459#issuecomment-697158140 ## CI report: * a3e5590fcd9193b1699c4539cf93aa175b14d829 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #11359: [FLINK-16095] [docs-zh] Translate "Modules" page of "Table API & SQL" into Chinese

2020-09-22 Thread GitBox
flinkbot edited a comment on pull request #11359: URL: https://github.com/apache/flink/pull/11359#issuecomment-596916485 ## CI report: * a42e8d680a2a0d344a0ffda29c2891627f7d1e2d Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/170635599) Azure: [FAILURE](http

[jira] [Created] (FLINK-19369) BlobClientTest.testGetFailsDuringStreamingForJobPermanentBlob hangs

2020-09-22 Thread Dian Fu (Jira)
Dian Fu created FLINK-19369: --- Summary: BlobClientTest.testGetFailsDuringStreamingForJobPermanentBlob hangs Key: FLINK-19369 URL: https://issues.apache.org/jira/browse/FLINK-19369 Project: Flink Is

[jira] [Updated] (FLINK-19369) BlobClientTest.testGetFailsDuringStreamingForJobPermanentBlob hangs

2020-09-22 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-19369: Component/s: Tests > BlobClientTest.testGetFailsDuringStreamingForJobPermanentBlob hangs > ---

[jira] [Updated] (FLINK-19369) BlobClientTest.testGetFailsDuringStreamingForJobPermanentBlob hangs

2020-09-22 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-19369: Labels: test-stability (was: ) > BlobClientTest.testGetFailsDuringStreamingForJobPermanentBlob hangs > --

[jira] [Updated] (FLINK-19268) Introduce batch-style execution for bounded keyed streams

2020-09-22 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz updated FLINK-19268: - Summary: Introduce batch-style execution for bounded keyed streams (was: Introduce boun

[GitHub] [flink] flinkbot commented on pull request #13459: [FLINK-18199] [chinese-translation]: translate FileSystem SQL Connector page into Chinese

2020-09-22 Thread GitBox
flinkbot commented on pull request #13459: URL: https://github.com/apache/flink/pull/13459#issuecomment-697158140 ## CI report: * a3e5590fcd9193b1699c4539cf93aa175b14d829 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[jira] [Commented] (FLINK-17793) Replace TableSchema with dedicated CatalogSchema

2020-09-22 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200587#comment-17200587 ] Jark Wu commented on FLINK-17793: - Hi [~twalthr], I'm currently busy working on another

[GitHub] [flink] flinkbot edited a comment on pull request #11359: [FLINK-16095] [docs-zh] Translate "Modules" page of "Table API & SQL" into Chinese

2020-09-22 Thread GitBox
flinkbot edited a comment on pull request #11359: URL: https://github.com/apache/flink/pull/11359#issuecomment-596916485 ## CI report: * a42e8d680a2a0d344a0ffda29c2891627f7d1e2d Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/170635599) Azure: [FAILURE](http

[GitHub] [flink] flinkbot edited a comment on pull request #13451: [FLINK-19333][python] Introduce BatchArrowPythonOverWindowAggregateFunctionOperator

2020-09-22 Thread GitBox
flinkbot edited a comment on pull request #13451: URL: https://github.com/apache/flink/pull/13451#issuecomment-696565311 ## CI report: * cb9329281ad618abbd1c75a1922e038a0869944e Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] flinkbot commented on pull request #13459: [FLINK-18199] [chinese-translation]: translate FileSystem SQL Connector page into Chinese

2020-09-22 Thread GitBox
flinkbot commented on pull request #13459: URL: https://github.com/apache/flink/pull/13459#issuecomment-697149813 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[GitHub] [flink] flinkbot edited a comment on pull request #11359: [FLINK-16095] [docs-zh] Translate "Modules" page of "Table API & SQL" into Chinese

2020-09-22 Thread GitBox
flinkbot edited a comment on pull request #11359: URL: https://github.com/apache/flink/pull/11359#issuecomment-596916485 ## CI report: * a42e8d680a2a0d344a0ffda29c2891627f7d1e2d Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/170635599) Azure: [FAILURE](http

[jira] [Updated] (FLINK-18199) Translate "Filesystem SQL Connector" page into Chinese

2020-09-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-18199: --- Labels: pull-request-available (was: ) > Translate "Filesystem SQL Connector" page into Chi

[GitHub] [flink] michaelli916 opened a new pull request #13459: [FLINK-18199] [chinese-translation]: translate FileSystem SQL Connector page into Chinese

2020-09-22 Thread GitBox
michaelli916 opened a new pull request #13459: URL: https://github.com/apache/flink/pull/13459 ## What is the purpose of the change *Translate "Filesystem SQL Connector" page into Chinese* ## Brief change log *Translate "Filesystem SQL Connector" page into Ch

[GitHub] [flink] flinkbot edited a comment on pull request #13451: [FLINK-19333][python] Introduce BatchArrowPythonOverWindowAggregateFunctionOperator

2020-09-22 Thread GitBox
flinkbot edited a comment on pull request #13451: URL: https://github.com/apache/flink/pull/13451#issuecomment-696565311 ## CI report: * e682b70e2b68e60ed3950290b1ebe53a6ecd40d8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] danny0405 commented on pull request #13033: [FLINK-18777][catalog] Supports schema registry catalog

2020-09-22 Thread GitBox
danny0405 commented on pull request #13033: URL: https://github.com/apache/flink/pull/13033#issuecomment-697103132 @maver1ck The code seems straight-forward, @dawidwys said that he would like to review this PR, but i'm not sure if he has time. -

[GitHub] [flink] wuchong closed pull request #9356: [FLINK-13340][kafka][table] Add 'topics' and 'subscriptionPattern' option for Flink Kafka connector

2020-09-22 Thread GitBox
wuchong closed pull request #9356: URL: https://github.com/apache/flink/pull/9356 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [flink] HuangXingBo commented on pull request #13451: [FLINK-19333][python] Introduce BatchArrowPythonOverWindowAggregateFunctionOperator

2020-09-22 Thread GitBox
HuangXingBo commented on pull request #13451: URL: https://github.com/apache/flink/pull/13451#issuecomment-697073756 @dianfu Thanks a lot for the update. I have addressed the comments at the latest commit. This is an automat

[GitHub] [flink] lirui-apache commented on pull request #13455: [FLINK-19361][hive] Create a synchronized metastore client to talk to…

2020-09-22 Thread GitBox
lirui-apache commented on pull request #13455: URL: https://github.com/apache/flink/pull/13455#issuecomment-697115923 @JingsongLi Thanks for the review. I have verified tests with Hive-1.0.1 This is an automated message from

[GitHub] [flink] wuchong commented on pull request #10354: [FLINK-14729][connectors] Multi-topics consuming from KafkaTableSource

2020-09-22 Thread GitBox
wuchong commented on pull request #10354: URL: https://github.com/apache/flink/pull/10354#issuecomment-697100110 Sorry for late replying and not noticing this PR. The multi-topic (topic list and topic pattern) for SQL connector has been supported in FLINK-18449. How about to close t

[GitHub] [flink] leonardBang commented on pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join

2020-09-22 Thread GitBox
leonardBang commented on pull request #13289: URL: https://github.com/apache/flink/pull/13289#issuecomment-697081273 > The compile is failed, please fix it first. > > ``` > FlinkPlannerImpl.scala message=File line length exceeds 100 characters line=168 > ``` I've fixed a

[GitHub] [flink] Shawn-Hx commented on pull request #13410: [FLINK-19247][docs-zh] Update Chinese documentation after removal of Kafka 0.10 and 0.11

2020-09-22 Thread GitBox
Shawn-Hx commented on pull request #13410: URL: https://github.com/apache/flink/pull/13410#issuecomment-697080083 Hi, @klion26 This PR is ready to be reviewed. Could you help to review it at your convenience? Thanks~

[GitHub] [flink] wsry commented on a change in pull request #13447: [FLINK-19297][network] Make ResultPartitionWriter record-oriented

2020-09-22 Thread GitBox
wsry commented on a change in pull request #13447: URL: https://github.com/apache/flink/pull/13447#discussion_r493159836 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/BoundedBlockingResultPartition.java ## @@ -63,6 +63,22 @@ public Bou

[GitHub] [flink-playgrounds] shuiqiangchen commented on pull request #16: [FLINK-19145][walkthroughs] Add PyFlink-walkthrough to Flink playground.

2020-09-22 Thread GitBox
shuiqiangchen commented on pull request #16: URL: https://github.com/apache/flink-playgrounds/pull/16#issuecomment-697071304 @alpinegizmo Thank you for polishing the doc, I have updated the PR, please have a look. This is an

[GitHub] [flink] flinkbot edited a comment on pull request #11896: [FLINK-14356] [single-value] Introduce "single-value" format to (de)serialize message to a single field

2020-09-22 Thread GitBox
flinkbot edited a comment on pull request #11896: URL: https://github.com/apache/flink/pull/11896#issuecomment-618808279 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [flink] wuchong merged pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join

2020-09-22 Thread GitBox
wuchong merged pull request #13289: URL: https://github.com/apache/flink/pull/13289 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink-statefun] galenwarren commented on pull request #152: [FLINK-19176] Add pluggable statefun payload serializer

2020-09-22 Thread GitBox
galenwarren commented on pull request #152: URL: https://github.com/apache/flink-statefun/pull/152#issuecomment-696388005 @igalshilman Thanks! I'll take a look at the others shortly, but wanted to quickly reply regarding the question about Optional and the serialized snapshot format

[GitHub] [flink] flinkbot edited a comment on pull request #13447: [FLINK-19297][network] Make ResultPartitionWriter record-oriented

2020-09-22 Thread GitBox
flinkbot edited a comment on pull request #13447: URL: https://github.com/apache/flink/pull/13447#issuecomment-696488834 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [flink] JingsongLi merged pull request #13455: [FLINK-19361][hive] Create a synchronized metastore client to talk to…

2020-09-22 Thread GitBox
JingsongLi merged pull request #13455: URL: https://github.com/apache/flink/pull/13455 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] JingsongLi merged pull request #13414: [FLINK-19227][Table SQL / API] The catalog is still created after opening failed in catalog registering

2020-09-22 Thread GitBox
JingsongLi merged pull request #13414: URL: https://github.com/apache/flink/pull/13414 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] wuchong commented on pull request #9356: [FLINK-13340][kafka][table] Add 'topics' and 'subscriptionPattern' option for Flink Kafka connector

2020-09-22 Thread GitBox
wuchong commented on pull request #9356: URL: https://github.com/apache/flink/pull/9356#issuecomment-697100549 Close this as it has been supported in FLINK-18449. This is an automated message from the Apache Git Service. To r

[GitHub] [flink] flinkbot edited a comment on pull request #13419: [FLINK-18842][e2e] Added 10min timeout to building the container.

2020-09-22 Thread GitBox
flinkbot edited a comment on pull request #13419: URL: https://github.com/apache/flink/pull/13419#issuecomment-694745717 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [flink] flinkbot edited a comment on pull request #13406: [FLINK-19243][elasticsearch] Bump snakeyaml to 1.27

2020-09-22 Thread GitBox
flinkbot edited a comment on pull request #13406: URL: https://github.com/apache/flink/pull/13406#issuecomment-694116951 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [flink] xintongsong commented on pull request #13453: [FLINK-19311][coordination] Add ResourceRequirement(s)

2020-09-22 Thread GitBox
xintongsong commented on pull request #13453: URL: https://github.com/apache/flink/pull/13453#issuecomment-696625955 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] zentol commented on a change in pull request #13419: [FLINK-18842][e2e] Added 10min timeout to building the container.

2020-09-22 Thread GitBox
zentol commented on a change in pull request #13419: URL: https://github.com/apache/flink/pull/13419#discussion_r492588052 ## File path: flink-end-to-end-tests/test-scripts/common.sh ## @@ -830,3 +830,30 @@ run_test_with_timeout() { $TEST_COMMAND ) } + +run_with_time

[GitHub] [flink-statefun] tzulitai closed pull request #159: [FLINK-19330][core] Move intialization logic to open() instead initializeState

2020-09-22 Thread GitBox
tzulitai closed pull request #159: URL: https://github.com/apache/flink-statefun/pull/159 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink-statefun] tzulitai closed pull request #157: [FLINK-19327][k8s] Bump JobManager heap size to 1 GB

2020-09-22 Thread GitBox
tzulitai closed pull request #157: URL: https://github.com/apache/flink-statefun/pull/157 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] flinkbot edited a comment on pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

2020-09-22 Thread GitBox
flinkbot edited a comment on pull request #13228: URL: https://github.com/apache/flink/pull/13228#issuecomment-679099456 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [flink] flinkbot edited a comment on pull request #13420: [FLINK-19229][python] Introduce the PythonStreamGroupAggregateOperator for Python UDAF.

2020-09-22 Thread GitBox
flinkbot edited a comment on pull request #13420: URL: https://github.com/apache/flink/pull/13420#issuecomment-694793326 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [flink] xintongsong edited a comment on pull request #13453: [FLINK-19311][coordination] Add ResourceRequirement(s)

2020-09-22 Thread GitBox
xintongsong edited a comment on pull request #13453: URL: https://github.com/apache/flink/pull/13453#issuecomment-696625955 Chime in with a minor comment: > The Serial Version UID for new classes should start at 1. Suggested by the code style guidelines. https://flink.apache.or

[GitHub] [flink] dawidwys edited a comment on pull request #13450: [FLINK-19339] Support unions with logical types in Avro >= 1.9.x

2020-09-22 Thread GitBox
dawidwys edited a comment on pull request #13450: URL: https://github.com/apache/flink/pull/13450#issuecomment-696655915 It is relevant for `AvroSerializer` (which I updated through `AvroFactory#fromSpecific` and added a test for it: `AvroUnionLogicalSerializerTest.java`). I checked

[GitHub] [flink] flinkbot commented on pull request #13456: Single task add partial flag in buffer

2020-09-22 Thread GitBox
flinkbot commented on pull request #13456: URL: https://github.com/apache/flink/pull/13456#issuecomment-696739793 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] kl0u commented on a change in pull request #13423: [FLINK-19269] Make the PushingAsyncDataInput.DataOutput aware of endOfInput

2020-09-22 Thread GitBox
kl0u commented on a change in pull request #13423: URL: https://github.com/apache/flink/pull/13423#discussion_r492589663 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractInput.java ## @@ -68,4 +68,13 @@ public void processLatenc

[GitHub] [flink-statefun] tzulitai closed pull request #158: [FLINK-19329] FunctionGroupOperator#dispose() might throw NPE during an unclean shutdown.

2020-09-22 Thread GitBox
tzulitai closed pull request #158: URL: https://github.com/apache/flink-statefun/pull/158 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] twalthr commented on pull request #13430: [BP-1.11][FLINK-19140] Fix UDTF documentation which uses wrong alias

2020-09-22 Thread GitBox
twalthr commented on pull request #13430: URL: https://github.com/apache/flink/pull/13430#issuecomment-696769329 Merged into 1.11 branch. This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [flink] aljoscha commented on pull request #8207: [FLINK-12250] Rewrite assembleNewPartPath to let it return a new PartPath

2020-09-22 Thread GitBox
aljoscha commented on pull request #8207: URL: https://github.com/apache/flink/pull/8207#issuecomment-696772477 This actually looks like a good fix. I rebased, will run CI and then merge. This is an automated message from the

[GitHub] [flink] kottmann commented on pull request #13457: [FLINK-8357] Use rolling logs as default

2020-09-22 Thread GitBox
kottmann commented on pull request #13457: URL: https://github.com/apache/flink/pull/13457#issuecomment-697013989 Things to be considered - Any opinions about the file size? What is a good size? - The max number of files could be set - OnStartupTriggeringPolicy can be used to replac

[GitHub] [flink-statefun] tzulitai commented on pull request #158: [FLINK-19329] FunctionGroupOperator#dispose() might throw NPE during an unclean shutdown.

2020-09-22 Thread GitBox
tzulitai commented on pull request #158: URL: https://github.com/apache/flink-statefun/pull/158#issuecomment-696548606 LGTM, +1 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [flink-statefun] tzulitai closed pull request #160: [hotfix][dockerfile] Add newline to end of flink-conf

2020-09-22 Thread GitBox
tzulitai closed pull request #160: URL: https://github.com/apache/flink-statefun/pull/160 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] StephanEwen commented on a change in pull request #13447: [FLINK-19297][network] Make ResultPartitionWriter record-oriented

2020-09-22 Thread GitBox
StephanEwen commented on a change in pull request #13447: URL: https://github.com/apache/flink/pull/13447#discussion_r492720319 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/RecordWriter.java ## @@ -109,89 +94,58 @@ }

[GitHub] [flink] flinkbot commented on pull request #13448: [FLINK-19289][k8s] Remove pods terminated during JM failover.

2020-09-22 Thread GitBox
flinkbot commented on pull request #13448: URL: https://github.com/apache/flink/pull/13448#issuecomment-696493031 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] flinkbot edited a comment on pull request #13128: [FLINK-18795][hbase] Support for HBase 2

2020-09-22 Thread GitBox
flinkbot edited a comment on pull request #13128: URL: https://github.com/apache/flink/pull/13128#issuecomment-672766836 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [flink-statefun] galenwarren commented on a change in pull request #152: [FLINK-19176] Add pluggable statefun payload serializer

2020-09-22 Thread GitBox
galenwarren commented on a change in pull request #152: URL: https://github.com/apache/flink-statefun/pull/152#discussion_r492357429 ## File path: statefun-flink/statefun-flink-core/src/main/java/org/apache/flink/statefun/flink/core/StatefulFunctionsConfigValidator.java ## @@

[GitHub] [flink] zentol commented on pull request #13453: [FLINK-19311][coordination] Add ResourceRequirement(s)

2020-09-22 Thread GitBox
zentol commented on pull request #13453: URL: https://github.com/apache/flink/pull/13453#issuecomment-696681873 @xintongsong Do you know by chance how to setup IntelliJ to use 1 as the default UID? This is an automated messa

[GitHub] [flink] rmetzger merged pull request #13409: [FLINK-17910][e2e] Fix debug log output to investigate rare test failure

2020-09-22 Thread GitBox
rmetzger merged pull request #13409: URL: https://github.com/apache/flink/pull/13409 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] echauchot commented on a change in pull request #13040: [FLINK-17073] [checkpointing] checkpointing backpressure if there are too many checkpoints to clean

2020-09-22 Thread GitBox
echauchot commented on a change in pull request #13040: URL: https://github.com/apache/flink/pull/13040#discussion_r492597386 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointsCleaner.java ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apach

[GitHub] [flink-statefun] sjwiesman commented on pull request #159: [FLINK-19330][core] Move intialization logic to open() instead initializeState

2020-09-22 Thread GitBox
sjwiesman commented on pull request #159: URL: https://github.com/apache/flink-statefun/pull/159#issuecomment-696412736 Out of scope for this PR but based on our offline conversation today it seems like there should be a remote e2e test with TM failures --

[GitHub] [flink] twalthr closed pull request #13425: [FLINK-19272][table-common] Add metadata interfaces for FLIP-107

2020-09-22 Thread GitBox
twalthr closed pull request #13425: URL: https://github.com/apache/flink/pull/13425 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink-statefun] igalshilman commented on a change in pull request #152: [FLINK-19176] Add pluggable statefun payload serializer

2020-09-22 Thread GitBox
igalshilman commented on a change in pull request #152: URL: https://github.com/apache/flink-statefun/pull/152#discussion_r492318196 ## File path: statefun-flink/statefun-flink-core/src/main/java/org/apache/flink/statefun/flink/core/message/MessageFactoryKey.java ## @@ -0,0 +1

[GitHub] [flink] wuchong commented on pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join

2020-09-22 Thread GitBox
wuchong commented on pull request #13289: URL: https://github.com/apache/flink/pull/13289#issuecomment-696662161 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] flinkbot commented on pull request #13447: [FLINK-19297][network] Make ResultPartitionWriter record-oriented

2020-09-22 Thread GitBox
flinkbot commented on pull request #13447: URL: https://github.com/apache/flink/pull/13447#issuecomment-696485547 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] dawidwys commented on pull request #13423: [FLINK-19269] Make the PushingAsyncDataInput.DataOutput aware of endOfInput

2020-09-22 Thread GitBox
dawidwys commented on pull request #13423: URL: https://github.com/apache/flink/pull/13423#issuecomment-696628108 Hi @pnowojski could you take a look at the changes, as it touches some of the streaming runtime parts? Or maybe you could ask somebody else that works on the streaming runtime

[GitHub] [flink] wuchong merged pull request #13442: [FLINK-19321][Table SQL / Runtime]CollectSinkFunction does not define serialVersionUID

2020-09-22 Thread GitBox
wuchong merged pull request #13442: URL: https://github.com/apache/flink/pull/13442 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] zentol commented on a change in pull request #13438: [FLINK-19014][e2e] Increase startup timeout

2020-09-22 Thread GitBox
zentol commented on a change in pull request #13438: URL: https://github.com/apache/flink/pull/13438#discussion_r492515807 ## File path: flink-dist/src/main/flink-bin/bin/flink-daemon.sh ## @@ -88,15 +88,6 @@ out="${FLINK_LOG_PREFIX}.out" log_setting=("-Dlog.file=${log}" "-

[GitHub] [flink] flinkbot commented on pull request #13453: [FLINK-19311][coordination] Add ResourceRequirement(s)

2020-09-22 Thread GitBox
flinkbot commented on pull request #13453: URL: https://github.com/apache/flink/pull/13453#issuecomment-696608065 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] twalthr commented on pull request #10354: [FLINK-14729][connectors] Multi-topics consuming from KafkaTableSource

2020-09-22 Thread GitBox
twalthr commented on pull request #10354: URL: https://github.com/apache/flink/pull/10354#issuecomment-696785659 @fangpengcheng95 Sorry, for replying so late to this PR. I think the changes make sense. However, we have a new table source architecture after FLIP-95. Do you think you have ti

[GitHub] [flink] wuchong commented on pull request #13332: [FLINK-19128][sql-client] Remove the runtime execution configuration in sql-client-defaults.yaml

2020-09-22 Thread GitBox
wuchong commented on pull request #13332: URL: https://github.com/apache/flink/pull/13332#issuecomment-696672677 Thanks @twalthr , will merge this then. This is an automated message from the Apache Git Service. To respond t

[GitHub] [flink] azagrebin commented on a change in pull request #13316: [FLINK-14422][runtime] Expose network memory usage to TaskManagerDetailsHandler's endpoint

2020-09-22 Thread GitBox
azagrebin commented on a change in pull request #13316: URL: https://github.com/apache/flink/pull/13316#discussion_r492749100 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/taskmanager/TaskManagerMetricsInfo.java ## @@ -206,9 +301,9 @@ public

[GitHub] [flink] rkhachatryan commented on a change in pull request #13040: [FLINK-17073] [checkpointing] checkpointing backpressure if there are too many checkpoints to clean

2020-09-22 Thread GitBox
rkhachatryan commented on a change in pull request #13040: URL: https://github.com/apache/flink/pull/13040#discussion_r492606259 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointsCleaner.java ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Ap

[GitHub] [flink] lirui-apache commented on a change in pull request #13434: [FLINK-19292][hive] HiveCatalog should support specifying Hadoop conf dir with configuration

2020-09-22 Thread GitBox
lirui-apache commented on a change in pull request #13434: URL: https://github.com/apache/flink/pull/13434#discussion_r492720329 ## File path: flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/factories/HiveCatalogFactoryTest.java ## @@ -5

[GitHub] [flink] flinkbot edited a comment on pull request #13445: [FLINK-19331][state-processor-api] Native resource leak when working with RocksDB

2020-09-22 Thread GitBox
flinkbot edited a comment on pull request #13445: URL: https://github.com/apache/flink/pull/13445#issuecomment-696389960 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [flink-statefun] tzulitai commented on pull request #157: [FLINK-19327][k8s] Bump JobManager heap size to 1 GB

2020-09-22 Thread GitBox
tzulitai commented on pull request #157: URL: https://github.com/apache/flink-statefun/pull/157#issuecomment-696560584 Merging ... This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [flink] carp84 commented on a change in pull request #13405: [FLINK-19270] Extract an inteface from AbstractKeyedStateBackend

2020-09-22 Thread GitBox
carp84 commented on a change in pull request #13405: URL: https://github.com/apache/flink/pull/13405#discussion_r492641148 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamOperatorStateHandler.java ## @@ -282,8 +283,8 @@ public vo

[GitHub] [flink] flinkbot edited a comment on pull request #13452: [FLINK-19273][sql-parser] Support METADATA syntax in SQL parser

2020-09-22 Thread GitBox
flinkbot edited a comment on pull request #13452: URL: https://github.com/apache/flink/pull/13452#issuecomment-696611770 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [flink] flinkbot edited a comment on pull request #13450: [FLINK-19339] Support unions with logical types in Avro >= 1.9.x

2020-09-22 Thread GitBox
flinkbot edited a comment on pull request #13450: URL: https://github.com/apache/flink/pull/13450#issuecomment-696552930 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [flink] XComp commented on a change in pull request #13453: [FLINK-19311][coordination] Add ResourceRequirement(s)

2020-09-22 Thread GitBox
XComp commented on a change in pull request #13453: URL: https://github.com/apache/flink/pull/13453#discussion_r492673612 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/slots/ResourceRequirement.java ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [flink] rmetzger commented on a change in pull request #13438: [FLINK-19014][e2e] Increase startup timeout

2020-09-22 Thread GitBox
rmetzger commented on a change in pull request #13438: URL: https://github.com/apache/flink/pull/13438#discussion_r492646461 ## File path: flink-dist/src/main/flink-bin/bin/flink-daemon.sh ## @@ -88,15 +88,6 @@ out="${FLINK_LOG_PREFIX}.out" log_setting=("-Dlog.file=${log}"

[GitHub] [flink] flinkbot commented on pull request #13455: [FLINK-19361][hive] Create a synchronized metastore client to talk to…

2020-09-22 Thread GitBox
flinkbot commented on pull request #13455: URL: https://github.com/apache/flink/pull/13455#issuecomment-696719238 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] flinkbot edited a comment on pull request #13457: [FLINK-8357] Use rolling logs as default

2020-09-22 Thread GitBox
flinkbot edited a comment on pull request #13457: URL: https://github.com/apache/flink/pull/13457#issuecomment-697012704 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [flink] flinkbot edited a comment on pull request #13289: [FLINK-18548][table-planner] support flexible syntax for Temporal table join

2020-09-22 Thread GitBox
flinkbot edited a comment on pull request #13289: URL: https://github.com/apache/flink/pull/13289#issuecomment-683894616 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [flink] leonardBang commented on pull request #13128: [FLINK-18795][hbase] Support for HBase 2

2020-09-22 Thread GitBox
leonardBang commented on pull request #13128: URL: https://github.com/apache/flink/pull/13128#issuecomment-696498920 One more tip, that's great if we could add e2e test for `hbase 2` just like kafka support multiple versions e2e test, we can keep `hbase 2` test once we decided to deprecate

  1   2   3   4   5   6   7   >