[GitHub] [flink] flinkbot edited a comment on pull request #14919: [FLINK-21338][test] Relax ITCase naming constraints

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14919: URL: https://github.com/apache/flink/pull/14919#issuecomment-776676702 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #14743: [FLINK-21366][doc] mentions Maxwell as CDC tool in Kafka connector documentation

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14743: URL: https://github.com/apache/flink/pull/14743#issuecomment-766411085 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #13912: [FLINK-19466][FLINK-19467][runtime / state backends] Add Flip-142 public interfaces and methods

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #13912: URL: https://github.com/apache/flink/pull/13912#issuecomment-721387578 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #14942: [FLINK-21377][coordination][tests] Make JobMaster QS tests pass with declarative scheduler

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14942: URL: https://github.com/apache/flink/pull/14942#issuecomment-779277958 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #14949: [FLINK-21384][docs] Automatically copy maven dependencies to clipboard on click

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14949: URL: https://github.com/apache/flink/pull/14949#issuecomment-780082194 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #14284: [FLINK-20324] Added Configuration mount support

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14284: URL: https://github.com/apache/flink/pull/14284#issuecomment-736661194 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #14265: FLINK-15649 and FLINK-20359. Adding Volume and Configuration Mount decorators and Owner reference

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14265: URL: https://github.com/apache/flink/pull/14265#issuecomment-736166155 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #14953: [FLINK-21351][checkpointing] Don't subsume last checkpoint

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14953: URL: https://github.com/apache/flink/pull/14953#issuecomment-780745633 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #14958: [FLINK-18550][sql-client] use TableResult#collect to get select result for sql client

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14958: URL: https://github.com/apache/flink/pull/14958#issuecomment-781095248 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #14822: [FLINK-21005][table-api] Introduce new provider for unified Sink API and implement in planner

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14822: URL: https://github.com/apache/flink/pull/14822#issuecomment-770392199 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #14084: [FLINK-15867][table-planner-blink] Support time-related types for FIRST_VALUE and LAST_VALUE aggregate functions

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14084: URL: https://github.com/apache/flink/pull/14084#issuecomment-728287751 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #14835: [FLINK-21213][task] Degrade log level to INFO when ignore to decline checkpoint as task not running

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14835: URL: https://github.com/apache/flink/pull/14835#issuecomment-771610358 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #14916: [FLINK-21345][Table SQL / Planner] Fix BUG of Union All join Temporal…

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14916: URL: https://github.com/apache/flink/pull/14916#issuecomment-776602074 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14847: URL: https://github.com/apache/flink/pull/14847#issuecomment-772363532 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #14838: [FLINK-19503][state] Add StateChangelog API

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14838: URL: https://github.com/apache/flink/pull/14838#issuecomment-772050707 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #14964: [FLINK-21410][docs] Document checkpoint interval trade-offs

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14964: URL: https://github.com/apache/flink/pull/14964#issuecomment-781635100 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14798: URL: https://github.com/apache/flink/pull/14798#issuecomment-769218666 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #14897: [FLINK-21221][runtime] Deduplication for multiple ResourceCounters

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14897: URL: https://github.com/apache/flink/pull/14897#issuecomment-775027203 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #14951: [FLINK-21380][coordination] Hide terminal ExecutionGraph in StateWithExecutionGraph

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14951: URL: https://github.com/apache/flink/pull/14951#issuecomment-780564498 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #14928: [FLINK-21360][coordination] Make resource timeout configurable

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14928: URL: https://github.com/apache/flink/pull/14928#issuecomment-06506 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #14950: [FLINK-21347][coordination] Extract interface from ExecutionGraph

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14950: URL: https://github.com/apache/flink/pull/14950#issuecomment-780426957 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #14944: [FLINK-21297] Support 'LOAD/UNLOAD MODULE' syntax

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14944: URL: https://github.com/apache/flink/pull/14944#issuecomment-779311077 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] rmetzger commented on a change in pull request #14963: [FLINK-21362][coordination] Move State.onEnter() logic into constructor

2021-02-18 Thread GitBox
rmetzger commented on a change in pull request #14963: URL: https://github.com/apache/flink/pull/14963#discussion_r578983459 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/declarative/DeclarativeScheduler.java ## @@ -907,20 +909,37 @@ public void

[GitHub] [flink] XComp commented on a change in pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-02-18 Thread GitBox
XComp commented on a change in pull request #14798: URL: https://github.com/apache/flink/pull/14798#discussion_r578786368 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -635,6 +641,33 @@ public void cancel() { ret

[GitHub] [flink] rmetzger commented on a change in pull request #14950: [FLINK-21347][coordination] Extract interface from ExecutionGraph

2021-02-18 Thread GitBox
rmetzger commented on a change in pull request #14950: URL: https://github.com/apache/flink/pull/14950#discussion_r578985387 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/declarative/StateTrackingMockExecutionGraph.java ## @@ -0,0 +1,459 @@ +/* +

[GitHub] [flink] rmetzger commented on a change in pull request #14950: [FLINK-21347][coordination] Extract interface from ExecutionGraph

2021-02-18 Thread GitBox
rmetzger commented on a change in pull request #14950: URL: https://github.com/apache/flink/pull/14950#discussion_r578985730 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/declarative/StateTrackingMockExecutionGraph.java ## @@ -0,0 +1,459 @@ +/* +

[jira] [Commented] (FLINK-21220) Change the type of cpuCores in ResourceProfile to CPUResource

2021-02-18 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17286908#comment-17286908 ] Yangze Guo commented on FLINK-21220: [~chesnay] I think it has the following benefit

[jira] [Commented] (FLINK-16444) Count the read/write/seek/next latency of RocksDB as metrics

2021-02-18 Thread Yu Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17286910#comment-17286910 ] Yu Li commented on FLINK-16444: --- After some more investigation, the metrics we plan to add

<    1   2   3   4   5