[GitHub] [flink] flinkbot commented on pull request #15367: [hotfix][doc] fix Image rendering error in dynamic_tables.md

2021-03-24 Thread GitBox
flinkbot commented on pull request #15367: URL: https://github.com/apache/flink/pull/15367#issuecomment-806408206 ## CI report: * ac22ed8671e9d4177a4506f3a42e9b1c1f36dbfa UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] flinkbot edited a comment on pull request #15362: [FLINK-21939][python] Support batch mode in Python DataStream API for process operation and reduce operation

2021-03-24 Thread GitBox
flinkbot edited a comment on pull request #15362: URL: https://github.com/apache/flink/pull/15362#issuecomment-805817140 ## CI report: * f65f9751b0e4a78d617f3c5a6d483d73580cfe0d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15332: [FLINK-21701][sql-client] Extend the "RESET" syntax in the SQL Client

2021-03-24 Thread GitBox
flinkbot edited a comment on pull request #15332: URL: https://github.com/apache/flink/pull/15332#issuecomment-804297721 ## CI report: * f42ce79779ba1596232890890122d0ac14428c23 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15265: [FLINK-21836][table-api] Introduce ParseStrategyParser

2021-03-24 Thread GitBox
flinkbot edited a comment on pull request #15265: URL: https://github.com/apache/flink/pull/15265#issuecomment-801879922 ## CI report: * afd793076a5c702aabc57198919019985529970e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] wsry commented on a change in pull request #13924: [FLINK-19938][network] Implement shuffle data read scheduling for sort-merge blocking shuffle

2021-03-24 Thread GitBox
wsry commented on a change in pull request #13924: URL: https://github.com/apache/flink/pull/13924#discussion_r601110625 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SortMergeResultPartition.java ## @@ -405,13 +413,8 @@ public ResultS

[GitHub] [flink] flinkbot edited a comment on pull request #15161: [FLINK-20114][connector/kafka,common] Fix a few KafkaSource-related bugs

2021-03-24 Thread GitBox
flinkbot edited a comment on pull request #15161: URL: https://github.com/apache/flink/pull/15161#issuecomment-797177953 ## CI report: * d3f59e302b9860d49ce79252aeb8bd1decaeeabf UNKNOWN * c58bb5faec3f07e0b66d0e042e3e9c6082fb8e9c Azure: [SUCCESS](https://dev.azure.com/apache-fl

[GitHub] [flink] Myasuka commented on pull request #15119: [FLINK-21736][state] Introduce state scope latency tracking metrics

2021-03-24 Thread GitBox
Myasuka commented on pull request #15119: URL: https://github.com/apache/flink/pull/15119#issuecomment-806406888 Unfortunately, changing the histogram implementation from `com.codahale.metrics.Histogram + SlidingTimeWindowReservoir` to `DescriptiveStatisticsHistogram + CircularDoubleArray`

[GitHub] [flink] flinkbot commented on pull request #15367: [hotfix][doc] fix Image rendering error in dynamic_tables.md

2021-03-24 Thread GitBox
flinkbot commented on pull request #15367: URL: https://github.com/apache/flink/pull/15367#issuecomment-806402031 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[GitHub] [flink] leonardBang commented on a change in pull request #15303: [FLINK-21713][table-api/table-planner] Correct function CURRENT_TIMESTAMP/CURRENT_TIME/CURRENT_DATE/NOW/LOCALTIME/LOCALTIMEST

2021-03-24 Thread GitBox
leonardBang commented on a change in pull request #15303: URL: https://github.com/apache/flink/pull/15303#discussion_r601100038 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/CodeGeneratorContext.scala ## @@ -481,6 +51

[GitHub] [flink] zhoulii opened a new pull request #15367: [hotfix][doc] fix Image rendering error in dynamic_tables.md

2021-03-24 Thread GitBox
zhoulii opened a new pull request #15367: URL: https://github.com/apache/flink/pull/15367 ## What is the purpose of the change fix [Image](https://ci.apache.org/projects/flink/flink-docs-master/docs/dev/table/concepts/dynamic_tables/#table-to-stream-conversion) rendering error.

[GitHub] [flink] flinkbot edited a comment on pull request #15366: Sql file

2021-03-24 Thread GitBox
flinkbot edited a comment on pull request #15366: URL: https://github.com/apache/flink/pull/15366#issuecomment-806388017 ## CI report: * c2cb1540e5d935c3c440c68f8883fe393504dee7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15365: [FLINK-21108][rest-client] Add basic & digest auth support to rest client

2021-03-24 Thread GitBox
flinkbot edited a comment on pull request #15365: URL: https://github.com/apache/flink/pull/15365#issuecomment-806387959 ## CI report: * 3441a04092840a70400afa3f8a087d5add4c2ba7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15362: [FLINK-21939][python] Support batch mode in Python DataStream API for process operation and reduce operation

2021-03-24 Thread GitBox
flinkbot edited a comment on pull request #15362: URL: https://github.com/apache/flink/pull/15362#issuecomment-805817140 ## CI report: * f65f9751b0e4a78d617f3c5a6d483d73580cfe0d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15339: [FLINK-21448] Randomize ITTests for delegating state backend

2021-03-24 Thread GitBox
flinkbot edited a comment on pull request #15339: URL: https://github.com/apache/flink/pull/15339#issuecomment-804687609 ## CI report: * 1fbc891a62624a340d1b4f6db8a4c4e6aaf0d649 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15332: [FLINK-21701][sql-client] Extend the "RESET" syntax in the SQL Client

2021-03-24 Thread GitBox
flinkbot edited a comment on pull request #15332: URL: https://github.com/apache/flink/pull/15332#issuecomment-804297721 ## CI report: * f42ce79779ba1596232890890122d0ac14428c23 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Closed] (FLINK-21076) Document how to use the declarative scheduler and its limitations

2021-03-24 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger closed FLINK-21076. -- Resolution: Fixed Resolved in https://github.com/apache/flink/commit/c9166223be8b4445df66

[GitHub] [flink] rmetzger closed pull request #15355: [FLINK-21076][docs] Add section about Adaptive Scheduler

2021-03-24 Thread GitBox
rmetzger closed pull request #15355: URL: https://github.com/apache/flink/pull/15355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [flink] rmetzger commented on pull request #15355: [FLINK-21076][docs] Add section about Adaptive Scheduler

2021-03-24 Thread GitBox
rmetzger commented on pull request #15355: URL: https://github.com/apache/flink/pull/15355#issuecomment-806397586 Thanks a lot for your review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Closed] (FLINK-21745) JobMasterTest.testReconnectionAfterDisconnect hangs on azure

2021-03-24 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger closed FLINK-21745. -- Fix Version/s: 1.13.0 Resolution: Fixed Resolved in https://github.com/apache/flink/co

[GitHub] [flink] rmetzger closed pull request #15262: [FLINK-21745][tests] Sets the parallelism in tests to comply to the AdaptiveScheduler requirements

2021-03-24 Thread GitBox
rmetzger closed pull request #15262: URL: https://github.com/apache/flink/pull/15262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[jira] [Updated] (FLINK-21969) PythonTimestampsAndWatermarksOperator emitted the Long.MAX_VALUE watermark before emitting all the data

2021-03-24 Thread Wei Zhong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei Zhong updated FLINK-21969: -- Component/s: API / Python > PythonTimestampsAndWatermarksOperator emitted the Long.MAX_VALUE watermark

[jira] [Created] (FLINK-21969) PythonTimestampsAndWatermarksOperator emitted the Long.MAX_VALUE watermark before emitting all the data

2021-03-24 Thread Wei Zhong (Jira)
Wei Zhong created FLINK-21969: - Summary: PythonTimestampsAndWatermarksOperator emitted the Long.MAX_VALUE watermark before emitting all the data Key: FLINK-21969 URL: https://issues.apache.org/jira/browse/FLINK-21969

[GitHub] [flink] flinkbot commented on pull request #15365: [FLINK-21108][rest-client] Add basic & digest auth support to rest client

2021-03-24 Thread GitBox
flinkbot commented on pull request #15365: URL: https://github.com/apache/flink/pull/15365#issuecomment-806387959 ## CI report: * 3441a04092840a70400afa3f8a087d5add4c2ba7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] flinkbot commented on pull request #15366: Sql file

2021-03-24 Thread GitBox
flinkbot commented on pull request #15366: URL: https://github.com/apache/flink/pull/15366#issuecomment-806388017 ## CI report: * c2cb1540e5d935c3c440c68f8883fe393504dee7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] flinkbot edited a comment on pull request #15362: [FLINK-21939][python] Support batch mode in Python DataStream API for process operation and reduce operation

2021-03-24 Thread GitBox
flinkbot edited a comment on pull request #15362: URL: https://github.com/apache/flink/pull/15362#issuecomment-805817140 ## CI report: * f65f9751b0e4a78d617f3c5a6d483d73580cfe0d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] sunxiaoguang commented on pull request #15365: [FLINK-21108][rest-client] Add basic & digest auth support to rest client

2021-03-24 Thread GitBox
sunxiaoguang commented on pull request #15365: URL: https://github.com/apache/flink/pull/15365#issuecomment-806385762 I'm working on unit tests recently, comments on design and implementation about this feature is welcome. Thanks -- This is an automated message from the Apache Git Serv

[jira] [Commented] (FLINK-21675) Push filter into the scan when watermark assigner is the parent of the table scan

2021-03-24 Thread Yuval Itzchakov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308396#comment-17308396 ] Yuval Itzchakov commented on FLINK-21675: - @Shengkai Fang Hey, would appreciate

[GitHub] [flink] flinkbot commented on pull request #15366: Sql file

2021-03-24 Thread GitBox
flinkbot commented on pull request #15366: URL: https://github.com/apache/flink/pull/15366#issuecomment-806382815 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[GitHub] [flink] wuchong commented on a change in pull request #15265: [FLINK-21836][table-api] Introduce ParseStrategyParser

2021-03-24 Thread GitBox
wuchong commented on a change in pull request #15265: URL: https://github.com/apache/flink/pull/15265#discussion_r601068115 ## File path: flink-table/flink-table-planner-blink/src/test/java/org/apache/flink/table/planner/delegation/ParserImplTest.java ## @@ -0,0 +1,166 @@ +/*

[GitHub] [flink] flinkbot commented on pull request #15365: [FLINK-21108][rest-client] Add basic & digest auth support to rest client

2021-03-24 Thread GitBox
flinkbot commented on pull request #15365: URL: https://github.com/apache/flink/pull/15365#issuecomment-806382094 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[GitHub] [flink] fsk119 opened a new pull request #15366: Sql file

2021-03-24 Thread GitBox
fsk119 opened a new pull request #15366: URL: https://github.com/apache/flink/pull/15366 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on

[GitHub] [flink] sunxiaoguang opened a new pull request #15365: [FLINK-21108][rest-client] Add basic & digest auth support to rest client

2021-03-24 Thread GitBox
sunxiaoguang opened a new pull request #15365: URL: https://github.com/apache/flink/pull/15365 Signed-off-by: Xiaoguang Sun ## What is the purpose of the change Implement Basic & Digest Auth scheme in rest-client so Flink rest-server can be protected behind a proxy with c

[GitHub] [flink] flinkbot edited a comment on pull request #15148: [FLINK-21731] Add benchmarks for DefaultScheduler's creation, scheduling and deploying

2021-03-24 Thread GitBox
flinkbot edited a comment on pull request #15148: URL: https://github.com/apache/flink/pull/15148#issuecomment-796572621 ## CI report: * cd1977e701621bdd1f827dce3f0b463b100958c0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink-statefun-playground] asfgit closed pull request #7: [FLINK-21932] Add Python SDK showcase

2021-03-24 Thread GitBox
asfgit closed pull request #7: URL: https://github.com/apache/flink-statefun-playground/pull/7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [flink] wsry commented on a change in pull request #13924: [FLINK-19938][network] Implement shuffle data read scheduling for sort-merge blocking shuffle

2021-03-24 Thread GitBox
wsry commented on a change in pull request #13924: URL: https://github.com/apache/flink/pull/13924#discussion_r601060222 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SortMergeSubpartitionReader.java ## @@ -176,21 +202,28 @@ public voi

[GitHub] [flink] wsry commented on a change in pull request #13924: [FLINK-19938][network] Implement shuffle data read scheduling for sort-merge blocking shuffle

2021-03-24 Thread GitBox
wsry commented on a change in pull request #13924: URL: https://github.com/apache/flink/pull/13924#discussion_r601057131 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SortMergeSubpartitionReader.java ## @@ -176,21 +202,28 @@ public voi

[GitHub] [flink] wsry commented on a change in pull request #13924: [FLINK-19938][network] Implement shuffle data read scheduling for sort-merge blocking shuffle

2021-03-24 Thread GitBox
wsry commented on a change in pull request #13924: URL: https://github.com/apache/flink/pull/13924#discussion_r601053647 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PartitionedFileReader.java ## @@ -61,104 +56,69 @@ /** Next dat

[GitHub] [flink] flinkbot edited a comment on pull request #15314: [FLINK-21332][runtime] Optimize releasing result partitions in RegionPartitionReleaseStrategy

2021-03-24 Thread GitBox
flinkbot edited a comment on pull request #15314: URL: https://github.com/apache/flink/pull/15314#issuecomment-803903444 ## CI report: * 7512eec2a3d84fb8211cf9b1161a25b7e8b8800e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink-statefun-playground] tzulitai commented on a change in pull request #7: [FLINK-21932] Add Python SDK showcase

2021-03-24 Thread GitBox
tzulitai commented on a change in pull request #7: URL: https://github.com/apache/flink-statefun-playground/pull/7#discussion_r601044648 ## File path: python/showcase/README.md ## @@ -0,0 +1,264 @@ +# StateFun Python SDK Showcase + +This project is intended for new StateFun us

[GitHub] [flink-statefun] tzulitai commented on pull request #218: [FLINK-21955]-[FLINK-21960] Pre-release sweep.

2021-03-24 Thread GitBox
tzulitai commented on pull request #218: URL: https://github.com/apache/flink-statefun/pull/218#issuecomment-806366859 LGTM from our offline hackathon :) Merged this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink-statefun] tzulitai commented on a change in pull request #218: [FLINK-21955]-[FLINK-21960] Pre-release sweep.

2021-03-24 Thread GitBox
tzulitai commented on a change in pull request #218: URL: https://github.com/apache/flink-statefun/pull/218#discussion_r601043830 ## File path: statefun-flink/statefun-flink-io-bundle/src/main/java/org/apache/flink/statefun/flink/io/kafka/RoutableProtobufKafkaIngressDeserializer.java

[GitHub] [flink-statefun] tzulitai merged pull request #218: [FLINK-21955]-[FLINK-21960] Pre-release sweep.

2021-03-24 Thread GitBox
tzulitai merged pull request #218: URL: https://github.com/apache/flink-statefun/pull/218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [flink-statefun] tzulitai closed pull request #218: [FLINK-21955]-[FLINK-21960] Pre-release sweep.

2021-03-24 Thread GitBox
tzulitai closed pull request #218: URL: https://github.com/apache/flink-statefun/pull/218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [flink] wuchong commented on a change in pull request #15265: [FLINK-21836][table-api] Introduce ParseStrategyParser

2021-03-24 Thread GitBox
wuchong commented on a change in pull request #15265: URL: https://github.com/apache/flink/pull/15265#discussion_r601036827 ## File path: flink-table/flink-table-planner-blink/src/test/java/org/apache/flink/table/planner/delegation/ParserImplTest.java ## @@ -0,0 +1,166 @@ +/*

[GitHub] [flink] flinkbot edited a comment on pull request #15314: [FLINK-21332][runtime] Optimize releasing result partitions in RegionPartitionReleaseStrategy

2021-03-24 Thread GitBox
flinkbot edited a comment on pull request #15314: URL: https://github.com/apache/flink/pull/15314#issuecomment-803903444 ## CI report: * 7512eec2a3d84fb8211cf9b1161a25b7e8b8800e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15148: [FLINK-21731] Add benchmarks for DefaultScheduler's creation, scheduling and deploying

2021-03-24 Thread GitBox
flinkbot edited a comment on pull request #15148: URL: https://github.com/apache/flink/pull/15148#issuecomment-796572621 ## CI report: * cd1977e701621bdd1f827dce3f0b463b100958c0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] leonardBang commented on a change in pull request #15303: [FLINK-21713][table-api/table-planner] Correct function CURRENT_TIMESTAMP/CURRENT_TIME/CURRENT_DATE/NOW/LOCALTIME/LOCALTIMEST

2021-03-24 Thread GitBox
leonardBang commented on a change in pull request #15303: URL: https://github.com/apache/flink/pull/15303#discussion_r601035897 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/NonDeterministicTests.scala ## @@ -20,5

[GitHub] [flink] leonardBang commented on a change in pull request #15303: [FLINK-21713][table-api/table-planner] Correct function CURRENT_TIMESTAMP/CURRENT_TIME/CURRENT_DATE/NOW/LOCALTIME/LOCALTIMEST

2021-03-24 Thread GitBox
leonardBang commented on a change in pull request #15303: URL: https://github.com/apache/flink/pull/15303#discussion_r601035545 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/NonDeterministicTests.scala ## @@ -20,5

[GitHub] [flink] zhuzhurk commented on a change in pull request #15312: [FLINK-21331][runtime] Optimize calculating tasks to restart in RestartPipelinedRegionFailoverStrategy

2021-03-24 Thread GitBox
zhuzhurk commented on a change in pull request #15312: URL: https://github.com/apache/flink/pull/15312#discussion_r601034351 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/flip1/RestartPipelinedRegionFailoverStrategy.java ## @@ -176,

[jira] [Closed] (FLINK-21930) There are some error for hive_read_writer.md

2021-03-24 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-21930. --- Fix Version/s: 1.13.0 Assignee: hehuiyuan Resolution: Fixed Fixed in master: 9bcd56c5ad4220a

[jira] [Updated] (FLINK-21930) Fix typo in Hive temporal join example

2021-03-24 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-21930: Summary: Fix typo in Hive temporal join example (was: There are some error for hive_read_writer.md) > Fi

[jira] [Updated] (FLINK-21930) There are some error for hive_read_writer.md

2021-03-24 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-21930: Component/s: Table SQL / Ecosystem > There are some error for hive_read_writer.md > --

[GitHub] [flink] wuchong merged pull request #15292: [FLINK-21930][DOC]fix hive dim doc replace o to order

2021-03-24 Thread GitBox
wuchong merged pull request #15292: URL: https://github.com/apache/flink/pull/15292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [flink] wuchong commented on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

2021-03-24 Thread GitBox
wuchong commented on pull request #14376: URL: https://github.com/apache/flink/pull/14376#issuecomment-806354798 I think we can simplify the desgin to just allow users change default value for types instead of columns. HBase connector also has a similar option `null-string-literal`.

[GitHub] [flink] flinkbot edited a comment on pull request #15348: [FLINK-21844][runtime] Do not auto-configure maxParallelism in REACTIVE scheduling mode

2021-03-24 Thread GitBox
flinkbot edited a comment on pull request #15348: URL: https://github.com/apache/flink/pull/15348#issuecomment-805219989 ## CI report: * 548ddea0488e0df73a8fd37234404fb25001c598 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15148: [FLINK-21731] Add benchmarks for DefaultScheduler's creation, scheduling and deploying

2021-03-24 Thread GitBox
flinkbot edited a comment on pull request #15148: URL: https://github.com/apache/flink/pull/15148#issuecomment-796572621 ## CI report: * cd1977e701621bdd1f827dce3f0b463b100958c0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] Thesharing commented on a change in pull request #15148: [FLINK-21731] Add benchmarks for DefaultScheduler's creation, scheduling and deploying

2021-03-24 Thread GitBox
Thesharing commented on a change in pull request #15148: URL: https://github.com/apache/flink/pull/15148#discussion_r601026918 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/benchmark/e2e/SchedulerBenchmarkBase.java ## @@ -0,0 +1,147 @@ +/* + * Li

[GitHub] [flink] zhuzhurk commented on a change in pull request #15148: [FLINK-21731] Add benchmarks for DefaultScheduler's creation, scheduling and deploying

2021-03-24 Thread GitBox
zhuzhurk commented on a change in pull request #15148: URL: https://github.com/apache/flink/pull/15148#discussion_r601026373 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/benchmark/e2e/SchedulerBenchmarkBase.java ## @@ -0,0 +1,147 @@ +/* + * Lice

[GitHub] [flink] KurtYoung commented on a change in pull request #15356: [FLINK-21947][csv] Support TIMESTAMP_LTZ type in CSV format

2021-03-24 Thread GitBox
KurtYoung commented on a change in pull request #15356: URL: https://github.com/apache/flink/pull/15356#discussion_r601006233 ## File path: flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvRowDeserializationSchema.java ## @@ -316,7 +321,11 @@ private stati

[jira] [Updated] (FLINK-21968) Calcite parser doesn't support to parse "-- test"

2021-03-24 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang updated FLINK-21968: -- Affects Version/s: 1.13.0 > Calcite parser doesn't support to parse "-- test" > --

[GitHub] [flink] fsk119 commented on pull request #15265: [FLINK-21836][table-api] Introduce ParseStrategyParser

2021-03-24 Thread GitBox
fsk119 commented on pull request #15265: URL: https://github.com/apache/flink/pull/15265#issuecomment-806343421 I think we can rebase this PR until all concerns are resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[jira] [Updated] (FLINK-21968) Calcite parser doesn't support to parse "-- test"

2021-03-24 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang updated FLINK-21968: -- Description: Please add a test in the {{FlinkSqlParserImplTest.java}}. {code:java} @Test

[jira] [Updated] (FLINK-21788) Throw PartitionNotFoundException if the partition file has been lost for blocking shuffle

2021-03-24 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-21788: Priority: Critical (was: Blocker) > Throw PartitionNotFoundException if the partition file has been lost

[GitHub] [flink] flinkbot edited a comment on pull request #15259: [FLINK-20757][network] Optimize data broadcast for sort-merge blocking shuffle

2021-03-24 Thread GitBox
flinkbot edited a comment on pull request #15259: URL: https://github.com/apache/flink/pull/15259#issuecomment-801679503 ## CI report: * b1b7558454e1df9f2ae913f6363cd823e1877c4c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Updated] (FLINK-21788) Throw PartitionNotFoundException if the partition file has been lost for blocking shuffle

2021-03-24 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-21788: Priority: Blocker (was: Major) > Throw PartitionNotFoundException if the partition file has been lost for

[jira] [Created] (FLINK-21968) Calcite parser doesn't support to parse "-- test"

2021-03-24 Thread Shengkai Fang (Jira)
Shengkai Fang created FLINK-21968: - Summary: Calcite parser doesn't support to parse "-- test" Key: FLINK-21968 URL: https://issues.apache.org/jira/browse/FLINK-21968 Project: Flink Issue Typ

[jira] [Updated] (FLINK-21788) Throw PartitionNotFoundException if the partition file has been lost for blocking shuffle

2021-03-24 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-21788: Parent: (was: FLINK-19614) Issue Type: Bug (was: Sub-task) > Throw PartitionNotFoundException

[GitHub] [flink] flinkbot edited a comment on pull request #15148: [FLINK-21731] Add benchmarks for DefaultScheduler's creation, scheduling and deploying

2021-03-24 Thread GitBox
flinkbot edited a comment on pull request #15148: URL: https://github.com/apache/flink/pull/15148#issuecomment-796572621 ## CI report: * cd1977e701621bdd1f827dce3f0b463b100958c0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Commented] (FLINK-21788) Throw PartitionNotFoundException if the partition file has been lost for blocking shuffle

2021-03-24 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308329#comment-17308329 ] Zhu Zhu commented on FLINK-21788: - which versions are affected by this problem [~kevin.c

[jira] [Comment Edited] (FLINK-21788) Throw PartitionNotFoundException if the partition file has been lost for blocking shuffle

2021-03-24 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308329#comment-17308329 ] Zhu Zhu edited comment on FLINK-21788 at 3/25/21, 3:44 AM: --- Wh

[jira] [Assigned] (FLINK-21788) Throw PartitionNotFoundException if the partition file has been lost for blocking shuffle

2021-03-24 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu reassigned FLINK-21788: --- Assignee: Yingjie Cao > Throw PartitionNotFoundException if the partition file has been lost for >

[GitHub] [flink] wsry commented on pull request #15259: [FLINK-20757][network] Optimize data broadcast for sort-merge blocking shuffle

2021-03-24 Thread GitBox
wsry commented on pull request #15259: URL: https://github.com/apache/flink/pull/15259#issuecomment-806341129 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[jira] [Closed] (FLINK-21951) Fix wrong if condition in BufferReaderWriterUtil#writeBuffers

2021-03-24 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-21951. --- Assignee: Yingjie Cao Resolution: Fixed Fixed via 3533d9822f0f653f2848b31de0fc239b3a12dcef > Fix wron

[GitHub] [flink] zhuzhurk merged pull request #15364: [FLINK-21951][network] Fix the wrong if condition in BufferReaderWriterUtil#writeBuffers

2021-03-24 Thread GitBox
zhuzhurk merged pull request #15364: URL: https://github.com/apache/flink/pull/15364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[jira] [Commented] (FLINK-21539) 'SQL Client end-to-end test (Blink planner) Elasticsearch (v6.3.1)' fails during download

2021-03-24 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308325#comment-17308325 ] Guowei Ma commented on FLINK-21539: --- https://dev.azure.com/apache-flink/apache-flink/_

[GitHub] [flink] zhuzhurk commented on a change in pull request #15148: [FLINK-21731] Add benchmarks for DefaultScheduler's creation, scheduling and deploying

2021-03-24 Thread GitBox
zhuzhurk commented on a change in pull request #15148: URL: https://github.com/apache/flink/pull/15148#discussion_r601012694 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/benchmark/e2e/SchedulingAndDeployingBenchmark.java ## @@ -0,0 +1,62 @@ +/*

[jira] [Created] (FLINK-21967) Add document on the operation of blocking result partition

2021-03-24 Thread Yun Gao (Jira)
Yun Gao created FLINK-21967: --- Summary: Add document on the operation of blocking result partition Key: FLINK-21967 URL: https://issues.apache.org/jira/browse/FLINK-21967 Project: Flink Issue Type:

[GitHub] [flink] flinkbot edited a comment on pull request #15362: [FLINK-21939][python] Support batch mode in Python DataStream API for process operation and reduce operation

2021-03-24 Thread GitBox
flinkbot edited a comment on pull request #15362: URL: https://github.com/apache/flink/pull/15362#issuecomment-805817140 ## CI report: * a46a6236b098fdc7b89755d4b072053134d42507 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15161: [FLINK-20114][connector/kafka,common] Fix a few KafkaSource-related bugs

2021-03-24 Thread GitBox
flinkbot edited a comment on pull request #15161: URL: https://github.com/apache/flink/pull/15161#issuecomment-797177953 ## CI report: * d3f59e302b9860d49ce79252aeb8bd1decaeeabf UNKNOWN * 3bbb86b12a43044ce3f876401c98f28c87858fbe Azure: [SUCCESS](https://dev.azure.com/apache-fl

[GitHub] [flink] KurtYoung commented on a change in pull request #15356: [FLINK-21947][csv] Support TIMESTAMP_LTZ type in CSV format

2021-03-24 Thread GitBox
KurtYoung commented on a change in pull request #15356: URL: https://github.com/apache/flink/pull/15356#discussion_r601004944 ## File path: flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/TimeFormats.java ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache So

[jira] [Created] (FLINK-21966) Support Kinesis connector in Python DataStream API.

2021-03-24 Thread Shuiqiang Chen (Jira)
Shuiqiang Chen created FLINK-21966: -- Summary: Support Kinesis connector in Python DataStream API. Key: FLINK-21966 URL: https://issues.apache.org/jira/browse/FLINK-21966 Project: Flink Issue

[jira] [Closed] (FLINK-20758) Use region file mechanism for shuffle data reading before we switch to managed memory

2021-03-24 Thread Yingjie Cao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yingjie Cao closed FLINK-20758. --- Resolution: Won't Fix > Use region file mechanism for shuffle data reading before we switch to > ma

[GitHub] [flink] flinkbot edited a comment on pull request #15362: [FLINK-21939][python] Support batch mode in Python DataStream API for process operation and reduce operation

2021-03-24 Thread GitBox
flinkbot edited a comment on pull request #15362: URL: https://github.com/apache/flink/pull/15362#issuecomment-805817140 ## CI report: * a46a6236b098fdc7b89755d4b072053134d42507 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15161: [FLINK-20114][connector/kafka,common] Fix a few KafkaSource-related bugs

2021-03-24 Thread GitBox
flinkbot edited a comment on pull request #15161: URL: https://github.com/apache/flink/pull/15161#issuecomment-797177953 ## CI report: * d3f59e302b9860d49ce79252aeb8bd1decaeeabf UNKNOWN * 3bbb86b12a43044ce3f876401c98f28c87858fbe Azure: [SUCCESS](https://dev.azure.com/apache-fl

[jira] [Commented] (FLINK-20985) end the stream-job in docker container will remain some zombie processes in 1.11, these useless processes not be maked as zombie but still exist in 1.12

2021-03-24 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308307#comment-17308307 ] Dian Fu commented on FLINK-20985: - Are these processes managed by Flink? Could you give

[jira] [Commented] (FLINK-21942) KubernetesLeaderRetrievalDriver not closed after terminated which lead to connection leak

2021-03-24 Thread Yi Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308299#comment-17308299 ] Yi Tang commented on FLINK-21942: - [~fly_in_gis] Sure, I've uploaded a ( [^jstack.l] ) c

[jira] [Updated] (FLINK-21942) KubernetesLeaderRetrievalDriver not closed after terminated which lead to connection leak

2021-03-24 Thread Yi Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yi Tang updated FLINK-21942: Attachment: jstack.l > KubernetesLeaderRetrievalDriver not closed after terminated which lead to > connec

[GitHub] [flink] lirui-apache commented on pull request #15274: [FLINK-21829][Hive Connect]Fix to throw exception when custom hadoop conf path does not exist

2021-03-24 Thread GitBox
lirui-apache commented on pull request #15274: URL: https://github.com/apache/flink/pull/15274#issuecomment-806314134 > > HiveCatalogFactoryTest > > Hi @lirui-apache , is it ok? > ` > > ``` > @Test > public void testCreateHiveCatalogWithIllegalHadoopConfDir() throws I

[jira] [Updated] (FLINK-20374) Wrong result when shuffling changelog stream on non-primary-key columns

2021-03-24 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-20374: Description: This is reported from user-zh ML: http://apache-flink.147419.n8.nabble.com/flink-1-11-2-cdc-

[GitHub] [flink] lindong28 commented on pull request #15161: [FLINK-20114][connector/kafka,common] Fix a few KafkaSource-related bugs

2021-03-24 Thread GitBox
lindong28 commented on pull request #15161: URL: https://github.com/apache/flink/pull/15161#issuecomment-806310235 @StephanEwen @becketqin Thanks for the review! I think all issues are resolved. Could you take another look? -- This is an automated message from the Apache Git Service. To

[GitHub] [flink] lindong28 commented on a change in pull request #15161: [FLINK-20114][connector/kafka,common] Fix a few KafkaSource-related bugs

2021-03-24 Thread GitBox
lindong28 commented on a change in pull request #15161: URL: https://github.com/apache/flink/pull/15161#discussion_r600993395 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/RecreateOnResetOperatorCoordinator.java ## @@ -74,7 +74,8 @@

[jira] [Commented] (FLINK-21294) Support state access API for the map/flat_map operation of Python ConnectedStreams

2021-03-24 Thread Wei Zhong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308286#comment-17308286 ] Wei Zhong commented on FLINK-21294: --- Merged via 7e49b1af59341d924eee1742ea59e8c43c3be7

[jira] [Assigned] (FLINK-21294) Support state access API for the map/flat_map operation of Python ConnectedStreams

2021-03-24 Thread Wei Zhong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei Zhong reassigned FLINK-21294: - Assignee: Wei Zhong > Support state access API for the map/flat_map operation of Python > Conn

[jira] [Closed] (FLINK-21294) Support state access API for the map/flat_map operation of Python ConnectedStreams

2021-03-24 Thread Wei Zhong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei Zhong closed FLINK-21294. - Resolution: Fixed > Support state access API for the map/flat_map operation of Python > ConnectedStream

[GitHub] [flink] WeiZhong94 closed pull request #15149: [FLINK-21294][python] Support state access API for the map/flat_map operation of Python ConnectedStreams

2021-03-24 Thread GitBox
WeiZhong94 closed pull request #15149: URL: https://github.com/apache/flink/pull/15149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [flink] leonardBang commented on a change in pull request #15303: [FLINK-21713][table-api/table-planner] Correct function CURRENT_TIMESTAMP/CURRENT_TIME/CURRENT_DATE/NOW/LOCALTIME/LOCALTIMEST

2021-03-24 Thread GitBox
leonardBang commented on a change in pull request #15303: URL: https://github.com/apache/flink/pull/15303#discussion_r600984396 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/delegation/PlannerBase.scala ## @@ -455,16 +455,21

[GitHub] [flink] dianfu commented on a change in pull request #15362: [FLINK-21939][python] Support batch mode in Python DataStream API for process operation and reduce operation

2021-03-24 Thread GitBox
dianfu commented on a change in pull request #15362: URL: https://github.com/apache/flink/pull/15362#discussion_r600982520 ## File path: flink-python/pyflink/datastream/tests/test_data_stream.py ## @@ -1068,6 +1013,35 @@ def on_timer(self, timestamp, ctx): expected_res

[GitHub] [flink] flinkbot edited a comment on pull request #15339: [FLINK-21448] Randomize ITTests for delegating state backend

2021-03-24 Thread GitBox
flinkbot edited a comment on pull request #15339: URL: https://github.com/apache/flink/pull/15339#issuecomment-804687609 ## CI report: * 78a059002986b8c966a7916dce4da7eeea054a3c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Commented] (FLINK-21613) Parse Compute Column with `IN` expression throws NPE

2021-03-24 Thread jibiyr (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308276#comment-17308276 ] jibiyr commented on FLINK-21613: [~twalthr] I seek advice from the calcite community, he

[GitHub] [flink] flinkbot edited a comment on pull request #15339: [FLINK-21448] Randomize ITTests for delegating state backend

2021-03-24 Thread GitBox
flinkbot edited a comment on pull request #15339: URL: https://github.com/apache/flink/pull/15339#issuecomment-804687609 ## CI report: * 78a059002986b8c966a7916dce4da7eeea054a3c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

  1   2   3   4   5   6   >