[GitHub] [flink] YuvalItzchakov edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

YuvalItzchakov edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-813077657 Placing `PushFilterInCalcIntoTableSOurceScanRule` after `FlinkLogicalCalcRemoveRule` in LOGICAL_REWRITES fixes the issue. -- This is an automated message from th

[GitHub] [flink] YuvalItzchakov commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

YuvalItzchakov commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-813077657 Placing `PushFilterInCalcIntoTableSOurceScanRule` after `FlinkLogicalCalcRemoveRule` fixes the issue. -- This is an automated message from the Apache Git Service. To re

[jira] [Commented] (FLINK-21875) GSRKinesisPubsubClient is not compiling in IntelliJ

[ https://issues.apache.org/jira/browse/FLINK-21875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17314577#comment-17314577 ] Robert Metzger commented on FLINK-21875: Thanks a lot for resolving this so quic

[GitHub] [flink] rmetzger commented on pull request #15360: [FLINK-21938][docs] Add how to unit test python udfs

rmetzger commented on pull request #15360: URL: https://github.com/apache/flink/pull/15360#issuecomment-813076238 No, we have to wait for a reviewer to show up. @HuangXingBo could you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [flink] flinkbot edited a comment on pull request #15486: [FLINK-21754][core] Fix 'Exception message does not point to the right path.'

flinkbot edited a comment on pull request #15486: URL: https://github.com/apache/flink/pull/15486#issuecomment-812964582 ## CI report: * 19ef569664eb49a37e24f71477b4a91ba413879a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15485: [FLINK-20387][table] Support TIMESTAMP_LTZ as rowtime attribute

flinkbot edited a comment on pull request #15485: URL: https://github.com/apache/flink/pull/15485#issuecomment-812897189 ## CI report: * a80d00d71f4b2810ad493f4a1cac215e6934df1d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15485: [FLINK-20387][table] Support TIMESTAMP_LTZ as rowtime attribute

flinkbot edited a comment on pull request #15485: URL: https://github.com/apache/flink/pull/15485#issuecomment-812897189 ## CI report: * 6d636a26572e5734968fe25490e4573fe580a7f1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15485: [FLINK-20387][table] Support TIMESTAMP_LTZ as rowtime attribute

flinkbot edited a comment on pull request #15485: URL: https://github.com/apache/flink/pull/15485#issuecomment-812897189 ## CI report: * 6d636a26572e5734968fe25490e4573fe580a7f1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] wuchong commented on a change in pull request #15280: [FLINK-21714][table-api] Use TIMESTAMP_LTZ as return type for function PROCTIME()

wuchong commented on a change in pull request #15280: URL: https://github.com/apache/flink/pull/15280#discussion_r606807680 ## File path: flink-table/flink-table-runtime-blink/src/test/java/org/apache/flink/table/data/DataFormatConvertersTest.java ## @@ -85,7 +85,7 @@

[GitHub] [flink] wuchong closed pull request #15427: [FLINK-21829][Hive Connect]Fix to throw exception when custom hadoop conf path does not exist or there is no conf file

wuchong closed pull request #15427: URL: https://github.com/apache/flink/pull/15427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Closed] (FLINK-21829) create HiveCatalog with custom hadoopconfdir first

[ https://issues.apache.org/jira/browse/FLINK-21829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-21829. --- Fix Version/s: 1.13.0 Assignee: hehuiyuan Resolution: Fixed Fixed in master: c86025f0a0c4c8a

[GitHub] [flink] flinkbot edited a comment on pull request #15486: [FLINK-21754][core] Fix 'Exception message does not point to the right path.'

flinkbot edited a comment on pull request #15486: URL: https://github.com/apache/flink/pull/15486#issuecomment-812964582 ## CI report: * 19ef569664eb49a37e24f71477b4a91ba413879a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] RocMarshal commented on pull request #15486: [FLINK-21754][core] Fix 'Exception message does not point to the right path.'

RocMarshal commented on pull request #15486: URL: https://github.com/apache/flink/pull/15486#issuecomment-813024022 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [flink] hehuiyuan commented on pull request #15427: [FLINK-21829][Hive Connect]Fix to throw exception when custom hadoop conf path does not exist or there is no conf file

hehuiyuan commented on pull request #15427: URL: https://github.com/apache/flink/pull/15427#issuecomment-813001630 Hi @wuchong , please take a look when you have time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (FLINK-19754) Cannot have more than one execute() or executeAsync() call in a single environment.

[ https://issues.apache.org/jira/browse/FLINK-19754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17314443#comment-17314443 ] Shiao Meng commented on FLINK-19754: I meet the save problem——got an error when my f

[jira] [Issue Comment Deleted] (FLINK-19754) Cannot have more than one execute() or executeAsync() call in a single environment.

[ https://issues.apache.org/jira/browse/FLINK-19754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shiao Meng updated FLINK-19754: --- Comment: was deleted (was: Is this problem solved?) > Cannot have more than one execute() or execut

[jira] [Commented] (FLINK-19754) Cannot have more than one execute() or executeAsync() call in a single environment.

[ https://issues.apache.org/jira/browse/FLINK-19754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17314441#comment-17314441 ] Shiao Meng commented on FLINK-19754: Is this problem solved? > Cannot have more tha

[GitHub] [flink] flinkbot edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

flinkbot edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-803592550 ## CI report: * 2ef40343abecf693b39b7b7fcb9f6d0d26bf82cd UNKNOWN * c6a9624a91169b7058a513fd2168747d9696e6c6 Azure: [FAILURE](https://dev.azure.com/apache-fl

[GitHub] [flink] YuvalItzchakov edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

YuvalItzchakov edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812995554 @fsk119 I've added a test to check computed column pushdown and it's failing. Test: ```java @Test public void testComputedColumnPushdownA

[GitHub] [flink] YuvalItzchakov commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

YuvalItzchakov commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812995554 @fsk119 I've added a test to check computed column pushdown and it's failing. The optimized plan that is being generated is: ``` FlinkLogicalCalc(select=[event_t

[GitHub] [flink] flinkbot edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

flinkbot edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-803592550 ## CI report: * 2ef40343abecf693b39b7b7fcb9f6d0d26bf82cd UNKNOWN * 6255655a4b3c6041a758c5919d6f63d1356d09cf Azure: [FAILURE](https://dev.azure.com/apache-fl

[GitHub] [flink] flinkbot edited a comment on pull request #15486: [FLINK-21754][core] Fix 'Exception message does not point to the right path.'

flinkbot edited a comment on pull request #15486: URL: https://github.com/apache/flink/pull/15486#issuecomment-812964582 ## CI report: * 19ef569664eb49a37e24f71477b4a91ba413879a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] YuvalItzchakov commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

YuvalItzchakov commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812991891 @fsk119 Which test are you referring to? Currently I only see linting errors. -- This is an automated message from the Apache Git Service. To respond to the message, ple