[GitHub] [flink] flinkbot edited a comment on pull request #15393: [FLINK-21980][Runtime/Coordination] ZooKeeperRunningJobsRegistry creates an empty znode

2021-04-06 Thread GitBox
flinkbot edited a comment on pull request #15393: URL: https://github.com/apache/flink/pull/15393#issuecomment-808510341 ## CI report: * 6d3a5349e3babb3f5c12ba2629f70f23dd8cbdf8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
flinkbot edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-803592550 ## CI report: * 2ef40343abecf693b39b7b7fcb9f6d0d26bf82cd UNKNOWN * f7dde849a55b4aad1044ac200b390a604029c710 UNKNOWN * a3341911ab289f00a4aa50b99c8b90980f5f

[jira] [Commented] (FLINK-22084) RescalingITCase fails with adaptive scheduler

2021-04-06 Thread Austin Cawley-Edwards (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315716#comment-17315716 ] Austin Cawley-Edwards commented on FLINK-22084: --- That is unfortunate, and

[GitHub] [flink] YuvalItzchakov commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
YuvalItzchakov commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-814268110 @fsk119 I resolved this by moving the instantiation of `util` into the `setup` method. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [flink] flinkbot edited a comment on pull request #15485: [FLINK-20387][table] Support TIMESTAMP_LTZ as rowtime attribute

2021-04-06 Thread GitBox
flinkbot edited a comment on pull request #15485: URL: https://github.com/apache/flink/pull/15485#issuecomment-812897189 ## CI report: * 99f1c41eb70ddeff355829f59ec0649c6da64b0b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15395: [FLINK-15146][core][ttl] Fix check that incremental cleanup size must be greater than zero

2021-04-06 Thread GitBox
flinkbot edited a comment on pull request #15395: URL: https://github.com/apache/flink/pull/15395#issuecomment-808844283 ## CI report: * 5d043b1bde696752f58e773239f37cf8e363e7ac Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] YuvalItzchakov edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
YuvalItzchakov edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-814257612 @fsk119 To be honest I don't understand why we need the added complexity of code inheritance here, these tests should be ran individually anyway. If each one of th

[GitHub] [flink] YuvalItzchakov commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
YuvalItzchakov commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-814257612 @fsk119 To be honest I don't understand why we need the added complexity of code inheritance here, these tests should be ran individually. If each one of them utilizes a

[GitHub] [flink] YuvalItzchakov commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
YuvalItzchakov commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-814253822 @fsk119 After registering the tables in `PushFilterInCalcIntoTableSourceRuleTest`, now only one test fails from `PushFilterIntoLegacyTableSourceScanRuleTest`:

[GitHub] [flink] flinkbot edited a comment on pull request #15495: [FLINK-21305][table-planner-blink] Fix Cumulative and Hopping window should accumulate late events belonging to the cleaned slice

2021-04-06 Thread GitBox
flinkbot edited a comment on pull request #15495: URL: https://github.com/apache/flink/pull/15495#issuecomment-814224111 ## CI report: * 68ee1f63c2ca642d7ef6908d81250a5ec53b1cb8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15494: [FLINK-17957] [table-api][parser] Forbidden syntax "CREATE SYSTEM FUNCTION" for sql parser

2021-04-06 Thread GitBox
flinkbot edited a comment on pull request #15494: URL: https://github.com/apache/flink/pull/15494#issuecomment-814059954 ## CI report: * feb716af24dd6257a488f9d2c4d63ff8e5e01f9c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15496: [FLINK-21990][streaming] Cancel task before clean up if execution was…

2021-04-06 Thread GitBox
flinkbot edited a comment on pull request #15496: URL: https://github.com/apache/flink/pull/15496#issuecomment-814224240 ## CI report: * 23153a97c61ce55427c1f0d864494938d656501c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15480: [FLINK-22006][k8s] Support to configure max concurrent requests for fabric8 Kubernetes client via JAVA opts or envs

2021-04-06 Thread GitBox
flinkbot edited a comment on pull request #15480: URL: https://github.com/apache/flink/pull/15480#issuecomment-812378052 ## CI report: * 8c7eca17544f157b58f4100af3527e346a63bbcb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
flinkbot edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-803592550 ## CI report: * 2ef40343abecf693b39b7b7fcb9f6d0d26bf82cd UNKNOWN * f7dde849a55b4aad1044ac200b390a604029c710 UNKNOWN * a3341911ab289f00a4aa50b99c8b90980f5f

[jira] [Resolved] (FLINK-22003) UnalignedCheckpointITCase fail

2021-04-06 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan resolved FLINK-22003. --- Fix Version/s: 1.13.0 Resolution: Fixed Merged into master as a40dfe0438afe0

[GitHub] [flink] rkhachatryan closed pull request #15466: [FLINK-22003][checkpointing] Prevent checkpoint from starting if any Source isn't running

2021-04-06 Thread GitBox
rkhachatryan closed pull request #15466: URL: https://github.com/apache/flink/pull/15466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [flink] rkhachatryan commented on pull request #15466: [FLINK-22003][checkpointing] Prevent checkpoint from starting if any Source isn't running

2021-04-06 Thread GitBox
rkhachatryan commented on pull request #15466: URL: https://github.com/apache/flink/pull/15466#issuecomment-814237052 Thanks for reviewing @tillrohrmann , @gaoyunhaii ! Merged into master as `a40dfe0438afe04d1ac68c30bb8d238be45232cf..9cb161005861365b9dadfd016fcc321475c3d890`. -- T

[GitHub] [flink] flinkbot commented on pull request #15496: [FLINK-21990][streaming] Cancel task before clean up if execution was…

2021-04-06 Thread GitBox
flinkbot commented on pull request #15496: URL: https://github.com/apache/flink/pull/15496#issuecomment-814224240 ## CI report: * 23153a97c61ce55427c1f0d864494938d656501c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] flinkbot commented on pull request #15495: [FLINK-21305][table-planner-blink] Fix Cumulative and Hopping window should accumulate late events belonging to the cleaned slice

2021-04-06 Thread GitBox
flinkbot commented on pull request #15495: URL: https://github.com/apache/flink/pull/15495#issuecomment-814224111 ## CI report: * 68ee1f63c2ca642d7ef6908d81250a5ec53b1cb8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] flinkbot edited a comment on pull request #15480: [FLINK-22006][k8s] Support to configure max concurrent requests for fabric8 Kubernetes client via JAVA opts or envs

2021-04-06 Thread GitBox
flinkbot edited a comment on pull request #15480: URL: https://github.com/apache/flink/pull/15480#issuecomment-812378052 ## CI report: * 8c7eca17544f157b58f4100af3527e346a63bbcb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] akalash commented on a change in pull request #15496: [FLINK-21990][streaming] Cancel task before clean up if execution was…

2021-04-06 Thread GitBox
akalash commented on a change in pull request #15496: URL: https://github.com/apache/flink/pull/15496#discussion_r607961267 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java ## @@ -946,41 +952,35 @@ private boolean trigge

[GitHub] [flink] flinkbot commented on pull request #15496: [FLINK-21990][streaming] Cancel task before clean up if execution was…

2021-04-06 Thread GitBox
flinkbot commented on pull request #15496: URL: https://github.com/apache/flink/pull/15496#issuecomment-814213793 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[jira] [Updated] (FLINK-21990) SourceStreamTask will always hang if the CheckpointedFunction#snapshotState throws an exception.

2021-04-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-21990: --- Labels: pull-request-available (was: ) > SourceStreamTask will always hang if the Checkpoin

[GitHub] [flink] akalash opened a new pull request #15496: [FLINK-21990][streaming] Cancel task before clean up if execution was…

2021-04-06 Thread GitBox
akalash opened a new pull request #15496: URL: https://github.com/apache/flink/pull/15496 … failed ## What is the purpose of the change *This PR adds the invocation of task cancel before clean up method when the execution was failed which allows sending cancel signal

[GitHub] [flink] flinkbot commented on pull request #15495: [FLINK-21305][table-planner-blink] Fix Cumulative and Hopping window should accumulate late events belonging to the cleaned slice

2021-04-06 Thread GitBox
flinkbot commented on pull request #15495: URL: https://github.com/apache/flink/pull/15495#issuecomment-814208132 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[GitHub] [flink] wangyang0918 edited a comment on pull request #15480: [FLINK-22006][k8s] Support to configure max concurrent requests for fabric8 Kubernetes client via JAVA opts or envs

2021-04-06 Thread GitBox
wangyang0918 edited a comment on pull request #15480: URL: https://github.com/apache/flink/pull/15480#issuecomment-814207158 @tillrohrmann I have pushed another commit for the documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink] wangyang0918 commented on pull request #15480: [FLINK-22006][k8s] Support to configure max concurrent requests for fabric8 Kubernetes client via JAVA opts or envs

2021-04-06 Thread GitBox
wangyang0918 commented on pull request #15480: URL: https://github.com/apache/flink/pull/15480#issuecomment-814207158 I have pushed another commit for the documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Updated] (FLINK-21305) Fix Cumulative and Hopping window should accumulate late events belonging to the cleaned slice

2021-04-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-21305: --- Labels: pull-request-available (was: ) > Fix Cumulative and Hopping window should accumulat

[GitHub] [flink] wuchong opened a new pull request #15495: [FLINK-21305][table-planner-blink] Fix Cumulative and Hopping window should accumulate late events belonging to the cleaned slice

2021-04-06 Thread GitBox
wuchong opened a new pull request #15495: URL: https://github.com/apache/flink/pull/15495 ## What is the purpose of the change Currently, the CUMULATE window drops elements belonging to the cleaned slices. This will lead to more inaccurate result than without slicing optimiz

[GitHub] [flink] flinkbot edited a comment on pull request #15493: [FLINK-22082][table planner] Fix nested projection push down doesn't …

2021-04-06 Thread GitBox
flinkbot edited a comment on pull request #15493: URL: https://github.com/apache/flink/pull/15493#issuecomment-814016686 ## CI report: * 6138eac2ea099ecedfa464d0cd06a05b6a47897f Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] flinkbot edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
flinkbot edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-803592550 ## CI report: * 2ef40343abecf693b39b7b7fcb9f6d0d26bf82cd UNKNOWN * f7dde849a55b4aad1044ac200b390a604029c710 UNKNOWN * a3341911ab289f00a4aa50b99c8b90980f5f

[GitHub] [flink] fsk119 commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
fsk119 commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-814182307 You can reuse these codes in the `setup` between `PushFilterInCalcIntoTableSourceRuleTest ` and `PushFilterIntoTableSourceScanRuleTest `. ``` // name: STRING, id: LONG

[GitHub] [flink] fsk119 commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
fsk119 commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-814180436 > After implementing the changes, the `PushFilterIntoTableSourceScanRuleTest` now fail since I cant run the `setup` code for them (due to use of batch vs stream): > > ```

[GitHub] [flink] YuvalItzchakov edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
YuvalItzchakov edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-814173776 After implementing the changes, the `PushFilterIntoTableSourceScanRuleTest` now fail since I cant run the `setup` code for them (due to use of batch vs stream):

[GitHub] [flink] YuvalItzchakov commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
YuvalItzchakov commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-814173776 After implementing the changes, the `PushFilterIntoTableSourceScanRuleTest` now fail since I cant run the `setup` code for them (due to use of batch vs stream):

[jira] [Commented] (FLINK-22084) RescalingITCase fails with adaptive scheduler

2021-04-06 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315618#comment-17315618 ] Chesnay Schepler commented on FLINK-22084: -- The test seems to use different max

[GitHub] [flink] flinkbot edited a comment on pull request #15493: [FLINK-22082][table planner] Fix nested projection push down doesn't …

2021-04-06 Thread GitBox
flinkbot edited a comment on pull request #15493: URL: https://github.com/apache/flink/pull/15493#issuecomment-814016686 ## CI report: * 6138eac2ea099ecedfa464d0cd06a05b6a47897f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15466: [FLINK-22003][checkpointing] Prevent checkpoint from starting if any Source isn't running

2021-04-06 Thread GitBox
flinkbot edited a comment on pull request #15466: URL: https://github.com/apache/flink/pull/15466#issuecomment-811978896 ## CI report: * 94e1244c252e25f00844c00c42230542ae38b6c1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
flinkbot edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-803592550 ## CI report: * 2ef40343abecf693b39b7b7fcb9f6d0d26bf82cd UNKNOWN * f7dde849a55b4aad1044ac200b390a604029c710 UNKNOWN * a3341911ab289f00a4aa50b99c8b90980f5f

[GitHub] [flink] YuvalItzchakov removed a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
YuvalItzchakov removed a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-814164316 @fsk119 I see this in your branch: ```java @Before public void setup() { util_$eq(streamTestUtil(new TableConfig())); ``` What

[GitHub] [flink] YuvalItzchakov commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
YuvalItzchakov commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-814164316 @fsk119 I see this in your branch: ```java @Before public void setup() { util_$eq(streamTestUtil(new TableConfig())); ``` What are you

[jira] [Commented] (FLINK-22084) RescalingITCase fails with adaptive scheduler

2021-04-06 Thread Austin Cawley-Edwards (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315603#comment-17315603 ] Austin Cawley-Edwards commented on FLINK-22084: --- [~trohrmann] very likely

[jira] [Assigned] (FLINK-22084) RescalingITCase fails with adaptive scheduler

2021-04-06 Thread Austin Cawley-Edwards (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Austin Cawley-Edwards reassigned FLINK-22084: - Assignee: Austin Cawley-Edwards > RescalingITCase fails with adaptive s

[GitHub] [flink] YuvalItzchakov commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
YuvalItzchakov commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-814157766 @fsk119 Rebased master. I already fixed the compile time error after installing the plugin IIRC. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [flink] flinkbot edited a comment on pull request #15493: [FLINK-22082][table planner] Fix nested projection push down doesn't …

2021-04-06 Thread GitBox
flinkbot edited a comment on pull request #15493: URL: https://github.com/apache/flink/pull/15493#issuecomment-814016686 ## CI report: * 6138eac2ea099ecedfa464d0cd06a05b6a47897f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15492: [FLINK-22107][hive] Include antlr into hive connector uber jars

2021-04-06 Thread GitBox
flinkbot edited a comment on pull request #15492: URL: https://github.com/apache/flink/pull/15492#issuecomment-813977720 ## CI report: * 3dcb8c4066486404c5ab3831a8c96d63952161e2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
flinkbot edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-803592550 ## CI report: * 2ef40343abecf693b39b7b7fcb9f6d0d26bf82cd UNKNOWN * f7dde849a55b4aad1044ac200b390a604029c710 UNKNOWN * a3341911ab289f00a4aa50b99c8b90980f5f

[jira] [Closed] (FLINK-17446) Blink supports cube and window together in group by

2021-04-06 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-17446. --- Resolution: Fixed > Blink supports cube and window together in group by > --

[jira] [Updated] (FLINK-21482) Support grouping set syntax for Window TVF based aggregation

2021-04-06 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-21482: Summary: Support grouping set syntax for Window TVF based aggregation (was: Fix bug when use grouping set

[jira] [Commented] (FLINK-17446) Blink supports cube and window together in group by

2021-04-06 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315592#comment-17315592 ] Jark Wu commented on FLINK-17446: - [~svend] we have supported this feature with new wind

[jira] [Commented] (FLINK-17446) Blink supports cube and window together in group by

2021-04-06 Thread Svend Vanderveken (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315590#comment-17315590 ] Svend Vanderveken commented on FLINK-17446: --- We'd be grateful if that feature

[GitHub] [flink] klion26 commented on pull request #8751: [FLINK-11937][StateBackend]Resolve small file problem in RocksDB incremental checkpoint

2021-04-06 Thread GitBox
klion26 commented on pull request #8751: URL: https://github.com/apache/flink/pull/8751#issuecomment-814131133 @StephanEwen sorry for the late reply. IIUC, maybe we still need this feature after FLIP-158 has been implemented(even if we cloud handle not to generate small sst files -- 64MB

[jira] [Commented] (FLINK-21329) "Local recovery and sticky scheduling end-to-end test" does not finish within 600 seconds

2021-04-06 Thread Seth Wiesman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315571#comment-17315571 ] Seth Wiesman commented on FLINK-21329: -- I looked at the test and I don't see anythi

[GitHub] [flink] flinkbot edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
flinkbot edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-803592550 ## CI report: * 2ef40343abecf693b39b7b7fcb9f6d0d26bf82cd UNKNOWN * ed648357d9c7714245e20e9dfd10abb65393bd82 Azure: [FAILURE](https://dev.azure.com/apache-fl

[GitHub] [flink] flinkbot edited a comment on pull request #15341: [FLINK-21923][table-planner-blink] Fix SplitAggregateRule not support both filter, count/sum, avg

2021-04-06 Thread GitBox
flinkbot edited a comment on pull request #15341: URL: https://github.com/apache/flink/pull/15341#issuecomment-804760572 ## CI report: * b9683c5a994a83652c156b06233c360d73ecfd7f UNKNOWN * 36f21178850b4c2e1f08008a1d53243a319a4f5b Azure: [SUCCESS](https://dev.azure.com/apache-fl

[GitHub] [flink] flinkbot edited a comment on pull request #15485: [FLINK-20387][table] Support TIMESTAMP_LTZ as rowtime attribute

2021-04-06 Thread GitBox
flinkbot edited a comment on pull request #15485: URL: https://github.com/apache/flink/pull/15485#issuecomment-812897189 ## CI report: * f805a55185df95368d7a1c1ec80717c5f2202b4c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15395: [FLINK-15146][core][ttl] Fix check that incremental cleanup size must be greater than zero

2021-04-06 Thread GitBox
flinkbot edited a comment on pull request #15395: URL: https://github.com/apache/flink/pull/15395#issuecomment-808844283 ## CI report: * dbd3a900a1ae3c4cee4c5de5e8fd7e47d661045c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
flinkbot edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-803592550 ## CI report: * 2ef40343abecf693b39b7b7fcb9f6d0d26bf82cd UNKNOWN * ed648357d9c7714245e20e9dfd10abb65393bd82 Azure: [FAILURE](https://dev.azure.com/apache-fl

[GitHub] [flink] fsk119 edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
fsk119 edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-814110768 Before review the new code, I think you **MUST** fix the compile error and REBASE to the current master branch. Your branch is far behind the master. I need to re-c

[GitHub] [flink] fsk119 commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
fsk119 commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-814110768 Before review the new code, I think you **MUST** fix the compile error and REBASE to the current master branch. Your branch is far behind the master. I need to re-compile

[GitHub] [flink] fsk119 commented on a change in pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
fsk119 commented on a change in pull request #15307: URL: https://github.com/apache/flink/pull/15307#discussion_r607834400 ## File path: flink-table/flink-table-planner-blink/src/test/resources/org/apache/flink/table/planner/plan/rules/logical/PushFilterInCalcIntoTableSourceRuleTest.x

[GitHub] [flink] fsk119 commented on a change in pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
fsk119 commented on a change in pull request #15307: URL: https://github.com/apache/flink/pull/15307#discussion_r607831711 ## File path: flink-table/flink-table-planner-blink/src/test/resources/org/apache/flink/table/planner/plan/rules/logical/PushFilterInCalcIntoTableSourceRuleTest.x

[jira] [Assigned] (FLINK-21743) JdbcXaSinkFunction throws XAER_RMFAIL when calling snapshotState and beginTx

2021-04-06 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan reassigned FLINK-21743: - Assignee: Yuan Mei (was: Roman Khachatryan) > JdbcXaSinkFunction throws XAER_R

[jira] [Updated] (FLINK-22125) Revisit the return value of MapState.get when the key doesn't exist

2021-04-06 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-22125: Summary: Revisit the return value of MapState.get when the key doesn't exist (was: Revisit the return val

[jira] [Created] (FLINK-22125) Revisit the return value of MapState.get when the key doesn't exists

2021-04-06 Thread Dian Fu (Jira)
Dian Fu created FLINK-22125: --- Summary: Revisit the return value of MapState.get when the key doesn't exists Key: FLINK-22125 URL: https://issues.apache.org/jira/browse/FLINK-22125 Project: Flink I

[GitHub] [flink] YuvalItzchakov commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
YuvalItzchakov commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-814092521 @fsk119 I think the code is ready. Waiting for your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[jira] [Created] (FLINK-22124) The job finished without any exception if error was thrown during state access

2021-04-06 Thread Dian Fu (Jira)
Dian Fu created FLINK-22124: --- Summary: The job finished without any exception if error was thrown during state access Key: FLINK-22124 URL: https://issues.apache.org/jira/browse/FLINK-22124 Project: Flink

[GitHub] [flink] flinkbot edited a comment on pull request #15485: [FLINK-20387][table] Support TIMESTAMP_LTZ as rowtime attribute

2021-04-06 Thread GitBox
flinkbot edited a comment on pull request #15485: URL: https://github.com/apache/flink/pull/15485#issuecomment-812897189 ## CI report: * f805a55185df95368d7a1c1ec80717c5f2202b4c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15395: [FLINK-15146][core][ttl] Fix check that incremental cleanup size must be greater than zero

2021-04-06 Thread GitBox
flinkbot edited a comment on pull request #15395: URL: https://github.com/apache/flink/pull/15395#issuecomment-808844283 ## CI report: * dbd3a900a1ae3c4cee4c5de5e8fd7e47d661045c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15393: [FLINK-21980][Runtime/Coordination] ZooKeeperRunningJobsRegistry creates an empty znode

2021-04-06 Thread GitBox
flinkbot edited a comment on pull request #15393: URL: https://github.com/apache/flink/pull/15393#issuecomment-808510341 ## CI report: * a73a44814d28531def35c89a8942629fb4c90ecc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
flinkbot edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-803592550 ## CI report: * 2ef40343abecf693b39b7b7fcb9f6d0d26bf82cd UNKNOWN * ed648357d9c7714245e20e9dfd10abb65393bd82 Azure: [FAILURE](https://dev.azure.com/apache-fl

[jira] [Created] (FLINK-22123) Test state access in Python DataStream API

2021-04-06 Thread Dian Fu (Jira)
Dian Fu created FLINK-22123: --- Summary: Test state access in Python DataStream API Key: FLINK-22123 URL: https://issues.apache.org/jira/browse/FLINK-22123 Project: Flink Issue Type: Test C

[jira] [Commented] (FLINK-22120) Bug when generate code for map get

2021-04-06 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315495#comment-17315495 ] Benchao Li commented on FLINK-22120: [~FrankZou] thanks for reporting this bug, woul

[GitHub] [flink] YuvalItzchakov commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
YuvalItzchakov commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-814080259 @fsk119 Nevermind, I had to run it twice. Pushed the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [flink] fsk119 commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
fsk119 commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-814079910 > @fsk119 Do I need to run the tests in a specific way for the framework to generate the XML? I'm currently running it in IntelliJ with JUnit and it's not generating the file.

[GitHub] [flink] YuvalItzchakov removed a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
YuvalItzchakov removed a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-814079446 @fsk119 Do I need to run the tests in a specific way for the framework to generate the XML? I'm currently running it in IntelliJ with JUnit and it's not generatin

[GitHub] [flink] YuvalItzchakov commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
YuvalItzchakov commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-814079446 @fsk119 Do I need to run the tests in a specific way for the framework to generate the XML? I'm currently running it in IntelliJ with JUnit and it's not generating the fi

[GitHub] [flink] fsk119 commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
fsk119 commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-814077916 You don't need to do it. Just delete the `PushFilterInCalcIntoTableSourceRuleTest.xml` and rerun the `PushFilterInCalcIntoTableSourceRuleTest`. The framework will generate the x

[jira] [Commented] (FLINK-22122) StreamingKafkaITCase Fail due to TestTimedOutException

2021-04-06 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315485#comment-17315485 ] Guowei Ma commented on FLINK-22122: --- https://dev.azure.com/apache-flink/apache-flink/_

[GitHub] [flink] YuvalItzchakov commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
YuvalItzchakov commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-814076225 > ![image](https://user-images.githubusercontent.com/33114724/113709213-d09ca900-9714-11eb-8ee7-8a03fc908d3a.png) > > You can do as I do to reuse the tests.

[GitHub] [flink] fsk119 edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
fsk119 edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-814072413 ![image](https://user-images.githubusercontent.com/33114724/113709213-d09ca900-9714-11eb-8ee7-8a03fc908d3a.png) You can do as I do to reuse the tests. Make `P

[GitHub] [flink] flinkbot edited a comment on pull request #15494: [FLINK-17957] [table-api][parser] Forbidden syntax "CREATE SYSTEM FUNCTION" for sql parser

2021-04-06 Thread GitBox
flinkbot edited a comment on pull request #15494: URL: https://github.com/apache/flink/pull/15494#issuecomment-814059954 ## CI report: * feb716af24dd6257a488f9d2c4d63ff8e5e01f9c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15393: [FLINK-21980][Runtime/Coordination] ZooKeeperRunningJobsRegistry creates an empty znode

2021-04-06 Thread GitBox
flinkbot edited a comment on pull request #15393: URL: https://github.com/apache/flink/pull/15393#issuecomment-808510341 ## CI report: * a73a44814d28531def35c89a8942629fb4c90ecc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Created] (FLINK-22122) StreamingKafkaITCase Fail due to TestTimedOutException

2021-04-06 Thread Guowei Ma (Jira)
Guowei Ma created FLINK-22122: - Summary: StreamingKafkaITCase Fail due to TestTimedOutException Key: FLINK-22122 URL: https://issues.apache.org/jira/browse/FLINK-22122 Project: Flink Issue Type:

[GitHub] [flink] flinkbot edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
flinkbot edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-803592550 ## CI report: * 2ef40343abecf693b39b7b7fcb9f6d0d26bf82cd UNKNOWN * ed648357d9c7714245e20e9dfd10abb65393bd82 Azure: [FAILURE](https://dev.azure.com/apache-fl

[GitHub] [flink] fsk119 edited a comment on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
fsk119 edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-814072413 ![image](https://user-images.githubusercontent.com/33114724/113709213-d09ca900-9714-11eb-8ee7-8a03fc908d3a.png) You can do as I do to reuse the tests. -- This is

[GitHub] [flink] YuvalItzchakov commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
YuvalItzchakov commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-814074061 > > @fsk119 OK, I figured it out. Since I abstracted away `createTableScanAfterPushdown` to the base class, I always returned `FlinkLogicalTableScan.create`. This can't h

[GitHub] [flink] hehuiyuan removed a comment on pull request #15395: [FLINK-15146][core][ttl] Fix check that incremental cleanup size must be greater than zero

2021-04-06 Thread GitBox
hehuiyuan removed a comment on pull request #15395: URL: https://github.com/apache/flink/pull/15395#issuecomment-813999154 @flinkbot re-run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [flink] hehuiyuan commented on pull request #15395: [FLINK-15146][core][ttl] Fix check that incremental cleanup size must be greater than zero

2021-04-06 Thread GitBox
hehuiyuan commented on pull request #15395: URL: https://github.com/apache/flink/pull/15395#issuecomment-814073517 @flinkbot re-run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [flink] fsk119 commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
fsk119 commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-814072413 ![image](https://user-images.githubusercontent.com/33114724/113709213-d09ca900-9714-11eb-8ee7-8a03fc908d3a.png) You can do as I do to reuse the most tests. -- This is an

[GitHub] [flink] fsk119 commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

2021-04-06 Thread GitBox
fsk119 commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-814070442 > @fsk119 OK, I figured it out. Since I abstracted away `createTableScanAfterPushdown` to the base class, I always returned `FlinkLogicalTableScan.create`. This can't happen sinc

[jira] [Updated] (FLINK-21685) Flink JobManager failed to restart from checkpoint in kubernetes HA setup

2021-04-06 Thread Peng Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peng Zhang updated FLINK-21685: --- Attachment: (was: 06-jobmanager-deployment.yaml) > Flink JobManager failed to restart from check

[jira] [Updated] (FLINK-21685) Flink JobManager failed to restart from checkpoint in kubernetes HA setup

2021-04-06 Thread Peng Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peng Zhang updated FLINK-21685: --- Attachment: (was: 03-config.yaml) > Flink JobManager failed to restart from checkpoint in kubern

[jira] [Updated] (FLINK-21685) Flink JobManager failed to restart from checkpoint in kubernetes HA setup

2021-04-06 Thread Peng Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peng Zhang updated FLINK-21685: --- Attachment: (was: scalyr-logs.txt.zip) > Flink JobManager failed to restart from checkpoint in k

[jira] [Updated] (FLINK-21685) Flink JobManager failed to restart from checkpoint in kubernetes HA setup

2021-04-06 Thread Peng Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peng Zhang updated FLINK-21685: --- Attachment: (was: 02-role-binding.yaml) > Flink JobManager failed to restart from checkpoint in

[jira] [Updated] (FLINK-21685) Flink JobManager failed to restart from checkpoint in kubernetes HA setup

2021-04-06 Thread Peng Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peng Zhang updated FLINK-21685: --- Attachment: (was: 01-role.yaml) > Flink JobManager failed to restart from checkpoint in kubernet

[jira] [Updated] (FLINK-21685) Flink JobManager failed to restart from checkpoint in kubernetes HA setup

2021-04-06 Thread Peng Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peng Zhang updated FLINK-21685: --- Attachment: (was: flink-ha.log) > Flink JobManager failed to restart from checkpoint in kubernet

[jira] [Updated] (FLINK-21685) Flink JobManager failed to restart from checkpoint in kubernetes HA setup

2021-04-06 Thread Peng Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peng Zhang updated FLINK-21685: --- Attachment: (was: 08-taskmanager-deployment.yaml) > Flink JobManager failed to restart from chec

[jira] [Created] (FLINK-22121) FlinkLogicalRankRuleBase should check if name of rankNumberType already exists in the input

2021-04-06 Thread Caizhi Weng (Jira)
Caizhi Weng created FLINK-22121: --- Summary: FlinkLogicalRankRuleBase should check if name of rankNumberType already exists in the input Key: FLINK-22121 URL: https://issues.apache.org/jira/browse/FLINK-22121

[jira] [Commented] (FLINK-22014) Flink JobManager failed to restart after failure in kubernetes HA setup

2021-04-06 Thread Mikalai Lushchytski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315479#comment-17315479 ] Mikalai Lushchytski commented on FLINK-22014: - [~trohrmann], I've uploaded t

<    1   2   3   4   >