[GitHub] [flink] Airblader commented on a change in pull request #16285: [FLINK-23070][table-api-java] Introduce TableEnvironment#createTable

2021-07-05 Thread GitBox
Airblader commented on a change in pull request #16285: URL: https://github.com/apache/flink/pull/16285#discussion_r664285145 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/CalcITCase.scala ## @@ -548,4 +549

[GitHub] [flink] twalthr commented on pull request #16374: [FLINK-22880][table] Remove 'blink' term from code base

2021-07-05 Thread GitBox
twalthr commented on pull request #16374: URL: https://github.com/apache/flink/pull/16374#issuecomment-874509412 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-22898) HiveParallelismInference limit return wrong parallelism

2021-07-05 Thread Rui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375292#comment-17375292 ] Rui Li commented on FLINK-22898: Fixed in master: a765da5dc9bc7f56971d1714abc8bce4796f96

[jira] [Commented] (FLINK-23269) json format decode number to vatchar error when define Decimal type in ddl

2021-07-05 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375289#comment-17375289 ] Jark Wu commented on FLINK-23269: - Are you looking for this configuration https://ci.ap

[jira] [Updated] (FLINK-23269) json format decode number to vatchar error when define Decimal type in ddl

2021-07-05 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-23269: Component/s: Table SQL / Ecosystem > json format decode number to vatchar error when define Decimal type i

[GitHub] [flink] flinkbot commented on pull request #16385: [FLINK-23080][datastream] Introduce SinkFunction#finish() method.

2021-07-05 Thread GitBox
flinkbot commented on pull request #16385: URL: https://github.com/apache/flink/pull/16385#issuecomment-874505150 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[jira] [Assigned] (FLINK-23256) Explain string shows output of legacy planner

2021-07-05 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-23256: --- Assignee: Mans Singh > Explain string shows output of legacy planner >

[GitHub] [flink] wuchong commented on pull request #16380: [FLINK-23256][docs][table] - Updated explain output to that of blink planner

2021-07-05 Thread GitBox
wuchong commented on pull request #16380: URL: https://github.com/apache/flink/pull/16380#issuecomment-874504325 cc @leonardBang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[jira] [Closed] (FLINK-23259) [DOCS]The 'window' link on page docs/dev/datastream/operators/overview is failed and 404 is returned

2021-07-05 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-23259. --- Fix Version/s: 1.13.3 1.14.0 Assignee: wuguihu Resolution: Fixed Fixed in

[jira] [Updated] (FLINK-23080) Add finish method to the SinkFunction

2021-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-23080: --- Labels: pull-request-available (was: ) > Add finish method to the SinkFunction > --

[GitHub] [flink] flinkbot commented on pull request #16384: [FLINK-23268][docs] Fix some link issues on page "docs/dev/table/sql…

2021-07-05 Thread GitBox
flinkbot commented on pull request #16384: URL: https://github.com/apache/flink/pull/16384#issuecomment-874503483 ## CI report: * cf2018241cc7100358cdcc4f6b039447f13a7e38 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] dawidwys opened a new pull request #16385: [FLINK-23080][datastream] Introduce SinkFunction#finish() method.

2021-07-05 Thread GitBox
dawidwys opened a new pull request #16385: URL: https://github.com/apache/flink/pull/16385 ## What is the purpose of the change Add an extension point for flushing buffered data in sinks before the final checkpoint. ## Verifying this change This change is already covere

[GitHub] [flink] flinkbot edited a comment on pull request #16348: [FLINK-16093][docs-zh]Translate "System Functions" page of "Functions" into Chinese

2021-07-05 Thread GitBox
flinkbot edited a comment on pull request #16348: URL: https://github.com/apache/flink/pull/16348#issuecomment-872690776 ## CI report: * 01f78c6f750f488bb1922e6aba615ade352cfd94 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #16341: [FLINK-21804][state/changelog] Create and wire changelog storage with state backend

2021-07-05 Thread GitBox
flinkbot edited a comment on pull request #16341: URL: https://github.com/apache/flink/pull/16341#issuecomment-872173720 ## CI report: * 6f5ae240c29fd87d14ef435def533716767da42c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] wuchong merged pull request #16381: [FLINK-23259][docs] Fix the Windows link for Page "docs/dev/datastream…

2021-07-05 Thread GitBox
wuchong merged pull request #16381: URL: https://github.com/apache/flink/pull/16381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[GitHub] [flink] flinkbot edited a comment on pull request #16286: [FLINK-21445] Refactors the PackagedProgramRetriever implementation and adds configuration to PackagedProgram

2021-07-05 Thread GitBox
flinkbot edited a comment on pull request #16286: URL: https://github.com/apache/flink/pull/16286#issuecomment-868270639 ## CI report: * 4cbaee738f213985ae8d6850b36005e0ebafd5bf UNKNOWN * 0556f30737fd827a1b18f9ec585faa1b26a43793 UNKNOWN * a91715f0a81b12c7cc5de3d91ed13194ee91

[GitHub] [flink] AHeise commented on pull request #15950: [FLINK-22700] [api] Propagate watermarks to sink API

2021-07-05 Thread GitBox
AHeise commented on pull request #15950: URL: https://github.com/apache/flink/pull/15950#issuecomment-874502712 Thanks @tzulitai ! @EronWright please don't forget to update the status in the FLIP pages (overview and FLIP-167). -- This is an automated message from the Apache Git Service.

[GitHub] [flink] flinkbot edited a comment on pull request #16173: [FLINK-15031][runtime] Calculate required shuffle memory before allocating slots if resources are specified

2021-07-05 Thread GitBox
flinkbot edited a comment on pull request #16173: URL: https://github.com/apache/flink/pull/16173#issuecomment-862370157 ## CI report: * ed948a42825ed6511e31c778c727328fc4150c72 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Closed] (FLINK-23260) [DOCS]The link on page docs/libs/gelly/overview is failed and 404 is returned

2021-07-05 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-23260. --- Fix Version/s: 1.13.3 1.14.0 Assignee: wuguihu Resolution: Fixed Fixed in

[GitHub] [flink] AHeise commented on a change in pull request #15972: Add common source and operator metrics.

2021-07-05 Thread GitBox
AHeise commented on a change in pull request #15972: URL: https://github.com/apache/flink/pull/15972#discussion_r664276017 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/InternalSourceMetricGroup.java ## @@ -0,0 +1,133 @@ +/* + * Licensed to

[GitHub] [flink] wuchong merged pull request #16382: [FLINK-23260][docs] Fix the link for Page "docs/libs/gelly/overview"

2021-07-05 Thread GitBox
wuchong merged pull request #16382: URL: https://github.com/apache/flink/pull/16382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[GitHub] [flink] AHeise commented on a change in pull request #15972: Add common source and operator metrics.

2021-07-05 Thread GitBox
AHeise commented on a change in pull request #15972: URL: https://github.com/apache/flink/pull/15972#discussion_r664275730 ## File path: flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/groups/SourceMetricGroup.java ## @@ -0,0 +1,71 @@ +/* + * Licensed t

[GitHub] [flink] AHeise commented on a change in pull request #15972: Add common source and operator metrics.

2021-07-05 Thread GitBox
AHeise commented on a change in pull request #15972: URL: https://github.com/apache/flink/pull/15972#discussion_r664274339 ## File path: flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/SettableGauge.java ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apach

[jira] [Closed] (FLINK-22700) [FLIP-167] Propagate watermarks to Sink API

2021-07-05 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai closed FLINK-22700. --- Resolution: Fixed Merged with flink/master: c0244d36fcdf9fe5479eb13c9304d6204eaba320

[GitHub] [flink] tzulitai closed pull request #15950: [FLINK-22700] [api] Propagate watermarks to sink API

2021-07-05 Thread GitBox
tzulitai closed pull request #15950: URL: https://github.com/apache/flink/pull/15950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[GitHub] [flink] AHeise commented on a change in pull request #15972: Add common source and operator metrics.

2021-07-05 Thread GitBox
AHeise commented on a change in pull request #15972: URL: https://github.com/apache/flink/pull/15972#discussion_r664273161 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java ## @@ -291,13 +300,23 @@ public InputStatus

[GitHub] [flink] AHeise commented on a change in pull request #15972: Add common source and operator metrics.

2021-07-05 Thread GitBox
AHeise commented on a change in pull request #15972: URL: https://github.com/apache/flink/pull/15972#discussion_r664271814 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/InternalSourceMetricGroup.java ## @@ -0,0 +1,133 @@ +/* + * Licensed to

[GitHub] [flink] tzulitai commented on pull request #15950: [FLINK-22700] [api] Propagate watermarks to sink API

2021-07-05 Thread GitBox
tzulitai commented on pull request #15950: URL: https://github.com/apache/flink/pull/15950#issuecomment-874498594 Merging this. You should still have access though @EronWright, unless something was messed up then we should probably try to fix it for you. -- This is an automated message f

[jira] [Commented] (FLINK-20321) Get NPE when using AvroDeserializationSchema to deserialize null input

2021-07-05 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375269#comment-17375269 ] Jark Wu commented on FLINK-20321: - [~hehuiyuan] I can help to merge if there is a pull r

[GitHub] [flink] AHeise commented on a change in pull request #15972: Add common source and operator metrics.

2021-07-05 Thread GitBox
AHeise commented on a change in pull request #15972: URL: https://github.com/apache/flink/pull/15972#discussion_r664271814 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/InternalSourceMetricGroup.java ## @@ -0,0 +1,133 @@ +/* + * Licensed to

[jira] [Updated] (FLINK-22994) Improve the performance of nesting udf invoking

2021-07-05 Thread lynn1.zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lynn1.zhang updated FLINK-22994: Description: h1. BackGround In some nesting udf invoking cases, Flink convert the udf result to e

[jira] [Updated] (FLINK-23268) [DOCS]The link on page docs/dev/table/sql/queries/match_recognize/ is failed and 404 is returned

2021-07-05 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-23268: Component/s: Table SQL / API > [DOCS]The link on page docs/dev/table/sql/queries/match_recognize/ is faile

[jira] [Created] (FLINK-23269) json format decode number to vatchar error when define Decimal type in ddl

2021-07-05 Thread silence (Jira)
silence created FLINK-23269: --- Summary: json format decode number to vatchar error when define Decimal type in ddl Key: FLINK-23269 URL: https://issues.apache.org/jira/browse/FLINK-23269 Project: Flink

[GitHub] [flink] AHeise commented on a change in pull request #15972: Add common source and operator metrics.

2021-07-05 Thread GitBox
AHeise commented on a change in pull request #15972: URL: https://github.com/apache/flink/pull/15972#discussion_r664270878 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/InternalSourceMetricGroup.java ## @@ -0,0 +1,133 @@ +/* + * Licensed to

[GitHub] [flink] AHeise commented on a change in pull request #15972: Add common source and operator metrics.

2021-07-05 Thread GitBox
AHeise commented on a change in pull request #15972: URL: https://github.com/apache/flink/pull/15972#discussion_r664270238 ## File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/reader/RecordsWithSplitIds.java ## @@ -18,12 +18,

[jira] [Closed] (FLINK-23095) Close the channel unspilling thread pool after restore

2021-07-05 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-23095. Resolution: Fixed Fixed in 869f6b03e8b48ba29765d29e8554ccb10419f08f > Close the channel u

[jira] [Closed] (FLINK-22972) Deprecate/Remove StreamOperator#dispose method

2021-07-05 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-22972. Resolution: Fixed Implemented in 63183d8a2a1267f31fdfafebb628bf61409a094e..a66a9153859d4e

[jira] [Closed] (FLINK-22972) Deprecate/Remove StreamOperator#dispose method

2021-07-05 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-22972. Resolution: Implemented > Deprecate/Remove StreamOperator#dispose method > ---

[jira] [Reopened] (FLINK-22972) Deprecate/Remove StreamOperator#dispose method

2021-07-05 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz reopened FLINK-22972: -- > Deprecate/Remove StreamOperator#dispose method > ---

[jira] [Updated] (FLINK-22994) Improve the performance of nesting udf invoking

2021-07-05 Thread lynn1.zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lynn1.zhang updated FLINK-22994: Description: h1. BackGround In some nesting udf invoking cases, Flink convert the udf result to e

[jira] [Commented] (FLINK-9673) Improve State efficiency of bounded OVER window operators

2021-07-05 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-9673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375257#comment-17375257 ] Jark Wu commented on FLINK-9673: Yes [~twalthr]. > Improve State efficiency of bounded O

[jira] [Updated] (FLINK-22994) Improve the performance of nesting udf invoking

2021-07-05 Thread lynn1.zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lynn1.zhang updated FLINK-22994: Description: h1. BackGround In some nesting udf invoking cases, Flink convert the udf result to e

[jira] [Updated] (FLINK-22994) Improve the performance of nesting udf invoking

2021-07-05 Thread lynn1.zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lynn1.zhang updated FLINK-22994: Description: h1. BackGround In some nesting udf invoking cases, Flink convert the udf result to e

[GitHub] [flink] dawidwys merged pull request #16360: [FLINK-23095][runtime] Close the channel unspilling thread pool after restore

2021-07-05 Thread GitBox
dawidwys merged pull request #16360: URL: https://github.com/apache/flink/pull/16360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[GitHub] [flink] dawidwys closed pull request #16351: [FLINK-22972][datastream] Remove StreamOperator#dispose in favour of close and finish

2021-07-05 Thread GitBox
dawidwys closed pull request #16351: URL: https://github.com/apache/flink/pull/16351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[jira] [Commented] (FLINK-7403) Remove expandLocalRef() before code generation

2021-07-05 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-7403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375254#comment-17375254 ] Jark Wu commented on FLINK-7403: Yes [~twalthr]. cc [~lzljs3620320] > Remove expandLocal

[jira] [Commented] (FLINK-8566) Replace retract/insert of same record for state retention timer resets

2021-07-05 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-8566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375252#comment-17375252 ] Jark Wu commented on FLINK-8566: [~twalthr] yes, this issue is still valid for blink plan

[GitHub] [flink] TsReaper commented on a change in pull request #16349: [FLINK-23150][table-planner-blink] Enable Java code splitting for all generated classes

2021-07-05 Thread GitBox
TsReaper commented on a change in pull request #16349: URL: https://github.com/apache/flink/pull/16349#discussion_r664265037 ## File path: flink-table/flink-table-planner-blink/pom.xml ## @@ -378,6 +378,8 @@ under the License.

[GitHub] [flink] lirui-apache closed pull request #16310: [FLINK-22898][Connectors/Hive] return default-parallelism in HiveParallelismInference when there is no source infer

2021-07-05 Thread GitBox
lirui-apache closed pull request #16310: URL: https://github.com/apache/flink/pull/16310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [flink-shaded] bjlvfei closed issue #94: Caused by: org.apache.flink.core.fs.UnsupportedFileSystemSchemeException: Hadoop is not in the classpath/dependencies

2021-07-05 Thread GitBox
bjlvfei closed issue #94: URL: https://github.com/apache/flink-shaded/issues/94 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[GitHub] [flink-shaded] bjlvfei commented on issue #94: Caused by: org.apache.flink.core.fs.UnsupportedFileSystemSchemeException: Hadoop is not in the classpath/dependencies

2021-07-05 Thread GitBox
bjlvfei commented on issue #94: URL: https://github.com/apache/flink-shaded/issues/94#issuecomment-874491433 Hi @tillrohrmann I'm also check the Flink document where also mentioned these Filesytem plugins. I will close the issue if there is no need any Hadoop dependency. Sure. I

[GitHub] [flink] flinkbot edited a comment on pull request #16348: [FLINK-16093][docs-zh]Translate "System Functions" page of "Functions" into Chinese

2021-07-05 Thread GitBox
flinkbot edited a comment on pull request #16348: URL: https://github.com/apache/flink/pull/16348#issuecomment-872690776 ## CI report: * 01f78c6f750f488bb1922e6aba615ade352cfd94 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot commented on pull request #16384: [FLINK-23268][docs] Fix some link issues on page "docs/dev/table/sql…

2021-07-05 Thread GitBox
flinkbot commented on pull request #16384: URL: https://github.com/apache/flink/pull/16384#issuecomment-874488845 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[jira] [Updated] (FLINK-23268) [DOCS]The link on page docs/dev/table/sql/queries/match_recognize/ is failed and 404 is returned

2021-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-23268: --- Labels: pull-request-available (was: ) > [DOCS]The link on page docs/dev/table/sql/queries/

[GitHub] [flink] hapihu opened a new pull request #16384: [FLINK-23268][docs] Fix some link issues on page "docs/dev/table/sql…

2021-07-05 Thread GitBox
hapihu opened a new pull request #16384: URL: https://github.com/apache/flink/pull/16384 Some link information on the page is incorrectly written, resulting in a 404 page. Modify the [English document](https://github.com/apache/flink/blob/master/docs/content/docs/dev/table/sql/queri

[GitHub] [flink] zicat commented on pull request #16163: [FLINK-22994][Table SQL / Planner] improve the performace of invoking…

2021-07-05 Thread GitBox
zicat commented on pull request #16163: URL: https://github.com/apache/flink/pull/16163#issuecomment-874486894 > Hi @zicat What do you think about the `copy` method? Override copy method is the simplest way for this issue. Exactly It's dangerous when Copy the field of resultType beca

[GitHub] [flink] zicat commented on a change in pull request #16163: [FLINK-22994][Table SQL / Planner] improve the performace of invoking…

2021-07-05 Thread GitBox
zicat commented on a change in pull request #16163: URL: https://github.com/apache/flink/pull/16163#discussion_r657706409 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/calls/BridgingFunctionGenUtil.scala ## @@ -288,16

[GitHub] [flink] flinkbot edited a comment on pull request #16286: [FLINK-21445] Refactors the PackagedProgramRetriever implementation and adds configuration to PackagedProgram

2021-07-05 Thread GitBox
flinkbot edited a comment on pull request #16286: URL: https://github.com/apache/flink/pull/16286#issuecomment-868270639 ## CI report: * 4cbaee738f213985ae8d6850b36005e0ebafd5bf UNKNOWN * 0556f30737fd827a1b18f9ec585faa1b26a43793 UNKNOWN * a91715f0a81b12c7cc5de3d91ed13194ee91

[jira] [Created] (FLINK-23268) [DOCS]The link on page docs/dev/table/sql/queries/match_recognize/ is failed and 404 is returned

2021-07-05 Thread wuguihu (Jira)
wuguihu created FLINK-23268: --- Summary: [DOCS]The link on page docs/dev/table/sql/queries/match_recognize/ is failed and 404 is returned Key: FLINK-23268 URL: https://issues.apache.org/jira/browse/FLINK-23268

[GitHub] [flink] flinkbot edited a comment on pull request #16352: [FLINK-23102][runtime] Accessing FlameGraphs while not being enabled …

2021-07-05 Thread GitBox
flinkbot edited a comment on pull request #16352: URL: https://github.com/apache/flink/pull/16352#issuecomment-872812232 ## CI report: * 650ecc5d383fa6ace3293b5022e964107b99ba01 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Updated] (FLINK-23150) Clean up the old implementation of code splitting

2021-07-05 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng updated FLINK-23150: Description: In the third step we clean up the old implementation of code splitting. (was: In the

[jira] [Created] (FLINK-23267) Activate Java code splitter for all generated classes

2021-07-05 Thread Caizhi Weng (Jira)
Caizhi Weng created FLINK-23267: --- Summary: Activate Java code splitter for all generated classes Key: FLINK-23267 URL: https://issues.apache.org/jira/browse/FLINK-23267 Project: Flink Issue Typ

[jira] [Commented] (FLINK-22677) Scheduler should invoke ShuffleMaster#registerPartitionWithProducer by a real asynchronous fashion

2021-07-05 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375218#comment-17375218 ] Zhu Zhu commented on FLINK-22677: - One thing need to mention is that I did not change {{

[jira] [Commented] (FLINK-22677) Scheduler should invoke ShuffleMaster#registerPartitionWithProducer by a real asynchronous fashion

2021-07-05 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375217#comment-17375217 ] Zhu Zhu commented on FLINK-22677: - Problems below could happen if enabling partition reg

[GitHub] [flink] XComp commented on pull request #16286: [FLINK-21445] Refactors the PackagedProgramRetriever implementation and adds configuration to PackagedProgram

2021-07-05 Thread GitBox
XComp commented on pull request #16286: URL: https://github.com/apache/flink/pull/16286#issuecomment-874463733 I reorganized the commits squashing most of them together and rebased the branch to the most recent `master` -- This is an automated message from the Apache Git Service. To resp

[GitHub] [flink] flinkbot edited a comment on pull request #16383: [FLINK-22677][runtime] DefaultScheduler supports async registration of produced partitions

2021-07-05 Thread GitBox
flinkbot edited a comment on pull request #16383: URL: https://github.com/apache/flink/pull/16383#issuecomment-874451793 ## CI report: * 2261906218ec3345b677703e3f79511436e5eac9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Assigned] (FLINK-23126) Refactor smoke-e2e into smoke-e2e-common and smoke-e2e-embedded

2021-07-05 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai reassigned FLINK-23126: --- Assignee: Evans Ye > Refactor smoke-e2e into smoke-e2e-common and smoke-e2e

[jira] [Comment Edited] (FLINK-23237) Add log to print data that failed to deserialize when ignore-parse-error=true

2021-07-05 Thread hehuiyuan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375188#comment-17375188 ] hehuiyuan edited comment on FLINK-23237 at 7/6/21, 4:54 AM:

[jira] [Commented] (FLINK-23126) Refactor smoke-e2e into smoke-e2e-common and smoke-e2e-embedded

2021-07-05 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375213#comment-17375213 ] Tzu-Li (Gordon) Tai commented on FLINK-23126: - Assigning this to [~evans_ye]

[jira] [Commented] (FLINK-20321) Get NPE when using AvroDeserializationSchema to deserialize null input

2021-07-05 Thread hehuiyuan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375211#comment-17375211 ] hehuiyuan commented on FLINK-20321: --- Hi [~jark] , is it considered merging to 1.12? >

[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers

2021-07-05 Thread GitBox
flinkbot edited a comment on pull request #11877: URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998 ## CI report: * 109e1d36469b537f997a7c844e57e23729a1af21 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Issue Comment Deleted] (FLINK-23237) Add log to print data that failed to deserialize when ignore-parse-error=true

2021-07-05 Thread hehuiyuan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hehuiyuan updated FLINK-23237: -- Comment: was deleted (was:   CSV format: {code:java} @Override public RowData deserialize(byte[] mess

[jira] [Commented] (FLINK-10734) Temporal joins on heavily filtered tables might fail in planning

2021-07-05 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-10734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375207#comment-17375207 ] Leonard Xu commented on FLINK-10734: [~twalthr] Although the bug still exits in lega

[GitHub] [flink] flinkbot commented on pull request #16383: [FLINK-22677][runtime] DefaultScheduler supports async registration of produced partitions

2021-07-05 Thread GitBox
flinkbot commented on pull request #16383: URL: https://github.com/apache/flink/pull/16383#issuecomment-874451793 ## CI report: * 2261906218ec3345b677703e3f79511436e5eac9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] flinkbot edited a comment on pull request #16353: [FLINK-23074][connector-hive] Shade parquet class in hive-exec to prevent conflict.

2021-07-05 Thread GitBox
flinkbot edited a comment on pull request #16353: URL: https://github.com/apache/flink/pull/16353#issuecomment-872850709 ## CI report: * 2cfdc338bbed942d0110eec248f2558b6ad80744 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #16332: [FLINK-22386] Introduce cache for docker images used during testing

2021-07-05 Thread GitBox
flinkbot edited a comment on pull request #16332: URL: https://github.com/apache/flink/pull/16332#issuecomment-871230385 ## CI report: * 6fbeae06b2487f2c26d447dd2fc11f545c7c30c3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #16192: [FLINK-22954][table-planner-blink] Rewrite Join on constant TableFunctionScan to Correlate

2021-07-05 Thread GitBox
flinkbot edited a comment on pull request #16192: URL: https://github.com/apache/flink/pull/16192#issuecomment-863860019 ## CI report: * 5723b973413cc91205872e93e6c876bea2163fde Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers

2021-07-05 Thread GitBox
flinkbot edited a comment on pull request #11877: URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998 ## CI report: * 109e1d36469b537f997a7c844e57e23729a1af21 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Closed] (FLINK-23225) There is some mismatches between the current translation and the latest English version on the Flink-Architecture page

2021-07-05 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-23225. --- Fix Version/s: 1.14.0 Assignee: wuguihu Resolution: Fixed Fixed in master: bf7bd78f8a6065b8d

[GitHub] [flink] wuchong merged pull request #16363: [FLINK-23225][doc-zh]Fixed some mismatches in the translation pages

2021-07-05 Thread GitBox
wuchong merged pull request #16363: URL: https://github.com/apache/flink/pull/16363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[jira] [Resolved] (FLINK-22884) Select view columns fail when store metadata with hive

2021-07-05 Thread Rui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Li resolved FLINK-22884. Fix Version/s: 1.13.3 1.14.0 Resolution: Fixed Fixed in master: 0b686824c33ad976

[GitHub] [flink] flinkbot edited a comment on pull request #16367: [FLINK-21448][configuration] Randomize ITTests for delegating state backend

2021-07-05 Thread GitBox
flinkbot edited a comment on pull request #16367: URL: https://github.com/apache/flink/pull/16367#issuecomment-873765195 ## CI report: * 45c95095271826d9d9263b914d1a31de36e6bd0e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #16353: [FLINK-23074][connector-hive] Shade parquet class in hive-exec to prevent conflict.

2021-07-05 Thread GitBox
flinkbot edited a comment on pull request #16353: URL: https://github.com/apache/flink/pull/16353#issuecomment-872850709 ## CI report: * 2cfdc338bbed942d0110eec248f2558b6ad80744 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #16192: [FLINK-22954][table-planner-blink] Rewrite Join on constant TableFunctionScan to Correlate

2021-07-05 Thread GitBox
flinkbot edited a comment on pull request #16192: URL: https://github.com/apache/flink/pull/16192#issuecomment-863860019 ## CI report: * 5723b973413cc91205872e93e6c876bea2163fde Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #16163: [FLINK-22994][Table SQL / Planner] improve the performace of invoking…

2021-07-05 Thread GitBox
flinkbot edited a comment on pull request #16163: URL: https://github.com/apache/flink/pull/16163#issuecomment-861284972 ## CI report: * 00f7cd34fc503db8cc116dd201bcc7f54a4b6f20 UNKNOWN * da303c24e513b0678794526c6351003b6e76cb6d UNKNOWN * 4133ee287c23af5da472db1098c9d7ab51b8

[jira] [Commented] (FLINK-23237) Add log to print data that failed to deserialize when ignore-parse-error=true

2021-07-05 Thread hehuiyuan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375189#comment-17375189 ] hehuiyuan commented on FLINK-23237: ---   CSV format: {code:java} @Override public RowDa

[jira] [Comment Edited] (FLINK-23237) Add log to print data that failed to deserialize when ignore-parse-error=true

2021-07-05 Thread hehuiyuan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375188#comment-17375188 ] hehuiyuan edited comment on FLINK-23237 at 7/6/21, 3:50 AM:

[GitHub] [flink] flinkbot commented on pull request #16383: [FLINK-22677][runtime] DefaultScheduler supports async registration of produced partitions

2021-07-05 Thread GitBox
flinkbot commented on pull request #16383: URL: https://github.com/apache/flink/pull/16383#issuecomment-874437979 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[jira] [Commented] (FLINK-23237) Add log to print data that failed to deserialize when ignore-parse-error=true

2021-07-05 Thread hehuiyuan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375188#comment-17375188 ] hehuiyuan commented on FLINK-23237: --- [~Aiden Gong] thanks , code is right.   Additio

[jira] [Updated] (FLINK-22662) YARNHighAvailabilityITCase.testKillYarnSessionClusterEntrypoint fail

2021-07-05 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song updated FLINK-22662: - Labels: pull-request-available test-stability (was: pull-request-available stale-assigned test-

[jira] [Updated] (FLINK-22677) Scheduler should invoke ShuffleMaster#registerPartitionWithProducer by a real asynchronous fashion

2021-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-22677: --- Labels: pull-request-available (was: ) > Scheduler should invoke ShuffleMaster#registerPart

[jira] [Updated] (FLINK-23237) Add log to print data that failed to deserialize when ignore-parse-error=true

2021-07-05 Thread hehuiyuan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hehuiyuan updated FLINK-23237: -- Description: Add log to print error data that failed to deserialize when set `ignore-parse-error` = `

[jira] [Updated] (FLINK-23237) Add log to print data that failed to deserialize when ignore-parse-error=true

2021-07-05 Thread hehuiyuan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hehuiyuan updated FLINK-23237: -- Summary: Add log to print data that failed to deserialize when ignore-parse-error=true (was: Add lo

[GitHub] [flink] zhuzhurk opened a new pull request #16383: [FLINK-22677][runtime] DefaultScheduler supports async registration of produced partitions

2021-07-05 Thread GitBox
zhuzhurk opened a new pull request #16383: URL: https://github.com/apache/flink/pull/16383 ## What is the purpose of the change This PR is to improve `DefaultScheduler` to support async registration of produced partitions. More details see FLINK-22677. ## Brief change l

[GitHub] [flink] zhangyy91 commented on a change in pull request #16367: [FLINK-21448][configuration] Randomize ITTests for delegating state backend

2021-07-05 Thread GitBox
zhangyy91 commented on a change in pull request #16367: URL: https://github.com/apache/flink/pull/16367#discussion_r664216072 ## File path: flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/streaming/util/TestStreamEnvironment.java ## @@ -75,36 +81,28 @@

[GitHub] [flink] Zakelly commented on a change in pull request #16341: [FLINK-21804][state/changelog] Create and wire changelog storage with state backend

2021-07-05 Thread GitBox
Zakelly commented on a change in pull request #16341: URL: https://github.com/apache/flink/pull/16341#discussion_r664212980 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/StateChangelogStorageLoader.java ## @@ -18,26 +18,81 @@ package org.a

[jira] [Commented] (FLINK-23219) temproary join ttl configruation does not take effect

2021-07-05 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375181#comment-17375181 ] Caizhi Weng commented on FLINK-23219: - Hi [~waywtdcc]! Thanks for your interest in

[GitHub] [flink] lirui-apache closed pull request #16149: [FLINK-22884][hive] HiveCatalog should mark views as generic and stor…

2021-07-05 Thread GitBox
lirui-apache closed pull request #16149: URL: https://github.com/apache/flink/pull/16149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [flink] flinkbot edited a comment on pull request #16367: [FLINK-21448][configuration] Randomize ITTests for delegating state backend

2021-07-05 Thread GitBox
flinkbot edited a comment on pull request #16367: URL: https://github.com/apache/flink/pull/16367#issuecomment-873765195 ## CI report: * 45c95095271826d9d9263b914d1a31de36e6bd0e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] JingsongLi commented on a change in pull request #16349: [FLINK-23150][table-planner-blink] Enable Java code splitting for all generated classes

2021-07-05 Thread GitBox
JingsongLi commented on a change in pull request #16349: URL: https://github.com/apache/flink/pull/16349#discussion_r664210234 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/TableConfigOptions.java ## @@ -94,8 +94,16 @@ private T

  1   2   3   4   5   6   7   >