[GitHub] [flink] MartijnVisser commented on pull request #17360: [FLINK-24379][Formats] Add support for Glue schema registry in Table API

2021-09-28 Thread GitBox
MartijnVisser commented on pull request #17360: URL: https://github.com/apache/flink/pull/17360#issuecomment-929009820 We're receiving a lot of community feedback that new features are not or not properly documented. It would be really good if we can get the documentation in with this PR.

[GitHub] [flink] xintongsong commented on a change in pull request #17362: [FLINK-24377][runtime] Fix TM potentially not released after heartbeat timeout.

2021-09-28 Thread GitBox
xintongsong commented on a change in pull request #17362: URL: https://github.com/apache/flink/pull/17362#discussion_r717176438 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java ## @@ -492,7 +492,8 @@ protected void onWorke

[GitHub] [flink] flinkbot commented on pull request #17375: [FLINK-24398][connectors/kafka] KafkaSourceFetcherManager should re-use an existing SplitFetcher to commit offset if possible

2021-09-28 Thread GitBox
flinkbot commented on pull request #17375: URL: https://github.com/apache/flink/pull/17375#issuecomment-929178305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [flink] matriv commented on a change in pull request #17341: [hotfix][test] Refactor BuiltInFunctions IT Tests

2021-09-28 Thread GitBox
matriv commented on a change in pull request #17341: URL: https://github.com/apache/flink/pull/17341#discussion_r717367218 ## File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/BuiltInFunctionTestBase.java ## @@ -261,6 +248,14 @@

[GitHub] [flink] infoverload commented on pull request #17349: [FLINK-24370][documentation] Added documentation for Asynchronous Sin…

2021-09-28 Thread GitBox
infoverload commented on pull request #17349: URL: https://github.com/apache/flink/pull/17349#issuecomment-929033854 After reading through the issue and the changes, I also think that a combination of JavaDocs and creating a blog post is a good idea -- This is an automated message from

[GitHub] [flink] flinkbot commented on pull request #17371: [BP-1.13][FLINK-24380][k8s] Terminate the pod if it failed

2021-09-28 Thread GitBox
flinkbot commented on pull request #17371: URL: https://github.com/apache/flink/pull/17371#issuecomment-929018020 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [flink-benchmarks] dawidwys commented on pull request #32: [FLINK-24230] Buffer debloating microbenchmark for single gate

2021-09-28 Thread GitBox
dawidwys commented on pull request #32: URL: https://github.com/apache/flink-benchmarks/pull/32#issuecomment-929184496 I tried changing the debloating target with basically a similar outcome. Changing the threshold also doesn't seem to help and does not have any visible effect. After some

[GitHub] [flink] flinkbot edited a comment on pull request #17378: [hotfix][docs] Move out the time zone page from streaming concepts section #17377

2021-09-28 Thread GitBox
flinkbot edited a comment on pull request #17378: URL: https://github.com/apache/flink/pull/17378#issuecomment-929395351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] AHeise closed pull request #7229: [FLINK-11060][scala-shell] Unable to set number of task manager and slot per task manager in scala shell local mode

2021-09-28 Thread GitBox
AHeise closed pull request #7229: URL: https://github.com/apache/flink/pull/7229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [flink] fapaul commented on a change in pull request #17374: [FLINK-24327][connectors/elasticsearch] Add Elasticsearch 7 sink for table API

2021-09-28 Thread GitBox
fapaul commented on a change in pull request #17374: URL: https://github.com/apache/flink/pull/17374#discussion_r717513726 ## File path: flink-connectors/flink-connector-elasticsearch7/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/table/Elasticsearch7ConnectorOptio

[GitHub] [flink] dannycranmer commented on a change in pull request #17360: [FLINK-24379][Formats] Add support for Glue schema registry in Table API

2021-09-28 Thread GitBox
dannycranmer commented on a change in pull request #17360: URL: https://github.com/apache/flink/pull/17360#discussion_r717342648 ## File path: flink-formats/flink-avro-glue-schema-registry/src/main/java/org/apache/flink/formats/avro/glue/schema/registry/GlueSchemaRegistryAvroFormatFac

[GitHub] [flink] flinkbot edited a comment on pull request #17361: [FLINK-24380][k8s] Terminate the pod if it failed

2021-09-28 Thread GitBox
flinkbot edited a comment on pull request #17361: URL: https://github.com/apache/flink/pull/17361#issuecomment-927655234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #14544: [FLINK-20845] Drop Scala 2.11 support

2021-09-28 Thread GitBox
flinkbot edited a comment on pull request #14544: URL: https://github.com/apache/flink/pull/14544#issuecomment-753633967 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink-web] syhily commented on a change in pull request #468: Release blog post 1.14 draft iteration

2021-09-28 Thread GitBox
syhily commented on a change in pull request #468: URL: https://github.com/apache/flink-web/pull/468#discussion_r717176500 ## File path: _posts/2021-09-21-release-1.14.0.md ## @@ -0,0 +1,344 @@ +--- +layout: post +title: "Apache Flink 1.14.0 Release Announcement" +date: 2021-

[GitHub] [flink] rkhachatryan commented on a change in pull request #16606: [FLINK-21357][runtime/statebackend]Periodic materialization for generalized incremental checkpoints

2021-09-28 Thread GitBox
rkhachatryan commented on a change in pull request #16606: URL: https://github.com/apache/flink/pull/16606#discussion_r717260198 ## File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/materializer/PeriodicMaterializer.java ##

[GitHub] [flink] flinkbot edited a comment on pull request #17341: [FLINK-24394][test] Refactor BuiltInFunctions IT Tests

2021-09-28 Thread GitBox
flinkbot edited a comment on pull request #17341: URL: https://github.com/apache/flink/pull/17341#issuecomment-925901262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot commented on pull request #17373: [hotfix] [docs-zh] Add auxiliary words to make the sentence flow smoothly

2021-09-28 Thread GitBox
flinkbot commented on pull request #17373: URL: https://github.com/apache/flink/pull/17373#issuecomment-929038094 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [flink] flinkbot edited a comment on pull request #17367: [FLINK-24382][metrics] Do not compute recordsOut metric in SinkOperat…

2021-09-28 Thread GitBox
flinkbot edited a comment on pull request #17367: URL: https://github.com/apache/flink/pull/17367#issuecomment-928966227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink-ml] zhipeng93 commented on pull request #9: [hotfix] Fix pom.xml and delete outdated files

2021-09-28 Thread GitBox
zhipeng93 commented on pull request #9: URL: https://github.com/apache/flink-ml/pull/9#issuecomment-928615913 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[GitHub] [flink] flinkbot edited a comment on pull request #17362: [FLINK-24377][runtime] Fix TM potentially not released after heartbeat timeout.

2021-09-28 Thread GitBox
flinkbot edited a comment on pull request #17362: URL: https://github.com/apache/flink/pull/17362#issuecomment-927655340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] curcur commented on pull request #16606: [FLINK-21357][runtime/statebackend]Periodic materialization for generalized incremental checkpoints

2021-09-28 Thread GitBox
curcur commented on pull request #16606: URL: https://github.com/apache/flink/pull/16606#issuecomment-928775970 > Thanks updating the PR @curcur. > > I've left some comments, PTAL. > > Besides that, could you please name the extracted commits according to [conventions](https:/

[GitHub] [flink] flinkbot edited a comment on pull request #17377: [hotfix][docs] Move out the time zone page from streaming concepts section

2021-09-28 Thread GitBox
flinkbot edited a comment on pull request #17377: URL: https://github.com/apache/flink/pull/17377#issuecomment-929395259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] jherico commented on pull request #17360: [FLINK-24379][Formats] Add support for Glue schema registry in Table API

2021-09-28 Thread GitBox
jherico commented on pull request #17360: URL: https://github.com/apache/flink/pull/17360#issuecomment-929472860 Responded to feedback, modified changelog mode to match existing code, added format document. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [flink] flinkbot edited a comment on pull request #17364: [FLINK-24371][datastream] Call preCommit on SinkWriter although no committer is available

2021-09-28 Thread GitBox
flinkbot edited a comment on pull request #17364: URL: https://github.com/apache/flink/pull/17364#issuecomment-927811962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] sjwiesman commented on pull request #17349: [FLINK-24370][documentation] Added documentation for Asynchronous Sin…

2021-09-28 Thread GitBox
sjwiesman commented on pull request #17349: URL: https://github.com/apache/flink/pull/17349#issuecomment-928281640 My vote is to leave this out of the Flink docs for now. Please feel free to turn any or all of this content into JavaDoc, and we'd love to support you in getting a blog post o

[GitHub] [flink] flinkbot edited a comment on pull request #17374: [FLINK-24327][connectors/elasticsearch] Add Elasticsearch 7 sink for table API

2021-09-28 Thread GitBox
flinkbot edited a comment on pull request #17374: URL: https://github.com/apache/flink/pull/17374#issuecomment-929172201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] xintongsong commented on pull request #17362: [FLINK-24377][runtime] Fix TM potentially not released after heartbeat timeout.

2021-09-28 Thread GitBox
xintongsong commented on pull request #17362: URL: https://github.com/apache/flink/pull/17362#issuecomment-928655861 @wangyang0918, thanks for the review. Comments addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [flink] MartijnVisser commented on pull request #17349: [FLINK-24370][documentation] Added documentation for Asynchronous Sin…

2021-09-28 Thread GitBox
MartijnVisser commented on pull request #17349: URL: https://github.com/apache/flink/pull/17349#issuecomment-929007543 I would leave it out of the Flink docs and work together on creating a blog post out of this. I do believe the AsyncSinkBase will be in 1.15, so we should do a blog when t

[GitHub] [flink] twalthr commented on pull request #17341: [FLINK-24394][test] Refactor BuiltInFunctions IT Tests

2021-09-28 Thread GitBox
twalthr commented on pull request #17341: URL: https://github.com/apache/flink/pull/17341#issuecomment-929319845 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] AHeise commented on pull request #11895: [FLINK-10911][scala-shell] Enable flink-scala-shell with Scala 2.12

2021-09-28 Thread GitBox
AHeise commented on pull request #11895: URL: https://github.com/apache/flink/pull/11895#issuecomment-929224060 Closing this PR due to https://issues.apache.org/jira/browse/FLINK-24360 / https://github.com/apache/flink/pull/17340 -- This is an automated message from the Apache Git Servic

[GitHub] [flink] flinkbot edited a comment on pull request #17352: [FLINK-10230][table] Support 'SHOW CREATE VIEW' syntax to print the query of a view

2021-09-28 Thread GitBox
flinkbot edited a comment on pull request #17352: URL: https://github.com/apache/flink/pull/17352#issuecomment-926627700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17372: [BP-1.13][FLINK-24377][runtime] Fix TM potentially not released after heartbeat timeout.

2021-09-28 Thread GitBox
flinkbot edited a comment on pull request #17372: URL: https://github.com/apache/flink/pull/17372#issuecomment-929030512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] AHeise merged pull request #17351: [FLINK-24371][datastream] Call preCommit on SinkWriter although no committer is available

2021-09-28 Thread GitBox
AHeise merged pull request #17351: URL: https://github.com/apache/flink/pull/17351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [flink] flinkbot edited a comment on pull request #17375: [FLINK-24398][connectors/kafka] KafkaSourceFetcherManager should re-use an existing SplitFetcher to commit offset if possible

2021-09-28 Thread GitBox
flinkbot edited a comment on pull request #17375: URL: https://github.com/apache/flink/pull/17375#issuecomment-929203203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17345: [FLINK-24227][connectors] FLIP-171: Added Kinesis Data Streams Sink i…

2021-09-28 Thread GitBox
flinkbot edited a comment on pull request #17345: URL: https://github.com/apache/flink/pull/17345#issuecomment-926109717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] JackWangCS commented on pull request #17245: [FLINK-23316][Table SQL/Ecosystem] Add tests for custom PartitionCommitPolicy

2021-09-28 Thread GitBox
JackWangCS commented on pull request #17245: URL: https://github.com/apache/flink/pull/17245#issuecomment-928452124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [flink-web] StephanEwen commented on a change in pull request #468: Release blog post 1.14 draft iteration

2021-09-28 Thread GitBox
StephanEwen commented on a change in pull request #468: URL: https://github.com/apache/flink-web/pull/468#discussion_r716900746 ## File path: _posts/2021-09-21-release-1.14.0.md ## @@ -0,0 +1,274 @@ +--- +layout: post +title: "Apache Flink 1.14.0 Release Announcement" +date:

[GitHub] [flink-benchmarks] dawidwys commented on a change in pull request #32: [FLINK-24230] Buffer debloating microbenchmark for single gate

2021-09-28 Thread GitBox
dawidwys commented on a change in pull request #32: URL: https://github.com/apache/flink-benchmarks/pull/32#discussion_r717316018 ## File path: src/main/java/org/apache/flink/benchmark/CheckpointingTimeBenchmark.java ## @@ -97,43 +100,119 @@ }) @Warmup(iterations = 4

[GitHub] [flink] flinkbot edited a comment on pull request #17245: [FLINK-23316][Table SQL/Ecosystem] Add tests for custom PartitionCommitPolicy

2021-09-28 Thread GitBox
flinkbot edited a comment on pull request #17245: URL: https://github.com/apache/flink/pull/17245#issuecomment-917600794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] curcur commented on a change in pull request #16606: [FLINK-21357][runtime/statebackend]Periodic materialization for generalized incremental checkpoints

2021-09-28 Thread GitBox
curcur commented on a change in pull request #16606: URL: https://github.com/apache/flink/pull/16606#discussion_r717191787 ## File path: pom.xml ## @@ -1518,7 +1518,7 @@ under the License. random: enable it randomly, unle

[GitHub] [flink] slinkydeveloper commented on pull request #17368: [hotfix] Add a docs page with module specific guides for flink contributors

2021-09-28 Thread GitBox
slinkydeveloper commented on pull request #17368: URL: https://github.com/apache/flink/pull/17368#issuecomment-929022468 @Airblader yep it seems like, perhaps I can modify the page you linked to be more "generic", and not specific to code style? -- This is an automated message from the A

[GitHub] [flink] CrynetLogistics closed pull request #17349: [FLINK-24370][documentation] Added documentation for Asynchronous Sin…

2021-09-28 Thread GitBox
CrynetLogistics closed pull request #17349: URL: https://github.com/apache/flink/pull/17349 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues

[GitHub] [flink] flinkbot edited a comment on pull request #17363: [FLINK-24324][connectors/elasticsearch] Add Elasticsearch 7 sink based on FLIP-143

2021-09-28 Thread GitBox
flinkbot edited a comment on pull request #17363: URL: https://github.com/apache/flink/pull/17363#issuecomment-927758743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] slinkydeveloper edited a comment on pull request #17368: [hotfix] Add a docs page with module specific guides for flink contributors

2021-09-28 Thread GitBox
slinkydeveloper edited a comment on pull request #17368: URL: https://github.com/apache/flink/pull/17368#issuecomment-929022468 @Airblader yep it seems like, perhaps I can modify the page you linked to be more "generic", and not specific to code style? Or do you have something else in mind

[GitHub] [flink] flinkbot commented on pull request #17366: [FLINK-24374] Retry querying for checkpoint stats

2021-09-28 Thread GitBox
flinkbot commented on pull request #17366: URL: https://github.com/apache/flink/pull/17366#issuecomment-928905078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [flink-web] xintongsong commented on pull request #468: Release blog post 1.14 draft iteration

2021-09-28 Thread GitBox
xintongsong commented on pull request #468: URL: https://github.com/apache/flink-web/pull/468#issuecomment-928601683 @StephanEwen, Thanks for addressing my comments. The fine-grained resource management section looks very good to me now. I've uploaded another figure, with better layou

[GitHub] [flink] AHeise merged pull request #17364: [FLINK-24371][datastream] Call preCommit on SinkWriter although no committer is available

2021-09-28 Thread GitBox
AHeise merged pull request #17364: URL: https://github.com/apache/flink/pull/17364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [flink] flinkbot edited a comment on pull request #17370: [BP-1.14][FLINK-24380][k8s] Terminate the pod if it failed

2021-09-28 Thread GitBox
flinkbot edited a comment on pull request #17370: URL: https://github.com/apache/flink/pull/17370#issuecomment-929030266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot commented on pull request #17368: [hotfix] Add a docs page with module specific guides for flink contributors

2021-09-28 Thread GitBox
flinkbot commented on pull request #17368: URL: https://github.com/apache/flink/pull/17368#issuecomment-929006965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [flink] rkhachatryan commented on pull request #16606: [FLINK-21357][runtime/statebackend]Periodic materialization for generalized incremental checkpoints

2021-09-28 Thread GitBox
rkhachatryan commented on pull request #16606: URL: https://github.com/apache/flink/pull/16606#issuecomment-928906726 All commits: `[FLINK-21357][runtime/statebackend]Periodic materialization for generalized incremental checkpoints` `[refactor] move AsyncExceptionHandler from flink-st

[GitHub] [flink] lindong28 commented on a change in pull request #17342: [FLINK-20928] Fix flaky test by retrying notifyCheckpointComplete until either commit success or timeout

2021-09-28 Thread GitBox
lindong28 commented on a change in pull request #17342: URL: https://github.com/apache/flink/pull/17342#discussion_r717524891 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/reader/fetcher/KafkaSourceFetcherManager.java ##

[GitHub] [flink] sjwiesman commented on pull request #17356: [FLINK-23313][docs] Reintroduce temporal table function documentation

2021-09-28 Thread GitBox
sjwiesman commented on pull request #17356: URL: https://github.com/apache/flink/pull/17356#issuecomment-929285508 This looks good to me. @leonardBang should we backport this to 1.14? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] flinkbot commented on pull request #17374: [FLINK-24327][connectors/elasticsearch] Add Elasticsearch 7 sink for table API

2021-09-28 Thread GitBox
flinkbot commented on pull request #17374: URL: https://github.com/apache/flink/pull/17374#issuecomment-929135606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [flink] flinkbot commented on pull request #17376: [FLINK-23313][docs] Reintroduce temporal table function documentation

2021-09-28 Thread GitBox
flinkbot commented on pull request #17376: URL: https://github.com/apache/flink/pull/17376#issuecomment-929337929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [flink] flinkbot commented on pull request #17365: [hotfix][web]Modify the configuration of prettier

2021-09-28 Thread GitBox
flinkbot commented on pull request #17365: URL: https://github.com/apache/flink/pull/17365#issuecomment-928654047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [flink] flinkbot edited a comment on pull request #17371: [BP-1.13][FLINK-24380][k8s] Terminate the pod if it failed

2021-09-28 Thread GitBox
flinkbot edited a comment on pull request #17371: URL: https://github.com/apache/flink/pull/17371#issuecomment-929030407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] Airblader commented on pull request #17368: [hotfix] Add a docs page with module specific guides for flink contributors

2021-09-28 Thread GitBox
Airblader commented on pull request #17368: URL: https://github.com/apache/flink/pull/17368#issuecomment-929004253 There seems to be some overlap with https://flink.apache.org/contributing/code-style-and-quality-components.html with this? -- This is an automated message from the Apache

[GitHub] [flink] flinkbot edited a comment on pull request #17360: [FLINK-24379][Formats] Add support for Glue schema registry in Table API

2021-09-28 Thread GitBox
flinkbot edited a comment on pull request #17360: URL: https://github.com/apache/flink/pull/17360#issuecomment-927544424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] matriv commented on a change in pull request #17343: [hotfix][docs] Various doc enhancements around filesystem table connector and json

2021-09-28 Thread GitBox
matriv commented on a change in pull request #17343: URL: https://github.com/apache/flink/pull/17343#discussion_r717695529 ## File path: docs/content/docs/connectors/table/filesystem.md ## @@ -102,6 +102,12 @@ The file system connector supports multiple formats: - Canal-JSON:

[GitHub] [flink-web] pnowojski commented on a change in pull request #468: Release blog post 1.14 draft iteration

2021-09-28 Thread GitBox
pnowojski commented on a change in pull request #468: URL: https://github.com/apache/flink-web/pull/468#discussion_r717258622 ## File path: _posts/2021-09-21-release-1.14.0.md ## @@ -0,0 +1,344 @@ +--- +layout: post +title: "Apache Flink 1.14.0 Release Announcement" +date: 20

[GitHub] [flink] twalthr commented on a change in pull request #17341: [hotfix][test] Refactor BuiltInFunctions IT Tests

2021-09-28 Thread GitBox
twalthr commented on a change in pull request #17341: URL: https://github.com/apache/flink/pull/17341#discussion_r717335148 ## File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/BuiltInFunctionTestBase.java ## @@ -261,6 +248,14 @@

[GitHub] [flink] flinkbot edited a comment on pull request #17350: [FLINK-24359][table-runtime] Use ResolvedSchema in AbstractFileSystemTable

2021-09-28 Thread GitBox
flinkbot edited a comment on pull request #17350: URL: https://github.com/apache/flink/pull/17350#issuecomment-926550692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #16606: [FLINK-21357][runtime/statebackend]Periodic materialization for generalized incremental checkpoints

2021-09-28 Thread GitBox
flinkbot edited a comment on pull request #16606: URL: https://github.com/apache/flink/pull/16606#issuecomment-887431748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17342: [FLINK-20928] Fix flaky test by retrying notifyCheckpointComplete until either commit success or timeout

2021-09-28 Thread GitBox
flinkbot edited a comment on pull request #17342: URL: https://github.com/apache/flink/pull/17342#issuecomment-925923633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot commented on pull request #17372: [BP-1.13][FLINK-24377][runtime] Fix TM potentially not released after heartbeat timeout.

2021-09-28 Thread GitBox
flinkbot commented on pull request #17372: URL: https://github.com/apache/flink/pull/17372#issuecomment-929019851 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [flink] flinkbot edited a comment on pull request #17368: [hotfix] Add a docs page with module specific guides for flink contributors

2021-09-28 Thread GitBox
flinkbot edited a comment on pull request #17368: URL: https://github.com/apache/flink/pull/17368#issuecomment-929030059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] xintongsong closed pull request #17362: [FLINK-24377][runtime] Fix TM potentially not released after heartbeat timeout.

2021-09-28 Thread GitBox
xintongsong closed pull request #17362: URL: https://github.com/apache/flink/pull/17362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-uns

[GitHub] [flink-ml] gaoyunhaii commented on pull request #9: [hotfix] Fix pom.xml and delete outdated files

2021-09-28 Thread GitBox
gaoyunhaii commented on pull request #9: URL: https://github.com/apache/flink-ml/pull/9#issuecomment-928711958 Very thanks @zhipeng93 for opening the PR! LGTM and +1 to merge~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [flink] dannycranmer commented on pull request #17360: [FLINK-24379][Formats] Add support for Glue schema registry in Table API

2021-09-28 Thread GitBox
dannycranmer commented on pull request #17360: URL: https://github.com/apache/flink/pull/17360#issuecomment-928976369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [flink] AHeise closed pull request #12052: [FLINK-17588][scala-shell] Throw exception when hadoop jar is missing in flink scala's yarn mode

2021-09-28 Thread GitBox
AHeise closed pull request #12052: URL: https://github.com/apache/flink/pull/12052 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [flink] flinkbot commented on pull request #17367: [FLINK-24382][metrics] Do not compute recordsOut metric in SinkOperat…

2021-09-28 Thread GitBox
flinkbot commented on pull request #17367: URL: https://github.com/apache/flink/pull/17367#issuecomment-928944825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [flink] leonardBang commented on pull request #17356: [FLINK-23313][docs] Reintroduce temporal table function documentation

2021-09-28 Thread GitBox
leonardBang commented on pull request #17356: URL: https://github.com/apache/flink/pull/17356#issuecomment-929331341 > This looks good to me. @leonardBang should we backport this to 1.14? Yes, I'll backport the PR to release-1.14 -- This is an automated message from the Apache Gi

[GitHub] [flink] MartijnVisser commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support

2021-09-28 Thread GitBox
MartijnVisser commented on pull request #14544: URL: https://github.com/apache/flink/pull/14544#issuecomment-928956978 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [flink] jherico removed a comment on pull request #17360: [FLINK-24379][Formats] Add support for Glue schema registry in Table API

2021-09-28 Thread GitBox
jherico removed a comment on pull request #17360: URL: https://github.com/apache/flink/pull/17360#issuecomment-927595250 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [flink] zentol commented on pull request #17133: [Proof of Concept][FLINK-24138] Architectural tests

2021-09-28 Thread GitBox
zentol commented on pull request #17133: URL: https://github.com/apache/flink/pull/17133#issuecomment-929064318 > Would it make sense to enforce that all **public** classes are required to have a visibility annotation I'm not sure. On the one hand it forces the dev to make a decisio

[GitHub] [flink] zekai-li commented on pull request #17365: [hotfix][web]Modify the configuration of prettier

2021-09-28 Thread GitBox
zekai-li commented on pull request #17365: URL: https://github.com/apache/flink/pull/17365#issuecomment-928730125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [flink] flinkbot commented on pull request #17378: [hotfix][docs] Move out the time zone page from streaming concepts section #17377

2021-09-28 Thread GitBox
flinkbot commented on pull request #17378: URL: https://github.com/apache/flink/pull/17378#issuecomment-929376738 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [flink] RocMarshal commented on pull request #17352: [FLINK-10230][table] Support 'SHOW CREATE VIEW' syntax to print the query of a view

2021-09-28 Thread GitBox
RocMarshal commented on pull request #17352: URL: https://github.com/apache/flink/pull/17352#issuecomment-928462394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [flink] zhuzhurk closed pull request #17357: [FLINK-24375] Let name of flush thread in RecordWriter contain subtask index.

2021-09-28 Thread GitBox
zhuzhurk closed pull request #17357: URL: https://github.com/apache/flink/pull/17357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[GitHub] [flink] CrynetLogistics commented on pull request #17349: [FLINK-24370][documentation] Added documentation for Asynchronous Sin…

2021-09-28 Thread GitBox
CrynetLogistics commented on pull request #17349: URL: https://github.com/apache/flink/pull/17349#issuecomment-929036278 Wonderful, we have consensus. Thank you @sjwiesman, @MartijnVisser and @infoverload for your comments. I am happy to add this information to a blog post and JavaDocs.

[GitHub] [flink-benchmarks] pnowojski commented on pull request #32: [FLINK-24230] Buffer debloating microbenchmark for single gate

2021-09-28 Thread GitBox
pnowojski commented on pull request #32: URL: https://github.com/apache/flink-benchmarks/pull/32#issuecomment-928949800 > Unforunately it's not that perfect, as the ALIGNED checkpoint do not match the math anymore. Or do they? You can run the benchmark with different debloating targe

[GitHub] [flink] flinkbot edited a comment on pull request #17369: [FLINK-19792][table-planner] Fix IntervalJoin with time equality predicate

2021-09-28 Thread GitBox
flinkbot edited a comment on pull request #17369: URL: https://github.com/apache/flink/pull/17369#issuecomment-929030154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17365: [hotfix][web]Modify the configuration of prettier

2021-09-28 Thread GitBox
flinkbot edited a comment on pull request #17365: URL: https://github.com/apache/flink/pull/17365#issuecomment-928705859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17358: [hotfix] Fix typo,'Kakfa' corrected to 'Kafka'

2021-09-28 Thread GitBox
flinkbot edited a comment on pull request #17358: URL: https://github.com/apache/flink/pull/17358#issuecomment-927338621 ## CI report: * 59eba292db9253d6f97a192ab808ff04288044ab Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17341: [FLINK-24394][test] Refactor BuiltInFunctions IT Tests

2021-09-28 Thread GitBox
flinkbot edited a comment on pull request #17341: URL: https://github.com/apache/flink/pull/17341#issuecomment-925901262 ## CI report: * f2c827b884fa646bae5f08c3d26a613a58a4ba3b UNKNOWN * 157029a573989ff4f1dee48f18c41b1d962c5030 UNKNOWN * 8f7543e9df040f87832eceb79cf5fd635778

[GitHub] [flink] flinkbot edited a comment on pull request #17376: [FLINK-23313][docs] Reintroduce temporal table function documentation

2021-09-28 Thread GitBox
flinkbot edited a comment on pull request #17376: URL: https://github.com/apache/flink/pull/17376#issuecomment-929374405 ## CI report: * 1cf7bf32b923da74d944d7657da272d804dee25f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] sjwiesman commented on a change in pull request #17377: [hotfix][docs] Move out the time zone page from streaming concepts section

2021-09-28 Thread GitBox
sjwiesman commented on a change in pull request #17377: URL: https://github.com/apache/flink/pull/17377#discussion_r717994901 ## File path: docs/content.zh/docs/dev/table/timezone.md ## @@ -1,6 +1,6 @@ --- title: "时区" -weight: 4 +weight: 86 Review comment: Can you mak

[GitHub] [flink] flinkbot edited a comment on pull request #17360: [FLINK-24379][Formats] Add support for Glue schema registry in Table API

2021-09-28 Thread GitBox
flinkbot edited a comment on pull request #17360: URL: https://github.com/apache/flink/pull/17360#issuecomment-927544424 ## CI report: * 1e11514b73a035cad03c582c00e5a156ec7ab115 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] hhkkxxx133 commented on a change in pull request #17360: [FLINK-24379][Formats] Add support for Glue schema registry in Table API

2021-09-28 Thread GitBox
hhkkxxx133 commented on a change in pull request #17360: URL: https://github.com/apache/flink/pull/17360#discussion_r718011735 ## File path: docs/data/sql_connectors.yml ## @@ -48,6 +48,12 @@ avro-confluent: category: format sql_url: https://repo.maven.apache.org/mav

[GitHub] [flink] flinkbot edited a comment on pull request #17377: [hotfix][docs] Move out the time zone page from streaming concepts section

2021-09-28 Thread GitBox
flinkbot edited a comment on pull request #17377: URL: https://github.com/apache/flink/pull/17377#issuecomment-929395259 ## CI report: * ef15f46d9e4c3d7c9ed00ac378208ece7f504a3e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17378: [hotfix][docs] Move out the time zone page from streaming concepts section #17377

2021-09-28 Thread GitBox
flinkbot edited a comment on pull request #17378: URL: https://github.com/apache/flink/pull/17378#issuecomment-929395351 ## CI report: * f1d88d124b164ba1ca396ada5946ac3f3e500382 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] leonardBang commented on pull request #17377: [hotfix][docs] Move out the time zone page from streaming concepts section

2021-09-28 Thread GitBox
leonardBang commented on pull request #17377: URL: https://github.com/apache/flink/pull/17377#issuecomment-929697510 Appreciate if you can help merge @sjwiesman , I don't have merge authority yet. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [flink] leonardBang commented on pull request #17356: [FLINK-23313][docs] Reintroduce temporal table function documentation

2021-09-28 Thread GitBox
leonardBang commented on pull request #17356: URL: https://github.com/apache/flink/pull/17356#issuecomment-929697815 That's great if you can help merge @sjwiesman , thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] flinkbot edited a comment on pull request #17377: [hotfix][docs] Move out the time zone page from streaming concepts section

2021-09-28 Thread GitBox
flinkbot edited a comment on pull request #17377: URL: https://github.com/apache/flink/pull/17377#issuecomment-929395259 ## CI report: * ef15f46d9e4c3d7c9ed00ac378208ece7f504a3e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17378: [hotfix][docs] Move out the time zone page from streaming concepts section #17377

2021-09-28 Thread GitBox
flinkbot edited a comment on pull request #17378: URL: https://github.com/apache/flink/pull/17378#issuecomment-929395351 ## CI report: * f1d88d124b164ba1ca396ada5946ac3f3e500382 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] zekai-li commented on pull request #17365: [hotfix][web]Modify the configuration of prettier

2021-09-28 Thread GitBox
zekai-li commented on pull request #17365: URL: https://github.com/apache/flink/pull/17365#issuecomment-929706981 @rehevkor5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Updated] (FLINK-19830) Properly implements processing-time temporal table join

2021-09-28 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-19830: --- Fix Version/s: (was: 1.14.0) 1.15.0 > Properly implements processing-time tem

[jira] [Commented] (FLINK-19830) Properly implements processing-time temporal table join

2021-09-28 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421830#comment-17421830 ] Leonard Xu commented on FLINK-19830: Hi [~gelimusong], the custom event mechanism di

[jira] [Updated] (FLINK-19830) Properly implements processing-time temporal table join

2021-09-28 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-19830: --- Description: The exsiting TemporalProcessTimeJoinOperator has already supported temporal table join

[jira] [Updated] (FLINK-19830) Properly implements processing-time temporal table join

2021-09-28 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-19830: --- Description: The exsiting TemporalProcessTimeJoinOperator has already supported temporal table join

<    1   2   3   4   5   6   7   8   9   >