[GitHub] [flink] flinkbot edited a comment on pull request #17653: FLINK SQL checkpoint不生效

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17653: URL: https://github.com/apache/flink/pull/17653#issuecomment-958686553 ## CI report: * 39134d1c1524f6014e0ce676e471379d386bc659 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17845: [FLINK-24352] [flink-table-planner] Add null check for temporal table check on SqlSnapshot

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17845: URL: https://github.com/apache/flink/pull/17845#issuecomment-974763929 ## CI report: * 3726a8418fd82d7456016658b98cf9ba1cf028e2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] CrynetLogistics commented on a change in pull request #17345: [FLINK-24227][connectors/kinesis] Added Kinesis Data Streams Sink i…

2021-11-22 Thread GitBox
CrynetLogistics commented on a change in pull request #17345: URL: https://github.com/apache/flink/pull/17345#discussion_r754588633 ## File path: flink-connectors/flink-connector-aws-kinesis-data-streams/pom.xml ## @@ -118,16 +109,6 @@ under the License.

[GitHub] [flink] fapaul commented on pull request #17813: [FLINK-24802][Table SQL/Planner] Improve cast ROW to STRING

2021-11-22 Thread GitBox
fapaul commented on pull request #17813: URL: https://github.com/apache/flink/pull/17813#issuecomment-975857536 @shenzhu thanks for your contribution, can you squash the two commits and maybe change the commit message name to `[FLINK-24802][table] ...`. I'll then merge the PR. --

[GitHub] [flink] flinkbot edited a comment on pull request #17872: [hotfix][docs][table] Fix docs for SHA1

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17872: URL: https://github.com/apache/flink/pull/17872#issuecomment-975782161 ## CI report: * 2dd18e6491931e21dc2ad06322045680ee9cf874 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17869: [FLINK-25005][build] Add java17-target profile

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17869: URL: https://github.com/apache/flink/pull/17869#issuecomment-975579743 ## CI report: * f7df3f0c5fc2cb7a7f037f792616cb564fbc3478 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17871: [hotfix] Add assertj in dependency management and link the code quality guide in the PR template

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17871: URL: https://github.com/apache/flink/pull/17871#issuecomment-975731882 ## CI report: * eb206096b08234d4a3153ff3a3fc64f900f24d6a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink-playgrounds] alpinegizmo closed pull request #26: update to an amd64 arch flink image

2021-11-22 Thread GitBox
alpinegizmo closed pull request #26: URL: https://github.com/apache/flink-playgrounds/pull/26 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issu

[GitHub] [flink-playgrounds] alpinegizmo commented on pull request #26: update to an amd64 arch flink image

2021-11-22 Thread GitBox
alpinegizmo commented on pull request #26: URL: https://github.com/apache/flink-playgrounds/pull/26#issuecomment-975836000 Thank you for this contribution. However, the apache/flink:1.13.1-scala_2.12-java8 images were quickly rebuilt for amd64 -- the arm-based images were a mistake that wa

[GitHub] [flink] flinkbot edited a comment on pull request #17845: [FLINK-24352] [flink-table-planner] Add null check for temporal table check on SqlSnapshot

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17845: URL: https://github.com/apache/flink/pull/17845#issuecomment-974763929 ## CI report: * 44fb878e4a2ba978731a85e43bb750be2c056e40 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] flinkbot edited a comment on pull request #17811: [FLINK-24754] Implement CHAR/VARCHAR length validation for sinks

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17811: URL: https://github.com/apache/flink/pull/17811#issuecomment-970441907 ## CI report: * a4db69f8d26bb92d1aab9833f428b1e4097c7a93 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Closed] (FLINK-15776) Rework 2-phase commit abstractions

2021-11-22 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan closed FLINK-15776. - Resolution: Cannot Reproduce Obsoleted by FLINK-19510 (FLIP-143) > Rework 2-phase commi

[GitHub] [flink] flinkbot edited a comment on pull request #17811: [FLINK-24754] Implement CHAR/VARCHAR length validation for sinks

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17811: URL: https://github.com/apache/flink/pull/17811#issuecomment-970441907 ## CI report: * a4db69f8d26bb92d1aab9833f428b1e4097c7a93 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] matriv commented on pull request #17811: [FLINK-24754] Implement CHAR/VARCHAR length validation for sinks

2021-11-22 Thread GitBox
matriv commented on pull request #17811: URL: https://github.com/apache/flink/pull/17811#issuecomment-975808446 @slinkydeveloper Thx for the review, please check again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] flinkbot edited a comment on pull request #17870: [Flink-24596][kafka] Fix buffered KafkaUpsert sink

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17870: URL: https://github.com/apache/flink/pull/17870#issuecomment-975609035 ## CI report: * 01d64c49b39abde51cc5ca9d82b509d0555b79e6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17868: [FLINK-25004][build] Disable spotless on Java 17

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17868: URL: https://github.com/apache/flink/pull/17868#issuecomment-975571677 ## CI report: * c6a24fedd2146fe1cbc1bc5a69b9f64bc4c1f04d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17735: [FLINK-24775][coordination] move JobStatus-related metrics out of ExecutionGraph

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17735: URL: https://github.com/apache/flink/pull/17735#issuecomment-964107798 ## CI report: * 4db2506e220550bb809be6c18ff1c363921964f0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17345: [FLINK-24227][connectors/kinesis] Added Kinesis Data Streams Sink i…

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17345: URL: https://github.com/apache/flink/pull/17345#issuecomment-926109717 ## CI report: * e0d7451523be3976f3c8695a0f3c9c782a76fddf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * 26d38e84409aacec3d0778a19aefde5ceb9caa66 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17866: [FLINK-24996][ci] Update CI image to contain Java 17

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17866: URL: https://github.com/apache/flink/pull/17866#issuecomment-975542249 ## CI report: * 3fafa6faf69e75095fe6be191958bcedbf8bf1bd Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * 26d38e84409aacec3d0778a19aefde5ceb9caa66 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17872: [hotfix][docs][table] Fix docs for SHA1

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17872: URL: https://github.com/apache/flink/pull/17872#issuecomment-975782161 ## CI report: * 2dd18e6491931e21dc2ad06322045680ee9cf874 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * 26d38e84409aacec3d0778a19aefde5ceb9caa66 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot commented on pull request #17872: [hotfix][docs][table] Fix docs for SHA1

2021-11-22 Thread GitBox
flinkbot commented on pull request #17872: URL: https://github.com/apache/flink/pull/17872#issuecomment-975782161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [flink] flinkbot edited a comment on pull request #17867: [FLINK-24592][Table SQL/Client] FlinkSQL Client multiline parser improvements

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17867: URL: https://github.com/apache/flink/pull/17867#issuecomment-975551530 ## CI report: * ed90e252cfa8e3fd725ca71473339aafe213a4b3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * 26d38e84409aacec3d0778a19aefde5ceb9caa66 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] snuyanzin opened a new pull request #17872: [hotfix][docs][table] Fix docs for SHA1

2021-11-22 Thread GitBox
snuyanzin opened a new pull request #17872: URL: https://github.com/apache/flink/pull/17872 ## What is the purpose of the change Currently docs for `SHA1` and `SHA-224` is identical, this PR fixes that ## Does this pull request potentially affect one of the following parts:

[GitHub] [flink] flinkbot edited a comment on pull request #17865: [FLINK-24993][core] Harden ExceptionUtils against changes to exceptions

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17865: URL: https://github.com/apache/flink/pull/17865#issuecomment-975516895 ## CI report: * 707f22044b3dc3ef8c61a49b892f3515df6a8644 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * 26d38e84409aacec3d0778a19aefde5ceb9caa66 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * 26d38e84409aacec3d0778a19aefde5ceb9caa66 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17538: [FLINK-24325][connectors/elasticsearch] Create Elasticsearch 6 Sink

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17538: URL: https://github.com/apache/flink/pull/17538#issuecomment-948574914 ## CI report: * 2d2e314314c0aca9b334ff09dd744d075b47cb53 UNKNOWN * 584a0214852f7deb726e8a2cc8462de58975ef04 Azure: [FAILURE](https://dev.azure.com/apache-fl

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * 26d38e84409aacec3d0778a19aefde5ceb9caa66 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] matriv commented on a change in pull request #17811: [FLINK-24754] Implement CHAR/VARCHAR length validation for sinks

2021-11-22 Thread GitBox
matriv commented on a change in pull request #17811: URL: https://github.com/apache/flink/pull/17811#discussion_r754506850 ## File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/sink/ConstraintValidator.java ## @@ -0,0 +1,209 @@ +/

[GitHub] [flink] flinkbot edited a comment on pull request #17845: [FLINK-24352] [flink-table-planner] Add null check for temporal table check on SqlSnapshot

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17845: URL: https://github.com/apache/flink/pull/17845#issuecomment-974763929 ## CI report: * 5c35a875ef1d4c812a118d3a4c386afba1ca71d1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * 26d38e84409aacec3d0778a19aefde5ceb9caa66 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17345: [FLINK-24227][connectors/kinesis] Added Kinesis Data Streams Sink i…

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17345: URL: https://github.com/apache/flink/pull/17345#issuecomment-926109717 ## CI report: * 553a3fc38d803f8addb31f639b868d5bbd7518dd Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17864: [FLINK-24992] StreamingWithStateTestBase compiles on later Scala versions

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17864: URL: https://github.com/apache/flink/pull/17864#issuecomment-975497434 ## CI report: * cd11ec0102a8085805a85a71fd14a79f36d92f3c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17845: [FLINK-24352] [flink-table-planner] Add null check for temporal table check on SqlSnapshot

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17845: URL: https://github.com/apache/flink/pull/17845#issuecomment-974763929 ## CI report: * 5c35a875ef1d4c812a118d3a4c386afba1ca71d1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Updated] (FLINK-25008) Improve behaviour of NotNullEnforcer when dropping records

2021-11-22 Thread Marios Trivyzas (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marios Trivyzas updated FLINK-25008: Component/s: Table SQL / Planner > Improve behaviour of NotNullEnforcer when dropping reco

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * 26d38e84409aacec3d0778a19aefde5ceb9caa66 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17345: [FLINK-24227][connectors/kinesis] Added Kinesis Data Streams Sink i…

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17345: URL: https://github.com/apache/flink/pull/17345#issuecomment-926109717 ## CI report: * 553a3fc38d803f8addb31f639b868d5bbd7518dd Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] matriv commented on a change in pull request #17811: [FLINK-24754] Implement CHAR/VARCHAR length validation for sinks

2021-11-22 Thread GitBox
matriv commented on a change in pull request #17811: URL: https://github.com/apache/flink/pull/17811#discussion_r754500912 ## File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/sink/ConstraintValidator.java ## @@ -0,0 +1,209 @@ +/

[jira] [Created] (FLINK-25008) Improve behaviour of NotNullEnforcer when dropping records

2021-11-22 Thread Marios Trivyzas (Jira)
Marios Trivyzas created FLINK-25008: --- Summary: Improve behaviour of NotNullEnforcer when dropping records Key: FLINK-25008 URL: https://issues.apache.org/jira/browse/FLINK-25008 Project: Flink

[jira] [Comment Edited] (FLINK-24815) Reduce the cpu cost of calculating stateSize during state allocation

2021-11-22 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447537#comment-17447537 ] Roman Khachatryan edited comment on FLINK-24815 at 11/22/21, 5:38 PM:

[jira] [Commented] (FLINK-24815) Reduce the cpu cost of calculating stateSize during state allocation

2021-11-22 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447537#comment-17447537 ] Roman Khachatryan commented on FLINK-24815: --- I agree think that passing some m

[GitHub] [flink] flinkbot edited a comment on pull request #17845: [FLINK-24352] [flink-table-planner] Add null check for temporal table check on SqlSnapshot

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17845: URL: https://github.com/apache/flink/pull/17845#issuecomment-974763929 ## CI report: * 5c35a875ef1d4c812a118d3a4c386afba1ca71d1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * 26d38e84409aacec3d0778a19aefde5ceb9caa66 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17845: [FLINK-24352] [flink-table-planner] Add null check for temporal table check on SqlSnapshot

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17845: URL: https://github.com/apache/flink/pull/17845#issuecomment-974763929 ## CI report: * 5c35a875ef1d4c812a118d3a4c386afba1ca71d1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * 26d38e84409aacec3d0778a19aefde5ceb9caa66 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17845: [FLINK-24352] [flink-table-planner] Add null check for temporal table check on SqlSnapshot

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17845: URL: https://github.com/apache/flink/pull/17845#issuecomment-974763929 ## CI report: * 5c35a875ef1d4c812a118d3a4c386afba1ca71d1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17862: [FLINK-24990][tests] Make InMemory[Async]LookupFunction public

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17862: URL: https://github.com/apache/flink/pull/17862#issuecomment-975459239 ## CI report: * 08217a2fdcc6c6b5b88c01927e37732f5294788d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * 26d38e84409aacec3d0778a19aefde5ceb9caa66 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] matriv commented on a change in pull request #17811: [FLINK-24754] Implement CHAR/VARCHAR length validation for sinks

2021-11-22 Thread GitBox
matriv commented on a change in pull request #17811: URL: https://github.com/apache/flink/pull/17811#discussion_r754492445 ## File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/sink/ConstraintValidator.java ## @@ -0,0 +1,209 @@ +/

[GitHub] [flink] flinkbot edited a comment on pull request #17845: [FLINK-24352] [flink-table-planner] Add null check for temporal table check on SqlSnapshot

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17845: URL: https://github.com/apache/flink/pull/17845#issuecomment-974763929 ## CI report: * 5c35a875ef1d4c812a118d3a4c386afba1ca71d1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * 26d38e84409aacec3d0778a19aefde5ceb9caa66 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17867: [FLINK-24592][Table SQL/Client] FlinkSQL Client multiline parser improvements

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17867: URL: https://github.com/apache/flink/pull/17867#issuecomment-975551530 ## CI report: * ed90e252cfa8e3fd725ca71473339aafe213a4b3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17845: [FLINK-24352] [flink-table-planner] Add null check for temporal table check on SqlSnapshot

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17845: URL: https://github.com/apache/flink/pull/17845#issuecomment-974763929 ## CI report: * 5c35a875ef1d4c812a118d3a4c386afba1ca71d1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * 26d38e84409aacec3d0778a19aefde5ceb9caa66 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17867: [FLINK-24592][Table SQL/Client] FlinkSQL Client multiline parser improvements

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17867: URL: https://github.com/apache/flink/pull/17867#issuecomment-975551530 ## CI report: * ed90e252cfa8e3fd725ca71473339aafe213a4b3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17757: URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588 ## CI report: * da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN * a2470991a14803fe27df5e16ebf17becb8f36a40 Azure: [FAILURE](https://dev.azure.com/apache-fl

[GitHub] [flink] flinkbot edited a comment on pull request #17845: [FLINK-24352] [flink-table-planner] Add null check for temporal table check on SqlSnapshot

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17845: URL: https://github.com/apache/flink/pull/17845#issuecomment-974763929 ## CI report: * 5c35a875ef1d4c812a118d3a4c386afba1ca71d1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * 26d38e84409aacec3d0778a19aefde5ceb9caa66 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] snuyanzin commented on pull request #17867: [FLINK-24592][Table SQL/Client] FlinkSQL Client multiline parser improvements

2021-11-22 Thread GitBox
snuyanzin commented on pull request #17867: URL: https://github.com/apache/flink/pull/17867#issuecomment-975744475 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [flink] flinkbot edited a comment on pull request #17845: [FLINK-24352] [flink-table-planner] Add null check for temporal table check on SqlSnapshot

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17845: URL: https://github.com/apache/flink/pull/17845#issuecomment-974763929 ## CI report: * 5c35a875ef1d4c812a118d3a4c386afba1ca71d1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17757: URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588 ## CI report: * da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN * a2470991a14803fe27df5e16ebf17becb8f36a40 Azure: [FAILURE](https://dev.azure.com/apache-fl

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * 26d38e84409aacec3d0778a19aefde5ceb9caa66 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] rkhachatryan commented on a change in pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader

2021-11-22 Thread GitBox
rkhachatryan commented on a change in pull request #17757: URL: https://github.com/apache/flink/pull/17757#discussion_r75448 ## File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java ## @@ -134,6 +138,6 @@ public l

[GitHub] [flink] flinkbot edited a comment on pull request #17845: [FLINK-24352] [flink-table-planner] Add null check for temporal table check on SqlSnapshot

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17845: URL: https://github.com/apache/flink/pull/17845#issuecomment-974763929 ## CI report: * 5c35a875ef1d4c812a118d3a4c386afba1ca71d1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17806: [FLINK-24708][planner] Fix wrong results of the IN operator

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17806: URL: https://github.com/apache/flink/pull/17806#issuecomment-969962850 ## CI report: * c3f5f0fcebad85e7cae6694d5282da369ce69509 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17757: URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588 ## CI report: * da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN * a2470991a14803fe27df5e16ebf17becb8f36a40 Azure: [FAILURE](https://dev.azure.com/apache-fl

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * 26d38e84409aacec3d0778a19aefde5ceb9caa66 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17871: [hotfix] Add assertj in dependency management and link the code quality guide in the PR template

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17871: URL: https://github.com/apache/flink/pull/17871#issuecomment-975731882 ## CI report: * eb206096b08234d4a3153ff3a3fc64f900f24d6a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17845: [FLINK-24352] [flink-table-planner] Add null check for temporal table check on SqlSnapshot

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17845: URL: https://github.com/apache/flink/pull/17845#issuecomment-974763929 ## CI report: * 5c35a875ef1d4c812a118d3a4c386afba1ca71d1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17757: URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588 ## CI report: * da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN * a2470991a14803fe27df5e16ebf17becb8f36a40 Azure: [FAILURE](https://dev.azure.com/apache-fl

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * 26d38e84409aacec3d0778a19aefde5ceb9caa66 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot commented on pull request #17871: [hotfix] Add assertj in dependency management and link the code quality guide in the PR template

2021-11-22 Thread GitBox
flinkbot commented on pull request #17871: URL: https://github.com/apache/flink/pull/17871#issuecomment-975732886 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[jira] [Updated] (FLINK-11038) Rewrite Kafka at-least-once it cases

2021-11-22 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-11038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-11038: --- Priority: Not a Priority (was: Minor) > Rewrite Kafka at-least-once it cases >

[GitHub] [flink] flinkbot commented on pull request #17871: [hotfix] Add assertj in dependency management and link the code quality guide in the PR template

2021-11-22 Thread GitBox
flinkbot commented on pull request #17871: URL: https://github.com/apache/flink/pull/17871#issuecomment-975731882 ## CI report: * eb206096b08234d4a3153ff3a3fc64f900f24d6a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] flinkbot edited a comment on pull request #17845: [FLINK-24352] [flink-table-planner] Add null check for temporal table check on SqlSnapshot

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17845: URL: https://github.com/apache/flink/pull/17845#issuecomment-974763929 ## CI report: * 5c35a875ef1d4c812a118d3a4c386afba1ca71d1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17757: URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588 ## CI report: * da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN * a2470991a14803fe27df5e16ebf17becb8f36a40 Azure: [FAILURE](https://dev.azure.com/apache-fl

[GitHub] [flink] pnowojski commented on a change in pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader

2021-11-22 Thread GitBox
pnowojski commented on a change in pull request #17757: URL: https://github.com/apache/flink/pull/17757#discussion_r754470187 ## File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java ## @@ -134,6 +138,6 @@ public long

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * 26d38e84409aacec3d0778a19aefde5ceb9caa66 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] slinkydeveloper opened a new pull request #17871: [hotfix] Add assertj in dependency management and link the code quality guide in the PR template

2021-11-22 Thread GitBox
slinkydeveloper opened a new pull request #17871: URL: https://github.com/apache/flink/pull/17871 For more details about this PR, check out: https://lists.apache.org/thread/33t7hz8w873p1bc5msppk65792z08rgt Changes: * Add assertj in the dependency management * Add our code q

[GitHub] [flink] flinkbot edited a comment on pull request #17867: [FLINK-24592][Table SQL/Client] FlinkSQL Client multiline parser improvements

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17867: URL: https://github.com/apache/flink/pull/17867#issuecomment-975551530 ## CI report: * ed90e252cfa8e3fd725ca71473339aafe213a4b3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17861: [FLINK-24989][build] Bump shade-plugin to 3.2.4

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17861: URL: https://github.com/apache/flink/pull/17861#issuecomment-975451730 ## CI report: * c2b74fa18a0007ce8af1840d20a3169fce20dc1d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17845: [FLINK-24352] [flink-table-planner] Add null check for temporal table check on SqlSnapshot

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17845: URL: https://github.com/apache/flink/pull/17845#issuecomment-974763929 ## CI report: * 5c35a875ef1d4c812a118d3a4c386afba1ca71d1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17693: [FLINK-24789][runtime] Trigger checkpoint disposal prior completing t…

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17693: URL: https://github.com/apache/flink/pull/17693#issuecomment-961795148 ## CI report: * 00d7ad3c59381c4118395cb4ae2cdd3375e3f121 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17757: URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588 ## CI report: * da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN * a2470991a14803fe27df5e16ebf17becb8f36a40 Azure: [FAILURE](https://dev.azure.com/apache-fl

[GitHub] [flink] rkhachatryan commented on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader

2021-11-22 Thread GitBox
rkhachatryan commented on pull request #17757: URL: https://github.com/apache/flink/pull/17757#issuecomment-975725464 > Those metrics should be documented somehow. IIRC, the consensus so far was to not document changelog at this stage; so the metrics shouldn't be mentioned in the doc

[GitHub] [flink] flinkbot edited a comment on pull request #17845: [FLINK-24352] [flink-table-planner] Add null check for temporal table check on SqlSnapshot

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17845: URL: https://github.com/apache/flink/pull/17845#issuecomment-974763929 ## CI report: * 5c35a875ef1d4c812a118d3a4c386afba1ca71d1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17845: [FLINK-24352] [flink-table-planner] Add null check for temporal table check on SqlSnapshot

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17845: URL: https://github.com/apache/flink/pull/17845#issuecomment-974763929 ## CI report: * 5c35a875ef1d4c812a118d3a4c386afba1ca71d1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17845: [FLINK-24352] [flink-table-planner] Add null check for temporal table check on SqlSnapshot

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17845: URL: https://github.com/apache/flink/pull/17845#issuecomment-974763929 ## CI report: * 5c35a875ef1d4c812a118d3a4c386afba1ca71d1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17845: [FLINK-24352] [flink-table-planner] Add null check for temporal table check on SqlSnapshot

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17845: URL: https://github.com/apache/flink/pull/17845#issuecomment-974763929 ## CI report: * 5c35a875ef1d4c812a118d3a4c386afba1ca71d1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17845: [FLINK-24352] [flink-table-planner] Add null check for temporal table check on SqlSnapshot

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17845: URL: https://github.com/apache/flink/pull/17845#issuecomment-974763929 ## CI report: * 5c35a875ef1d4c812a118d3a4c386afba1ca71d1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] rkhachatryan commented on a change in pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader

2021-11-22 Thread GitBox
rkhachatryan commented on a change in pull request #17757: URL: https://github.com/apache/flink/pull/17757#discussion_r754450587 ## File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java ## @@ -0,0 +1,134 @@ +/* + * Li

[GitHub] [flink] YuvalItzchakov commented on pull request #17845: [FLINK-24352] [flink-table-planner] Add null check for temporal table check on SqlSnapshot

2021-11-22 Thread GitBox
YuvalItzchakov commented on pull request #17845: URL: https://github.com/apache/flink/pull/17845#issuecomment-975705119 @tsreaper I have fixed the PR name and made the check more specific. Additionally I replaced the test ITCase test with a test in LookupJoinTest as you mentioned. -- Th

[GitHub] [flink] flinkbot edited a comment on pull request #17863: [FLINK-24991] FlinkStatistic compiles on later Scala versions

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17863: URL: https://github.com/apache/flink/pull/17863#issuecomment-975466878 ## CI report: * 353cb4d91c54ffa76c62de1611e9d3c2735c0a9f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Updated] (FLINK-24352) Lookup join + WITH clause throws NPE

2021-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24352: --- Labels: pull-request-available (was: ) > Lookup join + WITH clause throws NPE > ---

[GitHub] [flink] flinkbot edited a comment on pull request #17845: [FLINK-24352] [flink-table-planner] Add null check for temporal table check on SqlSnapshot

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17845: URL: https://github.com/apache/flink/pull/17845#issuecomment-974763929 ## CI report: * 5c35a875ef1d4c812a118d3a4c386afba1ca71d1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] rkhachatryan commented on a change in pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader

2021-11-22 Thread GitBox
rkhachatryan commented on a change in pull request #17757: URL: https://github.com/apache/flink/pull/17757#discussion_r75136 ## File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java ## @@ -0,0 +1,134 @@ +/* + * Li

<    1   2   3   4   5   6   7   8   >