[GitHub] [flink] flinkbot edited a comment on pull request #17754: [FLINK-24861][connector][jdbc] Fix false cache lookup for empty data

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17754: URL: https://github.com/apache/flink/pull/17754#issuecomment-965189525 ## CI report: * 5c617cbc1802c0dd3c061bc84fae49de524e7584 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] flinkbot edited a comment on pull request #17856: [FLINK-24984][ci] Rename MAVEN_OPTS variable

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17856: URL: https://github.com/apache/flink/pull/17856#issuecomment-975393083 ## CI report: * 101b88f2d5a9d6351cc8ec2b691e5f7eb8a32892 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Closed] (FLINK-24986) StateHandleSerializationTest fails on Java 17

2021-11-23 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-24986. Resolution: Fixed master: a390675e6f778387933d0fc53cca0e627bbd7c1a > StateHandleSerializa

[GitHub] [flink] zentol merged pull request #17858: [FLINK-24986][tests] Replace anonymous StreamStateHandle class

2021-11-23 Thread GitBox
zentol merged pull request #17858: URL: https://github.com/apache/flink/pull/17858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[jira] [Commented] (FLINK-23525) Docker command fails on Azure: Exit code 137 returned from process: file name '/usr/bin/docker'

2021-11-23 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448102#comment-17448102 ] Chesnay Schepler commented on FLINK-23525: -- In case anyone ran into this on Nov

[GitHub] [flink] flinkbot edited a comment on pull request #17133: [FLINK-24138] Architectural tests

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17133: URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602 ## CI report: * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN * 7f5fbf7c933209fd8cb7f8681499ddadaaa4eeef Azure: [SUCCESS](https://dev.azure.com/apache-fl

[GitHub] [flink] Myasuka commented on a change in pull request #16582: [FLINK-21504][checkpoint] Introduce notification of subsumed checkpoint

2021-11-23 Thread GitBox
Myasuka commented on a change in pull request #16582: URL: https://github.com/apache/flink/pull/16582#discussion_r755288365 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java ## @@ -1405,59 +1406,80 @@ private void declineCheckpoint(

[GitHub] [flink] flinkbot edited a comment on pull request #17878: [FLINK-24507][table] Cleanup DateTimeUtils

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17878: URL: https://github.com/apache/flink/pull/17878#issuecomment-976246777 ## CI report: * 48e076f003e46a7bd4ebabf610e4e130809d39b7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] matriv commented on a change in pull request #17878: [FLINK-24507][table] Cleanup DateTimeUtils

2021-11-23 Thread GitBox
matriv commented on a change in pull request #17878: URL: https://github.com/apache/flink/pull/17878#discussion_r755287680 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/AbstractCodeGeneratorCastRule.java ## @@ -102

[GitHub] [flink] flinkbot edited a comment on pull request #17133: [FLINK-24138] Architectural tests

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17133: URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602 ## CI report: * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN * 7f5fbf7c933209fd8cb7f8681499ddadaaa4eeef Azure: [SUCCESS](https://dev.azure.com/apache-fl

[GitHub] [flink] flinkbot edited a comment on pull request #17878: [FLINK-24507][table] Cleanup DateTimeUtils

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17878: URL: https://github.com/apache/flink/pull/17878#issuecomment-976246777 ## CI report: * 48e076f003e46a7bd4ebabf610e4e130809d39b7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] matriv commented on a change in pull request #17878: [FLINK-24507][table] Cleanup DateTimeUtils

2021-11-23 Thread GitBox
matriv commented on a change in pull request #17878: URL: https://github.com/apache/flink/pull/17878#discussion_r755281396 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/AbstractCodeGeneratorCastRule.java ## @@ -102

[GitHub] [flink] snuyanzin commented on a change in pull request #17831: [FLINK-15825][Table SQL/API] Add renameDatabase() to Catalog

2021-11-23 Thread GitBox
snuyanzin commented on a change in pull request #17831: URL: https://github.com/apache/flink/pull/17831#discussion_r755280622 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/Catalog.java ## @@ -206,6 +206,22 @@ void dropDatabase(String

[GitHub] [flink] flinkbot edited a comment on pull request #17133: [FLINK-24138] Architectural tests

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17133: URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602 ## CI report: * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN * 7f5fbf7c933209fd8cb7f8681499ddadaaa4eeef Azure: [SUCCESS](https://dev.azure.com/apache-fl

[GitHub] [flink] matriv commented on a change in pull request #17878: [FLINK-24507][table] Cleanup DateTimeUtils

2021-11-23 Thread GitBox
matriv commented on a change in pull request #17878: URL: https://github.com/apache/flink/pull/17878#discussion_r755280470 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/expressions/converter/ExpressionConverter.java ## @@ -64,8 +64,

[jira] [Commented] (FLINK-24696) Translate how to configure unaligned checkpoints into Chinese

2021-11-23 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448094#comment-17448094 ] Piotr Nowojski commented on FLINK-24696: Sure, thanks! > Translate how to confi

[jira] [Assigned] (FLINK-24696) Translate how to configure unaligned checkpoints into Chinese

2021-11-23 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski reassigned FLINK-24696: -- Assignee: ZhuoYu Chen > Translate how to configure unaligned checkpoints into Chinese

[GitHub] [flink] pnowojski commented on a change in pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader

2021-11-23 Thread GitBox
pnowojski commented on a change in pull request #17757: URL: https://github.com/apache/flink/pull/17757#discussion_r755278167 ## File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStorageMetricGroup.java ## @@ -134,6 +138,6 @@ public long

[GitHub] [flink] flinkbot edited a comment on pull request #17888: [FLINK-24077][hbase2/HBaseConnectorITCase] fix sporadic ut failing

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17888: URL: https://github.com/apache/flink/pull/17888#issuecomment-976661814 ## CI report: * b6a5b1890492cd51454d4ab44a3bba2db0fe8444 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] snuyanzin commented on pull request #17527: [hotfix][docs] Add link from README.md to 'Building Flink from Source'

2021-11-23 Thread GitBox
snuyanzin commented on pull request #17527: URL: https://github.com/apache/flink/pull/17527#issuecomment-976766385 Thanks for you feedback @MartijnVisser I would agree with you if information from site is not available offline or is in a separate repo. However in fact both code and

[GitHub] [flink] flinkbot edited a comment on pull request #17133: [FLINK-24138] Architectural tests

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17133: URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602 ## CI report: * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN * 7f5fbf7c933209fd8cb7f8681499ddadaaa4eeef Azure: [SUCCESS](https://dev.azure.com/apache-fl

[jira] [Closed] (FLINK-24534) Set async based transport for remote functions default

2021-11-23 Thread Igal Shilman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igal Shilman closed FLINK-24534. Resolution: Fixed Implemented at 49f6166523db846b3de3bd888f3f93adaeb16132. > Set async based tran

[GitHub] [flink] flinkbot edited a comment on pull request #17888: [FLINK-24077][hbase2/HBaseConnectorITCase] fix sporadic ut failing

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17888: URL: https://github.com/apache/flink/pull/17888#issuecomment-976661814 ## CI report: * b6a5b1890492cd51454d4ab44a3bba2db0fe8444 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17811: [FLINK-24754] Implement CHAR/VARCHAR length validation for sinks

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17811: URL: https://github.com/apache/flink/pull/17811#issuecomment-970441907 ## CI report: * b627ce2ec995c293b05b73145374738f99fc28e5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17676: [FLINK-14100][connectors] Add Oracle dialect

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17676: URL: https://github.com/apache/flink/pull/17676#issuecomment-960641444 ## CI report: * 59a23c2ce94a99edeebb8c4a90f63c24540d8f28 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17133: [FLINK-24138] Architectural tests

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17133: URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602 ## CI report: * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN * 7f5fbf7c933209fd8cb7f8681499ddadaaa4eeef Azure: [SUCCESS](https://dev.azure.com/apache-fl

[GitHub] [flink] slinkydeveloper commented on a change in pull request #17878: [FLINK-24507][table] Cleanup DateTimeUtils

2021-11-23 Thread GitBox
slinkydeveloper commented on a change in pull request #17878: URL: https://github.com/apache/flink/pull/17878#discussion_r755262281 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/expressions/converter/ExpressionConverter.java ## @@ -

[GitHub] [flink] slinkydeveloper commented on a change in pull request #17878: [FLINK-24507][table] Cleanup DateTimeUtils

2021-11-23 Thread GitBox
slinkydeveloper commented on a change in pull request #17878: URL: https://github.com/apache/flink/pull/17878#discussion_r755269820 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/DateTimeUtils.java ## @@ -412,92 +492,267 @@ public stati

[GitHub] [flink] flinkbot edited a comment on pull request #17888: [FLINK-24077][hbase2/HBaseConnectorITCase] fix sporadic ut failing

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17888: URL: https://github.com/apache/flink/pull/17888#issuecomment-976661814 ## CI report: * b6a5b1890492cd51454d4ab44a3bba2db0fe8444 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17871: [hotfix] Add assertj in dependency management and link the code quality guide in the PR template

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17871: URL: https://github.com/apache/flink/pull/17871#issuecomment-975731882 ## CI report: * eb206096b08234d4a3153ff3a3fc64f900f24d6a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] dannycranmer commented on a change in pull request #17785: [FLINK-24580][Connectors/Kinesis] Make ConnectTimeoutException recoverable

2021-11-23 Thread GitBox
dannycranmer commented on a change in pull request #17785: URL: https://github.com/apache/flink/pull/17785#discussion_r755268744 ## File path: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java ## @@ -42

[GitHub] [flink] flinkbot edited a comment on pull request #17811: [FLINK-24754] Implement CHAR/VARCHAR length validation for sinks

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17811: URL: https://github.com/apache/flink/pull/17811#issuecomment-970441907 ## CI report: * b627ce2ec995c293b05b73145374738f99fc28e5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] slinkydeveloper commented on a change in pull request #17878: [FLINK-24507][table] Cleanup DateTimeUtils

2021-11-23 Thread GitBox
slinkydeveloper commented on a change in pull request #17878: URL: https://github.com/apache/flink/pull/17878#discussion_r755268199 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/DateTimeUtils.java ## @@ -412,92 +492,267 @@ public stati

[GitHub] [flink] flinkbot edited a comment on pull request #17676: [FLINK-14100][connectors] Add Oracle dialect

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17676: URL: https://github.com/apache/flink/pull/17676#issuecomment-960641444 ## CI report: * 59a23c2ce94a99edeebb8c4a90f63c24540d8f28 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] slinkydeveloper commented on a change in pull request #17878: [FLINK-24507][table] Cleanup DateTimeUtils

2021-11-23 Thread GitBox
slinkydeveloper commented on a change in pull request #17878: URL: https://github.com/apache/flink/pull/17878#discussion_r755267687 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/DateTimeUtils.java ## @@ -1251,133 +1356,24 @@ private st

[GitHub] [flink] flinkbot edited a comment on pull request #17133: [FLINK-24138] Architectural tests

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17133: URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602 ## CI report: * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN * 7f5fbf7c933209fd8cb7f8681499ddadaaa4eeef Azure: [SUCCESS](https://dev.azure.com/apache-fl

[GitHub] [flink] eskabetxe commented on pull request #17676: [FLINK-14100][connectors] Add Oracle dialect

2021-11-23 Thread GitBox
eskabetxe commented on pull request #17676: URL: https://github.com/apache/flink/pull/17676#issuecomment-976753062 @leonardBang done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] dannycranmer commented on pull request #17785: [FLINK-24580][Connectors/Kinesis] Make ConnectTimeoutException recoverable

2021-11-23 Thread GitBox
dannycranmer commented on pull request #17785: URL: https://github.com/apache/flink/pull/17785#issuecomment-976751804 @john-karp can you please rebase to allow CI to run? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [flink] slinkydeveloper commented on a change in pull request #17878: [FLINK-24507][table] Cleanup DateTimeUtils

2021-11-23 Thread GitBox
slinkydeveloper commented on a change in pull request #17878: URL: https://github.com/apache/flink/pull/17878#discussion_r755264508 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/AbstractCodeGeneratorCastRule.java #

[GitHub] [flink] flinkbot edited a comment on pull request #17888: [FLINK-24077][hbase2/HBaseConnectorITCase] fix sporadic ut failing

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17888: URL: https://github.com/apache/flink/pull/17888#issuecomment-976661814 ## CI report: * b6a5b1890492cd51454d4ab44a3bba2db0fe8444 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17871: [hotfix] Add assertj in dependency management and link the code quality guide in the PR template

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17871: URL: https://github.com/apache/flink/pull/17871#issuecomment-975731882 ## CI report: * eb206096b08234d4a3153ff3a3fc64f900f24d6a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17133: [FLINK-24138] Architectural tests

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17133: URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602 ## CI report: * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN * 7f5fbf7c933209fd8cb7f8681499ddadaaa4eeef Azure: [SUCCESS](https://dev.azure.com/apache-fl

[GitHub] [flink] slinkydeveloper commented on a change in pull request #17878: [FLINK-24507][table] Cleanup DateTimeUtils

2021-11-23 Thread GitBox
slinkydeveloper commented on a change in pull request #17878: URL: https://github.com/apache/flink/pull/17878#discussion_r755262281 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/expressions/converter/ExpressionConverter.java ## @@ -

[GitHub] [flink] flinkbot edited a comment on pull request #17888: [FLINK-24077][hbase2/HBaseConnectorITCase] fix sporadic ut failing

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17888: URL: https://github.com/apache/flink/pull/17888#issuecomment-976661814 ## CI report: * b6a5b1890492cd51454d4ab44a3bba2db0fe8444 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] slinkydeveloper commented on a change in pull request #17871: [hotfix] Add assertj in dependency management and link the code quality guide in the PR template

2021-11-23 Thread GitBox
slinkydeveloper commented on a change in pull request #17871: URL: https://github.com/apache/flink/pull/17871#discussion_r755259752 ## File path: pom.xml ## @@ -586,6 +587,13 @@ under the License. ${junit4.version} +

[GitHub] [flink] flinkbot edited a comment on pull request #17133: [FLINK-24138] Architectural tests

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17133: URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602 ## CI report: * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN * 7f5fbf7c933209fd8cb7f8681499ddadaaa4eeef Azure: [SUCCESS](https://dev.azure.com/apache-fl

[GitHub] [flink-shaded] XComp commented on a change in pull request #103: [FLINK-24978] Upgrade ASM to 9.2

2021-11-23 Thread GitBox
XComp commented on a change in pull request #103: URL: https://github.com/apache/flink-shaded/pull/103#discussion_r755255705 ## File path: flink-shaded-asm-9/src/main/resources/META-INF/NOTICE ## @@ -1,4 +1,4 @@ -flink-shaded-asm7 +flink-shaded-asm9 Review comment: @zen

[GitHub] [flink] flinkbot edited a comment on pull request #17888: [FLINK-24077][hbase2/HBaseConnectorITCase] fix sporadic ut failing

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17888: URL: https://github.com/apache/flink/pull/17888#issuecomment-976661814 ## CI report: * b6a5b1890492cd51454d4ab44a3bba2db0fe8444 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17883: [FLINK-24971][BP-1.13] Adding retry mechanism in case git clone fails

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17883: URL: https://github.com/apache/flink/pull/17883#issuecomment-976404430 ## CI report: * f8befc71cd89945b26fd700b451cc7168d4cc11b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Closed] (FLINK-25017) Drop Zookeeper 3.4

2021-11-23 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-25017. Resolution: Fixed shaded-master: d0b6a919aeef3b2f091017b3b8ed82b87a80707b > Drop Zookeepe

[GitHub] [flink] flinkbot edited a comment on pull request #17345: [FLINK-24227][connectors/kinesis] Added Kinesis Data Streams Sink i…

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17345: URL: https://github.com/apache/flink/pull/17345#issuecomment-926109717 ## CI report: * 87ea7d97858a671be194c5155decb275b5443792 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink-shaded] zentol merged pull request #104: [FLINK-25017] Drop Zookeeper 3.4

2021-11-23 Thread GitBox
zentol merged pull request #104: URL: https://github.com/apache/flink-shaded/pull/104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsub

[GitHub] [flink] flinkbot edited a comment on pull request #17133: [FLINK-24138] Architectural tests

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17133: URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602 ## CI report: * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN * 7f5fbf7c933209fd8cb7f8681499ddadaaa4eeef Azure: [SUCCESS](https://dev.azure.com/apache-fl

[jira] [Commented] (FLINK-24978) Upgrade ASM to 9.2

2021-11-23 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448077#comment-17448077 ] Chesnay Schepler commented on FLINK-24978: -- shaded-master: b8a97eb8e6f59fca0cb1

[GitHub] [flink-shaded] zentol merged pull request #103: [FLINK-24978] Upgrade ASM to 9.2

2021-11-23 Thread GitBox
zentol merged pull request #103: URL: https://github.com/apache/flink-shaded/pull/103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsub

[GitHub] [flink] flinkbot edited a comment on pull request #17888: [FLINK-24077][hbase2/HBaseConnectorITCase] fix sporadic ut failing

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17888: URL: https://github.com/apache/flink/pull/17888#issuecomment-976661814 ## CI report: * b6a5b1890492cd51454d4ab44a3bba2db0fe8444 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17884: [FLINK-24971][BP-1.14] Adding retry mechanism in case git clone fails

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17884: URL: https://github.com/apache/flink/pull/17884#issuecomment-976404511 ## CI report: * 953424b1cfa1a1b274eff0bc84694660cac9dc5c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17345: [FLINK-24227][connectors/kinesis] Added Kinesis Data Streams Sink i…

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17345: URL: https://github.com/apache/flink/pull/17345#issuecomment-926109717 ## CI report: * c5fdc0470d9f96ed3aaa859c304ff2e78319f2bc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17133: [FLINK-24138] Architectural tests

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17133: URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602 ## CI report: * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN * 7f5fbf7c933209fd8cb7f8681499ddadaaa4eeef Azure: [SUCCESS](https://dev.azure.com/apache-fl

[jira] [Updated] (FLINK-24077) HBaseConnectorITCase.testTableSink

2021-11-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24077: --- Labels: pull-request-available test-stability (was: test-stability) > HBaseConnectorITCase.

[GitHub] [flink] pnowojski commented on pull request #17796: [FLINK-24846][streaming] Closing the mailbox only after it drains all mails including recursive ones

2021-11-23 Thread GitBox
pnowojski commented on pull request #17796: URL: https://github.com/apache/flink/pull/17796#issuecomment-976720425 I think the scenario that you posted works fine. After `endInput()` in step 2. there shouldn't be any timers registered left, as they are being cancelled in `AsyncWaitOperator

[GitHub] [flink] flinkbot edited a comment on pull request #17888: [FLINK-24077][hbase2/HBaseConnectorITCase] fix sporadic ut failing

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17888: URL: https://github.com/apache/flink/pull/17888#issuecomment-976661814 ## CI report: * b6a5b1890492cd51454d4ab44a3bba2db0fe8444 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17829: [FLINK-24940] [docs] correct usage about how to create Hive catalog vi…

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17829: URL: https://github.com/apache/flink/pull/17829#issuecomment-972818620 ## CI report: * bb1b65ce179c7067666d5f53147e015ff4c88691 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] slinkydeveloper commented on a change in pull request #17847: [FLINK-6573][Connectors/Common ] Flink MongoDB Connector

2021-11-23 Thread GitBox
slinkydeveloper commented on a change in pull request #17847: URL: https://github.com/apache/flink/pull/17847#discussion_r755230667 ## File path: flink-connectors/flink-connector-mongodb/src/main/java/org/apache/flink/mongodb/table/source/MongodbDynamicTableSource.java ## @@ -

[GitHub] [flink] flinkbot edited a comment on pull request #17133: [FLINK-24138] Architectural tests

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17133: URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602 ## CI report: * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN * 7f5fbf7c933209fd8cb7f8681499ddadaaa4eeef Azure: [SUCCESS](https://dev.azure.com/apache-fl

[GitHub] [flink] flinkbot edited a comment on pull request #17856: [FLINK-24984][ci] Rename MAVEN_OPTS variable

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17856: URL: https://github.com/apache/flink/pull/17856#issuecomment-975393083 ## CI report: * 101b88f2d5a9d6351cc8ec2b691e5f7eb8a32892 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17701: [FLINK-24294][streaming] Register all stream task resources to one cl…

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17701: URL: https://github.com/apache/flink/pull/17701#issuecomment-962009686 ## CI report: * fc40896ffa0e888aecb5c52a5557fd980eba46b2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17556: [FLINK-24627][tests] add some Junit5 extensions to replace the existed Junit4 rules

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17556: URL: https://github.com/apache/flink/pull/17556#issuecomment-950605426 ## CI report: * 47abcfe1925ba3e10e7b8f8ec209295cb2a9a78d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17133: [FLINK-24138] Architectural tests

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17133: URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602 ## CI report: * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN * 7f5fbf7c933209fd8cb7f8681499ddadaaa4eeef Azure: [SUCCESS](https://dev.azure.com/apache-fl

[GitHub] [flink] JingGe commented on a change in pull request #17888: [Flink-24077] fix sporadic ut failing

2021-11-23 Thread GitBox
JingGe commented on a change in pull request #17888: URL: https://github.com/apache/flink/pull/17888#discussion_r755237499 ## File path: flink-connectors/flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java ## @@ -329,9 +362,13 @@

[GitHub] [flink] JingGe commented on a change in pull request #17888: [Flink-24077] fix sporadic ut failing

2021-11-23 Thread GitBox
JingGe commented on a change in pull request #17888: URL: https://github.com/apache/flink/pull/17888#discussion_r755236635 ## File path: flink-connectors/flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java ## @@ -307,12 +327,25 @

[GitHub] [flink] JingGe commented on a change in pull request #17888: [Flink-24077] fix sporadic ut failing

2021-11-23 Thread GitBox
JingGe commented on a change in pull request #17888: URL: https://github.com/apache/flink/pull/17888#discussion_r755236509 ## File path: flink-connectors/flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java ## @@ -250,13 +252,25 @

[GitHub] [flink] JingGe commented on a change in pull request #17888: [Flink-24077] fix sporadic ut failing

2021-11-23 Thread GitBox
JingGe commented on a change in pull request #17888: URL: https://github.com/apache/flink/pull/17888#discussion_r755236331 ## File path: flink-connectors/flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java ## @@ -250,13 +252,25 @

[GitHub] [flink] XComp commented on pull request #17889: [DECO-1626] Adds actual secrets

2021-11-23 Thread GitBox
XComp commented on pull request #17889: URL: https://github.com/apache/flink/pull/17889#issuecomment-976703806 The PR was created in the wrong repository -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [flink] XComp closed pull request #17889: [DECO-1626] Adds actual secrets

2021-11-23 Thread GitBox
XComp closed pull request #17889: URL: https://github.com/apache/flink/pull/17889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [flink] Airblader commented on a change in pull request #17133: [FLINK-24138] Architectural tests

2021-11-23 Thread GitBox
Airblader commented on a change in pull request #17133: URL: https://github.com/apache/flink/pull/17133#discussion_r755235532 ## File path: flink-architecture-tests/src/test/java/org/apache/flink/architecture/rules/ApiAnnotationRules.java ## @@ -0,0 +1,168 @@ +/* + * Licensed

[GitHub] [flink] flinkbot edited a comment on pull request #17856: [FLINK-24984][ci] Rename MAVEN_OPTS variable

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17856: URL: https://github.com/apache/flink/pull/17856#issuecomment-975393083 ## CI report: * 101b88f2d5a9d6351cc8ec2b691e5f7eb8a32892 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] XComp opened a new pull request #17889: [DECO-1626] Adds actual secrets

2021-11-23 Thread GitBox
XComp opened a new pull request #17889: URL: https://github.com/apache/flink/pull/17889 ## What is the purpose of the change We want to enable secret usage after they were added to the `ververica/flink` repository. ## Brief change log * Adds secrets * Adds secrets

[jira] [Commented] (FLINK-24077) HBaseConnectorITCase.testTableSink

2021-11-23 Thread Marios Trivyzas (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448072#comment-17448072 ] Marios Trivyzas commented on FLINK-24077: - Haven't managed to have a failure loc

[GitHub] [flink] flinkbot edited a comment on pull request #17701: [FLINK-24294][streaming] Register all stream task resources to one cl…

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17701: URL: https://github.com/apache/flink/pull/17701#issuecomment-962009686 ## CI report: * fc40896ffa0e888aecb5c52a5557fd980eba46b2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Commented] (FLINK-24905) KDS implementation of Async Sink Table API

2021-11-23 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448071#comment-17448071 ] Ahmed Hamdy commented on FLINK-24905: - [~arvid]  Thanks, i will be using fallback ke

[GitHub] [flink] akalash commented on a change in pull request #17701: [FLINK-24294][streaming] Register all stream task resources to one cl…

2021-11-23 Thread GitBox
akalash commented on a change in pull request #17701: URL: https://github.com/apache/flink/pull/17701#discussion_r755231423 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java ## @@ -989,19 +1006,6 @@ private void releaseOu

[jira] [Closed] (FLINK-24993) ExceptionUtils#isDirectOutOfMemoryError doesn't work on Java 17

2021-11-23 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-24993. Resolution: Fixed master: 5d741638fd8633dedb3c0f4e1ebe3c4cc4df5d21 > ExceptionUtils#isDir

[GitHub] [flink] zentol merged pull request #17865: [FLINK-24993][core] Harden ExceptionUtils against changes to exceptions

2021-11-23 Thread GitBox
zentol merged pull request #17865: URL: https://github.com/apache/flink/pull/17865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [flink] flinkbot edited a comment on pull request #17757: [FLINK-23486][state][metrics] Add metrics for the Changelog uploader

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17757: URL: https://github.com/apache/flink/pull/17757#issuecomment-965292588 ## CI report: * da3800ed083f10e70c10de50c1f77c2bd41c116a UNKNOWN * 6e7d0a992ca325e273d74c74e04d06da83622fbb Azure: [FAILURE](https://dev.azure.com/apache-fl

[GitHub] [flink] flinkbot edited a comment on pull request #17463: [Hotfix] Fix typos.

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17463: URL: https://github.com/apache/flink/pull/17463#issuecomment-942081615 ## CI report: * 47736b02c9a39fe6e14d17409a79a4fc5415aba5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] zentol commented on pull request #17855: [FLINK-24983][build] Upgrade surefire to 3.0.5-M5

2021-11-23 Thread GitBox
zentol commented on pull request #17855: URL: https://github.com/apache/flink/pull/17855#issuecomment-976690773 There are probably way more instances of this, and if there's some anonymous class then Scala will generate similar files. -- This is an automated message from the Apache Git S

[jira] [Closed] (FLINK-19615) HBaseConnectorITCase.testTableSink is instable

2021-11-23 Thread Marios Trivyzas (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marios Trivyzas closed FLINK-19615. --- Resolution: Duplicate Closing this in favour of FLINK-24077 > HBaseConnectorITCase.testTabl

[GitHub] [flink] flinkbot edited a comment on pull request #17855: [FLINK-24983][build] Upgrade surefire to 3.0.5-M5

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17855: URL: https://github.com/apache/flink/pull/17855#issuecomment-975386458 ## CI report: * 26309d1565a0b0c335b851f8801270908ca54a33 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17822: Release 1.14 kafka3.0 bug

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17822: URL: https://github.com/apache/flink/pull/17822#issuecomment-971696959 ## CI report: * ca42ca0e3df01ed1ddbd020245528ecb7b4257eb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17463: [Hotfix] Fix typos.

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17463: URL: https://github.com/apache/flink/pull/17463#issuecomment-942081615 ## CI report: * 47736b02c9a39fe6e14d17409a79a4fc5415aba5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] dannycranmer commented on a change in pull request #17345: [FLINK-24227][connectors/kinesis] Added Kinesis Data Streams Sink i…

2021-11-23 Thread GitBox
dannycranmer commented on a change in pull request #17345: URL: https://github.com/apache/flink/pull/17345#discussion_r755165723 ## File path: flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsSinkBuilder.

[GitHub] [flink] dannycranmer commented on a change in pull request #17345: [FLINK-24227][connectors/kinesis] Added Kinesis Data Streams Sink i…

2021-11-23 Thread GitBox
dannycranmer commented on a change in pull request #17345: URL: https://github.com/apache/flink/pull/17345#discussion_r755165236 ## File path: flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsSinkBuilder.

[GitHub] [flink] flinkbot edited a comment on pull request #17133: [FLINK-24138] Architectural tests

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17133: URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602 ## CI report: * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN * 7f5fbf7c933209fd8cb7f8681499ddadaaa4eeef Azure: [SUCCESS](https://dev.azure.com/apache-fl

[GitHub] [flink] nicoweidner commented on pull request #17855: [FLINK-24983][build] Upgrade surefire to 3.0.5-M5

2021-11-23 Thread GitBox
nicoweidner commented on pull request #17855: URL: https://github.com/apache/flink/pull/17855#issuecomment-976683379 Or maybe test class detection changed between surefire versions? Now that I think about it, it reads like it simply picks up this class now which is at top-level in its pare

[GitHub] [flink] flinkbot edited a comment on pull request #17865: [FLINK-24993][core] Harden ExceptionUtils against changes to exceptions

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17865: URL: https://github.com/apache/flink/pull/17865#issuecomment-975516895 ## CI report: * 707f22044b3dc3ef8c61a49b892f3515df6a8644 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17857: [FLINK-24985][tests] Relax assumptions of stacktrace layout

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17857: URL: https://github.com/apache/flink/pull/17857#issuecomment-975401663 ## CI report: * 7fe5c7914e7831df87b81e5229193737bb123bd2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17855: [FLINK-24983][build] Upgrade surefire to 3.0.5-M5

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17855: URL: https://github.com/apache/flink/pull/17855#issuecomment-975386458 ## CI report: * 26309d1565a0b0c335b851f8801270908ca54a33 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17851: [FLINK-21214][kafka/IT] add retry rule for testScaleDownBeforeFirstCh…

2021-11-23 Thread GitBox
flinkbot edited a comment on pull request #17851: URL: https://github.com/apache/flink/pull/17851#issuecomment-975348551 ## CI report: * d345c99d5d16c997c423941618e5441d17ba3f9f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] nicoweidner edited a comment on pull request #17855: [FLINK-24983][build] Upgrade surefire to 3.0.5-M5

2021-11-23 Thread GitBox
nicoweidner edited a comment on pull request #17855: URL: https://github.com/apache/flink/pull/17855#issuecomment-976675499 > Oh it's definitely related. I'm wondering why I never saw that on CI with Java 17... > > but more to the point, it's because the `integration-tests` surefire

<    1   2   3   4   5   6   7   8   9   >