[GitHub] [flink] zentol commented on pull request #18325: [FLINK-25608][metrics] Annotate metrics classes with Public(Evolving)

2022-01-12 Thread GitBox
zentol commented on pull request #18325: URL: https://github.com/apache/flink/pull/18325#issuecomment-1010870404 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] flinkbot edited a comment on pull request #18319: [FLINK-25531][connectors/kafka] Force immediate shutdown of FlinkInternalKafkaProducer to speed up testRetryComittableOnRetriableErro

2022-01-12 Thread GitBox
flinkbot edited a comment on pull request #18319: URL: https://github.com/apache/flink/pull/18319#issuecomment-1008898822 ## CI report: * 100e8eaa503d8cf8206dde2b41af86f9ba12fbf6 Azure:

[GitHub] [flink] leonardBang commented on a change in pull request #18137: [FLINK-25287][connector-testing-framework] Refactor interfaces of connector testing framework to support more scenarios

2022-01-12 Thread GitBox
leonardBang commented on a change in pull request #18137: URL: https://github.com/apache/flink/pull/18137#discussion_r782874401 ## File path: flink-test-utils-parent/flink-connector-testing/src/main/java/org/apache/flink/connectors/test/common/external/sink/TestingSinkOptions.java

[jira] [Commented] (FLINK-25068) Show the maximum parallelism (number of key groups) of a job in Web UI

2022-01-12 Thread zlzhang0122 (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17474408#comment-17474408 ] zlzhang0122 commented on FLINK-25068: - Since the FLink-12067 have been merged and the implemention

[GitHub] [flink] tillrohrmann commented on a change in pull request #18286: [FLINK-25533] Forward preferred allocations into the DeclarativeSlotPoolBridge

2022-01-12 Thread GitBox
tillrohrmann commented on a change in pull request #18286: URL: https://github.com/apache/flink/pull/18286#discussion_r782905849 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/MergingSharedSlotProfileRetrieverFactory.java ## @@ -102,12 +103,16 @@

[GitHub] [flink] leonardBang commented on a change in pull request #18137: [FLINK-25287][connector-testing-framework] Refactor interfaces of connector testing framework to support more scenarios

2022-01-12 Thread GitBox
leonardBang commented on a change in pull request #18137: URL: https://github.com/apache/flink/pull/18137#discussion_r782796141 ## File path: flink-test-utils-parent/flink-connector-testing/src/main/java/org/apache/flink/connectors/test/common/external/sink/SinkDataReader.java

[GitHub] [flink] zentol commented on a change in pull request #18334: [BP-1.14][FLINK-22821][core] Stabilize NetUtils#getAvailablePort in order to a…

2022-01-12 Thread GitBox
zentol commented on a change in pull request #18334: URL: https://github.com/apache/flink/pull/18334#discussion_r782905546 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyPartitionRequestClientTest.java ## @@ -236,16 +236,19 @@ public

[GitHub] [flink] leonardBang commented on a change in pull request #18137: [FLINK-25287][connector-testing-framework] Refactor interfaces of connector testing framework to support more scenarios

2022-01-12 Thread GitBox
leonardBang commented on a change in pull request #18137: URL: https://github.com/apache/flink/pull/18137#discussion_r782796141 ## File path: flink-test-utils-parent/flink-connector-testing/src/main/java/org/apache/flink/connectors/test/common/external/sink/SinkDataReader.java

[GitHub] [flink] tillrohrmann commented on a change in pull request #18286: [FLINK-25533] Forward preferred allocations into the DeclarativeSlotPoolBridge

2022-01-12 Thread GitBox
tillrohrmann commented on a change in pull request #18286: URL: https://github.com/apache/flink/pull/18286#discussion_r782904887 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SimpleRequestSlotMatchingStrategy.java ## @@ -0,0 +1,69 @@

[GitHub] [flink] leonardBang commented on a change in pull request #18137: [FLINK-25287][connector-testing-framework] Refactor interfaces of connector testing framework to support more scenarios

2022-01-12 Thread GitBox
leonardBang commented on a change in pull request #18137: URL: https://github.com/apache/flink/pull/18137#discussion_r782790107 ## File path:

[GitHub] [flink] zentol commented on a change in pull request #18334: [BP-1.14][FLINK-22821][core] Stabilize NetUtils#getAvailablePort in order to a…

2022-01-12 Thread GitBox
zentol commented on a change in pull request #18334: URL: https://github.com/apache/flink/pull/18334#discussion_r782904247 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyConnectionManagerTest.java ## @@ -111,18 +116,20 @@ public void

[GitHub] [flink] zentol commented on a change in pull request #18334: [BP-1.14][FLINK-22821][core] Stabilize NetUtils#getAvailablePort in order to a…

2022-01-12 Thread GitBox
zentol commented on a change in pull request #18334: URL: https://github.com/apache/flink/pull/18334#discussion_r782903751 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyConnectionManagerTest.java ## @@ -46,17 +47,21 @@ public

[GitHub] [flink] zentol commented on a change in pull request #18334: [BP-1.14][FLINK-22821][core] Stabilize NetUtils#getAvailablePort in order to a…

2022-01-12 Thread GitBox
zentol commented on a change in pull request #18334: URL: https://github.com/apache/flink/pull/18334#discussion_r782902955 ## File path: flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/ClientTest.java ## @@ -254,10

[GitHub] [flink] flinkbot edited a comment on pull request #18324: [FLINK-25557][checkpoint] Introduce incremental/full checkpoint size stats

2022-01-12 Thread GitBox
flinkbot edited a comment on pull request #18324: URL: https://github.com/apache/flink/pull/18324#issuecomment-1009752905 ## CI report: * 1a403ce534516301bbcd2c1088f60f343e3ae903 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18314: [FLINK-24228][connectors/firehose] - Unified Async Sink for Kinesis Firehose

2022-01-12 Thread GitBox
flinkbot edited a comment on pull request #18314: URL: https://github.com/apache/flink/pull/18314#issuecomment-1008761781 ## CI report: * abb8d01781d4c9fb37891c289f33b7a33ddc76c3 Azure:

[jira] [Created] (FLINK-25627) Add basic structures of file store in table-store

2022-01-12 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-25627: Summary: Add basic structures of file store in table-store Key: FLINK-25627 URL: https://issues.apache.org/jira/browse/FLINK-25627 Project: Flink Issue

[GitHub] [flink] zentol commented on a change in pull request #18334: [BP-1.14][FLINK-22821][core] Stabilize NetUtils#getAvailablePort in order to a…

2022-01-12 Thread GitBox
zentol commented on a change in pull request #18334: URL: https://github.com/apache/flink/pull/18334#discussion_r782901768 ## File path: flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java ## @@ -102,14 +105,22 @@ public void setUp() throws Exception {

[GitHub] [flink] leonardBang commented on a change in pull request #18137: [FLINK-25287][connector-testing-framework] Refactor interfaces of connector testing framework to support more scenarios

2022-01-12 Thread GitBox
leonardBang commented on a change in pull request #18137: URL: https://github.com/apache/flink/pull/18137#discussion_r782790107 ## File path:

[jira] [Commented] (FLINK-23944) PulsarSourceITCase.testTaskManagerFailure is instable

2022-01-12 Thread Yufei Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17474404#comment-17474404 ] Yufei Zhang commented on FLINK-23944: - I failed to find a way to trigger this failure case 100%. I

[GitHub] [flink] fapaul commented on a change in pull request #18201: [FLINK-25167][API / DataStream]Expose StreamOperatorFactory in Connec…

2022-01-12 Thread GitBox
fapaul commented on a change in pull request #18201: URL: https://github.com/apache/flink/pull/18201#discussion_r782900187 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/TwoInputStreamOperatorFactory.java ## @@ -0,0 +1,31 @@ +/* + *

[GitHub] [flink] tillrohrmann commented on a change in pull request #18286: [FLINK-25533] Forward preferred allocations into the DeclarativeSlotPoolBridge

2022-01-12 Thread GitBox
tillrohrmann commented on a change in pull request #18286: URL: https://github.com/apache/flink/pull/18286#discussion_r782896288 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/RequestSlotMatchingStrategy.java ## @@ -0,0 +1,58 @@ +/* + *

[GitHub] [flink] zentol commented on pull request #18334: [BP-1.14][FLINK-22821][core] Stabilize NetUtils#getAvailablePort in order to a…

2022-01-12 Thread GitBox
zentol commented on pull request #18334: URL: https://github.com/apache/flink/pull/18334#issuecomment-1010855565 This is such a weird change. It only protects against concurrent uses of `NetUtils#getAvailablePort`, but any other port allocation can still break it. It also seems like

[jira] [Updated] (FLINK-25179) Add document for array,map,row types support for parquet row writer

2022-01-12 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Paul updated FLINK-25179: Affects Version/s: 1.15.0 > Add document for array,map,row types support for parquet row writer >

[jira] [Commented] (FLINK-25179) Add document for array,map,row types support for parquet row writer

2022-01-12 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17474401#comment-17474401 ] Fabian Paul commented on FLINK-25179: - Merged in master: d31b78573911dd73cfee4741c8f46f965010f2ea >

[jira] [Resolved] (FLINK-25179) Add document for array,map,row types support for parquet row writer

2022-01-12 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Paul resolved FLINK-25179. - Resolution: Fixed > Add document for array,map,row types support for parquet row writer >

[GitHub] [flink] wangyang0918 commented on pull request #17819: [FLINK-15816][k8s] Prevent labels using kubernetes.cluster-id to exceed the limit of 63 characters

2022-01-12 Thread GitBox
wangyang0918 commented on pull request #17819: URL: https://github.com/apache/flink/pull/17819#issuecomment-1010850333 Another thing is that maybe we could also add the pre-condition check for `KubernetesUtils#getCommonLabels`. This is the root cause why we reopen FLINK-15816. Not the

[GitHub] [flink] flinkbot edited a comment on pull request #18336: [FLINK-25441][network] Wrap failure cuase with ProducerFailedException only for PipelinedSubpartitionView

2022-01-12 Thread GitBox
flinkbot edited a comment on pull request #18336: URL: https://github.com/apache/flink/pull/18336#issuecomment-1010777588 ## CI report: * 79980aac09b1eabe9a2d78ecfb0eb68b1d04b26c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18324: [FLINK-25557][checkpoint] Introduce incremental/full checkpoint size stats

2022-01-12 Thread GitBox
flinkbot edited a comment on pull request #18324: URL: https://github.com/apache/flink/pull/18324#issuecomment-1009752905 ## CI report: * 1a403ce534516301bbcd2c1088f60f343e3ae903 Azure:

[GitHub] [flink] tillrohrmann commented on a change in pull request #18286: [FLINK-25533] Forward preferred allocations into the DeclarativeSlotPoolBridge

2022-01-12 Thread GitBox
tillrohrmann commented on a change in pull request #18286: URL: https://github.com/apache/flink/pull/18286#discussion_r782896288 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/RequestSlotMatchingStrategy.java ## @@ -0,0 +1,58 @@ +/* + *

[GitHub] [flink] fapaul merged pull request #18037: [FLINK-25179] Add document for composite types support for parquet

2022-01-12 Thread GitBox
fapaul merged pull request #18037: URL: https://github.com/apache/flink/pull/18037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot edited a comment on pull request #18314: [FLINK-24228][connectors/firehose] - Unified Async Sink for Kinesis Firehose

2022-01-12 Thread GitBox
flinkbot edited a comment on pull request #18314: URL: https://github.com/apache/flink/pull/18314#issuecomment-1008761781 ## CI report: * abb8d01781d4c9fb37891c289f33b7a33ddc76c3 Azure:

[GitHub] [flink] Thesharing edited a comment on pull request #17777: [FLINK-24886][core] TimeUtils supports the form of m.

2022-01-12 Thread GitBox
Thesharing edited a comment on pull request #1: URL: https://github.com/apache/flink/pull/1#issuecomment-1010705038 > hi @Thesharing , orignial commits are 4, i just reset the first commit and rebase code, then ci is running and you can see the log Thank you for rebasing the

[jira] [Commented] (FLINK-12607) Introduce a REST API that returns the maxParallelism of a job

2022-01-12 Thread zlzhang0122 (Jira)
[ https://issues.apache.org/jira/browse/FLINK-12607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17474400#comment-17474400 ] zlzhang0122 commented on FLINK-12607: - _The parameter of the

[GitHub] [flink] tillrohrmann commented on a change in pull request #18286: [FLINK-25533] Forward preferred allocations into the DeclarativeSlotPoolBridge

2022-01-12 Thread GitBox
tillrohrmann commented on a change in pull request #18286: URL: https://github.com/apache/flink/pull/18286#discussion_r782893415 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java ## @@ -162,9 +163,30 @@ void start( *

[GitHub] [flink] Thesharing commented on pull request #17777: [FLINK-24886][core] TimeUtils supports the form of m.

2022-01-12 Thread GitBox
Thesharing commented on pull request #1: URL: https://github.com/apache/flink/pull/1#issuecomment-1010846811 > Why is the order of units important? Because

[GitHub] [flink-web] lindong28 commented on pull request #498: Make minor change to the 'Apache Flink ML 2.0.0 Release Announcement'

2022-01-12 Thread GitBox
lindong28 commented on pull request #498: URL: https://github.com/apache/flink-web/pull/498#issuecomment-1010845667 The change has been verified by running `./docker-build.sh -p` and opening `http://0.0.0.0:4000/news/2022/01/07/release-ml-2.0.0.html`. -- This is an automated message

[GitHub] [flink] wangyang0918 commented on pull request #17819: [FLINK-15816][k8s] Prevent labels using kubernetes.cluster-id to exceed the limit of 63 characters

2022-01-12 Thread GitBox
wangyang0918 commented on pull request #17819: URL: https://github.com/apache/flink/pull/17819#issuecomment-1010844505 @alpreu In current implementation, the ConfigMap name could not be logger than 63 characters. This is my only concern about this PR. Before this change, I think we do not

[GitHub] [flink] flinkbot edited a comment on pull request #18336: [FLINK-25441][network] Wrap failure cuase with ProducerFailedException only for PipelinedSubpartitionView

2022-01-12 Thread GitBox
flinkbot edited a comment on pull request #18336: URL: https://github.com/apache/flink/pull/18336#issuecomment-1010777588 ## CI report: * 79980aac09b1eabe9a2d78ecfb0eb68b1d04b26c Azure:

[GitHub] [flink] pnowojski commented on a change in pull request #18336: [FLINK-25441][network] Wrap failure cuase with ProducerFailedException only for PipelinedSubpartitionView

2022-01-12 Thread GitBox
pnowojski commented on a change in pull request #18336: URL: https://github.com/apache/flink/pull/18336#discussion_r782885250 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartitionView.java ## @@ -55,6 +55,14 @@ default void

[jira] [Closed] (FLINK-25625) Introduce FileFormat for table-store

2022-01-12 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-25625. Resolution: Fixed master: cc1cbd1c967cca14f9a7240fff494d380fda2f9a > Introduce FileFormat for

[GitHub] [flink-table-store] JingsongLi merged pull request #2: [FLINK-25625] Introduce FileFormat

2022-01-12 Thread GitBox
JingsongLi merged pull request #2: URL: https://github.com/apache/flink-table-store/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-25614) Let LocalWindowAggregate be chained with upstream

2022-01-12 Thread Wenlong Lyu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17474394#comment-17474394 ] Wenlong Lyu commented on FLINK-25614: - hi, I think this is a bug actually. [~lmagics] could you also

[GitHub] [flink] flinkbot edited a comment on pull request #18339: [FLINK-25613][build] Sync surefire versions

2022-01-12 Thread GitBox
flinkbot edited a comment on pull request #18339: URL: https://github.com/apache/flink/pull/18339#issuecomment-1010832830 ## CI report: * 89d889d88a65ab7995ddb956b5871644169a681a Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18336: [FLINK-25441][network] Wrap failure cuase with ProducerFailedException only for PipelinedSubpartitionView

2022-01-12 Thread GitBox
flinkbot edited a comment on pull request #18336: URL: https://github.com/apache/flink/pull/18336#issuecomment-1010777588 ## CI report: * 79980aac09b1eabe9a2d78ecfb0eb68b1d04b26c Azure:

[GitHub] [flink] flinkbot commented on pull request #18339: [FLINK-25613][build] Sync surefire versions

2022-01-12 Thread GitBox
flinkbot commented on pull request #18339: URL: https://github.com/apache/flink/pull/18339#issuecomment-1010832830 ## CI report: * 89d889d88a65ab7995ddb956b5871644169a681a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #18338: [FLINK-25278][ci] Use Maven proxy for confluent repo

2022-01-12 Thread GitBox
flinkbot edited a comment on pull request #18338: URL: https://github.com/apache/flink/pull/18338#issuecomment-1010827695 ## CI report: * 038e45a8e4aafba7dd538f4a4e2d40e108da6eb1 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18336: [FLINK-25441][network] Wrap failure cuase with ProducerFailedException only for PipelinedSubpartitionView

2022-01-12 Thread GitBox
flinkbot edited a comment on pull request #18336: URL: https://github.com/apache/flink/pull/18336#issuecomment-1010777588 ## CI report: * 79980aac09b1eabe9a2d78ecfb0eb68b1d04b26c Azure:

[GitHub] [flink] wenlong88 commented on a change in pull request #18331: [FLINK-25614][table/runtime] Let LocalWindowAggregate be chained with upstream

2022-01-12 Thread GitBox
wenlong88 commented on a change in pull request #18331: URL: https://github.com/apache/flink/pull/18331#discussion_r782864309 ## File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/slicing/SliceAssigners.java ## @@ -552,7

[GitHub] [flink] flinkbot edited a comment on pull request #17936: [FLINK-24954][network] Refresh read buffer request timeout on buffer recycling/requesting for sort-shuffle

2022-01-12 Thread GitBox
flinkbot edited a comment on pull request #17936: URL: https://github.com/apache/flink/pull/17936#issuecomment-980533423 ## CI report: * 52333d291058310d84b19cef804268a59c2a4da9 Azure:

[jira] [Comment Edited] (FLINK-25584) Azure failed on install node and npm for Flink : Runtime web

2022-01-12 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472685#comment-17472685 ] Chesnay Schepler edited comment on FLINK-25584 at 1/12/22, 9:27 AM:

[jira] [Commented] (FLINK-25620) Upload artifacts to S3 failed on azure pipeline

2022-01-12 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17474391#comment-17474391 ] Chesnay Schepler commented on FLINK-25620: -- That's...weird? And very concerning; where the hell

[GitHub] [flink] flinkbot commented on pull request #18339: [FLINK-25613][build] Sync surefire versions

2022-01-12 Thread GitBox
flinkbot commented on pull request #18339: URL: https://github.com/apache/flink/pull/18339#issuecomment-1010829289 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot commented on pull request #18338: [FLINK-25278][ci] Use Maven proxy for confluent repo

2022-01-12 Thread GitBox
flinkbot commented on pull request #18338: URL: https://github.com/apache/flink/pull/18338#issuecomment-1010827695 ## CI report: * 038e45a8e4aafba7dd538f4a4e2d40e108da6eb1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[jira] [Updated] (FLINK-25278) Azure failed due to unable to transfer jar from confluent maven repo

2022-01-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-25278: --- Labels: pull-request-available stale-critical test-stability (was: stale-critical

[GitHub] [flink] flinkbot edited a comment on pull request #18319: [FLINK-25531][connectors/kafka] Force immediate shutdown of FlinkInternalKafkaProducer to speed up testRetryComittableOnRetriableErro

2022-01-12 Thread GitBox
flinkbot edited a comment on pull request #18319: URL: https://github.com/apache/flink/pull/18319#issuecomment-1008898822 ## CI report: * 100e8eaa503d8cf8206dde2b41af86f9ba12fbf6 Azure:

[jira] [Updated] (FLINK-25613) Remove excessive surefire-plugin versions

2022-01-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-25613: --- Labels: pull-request-available (was: ) > Remove excessive surefire-plugin versions >

[GitHub] [flink] wanglijie95 commented on pull request #18336: [FLINK-25441][network] Wrap failure cuase with ProducerFailedException only for PipelinedSubpartitionView

2022-01-12 Thread GitBox
wanglijie95 commented on pull request #18336: URL: https://github.com/apache/flink/pull/18336#issuecomment-1010826751 > Are you sure it should be this way? That `SortMergeSubpartitionReader` is always throwing "primary" failures without wrapping "ProducerFailedException"? Yes, I'm

[GitHub] [flink] flinkbot commented on pull request #18338: [FLINK-25278][ci] Use Maven proxy for confluent repo

2022-01-12 Thread GitBox
flinkbot commented on pull request #18338: URL: https://github.com/apache/flink/pull/18338#issuecomment-1010826578 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Commented] (FLINK-23843) Exceptions during "SplitEnumeratorContext.runInCoordinatorThread()" should cause Global Failure instead of Process Kill

2022-01-12 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17474390#comment-17474390 ] Etienne Chauchot commented on FLINK-23843: -- By the way [~trohrmann]can you assign the ticket to

[GitHub] [flink] zentol opened a new pull request #18339: [FLINK-25613][build] Sync surefire versions

2022-01-12 Thread GitBox
zentol opened a new pull request #18339: URL: https://github.com/apache/flink/pull/18339 All modules now use the surefire version defined in the root pom. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Comment Edited] (FLINK-23843) Exceptions during "SplitEnumeratorContext.runInCoordinatorThread()" should cause Global Failure instead of Process Kill

2022-01-12 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17474390#comment-17474390 ] Etienne Chauchot edited comment on FLINK-23843 at 1/12/22, 9:22 AM:

[GitHub] [flink] flinkbot edited a comment on pull request #17936: [FLINK-24954][network] Refresh read buffer request timeout on buffer recycling/requesting for sort-shuffle

2022-01-12 Thread GitBox
flinkbot edited a comment on pull request #17936: URL: https://github.com/apache/flink/pull/17936#issuecomment-980533423 ## CI report: * 52333d291058310d84b19cef804268a59c2a4da9 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17452: [FLINK-20732][connector/pulsar] Introduction of Pulsar Sink

2022-01-12 Thread GitBox
flinkbot edited a comment on pull request #17452: URL: https://github.com/apache/flink/pull/17452#issuecomment-940136217 ## CI report: * 8e3d80bc6fc29bf1865667fff9ab32495fd217f0 Azure:

[GitHub] [flink] wanglijie95 commented on a change in pull request #18336: [FLINK-25441][network] Wrap failure cuase with ProducerFailedException only for PipelinedSubpartitionView

2022-01-12 Thread GitBox
wanglijie95 commented on a change in pull request #18336: URL: https://github.com/apache/flink/pull/18336#discussion_r782859526 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartitionView.java ## @@ -91,7 +91,11 @@ public

[GitHub] [flink] dannycranmer commented on a change in pull request #18165: [FLINK-24904][docs] Updated docs to reflect new KDS Sink and deprecat…

2022-01-12 Thread GitBox
dannycranmer commented on a change in pull request #18165: URL: https://github.com/apache/flink/pull/18165#discussion_r782845007 ## File path: docs/content/docs/connectors/datastream/kinesis.md ## @@ -566,124 +583,124 @@ Retry and backoff parameters can be configured using

[GitHub] [flink] flinkbot edited a comment on pull request #18319: [FLINK-25531][connectors/kafka] Force immediate shutdown of FlinkInternalKafkaProducer to speed up testRetryComittableOnRetriableErro

2022-01-12 Thread GitBox
flinkbot edited a comment on pull request #18319: URL: https://github.com/apache/flink/pull/18319#issuecomment-1008898822 ## CI report: * 100e8eaa503d8cf8206dde2b41af86f9ba12fbf6 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17936: [FLINK-24954][network] Refresh read buffer request timeout on buffer recycling/requesting for sort-shuffle

2022-01-12 Thread GitBox
flinkbot edited a comment on pull request #17936: URL: https://github.com/apache/flink/pull/17936#issuecomment-980533423 ## CI report: * 52333d291058310d84b19cef804268a59c2a4da9 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17452: [FLINK-20732][connector/pulsar] Introduction of Pulsar Sink

2022-01-12 Thread GitBox
flinkbot edited a comment on pull request #17452: URL: https://github.com/apache/flink/pull/17452#issuecomment-940136217 ## CI report: * 8e3d80bc6fc29bf1865667fff9ab32495fd217f0 Azure:

[GitHub] [flink] alpreu commented on pull request #18319: [FLINK-25531][connectors/kafka] Force immediate shutdown of FlinkInternalKafkaProducer to speed up testRetryComittableOnRetriableError

2022-01-12 Thread GitBox
alpreu commented on pull request #18319: URL: https://github.com/apache/flink/pull/18319#issuecomment-1010818542 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] zentol commented on a change in pull request #18325: [FLINK-25608][metrics] Annotate metrics classes with Public(Evolving)

2022-01-12 Thread GitBox
zentol commented on a change in pull request #18325: URL: https://github.com/apache/flink/pull/18325#discussion_r782853586 ## File path: flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/LogicalScopeProvider.java ## @@ -17,13 +17,16 @@ package

[jira] [Updated] (FLINK-23976) Add additional availability timing metrics to Job lifecycle events

2022-01-12 Thread Konstantin Knauf (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Knauf updated FLINK-23976: - Labels: pull-request-available (was: auto-deprioritized-major pull-request-available)

[GitHub] [flink] flinkbot edited a comment on pull request #18337: [hotfix][tests] Fix the error parameter

2022-01-12 Thread GitBox
flinkbot edited a comment on pull request #18337: URL: https://github.com/apache/flink/pull/18337#issuecomment-1010814031 ## CI report: * 5d2adcfa1f8d183d0fb592f26f4a776217a76b04 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17936: [FLINK-24954][network] Refresh read buffer request timeout on buffer recycling/requesting for sort-shuffle

2022-01-12 Thread GitBox
flinkbot edited a comment on pull request #17936: URL: https://github.com/apache/flink/pull/17936#issuecomment-980533423 ## CI report: * 52333d291058310d84b19cef804268a59c2a4da9 Azure:

[GitHub] [flink] alpreu commented on pull request #17819: [FLINK-15816][k8s] Prevent labels using kubernetes.cluster-id to exceed the limit of 63 characters

2022-01-12 Thread GitBox
alpreu commented on pull request #17819: URL: https://github.com/apache/flink/pull/17819#issuecomment-1010816128 Hi @wangyang0918 could you clarify once more please what code changes would like to see for the PR to be merged? I think it would be great if we can still get this into the

[GitHub] [flink] tillrohrmann commented on pull request #17777: [FLINK-24886][core] TimeUtils supports the form of m.

2022-01-12 Thread GitBox
tillrohrmann commented on pull request #1: URL: https://github.com/apache/flink/pull/1#issuecomment-1010814744 > > hi @Thesharing , orignial commits are 4, i just reset the first commit and rebase code, then ci is running and you can see the log > > Thank you for rebasing

[GitHub] [flink] flinkbot commented on pull request #18337: [hotfix][tests] Fix the error parameter

2022-01-12 Thread GitBox
flinkbot commented on pull request #18337: URL: https://github.com/apache/flink/pull/18337#issuecomment-1010814031 ## CI report: * 5d2adcfa1f8d183d0fb592f26f4a776217a76b04 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] tillrohrmann commented on a change in pull request #18220: [FLINK-25410] Flink CLI should exit when app is accepted with detach …

2022-01-12 Thread GitBox
tillrohrmann commented on a change in pull request #18220: URL: https://github.com/apache/flink/pull/18220#discussion_r782849030 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/ApplicationReportProviderImpl.java ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache

[GitHub] [flink] tillrohrmann commented on a change in pull request #18220: [FLINK-25410] Flink CLI should exit when app is accepted with detach …

2022-01-12 Thread GitBox
tillrohrmann commented on a change in pull request #18220: URL: https://github.com/apache/flink/pull/18220#discussion_r782848602 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClientRetrieverImpl.java ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache

[GitHub] [flink] flinkbot edited a comment on pull request #17936: [FLINK-24954][network] Refresh read buffer request timeout on buffer recycling/requesting for sort-shuffle

2022-01-12 Thread GitBox
flinkbot edited a comment on pull request #17936: URL: https://github.com/apache/flink/pull/17936#issuecomment-980533423 ## CI report: * 52333d291058310d84b19cef804268a59c2a4da9 Azure:

[jira] [Commented] (FLINK-25070) FLIP-195: Improve the name and structure of vertex and operator name for job

2022-01-12 Thread Wenlong Lyu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17474384#comment-17474384 ] Wenlong Lyu commented on FLINK-25070: - [~MartijnVisser], yes, by default the sql operator name would

[GitHub] [flink] flinkbot commented on pull request #18337: [hotfix][tests] Fix the error parameter

2022-01-12 Thread GitBox
flinkbot commented on pull request #18337: URL: https://github.com/apache/flink/pull/18337#issuecomment-1010811247 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Commented] (FLINK-25053) Document how to use the usrlib to load code in the user code class loader

2022-01-12 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17474380#comment-17474380 ] Till Rohrmann commented on FLINK-25053: --- [~wanglijie95] are you still working on this issue? >

[GitHub] [flink] flinkbot edited a comment on pull request #17936: [FLINK-24954][network] Refresh read buffer request timeout on buffer recycling/requesting for sort-shuffle

2022-01-12 Thread GitBox
flinkbot edited a comment on pull request #17936: URL: https://github.com/apache/flink/pull/17936#issuecomment-980533423 ## CI report: * 52333d291058310d84b19cef804268a59c2a4da9 Azure:

[GitHub] [flink] zlzhang0122 opened a new pull request #18337: [hotfix][tests] Fix the error parameter

2022-01-12 Thread GitBox
zlzhang0122 opened a new pull request #18337: URL: https://github.com/apache/flink/pull/18337 ## What is the purpose of the change *The parameter of the ArchivedExecutionConfigBuilder.setMaxParallelism() is error* ## Brief change log *fix the error parameter*

[GitHub] [flink-benchmarks] pnowojski commented on pull request #41: [FLINK-24918][Runtime/State Backends]Support to specify the data dir for state benchmark

2022-01-12 Thread GitBox
pnowojski commented on pull request #41: URL: https://github.com/apache/flink-benchmarks/pull/41#issuecomment-1010801239 Thanks @Aitozi. I will do it, but could you take a look at the travis failure? It looks probably unrelated to your change, but it blocks merging of this PR. -- This

[GitHub] [flink] flinkbot edited a comment on pull request #18334: [BP-1.14][FLINK-22821][core] Stabilize NetUtils#getAvailablePort in order to a…

2022-01-12 Thread GitBox
flinkbot edited a comment on pull request #18334: URL: https://github.com/apache/flink/pull/18334#issuecomment-1010588736 ## CI report: * 96533113ed380aa0a8d5edc10ab61cc32620be0f Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18332: [FLINK-25427] Fix SavepointITCase.testTriggerSavepointAndResumeWithNo…

2022-01-12 Thread GitBox
flinkbot edited a comment on pull request #18332: URL: https://github.com/apache/flink/pull/18332#issuecomment-1010219286 ## CI report: * 899e78f146881ebfc1a034522182a528599daebc Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17936: [FLINK-24954][network] Refresh read buffer request timeout on buffer recycling/requesting for sort-shuffle

2022-01-12 Thread GitBox
flinkbot edited a comment on pull request #17936: URL: https://github.com/apache/flink/pull/17936#issuecomment-980533423 ## CI report: * 52333d291058310d84b19cef804268a59c2a4da9 Azure:

[GitHub] [flink] pnowojski commented on a change in pull request #18336: [FLINK-25441][network] Wrap failure cuase with ProducerFailedException only for PipelinedSubpartitionView

2022-01-12 Thread GitBox
pnowojski commented on a change in pull request #18336: URL: https://github.com/apache/flink/pull/18336#discussion_r782836619 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartitionView.java ## @@ -91,7 +91,11 @@ public

[jira] [Commented] (FLINK-25586) ExecutionGraphInfoStore in session cluster should split failed and successful jobs

2022-01-12 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-25586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17474374#comment-17474374 ] David Morávek commented on FLINK-25586: --- This makes sense +1 Just one question, how should this

[jira] [Commented] (FLINK-24801) "Post-job: Cache Maven local repo" failed on Azure

2022-01-12 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17474373#comment-17474373 ] Chesnay Schepler commented on FLINK-24801: -- ??Might the previous issue also caused by the disk

[GitHub] [flink] flinkbot edited a comment on pull request #18332: [FLINK-25427] Fix SavepointITCase.testTriggerSavepointAndResumeWithNo…

2022-01-12 Thread GitBox
flinkbot edited a comment on pull request #18332: URL: https://github.com/apache/flink/pull/18332#issuecomment-1010219286 ## CI report: * 899e78f146881ebfc1a034522182a528599daebc Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17936: [FLINK-24954][network] Refresh read buffer request timeout on buffer recycling/requesting for sort-shuffle

2022-01-12 Thread GitBox
flinkbot edited a comment on pull request #17936: URL: https://github.com/apache/flink/pull/17936#issuecomment-980533423 ## CI report: * 52333d291058310d84b19cef804268a59c2a4da9 Azure:

[GitHub] [flink] dmvk commented on a change in pull request #18332: [FLINK-25427] Fix SavepointITCase.testTriggerSavepointAndResumeWithNo…

2022-01-12 Thread GitBox
dmvk commented on a change in pull request #18332: URL: https://github.com/apache/flink/pull/18332#discussion_r782828427 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/minicluster/MiniClusterITCase.java ## @@ -653,14 +653,7 @@ public void

[GitHub] [flink] flinkbot edited a comment on pull request #18220: [FLINK-25410] Flink CLI should exit when app is accepted with detach …

2022-01-12 Thread GitBox
flinkbot edited a comment on pull request #18220: URL: https://github.com/apache/flink/pull/18220#issuecomment-1001978981 ## CI report: * fba405054a8ac366cebddce7b9b7f263bc5ea1d9 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17936: [FLINK-24954][network] Refresh read buffer request timeout on buffer recycling/requesting for sort-shuffle

2022-01-12 Thread GitBox
flinkbot edited a comment on pull request #17936: URL: https://github.com/apache/flink/pull/17936#issuecomment-980533423 ## CI report: * 52333d291058310d84b19cef804268a59c2a4da9 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18336: [FLINK-25441][network] Wrap failure cuase with ProducerFailedException only for PipelinedSubpartitionView

2022-01-12 Thread GitBox
flinkbot edited a comment on pull request #18336: URL: https://github.com/apache/flink/pull/18336#issuecomment-1010777588 ## CI report: * 79980aac09b1eabe9a2d78ecfb0eb68b1d04b26c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17936: [FLINK-24954][network] Refresh read buffer request timeout on buffer recycling/requesting for sort-shuffle

2022-01-12 Thread GitBox
flinkbot edited a comment on pull request #17936: URL: https://github.com/apache/flink/pull/17936#issuecomment-980533423 ## CI report: * 52333d291058310d84b19cef804268a59c2a4da9 Azure:

[GitHub] [flink] zuston commented on pull request #18157: [FLINK-17808] Rename checkpoint meta file to "_metadata" until it has…

2022-01-12 Thread GitBox
zuston commented on pull request #18157: URL: https://github.com/apache/flink/pull/18157#issuecomment-1010778009 Gentle ping @gaoyunhaii. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (FLINK-25585) JobManagerHAProcessFailureRecoveryITCase.testDispatcherProcessFailure failed on the azure

2022-01-12 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-25585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17474367#comment-17474367 ] David Morávek commented on FLINK-25585: --- Hi [~gaoyunhaii], I did a short pass on this one. -

<    1   2   3   4   5   6   7   >