[jira] [Commented] (FLINK-22643) Too many TCP connections among TaskManagers for large scale jobs

2022-01-14 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476009#comment-17476009 ] Piotr Nowojski commented on FLINK-22643: Thanks for the analysis! Ok, sounds goo

[GitHub] [flink] wuchong commented on pull request #18361: [FLINK-25631][table] Support enhanced `show tables` syntax

2022-01-14 Thread GitBox
wuchong commented on pull request #18361: URL: https://github.com/apache/flink/pull/18361#issuecomment-1012894487 Sure @liyubin117 , I will review it the next days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #7: [FLINK-25643] Introduce Predicate to table store

2022-01-14 Thread GitBox
JingsongLi commented on a change in pull request #7: URL: https://github.com/apache/flink-table-store/pull/7#discussion_r784634047 ## File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/predicate/Equal.java ## @@ -0,0 +1,52 @@ +/* + * Licensed to

[GitHub] [flink] Myasuka commented on a change in pull request #18324: [FLINK-25557][checkpoint] Introduce incremental/full checkpoint size stats

2022-01-14 Thread GitBox
Myasuka commented on a change in pull request #18324: URL: https://github.com/apache/flink/pull/18324#discussion_r784635071 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateBackendHandle.java ## @@ -113,6 +124,19 @@ public long g

[GitHub] [flink-table-store] JingsongLi closed pull request #8: [FLINK-25630] Introduce manifest related data structure and files

2022-01-14 Thread GitBox
JingsongLi closed pull request #8: URL: https://github.com/apache/flink-table-store/pull/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[jira] [Comment Edited] (FLINK-25630) Introduce MergeTree writer and reader for table store

2022-01-14 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475253#comment-17475253 ] Jingsong Lee edited comment on FLINK-25630 at 1/14/22, 8:11 AM: --

[GitHub] [flink] Myasuka commented on a change in pull request #18324: [FLINK-25557][checkpoint] Introduce incremental/full checkpoint size stats

2022-01-14 Thread GitBox
Myasuka commented on a change in pull request #18324: URL: https://github.com/apache/flink/pull/18324#discussion_r784638145 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateBackendHandle.java ## @@ -50,17 +50,28 @@ class C

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18352: [FLINK-15585][table] Improve function identifier string in plan digest

2022-01-14 Thread GitBox
slinkydeveloper commented on a change in pull request #18352: URL: https://github.com/apache/flink/pull/18352#discussion_r784638813 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/UserDefinedFunctionHelper.java ## @@ -243,6 +244,36 @

[GitHub] [flink] twalthr closed pull request #18342: [FLINK-25230][table-planner] Replace RelDataType with LogicalType serialization

2022-01-14 Thread GitBox
twalthr closed pull request #18342: URL: https://github.com/apache/flink/pull/18342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18290: [FLINK-25391][connectors][formats] Update existing table factories/format factories for catalog table options forwarding

2022-01-14 Thread GitBox
slinkydeveloper commented on a change in pull request #18290: URL: https://github.com/apache/flink/pull/18290#discussion_r784639062 ## File path: docs/content/docs/connectors/table/kinesis.md ## @@ -255,349 +271,399 @@ Connector Options scan.stream.initpos o

[jira] [Closed] (FLINK-25230) Harden type serialization in JSON plan

2022-01-14 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-25230. Fix Version/s: 1.15.0 Resolution: Fixed > Harden type serialization in JSON plan >

[jira] [Commented] (FLINK-25230) Harden type serialization in JSON plan

2022-01-14 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476013#comment-17476013 ] Timo Walther commented on FLINK-25230: -- commit 75992f495192b84cfe406d7e24a1188c7cb2

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18290: [FLINK-25391][connectors][formats] Update existing table factories/format factories for catalog table options forwarding

2022-01-14 Thread GitBox
slinkydeveloper commented on a change in pull request #18290: URL: https://github.com/apache/flink/pull/18290#discussion_r784639844 ## File path: docs/content/docs/connectors/table/hbase.md ## @@ -103,34 +105,39 @@ Connector Options table-name required +

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18290: [FLINK-25391][connectors][formats] Update existing table factories/format factories for catalog table options forwarding

2022-01-14 Thread GitBox
slinkydeveloper commented on a change in pull request #18290: URL: https://github.com/apache/flink/pull/18290#discussion_r784640093 ## File path: docs/content/docs/connectors/table/filesystem.md ## @@ -325,33 +347,43 @@ Time extractors define extracting time from partition val

[jira] [Assigned] (FLINK-25654) Remove the redundant lock in SortMergeResultPartition

2022-01-14 Thread Yingjie Cao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yingjie Cao reassigned FLINK-25654: --- Assignee: Yuxin Tan > Remove the redundant lock in SortMergeResultPartition > -

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18290: [FLINK-25391][connectors][formats] Update existing table factories/format factories for catalog table options forwarding

2022-01-14 Thread GitBox
slinkydeveloper commented on a change in pull request #18290: URL: https://github.com/apache/flink/pull/18290#discussion_r784640693 ## File path: docs/content/docs/connectors/table/elasticsearch.md ## @@ -67,15 +67,17 @@ Connector Options Option Requir

[GitHub] [flink] Myasuka commented on a change in pull request #18324: [FLINK-25557][checkpoint] Introduce incremental/full checkpoint size stats

2022-01-14 Thread GitBox
Myasuka commented on a change in pull request #18324: URL: https://github.com/apache/flink/pull/18324#discussion_r784642224 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/IncrementalRemoteKeyedStateHandle.java ## @@ -204,6 +203,21 @@ public long getSt

[GitHub] [flink-table-store] tsreaper commented on a change in pull request #7: [FLINK-25643] Introduce Predicate to table store

2022-01-14 Thread GitBox
tsreaper commented on a change in pull request #7: URL: https://github.com/apache/flink-table-store/pull/7#discussion_r784642303 ## File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/predicate/Equal.java ## @@ -0,0 +1,52 @@ +/* + * Licensed to th

[GitHub] [flink] twalthr closed pull request #18215: [FLINK-25392][table-planner]Support new StatementSet syntax in planner and parser

2022-01-14 Thread GitBox
twalthr closed pull request #18215: URL: https://github.com/apache/flink/pull/18215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[jira] [Closed] (FLINK-25392) Add new STATEMENT SET syntax

2022-01-14 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-25392. Fix Version/s: 1.15.0 Release Note: It is recommended to update statement sets to the new SQL

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18290: [FLINK-25391][connectors][formats] Update existing table factories/format factories for catalog table options forwarding

2022-01-14 Thread GitBox
slinkydeveloper commented on a change in pull request #18290: URL: https://github.com/apache/flink/pull/18290#discussion_r784645598 ## File path: docs/content/docs/connectors/table/kinesis.md ## @@ -178,69 +184,79 @@ Connector Options aws.credentials.provider

[GitHub] [flink] Myasuka commented on a change in pull request #18324: [FLINK-25557][checkpoint] Introduce incremental/full checkpoint size stats

2022-01-14 Thread GitBox
Myasuka commented on a change in pull request #18324: URL: https://github.com/apache/flink/pull/18324#discussion_r784648887 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/StateObject.java ## @@ -63,4 +63,14 @@ * @return Size of the state in byte

[GitHub] [flink-table-store] JingsongLi merged pull request #7: [FLINK-25643] Introduce Predicate to table store

2022-01-14 Thread GitBox
JingsongLi merged pull request #7: URL: https://github.com/apache/flink-table-store/pull/7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[GitHub] [flink] twalthr commented on a change in pull request #18352: [FLINK-15585][table] Improve function identifier string in plan digest

2022-01-14 Thread GitBox
twalthr commented on a change in pull request #18352: URL: https://github.com/apache/flink/pull/18352#discussion_r784649660 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/UserDefinedFunction.java ## @@ -58,9 +60,13 @@ /** Ret

[jira] [Closed] (FLINK-25643) Introduce Predicate to table store

2022-01-14 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-25643. Resolution: Fixed master: 82af5e63f0a6aded5bdeb7e147cc58721f7154aa > Introduce Predicate to table

[GitHub] [flink] twalthr commented on a change in pull request #18352: [FLINK-15585][table] Improve function identifier string in plan digest

2022-01-14 Thread GitBox
twalthr commented on a change in pull request #18352: URL: https://github.com/apache/flink/pull/18352#discussion_r784653224 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/UserDefinedFunctionHelper.java ## @@ -243,6 +244,36 @@ public

[GitHub] [flink] Myasuka commented on a change in pull request #18324: [FLINK-25557][checkpoint] Introduce incremental/full checkpoint size stats

2022-01-14 Thread GitBox
Myasuka commented on a change in pull request #18324: URL: https://github.com/apache/flink/pull/18324#discussion_r784653673 ## File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java ## @@ -368

[GitHub] [flink] twalthr commented on pull request #18352: [FLINK-15585][table] Improve function identifier string in plan digest

2022-01-14 Thread GitBox
twalthr commented on pull request #18352: URL: https://github.com/apache/flink/pull/18352#issuecomment-1012916947 @slinkydeveloper I addressed the test feedback. Please have another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink] Myasuka commented on a change in pull request #18324: [FLINK-25557][checkpoint] Introduce incremental/full checkpoint size stats

2022-01-14 Thread GitBox
Myasuka commented on a change in pull request #18324: URL: https://github.com/apache/flink/pull/18324#discussion_r784655215 ## File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java ## @@ -368

[jira] [Updated] (FLINK-23933) flink-json formats support a option to parse nested json as a String

2022-01-14 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-23933: - Parent: FLINK-25647 Issue Type: Sub-task (was: Improvement) > flink-json formats suppor

[jira] [Updated] (FLINK-18590) Support json array explode to multi messages

2022-01-14 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-18590: - Parent: FLINK-25647 Issue Type: Sub-task (was: Improvement) > Support json array explod

[GitHub] [flink] Myasuka commented on a change in pull request #18324: [FLINK-25557][checkpoint] Introduce incremental/full checkpoint size stats

2022-01-14 Thread GitBox
Myasuka commented on a change in pull request #18324: URL: https://github.com/apache/flink/pull/18324#discussion_r784658077 ## File path: flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/detail/job-checkpoints-detail.component.html ## @@ -45,12 +45,13 @@ >

[GitHub] [flink] Myasuka commented on a change in pull request #18324: [FLINK-25557][checkpoint] Introduce incremental/full checkpoint size stats

2022-01-14 Thread GitBox
Myasuka commented on a change in pull request #18324: URL: https://github.com/apache/flink/pull/18324#discussion_r784658411 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/SubtaskStateStats.java ## @@ -85,6 +88,7 @@ this.subtaskIndex = su

[GitHub] [flink] Myasuka commented on a change in pull request #18324: [FLINK-25557][checkpoint] Introduce incremental/full checkpoint size stats

2022-01-14 Thread GitBox
Myasuka commented on a change in pull request #18324: URL: https://github.com/apache/flink/pull/18324#discussion_r784658633 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/IncrementalKeyedStateHandle.java ## @@ -38,5 +38,5 @@ * created. */

[GitHub] [flink] twalthr commented on a change in pull request #18176: [FLINK-20286][connector-files] Support directory watching in filesystem table source

2022-01-14 Thread GitBox
twalthr commented on a change in pull request #18176: URL: https://github.com/apache/flink/pull/18176#discussion_r784660922 ## File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/connector/file/table/FileSystemTableSinkStreamingITCase.java ## @@ -0,0 +1,9

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18352: [FLINK-15585][table] Improve function identifier string in plan digest

2022-01-14 Thread GitBox
slinkydeveloper commented on a change in pull request #18352: URL: https://github.com/apache/flink/pull/18352#discussion_r784660032 ## File path: docs/content/docs/dev/table/functions/udfs.md ## @@ -240,7 +240,9 @@ An implementation class must extend from one of the available

[GitHub] [flink] twalthr commented on a change in pull request #18290: [FLINK-25391][connectors][formats] Update existing table factories/format factories for catalog table options forwarding

2022-01-14 Thread GitBox
twalthr commented on a change in pull request #18290: URL: https://github.com/apache/flink/pull/18290#discussion_r784663143 ## File path: docs/content/docs/connectors/table/elasticsearch.md ## @@ -67,15 +67,17 @@ Connector Options Option Required +

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18176: [FLINK-20286][connector-files] Support directory watching in filesystem table source

2022-01-14 Thread GitBox
slinkydeveloper commented on a change in pull request #18176: URL: https://github.com/apache/flink/pull/18176#discussion_r784664043 ## File path: flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/FileSystemTableSource.java ## @@ -272,7

[GitHub] [flink] tillrohrmann commented on a change in pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-14 Thread GitBox
tillrohrmann commented on a change in pull request #18169: URL: https://github.com/apache/flink/pull/18169#discussion_r784661497 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManagerDriver.java ## @@ -684,6 +694,7 @@ public void onGetContainerStatusE

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18176: [FLINK-20286][connector-files] Support directory watching in filesystem table source

2022-01-14 Thread GitBox
slinkydeveloper commented on a change in pull request #18176: URL: https://github.com/apache/flink/pull/18176#discussion_r784664915 ## File path: flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/FileSystemTableSource.java ## @@ -272,7

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18176: [FLINK-20286][connector-files] Support directory watching in filesystem table source

2022-01-14 Thread GitBox
slinkydeveloper commented on a change in pull request #18176: URL: https://github.com/apache/flink/pull/18176#discussion_r784665455 ## File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/connector/file/table/FileSystemTableSinkStreamingITCase.java ## @@ -

[GitHub] [flink] twalthr commented on a change in pull request #18290: [FLINK-25391][connectors][formats] Update existing table factories/format factories for catalog table options forwarding

2022-01-14 Thread GitBox
twalthr commented on a change in pull request #18290: URL: https://github.com/apache/flink/pull/18290#discussion_r784666001 ## File path: docs/content/docs/connectors/table/filesystem.md ## @@ -325,33 +347,43 @@ Time extractors define extracting time from partition values.

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18290: [FLINK-25391][connectors][formats] Update existing table factories/format factories for catalog table options forwarding

2022-01-14 Thread GitBox
slinkydeveloper commented on a change in pull request #18290: URL: https://github.com/apache/flink/pull/18290#discussion_r784666452 ## File path: docs/content/docs/connectors/table/elasticsearch.md ## @@ -67,15 +67,17 @@ Connector Options Option Requir

[GitHub] [flink] dawidwys commented on a change in pull request #18332: [FLINK-25427] Fix SavepointITCase.testTriggerSavepointAndResumeWithNo…

2022-01-14 Thread GitBox
dawidwys commented on a change in pull request #18332: URL: https://github.com/apache/flink/pull/18332#discussion_r784667192 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java ## @@ -1175,6 +1185,31 @@ private void terminateMiniClus

[GitHub] [flink] Myasuka commented on pull request #18324: [FLINK-25557][checkpoint] Introduce incremental/full checkpoint size stats

2022-01-14 Thread GitBox
Myasuka commented on pull request #18324: URL: https://github.com/apache/flink/pull/18324#issuecomment-1012931948 @rkhachatryan , what do you mean "How does this work after up-scaling? Will state size be reported e.g. twice"? Checkpoint state size would only report during taking checkpoint

[jira] [Assigned] (FLINK-24886) flink flame args bug, may we need to modify TimeUtils to supports m

2022-01-14 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-24886: - Assignee: jackylau > flink flame args bug, may we need to modify TimeUtils to supports

[jira] [Commented] (FLINK-21896) GroupAggregateJsonPlanTest.testDistinctAggCalls fail

2022-01-14 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476034#comment-17476034 ] Timo Walther commented on FLINK-21896: -- [~soumyajitsahu] We currently don't support

[jira] [Comment Edited] (FLINK-21896) GroupAggregateJsonPlanTest.testDistinctAggCalls fail

2022-01-14 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476034#comment-17476034 ] Timo Walther edited comment on FLINK-21896 at 1/14/22, 9:03 AM: --

[GitHub] [flink] tillrohrmann closed pull request #17777: [FLINK-24886][core] TimeUtils supports the form of m.

2022-01-14 Thread GitBox
tillrohrmann closed pull request #1: URL: https://github.com/apache/flink/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [flink] mingwayXue commented on pull request #17971: [hotfix][docs] fixed kafka.md sink example error

2022-01-14 Thread GitBox
mingwayXue commented on pull request #17971: URL: https://github.com/apache/flink/pull/17971#issuecomment-101293 ok, i will try again.thks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] mingwayXue closed pull request #17971: [hotfix][docs] fixed kafka.md sink example error

2022-01-14 Thread GitBox
mingwayXue closed pull request #17971: URL: https://github.com/apache/flink/pull/17971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu

[jira] [Closed] (FLINK-24886) flink flame args bug, may we need to modify TimeUtils to supports m

2022-01-14 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-24886. - Resolution: Fixed Fixed via 4cd0e396514a6efd7a180a3aea106124d919ebf4 > flink flame args bug, ma

[GitHub] [flink] mingwayXue opened a new pull request #18362: [hotfix][Apache Kafka Connector][docs] fixed kafka.md sink example error

2022-01-14 Thread GitBox
mingwayXue opened a new pull request #18362: URL: https://github.com/apache/flink/pull/18362 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[GitHub] [flink] flinkbot commented on pull request #18362: [hotfix][Apache Kafka Connector][docs] Fixed kafka.md sink example error

2022-01-14 Thread GitBox
flinkbot commented on pull request #18362: URL: https://github.com/apache/flink/pull/18362#issuecomment-1012941846 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pr

[GitHub] [flink] dawidwys commented on pull request #18355: [FLINK-25160][docs] Clarified purpose of execution.checkpointing.tole…

2022-01-14 Thread GitBox
dawidwys commented on pull request #18355: URL: https://github.com/apache/flink/pull/18355#issuecomment-1012943170 LGTM from my side. @qinjunjerry do you mind checking if something else should be documented here? -- This is an automated message from the Apache Git Service. To resp

[GitHub] [flink] twalthr commented on a change in pull request #18352: [FLINK-15585][table] Improve function identifier string in plan digest

2022-01-14 Thread GitBox
twalthr commented on a change in pull request #18352: URL: https://github.com/apache/flink/pull/18352#discussion_r784680356 ## File path: docs/content/docs/dev/table/functions/udfs.md ## @@ -240,7 +240,9 @@ An implementation class must extend from one of the available base cla

[jira] [Created] (FLINK-25655) FlinkKafkaInternalProducerITCase.testInitTransactionId failed on azure

2022-01-14 Thread Yun Gao (Jira)
Yun Gao created FLINK-25655: --- Summary: FlinkKafkaInternalProducerITCase.testInitTransactionId failed on azure Key: FLINK-25655 URL: https://issues.apache.org/jira/browse/FLINK-25655 Project: Flink

[jira] [Commented] (FLINK-25655) FlinkKafkaInternalProducerITCase.testInitTransactionId failed on azure

2022-01-14 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476042#comment-17476042 ] Yun Gao commented on FLINK-25655: - Perhaps cc [~fpaul]  > FlinkKafkaInternalProducerITC

[GitHub] [flink] Myasuka commented on a change in pull request #18297: [FLINK-25395][state] Fix TM error handling when uploading shared state

2022-01-14 Thread GitBox
Myasuka commented on a change in pull request #18297: URL: https://github.com/apache/flink/pull/18297#discussion_r784683300 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateHandleStreamImpl.java ## @@ -83,11 +80,7 @@ public Keyed

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18290: [FLINK-25391][connectors][formats] Update existing table factories/format factories for catalog table options forwarding

2022-01-14 Thread GitBox
slinkydeveloper commented on a change in pull request #18290: URL: https://github.com/apache/flink/pull/18290#discussion_r784700282 ## File path: docs/content/docs/connectors/table/filesystem.md ## @@ -325,33 +347,43 @@ Time extractors define extracting time from partition val

[GitHub] [flink] slinkydeveloper commented on pull request #18349: [FLINK-25609][table] Anonymous/inline tables don't require ObjectIdentifier anymore

2022-01-14 Thread GitBox
slinkydeveloper commented on pull request #18349: URL: https://github.com/apache/flink/pull/18349#issuecomment-1012963542 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] fapaul commented on a change in pull request #18257: [FLINK-25504][Kafka] Upgrade Kafka Client to 2.8.1 and Confluent Platform to 6.2.2

2022-01-14 Thread GitBox
fapaul commented on a change in pull request #18257: URL: https://github.com/apache/flink/pull/18257#discussion_r784705632 ## File path: flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/pom.xml ## @@ -143,6 +143,12 @@ under the License. org.apa

[GitHub] [flink] fapaul commented on pull request #18257: [FLINK-25504][Kafka] Upgrade Kafka Client to 2.8.1 and Confluent Platform to 6.2.2

2022-01-14 Thread GitBox
fapaul commented on pull request #18257: URL: https://github.com/apache/flink/pull/18257#issuecomment-1012968641 @MartijnVisser can you also open a ticket to update it for the kinesis e2e tests? -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [flink] fapaul merged pull request #18257: [FLINK-25504][Kafka] Upgrade Kafka Client to 2.8.1 and Confluent Platform to 6.2.2

2022-01-14 Thread GitBox
fapaul merged pull request #18257: URL: https://github.com/apache/flink/pull/18257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [flink] wenlong88 opened a new pull request #18363: [Flink-25600][table-planner] Support new statement set syntax in sql client and update docs

2022-01-14 Thread GitBox
wenlong88 opened a new pull request #18363: URL: https://github.com/apache/flink/pull/18363 ## What is the purpose of the change this pr is a follow up work of FLINK-25392, aims at adding support new statement set syntax in sql client and update related docs. ## Brief change l

[jira] [Commented] (FLINK-25504) Update and synchronise used versions of Kafka Client and Confluent Platform

2022-01-14 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476051#comment-17476051 ] Fabian Paul commented on FLINK-25504: - Merged in master: 28417562dbca16ac018cceaeccb

[jira] [Resolved] (FLINK-25504) Update and synchronise used versions of Kafka Client and Confluent Platform

2022-01-14 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Paul resolved FLINK-25504. - Resolution: Fixed > Update and synchronise used versions of Kafka Client and Confluent Platform

[GitHub] [flink] fapaul commented on pull request #17937: [FLINK-25044][testing][Pulsar Connector] Add More Unit Test For Pulsar Source

2022-01-14 Thread GitBox
fapaul commented on pull request #17937: URL: https://github.com/apache/flink/pull/17937#issuecomment-1012970412 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] flinkbot commented on pull request #18363: [Flink-25600][table-planner] Support new statement set syntax in sql client and update docs

2022-01-14 Thread GitBox
flinkbot commented on pull request #18363: URL: https://github.com/apache/flink/pull/18363#issuecomment-1012971326 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pr

[GitHub] [flink] TanYuxin-tyx opened a new pull request #18364: [FLINK-25654][network] Remove the redundant locks in SortMergeResultPartition

2022-01-14 Thread GitBox
TanYuxin-tyx opened a new pull request #18364: URL: https://github.com/apache/flink/pull/18364 ## What is the purpose of the change After [FLINK-2372](https://issues.apache.org/jira/browse/FLINK-2372), the task canceler will never call the close method of ResultPartit

[GitHub] [flink] MonsterChenzhuo commented on a change in pull request #17994: [FLINK-24456][Connectors / Kafka,Table SQL / Ecosystem] Support bound…

2022-01-14 Thread GitBox
MonsterChenzhuo commented on a change in pull request #17994: URL: https://github.com/apache/flink/pull/17994#discussion_r784710332 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaConnectorOptions.java #

[jira] [Updated] (FLINK-25654) Remove the redundant lock in SortMergeResultPartition

2022-01-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-25654: --- Labels: pull-request-available (was: ) > Remove the redundant lock in SortMergeResultPartit

[GitHub] [flink] MonsterChenzhuo commented on a change in pull request #17994: [FLINK-24456][Connectors / Kafka,Table SQL / Ecosystem] Support bound…

2022-01-14 Thread GitBox
MonsterChenzhuo commented on a change in pull request #17994: URL: https://github.com/apache/flink/pull/17994#discussion_r784711945 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaConnectorOptions.java #

[GitHub] [flink] JingGe commented on pull request #18333: [FLINK-25220][test] Write an architectural rule for all IT cases w.r.t. the MiniCluster

2022-01-14 Thread GitBox
JingGe commented on pull request #18333: URL: https://github.com/apache/flink/pull/18333#issuecomment-1012975101 @codecholeric many thanks for your reply. I would(and also had) suggest the first solution to use test jar in maven without any customized filter logic. @zentol Do you have any

[GitHub] [flink] flinkbot commented on pull request #18364: [FLINK-25654][network] Remove the redundant locks in SortMergeResultPartition

2022-01-14 Thread GitBox
flinkbot commented on pull request #18364: URL: https://github.com/apache/flink/pull/18364#issuecomment-1012976033 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pr

[GitHub] [flink] flinkbot edited a comment on pull request #17711: [FLINK-24737][runtime-web] Update outdated web dependencies

2022-01-14 Thread GitBox
flinkbot edited a comment on pull request #17711: URL: https://github.com/apache/flink/pull/17711#issuecomment-962917757 ## CI report: * b4e978359c87b33f8c5de84f6e0987f712335b19 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17937: [FLINK-25044][testing][Pulsar Connector] Add More Unit Test For Pulsar Source

2022-01-14 Thread GitBox
flinkbot edited a comment on pull request #17937: URL: https://github.com/apache/flink/pull/17937#issuecomment-981287170 ## CI report: * Unknown: [CANCELED](TBD) * 5bffc54d9cfaa9245563f623b76b98cf35e1ff81 UNKNOWN Bot commands The @flinkbot bot supports the fol

[GitHub] [flink] flinkbot edited a comment on pull request #18050: [FLINK-25034][runtime] Support flexible number of subpartitions in IntermediateResultPartition

2022-01-14 Thread GitBox
flinkbot edited a comment on pull request #18050: URL: https://github.com/apache/flink/pull/18050#issuecomment-988466514 ## CI report: * ad7f9baa5052478388323f894dcbcf22fabd2a2b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #18176: [FLINK-20286][connector-files] Support directory watching in filesystem table source

2022-01-14 Thread GitBox
flinkbot edited a comment on pull request #18176: URL: https://github.com/apache/flink/pull/18176#issuecomment-999490583 ## CI report: * a8c8f216f8d9f5ff1e0d7e34f583840dcefc6263 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #18261: [hotfix][javadocs] Fix the doc content in the createFieldGetter method of RowData

2022-01-14 Thread GitBox
flinkbot edited a comment on pull request #18261: URL: https://github.com/apache/flink/pull/18261#issuecomment-1004646772 ## CI report: * 34a1f33bd217d3c2e99b06a64c9ccbd1ab2d6e45 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] flinkbot edited a comment on pull request #18189: [FLINK-25430] Replace RunningJobRegistry by JobResultStore

2022-01-14 Thread GitBox
flinkbot edited a comment on pull request #18189: URL: https://github.com/apache/flink/pull/18189#issuecomment-1000280224 ## CI report: * 870e758087dab73a66bd5e5a09fc736478094d3b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Fix TM error handling when uploading shared state

2022-01-14 Thread GitBox
flinkbot edited a comment on pull request #18297: URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142 ## CI report: * eeb8c798bc364480d8e2b5ecf8b55c54397cef14 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] flinkbot edited a comment on pull request #18201: [FLINK-25167][API / DataStream]Expose StreamOperatorFactory in Connec…

2022-01-14 Thread GitBox
flinkbot edited a comment on pull request #18201: URL: https://github.com/apache/flink/pull/18201#issuecomment-1000767373 ## CI report: * 0c1bfde3e87dd0c60c90df35d592da0f884ee996 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] flinkbot edited a comment on pull request #18290: [FLINK-25391][connectors][formats] Update existing table factories/format factories for catalog table options forwarding

2022-01-14 Thread GitBox
flinkbot edited a comment on pull request #18290: URL: https://github.com/apache/flink/pull/18290#issuecomment-1006716199 ## CI report: * 0d8e419c43838e6d85155feadee7e096e3990e0d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] flinkbot edited a comment on pull request #18349: [FLINK-25609][table] Anonymous/inline tables don't require ObjectIdentifier anymore

2022-01-14 Thread GitBox
flinkbot edited a comment on pull request #18349: URL: https://github.com/apache/flink/pull/18349#issuecomment-1011991081 ## CI report: * Unknown: [CANCELED](TBD) * 47668982c9897b1f8d8d7ffa8b10ac8a134f088c UNKNOWN Bot commands The @flinkbot bot supports the fo

[jira] [Commented] (FLINK-25655) FlinkKafkaInternalProducerITCase.testInitTransactionId failed on azure

2022-01-14 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476055#comment-17476055 ] Fabian Paul commented on FLINK-25655: - I'll take a look. > FlinkKafkaInternalProduc

[GitHub] [flink] flinkbot commented on pull request #18352: [FLINK-15585][table] Improve function identifier string in plan digest

2022-01-14 Thread GitBox
flinkbot commented on pull request #18352: URL: https://github.com/apache/flink/pull/18352#issuecomment-1012981301 ## CI report: * aab8d5779881c1c1575c9c15e263e28fce50a215 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #18353: [FLINK-25129][docs]project configuation changes in docs

2022-01-14 Thread GitBox
flinkbot commented on pull request #18353: URL: https://github.com/apache/flink/pull/18353#issuecomment-1012981377 ## CI report: * 988fcbec1b60588c4c0cb2249a94f258145f7040 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #18355: [FLINK-25160][docs] Clarified purpose of execution.checkpointing.tole…

2022-01-14 Thread GitBox
flinkbot commented on pull request #18355: URL: https://github.com/apache/flink/pull/18355#issuecomment-1012981476 ## CI report: * 6b89b5c2cb9734084a479e7dfcea82a3218dd3ff UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #18358: [FLINK-25651][docs] Update kafka.md

2022-01-14 Thread GitBox
flinkbot commented on pull request #18358: URL: https://github.com/apache/flink/pull/18358#issuecomment-1012981567 ## CI report: * f081bab4fe89823da05cbad2f0be0ebae668e310 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #18360: [FLINK-25329][runtime] Support memory execution graph store in session cluster

2022-01-14 Thread GitBox
flinkbot commented on pull request #18360: URL: https://github.com/apache/flink/pull/18360#issuecomment-1012981724 ## CI report: * d7927cf9b7e4205d59e788be867174141d7cd901 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #18359: [FLINK-25484][connectors/filesystem] Support inactivityInterval config in table api

2022-01-14 Thread GitBox
flinkbot commented on pull request #18359: URL: https://github.com/apache/flink/pull/18359#issuecomment-1012981632 ## CI report: * 111d05bc4d409c357223c238e67bcb34880a1951 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[jira] [Updated] (FLINK-25651) Flink1.14.2 DataStream Connectors Kafka Deserializer example method uses the wrong parameter

2022-01-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-25651: --- Labels: pull-request-available (was: ) > Flink1.14.2 DataStream Connectors Kafka Deserializ

[GitHub] [flink] MonsterChenzhuo commented on a change in pull request #17994: [FLINK-24456][Connectors / Kafka,Table SQL / Ecosystem] Support bound…

2022-01-14 Thread GitBox
MonsterChenzhuo commented on a change in pull request #17994: URL: https://github.com/apache/flink/pull/17994#discussion_r784717516 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaConnectorOptions.java #

[GitHub] [flink] flinkbot edited a comment on pull request #17937: [FLINK-25044][testing][Pulsar Connector] Add More Unit Test For Pulsar Source

2022-01-14 Thread GitBox
flinkbot edited a comment on pull request #17937: URL: https://github.com/apache/flink/pull/17937#issuecomment-981287170 ## CI report: * Unknown: [CANCELED](TBD) * 5bffc54d9cfaa9245563f623b76b98cf35e1ff81 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620

[GitHub] [flink] dmvk commented on a change in pull request #18332: [FLINK-25427] Fix SavepointITCase.testTriggerSavepointAndResumeWithNo…

2022-01-14 Thread GitBox
dmvk commented on a change in pull request #18332: URL: https://github.com/apache/flink/pull/18332#discussion_r784718698 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java ## @@ -1175,6 +1185,31 @@ private void terminateMiniClusterS

[GitHub] [flink] flinkbot edited a comment on pull request #17711: [FLINK-24737][runtime-web] Update outdated web dependencies

2022-01-14 Thread GitBox
flinkbot edited a comment on pull request #17711: URL: https://github.com/apache/flink/pull/17711#issuecomment-962917757 ## CI report: * b4e978359c87b33f8c5de84f6e0987f712335b19 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #18050: [FLINK-25034][runtime] Support flexible number of subpartitions in IntermediateResultPartition

2022-01-14 Thread GitBox
flinkbot edited a comment on pull request #18050: URL: https://github.com/apache/flink/pull/18050#issuecomment-988466514 ## CI report: * ad7f9baa5052478388323f894dcbcf22fabd2a2b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #18176: [FLINK-20286][connector-files] Support directory watching in filesystem table source

2022-01-14 Thread GitBox
flinkbot edited a comment on pull request #18176: URL: https://github.com/apache/flink/pull/18176#issuecomment-999490583 ## CI report: * a8c8f216f8d9f5ff1e0d7e34f583840dcefc6263 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #18189: [FLINK-25430] Replace RunningJobRegistry by JobResultStore

2022-01-14 Thread GitBox
flinkbot edited a comment on pull request #18189: URL: https://github.com/apache/flink/pull/18189#issuecomment-1000280224 ## CI report: * 870e758087dab73a66bd5e5a09fc736478094d3b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

  1   2   3   4   5   >