[GitHub] [flink] flinkbot edited a comment on pull request #18479: [FLINK-25387] Introduce ExecNodeMetadata

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18479: URL: https://github.com/apache/flink/pull/18479#issuecomment-1020172062 ## CI report: * 26c2d84f06d6605f38a20311466137b07152dac5 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18479: [FLINK-25387] Introduce ExecNodeMetadata

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18479: URL: https://github.com/apache/flink/pull/18479#issuecomment-1020172062 ## CI report: * 26c2d84f06d6605f38a20311466137b07152dac5 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18479: [FLINK-25387] Introduce ExecNodeMetadata

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18479: URL: https://github.com/apache/flink/pull/18479#issuecomment-1020172062 ## CI report: * 26c2d84f06d6605f38a20311466137b07152dac5 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18428: [FLINK-25575] Add Sink V2 operators and translation

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18428: URL: https://github.com/apache/flink/pull/18428#issuecomment-1017677769 ## CI report: * b9b29ad0b3697de70c570ee08d4ccf45f1c3e0bf Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18512: [FLINK-25811][hotfix][connector/base] changing failed requests handler to accept List in AsyncSinkWriter

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18512: URL: https://github.com/apache/flink/pull/18512#issuecomment-1021344642 ## CI report: * 18179cd7b5c28433ae7502e9ab2b0b12ff1665ad Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18479: [FLINK-25387] Introduce ExecNodeMetadata

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18479: URL: https://github.com/apache/flink/pull/18479#issuecomment-1020172062 ## CI report: * 26c2d84f06d6605f38a20311466137b07152dac5 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18376: [FLINK-25668][runtime] Support calcuate network memory for dynamic graph

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18376: URL: https://github.com/apache/flink/pull/18376#issuecomment-1014266348 ## CI report: * 87627f9924e44eb40028822fc427363ea6d845a1 Azure:

[jira] [Updated] (FLINK-25811) Fix generic AsyncSinkWriter retrying requests in reverse order

2022-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-25811: --- Labels: pull-request-available (was: ) > Fix generic AsyncSinkWriter retrying requests in

[GitHub] [flink] matriv edited a comment on pull request #18479: [FLINK-25387] Introduce ExecNodeMetadata

2022-01-25 Thread GitBox
matriv edited a comment on pull request #18479: URL: https://github.com/apache/flink/pull/18479#issuecomment-1021436854 > I have one specific comment about the `context` field. Why have you opted for mixing together in the serialization the instance identifier and the type identifier

[GitHub] [flink] flinkbot edited a comment on pull request #18512: [FLINK-25811][hotfix][connector/base] changing failed requests handler to accept List in AsyncSinkWriter

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18512: URL: https://github.com/apache/flink/pull/18512#issuecomment-1021344642 ## CI report: * 18179cd7b5c28433ae7502e9ab2b0b12ff1665ad Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18479: [FLINK-25387] Introduce ExecNodeMetadata

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18479: URL: https://github.com/apache/flink/pull/18479#issuecomment-1020172062 ## CI report: * 26c2d84f06d6605f38a20311466137b07152dac5 Azure:

[GitHub] [flink] matriv commented on pull request #18479: [FLINK-25387] Introduce ExecNodeMetadata

2022-01-25 Thread GitBox
matriv commented on pull request #18479: URL: https://github.com/apache/flink/pull/18479#issuecomment-1021436854 > I have one specific comment about the `context` field. Why have you opted for mixing together in the serialization the instance identifier and the type identifier (composed

[GitHub] [flink] flinkbot edited a comment on pull request #18476: [FLINK-25726][streaming] Add Global Committer as post commit topology

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18476: URL: https://github.com/apache/flink/pull/18476#issuecomment-1020132926 ## CI report: * ff95aa4c4b60ccec3a55723df0b42eb8890a6cc6 Azure:

[GitHub] [flink] matriv commented on a change in pull request #18479: [FLINK-25387] Introduce ExecNodeMetadata

2022-01-25 Thread GitBox
matriv commented on a change in pull request #18479: URL: https://github.com/apache/flink/pull/18479#discussion_r791955587 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/JsonSerdeUtil.java ## @@ -21,8 +21,7 @@

[jira] [Updated] (FLINK-25811) Fix generic AsyncSinkWriter retrying requests in reverse order

2022-01-25 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Hamdy updated FLINK-25811: Description: h2. Motivation {{AsyncSinkWriter}} retries failed request in reverse order.

[GitHub] [flink] wpc009 commented on pull request #18475: [FLINK-25728] Protential memory leaks in StreamMultipleInputProcessor

2022-01-25 Thread GitBox
wpc009 commented on pull request #18475: URL: https://github.com/apache/flink/pull/18475#issuecomment-1021431119 > I'm afraid that those "time outs" might be because of some bug in this code causing a deadlock. I've also tried [to run a benchmark

[GitHub] [flink] flinkbot edited a comment on pull request #18479: [FLINK-25387] Introduce ExecNodeMetadata

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18479: URL: https://github.com/apache/flink/pull/18479#issuecomment-1020172062 ## CI report: * 26c2d84f06d6605f38a20311466137b07152dac5 Azure:

[jira] [Created] (FLINK-25811) Fix generic AsyncSinkWriter retrying requests in reverse order

2022-01-25 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-25811: --- Summary: Fix generic AsyncSinkWriter retrying requests in reverse order Key: FLINK-25811 URL: https://issues.apache.org/jira/browse/FLINK-25811 Project: Flink

[GitHub] [flink] matriv commented on a change in pull request #18479: [FLINK-25387] Introduce ExecNodeMetadata

2022-01-25 Thread GitBox
matriv commented on a change in pull request #18479: URL: https://github.com/apache/flink/pull/18479#discussion_r791952809 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeTypeIdResolver.java ## @@ -0,0 +1,65

[GitHub] [flink] matriv commented on a change in pull request #18479: [FLINK-25387] Introduce ExecNodeMetadata

2022-01-25 Thread GitBox
matriv commented on a change in pull request #18479: URL: https://github.com/apache/flink/pull/18479#discussion_r791950985 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeContext.java ## @@ -0,0 +1,94 @@ +/* +

[GitHub] [flink] wpc009 commented on a change in pull request #18475: [FLINK-25728] Protential memory leaks in StreamMultipleInputProcessor

2022-01-25 Thread GitBox
wpc009 commented on a change in pull request #18475: URL: https://github.com/apache/flink/pull/18475#discussion_r791934091 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/MultipleInputStreamTaskTest.java ## @@ -101,10 +101,15 @@

[GitHub] [flink] matriv commented on a change in pull request #18479: [FLINK-25387] Introduce ExecNodeMetadata

2022-01-25 Thread GitBox
matriv commented on a change in pull request #18479: URL: https://github.com/apache/flink/pull/18479#discussion_r791949325 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeMetadata.java ## @@ -0,0 +1,131 @@ +/*

[GitHub] [flink] wpc009 commented on a change in pull request #18475: [FLINK-25728] Protential memory leaks in StreamMultipleInputProcessor

2022-01-25 Thread GitBox
wpc009 commented on a change in pull request #18475: URL: https://github.com/apache/flink/pull/18475#discussion_r791934091 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/MultipleInputStreamTaskTest.java ## @@ -101,10 +101,15 @@

[GitHub] [flink] XComp edited a comment on pull request #17819: [FLINK-15816][k8s] Prevent labels using kubernetes.cluster-id to exceed the limit of 63 characters

2022-01-25 Thread GitBox
XComp edited a comment on pull request #17819: URL: https://github.com/apache/flink/pull/17819#issuecomment-1020406101 Ok, then I misinterpreted the ticket. Essentially, the issue is not that we have to guess the right value for this configuration parameter but that the validation never

[GitHub] [flink] wpc009 commented on a change in pull request #18475: [FLINK-25728] Protential memory leaks in StreamMultipleInputProcessor

2022-01-25 Thread GitBox
wpc009 commented on a change in pull request #18475: URL: https://github.com/apache/flink/pull/18475#discussion_r791934091 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/MultipleInputStreamTaskTest.java ## @@ -101,10 +101,15 @@

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18479: [FLINK-25387] Introduce ExecNodeMetadata

2022-01-25 Thread GitBox
slinkydeveloper commented on a change in pull request #18479: URL: https://github.com/apache/flink/pull/18479#discussion_r791883246 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/JsonSerdeUtil.java ## @@ -21,8

[GitHub] [flink] zentol merged pull request #17498: [FLINK-14954][rest] Add OpenAPI spec generator

2022-01-25 Thread GitBox
zentol merged pull request #17498: URL: https://github.com/apache/flink/pull/17498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] zuston commented on pull request #18157: [FLINK-17808] Rename checkpoint meta file to "_metadata" until it has…

2022-01-25 Thread GitBox
zuston commented on pull request #18157: URL: https://github.com/apache/flink/pull/18157#issuecomment-1020775523 Thanks @gaoyunhaii and @Myasuka again :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] syhily commented on a change in pull request #17452: [FLINK-20732][connector/pulsar] Introduction of Pulsar Sink

2022-01-25 Thread GitBox
syhily commented on a change in pull request #17452: URL: https://github.com/apache/flink/pull/17452#discussion_r791011231 ## File path: flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/sink/config/PulsarSinkConfigUtils.java ## @@ -0,0

[GitHub] [flink] flinkbot edited a comment on pull request #18498: [FLINK-25801][ metrics]add cpu processor metric of taskmanager

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18498: URL: https://github.com/apache/flink/pull/18498#issuecomment-1020905745 ## CI report: * e6d959da396523b05fdc25889fd2f1859857c70e Azure:

[GitHub] [flink] twalthr closed pull request #18290: [FLINK-25391][connectors][formats] Update existing table factories/format factories for catalog table options forwarding

2022-01-25 Thread GitBox
twalthr closed pull request #18290: URL: https://github.com/apache/flink/pull/18290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #18506: [FLINK-25805][table-planner] Use the DataType compact representation by default when using default conversion classes

2022-01-25 Thread GitBox
flinkbot commented on pull request #18506: URL: https://github.com/apache/flink/pull/18506#issuecomment-1021190808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] fapaul commented on pull request #18469: [FLINK-25485][connector/jdbc] Append default JDBC URL option of batch writing in MySQL.

2022-01-25 Thread GitBox
fapaul commented on pull request #18469: URL: https://github.com/apache/flink/pull/18469#issuecomment-1020900986 @leonardBang can you take a look at this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] galenwarren commented on pull request #18489: [FLINK-25790][flink-gs-fs-hadoop] Support authentication via core-site.xml in GCS FileSystem plugin

2022-01-25 Thread GitBox
galenwarren commented on pull request #18489: URL: https://github.com/apache/flink/pull/18489#issuecomment-1020764001 Please let me know if there's anything else you would suggest I change in terms of the implementation, besides what you've already suggested, and then I'll look at unit

[GitHub] [flink] flinkbot edited a comment on pull request #18427: [FLINK-25386][table] Harden table persisted plan

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18427: URL: https://github.com/apache/flink/pull/18427#issuecomment-1017644617 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] flinkbot edited a comment on pull request #18465: [FLINK-24978][build] Upgrade ASM to 9.2

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18465: URL: https://github.com/apache/flink/pull/18465#issuecomment-1019940899 ## CI report: * e065b40facb2f2dfbf0477b16145aef1e646c916 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18324: [FLINK-25557][checkpoint] Introduce incremental/full checkpoint size stats

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18324: URL: https://github.com/apache/flink/pull/18324#issuecomment-1009752905 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] dannycranmer commented on a change in pull request #18483: [FLINK-24041][connectors] Removed public setter for elementConverter in As…

2022-01-25 Thread GitBox
dannycranmer commented on a change in pull request #18483: URL: https://github.com/apache/flink/pull/18483#discussion_r790986281 ## File path:

[GitHub] [flink] RocMarshal commented on pull request #18472: [FLINK-25783][docs-zh] Translate azure_table_storage.md page into Chinese.

2022-01-25 Thread GitBox
RocMarshal commented on pull request #18472: URL: https://github.com/apache/flink/pull/18472#issuecomment-1021265214 @klion26 Hi, would you mind checking it if you have free time? thx. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink-statefun] igalshilman closed pull request #284: [FLINK-25775] Add Javascript SDK documentation

2022-01-25 Thread GitBox
igalshilman closed pull request #284: URL: https://github.com/apache/flink-statefun/pull/284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot edited a comment on pull request #18475: [FLINK-25728] Protential memory leaks in StreamMultipleInputProcessor

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18475: URL: https://github.com/apache/flink/pull/18475#issuecomment-1020104543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] SteNicholas commented on a change in pull request #18502: [hotfix][docs][kafka] Add explanation how Kafka Source deals with idl…

2022-01-25 Thread GitBox
SteNicholas commented on a change in pull request #18502: URL: https://github.com/apache/flink/pull/18502#discussion_r791593327 ## File path: docs/content.zh/docs/connectors/datastream/kafka.md ## @@ -176,6 +176,15 @@ env.fromSource(kafkaSource, new CustomWatermarkStrategy(),

[GitHub] [flink] flinkbot edited a comment on pull request #18460: [FLINK-25767][doc] Totally translated state.md into Chinese

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18460: URL: https://github.com/apache/flink/pull/18460#issuecomment-1019844798 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] flinkbot commented on pull request #18503: [FLINK-25331][tests] FlinkImageBuilder checks for Java 17

2022-01-25 Thread GitBox
flinkbot commented on pull request #18503: URL: https://github.com/apache/flink/pull/18503#issuecomment-1021046948 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] tillrohrmann commented on pull request #17485: [FLINK-24038] Add support for single leader election per JobManager process

2022-01-25 Thread GitBox
tillrohrmann commented on pull request #17485: URL: https://github.com/apache/flink/pull/17485#issuecomment-1021223748 Thanks for the review @XComp. I've resolved most of your comments. Those that I haven't resolved, I added an explanation for why not. Please take another look at this PR

[GitHub] [flink] dannycranmer merged pull request #18488: [FLINK-24041][connector] Fixing reversed insertion of failed requests

2022-01-25 Thread GitBox
dannycranmer merged pull request #18488: URL: https://github.com/apache/flink/pull/18488 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] rkhachatryan merged pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete

2022-01-25 Thread GitBox
rkhachatryan merged pull request #18382: URL: https://github.com/apache/flink/pull/18382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] dmvk commented on pull request #18303: [FLINK-25085][runtime] Add a scheduled thread pool for periodic tasks in RpcEndpoint

2022-01-25 Thread GitBox
dmvk commented on pull request #18303: URL: https://github.com/apache/flink/pull/18303#issuecomment-1020976719 Hi @zjureel, thanks for the PR. One question on the approach, why do we need to create a new implementation of the `ScheduledExecutor` instead of reusing the

[GitHub] [flink] flinkbot commented on pull request #18488: [FLINK-24041][connector] Fixing reversed insertion of failed requests

2022-01-25 Thread GitBox
flinkbot commented on pull request #18488: URL: https://github.com/apache/flink/pull/18488#issuecomment-1020394995 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] TanYuxin-tyx commented on a change in pull request #18474: [FLINK-25786][network] Adjust the generation of subpartition data storage order for sort-shuffle from random shuffle to rand

2022-01-25 Thread GitBox
TanYuxin-tyx commented on a change in pull request #18474: URL: https://github.com/apache/flink/pull/18474#discussion_r791322643 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SortMergeResultPartition.java ## @@ -492,10 +490,13 @@

[GitHub] [flink] curcur commented on a change in pull request #18431: [FLINK-25024][docs] Add Changelog backend docs

2022-01-25 Thread GitBox
curcur commented on a change in pull request #18431: URL: https://github.com/apache/flink/pull/18431#discussion_r791311410 ## File path: docs/content/docs/ops/state/state_backends.md ## @@ -325,6 +325,126 @@ public class MyOptionsFactory implements

[GitHub] [flink] flinkbot edited a comment on pull request #18359: [FLINK-25484][connectors/filesystem] Support inactivityInterval config in table api

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18359: URL: https://github.com/apache/flink/pull/18359#issuecomment-1012981632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] fapaul commented on pull request #18468: [FLINK-24905][connector/kinesis]Adding Kinesis data streams sql uber-jar and end to end test.

2022-01-25 Thread GitBox
fapaul commented on pull request #18468: URL: https://github.com/apache/flink/pull/18468#issuecomment-1021312806 Sorry for sounding a bit harsh but please open separate tickets for the different concerns. This is already the third PR belonging to

[GitHub] [flink] flinkbot edited a comment on pull request #18478: [FLINK-25787][flink-connector-gcp-pubsub] Adding endpoint support in Pubsub Source / Sink

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18478: URL: https://github.com/apache/flink/pull/18478#issuecomment-1020156897 ## CI report: * 7d269e64204469eb03c1b102f44a5930ceb45d62 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18500: [FLINK-25312][hive] HiveCatalog supports Flink's managed table

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18500: URL: https://github.com/apache/flink/pull/18500#issuecomment-1021030168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] flinkbot edited a comment on pull request #18494: [FLINK-25307][DEBUG-ONLY] Add debug message

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18494: URL: https://github.com/apache/flink/pull/18494#issuecomment-1020833870 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] MartijnVisser commented on a change in pull request #18502: [hotfix][docs][kafka] Add explanation how Kafka Source deals with idl…

2022-01-25 Thread GitBox
MartijnVisser commented on a change in pull request #18502: URL: https://github.com/apache/flink/pull/18502#discussion_r791699368 ## File path: docs/content.zh/docs/connectors/datastream/kafka.md ## @@ -176,6 +176,15 @@ env.fromSource(kafkaSource, new

[GitHub] [flink] flinkbot edited a comment on pull request #18489: [FLINK-25790][flink-gs-fs-hadoop] Support authentication via core-site.xml in GCS FileSystem plugin

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18489: URL: https://github.com/apache/flink/pull/18489#issuecomment-1020643947 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] godfreyhe closed pull request #18017: [FLINK-25171] Validation of duplicate fields in ddl sql

2022-01-25 Thread GitBox
godfreyhe closed pull request #18017: URL: https://github.com/apache/flink/pull/18017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] paul8263 commented on pull request #18460: [FLINK-25767][doc] Totally translated state.md into Chinese

2022-01-25 Thread GitBox
paul8263 commented on pull request #18460: URL: https://github.com/apache/flink/pull/18460#issuecomment-1020748254 Hi @Myasuka , Thank you for valuable suggestion. I've corrected some translations and please perform an another review. -- This is an automated message from the Apache

[GitHub] [flink] flinkbot edited a comment on pull request #18479: [FLINK-25387] Introduce ExecNodeMetadata

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18479: URL: https://github.com/apache/flink/pull/18479#issuecomment-1020172062 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] wangyang0918 merged pull request #18119: [FLINK-24947] Support hostNetwork for native K8s integration on session mode

2022-01-25 Thread GitBox
wangyang0918 merged pull request #18119: URL: https://github.com/apache/flink/pull/18119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #18510: [FLINK-18356][tests] Disable fork-reuse for table-planner

2022-01-25 Thread GitBox
flinkbot commented on pull request #18510: URL: https://github.com/apache/flink/pull/18510#issuecomment-1021336953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] tillrohrmann commented on pull request #18484: [FLINK-25758] Fix license issue with flink-gs-fs-hadoop

2022-01-25 Thread GitBox
tillrohrmann commented on pull request #18484: URL: https://github.com/apache/flink/pull/18484#issuecomment-1020379787 Subsumed by original PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] flinkbot edited a comment on pull request #18468: [FLINK-24905][connector/kinesis]Adding Kinesis data streams sql uber-jar and end to end test.

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18468: URL: https://github.com/apache/flink/pull/18468#issuecomment-1019969068 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] flinkbot edited a comment on pull request #18466: [FLINK-25016][build] Upgrade to Netty 4.1.70

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18466: URL: https://github.com/apache/flink/pull/18466#issuecomment-1019948477 ## CI report: * fb9cbe4ac95ec5291023532499aa478fedc10199 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18486: [Test Only] Checks the memory usage for flink-table/flink-table-planner ci pipeline

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18486: URL: https://github.com/apache/flink/pull/18486#issuecomment-1020338268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] XComp commented on a change in pull request #18189: [FLINK-25430] Replace RunningJobRegistry by JobResultStore

2022-01-25 Thread GitBox
XComp commented on a change in pull request #18189: URL: https://github.com/apache/flink/pull/18189#discussion_r791720372 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/JobDispatcherFactory.java ## @@ -38,13 +40,21 @@ public MiniDispatcher

[GitHub] [flink] flinkbot edited a comment on pull request #18043: [FLINK-25206] Add configuration option to disable configuration in user programs

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18043: URL: https://github.com/apache/flink/pull/18043#issuecomment-987929568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] im-pratham commented on pull request #18495: [hotfix] [docs] Updated doc with flink image name and tag

2022-01-25 Thread GitBox
im-pratham commented on pull request #18495: URL: https://github.com/apache/flink/pull/18495#issuecomment-1020879786 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] twalthr closed pull request #18464: [FLINK-25769][table] Add internal functions and basic function versioning

2022-01-25 Thread GitBox
twalthr closed pull request #18464: URL: https://github.com/apache/flink/pull/18464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] pnowojski commented on pull request #18392: [FLINK-25590][metrics] Introduce RequestedMemoryUsage and log warnings if usage exceeds 100%

2022-01-25 Thread GitBox
pnowojski commented on pull request #18392: URL: https://github.com/apache/flink/pull/18392#issuecomment-1021187597 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18464: [FLINK-25769][table] Add internal functions and basic function versioning

2022-01-25 Thread GitBox
slinkydeveloper commented on a change in pull request #18464: URL: https://github.com/apache/flink/pull/18464#discussion_r791698085 ## File path: flink-table/flink-table-common/src/test/java/org/apache/flink/table/module/CoreModuleTest.java ## @@ -18,14 +18,56 @@ package

[GitHub] [flink] JingsongLi closed pull request #18394: [FLINK-25520][Table SQL/API] Implement "ALTER TABLE ... COMPACT" SQL

2022-01-25 Thread GitBox
JingsongLi closed pull request #18394: URL: https://github.com/apache/flink/pull/18394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] xintongsong commented on a change in pull request #18430: [FLINK-25577][docs] Update GCS documentation

2022-01-25 Thread GitBox
xintongsong commented on a change in pull request #18430: URL: https://github.com/apache/flink/pull/18430#discussion_r791330799 ## File path: docs/content/docs/deployment/filesystems/gcs.md ## @@ -50,57 +48,66 @@ env.getCheckpointConfig().setCheckpointStorage("gs:///");

[GitHub] [flink] flinkbot edited a comment on pull request #18507: [FLINK-25807][rest][docs] Deduplicate fields that only differ by naming convention

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18507: URL: https://github.com/apache/flink/pull/18507#issuecomment-1021238121 ## CI report: * fbc6046ab610674c9e991cc23a6ea0cfa1c66b0d Azure:

[GitHub] [flink] fapaul commented on a change in pull request #18145: [FLINK-25368][connectors/kafka] Substitute KafkaConsumer with AdminClient when getting offsets

2022-01-25 Thread GitBox
fapaul commented on a change in pull request #18145: URL: https://github.com/apache/flink/pull/18145#discussion_r791678375 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/enumerator/KafkaSourceEnumerator.java ## @@

[GitHub] [flink] RocMarshal commented on pull request #18492: [FLINK-25797][docs-zh] Translate datastream/formats/parquet.md page into Chinese.

2022-01-25 Thread GitBox
RocMarshal commented on pull request #18492: URL: https://github.com/apache/flink/pull/18492#issuecomment-1021262773 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] flinkbot edited a comment on pull request #18428: [FLINK-25575] Add Sink V2 operators and translation

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18428: URL: https://github.com/apache/flink/pull/18428#issuecomment-1017677769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] MartijnVisser commented on pull request #18502: [hotfix][docs][kafka] Add explanation how Kafka Source deals with idl…

2022-01-25 Thread GitBox
MartijnVisser commented on pull request #18502: URL: https://github.com/apache/flink/pull/18502#issuecomment-1021173347 > LGTM  @MartijnVisser do you also want to update the Chinese translation or do it separately? I've updated the PR with the provided Chinese translation. --

[GitHub] [flink] flinkbot commented on pull request #18493: [FLINK-25798][docs-zh] Translate datastream/formats/text_files.md page into Chinese.

2022-01-25 Thread GitBox
flinkbot commented on pull request #18493: URL: https://github.com/apache/flink/pull/18493#issuecomment-1020820553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #18492: [FLINK-25797][docs-zh] Translate datastream/formats/parquet.md page into Chinese.

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18492: URL: https://github.com/apache/flink/pull/18492#issuecomment-1020820488 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] zjureel commented on pull request #18360: [FLINK-25329][runtime] Support memory execution graph store in session cluster

2022-01-25 Thread GitBox
zjureel commented on pull request #18360: URL: https://github.com/apache/flink/pull/18360#issuecomment-1020892847 Thanks @KarmaGYZ , I have updated the doc and comments in `FileExecutionGraphInfoStore` and `FileExecutionGraphInfoStoreTest` -- This is an automated message from the

[GitHub] [flink] dannycranmer commented on pull request #18488: [FLINK-24041][connector] Fixing reversed insertion of failed requests

2022-01-25 Thread GitBox
dannycranmer commented on pull request #18488: URL: https://github.com/apache/flink/pull/18488#issuecomment-1020996381 LGTM, merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] XComp commented on pull request #18303: [FLINK-25085][runtime] Add a scheduled thread pool for periodic tasks in RpcEndpoint

2022-01-25 Thread GitBox
XComp commented on pull request #18303: URL: https://github.com/apache/flink/pull/18303#issuecomment-1020945550 Thanks for the update @KarmaGYZ. I brought it up in today's release call mentioning that FLINK-25433 (which is a subtask of the efforts around introducing the `JobResultStore`;

[GitHub] [flink] flinkbot edited a comment on pull request #18504: [hotfix][azure] fix ArchUnit flag

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18504: URL: https://github.com/apache/flink/pull/18504#issuecomment-1021053731 ## CI report: * 187e515b3c9d3a773cc3e05cf0b3575f49385f08 Azure:

[GitHub] [flink] wanglijie95 commented on pull request #18130: [FLINK-25035][runtime] Shuffle service supports consuming subpartition range

2022-01-25 Thread GitBox
wanglijie95 commented on pull request #18130: URL: https://github.com/apache/flink/pull/18130#issuecomment-1020891761 > @wanglijie95 Thanks for the contribution. The code looks generally good to me and I only left several tiny comments. Thanks for review @wsry . I've addressed all

[GitHub] [flink] galenwarren commented on pull request #15599: [FLINK-11838][flink-gs-fs-hadoop] Create Google Storage file system with recoverable writer support

2022-01-25 Thread GitBox
galenwarren commented on pull request #15599: URL: https://github.com/apache/flink/pull/15599#issuecomment-1020640696 PR created: https://github.com/apache/flink/pull/18489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] flinkbot commented on pull request #18498: [FLINK-25801][ metrics]add cpu processor metric of taskmanager

2022-01-25 Thread GitBox
flinkbot commented on pull request #18498: URL: https://github.com/apache/flink/pull/18498#issuecomment-1020904530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] pnowojski commented on pull request #18475: [FLINK-25728] Protential memory leaks in StreamMultipleInputProcessor

2022-01-25 Thread GitBox
pnowojski commented on pull request #18475: URL: https://github.com/apache/flink/pull/18475#issuecomment-1021298130 I'm afraid that those "time outs" might be because of some bug in this code causing a deadlock. I've also tried [to run a benchmark

[GitHub] [flink] pnowojski commented on a change in pull request #18475: [FLINK-25728] Protential memory leaks in StreamMultipleInputProcessor

2022-01-25 Thread GitBox
pnowojski commented on a change in pull request #18475: URL: https://github.com/apache/flink/pull/18475#discussion_r791869485 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamMultipleInputProcessor.java ## @@ -55,17 +77,24 @@ public

[GitHub] [flink-table-store] tsreaper commented on a change in pull request #14: [FLINK-25803] Implement partition and bucket filter in FileStoreScanImpl

2022-01-25 Thread GitBox
tsreaper commented on a change in pull request #14: URL: https://github.com/apache/flink-table-store/pull/14#discussion_r791535456 ## File path: flink-table-store-core/src/test/java/org/apache/flink/table/store/file/operation/FileStoreCommitTestBase.java ## @@ -71,7 +67,7 @@

[GitHub] [flink] flinkbot edited a comment on pull request #18409: [hotfix][dist] Fix that flink-gs-fs-hadoop not included in flink-dist

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18409: URL: https://github.com/apache/flink/pull/18409#issuecomment-1017132626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] flinkbot edited a comment on pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18382: URL: https://github.com/apache/flink/pull/18382#issuecomment-1014709963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] flinkbot edited a comment on pull request #18482: [FLINK-25744] Support native savepoints

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18482: URL: https://github.com/apache/flink/pull/18482#issuecomment-1020278176 ## CI report: * 91675405ae82d0e945f46caaa685d65763b296c3 Azure:

[GitHub] [flink] jelly-1203 removed a comment on pull request #18493: [FLINK-25798][docs-zh] Translate datastream/formats/text_files.md page into Chinese.

2022-01-25 Thread GitBox
jelly-1203 removed a comment on pull request #18493: URL: https://github.com/apache/flink/pull/18493#issuecomment-1020840973 thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] flinkbot commented on pull request #18505: [FLINK-25796][network] Avoid record copy for result partition of sort-shuffle if there are enough buffers for better performance

2022-01-25 Thread GitBox
flinkbot commented on pull request #18505: URL: https://github.com/apache/flink/pull/18505#issuecomment-1021167533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] syhily commented on a change in pull request #18388: [FLINK-25530][python][connector/pulsar] Support Pulsar source connector in Python DataStream API.

2022-01-25 Thread GitBox
syhily commented on a change in pull request #18388: URL: https://github.com/apache/flink/pull/18388#discussion_r791184358 ## File path: flink-connectors/pom.xml ## @@ -105,6 +105,7 @@ under the License. flink-sql-connector-hive-3.1.2

[GitHub] [flink] flinkbot edited a comment on pull request #18487: [FLINK-25788][Table SQL / API] Add show connectors command

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18487: URL: https://github.com/apache/flink/pull/18487#issuecomment-1020369201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] flinkbot edited a comment on pull request #18499: [hotfix][docs] Fixed error for Hive ZH docs.

2022-01-25 Thread GitBox
flinkbot edited a comment on pull request #18499: URL: https://github.com/apache/flink/pull/18499#issuecomment-1020919615 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

<    1   2   3   4   5   6   7   8   9   >