[jira] [Commented] (FLINK-17398) Filesystem support flexible path reading

2022-04-29 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530344#comment-17530344 ] Jingsong Lee commented on FLINK-17398: -- [~luoyuxia] thanks > Filesystem support fl

[jira] [Assigned] (FLINK-17398) Filesystem support flexible path reading

2022-04-29 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee reassigned FLINK-17398: Assignee: luoyuxia > Filesystem support flexible path reading > -

[jira] [Commented] (FLINK-27436) option `properties.group.id` is not effective in kafka connector for finksql

2022-04-29 Thread Spongebob (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530329#comment-17530329 ] Spongebob commented on FLINK-27436: --- Hi [~martijnvisser] , When I deploy my flinksql a

[jira] (FLINK-15526) Add RollingPolicy to PartitionWriters

2022-04-29 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15526 ] luoyuxia deleted comment on FLINK-15526: -- was (Author: luoyuxia): [~lzljs3620320] If there is no any other user is working it, I would like to take it.  > Add RollingPolicy to PartitionWriters

[jira] (FLINK-15526) Add RollingPolicy to PartitionWriters

2022-04-29 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15526 ] luoyuxia deleted comment on FLINK-15526: -- was (Author: luoyuxia): [~lzljs3620320] I see DefaultRollingPolicy.shouldRollOnEvent can already avoid writing a big file by file size. Does the Jira a

[jira] (FLINK-18346) Support partition pruning for lookup table source

2022-04-29 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18346 ] luoyuxia deleted comment on FLINK-18346: -- was (Author: luoyuxia): [~lzljs3620320] If there is no any other user is working it, I would like to take it.  A pr will come soon. > Support partitio

[jira] [Comment Edited] (FLINK-25545) [JUnit5 Migration] Module: flink-clients

2022-04-29 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530288#comment-17530288 ] RocMarshal edited comment on FLINK-25545 at 4/30/22 1:03 AM: -

[jira] [Commented] (FLINK-25543) [JUnit5 Migration] Module: flink-yarn

2022-04-29 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530289#comment-17530289 ] RocMarshal commented on FLINK-25543: [~xtsong] Yes. Just ping me if there's anything

[jira] [Commented] (FLINK-25545) [JUnit5 Migration] Module: flink-clients

2022-04-29 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530288#comment-17530288 ] RocMarshal commented on FLINK-25545: Updated the state of the PR. > [JUnit5 Migrati

[jira] [Commented] (FLINK-26496) [JUnit5 Migration] Module: flink-yarn-test

2022-04-29 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530285#comment-17530285 ] RocMarshal commented on FLINK-26496: [~xtsong] Yes. Just ping me if there's anything

[jira] [Commented] (FLINK-18346) Support partition pruning for lookup table source

2022-04-29 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530282#comment-17530282 ] luoyuxia commented on FLINK-18346: -- [~lzljs3620320] If there is no any other user is wo

[jira] [Commented] (FLINK-15526) Add RollingPolicy to PartitionWriters

2022-04-29 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530281#comment-17530281 ] luoyuxia commented on FLINK-15526: -- [~lzljs3620320] If there is no any other user is wo

[jira] [Commented] (FLINK-16904) Migrate FileSystem descriptor to new table factory

2022-04-29 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530279#comment-17530279 ] luoyuxia commented on FLINK-16904: -- [~lzljs3620320] If there is no any other user is wo

[jira] [Commented] (FLINK-17398) Filesystem support flexible path reading

2022-04-29 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530278#comment-17530278 ] luoyuxia commented on FLINK-17398: -- [~lzljs3620320] If no any other is working it, I wo

[GitHub] [flink-kubernetes-operator] tedhtchang commented on pull request #188: [FLINK-27129][docs] Hardcoded namespace in FlinkDeployment manifests may fail to deploy

2022-04-29 Thread GitBox
tedhtchang commented on PR #188: URL: https://github.com/apache/flink-kubernetes-operator/pull/188#issuecomment-1113758507 @morhidi Thanks for reviewing. I updated document. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] martin-liu commented on pull request #18561: [FLINK-25874] loose PyFlink dependency of 'python-dateutil' to '>=2.8.0,<3'

2022-04-29 Thread GitBox
martin-liu commented on PR #18561: URL: https://github.com/apache/flink/pull/18561#issuecomment-1113635442 @dianfu This PR is pending for almost 3 months, can we proceed it if there's no more concern? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] BiGsuw commented on pull request #19590: [FLINK-27352][tests] [JUnit5 Migration] Module: flink-json

2022-04-29 Thread GitBox
BiGsuw commented on PR #19590: URL: https://github.com/apache/flink/pull/19590#issuecomment-1113559303 @zentol I have revised it according to your suggestion, please review it again, Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Updated] (FLINK-27459) JsonJobGraphGenerationTest doesn't reset context environment

2022-04-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27459: --- Labels: pull-request-available (was: ) > JsonJobGraphGenerationTest doesn't reset context e

[GitHub] [flink] flinkbot commented on pull request #19612: [FLINK-27459][tests] Reset context environment

2022-04-29 Thread GitBox
flinkbot commented on PR #19612: URL: https://github.com/apache/flink/pull/19612#issuecomment-1113554032 ## CI report: * 4d56f45020c81757093c9321afd6c40e52077961 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-27459) JsonJobGraphGenerationTest doesn't reset context environment

2022-04-29 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-27459: Summary: JsonJobGraphGenerationTest doesn't reset context environment Key: FLINK-27459 URL: https://issues.apache.org/jira/browse/FLINK-27459 Project: Flink

[jira] [Assigned] (FLINK-27441) Scrollbar is missing for particular UI elements (Accumulators, Backpressure, Watermarks)

2022-04-29 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-27441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi reassigned FLINK-27441: -- Assignee: Ferenc Csaky > Scrollbar is missing for particular UI elements (Accumulator

[GitHub] [flink] mbalassi commented on pull request #19606: [FLINK-27441][webfrontend] fix "nzScroll" calculations

2022-04-29 Thread GitBox
mbalassi commented on PR #19606: URL: https://github.com/apache/flink/pull/19606#issuecomment-1113531337 Thanks @ferenc-csaky and @gaborgsomogyi. Will merge on Monday after a quick test unless anyone raises an issue. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [flink] BiGsuw commented on a diff in pull request #19590: [FLINK-27352][tests] [JUnit5 Migration] Module: flink-json

2022-04-29 Thread GitBox
BiGsuw commented on code in PR #19590: URL: https://github.com/apache/flink/pull/19590#discussion_r861966383 ## flink-formats/flink-json/src/test/java/org/apache/flink/formats/json/JsonBatchFileSystemITCase.java: ## @@ -36,10 +36,14 @@ import java.util.Arrays; import java.util

[GitHub] [flink] BiGsuw commented on a diff in pull request #19590: [FLINK-27352][tests] [JUnit5 Migration] Module: flink-json

2022-04-29 Thread GitBox
BiGsuw commented on code in PR #19590: URL: https://github.com/apache/flink/pull/19590#discussion_r861960703 ## flink-formats/flink-json/src/test/java/org/apache/flink/formats/json/JsonBatchFileSystemITCase.java: ## @@ -50,11 +54,27 @@ public String[] formatProperties() { }

[GitHub] [flink-web] akalash commented on pull request #524: Add Buffer debloating blog post

2022-04-29 Thread GitBox
akalash commented on PR #524: URL: https://github.com/apache/flink-web/pull/524#issuecomment-1113499864 > Question here: For the case of backpressure and no backpressure, what is exactly meant? Is it backpressure to the upstream task or from downstream task? I assume the first, but I would

[jira] [Closed] (FLINK-27425) Default job service account needs access to services to work with Kafka

2022-04-29 Thread Mark Nuttall (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Nuttall closed FLINK-27425. Resolution: Invalid > Default job service account needs access to services to work with Kafka > --

[jira] [Commented] (FLINK-27425) Default job service account needs access to services to work with Kafka

2022-04-29 Thread Mark Nuttall (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530079#comment-17530079 ] Mark Nuttall commented on FLINK-27425: -- After further investigation, I realised tha

[jira] [Commented] (FLINK-27405) Refactor SourceCoordinator to abstract BaseCoordinator implementation

2022-04-29 Thread Steven Zhen Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530078#comment-17530078 ] Steven Zhen Wu commented on FLINK-27405: [~arvid] thanks a lot for the feedbacks

[GitHub] [flink-kubernetes-operator] mnuttall closed pull request #186: [FLINK-27425] Default job service account needs access to services to work with Kafka

2022-04-29 Thread GitBox
mnuttall closed pull request #186: [FLINK-27425] Default job service account needs access to services to work with Kafka URL: https://github.com/apache/flink-kubernetes-operator/pull/186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [flink-kubernetes-operator] mnuttall commented on pull request #186: [FLINK-27425] Default job service account needs access to services to work with Kafka

2022-04-29 Thread GitBox
mnuttall commented on PR #186: URL: https://github.com/apache/flink-kubernetes-operator/pull/186#issuecomment-1113479661 Update - yes, I've connected an sql-client to a session cluster and successfully run jobs against it, using Kafka. ``` apiVersion: flink.apache.org/v1alpha1

[GitHub] [flink] BiGsuw commented on a diff in pull request #19590: [FLINK-27352][tests] [JUnit5 Migration] Module: flink-json

2022-04-29 Thread GitBox
BiGsuw commented on code in PR #19590: URL: https://github.com/apache/flink/pull/19590#discussion_r861939399 ## flink-formats/flink-json/src/test/java/org/apache/flink/formats/json/debezium/DebeziumJsonSerDeSchemaTest.java: ## @@ -318,7 +307,7 @@ private void testDeserialization

[jira] [Created] (FLINK-27458) Expose allowNonRestoredState flag in JobSpec

2022-04-29 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-27458: -- Summary: Expose allowNonRestoredState flag in JobSpec Key: FLINK-27458 URL: https://issues.apache.org/jira/browse/FLINK-27458 Project: Flink Issue Type: Improvem

[jira] [Commented] (FLINK-27337) Prevent session cluster to be deleted when there are running jobs

2022-04-29 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530056#comment-17530056 ] Gyula Fora commented on FLINK-27337: I agree for deletions, the upgrade situation is

[GitHub] [flink] masteryhx commented on a diff in pull request #19598: [FLINK-25470][changelog] Expose more metrics of materialization

2022-04-29 Thread GitBox
masteryhx commented on code in PR #19598: URL: https://github.com/apache/flink/pull/19598#discussion_r861908383 ## flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogMetricGroup.java: ## @@ -0,0 +1,150 @@ +/* + * Licensed to

[GitHub] [flink] masteryhx commented on a diff in pull request #19598: [FLINK-25470][changelog] Expose more metrics of materialization

2022-04-29 Thread GitBox
masteryhx commented on code in PR #19598: URL: https://github.com/apache/flink/pull/19598#discussion_r861908063 ## flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/PeriodicMaterializationManager.java: ## @@ -180,9 +188,11 @@ privat

[GitHub] [flink] masteryhx commented on a diff in pull request #19598: [FLINK-25470][changelog] Expose more metrics of materialization

2022-04-29 Thread GitBox
masteryhx commented on code in PR #19598: URL: https://github.com/apache/flink/pull/19598#discussion_r861907199 ## flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/PeriodicMaterializationManager.java: ## @@ -132,8 +135,13 @@ public

[GitHub] [flink] masteryhx commented on a diff in pull request #19598: [FLINK-25470][changelog] Expose more metrics of materialization

2022-04-29 Thread GitBox
masteryhx commented on code in PR #19598: URL: https://github.com/apache/flink/pull/19598#discussion_r861899241 ## flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogMetricGroup.java: ## @@ -0,0 +1,150 @@ +/* + * Licensed to

[GitHub] [flink] echauchot commented on a diff in pull request #19586: [FLINK-26824] Upgrade Flink's supported Cassandra versions to match all Apache Cassandra supported versions

2022-04-29 Thread GitBox
echauchot commented on code in PR #19586: URL: https://github.com/apache/flink/pull/19586#discussion_r861897602 ## flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraSinkBase.java: ## @@ -72,6 +74,16 @@ Clos

[jira] [Created] (FLINK-27457) CassandraOutputFormats should support flush

2022-04-29 Thread Etienne Chauchot (Jira)
Etienne Chauchot created FLINK-27457: Summary: CassandraOutputFormats should support flush Key: FLINK-27457 URL: https://issues.apache.org/jira/browse/FLINK-27457 Project: Flink Issue Typ

[GitHub] [flink] masteryhx commented on a diff in pull request #19598: [FLINK-25470][changelog] Expose more metrics of materialization

2022-04-29 Thread GitBox
masteryhx commented on code in PR #19598: URL: https://github.com/apache/flink/pull/19598#discussion_r861893623 ## flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogMetricGroup.java: ## @@ -0,0 +1,150 @@ +/* + * Licensed to

[GitHub] [flink] masteryhx commented on a diff in pull request #19598: [FLINK-25470][changelog] Expose more metrics of materialization

2022-04-29 Thread GitBox
masteryhx commented on code in PR #19598: URL: https://github.com/apache/flink/pull/19598#discussion_r861891790 ## flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogMetricGroup.java: ## @@ -0,0 +1,150 @@ +/* + * Licensed to

[GitHub] [flink] masteryhx commented on a diff in pull request #19598: [FLINK-25470][changelog] Expose more metrics of materialization

2022-04-29 Thread GitBox
masteryhx commented on code in PR #19598: URL: https://github.com/apache/flink/pull/19598#discussion_r861889843 ## flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java: ## @@ -672,14 +680,17 @@ public vo

[GitHub] [flink] masteryhx commented on a diff in pull request #19598: [FLINK-25470][changelog] Expose more metrics of materialization

2022-04-29 Thread GitBox
masteryhx commented on code in PR #19598: URL: https://github.com/apache/flink/pull/19598#discussion_r861889523 ## flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java: ## @@ -694,6 +705,10 @@ public Key

[jira] [Closed] (FLINK-27453) Cleanup TestBaseUtils

2022-04-29 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-27453. Resolution: Fixed master: e4b8e4ea52aa9ab1efa0860f027efdda105ab4ad > Cleanup TestBaseUtil

[GitHub] [flink] zentol merged pull request #19610: [FLINK-27453][tests] Cleanup TestBaseUtils

2022-04-29 Thread GitBox
zentol merged PR #19610: URL: https://github.com/apache/flink/pull/19610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Closed] (FLINK-27452) Move TestBaseUtils#getFromHttp to WebFrontendITCase

2022-04-29 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-27452. Fix Version/s: 1.16.0 Resolution: Fixed master: 6d6175871bc4ce1fec746c8d0164d6f2706

[GitHub] [flink] zentol merged pull request #19609: [FLINK-27452][tests] Move TestBaseUtils#getFromHttp to WebFrontendITCase

2022-04-29 Thread GitBox
zentol merged PR #19609: URL: https://github.com/apache/flink/pull/19609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[GitHub] [flink] zentol commented on a diff in pull request #19600: [FLINK-27433][tests] Move RocksDB's log location to /tmp for e2e tests

2022-04-29 Thread GitBox
zentol commented on code in PR #19600: URL: https://github.com/apache/flink/pull/19600#discussion_r861769777 ## flink-end-to-end-tests/test-scripts/common.sh: ## @@ -305,6 +305,10 @@ function wait_dispatcher_running { } function start_cluster { + # After FLINK-24785, RocksD

[GitHub] [flink] flinkbot commented on pull request #19611: [FLINK-27454][tests] Remove inheritance from TestBaseUtils

2022-04-29 Thread GitBox
flinkbot commented on PR #19611: URL: https://github.com/apache/flink/pull/19611#issuecomment-1113260065 ## CI report: * 5aed2f1482f9173028f7d6b519f1c3f4e6c0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-27454) Remove inheritance from TestBaseUtils

2022-04-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27454: --- Labels: pull-request-available (was: ) > Remove inheritance from TestBaseUtils > --

[GitHub] [flink] zentol opened a new pull request, #19611: [FLINK-27454][tests] Remove inheritance from TestBaseUtils

2022-04-29 Thread GitBox
zentol opened a new pull request, #19611: URL: https://github.com/apache/flink/pull/19611 Based on #19610. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[jira] [Commented] (FLINK-27405) Refactor SourceCoordinator to abstract BaseCoordinator implementation

2022-04-29 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529957#comment-17529957 ] Arvid Heise commented on FLINK-27405: - Hi [~stevenz3wu], I think this approach look

[jira] [Updated] (FLINK-27452) Move TestBaseUtils#getFromHttp to WebFrontendITCase

2022-04-29 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-27452: - Component/s: Tests > Move TestBaseUtils#getFromHttp to WebFrontendITCase > -

[jira] [Commented] (FLINK-27434) How to convert 'Schema' to 'ResolvedSchema' within 'Catalog'?

2022-04-29 Thread wuwenchi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529942#comment-17529942 ] wuwenchi commented on FLINK-27434: -- [~fsk119]  Thanks for  your reply! We want iceberg

[GitHub] [flink] zentol commented on a diff in pull request #19590: [FLINK-27352][tests] [JUnit5 Migration] Module: flink-json

2022-04-29 Thread GitBox
zentol commented on code in PR #19590: URL: https://github.com/apache/flink/pull/19590#discussion_r861704021 ## flink-formats/flink-json/src/test/java/org/apache/flink/formats/json/ogg/OggJsonSerDeSchemaTest.java: ## @@ -242,7 +240,7 @@ private void testSerializationDeserializat

[jira] [Commented] (FLINK-27456) mistake and confusion with CEP example in docs

2022-04-29 Thread zhangtianyu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529911#comment-17529911 ] zhangtianyu commented on FLINK-27456: - t-1退订【18120144...@189.cn】 jira 写到: David An

[GitHub] [flink] flinkbot commented on pull request #19610: [FLINK-27453][tests] Cleanup TestBaseUtils

2022-04-29 Thread GitBox
flinkbot commented on PR #19610: URL: https://github.com/apache/flink/pull/19610#issuecomment-1113174265 ## CI report: * 5cd3e25682e9c2ba8860399b8340e1a8ec8d0275 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-27453) Cleanup TestBaseUtils

2022-04-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27453: --- Labels: pull-request-available (was: ) > Cleanup TestBaseUtils > - > >

[GitHub] [flink] zentol opened a new pull request, #19610: [FLINK-27453][tests] Cleanup TestBaseUtils

2022-04-29 Thread GitBox
zentol opened a new pull request, #19610: URL: https://github.com/apache/flink/pull/19610 Based on #19609. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[jira] [Created] (FLINK-27456) mistake and confusion with CEP example in docs

2022-04-29 Thread David Anderson (Jira)
David Anderson created FLINK-27456: -- Summary: mistake and confusion with CEP example in docs Key: FLINK-27456 URL: https://issues.apache.org/jira/browse/FLINK-27456 Project: Flink Issue Type

[jira] [Created] (FLINK-27455) [JUnit5 Migration] SnapshotMigrationTestBase

2022-04-29 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-27455: Summary: [JUnit5 Migration] SnapshotMigrationTestBase Key: FLINK-27455 URL: https://issues.apache.org/jira/browse/FLINK-27455 Project: Flink Issue Ty

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #87: [FLINK-27096] Add a script to visualize benchmark results

2022-04-29 Thread GitBox
lindong28 commented on code in PR #87: URL: https://github.com/apache/flink-ml/pull/87#discussion_r861680131 ## flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/Benchmark.java: ## @@ -75,33 +75,43 @@ public static void printHelp() { public static void executeB

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #87: [FLINK-27096] Add a script to visualize benchmark results

2022-04-29 Thread GitBox
lindong28 commented on code in PR #87: URL: https://github.com/apache/flink-ml/pull/87#discussion_r861666211 ## flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/Benchmark.java: ## @@ -71,37 +70,57 @@ public static void printHelp() { System.out.println();

[GitHub] [flink] gaborgsomogyi commented on pull request #19606: [FLINK-27441][webfrontend] fix "nzScroll" calculations

2022-04-29 Thread GitBox
gaborgsomogyi commented on PR #19606: URL: https://github.com/apache/flink/pull/19606#issuecomment-1113144117 @mbalassi @gyfora could you have a look plz? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [flink-kubernetes-operator] SteNicholas commented on a diff in pull request #190: [FLINK-27451] Enable the validator plugin in webhook

2022-04-29 Thread GitBox
SteNicholas commented on code in PR #190: URL: https://github.com/apache/flink-kubernetes-operator/pull/190#discussion_r861670372 ## flink-kubernetes-webhook/src/test/java/org/apache/flink/kubernetes/operator/admission/AdmissionHandlerTest.java: ## @@ -52,7 +53,9 @@ public clas

[jira] [Updated] (FLINK-27451) Enable the validator plugin in webhook

2022-04-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27451: --- Labels: pull-request-available (was: ) > Enable the validator plugin in webhook > -

[GitHub] [flink-kubernetes-operator] SteNicholas commented on a diff in pull request #190: [FLINK-27451] Enable the validator plugin in webhook

2022-04-29 Thread GitBox
SteNicholas commented on code in PR #190: URL: https://github.com/apache/flink-kubernetes-operator/pull/190#discussion_r861669274 ## flink-kubernetes-webhook/src/main/java/org/apache/flink/kubernetes/operator/admission/FlinkOperatorWebhook.java: ## @@ -57,8 +59,8 @@ public clas

[GitHub] [flink] gaoyunhaii commented on pull request #19584: release notes for the 1.15 release

2022-04-29 Thread GitBox
gaoyunhaii commented on PR #19584: URL: https://github.com/apache/flink/pull/19584#issuecomment-1113134837 Very thanks @zentol for the review! I have updated the PR according to the comments~ -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [flink-web] dannycranmer commented on a diff in pull request #517: [FLINK-24370] Addition of blog post describing features and usage of the Async Sink…

2022-04-29 Thread GitBox
dannycranmer commented on code in PR #517: URL: https://github.com/apache/flink-web/pull/517#discussion_r861661076 ## _posts/2022-03-16-async-sink-base.md: ## @@ -0,0 +1,169 @@ +--- +layout: post +title: "The Generic Asynchronous Base Sink" +date: 2022-04-30 16:00:00 +authors: +

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #188: [FLINK-27129][docs] Hardcoded namespace in FlinkDeployment manifests may fail to deploy

2022-04-29 Thread GitBox
morhidi commented on PR #188: URL: https://github.com/apache/flink-kubernetes-operator/pull/188#issuecomment-1113133688 This PR looks good, nit: I would emphasise that the scripts/deployments will run in the default namespace, that must be change using `kubectl config set-context --current

[jira] [Updated] (FLINK-24809) Check & possible fix decimal precision and scale for all Aggregate functions

2022-04-29 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Gao updated FLINK-24809: Release Note: This changes the result of a decimal SUM with retraction and AVG() between 1.14.0 and 1.14.1

[GitHub] [flink] gaoyunhaii commented on a diff in pull request #19584: release notes for the 1.15 release

2022-04-29 Thread GitBox
gaoyunhaii commented on code in PR #19584: URL: https://github.com/apache/flink/pull/19584#discussion_r861655853 ## docs/content/release-notes/flink-1.15.md: ## @@ -0,0 +1,597 @@ +--- +title: "Release Notes - Flink 1.15" +--- + + +# Release notes - Flink 1.15 + +These release no

[jira] [Updated] (FLINK-16501) Support IS JSON for Table API

2022-04-29 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Gao updated FLINK-16501: Release Note: This issue added IS JSON for Table API. Notes that `IS JSON` does not return NULL anymore bu

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #87: [FLINK-27096] Add a script to visualize benchmark results

2022-04-29 Thread GitBox
lindong28 commented on code in PR #87: URL: https://github.com/apache/flink-ml/pull/87#discussion_r861656690 ## flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/BenchmarkResult.java: ## @@ -18,13 +18,25 @@ package org.apache.flink.ml.benchmark; +import org.apa

[GitHub] [flink] gaoyunhaii commented on a diff in pull request #19584: release notes for the 1.15 release

2022-04-29 Thread GitBox
gaoyunhaii commented on code in PR #19584: URL: https://github.com/apache/flink/pull/19584#discussion_r861655853 ## docs/content/release-notes/flink-1.15.md: ## @@ -0,0 +1,597 @@ +--- +title: "Release Notes - Flink 1.15" +--- + + +# Release notes - Flink 1.15 + +These release no

[GitHub] [flink] gaoyunhaii commented on a diff in pull request #19584: release notes for the 1.15 release

2022-04-29 Thread GitBox
gaoyunhaii commented on code in PR #19584: URL: https://github.com/apache/flink/pull/19584#discussion_r861655853 ## docs/content/release-notes/flink-1.15.md: ## @@ -0,0 +1,597 @@ +--- +title: "Release Notes - Flink 1.15" +--- + + +# Release notes - Flink 1.15 + +These release no

[GitHub] [flink-web] sthm commented on a diff in pull request #517: [FLINK-24370] Addition of blog post describing features and usage of the Async Sink…

2022-04-29 Thread GitBox
sthm commented on code in PR #517: URL: https://github.com/apache/flink-web/pull/517#discussion_r861651452 ## _posts/2022-03-16-async-sink-base.md: ## @@ -0,0 +1,169 @@ +--- +layout: post +title: "The Generic Asynchronous Base Sink" +date: 2022-04-30 16:00:00 +authors: +- Crynet

[jira] [Created] (FLINK-27454) Remove inheritance from TestBaseUtils

2022-04-29 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-27454: Summary: Remove inheritance from TestBaseUtils Key: FLINK-27454 URL: https://issues.apache.org/jira/browse/FLINK-27454 Project: Flink Issue Type: Tec

[jira] [Created] (FLINK-27453) Cleanup TestBaseUtils

2022-04-29 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-27453: Summary: Cleanup TestBaseUtils Key: FLINK-27453 URL: https://issues.apache.org/jira/browse/FLINK-27453 Project: Flink Issue Type: Technical Debt

[jira] [Updated] (FLINK-16501) Support IS JSON for Table API

2022-04-29 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Gao updated FLINK-16501: Release Note: This issue added IS JSON for Table API. Notes `IS JSON` does not return NULL anymore but alw

[GitHub] [flink] gaoyunhaii commented on a diff in pull request #19584: release notes for the 1.15 release

2022-04-29 Thread GitBox
gaoyunhaii commented on code in PR #19584: URL: https://github.com/apache/flink/pull/19584#discussion_r861645152 ## docs/content/release-notes/flink-1.15.md: ## @@ -0,0 +1,597 @@ +--- +title: "Release Notes - Flink 1.15" +--- + + +# Release notes - Flink 1.15 + +These release no

[jira] [Updated] (FLINK-27452) Move TestBaseUtils#getFromHttp to WebFrontendITCase

2022-04-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27452: --- Labels: pull-request-available (was: ) > Move TestBaseUtils#getFromHttp to WebFrontendITCas

[GitHub] [flink] flinkbot commented on pull request #19609: [FLINK-27452][tests] Move TestBaseUtils#getFromHttp to WebFrontendITCase

2022-04-29 Thread GitBox
flinkbot commented on PR #19609: URL: https://github.com/apache/flink/pull/19609#issuecomment-1113108192 ## CI report: * 41481650e41f27b38c76f311fc5883eef51d040e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] MartijnVisser commented on pull request #19571: [FLINK-27394] Integrate the Flink Elasticsearch documentation in the Flink documentation

2022-04-29 Thread GitBox
MartijnVisser commented on PR #19571: URL: https://github.com/apache/flink/pull/19571#issuecomment-1113108121 > oh this doesn't even run in our ci image. then I guess you'll need to update the azure yaml as well. Based on https://github.com/actions/virtual-environments/blob/main/imag

[jira] [Assigned] (FLINK-27452) Move TestBaseUtils#getFromHttp to WebFrontendITCase

2022-04-29 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-27452: Assignee: Chesnay Schepler > Move TestBaseUtils#getFromHttp to WebFrontendITCase

[jira] [Updated] (FLINK-27452) Move TestBaseUtils#getFromHttp to WebFrontendITCase

2022-04-29 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-27452: - Summary: Move TestBaseUtils#getFromHttp to WebFrontendITCase (was: Move Te) > Move Test

[jira] [Created] (FLINK-27452) Move Te

2022-04-29 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-27452: Summary: Move Te Key: FLINK-27452 URL: https://issues.apache.org/jira/browse/FLINK-27452 Project: Flink Issue Type: Technical Debt Report

[GitHub] [flink] gaoyunhaii commented on a diff in pull request #19584: release notes for the 1.15 release

2022-04-29 Thread GitBox
gaoyunhaii commented on code in PR #19584: URL: https://github.com/apache/flink/pull/19584#discussion_r861620093 ## docs/content/release-notes/flink-1.15.md: ## @@ -0,0 +1,597 @@ +--- +title: "Release Notes - Flink 1.15" +--- + + +# Release notes - Flink 1.15 + +These release no

[GitHub] [flink] gaoyunhaii commented on a diff in pull request #19584: release notes for the 1.15 release

2022-04-29 Thread GitBox
gaoyunhaii commented on code in PR #19584: URL: https://github.com/apache/flink/pull/19584#discussion_r861629727 ## docs/content/release-notes/flink-1.15.md: ## @@ -0,0 +1,597 @@ +--- +title: "Release Notes - Flink 1.15" +--- + + +# Release notes - Flink 1.15 + +These release no

[jira] [Comment Edited] (FLINK-27337) Prevent session cluster to be deleted when there are running jobs

2022-04-29 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529879#comment-17529879 ] Aitozi edited comment on FLINK-27337 at 4/29/22 9:13 AM: - I want

[jira] [Commented] (FLINK-27337) Prevent session cluster to be deleted when there are running jobs

2022-04-29 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529879#comment-17529879 ] Aitozi commented on FLINK-27337:   I want to solve this in the following way # In webh

[GitHub] [flink] gaoyunhaii commented on a diff in pull request #19584: release notes for the 1.15 release

2022-04-29 Thread GitBox
gaoyunhaii commented on code in PR #19584: URL: https://github.com/apache/flink/pull/19584#discussion_r861628035 ## docs/content/release-notes/flink-1.15.md: ## @@ -0,0 +1,597 @@ +--- +title: "Release Notes - Flink 1.15" +--- + + +# Release notes - Flink 1.15 + +These release no

[GitHub] [flink] gaoyunhaii commented on a diff in pull request #19584: release notes for the 1.15 release

2022-04-29 Thread GitBox
gaoyunhaii commented on code in PR #19584: URL: https://github.com/apache/flink/pull/19584#discussion_r861627475 ## docs/content/release-notes/flink-1.15.md: ## @@ -0,0 +1,597 @@ +--- +title: "Release Notes - Flink 1.15" +--- + + +# Release notes - Flink 1.15 + +These release no

[GitHub] [flink] gaoyunhaii commented on a diff in pull request #19584: release notes for the 1.15 release

2022-04-29 Thread GitBox
gaoyunhaii commented on code in PR #19584: URL: https://github.com/apache/flink/pull/19584#discussion_r861626716 ## docs/content/release-notes/flink-1.15.md: ## @@ -0,0 +1,597 @@ +--- +title: "Release Notes - Flink 1.15" +--- + + +# Release notes - Flink 1.15 + +These release no

[GitHub] [flink] gaoyunhaii commented on a diff in pull request #19584: release notes for the 1.15 release

2022-04-29 Thread GitBox
gaoyunhaii commented on code in PR #19584: URL: https://github.com/apache/flink/pull/19584#discussion_r861626176 ## docs/content/release-notes/flink-1.15.md: ## @@ -0,0 +1,597 @@ +--- +title: "Release Notes - Flink 1.15" +--- + + +# Release notes - Flink 1.15 + +These release no

[GitHub] [flink] gaoyunhaii commented on a diff in pull request #19584: release notes for the 1.15 release

2022-04-29 Thread GitBox
gaoyunhaii commented on code in PR #19584: URL: https://github.com/apache/flink/pull/19584#discussion_r861623560 ## docs/content/release-notes/flink-1.15.md: ## @@ -0,0 +1,597 @@ +--- +title: "Release Notes - Flink 1.15" +--- + + +# Release notes - Flink 1.15 + +These release no

[GitHub] [flink] ferenc-csaky commented on pull request #19606: [FLINK-27441] fix "nzScroll" calculations

2022-04-29 Thread GitBox
ferenc-csaky commented on PR #19606: URL: https://github.com/apache/flink/pull/19606#issuecomment-1113086239 Tanks for the comments. 1. Yes, I linked it to the corresponding Jira, but here it is: https://github.com/NG-ZORRO/ng-zorro-antd/issues/3090 2. I tested this with Accumulato

[GitHub] [flink] gaoyunhaii commented on a diff in pull request #19584: release notes for the 1.15 release

2022-04-29 Thread GitBox
gaoyunhaii commented on code in PR #19584: URL: https://github.com/apache/flink/pull/19584#discussion_r861620093 ## docs/content/release-notes/flink-1.15.md: ## @@ -0,0 +1,597 @@ +--- +title: "Release Notes - Flink 1.15" +--- + + +# Release notes - Flink 1.15 + +These release no

[GitHub] [flink] gaoyunhaii commented on a diff in pull request #19584: release notes for the 1.15 release

2022-04-29 Thread GitBox
gaoyunhaii commented on code in PR #19584: URL: https://github.com/apache/flink/pull/19584#discussion_r861617764 ## docs/content/release-notes/flink-1.15.md: ## @@ -0,0 +1,597 @@ +--- +title: "Release Notes - Flink 1.15" +--- + + +# Release notes - Flink 1.15 + +These release no

[GitHub] [flink] zentol commented on a diff in pull request #19584: release notes for the 1.15 release

2022-04-29 Thread GitBox
zentol commented on code in PR #19584: URL: https://github.com/apache/flink/pull/19584#discussion_r861611488 ## docs/content/release-notes/flink-1.15.md: ## @@ -0,0 +1,597 @@ +--- +title: "Release Notes - Flink 1.15" +--- + + +# Release notes - Flink 1.15 + +These release notes

  1   2   >