[GitHub] [flink-kubernetes-operator] Aitozi commented on a diff in pull request #192: [FLINK-27097] Document custom validator implementations

2022-05-03 Thread GitBox
Aitozi commented on code in PR #192: URL: https://github.com/apache/flink-kubernetes-operator/pull/192#discussion_r864502156 ## docs/content/docs/operations/validator.md: ## @@ -0,0 +1,74 @@ +--- +title: "Validator" +weight: 5 +type: docs +aliases: +- /operations/validator.html

[GitHub] [flink-kubernetes-operator] Aitozi commented on a diff in pull request #192: [FLINK-27097] Document custom validator implementations

2022-05-03 Thread GitBox
Aitozi commented on code in PR #192: URL: https://github.com/apache/flink-kubernetes-operator/pull/192#discussion_r864495061 ## docs/content/docs/operations/validator.md: ## @@ -0,0 +1,74 @@ +--- +title: "Validator" +weight: 5 +type: docs +aliases: +- /operations/validator.html

[jira] [Comment Edited] (FLINK-27483) Support adding custom HTTP header for HTTP based Jar fetch

2022-05-03 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531506#comment-17531506 ] Aitozi edited comment on FLINK-27483 at 5/4/22 6:29 AM: I think

[jira] [Commented] (FLINK-27483) Support adding custom HTTP header for HTTP based Jar fetch

2022-05-03 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531506#comment-17531506 ] Aitozi commented on FLINK-27483: I think the custom headers is reasonable, but I'm not t

[jira] [Comment Edited] (FLINK-27483) Support adding custom HTTP header for HTTP based Jar fetch

2022-05-03 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531506#comment-17531506 ] Aitozi edited comment on FLINK-27483 at 5/4/22 6:28 AM: I think

[GitHub] [flink] snuyanzin commented on a diff in pull request #17677: [FLINK-24766][table] Ceiling/flooring dates to day returns wrong results

2022-05-03 Thread GitBox
snuyanzin commented on code in PR #17677: URL: https://github.com/apache/flink/pull/17677#discussion_r864489044 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/FloorCeilCallGen.scala: ## @@ -105,13 +105,27 @@ class FloorCeilCallGen(

[jira] [Updated] (FLINK-27097) Document custom validator implementations

2022-05-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27097: --- Labels: pull-request-available starter (was: starter) > Document custom validator implement

[GitHub] [flink-kubernetes-operator] SteNicholas commented on pull request #192: [FLINK-27097] Document custom validator implementations

2022-05-03 Thread GitBox
SteNicholas commented on PR #192: URL: https://github.com/apache/flink-kubernetes-operator/pull/192#issuecomment-1116959971 @gyfora, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [flink-kubernetes-operator] SteNicholas opened a new pull request, #192: [FLINK-27097] Document custom validator implementations

2022-05-03 Thread GitBox
SteNicholas opened a new pull request, #192: URL: https://github.com/apache/flink-kubernetes-operator/pull/192 Currently we allow users to specify custom validator implementations through the operator configuration. This can be very useful in production environments to implement custom vali

[jira] [Commented] (FLINK-25865) Support to set restart policy of TaskManager pod for native K8s integration

2022-05-03 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531499#comment-17531499 ] Aitozi commented on FLINK-25865: Hi [~wangyang0918] are you working on this now ? If not

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a diff in pull request #191: [FLINK-27303] Improve config cache settings + add cleanup

2022-05-03 Thread GitBox
wangyang0918 commented on code in PR #191: URL: https://github.com/apache/flink-kubernetes-operator/pull/191#discussion_r864478414 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigManager.java: ## @@ -87,8 +89,15 @@ public Config

[jira] [Commented] (FLINK-26647) Can not add extra config files on native Kubernetes

2022-05-03 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531498#comment-17531498 ] Aitozi commented on FLINK-26647: I think it will bring convenience to add a way to add c

[GitHub] [flink] flinkbot commented on pull request #19631: [FLINK-26397][docs-zh] Chinese Translation - Add documentation for Ki…

2022-05-03 Thread GitBox
flinkbot commented on PR #19631: URL: https://github.com/apache/flink/pull/19631#issuecomment-1116922993 ## CI report: * 22cf82350bc0e6ee1f713937ff9bad0431c885db UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-26397) Chinese Translation - Add documentation for Kinesis firehose Table Api

2022-05-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-26397: --- Labels: chinese-translation pull-request-available (was: chinese-translation) > Chinese Tr

[GitHub] [flink] cjjxfli opened a new pull request, #19631: [FLINK-26397][docs-zh] Chinese Translation - Add documentation for Ki…

2022-05-03 Thread GitBox
cjjxfli opened a new pull request, #19631: URL: https://github.com/apache/flink/pull/19631 [FLINK-26397][docs-zh] Chinese Translation - Add documentation for Kinesis firehose Table Api ## What is the purpose of the change *([FLINK-26397][docs-zh] Chinese Translation - A

[GitHub] [flink] flinkbot commented on pull request #19630: [FLINK-27461] Add option to set userAgent for kubeclient

2022-05-03 Thread GitBox
flinkbot commented on PR #19630: URL: https://github.com/apache/flink/pull/19630#issuecomment-1116912526 ## CI report: * 4d12d27eeeb4e8bc236732af954bd843046b5302 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-27461) Add a convenient way to set userAgent for the kubeclient

2022-05-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27461: --- Labels: pull-request-available (was: ) > Add a convenient way to set userAgent for the kube

[GitHub] [flink] Aitozi opened a new pull request, #19630: [FLINK-27461] Add option to set userAgent for kubeclient

2022-05-03 Thread GitBox
Aitozi opened a new pull request, #19630: URL: https://github.com/apache/flink/pull/19630 ## What is the purpose of the change This Pr is meant to add option to set user agent for kubeclient. ## Verifying this change This PR is a minor change without test case -- T

[jira] [Commented] (FLINK-26945) Add DATE_SUB supported in SQL & Table API

2022-05-03 Thread Lichuanliang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531469#comment-17531469 ] Lichuanliang commented on FLINK-26945: -- [~lsy] I've made a pull request. Please tak

[jira] [Updated] (FLINK-27483) Support adding custom HTTP header for HTTP based Jar fetch

2022-05-03 Thread Fuyao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fuyao Li updated FLINK-27483: - Description: Hello Team, I noticed this https://issues.apache.org/jira/browse/FLINK-27161, which could

[jira] [Updated] (FLINK-27483) Support adding custom HTTP header for HTTP based Jar fetch

2022-05-03 Thread Fuyao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fuyao Li updated FLINK-27483: - Description: Hello Team, I noticed this https://issues.apache.org/jira/browse/FLINK-27161, which could

[jira] [Updated] (FLINK-27483) Support adding custom HTTP header for HTTP based Jar fetch

2022-05-03 Thread Fuyao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fuyao Li updated FLINK-27483: - Summary: Support adding custom HTTP header for HTTP based Jar fetch (was: Support adding HTTP header fo

[jira] [Commented] (FLINK-27483) Support adding HTTP header for HTTP based Jar fetch

2022-05-03 Thread Fuyao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531445#comment-17531445 ] Fuyao Li commented on FLINK-27483: -- [~wangyang0918] [~aitozi]  Thanks. > Support addin

[jira] [Updated] (FLINK-27483) Support adding HTTP header for HTTP based Jar fetch

2022-05-03 Thread Fuyao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fuyao Li updated FLINK-27483: - Description: Hello Team, I noticed this https://issues.apache.org/jira/browse/FLINK-27161, which could

[jira] [Created] (FLINK-27483) Support adding HTTP header for HTTP based Jar fetch

2022-05-03 Thread Fuyao Li (Jira)
Fuyao Li created FLINK-27483: Summary: Support adding HTTP header for HTTP based Jar fetch Key: FLINK-27483 URL: https://issues.apache.org/jira/browse/FLINK-27483 Project: Flink Issue Type: Impro

[jira] [Updated] (FLINK-27479) HybridSource refreshes availability future

2022-05-03 Thread Thomas Weise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Weise updated FLINK-27479: - Issue Type: Bug (was: Improvement) > HybridSource refreshes availability future > -

[jira] [Assigned] (FLINK-27479) HybridSource refreshes availability future

2022-05-03 Thread Thomas Weise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Weise reassigned FLINK-27479: Assignee: Mason Chen > HybridSource refreshes availability future > -

[jira] [Commented] (FLINK-27479) HybridSource refreshes availability future

2022-05-03 Thread Thomas Weise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531436#comment-17531436 ] Thomas Weise commented on FLINK-27479: -- Of course, thanks for reporting the issue!

[jira] [Commented] (FLINK-25699) Use HashMap for MAP value constructors

2022-05-03 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531350#comment-17531350 ] Sergey Nuyanzin commented on FLINK-25699: - Hi [~twalthr]  since the PR is alread

[GitHub] [flink-web] CrynetLogistics commented on pull request #517: [FLINK-24370] Addition of blog post describing features and usage of the Async Sink…

2022-05-03 Thread GitBox
CrynetLogistics commented on PR #517: URL: https://github.com/apache/flink-web/pull/517#issuecomment-1116308044 @dannycranmer @sthm Thank you. I have made corresponding amendments to your review comments. Please kindly re-review and approve if happy. -- This is an automated message from t

[GitHub] [flink-web] CrynetLogistics commented on a diff in pull request #517: [FLINK-24370] Addition of blog post describing features and usage of the Async Sink…

2022-05-03 Thread GitBox
CrynetLogistics commented on code in PR #517: URL: https://github.com/apache/flink-web/pull/517#discussion_r863960180 ## _posts/2022-03-16-async-sink-base.md: ## @@ -0,0 +1,169 @@ +--- +layout: post +title: "The Generic Asynchronous Base Sink" Review Comment: Wanted to keep

[GitHub] [flink-web] CrynetLogistics commented on a diff in pull request #517: [FLINK-24370] Addition of blog post describing features and usage of the Async Sink…

2022-05-03 Thread GitBox
CrynetLogistics commented on code in PR #517: URL: https://github.com/apache/flink-web/pull/517#discussion_r863955894 ## _posts/2022-03-16-async-sink-base.md: ## @@ -0,0 +1,169 @@ +--- +layout: post +title: "The Generic Asynchronous Base Sink" +date: 2022-04-30 16:00:00 +authors

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #191: [FLINK-27303] Improve config cache settings + add cleanup

2022-05-03 Thread GitBox
gyfora commented on code in PR #191: URL: https://github.com/apache/flink-kubernetes-operator/pull/191#discussion_r863936131 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigManager.java: ## @@ -87,8 +89,15 @@ public Configuratio

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #191: [FLINK-27303] Improve config cache settings + add cleanup

2022-05-03 Thread GitBox
gyfora commented on code in PR #191: URL: https://github.com/apache/flink-kubernetes-operator/pull/191#discussion_r863934809 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigManager.java: ## @@ -87,8 +89,15 @@ public Configuratio

[jira] [Commented] (FLINK-27156) [FLIP-171] MongoDB implementation of Async Sink

2022-05-03 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-27156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531251#comment-17531251 ] Marco Zühlke commented on FLINK-27156: -- For MongoDB there already exist a Jira issu

[GitHub] [flink] JingGe commented on pull request #19624: [FLINK-27476][test] build import option only focuses on maven main class files

2022-05-03 Thread GitBox
JingGe commented on PR #19624: URL: https://github.com/apache/flink/pull/19624#issuecomment-111627 @Airblader After talking with @zentol offline and checking the archunit doc again. I think, theoretically, class path should only be managed by the test via `@AnalyzeClasses(...ImportOptio

[jira] [Commented] (FLINK-27468) Observing JobManager deployment. Previous status: MISSING

2022-05-03 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531243#comment-17531243 ] Yang Wang commented on FLINK-27468: --- I agree with [~gyfora] that we could not handle t

[GitHub] [flink] matriv commented on a diff in pull request #17677: [FLINK-24766][table] Ceiling/flooring dates to day returns wrong results

2022-05-03 Thread GitBox
matriv commented on code in PR #17677: URL: https://github.com/apache/flink/pull/17677#discussion_r863878838 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/TimeFunctionsITCase.java: ## @@ -425,4 +430,304 @@ private Stream temporalOverla

[jira] (FLINK-27468) Observing JobManager deployment. Previous status: MISSING

2022-05-03 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27468 ] Yang Wang deleted comment on FLINK-27468: --- was (Author: fly_in_gis): {{execution.shutdown-on-application-finish}} is introduced in 1.15.0. > Observing JobManager deployment. Previous status: M

[jira] [Commented] (FLINK-27468) Observing JobManager deployment. Previous status: MISSING

2022-05-03 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531242#comment-17531242 ] Yang Wang commented on FLINK-27468: --- {{execution.shutdown-on-application-finish}} is i

[GitHub] [flink] matriv commented on a diff in pull request #17677: [FLINK-24766][table] Ceiling/flooring dates to day returns wrong results

2022-05-03 Thread GitBox
matriv commented on code in PR #17677: URL: https://github.com/apache/flink/pull/17677#discussion_r863877260 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/FloorCeilCallGen.scala: ## @@ -105,13 +105,27 @@ class FloorCeilCallGen(

[GitHub] [flink] matriv commented on a diff in pull request #17677: [FLINK-24766][table] Ceiling/flooring dates to day returns wrong results

2022-05-03 Thread GitBox
matriv commented on code in PR #17677: URL: https://github.com/apache/flink/pull/17677#discussion_r863876855 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/FloorCeilCallGen.scala: ## @@ -105,13 +105,27 @@ class FloorCeilCallGen(

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a diff in pull request #191: [FLINK-27303] Improve config cache settings + add cleanup

2022-05-03 Thread GitBox
wangyang0918 commented on code in PR #191: URL: https://github.com/apache/flink-kubernetes-operator/pull/191#discussion_r863874296 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigManager.java: ## @@ -87,8 +89,15 @@ public Config

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a diff in pull request #191: [FLINK-27303] Improve config cache settings + add cleanup

2022-05-03 Thread GitBox
wangyang0918 commented on code in PR #191: URL: https://github.com/apache/flink-kubernetes-operator/pull/191#discussion_r863872666 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigManager.java: ## @@ -87,8 +89,15 @@ public Config

[GitHub] [flink] healchow commented on a diff in pull request #19629: [FLINK-27480][kafka] Explain possible metrics InstanceAlreadyExistsException in docs

2022-05-03 Thread GitBox
healchow commented on code in PR #19629: URL: https://github.com/apache/flink/pull/19629#discussion_r863859699 ## docs/content/docs/connectors/datastream/kafka.md: ## @@ -344,6 +344,16 @@ fetched from Kafka in ```SplitReader```. The state of split, or current progress consumin

[GitHub] [flink] snuyanzin commented on a diff in pull request #17677: [FLINK-24766][table] Ceiling/flooring dates to day returns wrong results

2022-05-03 Thread GitBox
snuyanzin commented on code in PR #17677: URL: https://github.com/apache/flink/pull/17677#discussion_r863851471 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/TimeFunctionsITCase.java: ## @@ -425,4 +430,304 @@ private Stream temporalOve

[GitHub] [flink] snuyanzin commented on a diff in pull request #17677: [FLINK-24766][table] Ceiling/flooring dates to day returns wrong results

2022-05-03 Thread GitBox
snuyanzin commented on code in PR #17677: URL: https://github.com/apache/flink/pull/17677#discussion_r863847618 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/TimeFunctionsITCase.java: ## @@ -425,4 +430,304 @@ private Stream temporalOve

[jira] [Commented] (FLINK-27435) Kubernetes Operator keeps savepoint history

2022-05-03 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531225#comment-17531225 ] Yang Wang commented on FLINK-27435: --- I think adding the savepoint history to the statu

[jira] [Commented] (FLINK-27420) Suspended SlotManager fail to reregister metrics when started again

2022-05-03 Thread Nicolaus Weidner (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531222#comment-17531222 ] Nicolaus Weidner commented on FLINK-27420: -- Looks fine on master, but in the ba

[GitHub] [flink-connector-elasticsearch] afedulov commented on a diff in pull request #15: [FLINK-27475][Build] Clean-up unused Maven dependencies, plugins and profiles

2022-05-03 Thread GitBox
afedulov commented on code in PR #15: URL: https://github.com/apache/flink-connector-elasticsearch/pull/15#discussion_r863822433 ## flink-connector-elasticsearch7/pom.xml: ## @@ -81,20 +81,6 @@ under the License. org.elasticsearch.client

[GitHub] [flink-connector-elasticsearch] fapaul commented on a diff in pull request #15: [FLINK-27475][Build] Clean-up unused Maven dependencies, plugins and profiles

2022-05-03 Thread GitBox
fapaul commented on code in PR #15: URL: https://github.com/apache/flink-connector-elasticsearch/pull/15#discussion_r863795387 ## pom.xml: ## @@ -806,32 +436,6 @@ under the License. maven-shade-plugin

[jira] [Updated] (FLINK-27451) Enable the validator plugin in webhook

2022-05-03 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang updated FLINK-27451: -- Fix Version/s: kubernetes-operator-1.0.0 > Enable the validator plugin in webhook > --

[jira] [Assigned] (FLINK-27451) Enable the validator plugin in webhook

2022-05-03 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang reassigned FLINK-27451: - Assignee: Aitozi > Enable the validator plugin in webhook > ---

[jira] [Commented] (FLINK-27458) Expose allowNonRestoredState flag in JobSpec

2022-05-03 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531201#comment-17531201 ] Yang Wang commented on FLINK-27458: --- This is a reasonable improvement. +1 to introduce

[jira] [Assigned] (FLINK-27337) Prevent session cluster to be deleted when there are running jobs

2022-05-03 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang reassigned FLINK-27337: - Assignee: Aitozi > Prevent session cluster to be deleted when there are running jobs >

[jira] [Commented] (FLINK-27461) Add a convenient way to set userAgent for the kubeclient

2022-05-03 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531194#comment-17531194 ] Yang Wang commented on FLINK-27461: --- Nice suggestion. Actually, we also find the user

[jira] [Assigned] (FLINK-27474) Use Hugo build information to derive current branch for externally hosted documentation

2022-05-03 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-27474: -- Assignee: Martijn Visser > Use Hugo build information to derive current branch for ex

[jira] [Assigned] (FLINK-27461) Add a convenient way to set userAgent for the kubeclient

2022-05-03 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang reassigned FLINK-27461: - Assignee: Aitozi > Add a convenient way to set userAgent for the kubeclient > -

[jira] [Created] (FLINK-27482) Dashboard not showing after installation

2022-05-03 Thread Aarsh Shah (Jira)
Aarsh Shah created FLINK-27482: -- Summary: Dashboard not showing after installation Key: FLINK-27482 URL: https://issues.apache.org/jira/browse/FLINK-27482 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-26803) Merge small ChannelState file for Unaligned Checkpoint

2022-05-03 Thread fanrui (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531182#comment-17531182 ] fanrui commented on FLINK-26803: Hi [~pnowojski] you're right. After my research, 15K o

[GitHub] [flink] fapaul commented on a diff in pull request #19588: [FLINK-XXXX] [core] Add Generator source

2022-05-03 Thread GitBox
fapaul commented on code in PR #19588: URL: https://github.com/apache/flink/pull/19588#discussion_r863728326 ## flink-core/src/main/java/org/apache/flink/util/NewSplittableIterator.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

[GitHub] [flink] flinkbot commented on pull request #19629: [FLINK-27480][kafka] Explain possible metrics InstanceAlreadyExistsException in docs

2022-05-03 Thread GitBox
flinkbot commented on PR #19629: URL: https://github.com/apache/flink/pull/19629#issuecomment-1116046941 ## CI report: * 5e3a9d462a25460952c9747ead53fda7d5714c28 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] fapaul commented on a diff in pull request #19588: [FLINK-XXXX] [core] Add Generator source

2022-05-03 Thread GitBox
fapaul commented on code in PR #19588: URL: https://github.com/apache/flink/pull/19588#discussion_r863724935 ## flink-core/src/main/java/org/apache/flink/api/connector/source/lib/GeneratorSource.java: ## @@ -0,0 +1,245 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (FLINK-26947) Add ARRAY_CONTAINS supported in SQL & Table API

2022-05-03 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531170#comment-17531170 ] Timo Walther commented on FLINK-26947: -- So are you fine with the current implementa

[jira] [Updated] (FLINK-27480) KafkaSources sharing the groupId might lead to InstanceAlreadyExistException warning

2022-05-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27480: --- Labels: pull-request-available (was: ) > KafkaSources sharing the groupId might lead to Ins

[GitHub] [flink] fapaul commented on pull request #19629: [FLINK-27480][kafka] Explain possible metrics InstanceAlreadyExistsException in docs

2022-05-03 Thread GitBox
fapaul commented on PR #19629: URL: https://github.com/apache/flink/pull/19629#issuecomment-1116044205 I open backports to 1.15 and 1.14 once approved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [flink] fapaul opened a new pull request, #19629: [FLINK-27480][kafka] Explain possible metrics InstanceAlreadyExistsException in docs

2022-05-03 Thread GitBox
fapaul opened a new pull request, #19629: URL: https://github.com/apache/flink/pull/19629 …ception in docs ## What is the purpose of the change Multiple users were seeing a problem during metrics registration of the underlying KafkaConsumer of the KafkaSource. This PR a

[GitHub] [flink] afedulov commented on a diff in pull request #19588: [FLINK-XXXX] [core] Add Generator source

2022-05-03 Thread GitBox
afedulov commented on code in PR #19588: URL: https://github.com/apache/flink/pull/19588#discussion_r863717974 ## flink-core/src/main/java/org/apache/flink/util/NewSplittableIterator.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [flink] afedulov commented on a diff in pull request #19588: [FLINK-XXXX] [core] Add Generator source

2022-05-03 Thread GitBox
afedulov commented on code in PR #19588: URL: https://github.com/apache/flink/pull/19588#discussion_r863717974 ## flink-core/src/main/java/org/apache/flink/util/NewSplittableIterator.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [flink] afedulov commented on a diff in pull request #19588: [FLINK-XXXX] [core] Add Generator source

2022-05-03 Thread GitBox
afedulov commented on code in PR #19588: URL: https://github.com/apache/flink/pull/19588#discussion_r863717635 ## flink-core/src/main/java/org/apache/flink/api/connector/source/lib/GeneratorSource.java: ## @@ -0,0 +1,245 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [flink-kubernetes-operator] gyfora opened a new pull request, #191: [FLINK-27303] Improve config cache settings + add cleanup

2022-05-03 Thread GitBox
gyfora opened a new pull request, #191: URL: https://github.com/apache/flink-kubernetes-operator/pull/191 This adds the missing cleanup logic + makes size/expiration configurable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Updated] (FLINK-27475) Clean-up unused Maven settings from flink-connector-elasticsearch

2022-05-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27475: --- Labels: pull-request-available (was: ) > Clean-up unused Maven settings from flink-connecto

[GitHub] [flink-connector-elasticsearch] MartijnVisser opened a new pull request, #15: [FLINK-27475][Build] Clean-up unused Maven dependencies, plugins and profiles

2022-05-03 Thread GitBox
MartijnVisser opened a new pull request, #15: URL: https://github.com/apache/flink-connector-elasticsearch/pull/15 * First iteration of clean-up of Maven POM files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[jira] [Closed] (FLINK-27362) Support restartNonce semantics in session job

2022-05-03 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-27362. -- Resolution: Fixed merged to main 399887eb058bb8198f6b2b4cc8b1d4694c04dca3 > Support restartNonce sema

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #185: [FLINK-27362] Support restartNonce semantics in session job

2022-05-03 Thread GitBox
gyfora merged PR #185: URL: https://github.com/apache/flink-kubernetes-operator/pull/185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [flink] RocMarshal commented on a diff in pull request #18986: [FLINK-26496][flink-yarn-test] [JUnit5 Migration] Module: flink-yarn-test

2022-05-03 Thread GitBox
RocMarshal commented on code in PR #18986: URL: https://github.com/apache/flink/pull/18986#discussion_r863685388 ## flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionCapacitySchedulerITCase.java: ## @@ -445,39 +444,51 @@ private static Map getFlinkConfig(final Str

[GitHub] [flink] fapaul commented on a diff in pull request #19588: [FLINK-XXXX] [core] Add Generator source

2022-05-03 Thread GitBox
fapaul commented on code in PR #19588: URL: https://github.com/apache/flink/pull/19588#discussion_r863672111 ## flink-core/src/main/java/org/apache/flink/api/connector/source/lib/GeneratorSource.java: ## @@ -0,0 +1,245 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [flink] zentol commented on a diff in pull request #18986: [FLINK-26496][flink-yarn-test] [JUnit5 Migration] Module: flink-yarn-test

2022-05-03 Thread GitBox
zentol commented on code in PR #18986: URL: https://github.com/apache/flink/pull/18986#discussion_r863668139 ## flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java: ## @@ -173,10 +172,10 @@ public abstract class YarnTestBase extends TestLogger { };

[jira] [Commented] (FLINK-26947) Add ARRAY_CONTAINS supported in SQL & Table API

2022-05-03 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531135#comment-17531135 ] dalongliu commented on FLINK-26947: --- [~twalthr] Thanks for your contribution, if we ha

[jira] [Closed] (FLINK-27470) [JUnit5 Migration] Module: flink-statebackend-heap-spillable

2022-05-03 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-27470. Resolution: Fixed master: 90e98ba7c858b740365fc9ffdf0afc7d791373f2 > [JUnit5 Migration] M

[GitHub] [flink] zentol merged pull request #19625: [FLINK-27470][state][tests] Migrate test to JUnit5

2022-05-03 Thread GitBox
zentol merged PR #19625: URL: https://github.com/apache/flink/pull/19625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[GitHub] [flink] matriv commented on a diff in pull request #17677: [FLINK-24766][table] Ceiling/flooring dates to day returns wrong results

2022-05-03 Thread GitBox
matriv commented on code in PR #17677: URL: https://github.com/apache/flink/pull/17677#discussion_r863627842 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/TimeFunctionsITCase.java: ## @@ -425,4 +430,304 @@ private Stream temporalOverla

[GitHub] [flink] matriv commented on a diff in pull request #17677: [FLINK-24766][table] Ceiling/flooring dates to day returns wrong results

2022-05-03 Thread GitBox
matriv commented on code in PR #17677: URL: https://github.com/apache/flink/pull/17677#discussion_r863626617 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/TimeFunctionsITCase.java: ## @@ -425,4 +430,304 @@ private Stream temporalOverla

[GitHub] [flink] afedulov commented on a diff in pull request #19552: [FLINK-27185][connectors][formats] Convert formats and connectors modules to assertj

2022-05-03 Thread GitBox
afedulov commented on code in PR #19552: URL: https://github.com/apache/flink/pull/19552#discussion_r863602581 ## flink-formats/flink-csv/src/test/java/org/apache/flink/formats/csv/CsvRowDataSerDeSchemaTest.java: ## @@ -61,11 +61,9 @@ import static org.apache.flink.table.data.S

[GitHub] [flink] afedulov commented on a diff in pull request #19552: [FLINK-27185][connectors][formats] Convert formats and connectors modules to assertj

2022-05-03 Thread GitBox
afedulov commented on code in PR #19552: URL: https://github.com/apache/flink/pull/19552#discussion_r863600886 ## flink-formats/flink-csv/src/test/java/org/apache/flink/formats/csv/CsvRowDataSerDeSchemaTest.java: ## @@ -358,12 +354,8 @@ public void testSerializationWithTypesMism

[jira] [Closed] (FLINK-27061) Improve the ArchUnit test infra in the external elasticsearch connector

2022-05-03 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-27061. -- Fix Version/s: 1.16.0 Resolution: Fixed Fixed in main: f966128604c565b68bd16de9b74d008b

[GitHub] [flink-connector-elasticsearch] MartijnVisser merged pull request #10: [FLINK-27061] archunit test for production code

2022-05-03 Thread GitBox
MartijnVisser merged PR #10: URL: https://github.com/apache/flink-connector-elasticsearch/pull/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues

[jira] [Commented] (FLINK-26584) State Processor API fails to write savepoints exceeding 5MB

2022-05-03 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531108#comment-17531108 ] Martijn Visser commented on FLINK-26584: Got it, thank you! > State Processor A

[jira] [Closed] (FLINK-26584) State Processor API fails to write savepoints exceeding 5MB

2022-05-03 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-26584. -- Resolution: Duplicate > State Processor API fails to write savepoints exceeding 5MB >

[GitHub] [flink] JingGe commented on pull request #19624: [FLINK-27476][test] build import option only focuses on maven main class files

2022-05-03 Thread GitBox
JingGe commented on PR #19624: URL: https://github.com/apache/flink/pull/19624#issuecomment-1115868753 Conceptually, you are right. As far as I understood, they have two different responsibilities. `SourcePredicates` are used to build the rules with their default classes scope. Same Rule wi

[jira] [Updated] (FLINK-27481) Flink checkpoints are very slow after upgrading from Flink 1.13.1 to Flink 1.14.3

2022-05-03 Thread Monika Hristova (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Monika Hristova updated FLINK-27481: Description: I am experiencing extremely slow checkpoints after upgrading flink version fr

[jira] [Updated] (FLINK-27481) Flink checkpoints are very slow after upgrading from Flink 1.13.1 to Flink 1.14.3

2022-05-03 Thread Monika Hristova (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Monika Hristova updated FLINK-27481: Affects Version/s: 1.14.3 > Flink checkpoints are very slow after upgrading from Flink 1.1

[jira] [Commented] (FLINK-26803) Merge small ChannelState file for Unaligned Checkpoint

2022-05-03 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531097#comment-17531097 ] Piotr Nowojski commented on FLINK-26803: If it's just a single file per {{Operat

[jira] [Created] (FLINK-27481) Flink checkpoints are very slow after upgrading from Flink 1.13.1 to Flink 1.14.3

2022-05-03 Thread Monika Hristova (Jira)
Monika Hristova created FLINK-27481: --- Summary: Flink checkpoints are very slow after upgrading from Flink 1.13.1 to Flink 1.14.3 Key: FLINK-27481 URL: https://issues.apache.org/jira/browse/FLINK-27481

[GitHub] [flink] zentol commented on pull request #19624: [FLINK-27476][test] build import option only focuses on maven main class files

2022-05-03 Thread GitBox
zentol commented on PR #19624: URL: https://github.com/apache/flink/pull/19624#issuecomment-1115850613 I don't necessarily mind it, but do think that we should figure out the responsibilities a bit. Currently, a test can select certain classes to test via the ImportOptions. This newl

[jira] [Created] (FLINK-27480) KafkaSources sharing the groupId might lead to InstanceAlreadyExistException warning

2022-05-03 Thread Fabian Paul (Jira)
Fabian Paul created FLINK-27480: --- Summary: KafkaSources sharing the groupId might lead to InstanceAlreadyExistException warning Key: FLINK-27480 URL: https://issues.apache.org/jira/browse/FLINK-27480 Pr

[jira] [Assigned] (FLINK-27480) KafkaSources sharing the groupId might lead to InstanceAlreadyExistException warning

2022-05-03 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Paul reassigned FLINK-27480: --- Assignee: Fabian Paul > KafkaSources sharing the groupId might lead to InstanceAlreadyExist

[GitHub] [flink] JingGe commented on pull request #19624: [FLINK-27476][test] build import option only focuses on maven main class files

2022-05-03 Thread GitBox
JingGe commented on PR #19624: URL: https://github.com/apache/flink/pull/19624#issuecomment-1115840104 > Have you tried whether `ImportOption.DoNotIncludeJars` would fix the issue? Yes, that could fix it. But I think the import option I built in this PR is still very helpful for the f

[jira] [Closed] (FLINK-27352) [JUnit5 Migration] Module: flink-json

2022-05-03 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-27352. Fix Version/s: 1.16.0 Resolution: Fixed master: 890abfb850d6a94b9faff81de0a81ad5914

[GitHub] [flink] zentol merged pull request #19590: [FLINK-27352][tests] [JUnit5 Migration] Module: flink-json

2022-05-03 Thread GitBox
zentol merged PR #19590: URL: https://github.com/apache/flink/pull/19590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

  1   2   >