[GitHub] [flink] shuiqiangchen commented on pull request #19958: [FLINK-27159][table-api] Support first_value/last_value in the Table API

2022-06-15 Thread GitBox
shuiqiangchen commented on PR #19958: URL: https://github.com/apache/flink/pull/19958#issuecomment-1157258316 @dianfu Thanks, I will refer to those commits in the ticket you mentioned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] dusukang commented on pull request #19741: [FLINK-27794][connectors/jdbc]Fix the bug of wrong primary key in MysqlCatalog

2022-06-15 Thread GitBox
dusukang commented on PR #19741: URL: https://github.com/apache/flink/pull/19741#issuecomment-1157248524 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-28087) Add validation for the meta.name of FlinkDeployment CR

2022-06-15 Thread Fred k (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fred k updated FLINK-28087: --- Description: The meta.name of FlinkDeployment CR meta.name must be match the regex: {code:java}

[jira] [Updated] (FLINK-28087) Add validation for meta.name of FlinkDeployment CR

2022-06-15 Thread Fred k (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fred k updated FLINK-28087: --- Description: The meta.name of FlinkDeployment CR meta.name must be match the regex: {{}} {code:java}

[jira] [Updated] (FLINK-28087) Add validation for the meta.name of FlinkDeployment CR

2022-06-15 Thread Fred k (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fred k updated FLINK-28087: --- Summary: Add validation for the meta.name of FlinkDeployment CR (was: Add validation for meta.name of

[jira] [Updated] (FLINK-28087) Add validation for meta.name of FlinkDeployment CR

2022-06-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28087: --- Labels: pull-request-available (was: ) > Add validation for meta.name of FlinkDeployment

[GitHub] [flink-kubernetes-operator] Grypse opened a new pull request, #270: [FLINK-28087]add validation for the meta.name of FlinkDeployment CR.

2022-06-15 Thread GitBox
Grypse opened a new pull request, #270: URL: https://github.com/apache/flink-kubernetes-operator/pull/270 The meta.name of FlinkDeployment CR meta.name must be match the regex: ` '[a-z]([-a-z0-9]*[a-z0-9])?'` By RRC-1035, a DNS-1035 label must consist of lower case alphanumeric

[GitHub] [flink] dianfu commented on a diff in pull request #19295: [FLINK-26941][cep] Support Pattern end with notFollowedBy with window

2022-06-15 Thread GitBox
dianfu commented on code in PR #19295: URL: https://github.com/apache/flink/pull/19295#discussion_r898692689 ## docs/content/docs/libs/cep.md: ## @@ -718,6 +718,35 @@ next.within(Time.seconds(10)) {{< /tab >}} {{< /tabs >}} +Notice that A pattern sequence can end in

[GitHub] [flink] dianfu commented on a diff in pull request #19295: [FLINK-26941][cep] Support Pattern end with notFollowedBy with window

2022-06-15 Thread GitBox
dianfu commented on code in PR #19295: URL: https://github.com/apache/flink/pull/19295#discussion_r898652853 ## flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java: ## @@ -157,11 +157,8 @@ public static boolean canProduceEmptyMatches(final

[GitHub] [flink] liuzhuang2017 commented on pull request #19966: [hotfix][docs] Fix the Intellij key nouns.

2022-06-15 Thread GitBox
liuzhuang2017 commented on PR #19966: URL: https://github.com/apache/flink/pull/19966#issuecomment-1157228755 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] luoyuxia commented on a diff in pull request #19851: [FLINK-20765][table-planner]The nullability of result for boolean expression in ScalarOperatorGens should be compatible with the r

2022-06-15 Thread GitBox
luoyuxia commented on code in PR #19851: URL: https://github.com/apache/flink/pull/19851#discussion_r898680314 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala: ## @@ -351,9 +351,11 @@ object

[GitHub] [flink] luoyuxia commented on a diff in pull request #19851: [FLINK-20765][table-planner]The nullability of result for boolean expression in ScalarOperatorGens should be compatible with the r

2022-06-15 Thread GitBox
luoyuxia commented on code in PR #19851: URL: https://github.com/apache/flink/pull/19851#discussion_r898680313 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala: ## @@ -351,9 +351,11 @@ object

[GitHub] [flink] luoyuxia commented on a diff in pull request #19851: [FLINK-20765][table-planner]The nullability of result for boolean expression in ScalarOperatorGens should be compatible with the r

2022-06-15 Thread GitBox
luoyuxia commented on code in PR #19851: URL: https://github.com/apache/flink/pull/19851#discussion_r898679763 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/utils/ScalarOperatorsTestBase.scala: ## @@ -67,8 +67,8 @@ abstract class

[jira] [Updated] (FLINK-28087) Add validation for meta.name of FlinkDeployment CR

2022-06-15 Thread Fred k (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fred k updated FLINK-28087: --- Description: The FlinkDeployment CR meta.name must be match the regex: {code:java}

[jira] [Comment Edited] (FLINK-27953) using the original order to add the primary key in PushProjectIntoTableSourceScanRule

2022-06-15 Thread zoucao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554894#comment-17554894 ] zoucao edited comment on FLINK-27953 at 6/16/22 3:57 AM: - Hi [~godfreyhe], could

[jira] [Commented] (FLINK-27953) using the original order to add the primary key in PushProjectIntoTableSourceScanRule

2022-06-15 Thread zoucao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554894#comment-17554894 ] zoucao commented on FLINK-27953: Hi [~godfrey], could you have time to take a look? > using the

[jira] [Updated] (FLINK-28087) Add validation for meta.name of FlinkDeployment CR

2022-06-15 Thread Fred k (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fred k updated FLINK-28087: --- Summary: Add validation for meta.name of FlinkDeployment CR (was: FlinkDeployment meta.name validation) >

[GitHub] [flink] lincoln-lil commented on pull request #19942: [FLINK-28019][table] fix error when retract a staled record if state ttl enabled in RetractableTopNFunction

2022-06-15 Thread GitBox
lincoln-lil commented on PR #19942: URL: https://github.com/apache/flink/pull/19942#issuecomment-1157199426 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-28087) FlinkDeployment meta.name validation

2022-06-15 Thread Fred k (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fred k updated FLINK-28087: --- Summary: FlinkDeployment meta.name validation (was: FlinkDeployment name validation) > FlinkDeployment

[jira] [Assigned] (FLINK-27987) Let FileSystemTableSource extend from SupportsStatisticReport

2022-06-15 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he reassigned FLINK-27987: -- Assignee: godfrey he (was: Yunhong Zheng) > Let FileSystemTableSource extend from

[jira] [Updated] (FLINK-28087) FlinkDeployment name validation

2022-06-15 Thread Fred k (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fred k updated FLINK-28087: --- Description: The FlinkDeployment CR meta.name must be match the regex: {code:java}

[jira] [Updated] (FLINK-28074) show statistics details for DESCRIBE EXTENDED

2022-06-15 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-28074: --- Description: Currently, DESCRIBE command only show the schema of a given table, EXTENDED does not

[jira] [Updated] (FLINK-28087) FlinkDeployment name validation

2022-06-15 Thread Fred k (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fred k updated FLINK-28087: --- Attachment: operator-flink.jpg > FlinkDeployment name validation > --- > >

[jira] [Created] (FLINK-28087) FlinkDeployment name validation

2022-06-15 Thread Fred k (Jira)
Fred k created FLINK-28087: -- Summary: FlinkDeployment name validation Key: FLINK-28087 URL: https://issues.apache.org/jira/browse/FLINK-28087 Project: Flink Issue Type: Improvement

[GitHub] [flink] flinkbot commented on pull request #19984: [hotfix][tests] test the serialized object in GlobFilePathFilterTest#testGlobFilterSerializable

2022-06-15 Thread GitBox
flinkbot commented on PR #19984: URL: https://github.com/apache/flink/pull/19984#issuecomment-1157186972 ## CI report: * 6726e9d27b74ebe57e9e986ebc4a8fe8a3afc628 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] zhoulii opened a new pull request, #19984: [hotfix][tests] test the serialized object in GlobFilePathFilterTest#testGlobFilterSerializable

2022-06-15 Thread GitBox
zhoulii opened a new pull request, #19984: URL: https://github.com/apache/flink/pull/19984 ## What is the purpose of the change - test the serialized object in GlobFilePathFilterTest#testGlobFilterSerializable - Rework GlobFilePathFilterTest to be based on AssertJ ##

[GitHub] [flink-web] gaoyunhaii commented on pull request #545: Add blogs for FLIP-147 support checkpoints after tasks finished

2022-06-15 Thread GitBox
gaoyunhaii commented on PR #545: URL: https://github.com/apache/flink-web/pull/545#issuecomment-1157179944 Thanks @zhuzhurk @wanglijie95 for the review! I have updated the blogs according to the comments and also rewrite some part. -- This is an automated message from the Apache Git

[jira] [Commented] (FLINK-25655) FlinkKafkaInternalProducerITCase.testInitTransactionId failed on azure

2022-06-15 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554883#comment-17554883 ] lincoln lee commented on FLINK-25655: - Any new progress here? I encountered two in a row, recent

[GitHub] [flink-web] gaoyunhaii commented on pull request #546: Add blogs for FLIP-187 adaptive batch scheduler

2022-06-15 Thread GitBox
gaoyunhaii commented on PR #546: URL: https://github.com/apache/flink-web/pull/546#issuecomment-1157174790 Thanks @wanglijie95 for the update! LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Created] (FLINK-28086) Table Store Catalog supports partition methods

2022-06-15 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-28086: Summary: Table Store Catalog supports partition methods Key: FLINK-28086 URL: https://issues.apache.org/jira/browse/FLINK-28086 Project: Flink Issue Type:

[GitHub] [flink] imaffe commented on a diff in pull request #19973: [FLINK-28082][Connector/Pulsar] Add end-to-end encryption support for Pulsar connector.

2022-06-15 Thread GitBox
imaffe commented on code in PR #19973: URL: https://github.com/apache/flink/pull/19973#discussion_r898643192 ## flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/PulsarSourceBuilder.java: ## @@ -369,6 +373,18 @@ public

[GitHub] [flink] flinkbot commented on pull request #19983: [FLINK-27878][datastream] Add Retry Support For Async I/O In DataStream API

2022-06-15 Thread GitBox
flinkbot commented on PR #19983: URL: https://github.com/apache/flink/pull/19983#issuecomment-1157166737 ## CI report: * 7cac33be1271b73b8f28069ee17db53a790bef29 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] imaffe commented on pull request #19974: [FLINK-28083][Connector/Pulsar] Object-reusing for Pulsar source

2022-06-15 Thread GitBox
imaffe commented on PR #19974: URL: https://github.com/apache/flink/pull/19974#issuecomment-1157166125 I'm not very familiar with the object-reuse deserialization schema here. Could you describe briefly why we introduce this change ? -- This is an automated message from the Apache Git

[GitHub] [flink] godfreyhe commented on pull request #19939: [FLINK-27983][FLINK-27984][FLINK-27985] Introduce SupportsStatisticsReport, FileBasedStatisticsReportableDecodingFormat, FlinkRecomputeStat

2022-06-15 Thread GitBox
godfreyhe commented on PR #19939: URL: https://github.com/apache/flink/pull/19939#issuecomment-1157166185 Thanks for the review, I will merge it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (FLINK-27878) Add Retry Support For Async I/O In DataStream API

2022-06-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27878: --- Labels: pull-request-available (was: ) > Add Retry Support For Async I/O In DataStream API

[GitHub] [flink] lincoln-lil opened a new pull request, #19983: [FLINK-27878][datastream] Add Retry Support For Async I/O In DataStream API

2022-06-15 Thread GitBox
lincoln-lil opened a new pull request, #19983: URL: https://github.com/apache/flink/pull/19983 ## What is the purpose of the change This is the implementation of [FLIP-232](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=211883963) ## Brief change log * add new

[GitHub] [flink] imaffe commented on pull request #19977: [FLINK-28084][Connector/Pulsar] Remove the reconsume later logic for Pulsar unordered reader.

2022-06-15 Thread GitBox
imaffe commented on PR #19977: URL: https://github.com/apache/flink/pull/19977#issuecomment-1157163612 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [flink] imaffe commented on pull request #19978: [FLINK-27881][Connector/Pulsar] Never return null for PulsarMessageBuilder

2022-06-15 Thread GitBox
imaffe commented on PR #19978: URL: https://github.com/apache/flink/pull/19978#issuecomment-1157163110 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [flink] flinkbot commented on pull request #19982: [BP-1.14][FLINK-27762][connector/kafka] Catch WakeupException and retry KafkaConsumer invocations in split assignment

2022-06-15 Thread GitBox
flinkbot commented on PR #19982: URL: https://github.com/apache/flink/pull/19982#issuecomment-1157162626 ## CI report: * 698c594f054ff7ef72dc5982dc71e7fcd2d6d359 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] Aitozi commented on pull request #19840: [FLINK-24713][Runtime/Coordination] Support the initial delay for SlotManager to wait fo…

2022-06-15 Thread GitBox
Aitozi commented on PR #19840: URL: https://github.com/apache/flink/pull/19840#issuecomment-1157161267 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] Aitozi commented on pull request #19840: [FLINK-24713][Runtime/Coordination] Support the initial delay for SlotManager to wait fo…

2022-06-15 Thread GitBox
Aitozi commented on PR #19840: URL: https://github.com/apache/flink/pull/19840#issuecomment-1157161191 The failed test with unfinished test case `org.apache.flink.test.checkpointing.StreamFaultToleranceTestBase.runCheckpointedProgram` can finish locally -- This is an automated message

[GitHub] [flink] flinkbot commented on pull request #19981: [BP-1.15][FLINK-27762][connector/kafka] Catch WakeupException and retry KafkaConsumer invocations in split assignment

2022-06-15 Thread GitBox
flinkbot commented on PR #19981: URL: https://github.com/apache/flink/pull/19981#issuecomment-1157160602 ## CI report: * 7544a90ee0babb2b5b087d4cab91b4f6442b968b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #19980: [BP-1.15][FLINK-27041][connector/kafka] Catch IllegalStateException in KafkaPartitionSplitReader.fetch() to handle no valid partition case

2022-06-15 Thread GitBox
flinkbot commented on PR #19980: URL: https://github.com/apache/flink/pull/19980#issuecomment-1157160564 ## CI report: * 6e88bc91064cdec9d581add9928c3d9f05e835af UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] PatrickRen opened a new pull request, #19982: [FLINK-27762][connector/kafka] Catch WakeupException and retry KafkaConsumer invocations in split assignment

2022-06-15 Thread GitBox
PatrickRen opened a new pull request, #19982: URL: https://github.com/apache/flink/pull/19982 Unchanged back port of #19828 on release-1.14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] imaffe commented on a diff in pull request #19976: [FLINK-27400][Connector/Pulsar] Never subscribe the Pulsar internal topics by using regex

2022-06-15 Thread GitBox
imaffe commented on code in PR #19976: URL: https://github.com/apache/flink/pull/19976#discussion_r898633161 ## flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/enumerator/topic/TopicNameUtils.java: ## @@ -30,13 +31,35 @@ import

[GitHub] [flink] PatrickRen opened a new pull request, #19981: [BP-1.15][FLINK-27762][connector/kafka] Catch WakeupException and retry KafkaConsumer invocations in split assignment

2022-06-15 Thread GitBox
PatrickRen opened a new pull request, #19981: URL: https://github.com/apache/flink/pull/19981 Unchanged back port of #19828 on release-1.15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] PatrickRen opened a new pull request, #19980: [BP-1.15][FLINK-27041][connector/kafka] Catch IllegalStateException in KafkaPartitionSplitReader.fetch() to handle no valid partition cas

2022-06-15 Thread GitBox
PatrickRen opened a new pull request, #19980: URL: https://github.com/apache/flink/pull/19980 Unchanged back port of #19456 on release-1.15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] flinkbot commented on pull request #19979: [BP-1.14][FLINK-27041][connector/kafka] Catch IllegalStateException in KafkaPartitionSplitReader.fetch() to handle no valid partition case

2022-06-15 Thread GitBox
flinkbot commented on PR #19979: URL: https://github.com/apache/flink/pull/19979#issuecomment-1157156391 ## CI report: * 79f25b1182a1f059b30603b78e95f9ce47c4f61b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] imaffe commented on a diff in pull request #19099: [FLINK-26182][Connector/pulsar] Create a e2e tests for Pulsar sink.

2022-06-15 Thread GitBox
imaffe commented on code in PR #19099: URL: https://github.com/apache/flink/pull/19099#discussion_r898626758 ## flink-connectors/flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/testutils/PulsarTestContext.java: ## @@ -19,44 +19,61 @@ package

[GitHub] [flink] PatrickRen opened a new pull request, #19979: [BP-1.14][FLINK-27041][connector/kafka] Catch IllegalStateException in KafkaPartitionSplitReader.fetch() to handle no valid partition cas

2022-06-15 Thread GitBox
PatrickRen opened a new pull request, #19979: URL: https://github.com/apache/flink/pull/19979 Unchanged back port of #19456 on release-1.14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (FLINK-28077) KeyedStateCheckpointingITCase.testWithMemoryBackendSync runs into timeout

2022-06-15 Thread fanrui (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554862#comment-17554862 ] fanrui commented on FLINK-28077: Hi [~mapohl] [~chesnay] , thanks for this information, I will take a

[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #158: [FLINK-28079] Check Hive DDL against table store schema when creating table

2022-06-15 Thread GitBox
tsreaper commented on code in PR #158: URL: https://github.com/apache/flink-table-store/pull/158#discussion_r898626398 ## flink-table-store-hive/src/main/java/org/apache/flink/table/store/hive/HiveSchema.java: ## @@ -73,11 +90,134 @@ public static HiveSchema extract(Properties

[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #158: [FLINK-28079] Check Hive DDL against table store schema when creating table

2022-06-15 Thread GitBox
tsreaper commented on code in PR #158: URL: https://github.com/apache/flink-table-store/pull/158#discussion_r898626041 ## flink-table-store-hive/src/main/java/org/apache/flink/table/store/hive/HiveSchema.java: ## @@ -18,50 +18,67 @@ package org.apache.flink.table.store.hive;

[GitHub] [flink] deadwind4 commented on a diff in pull request #19777: [hotfix][connector/pulsar][docs] Update atEventTime to atPublishTime in JavaDoc

2022-06-15 Thread GitBox
deadwind4 commented on code in PR #19777: URL: https://github.com/apache/flink/pull/19777#discussion_r898621744 ## flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/PulsarSourceBuilder.java: ## @@ -107,7 +107,7 @@ *

[GitHub] [flink] deadwind4 commented on a diff in pull request #19777: [hotfix][connector/pulsar][docs] Update atEventTime to atPublishTime in JavaDoc

2022-06-15 Thread GitBox
deadwind4 commented on code in PR #19777: URL: https://github.com/apache/flink/pull/19777#discussion_r898621580 ## flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/PulsarSourceBuilder.java: ## @@ -107,7 +107,7 @@ *

[GitHub] [flink] liujiawinds commented on pull request #19965: [FLINK-22920][formats] Fix guava version conflict in `flink-orc` and `flink-parquet` module

2022-06-15 Thread GitBox
liujiawinds commented on PR #19965: URL: https://github.com/apache/flink/pull/19965#issuecomment-1157128850 @JingsongLi Could you review this pr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink-ml] yunfengzhou-hub commented on pull request #109: [hotfix][flink-ml-lib][syntax]fix the forgotten static import method compareResultCollections from TestBaseUtils

2022-06-15 Thread GitBox
yunfengzhou-hub commented on PR #109: URL: https://github.com/apache/flink-ml/pull/109#issuecomment-1157125976 Got it. From the information provided in [FLINK-27454](https://issues.apache.org/jira/browse/FLINK-27454) it seems that AbstractTestBase would still extend TestBaseUtils until

[GitHub] [flink] flinkbot commented on pull request #19978: [FLINK-27881][Connector/Pulsar] Never return null for PulsarMessageBuilder

2022-06-15 Thread GitBox
flinkbot commented on PR #19978: URL: https://github.com/apache/flink/pull/19978#issuecomment-1157016182 ## CI report: * a0384dee5b76b645ec0947dd208ce027cbce9717 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Comment Edited] (FLINK-27736) Pulsar sink catch watermark error

2022-06-15 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554812#comment-17554812 ] Yufan Sheng edited comment on FLINK-27736 at 6/15/22 10:33 PM: --- Tks for

[jira] [Commented] (FLINK-27736) Pulsar sink catch watermark error

2022-06-15 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554812#comment-17554812 ] Yufan Sheng commented on FLINK-27736: - Tks for your report This is a known bug and fixed in

[jira] [Updated] (FLINK-27881) The key(String) in PulsarMessageBuilder returns null

2022-06-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27881: --- Labels: pull-request-available (was: ) > The key(String) in PulsarMessageBuilder returns

[GitHub] [flink] syhily opened a new pull request, #19978: [FLINK-27881][Connector/Pulsar] Never return null for PulsarMessageBuilder

2022-06-15 Thread GitBox
syhily opened a new pull request, #19978: URL: https://github.com/apache/flink/pull/19978 ## What is the purpose of the change The PulsarMessageBuild.key(String) always return null, which cause NPE. ## Brief change log `return this` instead of `return null` ##

[jira] [Commented] (FLINK-27881) The key(String) in PulsarMessageBuilder returns null

2022-06-15 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554811#comment-17554811 ] Yufan Sheng commented on FLINK-27881: - I'll submit a PR today. This is a known bug. > The

[jira] [Created] (FLINK-28085) Close all the pending Pulsar transactions when flink shutdown the pipeline.

2022-06-15 Thread Yufan Sheng (Jira)
Yufan Sheng created FLINK-28085: --- Summary: Close all the pending Pulsar transactions when flink shutdown the pipeline. Key: FLINK-28085 URL: https://issues.apache.org/jira/browse/FLINK-28085 Project:

[GitHub] [flink] flinkbot commented on pull request #19977: [FLINK-28084][Connector/Pulsar] Remove the reconsume later logic for Pulsar unordered reader.

2022-06-15 Thread GitBox
flinkbot commented on PR #19977: URL: https://github.com/apache/flink/pull/19977#issuecomment-1156981879 ## CI report: * 9756d018cd49ff6b7f3f6f1a46e5dd1b6cc4aaa4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-28084) Pulsar unordered reader should disable retry and delete reconsume logic.

2022-06-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28084: --- Labels: pull-request-available (was: ) > Pulsar unordered reader should disable retry and

[GitHub] [flink] syhily opened a new pull request, #19977: [FLINK-28084][Connector/Pulsar] Remove the reconsume later logic for Pulsar unordered reader.

2022-06-15 Thread GitBox
syhily opened a new pull request, #19977: URL: https://github.com/apache/flink/pull/19977 ## What is the purpose of the change Pulsar unordered reader is used for Shared and Key_Shared subscriptions. It would reconsume a message if it didn't acknowledge in a transaction. But this

[jira] [Updated] (FLINK-28084) Pulsar unordered reader should disable retry and delete reconsume logic.

2022-06-15 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yufan Sheng updated FLINK-28084: Description: UnroderdPulsarSourceReader currently calls reconsume, but this feature relys on

[jira] [Updated] (FLINK-27400) Pulsar connector subscribed the system topic when using the regex

2022-06-15 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yufan Sheng updated FLINK-27400: Description: UnroderdPulsarSourceReader currently calls reconsume, but this feature relys on

[jira] [Updated] (FLINK-27400) Pulsar connector subscribed the system topic when using the regex

2022-06-15 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yufan Sheng updated FLINK-27400: Description: Pulsar has a lot of internal topics which is used for metadata. It couldn't be

[jira] [Created] (FLINK-28084) Pulsar unordered reader should disable retry and delete reconsume logic.

2022-06-15 Thread Yufan Sheng (Jira)
Yufan Sheng created FLINK-28084: --- Summary: Pulsar unordered reader should disable retry and delete reconsume logic. Key: FLINK-28084 URL: https://issues.apache.org/jira/browse/FLINK-28084 Project:

[GitHub] [flink] flinkbot commented on pull request #19976: [FLINK-27400][Connector/Pulsar] Never subscribe the Pulsar internal topics by using regex

2022-06-15 Thread GitBox
flinkbot commented on PR #19976: URL: https://github.com/apache/flink/pull/19976#issuecomment-1156917077 ## CI report: * 67a21b87b36684c7dd551e29e77663be2487075e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-27400) Pulsar connector subscribed the system topic when using the regex

2022-06-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27400: --- Labels: pull-request-available (was: ) > Pulsar connector subscribed the system topic when

[GitHub] [flink] syhily opened a new pull request, #19976: [FLINK-27400][Connector/Pulsar] Never subscribe the Pulsar internal topics by using regex

2022-06-15 Thread GitBox
syhily opened a new pull request, #19976: URL: https://github.com/apache/flink/pull/19976 ## What is the purpose of the change The current Pulsar connector would subscribe the Pulsar internal system topics, which is not allowed. ## Brief change log Add a method for

[GitHub] [flink] flinkbot commented on pull request #19975: [FLINK-27611][Connector/Pulsar] Fix the checkpoint issue on shared reader.

2022-06-15 Thread GitBox
flinkbot commented on PR #19975: URL: https://github.com/apache/flink/pull/19975#issuecomment-1156883644 ## CI report: * d11c0d8f91702f7c7d83819edd30916aed2940ec UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-27611) ConcurrentModificationException during Flink-Pulsar checkpoint notification

2022-06-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27611: --- Labels: pull-request-available (was: ) > ConcurrentModificationException during

[GitHub] [flink] syhily opened a new pull request, #19975: [FLINK-27611][Connector/Pulsar] Fix the checkpoint issue on shared reader.

2022-06-15 Thread GitBox
syhily opened a new pull request, #19975: URL: https://github.com/apache/flink/pull/19975 ## What is the purpose of the change Pulsar entered a ConcurrentModificationException because I don't property used the Iterator. This PR fixes this issue. ## Brief change log

[GitHub] [flink] flinkbot commented on pull request #19974: [FLINK-28083][Connector/Pulsar] Object-reusing for Pulsar source

2022-06-15 Thread GitBox
flinkbot commented on PR #19974: URL: https://github.com/apache/flink/pull/19974#issuecomment-1156861952 ## CI report: * 2dc70b01fc3387cab385936f03069075471aecac UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-28083) PulsarSource cannot work with object-reusing DeserializationSchema.

2022-06-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28083: --- Labels: pull-request-available (was: ) > PulsarSource cannot work with object-reusing

[GitHub] [flink] syhily opened a new pull request, #19974: [FLINK-28083][Connector/Pulsar] Object-reusing for Pulsar source

2022-06-15 Thread GitBox
syhily opened a new pull request, #19974: URL: https://github.com/apache/flink/pull/19974 ## What is the purpose of the change This pull request moves record deserializing in PulsarSource from SplitFetcher to RecordEmitter to support object-reusing deserializer. ## Brief

[jira] [Created] (FLINK-28083) PulsarSource cannot work with object-reusing DeserializationSchema.

2022-06-15 Thread Yufan Sheng (Jira)
Yufan Sheng created FLINK-28083: --- Summary: PulsarSource cannot work with object-reusing DeserializationSchema. Key: FLINK-28083 URL: https://issues.apache.org/jira/browse/FLINK-28083 Project: Flink

[GitHub] [flink] flinkbot commented on pull request #19973: [FLINK-28082][Connector/Pulsar] Add end-to-end encryption support for Pulsar connector.

2022-06-15 Thread GitBox
flinkbot commented on PR #19973: URL: https://github.com/apache/flink/pull/19973#issuecomment-1156816241 ## CI report: * f2c2ed2a6537a36091a3c0da129537a523b08d16 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-28082) Support end to end encryption on Pulsar connector.

2022-06-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28082: --- Labels: pull-request-available (was: ) > Support end to end encryption on Pulsar

[GitHub] [flink] syhily opened a new pull request, #19973: [FLINK-28082][Connector/Pulsar] Add end-to-end encryption support for Pulsar connector.

2022-06-15 Thread GitBox
syhily opened a new pull request, #19973: URL: https://github.com/apache/flink/pull/19973 ## What is the purpose of the change Add the end-to-end encryption support for Pulsar. ## Brief change log Add the CryptoKeyReader for both Pulsar source and sink. Add encryption

[jira] [Created] (FLINK-28082) Support end to end encryption on Pulsar connector.

2022-06-15 Thread Yufan Sheng (Jira)
Yufan Sheng created FLINK-28082: --- Summary: Support end to end encryption on Pulsar connector. Key: FLINK-28082 URL: https://issues.apache.org/jira/browse/FLINK-28082 Project: Flink Issue Type:

[jira] [Commented] (FLINK-28043) "Invalid lambda deserialization" in AvroParquetReaders

2022-06-15 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554703#comment-17554703 ] Jing Ge commented on FLINK-28043: - Just want to let you know that I will find time to do it this week. 

[GitHub] [flink] syhily commented on pull request #19473: [FLINK-27199][Connector/Pulsar] Bump pulsar to 2.10.0

2022-06-15 Thread GitBox
syhily commented on PR #19473: URL: https://github.com/apache/flink/pull/19473#issuecomment-1156706620 @fapaul This is PR ready, I think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (FLINK-27790) Port ADD JAR /SHOW JARS syntax implementation from SqlClient to TableEnvironment side

2022-06-15 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu updated FLINK-27790: -- Summary: Port ADD JAR /SHOW JARS syntax implementation from SqlClient to TableEnvironment side (was:

[GitHub] [flink] flinkbot commented on pull request #19972: [FLINK-27399][Connector/Pulsar] Modify start cursor and stop cursor, change initial position setting logic.

2022-06-15 Thread GitBox
flinkbot commented on PR #19972: URL: https://github.com/apache/flink/pull/19972#issuecomment-1156690944 ## CI report: * da9be03ef90e2e12873a3ef5c72996f2fa8fa964 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] syhily opened a new pull request, #19972: [FLINK-27399][Connector/Pulsar] Modify start cursor and stop cursor, change initial position setting logic.

2022-06-15 Thread GitBox
syhily opened a new pull request, #19972: URL: https://github.com/apache/flink/pull/19972 ## What is the purpose of the change ## Brief change log This task modifies the `flink-connector-pulsar` module, adding some new mechanisms to set the initial consuming position. -

[jira] [Updated] (FLINK-27399) Pulsar connector didn't set start consuming position correctly

2022-06-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27399: --- Labels: pull-request-available (was: ) > Pulsar connector didn't set start consuming

[GitHub] [flink-ml] coderappee commented on pull request #109: [hotfix][flink-ml-lib][syntax]fix the forgotten static import method compareResultCollections from TestBaseUtils

2022-06-15 Thread GitBox
coderappee commented on PR #109: URL: https://github.com/apache/flink-ml/pull/109#issuecomment-1156647134 > Hi @coderappee , thanks for creating this PR. Could you please illustrate why do we need to add these static imports? For now the test cases can still pass without these imports.

[jira] [Assigned] (FLINK-25842) [v2] FLIP-158: Generalized incremental checkpoints

2022-06-15 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuan Mei reassigned FLINK-25842: Assignee: Yuan Mei > [v2] FLIP-158: Generalized incremental checkpoints >

[jira] [Assigned] (FLINK-23143) Support state migration

2022-06-15 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuan Mei reassigned FLINK-23143: Assignee: Hangxiang Yu > Support state migration > --- > >

[jira] [Assigned] (FLINK-28081) Remove deprecated Hadoop specific Flink configuration options

2022-06-15 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi reassigned FLINK-28081: - Assignee: Gabor Somogyi > Remove deprecated Hadoop specific Flink configuration

[jira] [Created] (FLINK-28081) Remove deprecated Hadoop specific Flink configuration options

2022-06-15 Thread Gabor Somogyi (Jira)
Gabor Somogyi created FLINK-28081: - Summary: Remove deprecated Hadoop specific Flink configuration options Key: FLINK-28081 URL: https://issues.apache.org/jira/browse/FLINK-28081 Project: Flink

[jira] [Commented] (FLINK-25458) Support local recovery

2022-06-15 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554667#comment-17554667 ] Yuan Mei commented on FLINK-25458: -- As discussed offline and summarized here: * The first step is to

[GitHub] [flink] eskabetxe commented on pull request #19925: [FLINK-27976][WebUi] Allow order jobs by name

2022-06-15 Thread GitBox
eskabetxe commented on PR #19925: URL: https://github.com/apache/flink/pull/19925#issuecomment-1156625342 @MartijnVisser could you forward to someone that can check this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Assigned] (FLINK-25458) Support local recovery

2022-06-15 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuan Mei reassigned FLINK-25458: Assignee: Yanfei Lei > Support local recovery > -- > > Key:

[jira] [Updated] (FLINK-27790) Port ADD/ShowJar syntax implementation from SqlClient to TableEnvironment side

2022-06-15 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu updated FLINK-27790: -- Summary: Port ADD/ShowJar syntax implementation from SqlClient to TableEnvironment side (was: Move

  1   2   3   >