[GitHub] [flink] MartijnVisser commented on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

2022-06-19 Thread GitBox
MartijnVisser commented on PR #14376: URL: https://github.com/apache/flink/pull/14376#issuecomment-1160046705 > The main reason I use scala in the code is that it's more clear to write codegen code. In the first version of this PR, I used java code to do that. If we cannot use scala depende

[jira] [Comment Edited] (FLINK-28119) Update the document for Contribute Documentation

2022-06-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556222#comment-17556222 ] Martijn Visser edited comment on FLINK-28119 at 6/20/22 6:54 AM: -

[jira] [Commented] (FLINK-28119) Update the document for Contribute Documentation

2022-06-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556222#comment-17556222 ] Martijn Visser commented on FLINK-28119: [~martijnvisser] Thanks! I'll update th

[jira] [Assigned] (FLINK-28119) Update the document for Contribute Documentation

2022-06-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-28119: -- Assignee: Martijn Visser > Update the document for Contribute Documentation > ---

[GitHub] [flink] MartijnVisser commented on a diff in pull request #20011: [FLINK-28112][filesystems] Fix error message when directly supported file system is not able to be handled

2022-06-19 Thread GitBox
MartijnVisser commented on code in PR #20011: URL: https://github.com/apache/flink/pull/20011#discussion_r901309667 ## flink-core/src/main/java/org/apache/flink/core/fs/FileSystem.java: ## @@ -527,13 +527,30 @@ public static FileSystem getUnguardedFileSystem(final URI fsUri) th

[jira] [Commented] (FLINK-28125) Promote leadership changing logs to INFO level

2022-06-19 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556220#comment-17556220 ] Weijie Guo commented on FLINK-28125: Hi [~xtsong] , I am interested in this ticket,

[jira] [Updated] (FLINK-28115) Flink 1.15.0 Parallelism Rebalance causes flink job failure

2022-06-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-28115: --- Flags: (was: Important) > Flink 1.15.0 Parallelism Rebalance causes flink job failure > --

[jira] [Updated] (FLINK-28116) Elasticsearch connector doesn't provide security through token

2022-06-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-28116: --- Issue Type: New Feature (was: Improvement) > Elasticsearch connector doesn't provide securi

[jira] [Updated] (FLINK-28116) Elasticsearch connector doesn't provide security through token

2022-06-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-28116: --- Component/s: Connectors / ElasticSearch > Elasticsearch connector doesn't provide security t

[jira] [Updated] (FLINK-28116) Elasticsearch connector doesn't provide security through token

2022-06-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-28116: --- Flags: (was: Important) > Elasticsearch connector doesn't provide security through token >

[jira] [Commented] (FLINK-28117) More metrics for FileSource

2022-06-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556214#comment-17556214 ] Martijn Visser commented on FLINK-28117: [~jingge] Why would these metrics only

[GitHub] [flink] maosuhan commented on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

2022-06-19 Thread GitBox
maosuhan commented on PR #14376: URL: https://github.com/apache/flink/pull/14376#issuecomment-1160032898 > Thanks for starting the review @libenchao - I have one comment about this one > > > 2. I noticed you introduced scala dependency for this module, hence we'd better to add the sc

[jira] [Commented] (FLINK-27822) Translate the doc of checkpoint/savepoint guarantees

2022-06-19 Thread Feifan Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556209#comment-17556209 ] Feifan Wang commented on FLINK-27822: - Hi [~jingge] , can you help me find a Chinese

[jira] [Assigned] (FLINK-28121) Translate "Extension Points" and "Full Stack Example" in "User-defined Sources & Sinks" page

2022-06-19 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-28121: --- Assignee: Chengkai Yang > Translate "Extension Points" and "Full Stack Example" in "User-defined >

[GitHub] [flink] deadwind4 commented on pull request #20005: Update table_api.md, 翻译一段试试流程

2022-06-19 Thread GitBox
deadwind4 commented on PR #20005: URL: https://github.com/apache/flink/pull/20005#issuecomment-1160018239 @jmd300 You can read [How to contribue](https://flink.apache.org/contributing/contribute-code.html) and [how to contribute doc](https://flink.apache.org/contributing/contribute-documen

[GitHub] [flink-kubernetes-operator] csviri commented on a diff in pull request #269: [FLINK-27688] Add pluggable FlinkResourceListener interface

2022-06-19 Thread GitBox
csviri commented on code in PR #269: URL: https://github.com/apache/flink-kubernetes-operator/pull/269#discussion_r901287441 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/EventHelper.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apac

[GitHub] [flink] deadwind4 commented on pull request #19988: [FLINK-28092][table] Support ASCII and CHR built-in function in the Table API

2022-06-19 Thread GitBox
deadwind4 commented on PR #19988: URL: https://github.com/apache/flink/pull/19988#issuecomment-1160014687 @dianfu I agree with you. If we migrate all built-in functions to the new stack, we could create a new Jira ticket to target this. -- This is an automated message from the Apache Git

[GitHub] [flink] dianfu commented on pull request #19988: [FLINK-28092][table] Support ASCII and CHR built-in function in the Table API

2022-06-19 Thread GitBox
dianfu commented on PR #19988: URL: https://github.com/apache/flink/pull/19988#issuecomment-1160011713 @snuyanzin @deadwind4 Per my understanding, the new stack is to ease the adding of new built-in functions. For existing functions, as the work is already done, it isn't convincing for me t

[GitHub] [flink] zhoulii commented on pull request #19984: [FLINK-28105][Tests] test the copied object in GlobFilePathFilterTest#testGlobFilterSerializable

2022-06-19 Thread GitBox
zhoulii commented on PR #19984: URL: https://github.com/apache/flink/pull/19984#issuecomment-1160009844 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] deadwind4 commented on a diff in pull request #20017: [FLINK-27290][docs-zh]Translate the "Data Type" section of "Data Types" in to Chinese.

2022-06-19 Thread GitBox
deadwind4 commented on code in PR #20017: URL: https://github.com/apache/flink/pull/20017#discussion_r901276805 ## docs/content.zh/docs/dev/table/types.md: ## @@ -100,47 +100,38 @@ t = DataTypes.INTERVAL(DataTypes.DAY(), DataTypes.SECOND(3)) {{< /tab >}} {{< /tabs >}} + -

[jira] [Closed] (FLINK-27159) Support first_value/last_value in the Table API

2022-06-19 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu closed FLINK-27159. --- Fix Version/s: 1.16.0 Resolution: Fixed Merged to master via 210c6275c08466fcd93fa8c4dede379724c20df5

[GitHub] [flink] dianfu closed pull request #19958: [FLINK-27159][table-api] Support first_value/last_value in the Table API

2022-06-19 Thread GitBox
dianfu closed pull request #19958: [FLINK-27159][table-api] Support first_value/last_value in the Table API URL: https://github.com/apache/flink/pull/19958 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] dianfu commented on pull request #19958: [FLINK-27159][table-api] Support first_value/last_value in the Table API

2022-06-19 Thread GitBox
dianfu commented on PR #19958: URL: https://github.com/apache/flink/pull/19958#issuecomment-1160004679 > And there is a minor issue , I find that the functions documentation for python is redirect to System (Built-in) Functions documentation for Java API. It's first_value() in python while

[jira] [Created] (FLINK-28126) Iteration gets stuck when replayable datastream and its downstream operator have different parallelism

2022-06-19 Thread Xuannan Su (Jira)
Xuannan Su created FLINK-28126: -- Summary: Iteration gets stuck when replayable datastream and its downstream operator have different parallelism Key: FLINK-28126 URL: https://issues.apache.org/jira/browse/FLINK-28126

[jira] [Closed] (FLINK-27861) Introduce UserResourceManager to manage user defined resource

2022-06-19 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-27861. --- Assignee: dalongliu Resolution: Fixed Fixed in master: 7032ce386d7e765ad9a295732f2f909db97dce1b > Int

[GitHub] [flink] reswqa commented on a diff in pull request #19840: [FLINK-24713][Runtime/Coordination] Support the initial delay for SlotManager to wait fo…

2022-06-19 Thread GitBox
reswqa commented on code in PR #19840: URL: https://github.com/apache/flink/pull/19840#discussion_r901274198 ## flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/DeclarativeSlotManagerTest.java: ## @@ -1449,20 +1449,70 @@ public void testProcessRes

[GitHub] [flink] wuchong merged pull request #19859: [FLINK-27861][table] Introduce UserResourceManager to manage user defined resource

2022-06-19 Thread GitBox
wuchong merged PR #19859: URL: https://github.com/apache/flink/pull/19859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

[GitHub] [flink-connector-elasticsearch] deadwind4 commented on pull request #22: [FLINK-28107][python][connector/elasticsearch] Add a MapElasticsearchEmitter for PyFlink

2022-06-19 Thread GitBox
deadwind4 commented on PR #22: URL: https://github.com/apache/flink-connector-elasticsearch/pull/22#issuecomment-1159997140 @MartijnVisser I create a `SimpleElasticsearchEmitter` class in https://github.com/apache/flink/pull/19732 and rename it to `MapElasticsearchEmitter` in https://gith

[GitHub] [flink-web] gaoyunhaii commented on pull request #545: Add blogs for FLIP-147 support checkpoints after tasks finished

2022-06-19 Thread GitBox
gaoyunhaii commented on PR #545: URL: https://github.com/apache/flink-web/pull/545#issuecomment-1159993038 Very thanks @zhuzhurk for the review! I have update the PR accordingly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Created] (FLINK-28125) Promote leadership changing logs to INFO level

2022-06-19 Thread Xintong Song (Jira)
Xintong Song created FLINK-28125: Summary: Promote leadership changing logs to INFO level Key: FLINK-28125 URL: https://issues.apache.org/jira/browse/FLINK-28125 Project: Flink Issue Type: Im

[GitHub] [flink] 1996fanrui commented on a diff in pull request #19993: [FLINK-28077][checkpoint] Fix the bug that tasks get stuck during cancellation in ChannelStateWriteRequestExecutorImpl

2022-06-19 Thread GitBox
1996fanrui commented on code in PR #19993: URL: https://github.com/apache/flink/pull/19993#discussion_r901261999 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequest.java: ## @@ -109,6 +112,9 @@ static ChannelStateWriteRequest build

[jira] [Commented] (FLINK-28123) When a flink job is restarted, the metaspce size of the taskmanager does not decrease but keeps increasing. After several restarts, the flink job metaspce oom.

2022-06-19 Thread Zhuang Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556191#comment-17556191 ] Zhuang Liu commented on FLINK-28123: - [~martijnvisser],OK,thanks your reply.I will

[jira] [Commented] (FLINK-28123) When a flink job is restarted, the metaspce size of the taskmanager does not decrease but keeps increasing. After several restarts, the flink job metaspce oom.

2022-06-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556189#comment-17556189 ] Martijn Visser commented on FLINK-28123: [~liu zhuang] Please try this with the

[jira] [Updated] (FLINK-28123) When a flink job is restarted, the metaspce size of the taskmanager does not decrease but keeps increasing. After several restarts, the flink job metaspce oom.

2022-06-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-28123: --- Fix Version/s: (was: 1.16.0) > When a flink job is restarted, the metaspce size of the t

[GitHub] [flink] MartijnVisser commented on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

2022-06-19 Thread GitBox
MartijnVisser commented on PR #14376: URL: https://github.com/apache/flink/pull/14376#issuecomment-1159966132 Thanks for starting the review @libenchao - I have one comment about this one > 2\. I noticed you introduced scala dependency for this module, hence we'd better to add the sca

[GitHub] [flink-ml] lindong28 merged pull request #112: [FLINK-27096] Flush buffer at epoch watermark

2022-06-19 Thread GitBox
lindong28 merged PR #112: URL: https://github.com/apache/flink-ml/pull/112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[GitHub] [flink-ml] lindong28 commented on pull request #112: [FLINK-27096] Flush buffer at epoch watermark

2022-06-19 Thread GitBox
lindong28 commented on PR #112: URL: https://github.com/apache/flink-ml/pull/112#issuecomment-1159959274 Thanks for the information. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [flink-ml] lindong28 commented on pull request #112: [FLINK-27096] Flush buffer at epoch watermark

2022-06-19 Thread GitBox
lindong28 commented on PR #112: URL: https://github.com/apache/flink-ml/pull/112#issuecomment-1159956579 For the record, @yunfengzhou-hub has done benchmarks to verify the performance impact of this PR. Here are the results: - Benchmark setup: an iterative data stream job with an almo

[GitHub] [flink-connector-elasticsearch] deadwind4 opened a new pull request, #22: [FLINK-28107][python][connector/elasticsearch] Add a MapElasticsearchEmitter for PyFlink

2022-06-19 Thread GitBox
deadwind4 opened a new pull request, #22: URL: https://github.com/apache/flink-connector-elasticsearch/pull/22 The PR only aligns code in main repo, the MapElasticsearchEmitter class is used in PyFlink ES connector. I will use this [ticket](https://issues.apache.org/jira/browse/FLINK-

[GitHub] [flink-web] gaoyunhaii commented on a diff in pull request #545: Add blogs for FLIP-147 support checkpoints after tasks finished

2022-06-19 Thread GitBox
gaoyunhaii commented on code in PR #545: URL: https://github.com/apache/flink-web/pull/545#discussion_r901234540 ## _posts/2022-06-01-final-checkpoint-part1.md: ## @@ -81,59 +81,61 @@ running subtasks. The states could be repartitioned on restarting and all the ne To support c

[GitHub] [flink-web] gaoyunhaii commented on a diff in pull request #545: Add blogs for FLIP-147 support checkpoints after tasks finished

2022-06-19 Thread GitBox
gaoyunhaii commented on code in PR #545: URL: https://github.com/apache/flink-web/pull/545#discussion_r901234152 ## _posts/2022-06-01-final-checkpoint-part1.md: ## @@ -81,59 +81,61 @@ running subtasks. The states could be repartitioned on restarting and all the ne To support c

[GitHub] [flink] flinkbot commented on pull request #20019: [BP-1.14][FLINK-27420] Recreate metric groups for each new RM to avoid metric loss

2022-06-19 Thread GitBox
flinkbot commented on PR #20019: URL: https://github.com/apache/flink/pull/20019#issuecomment-1159939416 ## CI report: * c8c674d62adc242a0caef7193c34f81a76ec2420 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] fredia commented on a diff in pull request #19907: [FLINK-27692][state] Support local recovery for materialized part of changelog

2022-06-19 Thread GitBox
fredia commented on code in PR #19907: URL: https://github.com/apache/flink/pull/19907#discussion_r895604615 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/TaskLocalStateStore.java: ## @@ -76,7 +74,7 @@ public interface TaskLocalStateStore { /** * Remov

[GitHub] [flink] xintongsong opened a new pull request, #20019: [BP-1.14][FLINK-27420] Recreate metric groups for each new RM to avoid metric loss

2022-06-19 Thread GitBox
xintongsong opened a new pull request, #20019: URL: https://github.com/apache/flink/pull/20019 See #19646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[jira] [Resolved] (FLINK-27877) Improve performance of several feature engineering algorithms

2022-06-19 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin resolved FLINK-27877. -- Resolution: Fixed > Improve performance of several feature engineering algorithms > --

[jira] [Updated] (FLINK-27877) Improve StringIndexer performance and optimize flink-ml-bench

2022-06-19 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-27877: - Summary: Improve StringIndexer performance and optimize flink-ml-bench (was: Improve performance of sev

[jira] [Commented] (FLINK-28115) Flink 1.15.0 Parallelism Rebalance causes flink job failure

2022-06-19 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556178#comment-17556178 ] Qingsheng Ren commented on FLINK-28115: --- >From the stack trace it looks like unrel

[GitHub] [flink-ml] lindong28 merged pull request #111: [FLINK-27877] Improve StringIndexer performance and optimize flink-ml-bench

2022-06-19 Thread GitBox
lindong28 merged PR #111: URL: https://github.com/apache/flink-ml/pull/111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[GitHub] [flink-ml] lindong28 commented on pull request #111: [FLINK-27877] Improve StringIndexer performance and optimize flink-ml-bench

2022-06-19 Thread GitBox
lindong28 commented on PR #111: URL: https://github.com/apache/flink-ml/pull/111#issuecomment-1159934718 Thanks for the update. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Created] (FLINK-28124) Flink on K8S in hosetNetwork mode, the CPU usage will spike

2022-06-19 Thread liuzhuo (Jira)
liuzhuo created FLINK-28124: --- Summary: Flink on K8S in hosetNetwork mode, the CPU usage will spike Key: FLINK-28124 URL: https://issues.apache.org/jira/browse/FLINK-28124 Project: Flink Issue Type

[jira] [Updated] (FLINK-27696) Add bin-pack strategy to split the whole bucket data files into several small splits for append-only table.

2022-06-19 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-27696: - Description: We don't have to assign each task with a whole bucket data files. Instead, we can

[GitHub] [flink-table-store] JingsongLi opened a new pull request, #165: [FLINK-27696] Add bin-pack strategy to split the whole bucket data files into several small splits

2022-06-19 Thread GitBox
JingsongLi opened a new pull request, #165: URL: https://github.com/apache/flink-table-store/pull/165 We don't have to assign each task with a whole bucket data files. Instead, we can use some algorithm ( such as bin-packing) to split the whole bucket data files into multiple fragments to i

[jira] [Closed] (FLINK-28107) Support id of document is null

2022-06-19 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu closed FLINK-28107. --- Assignee: LuNing Wang Resolution: Fixed Merged to master via 11910d52cd1b948b21d0ea04263be689d2bd721e

[GitHub] [flink] dianfu closed pull request #20002: [FLINK-28107][python][connector/elasticsearch] Support id of document is null

2022-06-19 Thread GitBox
dianfu closed pull request #20002: [FLINK-28107][python][connector/elasticsearch] Support id of document is null URL: https://github.com/apache/flink/pull/20002 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] (FLINK-28111) flinksql use hivecatalog cause union all operation lost 'eventTime attribute'

2022-06-19 Thread yutao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28111 ] yutao deleted comment on FLINK-28111: --- was (Author: chaojipaopao): [~jingge] ok,just in work day.i will try > flinksql use hivecatalog cause union all operation lost 'eventTime > attribute' > -

[GitHub] [flink] fredia commented on a diff in pull request #19907: [FLINK-27692][state] Support local recovery for materialized part of changelog

2022-06-19 Thread GitBox
fredia commented on code in PR #19907: URL: https://github.com/apache/flink/pull/19907#discussion_r895925820 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/TaskLocalStateStoreImpl.java: ## @@ -141,6 +158,29 @@ public void storeLocalState( subt

[GitHub] [flink] gaoyunhaii closed pull request #19653: [FLINK-27523] Runtime supports producing and consuming cached intermediate results

2022-06-19 Thread GitBox
gaoyunhaii closed pull request #19653: [FLINK-27523] Runtime supports producing and consuming cached intermediate results URL: https://github.com/apache/flink/pull/19653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink] gaoyunhaii commented on pull request #19653: [FLINK-27523] Runtime supports producing and consuming cached intermediate results

2022-06-19 Thread GitBox
gaoyunhaii commented on PR #19653: URL: https://github.com/apache/flink/pull/19653#issuecomment-1159909912 Thanks @Sxnan for the PR and @zhuzhurk @wsry for the review! will merge~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[jira] [Commented] (FLINK-28123) When a flink job is restarted, the metaspce size of the taskmanager does not decrease but keeps increasing. After several restarts, the flink job metaspce oom.

2022-06-19 Thread Zhuang Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556166#comment-17556166 ] Zhuang Liu commented on FLINK-28123: - TaskManager log: 2022-06-17 16:35:42,720 ERR

[GitHub] [flink] Aitozi commented on a diff in pull request #19840: [FLINK-24713][Runtime/Coordination] Support the initial delay for SlotManager to wait fo…

2022-06-19 Thread GitBox
Aitozi commented on code in PR #19840: URL: https://github.com/apache/flink/pull/19840#discussion_r901209861 ## flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/DeclarativeSlotManagerTest.java: ## @@ -1466,6 +1466,52 @@ public void testProcessReso

[GitHub] [flink] wangyang0918 commented on a diff in pull request #15832: [FLINK-22494][ha] Introduce PossibleInconsistentStateException

2022-06-19 Thread GitBox
wangyang0918 commented on code in PR #15832: URL: https://github.com/apache/flink/pull/15832#discussion_r901208618 ## flink-runtime/src/main/java/org/apache/flink/runtime/persistence/PossibleInconsistentStateException.java: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Soft

[GitHub] [flink] flinkbot commented on pull request #20018: [FLINK-28120][planner] Fix FlinkCost comparison issue

2022-06-19 Thread GitBox
flinkbot commented on PR #20018: URL: https://github.com/apache/flink/pull/20018#issuecomment-1159898654 ## CI report: * a49f2dfbd0b2cdca8292d621fd322494aefef06f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-28120) Meet assert error: BatchPhysicalExchange.BATCH_PHYSICAL has lower cost then best cost of subset :RelSubset#15.BATCH_PHYSICAL.hash[0, 1]true.[]]

2022-06-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28120: --- Labels: pull-request-available (was: ) > Meet assert error: BatchPhysicalExchange.BATCH_PHY

[GitHub] [flink] luoyuxia opened a new pull request, #20018: [FLINK-28120][planner] Fix FlinkCost comparison issue

2022-06-19 Thread GitBox
luoyuxia opened a new pull request, #20018: URL: https://github.com/apache/flink/pull/20018 ## What is the purpose of the change To fix FlinkCost comparison issue that the logic inconsistent between `Flink#isLe` and `Flink#equal`. ## Brief change log Modify the compa

[GitHub] [flink] cason0126 commented on pull request #19964: [FLINK-27291][docs-zh] Translate the "List of Data Types" section of…

2022-06-19 Thread GitBox
cason0126 commented on PR #19964: URL: https://github.com/apache/flink/pull/19964#issuecomment-1159896445 @ChengkaiYang2022 Thanks for correcting. I will fix them ; There is one part I am confusing about : using (both inclusive) instead of using '[' and ']' 。 I think using `[` and`]

[jira] [Created] (FLINK-28123) When a flink job is restarted, the metaspce size of the taskmanager does not decrease but keeps increasing. After several restarts, the flink job metaspce oom.

2022-06-19 Thread Zhuang Liu (Jira)
Zhuang Liu created FLINK-28123: --- Summary: When a flink job is restarted, the metaspce size of the taskmanager does not decrease but keeps increasing. After several restarts, the flink job metaspce oom. Key: FLINK-28123

[jira] [Updated] (FLINK-28019) Error occurred when retract a staled record when enable state ttl in RetractableTopNFunction

2022-06-19 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-28019: - Fix Version/s: 1.15.2 > Error occurred when retract a staled record when enable state ttl in >

[jira] [Comment Edited] (FLINK-28019) Error occurred when retract a staled record when enable state ttl in RetractableTopNFunction

2022-06-19 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17554931#comment-17554931 ] Jingsong Lee edited comment on FLINK-28019 at 6/20/22 2:13 AM: ---

[jira] [Updated] (FLINK-28019) Error occurred when retract a staled record when enable state ttl in RetractableTopNFunction

2022-06-19 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-28019: - Fix Version/s: 1.14.6 > Error occurred when retract a staled record when enable state ttl in >

[GitHub] [flink] JingsongLi merged pull request #19996: [BP-1.15][FLINK-28019][table] fix error when retract a staled record if state ttl enabled in RetractableTopNFunction

2022-06-19 Thread GitBox
JingsongLi merged PR #19996: URL: https://github.com/apache/flink/pull/19996 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[GitHub] [flink] JingsongLi merged pull request #19997: [BP-1.14][FLINK-28019][table] fix error when retract a staled record if state ttl enabled in RetractableTopNFunction

2022-06-19 Thread GitBox
JingsongLi merged PR #19997: URL: https://github.com/apache/flink/pull/19997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[jira] [Comment Edited] (FLINK-16105) Translate "User-defined Sources & Sinks" page of "Table API & SQL" into Chinese

2022-06-19 Thread Chengkai Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556085#comment-17556085 ] Chengkai Yang edited comment on FLINK-16105 at 6/20/22 2:11 AM: --

[jira] [Commented] (FLINK-28121) Translate "Extension Points" and "Full Stack Example" in "User-defined Sources & Sinks" page

2022-06-19 Thread Chengkai Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556158#comment-17556158 ] Chengkai Yang commented on FLINK-28121: --- [~jark] hi,could you assign this to me?

[GitHub] [flink-ml] zhipeng93 commented on pull request #111: [FLINK-27877] Improve StringIndexer performance and optimize flink-ml-bench

2022-06-19 Thread GitBox
zhipeng93 commented on PR #111: URL: https://github.com/apache/flink-ml/pull/111#issuecomment-1159890361 @lindong28 @yunfengzhou-hub Thanks for the PR. The comments have been addressed in the latest PR. -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [flink-ml] yunfengzhou-hub commented on a diff in pull request #111: [FLINK-27877] Improve StringIndexer performance and optimize flink-ml-bench

2022-06-19 Thread GitBox
yunfengzhou-hub commented on code in PR #111: URL: https://github.com/apache/flink-ml/pull/111#discussion_r901202810 ## flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/BenchmarkUtils.java: ## @@ -99,6 +99,7 @@ private static BenchmarkResult runBenchmark(

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #111: [FLINK-27877] Improve StringIndexer performance and optimize flink-ml-bench

2022-06-19 Thread GitBox
zhipeng93 commented on code in PR #111: URL: https://github.com/apache/flink-ml/pull/111#discussion_r901202605 ## flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/BenchmarkUtils.java: ## @@ -99,6 +99,7 @@ private static BenchmarkResult runBenchmark( Da

[jira] [Updated] (FLINK-28121) Translate "Extension Points" and "Full Stack Example" in "User-defined Sources & Sinks" page

2022-06-19 Thread Chengkai Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chengkai Yang updated FLINK-28121: -- Description: The links are https://nightlies.apache.org/flink/flink-docs-master/docs/dev/tabl

[jira] [Updated] (FLINK-28122) Translate "Overview " and "Project Configuration" in "User-defined Sources & Sinks" page

2022-06-19 Thread Chengkai Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chengkai Yang updated FLINK-28122: -- Description: The links are https://nightlies.apache.org/flink/flink-docs-master/docs/dev/table

[jira] [Updated] (FLINK-28122) Translate "Overview " and "Project Configuration" in "User-defined Sources & Sinks" page

2022-06-19 Thread Chengkai Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chengkai Yang updated FLINK-28122: -- Component/s: chinese-translation Documentation > Translate "Overview " and "P

[jira] [Created] (FLINK-28122) Translate "Overview " and "Project Configuration" in "User-defined Sources & Sinks" page

2022-06-19 Thread Chengkai Yang (Jira)
Chengkai Yang created FLINK-28122: - Summary: Translate "Overview " and "Project Configuration" in "User-defined Sources & Sinks" page Key: FLINK-28122 URL: https://issues.apache.org/jira/browse/FLINK-28122

[jira] [Updated] (FLINK-28121) Translate "Extension Points" and "Full Stack Example" in "User-defined Sources & Sinks" page

2022-06-19 Thread Chengkai Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chengkai Yang updated FLINK-28121: -- Summary: Translate "Extension Points" and "Full Stack Example" in "User-defined Sources & Sink

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #111: [FLINK-27877] Improve StringIndexer performance and optimize flink-ml-bench

2022-06-19 Thread GitBox
zhipeng93 commented on code in PR #111: URL: https://github.com/apache/flink-ml/pull/111#discussion_r901200665 ## flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/datagenerator/common/DoubleGenerator.java: ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software

[jira] [Created] (FLINK-28121) Translate in "Extension Points" and "Full Stack Example" in "User-defined Sources & Sinks" page

2022-06-19 Thread Chengkai Yang (Jira)
Chengkai Yang created FLINK-28121: - Summary: Translate in "Extension Points" and "Full Stack Example" in "User-defined Sources & Sinks" page Key: FLINK-28121 URL: https://issues.apache.org/jira/browse/FLINK-28121

[jira] [Commented] (FLINK-28120) Meet assert error: BatchPhysicalExchange.BATCH_PHYSICAL has lower cost then best cost of subset :RelSubset#15.BATCH_PHYSICAL.hash[0, 1]true.[]]

2022-06-19 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556154#comment-17556154 ] luoyuxia commented on FLINK-28120: -- [~godfrey] Could you please have a look. And I woul

[GitHub] [flink] Sxnan commented on pull request #19653: [FLINK-27523] Runtime supports producing and consuming cached intermediate results

2022-06-19 Thread GitBox
Sxnan commented on PR #19653: URL: https://github.com/apache/flink/pull/19653#issuecomment-1159884365 @wsry Thanks for your feedback. @gaoyunhaii Could you help merging the PR if there are no more concern? -- This is an automated message from the Apache Git Service. To respond to the mess

[jira] [Updated] (FLINK-28120) Meet assert error: BatchPhysicalExchange.BATCH_PHYSICAL has lower cost then best cost of subset :RelSubset#15.BATCH_PHYSICAL.hash[0, 1]true.[]]

2022-06-19 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-28120: - Description: When I run the following sql with Hive dialect,   {code:java} create table src(key string,

[jira] [Commented] (FLINK-28111) flinksql use hivecatalog cause union all operation lost 'eventTime attribute'

2022-06-19 Thread yutao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556153#comment-17556153 ] yutao commented on FLINK-28111: --- [~jingge] [~martijnvisser]  flink 1.15.0 also have this p

[GitHub] [flink-ml] yunfengzhou-hub commented on pull request #112: [FLINK-27096] Flush buffer at epoch watermark

2022-06-19 Thread GitBox
yunfengzhou-hub commented on PR #112: URL: https://github.com/apache/flink-ml/pull/112#issuecomment-1159880670 Hi @lindong28, Thanks for reviewing this PR. Before this PR is implemented, Flink ML stages with iterations, like KMeans, have to spend at least 100 ms for each iteration th

[GitHub] [flink] ChengkaiYang2022 commented on a diff in pull request #19964: [FLINK-27291][docs-zh] Translate the "List of Data Types" section of…

2022-06-19 Thread GitBox
ChengkaiYang2022 commented on code in PR #19964: URL: https://github.com/apache/flink/pull/19964#discussion_r901187712 ## docs/content.zh/docs/dev/table/types.md: ## @@ -686,55 +669,50 @@ TIME(p) DataTypes.TIME(p) ``` -**Bridging to JVM Types** +**JVM Types桥接** -| Java Typ

[GitHub] [flink] zhoulii commented on a diff in pull request #19984: [FLINK-28105][Tests] test the copied object in GlobFilePathFilterTest#testGlobFilterSerializable

2022-06-19 Thread GitBox
zhoulii commented on code in PR #19984: URL: https://github.com/apache/flink/pull/19984#discussion_r901196339 ## flink-core/src/test/java/org/apache/flink/api/common/io/GlobFilePathFilterTest.java: ## @@ -27,14 +27,13 @@ import java.io.IOException; import java.util.Collections

[jira] [Updated] (FLINK-28120) Meet assert error: BatchPhysicalExchange.BATCH_PHYSICAL has lower cost then best cost of subset :RelSubset#15.BATCH_PHYSICAL.hash[0, 1]true.[]]

2022-06-19 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-28120: - Attachment: 截屏2022-06-18 上午11.48.46.png > Meet assert error: BatchPhysicalExchange.BATCH_PHYSICAL has lo

[jira] (FLINK-26270) Flink SQL write data to kafka by CSV format , decimal type was converted to scientific notation

2022-06-19 Thread fengjk (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26270 ] fengjk deleted comment on FLINK-26270: was (Author: JIRAUSER284851): The current fix is repackaged by modifying the source code Settings , But not dynamic parameter configuration: this.csvMappe

[jira] [Created] (FLINK-28120) Meet assert error: BatchPhysicalExchange.BATCH_PHYSICAL has lower cost then best cost of subset :RelSubset#15.BATCH_PHYSICAL.hash[0, 1]true.[]]

2022-06-19 Thread luoyuxia (Jira)
luoyuxia created FLINK-28120: Summary: Meet assert error: BatchPhysicalExchange.BATCH_PHYSICAL has lower cost then best cost of subset :RelSubset#15.BATCH_PHYSICAL.hash[0, 1]true.[]] Key: FLINK-28120 URL: https://i

[GitHub] [flink] liujiawinds commented on pull request #20006: [FLINK-27415][Connectors / FileSystem] Read empty csv file throws exception in FileSystem table connector

2022-06-19 Thread GitBox
liujiawinds commented on PR #20006: URL: https://github.com/apache/flink/pull/20006#issuecomment-1159871386 @reswqa Thanks for your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [flink-table-store] complone commented on pull request #164: [FLINK-27708] Add background compaction task for append-only table when ingesting.

2022-06-19 Thread GitBox
complone commented on PR #164: URL: https://github.com/apache/flink-table-store/pull/164#issuecomment-1159859486 > Hi @complone AppendOnly's compaction is not the compaction inside MergeTree, AppendOnly's compaction is actually a small files merge I will read [leveldb related materi

[jira] [Closed] (FLINK-28114) The path of the Python client interpreter could not point to an archive file in distributed file system

2022-06-19 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu closed FLINK-28114. --- Assignee: Dian Fu Resolution: Fixed Fixed in: - master via 6b04a50ae2182d4cdd8e44ea9a16171d1d2394ce -

[GitHub] [flink] deadwind4 commented on pull request #20002: [FLINK-28107][python][connector/elasticsearch] Support id of document is null

2022-06-19 Thread GitBox
deadwind4 commented on PR #20002: URL: https://github.com/apache/flink/pull/20002#issuecomment-1159838998 @dianfu make sense to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[jira] [Comment Edited] (FLINK-28033) find and output new min watermark mybe wrong when in multichannel

2022-06-19 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556114#comment-17556114 ] Weijie Guo edited comment on FLINK-28033 at 6/19/22 6:43 PM: -

[jira] [Comment Edited] (FLINK-28033) find and output new min watermark mybe wrong when in multichannel

2022-06-19 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556114#comment-17556114 ] Weijie Guo edited comment on FLINK-28033 at 6/19/22 6:43 PM: -

[jira] [Commented] (FLINK-28033) find and output new min watermark mybe wrong when in multichannel

2022-06-19 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556114#comment-17556114 ] Weijie Guo commented on FLINK-28033: `newMinWatermark` is a local variable, it will

  1   2   >