[GitHub] [flink] flinkbot commented on pull request #20074: use-relbulider-to-build-project

flinkbot commented on PR #20074: URL: https://github.com/apache/flink/pull/20074#issuecomment-1166422640 ## CI report: * 256216ad8c8ca9b106e7d602658392f11003b785 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] luoyuxia opened a new pull request, #20074: use-relbulider-to-build-project

luoyuxia opened a new pull request, #20074: URL: https://github.com/apache/flink/pull/20074 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them o

[GitHub] [flink] lsyldliu commented on a diff in pull request #19193: [FLINK-26813[SQL-API] Supports ADD/MODIFY column/watermark/constraint syntax parse for ALTER TABLE

lsyldliu commented on code in PR #19193: URL: https://github.com/apache/flink/pull/19193#discussion_r906756236 ## flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkSqlParserImplTest.java: ## @@ -313,6 +313,175 @@ void testAlterTable() { sql(sql

[GitHub] [flink] lsyldliu commented on pull request #19193: [FLINK-26813[SQL-API] Supports ADD/MODIFY column/watermark/constraint syntax parse for ALTER TABLE

lsyldliu commented on PR #19193: URL: https://github.com/apache/flink/pull/19193#issuecomment-1166418304 @fsk119 Thanks for your review, I've addressed your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink] lsyldliu commented on a diff in pull request #19193: [FLINK-26813[SQL-API] Supports ADD/MODIFY column/watermark/constraint syntax parse for ALTER TABLE

lsyldliu commented on code in PR #19193: URL: https://github.com/apache/flink/pull/19193#discussion_r906754613 ## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/position/SqlColumnPosSpec.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [flink] lsyldliu commented on a diff in pull request #19193: [FLINK-26813[SQL-API] Supports ADD/MODIFY column/watermark/constraint syntax parse for ALTER TABLE

lsyldliu commented on code in PR #19193: URL: https://github.com/apache/flink/pull/19193#discussion_r906753870 ## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlAlterTableAdd.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [flink] wuchong commented on pull request #20003: [FLINK-28080][runtime] Introduce MutableURLClassLoader as parent class of FlinkUserClassLoader and SafetyNetWrapperClassLoader

wuchong commented on PR #20003: URL: https://github.com/apache/flink/pull/20003#issuecomment-1166415168 LGTM. Would be better @zhuzhurk or @zentol could have a double-check. Btw, the E2E is still failed. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [flink] lsyldliu commented on a diff in pull request #19193: [FLINK-26813[SQL-API] Supports ADD/MODIFY column/watermark/constraint syntax parse for ALTER TABLE

lsyldliu commented on code in PR #19193: URL: https://github.com/apache/flink/pull/19193#discussion_r906753373 ## flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkSqlParserImplTest.java: ## @@ -313,6 +313,175 @@ void testAlterTable() { sql(sql

[GitHub] [flink] wuchong commented on pull request #20057: [FLINK-28213][runtime] StreamExecutionEnvironment configure method support override pipeline.jars option

wuchong commented on PR #20057: URL: https://github.com/apache/flink/pull/20057#issuecomment-1166414526 @lsyldliu the test is failed. Could you rebase branch and try again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] lsyldliu commented on a diff in pull request #19193: [FLINK-26813[SQL-API] Supports ADD/MODIFY column/watermark/constraint syntax parse for ALTER TABLE

lsyldliu commented on code in PR #19193: URL: https://github.com/apache/flink/pull/19193#discussion_r906752928 ## flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl: ## @@ -567,12 +568,60 @@ SqlAlterTable SqlAlterTable() : propertyLis

[GitHub] [flink] lsyldliu commented on a diff in pull request #19193: [FLINK-26813[SQL-API] Supports ADD/MODIFY column/watermark/constraint syntax parse for ALTER TABLE

lsyldliu commented on code in PR #19193: URL: https://github.com/apache/flink/pull/19193#discussion_r906752928 ## flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl: ## @@ -567,12 +568,60 @@ SqlAlterTable SqlAlterTable() : propertyLis

[GitHub] [flink] lsyldliu commented on a diff in pull request #19193: [FLINK-26813[SQL-API] Supports ADD/MODIFY column/watermark/constraint syntax parse for ALTER TABLE

lsyldliu commented on code in PR #19193: URL: https://github.com/apache/flink/pull/19193#discussion_r906752928 ## flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl: ## @@ -567,12 +568,60 @@ SqlAlterTable SqlAlterTable() : propertyLis

[jira] [Assigned] (FLINK-28213) StreamExecutionEnvironment configure method support override pipeline.jars option

[ https://issues.apache.org/jira/browse/FLINK-28213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-28213: --- Assignee: dalongliu > StreamExecutionEnvironment configure method support override pipeline.jars >

[GitHub] [flink] lsyldliu commented on a diff in pull request #19193: [FLINK-26813[SQL-API] Supports ADD/MODIFY column/watermark/constraint syntax parse for ALTER TABLE

lsyldliu commented on code in PR #19193: URL: https://github.com/apache/flink/pull/19193#discussion_r906752106 ## flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkSqlParserImplTest.java: ## @@ -313,6 +313,175 @@ void testAlterTable() { sql(sql

[GitHub] [flink] lsyldliu commented on a diff in pull request #19193: [FLINK-26813[SQL-API] Supports ADD/MODIFY column/watermark/constraint syntax parse for ALTER TABLE

lsyldliu commented on code in PR #19193: URL: https://github.com/apache/flink/pull/19193#discussion_r906751763 ## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlAlterTable.java: ## @@ -94,4 +97,15 @@ public SqlNodeList getPartitionSpec() { pub

[GitHub] [flink] liujiawinds commented on pull request #20073: [FLINK-28173][formats] Specify guava version explicitly in flink-orc and flink-parquet

liujiawinds commented on PR #20073: URL: https://github.com/apache/flink/pull/20073#issuecomment-1166377868 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #274: [FLINK-28180] Unify Application and SessionJob reconciler logic

gyfora commented on PR #274: URL: https://github.com/apache/flink-kubernetes-operator/pull/274#issuecomment-1166364561 @Aitozi thanks for the review, I have managed to move further methods into the `FlinkReconciler` and make the subclass implementations a little more modular with new metho

[GitHub] [flink] gaborgsomogyi commented on a diff in pull request #20066: [FLINK-25908][runtime][security] Add HadoopFSDelegationTokenProvider

gaborgsomogyi commented on code in PR #20066: URL: https://github.com/apache/flink/pull/20066#discussion_r906721436 ## flink-runtime/src/main/java/org/apache/flink/runtime/security/token/KerberosDelegationTokenManager.java: ## @@ -130,12 +131,14 @@ private Map loadProviders() {

[GitHub] [flink] gaborgsomogyi commented on a diff in pull request #20066: [FLINK-25908][runtime][security] Add HadoopFSDelegationTokenProvider

gaborgsomogyi commented on code in PR #20066: URL: https://github.com/apache/flink/pull/20066#discussion_r906720670 ## flink-runtime/src/test/java/org/apache/flink/runtime/security/token/KerberosDelegationTokenManagerITCase.java: ## @@ -79,9 +80,8 @@ public void configurationIsN

[GitHub] [flink] gaborgsomogyi commented on a diff in pull request #20066: [FLINK-25908][runtime][security] Add HadoopFSDelegationTokenProvider

gaborgsomogyi commented on code in PR #20066: URL: https://github.com/apache/flink/pull/20066#discussion_r906720670 ## flink-runtime/src/test/java/org/apache/flink/runtime/security/token/KerberosDelegationTokenManagerITCase.java: ## @@ -79,9 +80,8 @@ public void configurationIsN

[jira] [Commented] (FLINK-27822) Translate the doc of checkpoint/savepoint guarantees

[ https://issues.apache.org/jira/browse/FLINK-27822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558810#comment-17558810 ] Jing Ge commented on FLINK-27822: - Hi [~Feifan Wang] , sorry for the late reply. I just

[GitHub] [flink] JingGe commented on a diff in pull request #19998: [FLINK-27822][docs-zh] Translate the doc of checkpoint/savepoint guar…

JingGe commented on code in PR #19998: URL: https://github.com/apache/flink/pull/19998#discussion_r906709098 ## docs/content.zh/docs/ops/state/checkpoints_vs_savepoints.md: ## @@ -24,72 +24,65 @@ specific language governing permissions and limitations under the License. -->

[GitHub] [flink] afedulov commented on a diff in pull request #19856: [FLINK-27854][tests] Refactor FlinkImageBuilder and FlinkContainerBuilder

afedulov commented on code in PR #19856: URL: https://github.com/apache/flink/pull/19856#discussion_r906708437 ## flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/container/FlinkContainersConfig.java: ## @@ -0,0 +1,599 @@ +/* +

[GitHub] [flink] afedulov commented on a diff in pull request #19856: [FLINK-27854][tests] Refactor FlinkImageBuilder and FlinkContainerBuilder

afedulov commented on code in PR #19856: URL: https://github.com/apache/flink/pull/19856#discussion_r906708437 ## flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/container/FlinkContainersConfig.java: ## @@ -0,0 +1,599 @@ +/* +

[GitHub] [flink] afedulov commented on a diff in pull request #19856: [FLINK-27854][tests] Refactor FlinkImageBuilder and FlinkContainerBuilder

afedulov commented on code in PR #19856: URL: https://github.com/apache/flink/pull/19856#discussion_r906708437 ## flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/container/FlinkContainersConfig.java: ## @@ -0,0 +1,599 @@ +/* +

[GitHub] [flink] afedulov commented on a diff in pull request #19856: [FLINK-27854][tests] Refactor FlinkImageBuilder and FlinkContainerBuilder

afedulov commented on code in PR #19856: URL: https://github.com/apache/flink/pull/19856#discussion_r906708437 ## flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/container/FlinkContainersConfig.java: ## @@ -0,0 +1,599 @@ +/* +

[GitHub] [flink] afedulov closed pull request #19854: WIP: Refactor FlinkImageBuilder, FlinkContainersBuilder

afedulov closed pull request #19854: WIP: Refactor FlinkImageBuilder, FlinkContainersBuilder URL: https://github.com/apache/flink/pull/19854 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [flink-kubernetes-operator] Aitozi commented on a diff in pull request #274: [FLINK-28180] Unify Application and SessionJob reconciler logic

Aitozi commented on code in PR #274: URL: https://github.com/apache/flink-kubernetes-operator/pull/274#discussion_r906685879 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/FlinkReconciler.java: ## @@ -0,0 +1,282 @@ +/* + *

[jira] [Commented] (FLINK-27155) Reduce multiple reads to the same Changelog file in the same taskmanager during restore

[ https://issues.apache.org/jira/browse/FLINK-27155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558798#comment-17558798 ] Feifan Wang commented on FLINK-27155: - Hi [~roman] , thanks for your comments ! I a

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #280: [FLINK-28008] Can not get secondary resource from context after operator restart

morhidi commented on PR #280: URL: https://github.com/apache/flink-kubernetes-operator/pull/280#issuecomment-1166319359 cc @Aitozi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[jira] [Commented] (FLINK-26372) Allow to configure Changelog Storage per program

[ https://issues.apache.org/jira/browse/FLINK-26372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558793#comment-17558793 ] Feifan Wang commented on FLINK-26372: - Hi [~Yanfei Lei] , I read the discussion, it

[GitHub] [flink] liujiawinds commented on pull request #20073: [FLINK-28173][formats] Specify guava version explicitly in flink-orc and flink-parquet

liujiawinds commented on PR #20073: URL: https://github.com/apache/flink/pull/20073#issuecomment-1166312956 @zentol Thanks for your suggestion. Please have a look the new PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] liujiawinds commented on pull request #20073: [FLINK-28173][formats] Specify guava version explicitly in flink-orc and flink-parquet

liujiawinds commented on PR #20073: URL: https://github.com/apache/flink/pull/20073#issuecomment-1166312851 - Passed hadoop3 tests with maven flags `-Dinclude_hadoop_aws -Dhadoop.version=3.1.3 -Phadoop3-tests,hive3`. - Passed run ITcases of flink-orc and flink-parquet in IDE. -- This i

[GitHub] [flink] 6591812 commented on pull request #20072: [FLINK-28136][runtime] Implement ExecutionTimeBasedSlowTaskDetector

6591812 commented on PR #20072: URL: https://github.com/apache/flink/pull/20072#issuecomment-1166312412 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] (FLINK-28231) Support Apache Ozone FileSystem

[ https://issues.apache.org/jira/browse/FLINK-28231 ] bianqi deleted comment on FLINK-28231: was (Author: bianqi): [~prabhujoseph]  You are Hadoop PMC, you are more professional than me. More familiar with Ozone than I am. You complete this meanin

[jira] [Updated] (FLINK-28008) Can not get secondary resource from context after operator restart

[ https://issues.apache.org/jira/browse/FLINK-28008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28008: --- Labels: pull-request-available (was: ) > Can not get secondary resource from context after

[GitHub] [flink-kubernetes-operator] morhidi opened a new pull request, #280: [FLINK-28008] Can not get secondary resource from context after operator restart

morhidi opened a new pull request, #280: URL: https://github.com/apache/flink-kubernetes-operator/pull/280 - bumping JOSDK version v3.0.2 -> v3.0.3 - add primaryToSecondary mapper for session jobs - removing the workaround for setting namespaces (not needed anymore from JOSDK v3.0.3+)

[GitHub] [flink] flinkbot commented on pull request #20073: [FLINK-28173][formats] Specify guava version explicitly in flink-orc and flink-parquet

flinkbot commented on PR #20073: URL: https://github.com/apache/flink/pull/20073#issuecomment-1166305179 ## CI report: * 9577cff4804406d987e41cc9d9ec71cad4a9df55 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] liujiawinds opened a new pull request, #20073: [FLINK-28173][formats] Specify guava version explicitly in flink-orc and flink-parquet

liujiawinds opened a new pull request, #20073: URL: https://github.com/apache/flink/pull/20073 ## What is the purpose of the change Multiple Parquet format tests are failing with `NoSuchMethodError` in hadoop cron builds. ## Brief change log - * Specify guava version e

[GitHub] [flink] liujiawinds closed pull request #20047: [FLINK-28173][formats] Cover default dependencies with guava exclusion in `hadoop3-tests` profile

liujiawinds closed pull request #20047: [FLINK-28173][formats] Cover default dependencies with guava exclusion in `hadoop3-tests` profile URL: https://github.com/apache/flink/pull/20047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[jira] [Created] (FLINK-28251) flink-avro format reader may thrown ’java.util.NoSuchElementException' Exception in some cases

jinshuangxian created FLINK-28251: - Summary: flink-avro format reader may thrown ’java.util.NoSuchElementException' Exception in some cases Key: FLINK-28251 URL: https://issues.apache.org/jira/browse/FLINK-282

[jira] [Created] (FLINK-28250) exactly-once sink kafka cause out of memory

jinshuangxian created FLINK-28250: - Summary: exactly-once sink kafka cause out of memory Key: FLINK-28250 URL: https://issues.apache.org/jira/browse/FLINK-28250 Project: Flink Issue Type: Bug

[GitHub] [flink] dusukang commented on pull request #19741: [FLINK-27794][connectors/jdbc] Fix the wrong primary key for MysqlCatalog when there are tables with same name in different databases

dusukang commented on PR #19741: URL: https://github.com/apache/flink/pull/19741#issuecomment-1166291016 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Resolved] (FLINK-16078) Translate "Tuning Checkpoints and Large State" page into Chinese

[ https://issues.apache.org/jira/browse/FLINK-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang resolved FLINK-16078. -- Resolution: Fixed merged in master: f9ba9d10f53515d904680327ea4bbd07a9e3bfab > Translate "Tuning Chec

[GitHub] [flink] liuzhuang2017 commented on pull request #19503: [FLINK-16078] [docs-zh] Translate "Tuning Checkpoints and Large State".

liuzhuang2017 commented on PR #19503: URL: https://github.com/apache/flink/pull/19503#issuecomment-1166272910 @mddxhj , Thank you very much careful review. @Myasuka , Thank you very much for the merged and previous invaluable suggestions for this jira. -- This is an automated message fro

[GitHub] [flink] Myasuka closed pull request #19503: [FLINK-16078] [docs-zh] Translate "Tuning Checkpoints and Large State".

Myasuka closed pull request #19503: [FLINK-16078] [docs-zh] Translate "Tuning Checkpoints and Large State". URL: https://github.com/apache/flink/pull/19503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] Myasuka commented on pull request #19503: [FLINK-16078] [docs-zh] Translate "Tuning Checkpoints and Large State".

Myasuka commented on PR #19503: URL: https://github.com/apache/flink/pull/19503#issuecomment-1166268731 Thanks for @mddxhj ’s careful review, and thanks for @liuzhuang2017 's work to kick off this. I will merge this PR manually with those committed suggestions. -- This is an automated me

[GitHub] [flink] mddxhj commented on a diff in pull request #19503: [FLINK-16078] [docs-zh] Translate "Tuning Checkpoints and Large State".

mddxhj commented on code in PR #19503: URL: https://github.com/apache/flink/pull/19503#discussion_r906670868 ## docs/content.zh/docs/ops/state/large_state_tuning.md: ## @@ -26,122 +26,102 @@ under the License. # 大状态与 Checkpoint 调优 -This page gives a guide how to configure a

[GitHub] [flink] mddxhj commented on a diff in pull request #19413: [FLINK-16078] [docs-zh] Translate "Tuning Checkpoints and Large State"

mddxhj commented on code in PR #19413: URL: https://github.com/apache/flink/pull/19413#discussion_r906644336 ## docs/content.zh/docs/ops/state/large_state_tuning.md: ## @@ -26,122 +26,81 @@ under the License. # 大状态与 Checkpoint 调优 -This page gives a guide how to configure an

[GitHub] [flink] mddxhj commented on a diff in pull request #19503: [FLINK-16078] [docs-zh] Translate "Tuning Checkpoints and Large State".

mddxhj commented on code in PR #19503: URL: https://github.com/apache/flink/pull/19503#discussion_r906670676 ## docs/content.zh/docs/ops/state/large_state_tuning.md: ## @@ -26,122 +26,102 @@ under the License. # 大状态与 Checkpoint 调优 -This page gives a guide how to configure a

[GitHub] [flink] 6591812 commented on pull request #20072: [FLINK-28136][runtime] Implement ExecutionTimeBasedSlowTaskDetector

6591812 commented on PR #20072: URL: https://github.com/apache/flink/pull/20072#issuecomment-1166258760 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] 6591812 commented on pull request #20072: [FLINK-28136][runtime] Implement ExecutionTimeBasedSlowTaskDetector

6591812 commented on PR #20072: URL: https://github.com/apache/flink/pull/20072#issuecomment-1166255133 > > * @flinkbot run azure @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [flink] 6591812 commented on pull request #20072: [FLINK-28136][runtime] Implement ExecutionTimeBasedSlowTaskDetector

6591812 commented on PR #20072: URL: https://github.com/apache/flink/pull/20072#issuecomment-1166252532 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] diohabara commented on pull request #19950: [hotfix] [docs] Translate a Chinese comment into English

diohabara commented on PR #19950: URL: https://github.com/apache/flink/pull/19950#issuecomment-1166252161 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-28136) Implement ExecutionTimeBasedSlowTaskDetector

[ https://issues.apache.org/jira/browse/FLINK-28136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28136: --- Labels: pull-request-available (was: ) > Implement ExecutionTimeBasedSlowTaskDetector > ---

[GitHub] [flink] flinkbot commented on pull request #20072: [FLINK-28136][runtime] Implement ExecutionTimeBasedSlowTaskDetector

flinkbot commented on PR #20072: URL: https://github.com/apache/flink/pull/20072#issuecomment-1166241130 ## CI report: * bcc6b332cfedc76e221475d0792078369ad5a351 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] 6591812 opened a new pull request, #20072: Flink 28136

6591812 opened a new pull request, #20072: URL: https://github.com/apache/flink/pull/20072 This a pr based on https://github.com/apache/flink/pull/20054. In the first version of speculative execution, an ExecutionTimeBasedSlowTaskDetector will be used to detect slow tasks. For Execut

[GitHub] [flink] maosuhan commented on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

maosuhan commented on PR #14376: URL: https://github.com/apache/flink/pull/14376#issuecomment-1166225283 @libenchao Appreciate for your detailed review. I have fixed most of the issues and I also leave some comment. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [flink] maosuhan commented on a diff in pull request #14376: [FLINK-18202][PB format] New Format of protobuf

maosuhan commented on code in PR #14376: URL: https://github.com/apache/flink/pull/14376#discussion_r906652762 ## flink-formats/flink-protobuf/src/main/java/org/apache/flink/formats/protobuf/PbCodegenAppender.java: ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [flink] dusukang commented on pull request #19741: [FLINK-27794][connectors/jdbc] Fix the wrong primary key for MysqlCatalog when there are tables with same name in different databases

dusukang commented on PR #19741: URL: https://github.com/apache/flink/pull/19741#issuecomment-1166224215 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.