[GitHub] [flink] swuferhong commented on a diff in pull request #20462: [FLINK-28821][table-planner] Adjust join cost for dpp query pattern which could help more plans use dpp

2022-08-07 Thread GitBox
swuferhong commented on code in PR #20462: URL: https://github.com/apache/flink/pull/20462#discussion_r939884076 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/utils/DynamicPartitionPruningUtils.java: ## @@ -0,0 +1,342 @@ +/* + * Licensed to the

[GitHub] [flink] yunfengzhou-hub commented on a diff in pull request #20454: [FLINK-28639][Runtime/Checkpointing] Preserve consistency of events from subtask to OC

2022-08-07 Thread GitBox
yunfengzhou-hub commented on code in PR #20454: URL: https://github.com/apache/flink/pull/20454#discussion_r939883850 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/FinishedOperatorChain.java: ## @@ -62,8 +63,9 @@ public WatermarkGaugeExposingOutp

[GitHub] [flink] swuferhong commented on a diff in pull request #20462: [FLINK-28821][table-planner] Adjust join cost for dpp query pattern which could help more plans use dpp

2022-08-07 Thread GitBox
swuferhong commented on code in PR #20462: URL: https://github.com/apache/flink/pull/20462#discussion_r939883772 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/utils/DynamicPartitionPruningUtils.java: ## @@ -0,0 +1,342 @@ +/* + * Licensed to the

[GitHub] [flink] swuferhong commented on a diff in pull request #20462: [FLINK-28821][table-planner] Adjust join cost for dpp query pattern which could help more plans use dpp

2022-08-07 Thread GitBox
swuferhong commented on code in PR #20462: URL: https://github.com/apache/flink/pull/20462#discussion_r939883033 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/utils/DynamicPartitionPruningUtils.java: ## @@ -0,0 +1,342 @@ +/* + * Licensed to the

[GitHub] [flink] swuferhong commented on pull request #20462: [FLINK-28821][table-planner] Adjust join cost for dpp query pattern which could help more plans use dpp

2022-08-07 Thread GitBox
swuferhong commented on PR #20462: URL: https://github.com/apache/flink/pull/20462#issuecomment-1207740372 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [flink] snuyanzin commented on pull request #20455: [FLINK-28814][Connectors][JDBC] Update org.postgresql:postgresql to 42.4.1

2022-08-07 Thread GitBox
snuyanzin commented on PR #20455: URL: https://github.com/apache/flink/pull/20455#issuecomment-1207736880 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-28836) Support broadcast in Thread Mode

2022-08-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28836: --- Labels: pull-request-available (was: ) > Support broadcast in Thread Mode > ---

[GitHub] [flink] HuangXingBo opened a new pull request, #20490: [FLINK-28836][python] Support broadcast in Thread Mode

2022-08-07 Thread GitBox
HuangXingBo opened a new pull request, #20490: URL: https://github.com/apache/flink/pull/20490 ## What is the purpose of the change *This pull request support broadcast in Thread Mode* ## Brief change log - *Support broadcast in Thread Mode* ## Verifying this

[jira] [Assigned] (FLINK-28554) Kubernetes-Operator allow readOnlyRootFilesystem via operatorSecurityContext

2022-08-07 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang reassigned FLINK-28554: - Assignee: Tim > Kubernetes-Operator allow readOnlyRootFilesystem via operatorSecurityContext >

[GitHub] [flink] snuyanzin commented on pull request #19916: [FLINK-27936][tests] Migrate flink-connector-cassandra to JUnit5

2022-08-07 Thread GitBox
snuyanzin commented on PR #19916: URL: https://github.com/apache/flink/pull/19916#issuecomment-1207734245 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [flink] lincoln-lil commented on a diff in pull request #20324: [FLINK-28568][table-runtime] Implements a new lookup join operator (sync mode only) with state to eliminate the non determinism

2022-08-07 Thread GitBox
lincoln-lil commented on code in PR #20324: URL: https://github.com/apache/flink/pull/20324#discussion_r939876782 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecLookupJoin.java: ## @@ -541,16 +632,9 @@ private Pro

[GitHub] [flink] lincoln-lil commented on a diff in pull request #20324: [FLINK-28568][table-runtime] Implements a new lookup join operator (sync mode only) with state to eliminate the non determinism

2022-08-07 Thread GitBox
lincoln-lil commented on code in PR #20324: URL: https://github.com/apache/flink/pull/20324#discussion_r939876601 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecLookupJoin.java: ## @@ -329,8 +342,66 @@ private Tra

[GitHub] [flink] lincoln-lil commented on a diff in pull request #20324: [FLINK-28568][table-runtime] Implements a new lookup join operator (sync mode only) with state to eliminate the non determinism

2022-08-07 Thread GitBox
lincoln-lil commented on code in PR #20324: URL: https://github.com/apache/flink/pull/20324#discussion_r939875933 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecLookupJoin.java: ## @@ -143,6 +154,8 @@ public abstr

[GitHub] [flink] Myasuka commented on a diff in pull request #20420: [FLINK-28626][tests]Fix unstable RescaleCheckpointManuallyITCase

2022-08-07 Thread GitBox
Myasuka commented on code in PR #20420: URL: https://github.com/apache/flink/pull/20420#discussion_r939869507 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/RescaleCheckpointManuallyITCase.java: ## @@ -150,54 +137,33 @@ public void testCheckpointRescalingKeyedS

[GitHub] [flink] godfreyhe commented on a diff in pull request #20324: [FLINK-28568][table-runtime] Implements a new lookup join operator (sync mode only) with state to eliminate the non determinism

2022-08-07 Thread GitBox
godfreyhe commented on code in PR #20324: URL: https://github.com/apache/flink/pull/20324#discussion_r939866279 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecLookupJoin.java: ## @@ -541,16 +632,9 @@ private Proce

[GitHub] [flink] yunfengzhou-hub commented on a diff in pull request #20454: [FLINK-28639][Runtime/Checkpointing] Preserve consistency of events from subtask to OC

2022-08-07 Thread GitBox
yunfengzhou-hub commented on code in PR #20454: URL: https://github.com/apache/flink/pull/20454#discussion_r939861202 ## flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/OperatorCoordinatorHolder.java: ## @@ -298,6 +322,86 @@ public void resetToCheckpo

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #20459: [FLINK-28823][network] Enlarge the max requested buffers for SortMergeResultPartitionReadScheduler

2022-08-07 Thread GitBox
TanYuxin-tyx commented on code in PR #20459: URL: https://github.com/apache/flink/pull/20459#discussion_r939859889 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SortMergeResultPartitionReadScheduler.java: ## @@ -85,8 +85,8 @@ class SortMergeResultP

[GitHub] [flink] yunfengzhou-hub commented on a diff in pull request #20454: [FLINK-28639][Runtime/Checkpointing] Preserve consistency of events from subtask to OC

2022-08-07 Thread GitBox
yunfengzhou-hub commented on code in PR #20454: URL: https://github.com/apache/flink/pull/20454#discussion_r939858060 ## flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java: ## @@ -1488,12 +1488,15 @@ public void deliverOperatorEvent(OperatorID operator,

[jira] [Commented] (FLINK-28713) Remove unused curator-test dependency from flink-test-utils

2022-08-07 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17576562#comment-17576562 ] Xintong Song commented on FLINK-28713: -- Fix CI in master (1.16): caef5b7a5c1b980cff

[GitHub] [flink] wsry commented on pull request #20483: [FLINK-28713][yarn] Bump curator-test dependency

2022-08-07 Thread GitBox
wsry commented on PR #20483: URL: https://github.com/apache/flink/pull/20483#issuecomment-1207707098 @zentol @xintongsong Thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [flink] xintongsong closed pull request #20483: [FLINK-28713][yarn] Bump curator-test dependency

2022-08-07 Thread GitBox
xintongsong closed pull request #20483: [FLINK-28713][yarn] Bump curator-test dependency URL: https://github.com/apache/flink/pull/20483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] fredia commented on a diff in pull request #20217: [FLINK-27693][state] Support local recovery for non-materialized part

2022-08-07 Thread GitBox
fredia commented on code in PR #20217: URL: https://github.com/apache/flink/pull/20217#discussion_r939852338 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/ChangelogTaskLocalStateStore.java: ## @@ -97,6 +101,47 @@ private void updateReference(long checkpointId, T

[jira] [Commented] (FLINK-28844) YARNHighAvailabilityITCase fails with NoSuchMethod of org.apache.curator

2022-08-07 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17576551#comment-17576551 ] Yuxin Tan commented on FLINK-28844: --- https://dev.azure.com/apache-flink/apache-flink/_

[GitHub] [flink] yuzelin commented on a diff in pull request #20479: [FLINK-28631][sql-gateway][hive] Support to GetFunctions in the HiveServer2Endpoint

2022-08-07 Thread GitBox
yuzelin commented on code in PR #20479: URL: https://github.com/apache/flink/pull/20479#discussion_r939831480 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/endpoint/hive/util/OperationExecutorFactory.java: ## @@ -203,6 +230,78 @@ private static Re

[GitHub] [flink] godfreyhe commented on a diff in pull request #20415: [FLINK-28711] Hive connector implements SupportsDynamicFiltering interface

2022-08-07 Thread GitBox
godfreyhe commented on code in PR #20415: URL: https://github.com/apache/flink/pull/20415#discussion_r939838254 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/src/impl/DynamicFileSplitEnumeratorTest.java: ## @@ -0,0 +1,189 @@ +/* + * Lice

[GitHub] [flink] fredia commented on a diff in pull request #20217: [FLINK-27693][state] Support local recovery for non-materialized part

2022-08-07 Thread GitBox
fredia commented on code in PR #20217: URL: https://github.com/apache/flink/pull/20217#discussion_r939841395 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/ChangelogTaskLocalStateStore.java: ## @@ -97,6 +101,47 @@ private void updateReference(long checkpointId, T

[GitHub] [flink] fredia commented on a diff in pull request #20217: [FLINK-27693][state] Support local recovery for non-materialized part

2022-08-07 Thread GitBox
fredia commented on code in PR #20217: URL: https://github.com/apache/flink/pull/20217#discussion_r939839267 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/LocalStateRegistry.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [flink] lsyldliu commented on a diff in pull request #20442: [FLINK-24614][Connectors/PARQUET] Add Complex types support for parquet reader

2022-08-07 Thread GitBox
lsyldliu commented on code in PR #20442: URL: https://github.com/apache/flink/pull/20442#discussion_r939837891 ## flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/vector/reader/BaseVectorizedColumnReader.java: ## @@ -0,0 +1,290 @@ +/* + * Licensed to th

[GitHub] [flink] flinkbot commented on pull request #20489: [FLINK-28854][connector/jdbc] Migrate JDBC lookup table to the new LookupFunction and caching interface

2022-08-07 Thread GitBox
flinkbot commented on PR #20489: URL: https://github.com/apache/flink/pull/20489#issuecomment-1207683417 ## CI report: * 00fc873ab22f7e1515a4adf05011f3fbcfef4f0f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #340: [FLINK-28845] Do not ignore initialSavepointPath if first deploy fails completely

2022-08-07 Thread GitBox
gyfora commented on PR #340: URL: https://github.com/apache/flink-kubernetes-operator/pull/340#issuecomment-1207681498 cc @jeesmon @Aitozi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[jira] [Updated] (FLINK-28845) InitialSavepointPath might be ignored if first deployment fails

2022-08-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28845: --- Labels: pull-request-available (was: ) > InitialSavepointPath might be ignored if first dep

[GitHub] [flink-kubernetes-operator] gyfora opened a new pull request, #340: [FLINK-28845] Do not ignore initialSavepointPath if first deploy fails completely

2022-08-07 Thread GitBox
gyfora opened a new pull request, #340: URL: https://github.com/apache/flink-kubernetes-operator/pull/340 ## What is the purpose of the change Fix a bug that would cause the `initialSavepointPath` to be ignored if first deploy attempt fails completely. ## Brief change log

[GitHub] [flink] yuzelin commented on a diff in pull request #20479: [FLINK-28631][sql-gateway][hive] Support to GetFunctions in the HiveServer2Endpoint

2022-08-07 Thread GitBox
yuzelin commented on code in PR #20479: URL: https://github.com/apache/flink/pull/20479#discussion_r939831055 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/endpoint/hive/util/OperationExecutorFactory.java: ## @@ -203,6 +230,78 @@ private static Re

[GitHub] [flink] flinkbot commented on pull request #20488: [FLINK-28788][python] Support SideOutput in Thread Mode

2022-08-07 Thread GitBox
flinkbot commented on PR #20488: URL: https://github.com/apache/flink/pull/20488#issuecomment-1207671881 ## CI report: * 800d4586334e80172a19f94ada0cc2693239f9cc UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-28854) Migrate JDBC table connector to the new LookupFunction interface

2022-08-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28854: --- Labels: pull-request-available (was: ) > Migrate JDBC table connector to the new LookupFunc

[GitHub] [flink] PatrickRen opened a new pull request, #20489: [FLINK-28854][connector/jdbc] Migrate JDBC lookup table to the new LookupFunction and caching interface

2022-08-07 Thread GitBox
PatrickRen opened a new pull request, #20489: URL: https://github.com/apache/flink/pull/20489 ## What is the purpose of the change This PR migrate JDBC lookup table to the new LookupFunction and caching interface. ## Brief change log - Migrate JDBC lookup table to th

[jira] [Updated] (FLINK-28788) Support SideOutput in Thread Mode

2022-08-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28788: --- Labels: pull-request-available (was: ) > Support SideOutput in Thread Mode > --

[GitHub] [flink] HuangXingBo opened a new pull request, #20488: [FLINK-28788][python] Support SideOutput in Thread Mode

2022-08-07 Thread GitBox
HuangXingBo opened a new pull request, #20488: URL: https://github.com/apache/flink/pull/20488 ## What is the purpose of the change *This pull request will support SideOutput in Thread Mode* ## Brief change log - *Support SideOutput in Thread Mode* ## Verifyi

[jira] [Commented] (FLINK-28859) FAILED pyflink/datastream/connectors/tests/test_file_system.py::FileSinkCsvBulkWriterTests::test_csv_customize_quote_char_write

2022-08-07 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17576539#comment-17576539 ] Huang Xingbo commented on FLINK-28859: -- Thanks for reporting this. [~Juntao Hu] is

[GitHub] [flink] flinkbot commented on pull request #20487: [FLINK-28799] Hybrid shuffle should supports schedule the graph contains blocking edge

2022-08-07 Thread GitBox
flinkbot commented on PR #20487: URL: https://github.com/apache/flink/pull/20487#issuecomment-1207658018 ## CI report: * 6cfe0210d33bbe42bf76b107c38e8128737e8a74 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] lincoln-lil commented on a diff in pull request #20482: [FLINK-28848][table-planner] Introduces LOOKUP join hint to support delayed retry for lookup join (table alias unsupported in

2022-08-07 Thread GitBox
lincoln-lil commented on code in PR #20482: URL: https://github.com/apache/flink/pull/20482#discussion_r939814164 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/utils/LookupJoinUtil.java: ## @@ -144,75 +146,92 @@ private LookupJoinUtil() {

[jira] [Commented] (FLINK-28859) FAILED pyflink/datastream/connectors/tests/test_file_system.py::FileSinkCsvBulkWriterTests::test_csv_customize_quote_char_write

2022-08-07 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17576530#comment-17576530 ] godfrey he commented on FLINK-28859: cc [~hxbks2ks] > FAILED > pyflink/datastream/

[jira] [Created] (FLINK-28859) FAILED pyflink/datastream/connectors/tests/test_file_system.py::FileSinkCsvBulkWriterTests::test_csv_customize_quote_char_write

2022-08-07 Thread godfrey he (Jira)
godfrey he created FLINK-28859: -- Summary: FAILED pyflink/datastream/connectors/tests/test_file_system.py::FileSinkCsvBulkWriterTests::test_csv_customize_quote_char_write Key: FLINK-28859 URL: https://issues.apache.or

[jira] [Updated] (FLINK-28859) FAILED pyflink/datastream/connectors/tests/test_file_system.py::FileSinkCsvBulkWriterTests::test_csv_customize_quote_char_write

2022-08-07 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-28859: --- Description: https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=39522&view=logs&

[GitHub] [flink] fredia commented on a diff in pull request #20217: [FLINK-27693][state] Support local recovery for non-materialized part

2022-08-07 Thread GitBox
fredia commented on code in PR #20217: URL: https://github.com/apache/flink/pull/20217#discussion_r939812417 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/LocalStateRegistry.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Updated] (FLINK-28799) Hybrid shuffle can't schedule graph contains blocking edge

2022-08-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28799: --- Labels: pull-request-available (was: ) > Hybrid shuffle can't schedule graph contains block

[GitHub] [flink] reswqa opened a new pull request, #20487: [FLINK-28799] Hybrid shuffle should supports schedule the graph contains blocking edge

2022-08-07 Thread GitBox
reswqa opened a new pull request, #20487: URL: https://github.com/apache/flink/pull/20487 ## What is the purpose of the change *Based on TPC-DS test, we found that hybrid shuffle can't schedule the graph contains blocking edge. The reason is that some batch operators will forcibly se

[jira] [Updated] (FLINK-28843) Fail to find incremental handle when restoring from changelog checkpoint in claim mode

2022-08-07 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuan Mei updated FLINK-28843: - Summary: Fail to find incremental handle when restoring from changelog checkpoint in claim mode (was: F

[GitHub] [flink] godfreyhe commented on a diff in pull request #20377: [FLINK-27338][hive] Improve splitting file for Hive source

2022-08-07 Thread GitBox
godfreyhe commented on code in PR #20377: URL: https://github.com/apache/flink/pull/20377#discussion_r939780282 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/PartitionMonitorTest.java: ## @@ -99,6 +99,10 @@ private void commitPartitionWi

[GitHub] [flink] lincoln-lil commented on pull request #20482: [FLINK-28848][table-planner] Introduces LOOKUP join hint to support delayed retry for lookup join (table alias unsupported in hint)

2022-08-07 Thread GitBox
lincoln-lil commented on PR #20482: URL: https://github.com/apache/flink/pull/20482#issuecomment-1207639175 rebased master and updated the pr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [flink] flinkbot commented on pull request #20486: [FLINK-23252][state/changelog] [docs] Update the docs about disabling changelog

2022-08-07 Thread GitBox
flinkbot commented on PR #20486: URL: https://github.com/apache/flink/pull/20486#issuecomment-1207638411 ## CI report: * 0289104858e9da5066768dd6865475da4610fecc UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] fredia commented on a diff in pull request #20217: [FLINK-27693][state] Support local recovery for non-materialized part

2022-08-07 Thread GitBox
fredia commented on code in PR #20217: URL: https://github.com/apache/flink/pull/20217#discussion_r939805560 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/LocalStateRegistry.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [flink] fredia commented on a diff in pull request #20217: [FLINK-27693][state] Support local recovery for non-materialized part

2022-08-07 Thread GitBox
fredia commented on code in PR #20217: URL: https://github.com/apache/flink/pull/20217#discussion_r939805155 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/LocalStateRegistry.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Created] (FLINK-28858) Add document to describe join hints for batch sql

2022-08-07 Thread godfrey he (Jira)
godfrey he created FLINK-28858: -- Summary: Add document to describe join hints for batch sql Key: FLINK-28858 URL: https://issues.apache.org/jira/browse/FLINK-28858 Project: Flink Issue Type: Sub

[jira] [Closed] (FLINK-28682) support join hint in flink batch

2022-08-07 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he closed FLINK-28682. -- Resolution: Fixed Fixed in master: 53f1a66f67ca1414e9b8f833f79466aa6b2110f5 f794d72903c9c76e89731273d

[jira] [Assigned] (FLINK-28682) support join hint in flink batch

2022-08-07 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he reassigned FLINK-28682: -- Assignee: xuyang > support join hint in flink batch > > >

[jira] [Comment Edited] (FLINK-28678) Support SQL hint for Filter, SetOp, Sort, Window, Values

2022-08-07 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17576523#comment-17576523 ] godfrey he edited comment on FLINK-28678 at 8/8/22 3:59 AM:

[jira] [Updated] (FLINK-28682) support join hint in flink batch

2022-08-07 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-28682: --- Fix Version/s: 1.16.0 > support join hint in flink batch > > >

[jira] [Closed] (FLINK-28678) Support SQL hint for Filter, SetOp, Sort, Window, Values

2022-08-07 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he closed FLINK-28678. -- Resolution: Fixed Fixed in master: d17dcbd43b287c58efc726f8a0a9b78c5ddf7f60 4e46602342f3e3e45716f3adf

[jira] [Assigned] (FLINK-28678) Support SQL hint for Filter, SetOp, Sort, Window, Values

2022-08-07 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he reassigned FLINK-28678: -- Assignee: xuyang > Support SQL hint for Filter, SetOp, Sort, Window, Values > ---

[jira] [Updated] (FLINK-28678) Support SQL hint for Filter, SetOp, Sort, Window, Values

2022-08-07 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-28678: --- Fix Version/s: 1.16.0 > Support SQL hint for Filter, SetOp, Sort, Window, Values > -

[GitHub] [flink] godfreyhe closed pull request #20359: [FLINK-28682][table-planner] support join hint in batch rules

2022-08-07 Thread GitBox
godfreyhe closed pull request #20359: [FLINK-28682][table-planner] support join hint in batch rules URL: https://github.com/apache/flink/pull/20359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [flink] libenchao commented on pull request #20140: [Flink 16024][Connector][JDBC] Support FilterPushdown

2022-08-07 Thread GitBox
libenchao commented on PR #20140: URL: https://github.com/apache/flink/pull/20140#issuecomment-1207632475 @qingwei91 Thanks for your contribution. For the current design, I see you use `ValueLiteralExpression#toString()` to generate the string for literals. This may work for some cases, but

[GitHub] [flink] godfreyhe commented on pull request #20359: [FLINK-28682][table-planner] support join hint in batch rules

2022-08-07 Thread GitBox
godfreyhe commented on PR #20359: URL: https://github.com/apache/flink/pull/20359#issuecomment-1207631496 The failure is due to https://issues.apache.org/jira/browse/FLINK-28844 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] masteryhx commented on pull request #19679: [FLINK-23143][state/changelog] Support state migration for ChangelogS…

2022-08-07 Thread GitBox
masteryhx commented on PR #19679: URL: https://github.com/apache/flink/pull/19679#issuecomment-1207630691 > Thanks for updating the PR @masteryhx Production code changes LGTM. > > I have some concerns regarding the test coverage, PTAL at the comments. > > Besides that, commi

[GitHub] [flink] masteryhx opened a new pull request, #20486: [FLINK-23252][state/changelog] [docs] Update the docs about disabling changelog

2022-08-07 Thread GitBox
masteryhx opened a new pull request, #20486: URL: https://github.com/apache/flink/pull/20486 ## What is the purpose of the change This pull request updates the documentation about changing changelog from enabling to disabling. ## Brief change log - Updat

[GitHub] [flink] luoyuxia commented on a diff in pull request #20422: [FLINK-28778][SQL/API] Bulk fetch of table and column statistics for given partitions

2022-08-07 Thread GitBox
luoyuxia commented on code in PR #20422: URL: https://github.com/apache/flink/pull/20422#discussion_r939763843 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java: ## @@ -146,10 +159,14 @@ /** A catalog implementation fo

[GitHub] [flink] fredia commented on a diff in pull request #20217: [FLINK-27693][state] Support local recovery for non-materialized part

2022-08-07 Thread GitBox
fredia commented on code in PR #20217: URL: https://github.com/apache/flink/pull/20217#discussion_r939797960 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/TaskExecutorLocalStateStoresManager.java: ## @@ -101,6 +103,7 @@ public TaskExecutorLocalStateStoresManager(

[jira] [Assigned] (FLINK-28855) ThriftObjectConversions compile failed

2022-08-07 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang reassigned FLINK-28855: - Assignee: yuzelin > ThriftObjectConversions compile failed > --

[GitHub] [flink] fredia commented on a diff in pull request #20217: [FLINK-27693][state] Support local recovery for non-materialized part

2022-08-07 Thread GitBox
fredia commented on code in PR #20217: URL: https://github.com/apache/flink/pull/20217#discussion_r939796611 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/ChangelogTaskLocalStateStore.java: ## @@ -181,6 +226,16 @@ public void pruneCheckpoints(LongPredicate prunin

[jira] [Commented] (FLINK-28855) ThriftObjectConversions compile failed

2022-08-07 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17576518#comment-17576518 ] Shengkai Fang commented on FLINK-28855: --- Thanks for pointing out! [~yzl] will help

[jira] [Created] (FLINK-28857) Add Document for DataStream Cache API

2022-08-07 Thread Xuannan Su (Jira)
Xuannan Su created FLINK-28857: -- Summary: Add Document for DataStream Cache API Key: FLINK-28857 URL: https://issues.apache.org/jira/browse/FLINK-28857 Project: Flink Issue Type: Sub-task

[jira] [Closed] (FLINK-28688) Support DataStream PythonWindowOperator in Thread Mode

2022-08-07 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huang Xingbo closed FLINK-28688. Resolution: Done Merged into master via d137c12877fa2b21688acd3a89bb947975b0553a > Support DataSt

[GitHub] [flink] HuangXingBo closed pull request #20435: [FLINK-28688][python] Support DataStream PythonWindowOperator in Thread Mode

2022-08-07 Thread GitBox
HuangXingBo closed pull request #20435: [FLINK-28688][python] Support DataStream PythonWindowOperator in Thread Mode URL: https://github.com/apache/flink/pull/20435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Closed] (FLINK-28789) TPC-DS tests failed due to release input gate for task failure

2022-08-07 Thread Yingjie Cao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yingjie Cao closed FLINK-28789. --- Resolution: Fixed > TPC-DS tests failed due to release input gate for task failure > -

[jira] [Commented] (FLINK-28789) TPC-DS tests failed due to release input gate for task failure

2022-08-07 Thread Yingjie Cao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17576513#comment-17576513 ] Yingjie Cao commented on FLINK-28789: - Closing this issue, feel free to reopen it if

[GitHub] [flink] WencongLiu commented on pull request #20451: [FLINK-28162][sql-gateway]Introduce the operation related API for REST endpoint

2022-08-07 Thread GitBox
WencongLiu commented on PR #20451: URL: https://github.com/apache/flink/pull/20451#issuecomment-1207604935 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [flink] masteryhx commented on a diff in pull request #19679: [FLINK-23143][state/changelog] Support state migration for ChangelogS…

2022-08-07 Thread GitBox
masteryhx commented on code in PR #19679: URL: https://github.com/apache/flink/pull/19679#discussion_r939789230 ## flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java: ## @@ -782,21 +847,57 @@ public Ke

[jira] [Closed] (FLINK-28856) YARNHighAvailabilityITCase tests failed with NoSuchMethodError

2022-08-07 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huang Xingbo closed FLINK-28856. Resolution: Duplicate > YARNHighAvailabilityITCase tests failed with NoSuchMethodError > -

[GitHub] [flink] lincoln-lil commented on a diff in pull request #20324: [FLINK-28568][table-runtime] Implements a new lookup join operator (sync mode only) with state to eliminate the non determinism

2022-08-07 Thread GitBox
lincoln-lil commented on code in PR #20324: URL: https://github.com/apache/flink/pull/20324#discussion_r939777681 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/LookupJoinJsonPlanTest.java: ## @@ -156,4 +173,43 @@ public vo

[jira] [Created] (FLINK-28856) YARNHighAvailabilityITCase tests failed with NoSuchMethodError

2022-08-07 Thread Huang Xingbo (Jira)
Huang Xingbo created FLINK-28856: Summary: YARNHighAvailabilityITCase tests failed with NoSuchMethodError Key: FLINK-28856 URL: https://issues.apache.org/jira/browse/FLINK-28856 Project: Flink

[GitHub] [flink] Myasuka commented on a diff in pull request #20399: [FLINK-28699][StateBackend] Native rocksdb full snapshot in non-incremental checkpointing

2022-08-07 Thread GitBox
Myasuka commented on code in PR #20399: URL: https://github.com/apache/flink/pull/20399#discussion_r939784345 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksNativeFullSnapshotStrategy.java: ## @@ -0,0 +1,25

[jira] [Commented] (FLINK-28789) TPC-DS tests failed due to release input gate for task failure

2022-08-07 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17576508#comment-17576508 ] Yuxin Tan commented on FLINK-28789: --- The commit has been reverted on Aug 05, and the i

[jira] [Commented] (FLINK-28766) UnalignedCheckpointStressITCase.runStressTest failed with NoSuchFileException

2022-08-07 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17576507#comment-17576507 ] Huang Xingbo commented on FLINK-28766: -- https://dev.azure.com/apache-flink/apache-f

[jira] [Commented] (FLINK-28855) ThriftObjectConversions compile failed

2022-08-07 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17576506#comment-17576506 ] Huang Xingbo commented on FLINK-28855: -- cc [~fsk119] [~yzl] > ThriftObjectConversi

[jira] [Created] (FLINK-28855) ThriftObjectConversions compile failed

2022-08-07 Thread Huang Xingbo (Jira)
Huang Xingbo created FLINK-28855: Summary: ThriftObjectConversions compile failed Key: FLINK-28855 URL: https://issues.apache.org/jira/browse/FLINK-28855 Project: Flink Issue Type: Bug

[GitHub] [flink] godfreyhe commented on a diff in pull request #20377: [FLINK-27338][hive] Improve splitting file for Hive source

2022-08-07 Thread GitBox
godfreyhe commented on code in PR #20377: URL: https://github.com/apache/flink/pull/20377#discussion_r93964 ## docs/content/docs/connectors/table/hive/hive_read_write.md: ## @@ -166,6 +166,39 @@ following parameters in `TableConfig` (note that these parameters affect all so

[GitHub] [flink] Myasuka commented on a diff in pull request #20484: [FLINK-28843][StateBackend] Fix restore from incremental checkpoint with changelog checkpoint in claim mode

2022-08-07 Thread GitBox
Myasuka commented on code in PR #20484: URL: https://github.com/apache/flink/pull/20484#discussion_r939775768 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateBackendHandle.java: ## @@ -149,29 +151,58 @@ public static ChangelogStateBackendHan

[jira] [Created] (FLINK-28854) Migrate JDBC table connector to the new LookupFunction interface

2022-08-07 Thread Qingsheng Ren (Jira)
Qingsheng Ren created FLINK-28854: - Summary: Migrate JDBC table connector to the new LookupFunction interface Key: FLINK-28854 URL: https://issues.apache.org/jira/browse/FLINK-28854 Project: Flink

[jira] [Commented] (FLINK-28843) Failed to restore from changelog checkpoint in claim mode

2022-08-07 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17576502#comment-17576502 ] Yanfei Lei commented on FLINK-28843: [~frozen stone] Thanks for reporting this bug!

[GitHub] [flink-table-store] SteNicholas commented on pull request #264: [FLINK-28754] Document that Java 8 is required to build table store

2022-08-07 Thread GitBox
SteNicholas commented on PR #264: URL: https://github.com/apache/flink-table-store/pull/264#issuecomment-1207586860 @JingsongLi, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[jira] [Updated] (FLINK-28420) Support partial lookup caching in lookup join runners

2022-08-07 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-28420: Fix Version/s: 1.16.0 > Support partial lookup caching in lookup join runners > --

[jira] [Closed] (FLINK-28420) Support partial lookup caching in lookup join runners

2022-08-07 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-28420. --- Resolution: Fixed Fixed in master: bc76a93239e159fba7277da96336c3796887e6c5 > Support partial lookup cachin

[GitHub] [flink] wuchong merged pull request #20480: [FLINK-28420] Support partial caching in sync and async lookup runner

2022-08-07 Thread GitBox
wuchong merged PR #20480: URL: https://github.com/apache/flink/pull/20480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

[GitHub] [flink] wuchong commented on pull request #20480: [FLINK-28420] Support partial caching in sync and async lookup runner

2022-08-07 Thread GitBox
wuchong commented on PR #20480: URL: https://github.com/apache/flink/pull/20480#issuecomment-1207586278 The failed case is tracked by FLINK-28844. Merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (FLINK-28844) YARNHighAvailabilityITCase fails with NoSuchMethod of org.apache.curator

2022-08-07 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17576499#comment-17576499 ] Jark Wu commented on FLINK-28844: - https://dev.azure.com/apache-flink/apache-flink/_buil

[jira] [Closed] (FLINK-27790) Port ADD JAR /SHOW JARS syntax implementation from SqlClient to TableEnvironment side

2022-08-07 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-27790. --- Resolution: Fixed Fixed in master: c5c66af680eaf3aae6fbcb6dc48e8d6b66ade8c9 to fe9c726ac1ac09c719b2769e7b73

[GitHub] [flink] PatrickRen commented on pull request #20480: [FLINK-28420] Support partial caching in sync and async lookup runner

2022-08-07 Thread GitBox
PatrickRen commented on PR #20480: URL: https://github.com/apache/flink/pull/20480#issuecomment-1207584493 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Closed] (FLINK-28851) Allow to GetTypeInfo in the HiveServer2 Endpoint

2022-08-07 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang closed FLINK-28851. - Resolution: Implemented Merged into master: 3aaa160bd80a5e89447118fa1bc9cfea6bd368d1 29ca0ad8e

[GitHub] [flink] wuchong merged pull request #20361: [FLINK-27790][Table SQL / API] Port ADD JAR /SHOW JARS syntax implementation from SqlClient to TableEnvironment side

2022-08-07 Thread GitBox
wuchong merged PR #20361: URL: https://github.com/apache/flink/pull/20361 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

  1   2   3   >