[GitHub] [flink] mas-chen commented on a diff in pull request #20215: [FLINK-27479] [Connectors / Common] introduce availability helper to manage future for hybr…

2022-08-16 Thread GitBox
mas-chen commented on code in PR #20215: URL: https://github.com/apache/flink/pull/20215#discussion_r947506841 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/hybrid/HybridSourceReader.java: ## @@ -231,16 +236,7 @@ private void setCu

[GitHub] [flink] mas-chen commented on a diff in pull request #20215: [FLINK-27479] [Connectors / Common] introduce availability helper to manage future for hybr…

2022-08-16 Thread GitBox
mas-chen commented on code in PR #20215: URL: https://github.com/apache/flink/pull/20215#discussion_r947506841 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/hybrid/HybridSourceReader.java: ## @@ -231,16 +236,7 @@ private void setCu

[GitHub] [flink] mas-chen commented on a diff in pull request #20215: [FLINK-27479] [Connectors / Common] introduce availability helper to manage future for hybr…

2022-08-16 Thread GitBox
mas-chen commented on code in PR #20215: URL: https://github.com/apache/flink/pull/20215#discussion_r947506841 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/hybrid/HybridSourceReader.java: ## @@ -231,16 +236,7 @@ private void setCu

[GitHub] [flink] mas-chen commented on a diff in pull request #20215: [FLINK-27479] [Connectors / Common] introduce availability helper to manage future for hybr…

2022-08-16 Thread GitBox
mas-chen commented on code in PR #20215: URL: https://github.com/apache/flink/pull/20215#discussion_r947506841 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/hybrid/HybridSourceReader.java: ## @@ -231,16 +236,7 @@ private void setCu

[GitHub] [flink] mas-chen commented on a diff in pull request #20215: [FLINK-27479] [Connectors / Common] introduce availability helper to manage future for hybr…

2022-08-16 Thread GitBox
mas-chen commented on code in PR #20215: URL: https://github.com/apache/flink/pull/20215#discussion_r947506841 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/hybrid/HybridSourceReader.java: ## @@ -231,16 +236,7 @@ private void setCu

[GitHub] [flink] mas-chen commented on a diff in pull request #20215: [FLINK-27479] [Connectors / Common] introduce availability helper to manage future for hybr…

2022-08-16 Thread GitBox
mas-chen commented on code in PR #20215: URL: https://github.com/apache/flink/pull/20215#discussion_r947506841 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/hybrid/HybridSourceReader.java: ## @@ -231,16 +236,7 @@ private void setCu

[GitHub] [flink] mas-chen commented on a diff in pull request #20215: [FLINK-27479] [Connectors / Common] introduce availability helper to manage future for hybr…

2022-08-16 Thread GitBox
mas-chen commented on code in PR #20215: URL: https://github.com/apache/flink/pull/20215#discussion_r947506841 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/hybrid/HybridSourceReader.java: ## @@ -231,16 +236,7 @@ private void setCu

[jira] [Commented] (FLINK-28272) Handle TLS Certificate Renewal in Webhook

2022-08-16 Thread wu3396 (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580621#comment-17580621 ] wu3396 commented on FLINK-28272: Hello, I've just hit the same issue , my env is: kubern

[GitHub] [flink] WencongLiu commented on pull request #20574: [FLINK-28963][sql-gateway]Add API compatibility test for sql gateway rest endpoint

2022-08-16 Thread GitBox
WencongLiu commented on PR #20574: URL: https://github.com/apache/flink/pull/20574#issuecomment-1217523181 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Resolved] (FLINK-28803) Add Transformer and Estimator for KBinsDiscretizer

2022-08-16 Thread Zhipeng Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhipeng Zhang resolved FLINK-28803. --- Fix Version/s: ml-2.2.0 Resolution: Fixed fixed on master via be546ad47887bdf2bbcf66b

[GitHub] [flink-ml] zhipeng93 merged pull request #139: [FLINK-28803] Add Transformer and Estimator for KBinsDiscretizer

2022-08-16 Thread GitBox
zhipeng93 merged PR #139: URL: https://github.com/apache/flink-ml/pull/139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[GitHub] [flink-ml] zhipeng93 commented on pull request #139: [FLINK-28803] Add Transformer and Estimator for KBinsDiscretizer

2022-08-16 Thread GitBox
zhipeng93 commented on PR #139: URL: https://github.com/apache/flink-ml/pull/139#issuecomment-1217515997 Thanks for the review @lindong28. Merging now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Resolved] (FLINK-28894) Add Transformer for Interaction

2022-08-16 Thread Zhipeng Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhipeng Zhang resolved FLINK-28894. --- Fix Version/s: ml-2.2.0 Assignee: weibo zhao Resolution: Fixed fixed on mast

[GitHub] [flink] mas-chen commented on a diff in pull request #20598: [FLINK-28997][datadog] Add switch to use logical identifier

2022-08-16 Thread GitBox
mas-chen commented on code in PR #20598: URL: https://github.com/apache/flink/pull/20598#discussion_r947487427 ## docs/content.zh/docs/deployment/metric_reporters.md: ## @@ -261,18 +261,20 @@ metrics.reporter.stsd.interval: 60 SECONDS 使用 Datadog 时,Flink 运行指标中的任何变量,例如 ``、``、 `

[GitHub] [flink] mas-chen commented on a diff in pull request #20598: [FLINK-28997][datadog] Add switch to use logical identifier

2022-08-16 Thread GitBox
mas-chen commented on code in PR #20598: URL: https://github.com/apache/flink/pull/20598#discussion_r947487427 ## docs/content.zh/docs/deployment/metric_reporters.md: ## @@ -261,18 +261,20 @@ metrics.reporter.stsd.interval: 60 SECONDS 使用 Datadog 时,Flink 运行指标中的任何变量,例如 ``、``、 `

[jira] [Commented] (FLINK-28765) Create a doc for protobuf format

2022-08-16 Thread Hui Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580607#comment-17580607 ] Hui Yang commented on FLINK-28765: -- [~maosuhan] want to follow up with you to see if yo

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #139: [FLINK-28803] Add Transformer and Estimator for KBinsDiscretizer

2022-08-16 Thread GitBox
lindong28 commented on code in PR #139: URL: https://github.com/apache/flink-ml/pull/139#discussion_r947463284 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/kbinsdiscretizer/KBinsDiscretizer.java: ## @@ -0,0 +1,341 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [flink] WencongLiu commented on pull request #20574: [FLINK-28963][sql-gateway]Add API compatibility test for sql gateway rest endpoint

2022-08-16 Thread GitBox
WencongLiu commented on PR #20574: URL: https://github.com/apache/flink/pull/20574#issuecomment-1217476335 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [flink] swuferhong commented on pull request #20595: [FLINK-28992][table-planner] fix: Change Ndv takes the max value instead of sum of all partitions when getting partition table column stat

2022-08-16 Thread GitBox
swuferhong commented on PR #20595: URL: https://github.com/apache/flink/pull/20595#issuecomment-1217449186 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [flink-ml] zhipeng93 merged pull request #140: [FLINK-28894] Add Transformer for Interaction

2022-08-16 Thread GitBox
zhipeng93 merged PR #140: URL: https://github.com/apache/flink-ml/pull/140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[GitHub] [flink-ml] zhipeng93 commented on pull request #140: [FLINK-28894] Add Transformer for Interaction

2022-08-16 Thread GitBox
zhipeng93 commented on PR #140: URL: https://github.com/apache/flink-ml/pull/140#issuecomment-1217442803 Thanks for the update. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] Mrzyxing commented on pull request #20510: [FLINK-28815][docs] Translate the Real Time Reporting with the Table API page into Chinese

2022-08-16 Thread GitBox
Mrzyxing commented on PR #20510: URL: https://github.com/apache/flink/pull/20510#issuecomment-1217442299 @ChengkaiYang2022 Updates, please have a look just when you have time. And will push a final commit after all conversation resolved. -- This is an automated message from the Apache Git

[jira] [Commented] (FLINK-29007) UsingRemoteJarITCase failed with NPE in hadoop3

2022-08-16 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580554#comment-17580554 ] dalongliu commented on FLINK-29007: --- ok, also cc [~Jiangang]  > UsingRemoteJarITCase

[jira] [Commented] (FLINK-29005) Parquet row type reader should not return null value when some child fields is null

2022-08-16 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580553#comment-17580553 ] dalongliu commented on FLINK-29005: --- cc [~jark]  > Parquet row type reader should not

[GitHub] [flink] Mrzyxing commented on a diff in pull request #20510: [FLINK-28815][docs] Translate the Real Time Reporting with the Table API page into Chinese

2022-08-16 Thread GitBox
Mrzyxing commented on code in PR #20510: URL: https://github.com/apache/flink/pull/20510#discussion_r947431564 ## docs/content.zh/docs/try-flink/table_api.md: ## @@ -275,38 +270,38 @@ public static Table report(Table transactions) { } ``` -This defines your application as us

[GitHub] [flink] Mrzyxing commented on a diff in pull request #20510: [FLINK-28815][docs] Translate the Real Time Reporting with the Table API page into Chinese

2022-08-16 Thread GitBox
Mrzyxing commented on code in PR #20510: URL: https://github.com/apache/flink/pull/20510#discussion_r947427688 ## docs/content.zh/docs/try-flink/table_api.md: ## @@ -275,38 +270,38 @@ public static Table report(Table transactions) { } ``` -This defines your application as us

[jira] [Commented] (FLINK-29005) Parquet row type reader should not return null value when some child fields is null

2022-08-16 Thread Kai Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580550#comment-17580550 ] Kai Chen commented on FLINK-29005: -- hi [~lsy] Could you assign this to me? > Parquet r

[GitHub] [flink] Mrzyxing commented on a diff in pull request #20510: [FLINK-28815][docs] Translate the Real Time Reporting with the Table API page into Chinese

2022-08-16 Thread GitBox
Mrzyxing commented on code in PR #20510: URL: https://github.com/apache/flink/pull/20510#discussion_r947427414 ## docs/content.zh/docs/try-flink/table_api.md: ## @@ -275,38 +270,38 @@ public static Table report(Table transactions) { } ``` -This defines your application as us

[jira] [Commented] (FLINK-29007) UsingRemoteJarITCase failed with NPE in hadoop3

2022-08-16 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580549#comment-17580549 ] Huang Xingbo commented on FLINK-29007: -- [~lsy] Could you help take a look? Thx > U

[jira] [Created] (FLINK-29007) UsingRemoteJarITCase failed with NPE in hadoop3

2022-08-16 Thread Huang Xingbo (Jira)
Huang Xingbo created FLINK-29007: Summary: UsingRemoteJarITCase failed with NPE in hadoop3 Key: FLINK-29007 URL: https://issues.apache.org/jira/browse/FLINK-29007 Project: Flink Issue Type: B

[GitHub] [flink] Mrzyxing commented on a diff in pull request #20510: [FLINK-28815][docs] Translate the Real Time Reporting with the Table API page into Chinese

2022-08-16 Thread GitBox
Mrzyxing commented on code in PR #20510: URL: https://github.com/apache/flink/pull/20510#discussion_r947426395 ## docs/content.zh/docs/try-flink/table_api.md: ## @@ -275,38 +270,38 @@ public static Table report(Table transactions) { } ``` -This defines your application as us

[GitHub] [flink] Mrzyxing commented on a diff in pull request #20510: [FLINK-28815][docs] Translate the Real Time Reporting with the Table API page into Chinese

2022-08-16 Thread GitBox
Mrzyxing commented on code in PR #20510: URL: https://github.com/apache/flink/pull/20510#discussion_r947419792 ## docs/content.zh/docs/try-flink/table_api.md: ## @@ -163,44 +161,41 @@ tEnv.executeSql("CREATE TABLE spend_report (\n" + ")"); ``` -The second table, `spend_r

[GitHub] [flink] Mrzyxing commented on a diff in pull request #20510: [FLINK-28815][docs] Translate the Real Time Reporting with the Table API page into Chinese

2022-08-16 Thread GitBox
Mrzyxing commented on code in PR #20510: URL: https://github.com/apache/flink/pull/20510#discussion_r947419000 ## docs/content.zh/docs/try-flink/table_api.md: ## @@ -163,44 +161,41 @@ tEnv.executeSql("CREATE TABLE spend_report (\n" + ")"); ``` -The second table, `spend_r

[jira] [Commented] (FLINK-22827) Hive dialect supports CLUSTERED BY clause of CREATE TABLE DDL

2022-08-16 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580544#comment-17580544 ] luoyuxia commented on FLINK-22827: -- [~aidenma] Thanks for your attention. If you have a

[GitHub] [flink] Mrzyxing commented on a diff in pull request #20510: [FLINK-28815][docs] Translate the Real Time Reporting with the Table API page into Chinese

2022-08-16 Thread GitBox
Mrzyxing commented on code in PR #20510: URL: https://github.com/apache/flink/pull/20510#discussion_r947418223 ## docs/content.zh/docs/try-flink/table_api.md: ## @@ -28,51 +28,49 @@ under the License. # 基于 Table API 实现实时报表 -Apache Flink offers a Table API as a unified, rela

[GitHub] [flink] Mrzyxing commented on a diff in pull request #20510: [FLINK-28815][docs] Translate the Real Time Reporting with the Table API page into Chinese

2022-08-16 Thread GitBox
Mrzyxing commented on code in PR #20510: URL: https://github.com/apache/flink/pull/20510#discussion_r947418327 ## docs/content.zh/docs/try-flink/table_api.md: ## @@ -109,25 +107,25 @@ report(transactions).executeInsert("spend_report"); ``` -## Breaking Down The Code +## 代码分

[jira] [Commented] (FLINK-29006) PulsarSourceITCase failed with Could not acquire the minimum required resources.

2022-08-16 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580543#comment-17580543 ] Huang Xingbo commented on FLINK-29006: -- [~syhily] Could you help take a look? Thx.

[jira] [Created] (FLINK-29006) PulsarSourceITCase failed with Could not acquire the minimum required resources.

2022-08-16 Thread Huang Xingbo (Jira)
Huang Xingbo created FLINK-29006: Summary: PulsarSourceITCase failed with Could not acquire the minimum required resources. Key: FLINK-29006 URL: https://issues.apache.org/jira/browse/FLINK-29006 Proj

[jira] [Resolved] (FLINK-26411) Hive dialect supports CLUSTERED BY/ SORTED BY table

2022-08-16 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia resolved FLINK-26411. -- Resolution: Duplicate > Hive dialect supports CLUSTERED BY/ SORTED BY table > ---

[jira] [Updated] (FLINK-26411) Hive dialect supports CLUSTERED BY/ SORTED BY table

2022-08-16 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-26411: - Fix Version/s: 1.16.0 > Hive dialect supports CLUSTERED BY/ SORTED BY table > -

[jira] [Updated] (FLINK-28429) Reduce pyflink tests time

2022-08-16 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huang Xingbo updated FLINK-28429: - Priority: Critical (was: Major) > Reduce pyflink tests time > - > >

[GitHub] [flink] flinkbot commented on pull request #20607: PyFlink supports specifying index-url when installing third-party dependencies

2022-08-16 Thread GitBox
flinkbot commented on PR #20607: URL: https://github.com/apache/flink/pull/20607#issuecomment-1217406734 ## CI report: * 8186d12303b8cf92e54dc61b3c03eee3d54120d8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Closed] (FLINK-28925) Fix the concurrency problem in hybrid shuffle

2022-08-16 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song closed FLINK-28925. Resolution: Fixed master (1.16): 7ed817f2054a13c3e2754c37f7681d8fbdba4b41 > Fix the concurrency p

[GitHub] [flink] xintongsong closed pull request #20591: [FLINK-28925] Fix the concurrency problem in hybrid shuffle

2022-08-16 Thread GitBox
xintongsong closed pull request #20591: [FLINK-28925] Fix the concurrency problem in hybrid shuffle URL: https://github.com/apache/flink/pull/20591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Comment Edited] (FLINK-28984) FsCheckpointStateOutputStream is not being released normally

2022-08-16 Thread ChangjiGuo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580099#comment-17580099 ] ChangjiGuo edited comment on FLINK-28984 at 8/17/22 3:06 AM: -

[GitHub] [flink] WencongLiu commented on pull request #20574: [FLINK-28963][sql-gateway]Add API compatibility test for sql gateway rest endpoint

2022-08-16 Thread GitBox
WencongLiu commented on PR #20574: URL: https://github.com/apache/flink/pull/20574#issuecomment-1217404294 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [flink] xintongsong commented on a diff in pull request #20553: [FLINK-28800][network] HsFileDataManager should avoid busy-loop when fileReader has not data to read

2022-08-16 Thread GitBox
xintongsong commented on code in PR #20553: URL: https://github.com/apache/flink/pull/20553#discussion_r947407205 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/HsFileDataManager.java: ## @@ -147,6 +148,17 @@ public void setup() { // con

[GitHub] [flink-ml] zhipeng93 commented on pull request #141: [FLINK-28805] Add Transformer for HashingTF

2022-08-16 Thread GitBox
zhipeng93 commented on PR #141: URL: https://github.com/apache/flink-ml/pull/141#issuecomment-1217402980 @yunfengzhou-hub Thanks for the review. The PR is updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #141: [FLINK-28805] Add Transformer for HashingTF

2022-08-16 Thread GitBox
zhipeng93 commented on code in PR #141: URL: https://github.com/apache/flink-ml/pull/141#discussion_r947400349 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/hashingtf/HashingTF.java: ## @@ -0,0 +1,193 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #141: [FLINK-28805] Add Transformer for HashingTF

2022-08-16 Thread GitBox
zhipeng93 commented on code in PR #141: URL: https://github.com/apache/flink-ml/pull/141#discussion_r947406219 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/hashingtf/HashingTF.java: ## @@ -0,0 +1,193 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Commented] (FLINK-22827) Hive dialect supports CLUSTERED BY clause of CREATE TABLE DDL

2022-08-16 Thread Ma Jun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580540#comment-17580540 ] Ma Jun commented on FLINK-22827: [~luoyuxia] Thank you!  I merge you branch to my branch

[GitHub] [flink] jlon opened a new pull request, #20607: PyFlink supports specifying index-url when installing third-party dependencies

2022-08-16 Thread GitBox
jlon opened a new pull request, #20607: URL: https://github.com/apache/flink/pull/20607 ## What is the purpose of the change PyFlink supports specifying index-url when installing third-party dependencies。 When we use pyflink, if there is a third-party dependency, when using pip to

[jira] [Created] (FLINK-29005) Parquet row type reader should not return null value when some child fields is null

2022-08-16 Thread dalongliu (Jira)
dalongliu created FLINK-29005: - Summary: Parquet row type reader should not return null value when some child fields is null Key: FLINK-29005 URL: https://issues.apache.org/jira/browse/FLINK-29005 Projec

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #141: [FLINK-28805] Add Transformer for HashingTF

2022-08-16 Thread GitBox
zhipeng93 commented on code in PR #141: URL: https://github.com/apache/flink-ml/pull/141#discussion_r947400349 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/hashingtf/HashingTF.java: ## @@ -0,0 +1,193 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #141: [FLINK-28805] Add Transformer for HashingTF

2022-08-16 Thread GitBox
zhipeng93 commented on code in PR #141: URL: https://github.com/apache/flink-ml/pull/141#discussion_r947399605 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/hashingtf/HashingTF.java: ## @@ -0,0 +1,193 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [flink-ml] zhipeng93 commented on pull request #139: [FLINK-28803] Add Transformer and Estimator for KBinsDiscretizer

2022-08-16 Thread GitBox
zhipeng93 commented on PR #139: URL: https://github.com/apache/flink-ml/pull/139#issuecomment-1217392085 @yunfengzhou-hub Thanks for the review. I have addressed your comments in the PR. @lindong28 Do you want to take a look? -- This is an automated message from the Apache Git Service

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #139: [FLINK-28803] Add Transformer and Estimator for KBinsDiscretizer

2022-08-16 Thread GitBox
zhipeng93 commented on code in PR #139: URL: https://github.com/apache/flink-ml/pull/139#discussion_r947397118 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/kbinsdiscretizer/KBinsDiscretizerParams.java: ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [flink] godfreyhe commented on a diff in pull request #20592: [FLINK-28987][table-planner] Updates description of lookup join transformation with async params and retry strategy for easier de

2022-08-16 Thread GitBox
godfreyhe commented on code in PR #20592: URL: https://github.com/apache/flink/pull/20592#discussion_r947394831 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecLookupJoin.java: ## @@ -411,6 +426,55 @@ private Trans

[GitHub] [flink] wuchong commented on pull request #20176: [FLINK-27660][table] add table api for registering function with resource

2022-08-16 Thread GitBox
wuchong commented on PR #20176: URL: https://github.com/apache/flink/pull/20176#issuecomment-1217386365 @lsyldliu , could you help to continue review this PR when you are free? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #139: [FLINK-28803] Add Transformer and Estimator for KBinsDiscretizer

2022-08-16 Thread GitBox
zhipeng93 commented on code in PR #139: URL: https://github.com/apache/flink-ml/pull/139#discussion_r947392648 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/kbinsdiscretizer/KBinsDiscretizer.java: ## @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [flink] swuferhong commented on pull request #20513: [FLINK-28858][docs] Add document to describe join hints for batch sql

2022-08-16 Thread GitBox
swuferhong commented on PR #20513: URL: https://github.com/apache/flink/pull/20513#issuecomment-1217382778 > @swuferhong for the structure of the document, my suggestion is like follows: > > ## Query Hints > some description... > > ### Syntax > ```sql > query hints:

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #139: [FLINK-28803] Add Transformer and Estimator for KBinsDiscretizer

2022-08-16 Thread GitBox
zhipeng93 commented on code in PR #139: URL: https://github.com/apache/flink-ml/pull/139#discussion_r947391377 ## flink-ml-lib/src/test/java/org/apache/flink/ml/feature/KBinsDiscretizerTest.java: ## @@ -0,0 +1,296 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [flink] swuferhong commented on a diff in pull request #20513: [FLINK-28858][docs] Add document to describe join hints for batch sql

2022-08-16 Thread GitBox
swuferhong commented on code in PR #20513: URL: https://github.com/apache/flink/pull/20513#discussion_r947390996 ## docs/content/docs/dev/table/sql/queries/hints.md: ## @@ -84,4 +84,219 @@ insert into kafka_table1 /*+ OPTIONS('sink.partitioner'='round-robin') */ select ```

[GitHub] [flink] swuferhong commented on a diff in pull request #20513: [FLINK-28858][docs] Add document to describe join hints for batch sql

2022-08-16 Thread GitBox
swuferhong commented on code in PR #20513: URL: https://github.com/apache/flink/pull/20513#discussion_r947390796 ## docs/content.zh/docs/dev/table/sql/queries/hints.md: ## @@ -79,4 +79,209 @@ insert into kafka_table1 /*+ OPTIONS('sink.partitioner'='round-robin') */ select ``

[GitHub] [flink] swuferhong commented on a diff in pull request #20513: [FLINK-28858][docs] Add document to describe join hints for batch sql

2022-08-16 Thread GitBox
swuferhong commented on code in PR #20513: URL: https://github.com/apache/flink/pull/20513#discussion_r947390429 ## docs/content/docs/dev/table/sql/queries/hints.md: ## @@ -84,4 +84,222 @@ insert into kafka_table1 /*+ OPTIONS('sink.partitioner'='round-robin') */ select ```

[jira] [Commented] (FLINK-29004) pyflink supports specifying index-url when installing third-party dependencies

2022-08-16 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580532#comment-17580532 ] Huang Xingbo commented on FLINK-29004: -- Hi [~long jiang], pyflink support specifyin

[jira] [Resolved] (FLINK-29004) pyflink supports specifying index-url when installing third-party dependencies

2022-08-16 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huang Xingbo resolved FLINK-29004. -- Resolution: Not A Problem > pyflink supports specifying index-url when installing third-party

[jira] [Resolved] (FLINK-22827) Hive dialect supports CLUSTERED BY clause of CREATE TABLE DDL

2022-08-16 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia resolved FLINK-22827. -- Resolution: Duplicate > Hive dialect supports CLUSTERED BY clause of CREATE TABLE DDL > --

[jira] [Commented] (FLINK-27748) AdaptiveScheduler should support operator fixed parallelism

2022-08-16 Thread john (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580525#comment-17580525 ] john commented on FLINK-27748: -- [~knaufk]  Probably not, maxParallelism controls the total

[jira] [Created] (FLINK-29004) pyflink supports specifying index-url when installing third-party dependencies

2022-08-16 Thread john (Jira)
john created FLINK-29004: Summary: pyflink supports specifying index-url when installing third-party dependencies Key: FLINK-29004 URL: https://issues.apache.org/jira/browse/FLINK-29004 Project: Flink

[GitHub] [flink] lsyldliu commented on pull request #20602: [FLINK-28917][table-runtime] Add sql test for adaptive hash join

2022-08-16 Thread GitBox
lsyldliu commented on PR #20602: URL: https://github.com/apache/flink/pull/20602#issuecomment-1217351497 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] liuzhuang2017 commented on pull request #20551: [FLINK-28922][docs-zh] Translate "ORDER BY clause" page into Chinese.

2022-08-16 Thread GitBox
liuzhuang2017 commented on PR #20551: URL: https://github.com/apache/flink/pull/20551#issuecomment-1217341663 @wuchong , Can you help me review this pr?Thank you very much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [flink] liuzhuang2017 commented on pull request #20552: [FLINK-28924][docs-zh] Translate "LIMIT clause" page into Chinese.

2022-08-16 Thread GitBox
liuzhuang2017 commented on PR #20552: URL: https://github.com/apache/flink/pull/20552#issuecomment-1217340054 @wuchong , Can you help me review this pr?Thank you very much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [flink] gezhiwei8899 commented on pull request #18956: [FLINK-26394] CheckpointCoordinator.isTriggering can not be reset in a particular case.

2022-08-16 Thread GitBox
gezhiwei8899 commented on PR #18956: URL: https://github.com/apache/flink/pull/18956#issuecomment-1217259306 ![image](https://user-images.githubusercontent.com/16362526/185000431-cda381d5-d1ab-4bc5-9a19-686d6c88eb06.png) -- This is an automated message from the Apache Git Service. To

[jira] [Closed] (FLINK-27917) PulsarUnorderedPartitionSplitReaderTest.consumeMessageCreatedBeforeHandleSplitsChangesAndResetToEarliestPosition failed with AssertionError

2022-08-16 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen closed FLINK-27917. - Resolution: Fixed master via f7af9f6462be9cac80d6c433a4abdcc8db8c84aa [~syhily] since affected versions

[jira] [Updated] (FLINK-27917) PulsarUnorderedPartitionSplitReaderTest.consumeMessageCreatedBeforeHandleSplitsChangesAndResetToEarliestPosition failed with AssertionError

2022-08-16 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen updated FLINK-27917: -- Fix Version/s: 1.16.0 > PulsarUnorderedPartitionSplitReaderTest.consumeMessageCreatedBeforeHandleSplit

[GitHub] [flink] tisonkun merged pull request #20567: [FLINK-27917][Connector/Pulsar] Fix message assert error in PulsarUnorderedPartitionSplitReaderTest

2022-08-16 Thread GitBox
tisonkun merged PR #20567: URL: https://github.com/apache/flink/pull/20567 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[GitHub] [flink] tisonkun commented on pull request #20567: [FLINK-27917][Connector/Pulsar] Fix message assert error in PulsarUnorderedPartitionSplitReaderTest

2022-08-16 Thread GitBox
tisonkun commented on PR #20567: URL: https://github.com/apache/flink/pull/20567#issuecomment-1217255393 Merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [flink] gezhiwei8899 commented on pull request #18956: [FLINK-26394] CheckpointCoordinator.isTriggering can not be reset in a particular case.

2022-08-16 Thread GitBox
gezhiwei8899 commented on PR #18956: URL: https://github.com/apache/flink/pull/18956#issuecomment-1217249603 Never trigger ckp again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [flink] gezhiwei8899 commented on pull request #18956: [FLINK-26394] CheckpointCoordinator.isTriggering can not be reset in a particular case.

2022-08-16 Thread GitBox
gezhiwei8899 commented on PR #18956: URL: https://github.com/apache/flink/pull/18956#issuecomment-1217249127 ![image](https://user-images.githubusercontent.com/16362526/184998667-cad027df-00cf-4e6c-9d28-c9e52ef25626.png) -- This is an automated message from the Apache Git Service. To

[jira] [Updated] (FLINK-15867) LAST_VALUE and FIRST_VALUE aggregate function does not support time-related types

2022-08-16 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-15867: --- Labels: auto-deprioritized-major auto-deprioritized-minor auto-unassigned pull-request-ava

[jira] [Updated] (FLINK-21278) NullpointExecption error is reported when using the evictor method to filter the data before the window calculation

2022-08-16 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-21278: --- Labels: auto-deprioritized-critical auto-deprioritized-major auto-deprioritized-minor pull

[GitHub] [flink] JingGe commented on pull request #20235: [Flink 14101][Connectors][Jdbc] SQL Server dialect

2022-08-16 Thread GitBox
JingGe commented on PR #20235: URL: https://github.com/apache/flink/pull/20235#issuecomment-1217195964 @qingwei91 would you like to do the following clean-up: 1. squash commits and please make sure the commit message follows Flink rule. 2. rebase to the master. 3. Replace "[Flink 141

[GitHub] [flink] JingGe commented on a diff in pull request #20235: [Flink 14101][Connectors][Jdbc] SQL Server dialect

2022-08-16 Thread GitBox
JingGe commented on code in PR #20235: URL: https://github.com/apache/flink/pull/20235#discussion_r947270277 ## flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/sqlserver/SqlServerDialect.java: ## @@ -0,0 +1,162 @@ +/* + * Licensed to t

[jira] [Created] (FLINK-29003) sqlServerDialect should support limit clause

2022-08-16 Thread Jing Ge (Jira)
Jing Ge created FLINK-29003: --- Summary: sqlServerDialect should support limit clause Key: FLINK-29003 URL: https://issues.apache.org/jira/browse/FLINK-29003 Project: Flink Issue Type: New Feature

[jira] [Commented] (FLINK-28817) NullPointerException in HybridSource when restoring from checkpoint

2022-08-16 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580458#comment-17580458 ] Danny Cranmer commented on FLINK-28817: --- * Merged commit [{{6e80d90}}|https://git

[jira] [Created] (FLINK-29002) Deprecate Datadog reporter 'tags' option

2022-08-16 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-29002: Summary: Deprecate Datadog reporter 'tags' option Key: FLINK-29002 URL: https://issues.apache.org/jira/browse/FLINK-29002 Project: Flink Issue Type:

[GitHub] [flink] zentol commented on a diff in pull request #20598: [FLINK-28997][datadog] Add switch to use logical identifier

2022-08-16 Thread GitBox
zentol commented on code in PR #20598: URL: https://github.com/apache/flink/pull/20598#discussion_r947179550 ## flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporterFactory.java: ## @@ -26,8 +26,34 @@ /** {@link MetricReporterFac

[GitHub] [flink] zentol commented on a diff in pull request #20598: [FLINK-28997][datadog] Add switch to use logical identifier

2022-08-16 Thread GitBox
zentol commented on code in PR #20598: URL: https://github.com/apache/flink/pull/20598#discussion_r947179110 ## flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporterFactory.java: ## @@ -26,8 +26,34 @@ /** {@link MetricReporterFac

[GitHub] [flink] flinkbot commented on pull request #20606: [FLINK-28978][kinesis] Update AWS Regions validation to allow for fut…

2022-08-16 Thread GitBox
flinkbot commented on PR #20606: URL: https://github.com/apache/flink/pull/20606#issuecomment-1217057063 ## CI report: * 2b49df53205ef21e11e83bfd31749f5d0f9e4ec0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #20605: [FLINK-28978][kinesis] Update AWS Regions validation to allow for fut…

2022-08-16 Thread GitBox
flinkbot commented on PR #20605: URL: https://github.com/apache/flink/pull/20605#issuecomment-1217049040 ## CI report: * 5f1aeb0ee4c229717cb5ea74218644ac4eb6bd68 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] hlteoh37 opened a new pull request, #20606: [FLINK-28978][kinesis] Update AWS Regions validation to allow for fut…

2022-08-16 Thread GitBox
hlteoh37 opened a new pull request, #20606: URL: https://github.com/apache/flink/pull/20606 …ure AWS regions ## What is the purpose of the change Make the validation for `AWS Region` string passed into the Kinesis connector more permissive (checks that the shape of the string follo

[GitHub] [flink] hlteoh37 opened a new pull request, #20605: [FLINK-28978][kinesis] Update AWS Regions validation to allow for fut…

2022-08-16 Thread GitBox
hlteoh37 opened a new pull request, #20605: URL: https://github.com/apache/flink/pull/20605 …ure AWS regions ## What is the purpose of the change Make the validation for `AWS Region` string passed into the Kinesis connector more permissive (checks that the shape of the string follo

[GitHub] [flink] flinkbot commented on pull request #20604: FLINK-27107. Typo in Task.

2022-08-16 Thread GitBox
flinkbot commented on PR #20604: URL: https://github.com/apache/flink/pull/20604#issuecomment-1217018246 ## CI report: * d7f98e34cf50eed96658fa1f29954a30f24b2c15 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-28094) Upgrade AWS SDK to support ap-southeast-3

2022-08-16 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-28094: -- Summary: Upgrade AWS SDK to support ap-southeast-3 (was: [aws][connectors][formats] Upgrade

[jira] [Updated] (FLINK-28978) Kinesis connector doesn't work for new AWS regions

2022-08-16 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-28978: -- Summary: Kinesis connector doesn't work for new AWS regions (was: [aws][connectors] Kinesis c

[jira] [Updated] (FLINK-28975) withIdleness marks all streams from FLIP-27 sources as idle

2022-08-16 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-28975: -- Fix Version/s: 1.15.3 (was: 1.15.2) > withIdleness marks all streams fr

[jira] [Updated] (FLINK-27107) Typo in Task

2022-08-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27107: --- Labels: pull-request-available (was: ) > Typo in Task > > > Ke

[GitHub] [flink] HarshaR99 opened a new pull request, #20604: FLINK-27107. Typo in Task.

2022-08-16 Thread GitBox
HarshaR99 opened a new pull request, #20604: URL: https://github.com/apache/flink/pull/20604 ## What is the purpose of the change Link to the Apache JIRA :- https://issues.apache.org/jira/browse/FLINK-27107 Two small typos in Task TaskCancelerWatchDog/TaskInterrup

[jira] [Updated] (FLINK-28909) Add ribbon filter policy option in RocksDBConfiguredOptions

2022-08-16 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-28909: -- Fix Version/s: 1.15.3 (was: 1.15.2) > Add ribbon filter policy option i

  1   2   3   >