[GitHub] [flink-kubernetes-operator] gaborgsomogyi commented on pull request #364: [FLINK-28272] Handle TLS Certificate Renewal in Webhook

2022-09-07 Thread GitBox
gaborgsomogyi commented on PR #364: URL: https://github.com/apache/flink-kubernetes-operator/pull/364#issuecomment-1238987557 @mbalassi @morhidi I've considered the doc in-depth and I think better to do it in separate jira since there is no doc for the webhook in general. -- This is an a

[GitHub] [flink-kubernetes-operator] SteNicholas commented on a diff in pull request #364: [FLINK-28272] Handle TLS Certificate Renewal in Webhook

2022-09-07 Thread GitBox
SteNicholas commented on code in PR #364: URL: https://github.com/apache/flink-kubernetes-operator/pull/364#discussion_r964458293 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/fs/FileSystemWatchService.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed

[GitHub] [flink] gaoyunhaii commented on a diff in pull request #20534: [FLINK-28860] Fix CacheITCase

2022-09-07 Thread GitBox
gaoyunhaii commented on code in PR #20534: URL: https://github.com/apache/flink/pull/20534#discussion_r964342154 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/JobMasterPartitionTracker.java: ## @@ -57,15 +59,32 @@ void stopTrackingAndReleasePartiti

[GitHub] [flink] luoyuxia commented on a diff in pull request #20696: [FLINK-29025][docs] add docs for Hive dialect

2022-09-07 Thread GitBox
luoyuxia commented on code in PR #20696: URL: https://github.com/apache/flink/pull/20696#discussion_r964462819 ## docs/content/docs/dev/table/hiveCompatibility/hiveDialect/overview.md: ## @@ -0,0 +1,97 @@ +--- +title: "Overview" +weight: 1 +type: docs +aliases: +- /dev/table/hiv

[jira] [Commented] (FLINK-29216) rows belong to update rowkind are transfered into delete and insert

2022-09-07 Thread Spongebob (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601167#comment-17601167 ] Spongebob commented on FLINK-29216: --- Thanks [~lincoln.86xy] , it apparents normal when

[jira] [Commented] (FLINK-28461) PyFlink Table should add get_resolved_schema method

2022-09-07 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601169#comment-17601169 ] Xingbo Huang commented on FLINK-28461: -- Thanks [~bzhaoop] . I have assigned it to y

[jira] [Assigned] (FLINK-28461) PyFlink Table should add get_resolved_schema method

2022-09-07 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang reassigned FLINK-28461: Assignee: bo zhao > PyFlink Table should add get_resolved_schema method > ---

[jira] [Commented] (FLINK-27929) Drop support for python 3.6

2022-09-07 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601170#comment-17601170 ] Xingbo Huang commented on FLINK-27929: -- Thanks [~bzhaoop] . I have assigned it to y

[jira] [Assigned] (FLINK-27929) Drop support for python 3.6

2022-09-07 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang reassigned FLINK-27929: Assignee: bo zhao > Drop support for python 3.6 > --- > >

[GitHub] [flink] luoyuxia commented on a diff in pull request #20696: [FLINK-29025][docs] add docs for Hive dialect

2022-09-07 Thread GitBox
luoyuxia commented on code in PR #20696: URL: https://github.com/apache/flink/pull/20696#discussion_r964480454 ## docs/content.zh/docs/dev/table/hiveCompatibility/hiveDialect/Queries/overview.md: ## @@ -0,0 +1,163 @@ +--- +title: "Overview" +weight: 1 +type: docs +aliases: +- /d

[GitHub] [flink] JingGe commented on pull request #20235: [Flink-14101][Connectors][Jdbc] SQL Server dialect

2022-09-07 Thread GitBox
JingGe commented on PR #20235: URL: https://github.com/apache/flink/pull/20235#issuecomment-1239017424 @PatrickRen Would you like to merge this PR? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] swuferhong opened a new pull request, #20777: [FLINK-27402] Fix unexpected boolean expression simplification for filter condition between varchar type and boolean values true/false

2022-09-07 Thread GitBox
swuferhong opened a new pull request, #20777: URL: https://github.com/apache/flink/pull/20777 ## What is the purpose of the change For sql statement `select * from c1 = 1 and c2 = true; `, if `c2` is varchar type, filter condition `c2 = true` will be incorrectly simpl

[jira] [Updated] (FLINK-27402) Unexpected boolean expression simplification for AND expression

2022-09-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27402: --- Labels: pull-request-available (was: ) > Unexpected boolean expression simplification for

[GitHub] [flink] luoyuxia commented on a diff in pull request #20696: [FLINK-29025][docs] add docs for Hive dialect

2022-09-07 Thread GitBox
luoyuxia commented on code in PR #20696: URL: https://github.com/apache/flink/pull/20696#discussion_r964489186 ## docs/content.zh/docs/dev/table/hiveCompatibility/hiveDialect/Queries/overview.md: ## @@ -0,0 +1,163 @@ +--- +title: "Overview" +weight: 1 +type: docs +aliases: +- /d

[GitHub] [flink] SubNader commented on pull request #15491: [FLINK-21966][python]Support Kinesis connector in Python DataStream API

2022-09-07 Thread GitBox
SubNader commented on PR #15491: URL: https://github.com/apache/flink/pull/15491#issuecomment-1239021381 @xinbinhuang this would be very nice to have. Let me know if I can help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] flinkbot commented on pull request #20777: [FLINK-27402] Fix unexpected boolean expression simplification for filter condition between varchar type and boolean values true/false

2022-09-07 Thread GitBox
flinkbot commented on PR #20777: URL: https://github.com/apache/flink/pull/20777#issuecomment-1239025583 ## CI report: * 265511cf0c7401eb608ef3f619399c886b2f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-29069) Release Testing: Verify FLIP-218 Create table as select syntax

2022-09-07 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601175#comment-17601175 ] Qingsheng Ren commented on FLINK-29069: --- # Used CTAS syntax to create a Kafka sink

[GitHub] [flink] luoyuxia commented on a diff in pull request #20696: [FLINK-29025][docs] add docs for Hive dialect

2022-09-07 Thread GitBox
luoyuxia commented on code in PR #20696: URL: https://github.com/apache/flink/pull/20696#discussion_r964494659 ## docs/content.zh/docs/dev/table/hiveCompatibility/hiveDialect/Queries/sort-cluster-distribute-by.md: ## @@ -0,0 +1,94 @@ +--- +title: "Sort/Cluster/Distributed By" +w

[GitHub] [flink] gaoyunhaii commented on a diff in pull request #20235: [Flink-14101][Connectors][Jdbc] SQL Server dialect

2022-09-07 Thread GitBox
gaoyunhaii commented on code in PR #20235: URL: https://github.com/apache/flink/pull/20235#discussion_r939799891 ## flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/dialect/sqlserver/SqlServerTableSinkITCase.java: ## @@ -0,0 +1,492 @@ +/* + * L

[GitHub] [flink] gaoyunhaii commented on pull request #20235: [Flink-14101][Connectors][Jdbc] SQL Server dialect

2022-09-07 Thread GitBox
gaoyunhaii commented on PR #20235: URL: https://github.com/apache/flink/pull/20235#issuecomment-1239030600 Thanks @qingwei91 for the PR and everyone for the reviewing and tracking! I could help merging the PR~ -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Created] (FLINK-29218) ADD JAR syntax could not work with Hive catalog in SQL client

2022-09-07 Thread Qingsheng Ren (Jira)
Qingsheng Ren created FLINK-29218: - Summary: ADD JAR syntax could not work with Hive catalog in SQL client Key: FLINK-29218 URL: https://issues.apache.org/jira/browse/FLINK-29218 Project: Flink

[GitHub] [flink] luoyuxia commented on a diff in pull request #20696: [FLINK-29025][docs] add docs for Hive dialect

2022-09-07 Thread GitBox
luoyuxia commented on code in PR #20696: URL: https://github.com/apache/flink/pull/20696#discussion_r964505352 ## docs/content.zh/docs/dev/table/hiveCompatibility/hiveDialect/Queries/group-by.md: ## @@ -0,0 +1,129 @@ +--- +title: "Group By" +weight: 3 +type: docs +--- + + +# Gro

[jira] [Created] (FLINK-29219) CREATE TABLE AS statement blocks SQL client's execution

2022-09-07 Thread Qingsheng Ren (Jira)
Qingsheng Ren created FLINK-29219: - Summary: CREATE TABLE AS statement blocks SQL client's execution Key: FLINK-29219 URL: https://issues.apache.org/jira/browse/FLINK-29219 Project: Flink Iss

[GitHub] [flink] gaoyunhaii closed pull request #20235: [Flink-14101][Connectors][Jdbc] SQL Server dialect

2022-09-07 Thread GitBox
gaoyunhaii closed pull request #20235: [Flink-14101][Connectors][Jdbc] SQL Server dialect URL: https://github.com/apache/flink/pull/20235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] gaoyunhaii commented on pull request #20235: [Flink-14101][Connectors][Jdbc] SQL Server dialect

2022-09-07 Thread GitBox
gaoyunhaii commented on PR #20235: URL: https://github.com/apache/flink/pull/20235#issuecomment-1239055514 Merge on master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] luoyuxia commented on a diff in pull request #20696: [FLINK-29025][docs] add docs for Hive dialect

2022-09-07 Thread GitBox
luoyuxia commented on code in PR #20696: URL: https://github.com/apache/flink/pull/20696#discussion_r964524728 ## docs/content.zh/docs/dev/table/hiveCompatibility/hiveDialect/Queries/join.md: ## @@ -0,0 +1,105 @@ +--- +title: "Join" +weight: 4 +type: docs +--- + + +# Join + +##

[jira] [Commented] (FLINK-14101) Introduce SqlServerDialect

2022-09-07 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601192#comment-17601192 ] Yun Gao commented on FLINK-14101: - Merge on master via a8ca381c57788cd1a1527e4ebdc19bdbc

[jira] [Closed] (FLINK-14101) Introduce SqlServerDialect

2022-09-07 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Gao closed FLINK-14101. --- Fix Version/s: 1.17.0 Resolution: Fixed > Introduce SqlServerDialect > -- > >

[jira] [Reopened] (FLINK-14101) Introduce SqlServerDialect

2022-09-07 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Gao reopened FLINK-14101: - > Introduce SqlServerDialect > -- > > Key: FLINK-14101 >

[jira] [Closed] (FLINK-14101) Introduce SqlServerDialect

2022-09-07 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Gao closed FLINK-14101. --- Release Note: This issue introduce the support of Microsoft SQLSever dialect in the jdbc connector. R

[jira] [Updated] (FLINK-14101) Introduce SqlServerDialect

2022-09-07 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Gao updated FLINK-14101: Release Note: This issue introduces the support of Microsoft SQLSever dialect in the jdbc connector. (wa

[jira] [Closed] (FLINK-29069) Release Testing: Verify FLIP-218 Create table as select syntax

2022-09-07 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren closed FLINK-29069. - Resolution: Resolved > Release Testing: Verify FLIP-218 Create table as select syntax >

[GitHub] [flink] MartijnVisser commented on pull request #20640: [hotfix][docs] Fix some formatting errors in Chinese documents.

2022-09-07 Thread GitBox
MartijnVisser commented on PR #20640: URL: https://github.com/apache/flink/pull/20640#issuecomment-1239069610 @liuzhuang2017 Can you please fetch all upstream commits, rebase and push again? Right now all tests fail which make it not possible to merge. Something like: - `git fetch

[GitHub] [flink] luoyuxia commented on a diff in pull request #20696: [FLINK-29025][docs] add docs for Hive dialect

2022-09-07 Thread GitBox
luoyuxia commented on code in PR #20696: URL: https://github.com/apache/flink/pull/20696#discussion_r964572857 ## docs/content.zh/docs/dev/table/hiveCompatibility/hiveDialect/Queries/sub-queries.md: ## @@ -0,0 +1,69 @@ +--- +title: "Sub-Queries" +weight: 8 +type: docs +--- + + +

[GitHub] [flink] luoyuxia commented on a diff in pull request #20696: [FLINK-29025][docs] add docs for Hive dialect

2022-09-07 Thread GitBox
luoyuxia commented on code in PR #20696: URL: https://github.com/apache/flink/pull/20696#discussion_r964579483 ## docs/content.zh/docs/dev/table/hiveCompatibility/hiveDialect/Queries/transform.md: ## @@ -0,0 +1,129 @@ +--- +title: "Transform Clause" +weight: 10 +type: docs +---

[GitHub] [flink] luoyuxia commented on a diff in pull request #20696: [FLINK-29025][docs] add docs for Hive dialect

2022-09-07 Thread GitBox
luoyuxia commented on code in PR #20696: URL: https://github.com/apache/flink/pull/20696#discussion_r964584086 ## docs/content.zh/docs/dev/table/hiveCompatibility/hiveDialect/create.md: ## @@ -0,0 +1,247 @@ +--- +title: "CREATE Statements" +weight: 2 +type: docs +aliases: +- /de

[jira] [Created] (FLINK-29220) Skip ci tests on docs-only-PRs

2022-09-07 Thread Xingbo Huang (Jira)
Xingbo Huang created FLINK-29220: Summary: Skip ci tests on docs-only-PRs Key: FLINK-29220 URL: https://issues.apache.org/jira/browse/FLINK-29220 Project: Flink Issue Type: Improvement

[jira] [Assigned] (FLINK-29220) Skip ci tests on docs-only-PRs

2022-09-07 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang reassigned FLINK-29220: Assignee: Xingbo Huang > Skip ci tests on docs-only-PRs > --

[jira] [Created] (FLINK-29221) Adding join hint in sql may cause imcompatible state

2022-09-07 Thread xuyang (Jira)
xuyang created FLINK-29221: -- Summary: Adding join hint in sql may cause imcompatible state Key: FLINK-29221 URL: https://issues.apache.org/jira/browse/FLINK-29221 Project: Flink Issue Type: Improvem

[GitHub] [flink] snuyanzin commented on pull request #19782: [FLINK-27640] Suggest use of maven wrapper (mvnw)

2022-09-07 Thread GitBox
snuyanzin commented on PR #19782: URL: https://github.com/apache/flink/pull/19782#issuecomment-1239155381 Probably also makes sense to add this to `docs/content/docs/flinkDev/ide_setup.md` ``` 7. Set up maven home path to maven-wrapper. Go to "File" → "Settings" → "Build,Executi

[GitHub] [flink] snuyanzin commented on pull request #20753: [FLINK-29201][docs] Add setting up of maven-wrapper

2022-09-07 Thread GitBox
snuyanzin commented on PR #20753: URL: https://github.com/apache/flink/pull/20753#issuecomment-1239156355 closed in favor of https://github.com/apache/flink/pull/19782 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [flink] snuyanzin closed pull request #20753: [FLINK-29201][docs] Add setting up of maven-wrapper

2022-09-07 Thread GitBox
snuyanzin closed pull request #20753: [FLINK-29201][docs] Add setting up of maven-wrapper URL: https://github.com/apache/flink/pull/20753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-29201) Some tests from flink-sql-client, flink-connector-hive are not compiling in IntellijIdea with new maven

2022-09-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29201: --- Labels: pull-request-available (was: ) > Some tests from flink-sql-client, flink-connector-

[jira] [Closed] (FLINK-29197) Translate the IDE setup documentation into Chinese

2022-09-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin closed FLINK-29197. --- Release Note: closed in favor of https://issues.apache.org/jira/browse/FLINK-27640 Res

[jira] [Commented] (FLINK-29201) Some tests from flink-sql-client, flink-connector-hive are not compiling in IntellijIdea with new maven

2022-09-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601222#comment-17601222 ] Sergey Nuyanzin commented on FLINK-29201: - Thanks for the feedback modified .m2

[jira] [Closed] (FLINK-29201) Some tests from flink-sql-client, flink-connector-hive are not compiling in IntellijIdea with new maven

2022-09-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin closed FLINK-29201. --- Resolution: Duplicate > Some tests from flink-sql-client, flink-connector-hive are not compi

[jira] [Reopened] (FLINK-27917) PulsarUnorderedPartitionSplitReaderTest.consumeMessageCreatedBeforeHandleSplitsChangesAndResetToEarliestPosition failed with AssertionError

2022-09-07 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang reopened FLINK-27917: -- > PulsarUnorderedPartitionSplitReaderTest.consumeMessageCreatedBeforeHandleSplitsChangesAndResetTo

[jira] [Commented] (FLINK-27917) PulsarUnorderedPartitionSplitReaderTest.consumeMessageCreatedBeforeHandleSplitsChangesAndResetToEarliestPosition failed with AssertionError

2022-09-07 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601243#comment-17601243 ] Xingbo Huang commented on FLINK-27917: -- [~syhily] Thanks a lot for the investigatio

[jira] [Assigned] (FLINK-29195) Expose lastCheckpointId metric

2022-09-07 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang reassigned FLINK-29195: Assignee: chenyuzhi > Expose lastCheckpointId metric > --- > >

[jira] [Commented] (FLINK-29195) Expose lastCheckpointId metric

2022-09-07 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601254#comment-17601254 ] Yun Tang commented on FLINK-29195: -- I think this idea is okay, [~stupid_pig] please go

[GitHub] [flink] luoyuxia commented on a diff in pull request #20696: [FLINK-29025][docs] add docs for Hive dialect

2022-09-07 Thread GitBox
luoyuxia commented on code in PR #20696: URL: https://github.com/apache/flink/pull/20696#discussion_r964719930 ## docs/content/docs/dev/table/hiveCompatibility/hiveDialect/load-data.md: ## @@ -0,0 +1,86 @@ +--- +title: "Load Data Statements" +weight: 4 +type: docs +aliases: +- /

[GitHub] [flink] luoyuxia commented on a diff in pull request #20696: [FLINK-29025][docs] add docs for Hive dialect

2022-09-07 Thread GitBox
luoyuxia commented on code in PR #20696: URL: https://github.com/apache/flink/pull/20696#discussion_r964721241 ## docs/content.zh/docs/dev/table/hiveCompatibility/hiveDialect/set.md: ## @@ -0,0 +1,72 @@ +--- +title: "SET Statements" +weight: 8 +type: docs +aliases: +- /dev/table

[GitHub] [flink] bzhaoopenstack commented on a diff in pull request #20642: [FLINK-29047][k8s] Shade fabric8 kubernetes with org.apache.flink.shaded prefix in flink-kubernetes

2022-09-07 Thread GitBox
bzhaoopenstack commented on code in PR #20642: URL: https://github.com/apache/flink/pull/20642#discussion_r964728414 ## flink-dist/pom.xml: ## @@ -715,6 +715,8 @@ under the License. *

[GitHub] [flink] luoyuxia commented on a diff in pull request #20696: [FLINK-29025][docs] add docs for Hive dialect

2022-09-07 Thread GitBox
luoyuxia commented on code in PR #20696: URL: https://github.com/apache/flink/pull/20696#discussion_r964733789 ## docs/content.zh/docs/dev/table/hiveCompatibility/hiveDialect/show.md: ## @@ -0,0 +1,119 @@ +--- +title: "Show Statements" +weight: 5 +type: docs +aliases: +- /dev/ta

[GitHub] [flink] luoyuxia commented on pull request #20774: [FLINK-29191][hive] fix Hive dialect can't get value for the variables set by set command

2022-09-07 Thread GitBox
luoyuxia commented on PR #20774: URL: https://github.com/apache/flink/pull/20774#issuecomment-1239277822 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] rkhachatryan commented on pull request #20723: [FLINK-29158] Fix logging in DefaultCompletedCheckpointStore

2022-09-07 Thread GitBox
rkhachatryan commented on PR #20723: URL: https://github.com/apache/flink/pull/20723#issuecomment-1239281202 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [flink] afedulov commented on a diff in pull request #20757: [FLINK-27919] Add FLIP-27-based source for data generation (FLIP-238)

2022-09-07 Thread GitBox
afedulov commented on code in PR #20757: URL: https://github.com/apache/flink/pull/20757#discussion_r964741596 ## flink-core/src/main/java/org/apache/flink/api/connector/source/lib/DataGeneratorSource.java: ## @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [flink] XComp commented on a diff in pull request #19916: [FLINK-27936][tests] Migrate flink-connector-cassandra to JUnit5

2022-09-07 Thread GitBox
XComp commented on code in PR #19916: URL: https://github.com/apache/flink/pull/19916#discussion_r964749404 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/GenericWriteAheadSinkTest.java: ## @@ -122,15 +123,15 @@ protected void verifyResultsWhe

[jira] [Created] (FLINK-29222) Wrong behavior for Hive's load data inpath

2022-09-07 Thread luoyuxia (Jira)
luoyuxia created FLINK-29222: Summary: Wrong behavior for Hive's load data inpath Key: FLINK-29222 URL: https://issues.apache.org/jira/browse/FLINK-29222 Project: Flink Issue Type: Bug

[GitHub] [flink] liuyongvs commented on pull request #20746: [FLINK-28893][table] Add built-in conv function.

2022-09-07 Thread GitBox
liuyongvs commented on PR #20746: URL: https://github.com/apache/flink/pull/20746#issuecomment-1239309060 hi @twalthr do you have time to review it, thanks? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Updated] (FLINK-29222) Wrong behavior for Hive's load data inpath

2022-09-07 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-29222: - Description: When using the following sql with Hive dialect:   {code:java} load data local inpath 'test

[GitHub] [flink] luoyuxia opened a new pull request, #20778: [FLINK-29222][hive] fix wrong behavior for Hive's load data inpath

2022-09-07 Thread GitBox
luoyuxia opened a new pull request, #20778: URL: https://github.com/apache/flink/pull/20778 ## What is the purpose of the change To fix the wrong behavior for Hive's load data inpath ## Brief change log - Call method `HiveCatalog#loadTable(..., isOverWrite, isSource

[jira] [Updated] (FLINK-29222) Wrong behavior for Hive's load data inpath

2022-09-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29222: --- Labels: pull-request-available (was: ) > Wrong behavior for Hive's load data inpath > -

[jira] [Updated] (FLINK-29222) Wrong behavior for Hive's load data inpath

2022-09-07 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-29222: - Description: In hive, `load data inpath` will remove src file, and `load data local inpath` won't remov

[jira] [Updated] (FLINK-29222) Wrong behavior for Hive's load data inpath

2022-09-07 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-29222: - Description: In hive, `load data inpath` will remove src file, and `load data local inpath` won't remov

[GitHub] [flink] flinkbot commented on pull request #20778: [FLINK-29222][hive] fix wrong behavior for Hive's load data inpath

2022-09-07 Thread GitBox
flinkbot commented on PR #20778: URL: https://github.com/apache/flink/pull/20778#issuecomment-1239331228 ## CI report: * 4f66e9233c9414b6bb9e6cf4db1a7e0fa667eddb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-28171) Adjust Job and Task manager port definitions to work with Istio+mTLS

2022-09-07 Thread John Ervine (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601289#comment-17601289 ] John Ervine commented on FLINK-28171: - Is there tested workaround for this? > Adjus

[GitHub] [flink] afedulov commented on a diff in pull request #20757: [FLINK-27919] Add FLIP-27-based source for data generation (FLIP-238)

2022-09-07 Thread GitBox
afedulov commented on code in PR #20757: URL: https://github.com/apache/flink/pull/20757#discussion_r964807950 ## flink-core/src/main/java/org/apache/flink/api/connector/source/lib/SourceReaderFactory.java: ## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [flink] afedulov commented on a diff in pull request #20757: [FLINK-27919] Add FLIP-27-based source for data generation (FLIP-238)

2022-09-07 Thread GitBox
afedulov commented on code in PR #20757: URL: https://github.com/apache/flink/pull/20757#discussion_r964810222 ## flink-core/src/main/java/org/apache/flink/api/connector/source/lib/util/GeneratingIteratorSourceReader.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Softw

[GitHub] [flink] mxm commented on a diff in pull request #20485: [FLINK-28853][connector-base] Add FLIP-217 support for watermark alignment of source splits

2022-09-07 Thread GitBox
mxm commented on code in PR #20485: URL: https://github.com/apache/flink/pull/20485#discussion_r964820287 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java: ## @@ -559,14 +577,67 @@ private void createOutputForSplits(List newSpli

[GitHub] [flink] mxm commented on a diff in pull request #20485: [FLINK-28853][connector-base] Add FLIP-217 support for watermark alignment of source splits

2022-09-07 Thread GitBox
mxm commented on code in PR #20485: URL: https://github.com/apache/flink/pull/20485#discussion_r964825458 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java: ## @@ -559,14 +577,67 @@ private void createOutputForSplits(List newSpli

[jira] [Commented] (FLINK-28171) Adjust Job and Task manager port definitions to work with Istio+mTLS

2022-09-07 Thread Moshe Elisha (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601303#comment-17601303 ] Moshe Elisha commented on FLINK-28171: -- [~johnboy74]  You can configure Istio to a

[jira] [Commented] (FLINK-29183) flink job ended before window time up while using bounded stream source

2022-09-07 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601316#comment-17601316 ] Weijie Guo commented on FLINK-29183: [~landlord] First of all, the phenomenon you ob

[GitHub] [flink] bzhaoopenstack commented on a diff in pull request #20642: [FLINK-29047][k8s] Shade fabric8 kubernetes with org.apache.flink.shaded prefix in flink-kubernetes

2022-09-07 Thread GitBox
bzhaoopenstack commented on code in PR #20642: URL: https://github.com/apache/flink/pull/20642#discussion_r964871297 ## flink-dist/pom.xml: ## @@ -715,6 +715,8 @@ under the License. *

[jira] [Closed] (FLINK-28411) OperatorCoordinator exception may fail Session Cluster

2022-09-07 Thread Daren Wong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daren Wong closed FLINK-28411. -- Resolution: Won't Fix > OperatorCoordinator exception may fail Session Cluster > -

[GitHub] [flink] darenwkt closed pull request #20186: [FLINK-28411] - Error Handling for OperatorCoordinatorHolder which may fail Session Cluster

2022-09-07 Thread GitBox
darenwkt closed pull request #20186: [FLINK-28411] - Error Handling for OperatorCoordinatorHolder which may fail Session Cluster URL: https://github.com/apache/flink/pull/20186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Assigned] (FLINK-26256) AWS SDK Async Event Loop Group Classloader Issue

2022-09-07 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer reassigned FLINK-26256: - Assignee: (was: Zichen Liu) > AWS SDK Async Event Loop Group Classloader Issue > --

[jira] [Updated] (FLINK-28411) OperatorCoordinator exception may fail Session Cluster

2022-09-07 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-28411: -- Fix Version/s: (was: 1.16.0) (was: 1.15.3) > OperatorCoordinator ex

[GitHub] [flink] MartijnVisser merged pull request #20766: [FLINK-29210][Docs][SQL Client] Add required parameter when running SQL Client via Docker Compose

2022-09-07 Thread GitBox
MartijnVisser merged PR #20766: URL: https://github.com/apache/flink/pull/20766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

[jira] [Closed] (FLINK-29210) Documented SQL Client setup when using Docker Compose doesn't work

2022-09-07 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-29210. -- Fix Version/s: 1.17.0 Resolution: Fixed Fixed in master: 442ab0ce6cbba4e276659db765846f

[GitHub] [flink] stevenzwu commented on a diff in pull request #20757: [FLINK-27919] Add FLIP-27-based source for data generation (FLIP-238)

2022-09-07 Thread GitBox
stevenzwu commented on code in PR #20757: URL: https://github.com/apache/flink/pull/20757#discussion_r964946446 ## flink-core/src/main/java/org/apache/flink/api/connector/source/lib/DataGeneratorSource.java: ## @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [flink] mxm commented on a diff in pull request #20485: [FLINK-28853][connector-base] Add FLIP-217 support for watermark alignment of source splits

2022-09-07 Thread GitBox
mxm commented on code in PR #20485: URL: https://github.com/apache/flink/pull/20485#discussion_r964907964 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java: ## @@ -562,11 +580,62 @@ private void updateMaxDesiredWatermark(Watermar

[GitHub] [flink-kubernetes-operator] gaborgsomogyi commented on a diff in pull request #364: [FLINK-28272] Handle TLS Certificate Renewal in Webhook

2022-09-07 Thread GitBox
gaborgsomogyi commented on code in PR #364: URL: https://github.com/apache/flink-kubernetes-operator/pull/364#discussion_r964963833 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/fs/FileSystemWatchService.java: ## @@ -0,0 +1,94 @@ +/* + * Licens

[GitHub] [flink] mxm commented on a diff in pull request #20485: [FLINK-28853][connector-base] Add FLIP-217 support for watermark alignment of source splits

2022-09-07 Thread GitBox
mxm commented on code in PR #20485: URL: https://github.com/apache/flink/pull/20485#discussion_r964964213 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java: ## @@ -559,14 +577,67 @@ private void createOutputForSplits(List newSpli

[jira] [Created] (FLINK-29223) Missing debug output for when filtering JobGraphs based on their persisted JobResult

2022-09-07 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-29223: - Summary: Missing debug output for when filtering JobGraphs based on their persisted JobResult Key: FLINK-29223 URL: https://issues.apache.org/jira/browse/FLINK-29223

[jira] [Updated] (FLINK-29223) Missing debug output for when filtering JobGraphs based on their persisted JobResult

2022-09-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-29223: -- Labels: starter (was: ) > Missing debug output for when filtering JobGraphs based on their pe

[jira] [Updated] (FLINK-29223) Missing debug output for when filtering JobGraphs based on their persisted JobResult

2022-09-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-29223: -- Affects Version/s: 1.15.2 1.16.0 1.17.0 > Missin

[jira] [Updated] (FLINK-29223) Missing debug output for when filtering JobGraphs based on their persisted JobResult

2022-09-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-29223: -- Description: We have the case where we don't see (in the logs) a job being registered in the

[GitHub] [flink] mxm commented on a diff in pull request #20485: [FLINK-28853][connector-base] Add FLIP-217 support for watermark alignment of source splits

2022-09-07 Thread GitBox
mxm commented on code in PR #20485: URL: https://github.com/apache/flink/pull/20485#discussion_r952493768 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcher.java: ## @@ -171,17 +230,54 @@ void runOnce() {

[GitHub] [flink] mxm commented on a diff in pull request #20485: [FLINK-28853][connector-base] Add FLIP-217 support for watermark alignment of source splits

2022-09-07 Thread GitBox
mxm commented on code in PR #20485: URL: https://github.com/apache/flink/pull/20485#discussion_r964978381 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java: ## @@ -562,11 +580,62 @@ private void updateMaxDesiredWatermark(Watermar

[GitHub] [flink] zentol commented on a diff in pull request #20757: [FLINK-27919] Add FLIP-27-based source for data generation (FLIP-238)

2022-09-07 Thread GitBox
zentol commented on code in PR #20757: URL: https://github.com/apache/flink/pull/20757#discussion_r964996882 ## flink-core/src/main/java/org/apache/flink/api/connector/source/lib/util/RateLimitedSourceReader.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [flink] zentol commented on a diff in pull request #20757: [FLINK-27919] Add FLIP-27-based source for data generation (FLIP-238)

2022-09-07 Thread GitBox
zentol commented on code in PR #20757: URL: https://github.com/apache/flink/pull/20757#discussion_r963472820 ## flink-core/src/main/java/org/apache/flink/api/connector/source/lib/util/GeneratingIteratorSourceReader.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [flink] zentol commented on a diff in pull request #20757: [FLINK-27919] Add FLIP-27-based source for data generation (FLIP-238)

2022-09-07 Thread GitBox
zentol commented on code in PR #20757: URL: https://github.com/apache/flink/pull/20757#discussion_r964999081 ## flink-core/src/main/java/org/apache/flink/api/connector/source/lib/SourceReaderFactory.java: ## @@ -27,9 +27,17 @@ /** * A factory for creating source reader instan

[GitHub] [flink] zentol commented on a diff in pull request #20757: [FLINK-27919] Add FLIP-27-based source for data generation (FLIP-238)

2022-09-07 Thread GitBox
zentol commented on code in PR #20757: URL: https://github.com/apache/flink/pull/20757#discussion_r963654710 ## flink-core/src/main/java/org/apache/flink/api/connector/source/lib/DataGeneratorSource.java: ## @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [flink] zentol commented on a diff in pull request #20757: [FLINK-27919] Add FLIP-27-based source for data generation (FLIP-238)

2022-09-07 Thread GitBox
zentol commented on code in PR #20757: URL: https://github.com/apache/flink/pull/20757#discussion_r965003553 ## flink-core/src/main/java/org/apache/flink/api/connector/source/lib/DataGeneratorSource.java: ## @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [flink] zentol commented on a diff in pull request #20757: [FLINK-27919] Add FLIP-27-based source for data generation (FLIP-238)

2022-09-07 Thread GitBox
zentol commented on code in PR #20757: URL: https://github.com/apache/flink/pull/20757#discussion_r965008089 ## flink-core/src/main/java/org/apache/flink/api/connector/source/lib/DataGeneratorSource.java: ## @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [flink] afedulov commented on a diff in pull request #20757: [FLINK-27919] Add FLIP-27-based source for data generation (FLIP-238)

2022-09-07 Thread GitBox
afedulov commented on code in PR #20757: URL: https://github.com/apache/flink/pull/20757#discussion_r965053647 ## flink-core/src/main/java/org/apache/flink/api/connector/source/lib/util/IteratorSourceReaderBase.java: ## @@ -0,0 +1,164 @@ +/* + * Licensed to the Apache Software F

[GitHub] [flink] afedulov commented on a diff in pull request #20757: [FLINK-27919] Add FLIP-27-based source for data generation (FLIP-238)

2022-09-07 Thread GitBox
afedulov commented on code in PR #20757: URL: https://github.com/apache/flink/pull/20757#discussion_r965053647 ## flink-core/src/main/java/org/apache/flink/api/connector/source/lib/util/IteratorSourceReaderBase.java: ## @@ -0,0 +1,164 @@ +/* + * Licensed to the Apache Software F

[GitHub] [flink] stevenzwu commented on a diff in pull request #20757: [FLINK-27919] Add FLIP-27-based source for data generation (FLIP-238)

2022-09-07 Thread GitBox
stevenzwu commented on code in PR #20757: URL: https://github.com/apache/flink/pull/20757#discussion_r965058470 ## flink-core/src/main/java/org/apache/flink/api/connector/source/lib/DataGeneratorSource.java: ## @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [flink] gaoyunhaii commented on pull request #20733: [FLINK-29132][rest] Cleanup subtask attempt metrics to avoid memory leak.

2022-09-07 Thread GitBox
gaoyunhaii commented on PR #20733: URL: https://github.com/apache/flink/pull/20733#issuecomment-1239624491 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

  1   2   >