[GitHub] [flink-kubernetes-operator] gaborgsomogyi commented on a diff in pull request #369: [FLINK-29256] Add docs for k8s operator webhook

2022-09-18 Thread GitBox
gaborgsomogyi commented on code in PR #369: URL: https://github.com/apache/flink-kubernetes-operator/pull/369#discussion_r973867967 ## docs/content/docs/concepts/architecture.md: ## @@ -63,3 +63,18 @@ The Operator manages the lifecycle of Flink resources. The following chart

[jira] [Commented] (FLINK-29329) Checkpoint can not be triggered if encountering OOM

2022-09-18 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606413#comment-17606413 ] Yun Tang commented on FLINK-29329: -- Do you mean once we incurred  OOM, then no checkpoints would be

[jira] [Commented] (FLINK-29328) 【flink在使用状态过期设置时出现问题】

2022-09-18 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606408#comment-17606408 ] Yun Tang commented on FLINK-29328: -- [~Jason_H] Please use English to update this ticket. >

[jira] [Updated] (FLINK-29280) Join hint are not propagated in subquery

2022-09-18 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-29280: --- Fix Version/s: 1.16.0 1.17.0 > Join hint are not propagated in subquery >

[jira] [Commented] (FLINK-29328) 【flink在使用状态过期设置时出现问题】

2022-09-18 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606407#comment-17606407 ] Yanfei Lei commented on FLINK-29328: >From your attachments, this issue is caused by state

[jira] [Closed] (FLINK-29280) Join hint are not propagated in subquery

2022-09-18 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he closed FLINK-29280. -- Resolution: Fixed Fixed in master: 22cb554008320e6684280b5205f93d7a6f685c6c in 1.16.0:

[jira] [Assigned] (FLINK-29280) Join hint are not propagated in subquery

2022-09-18 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he reassigned FLINK-29280: -- Assignee: xuyang > Join hint are not propagated in subquery >

[GitHub] [flink] godfreyhe closed pull request #20823: [FLINK-29280][table-planner] fix join hints could not be propagated in subquery

2022-09-18 Thread GitBox
godfreyhe closed pull request #20823: [FLINK-29280][table-planner] fix join hints could not be propagated in subquery URL: https://github.com/apache/flink/pull/20823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Updated] (FLINK-29329) Checkpoint can not be triggered if encountering OOM

2022-09-18 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan updated FLINK-29329: -- Attachment: job-exceptions-1.txt > Checkpoint can not be triggered if encountering OOM >

[GitHub] [flink] lincoln-lil commented on pull request #20800: [FLINK-28850][table-planner] Support table alias in LOOKUP hint

2022-09-18 Thread GitBox
lincoln-lil commented on PR #20800: URL: https://github.com/apache/flink/pull/20800#issuecomment-1250520693 > @flinkbot run azure failed by a known case: https://issues.apache.org/jira/browse/FLINK-29315

[jira] [Updated] (FLINK-29329) Checkpoint can not be triggered if encountering OOM

2022-09-18 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan updated FLINK-29329: -- Attachment: (was: job-exceptions.txt) > Checkpoint can not be triggered if encountering OOM >

[jira] [Updated] (FLINK-29329) Checkpoint can not be triggered if encountering OOM

2022-09-18 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan updated FLINK-29329: -- Description: When writing a checkpoint, an OOM error is thrown. But the JM is not failed and is

[jira] [Updated] (FLINK-27603) Hive dialect supports "reload function"

2022-09-18 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-27603: - Fix Version/s: (was: 1.16.0) 1.17.0 > Hive dialect supports "reload

[jira] [Closed] (FLINK-28131) FLIP-168: Speculative Execution for Batch Job

2022-09-18 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang closed FLINK-28131. Resolution: Done > FLIP-168: Speculative Execution for Batch Job >

[jira] [Updated] (FLINK-13910) Many serializable classes have no explicit 'serialVersionUID'

2022-09-18 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-13910: - Fix Version/s: 1.17.0 (was: 1.16.0) > Many serializable classes have no

[jira] [Created] (FLINK-29329) Checkpoint can not be triggered if encountering OOM

2022-09-18 Thread Yuxin Tan (Jira)
Yuxin Tan created FLINK-29329: - Summary: Checkpoint can not be triggered if encountering OOM Key: FLINK-29329 URL: https://issues.apache.org/jira/browse/FLINK-29329 Project: Flink Issue Type:

[jira] [Updated] (FLINK-21375) Refactor HybridMemorySegment

2022-09-18 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-21375: - Fix Version/s: 1.17.0 (was: 1.16.0) > Refactor HybridMemorySegment >

[jira] [Updated] (FLINK-18986) KubernetesSessionCli creates RestClusterClient for detached deployments

2022-09-18 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-18986: - Fix Version/s: (was: 1.16.0) 1.17.0 > KubernetesSessionCli creates

[jira] [Updated] (FLINK-25444) ClosureCleaner rejects ExecutionConfig as not be Serializable due to TextElement

2022-09-18 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-25444: - Fix Version/s: 1.17.0 (was: 1.16.0) > ClosureCleaner rejects

[jira] [Closed] (FLINK-21556) StreamingKafkaITCase hangs on azure

2022-09-18 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang closed FLINK-21556. Resolution: Fixed > StreamingKafkaITCase hangs on azure > --- > >

[jira] [Updated] (FLINK-27391) Support Hive bucket table

2022-09-18 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-27391: - Fix Version/s: 1.17.0 (was: 1.16.0) > Support Hive bucket table >

[jira] [Updated] (FLINK-27242) Support RENAME PARTITION statement for partitioned table

2022-09-18 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-27242: - Fix Version/s: 1.17.0 (was: 1.16.0) > Support RENAME PARTITION statement

[jira] [Updated] (FLINK-27243) Support SHOW PARTITIONS statement for partitioned table

2022-09-18 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-27243: - Fix Version/s: 1.17.0 (was: 1.16.0) > Support SHOW PARTITIONS statement

[jira] [Updated] (FLINK-27241) Support DROP PARTITION statement for partitioned table

2022-09-18 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-27241: - Fix Version/s: 1.17.0 (was: 1.16.0) > Support DROP PARTITION statement

[jira] [Updated] (FLINK-27240) Support ADD PARTITION statement for partitioned table

2022-09-18 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-27240: - Fix Version/s: 1.17.0 (was: 1.16.0) > Support ADD PARTITION statement

[jira] [Updated] (FLINK-26968) Bump CopyOnWriteStateMap entry version before write

2022-09-18 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-26968: - Fix Version/s: 1.17.0 (was: 1.16.0) > Bump CopyOnWriteStateMap entry

[jira] [Updated] (FLINK-26967) Fix race condition in CopyOnWriteStateMap

2022-09-18 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-26967: - Fix Version/s: 1.17.0 (was: 1.16.0) > Fix race condition in

[jira] [Updated] (FLINK-26965) Allow reuse of PeriodicMaterializationManager

2022-09-18 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-26965: - Fix Version/s: 1.17.0 (was: 1.16.0) > Allow reuse of

[jira] [Updated] (FLINK-26964) Notify CheckpointStrategy about checkpoint completion/abortion

2022-09-18 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-26964: - Fix Version/s: 1.17.0 (was: 1.16.0) > Notify CheckpointStrategy about

[jira] [Updated] (FLINK-26963) Allow HeapBackend creation customization

2022-09-18 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-26963: - Fix Version/s: 1.17.0 (was: 1.16.0) > Allow HeapBackend creation

[jira] [Updated] (FLINK-22956) Stream Over TTL should use enableTimeToLive of state instead of timer

2022-09-18 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-22956: - Fix Version/s: 1.17.0 (was: 1.16.0) > Stream Over TTL should use

[jira] [Updated] (FLINK-23815) Separate the concerns of PendingCheckpoint and CheckpointPlan

2022-09-18 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-23815: - Fix Version/s: 1.17.0 (was: 1.16.0) > Separate the concerns of

[jira] [Updated] (FLINK-16388) Bump orc-core to 1.4.5

2022-09-18 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-16388: - Fix Version/s: 1.17.0 (was: 1.16.0) > Bump orc-core to 1.4.5 >

[jira] [Updated] (FLINK-18229) Pending worker requests should be properly cleared

2022-09-18 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-18229: - Fix Version/s: (was: 1.16.0) 1.17.0 > Pending worker requests should be

[jira] [Updated] (FLINK-21784) Allow HeapBackend RestoreOperation customization

2022-09-18 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-21784: - Fix Version/s: 1.17.0 (was: 1.16.0) > Allow HeapBackend RestoreOperation

[jira] [Updated] (FLINK-21783) Allow HeapBackend snapshotting customization

2022-09-18 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-21783: - Fix Version/s: 1.17.0 (was: 1.16.0) > Allow HeapBackend snapshotting

[jira] [Updated] (FLINK-21649) Allow extension of CopyOnWrite state classes

2022-09-18 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-21649: - Fix Version/s: 1.17.0 (was: 1.16.0) > Allow extension of CopyOnWrite

[jira] [Updated] (FLINK-16952) Parquet file system format support filter pushdown

2022-09-18 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-16952: - Fix Version/s: 1.17.0 (was: 1.16.0) > Parquet file system format

[jira] [Closed] (FLINK-28738) [doc] Add a user doc about the correctness for non-deterministic updates

2022-09-18 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he closed FLINK-28738. -- Resolution: Fixed Fixed in master: a02b2c232ea2fb1b22bd0e5c290e4c6f0217549b in 1.16.0:

[GitHub] [flink] godfreyhe closed pull request #20679: [FLINK-28738][table-planner] Adds a user doc about the determinism in streaming

2022-09-18 Thread GitBox
godfreyhe closed pull request #20679: [FLINK-28738][table-planner] Adds a user doc about the determinism in streaming URL: https://github.com/apache/flink/pull/20679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Created] (FLINK-29328) 【flink在使用状态过期设置时出现问题】

2022-09-18 Thread Jason (Jira)
Jason created FLINK-29328: - Summary: 【flink在使用状态过期设置时出现问题】 Key: FLINK-29328 URL: https://issues.apache.org/jira/browse/FLINK-29328 Project: Flink Issue Type: Bug Components: API /

[jira] [Commented] (FLINK-27916) HybridSourceReaderTest.testReader failed with AssertionError

2022-09-18 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606392#comment-17606392 ] Xingbo Huang commented on FLINK-27916: --

[GitHub] [flink] LadyForest commented on pull request #20652: [FLINK-22315][table] Support add/modify column/constraint/watermark for ALTER TABLE statement

2022-09-18 Thread GitBox
LadyForest commented on PR #20652: URL: https://github.com/apache/flink/pull/20652#issuecomment-1250479200 Hi @lsyldliu, do you have time to take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] lincoln-lil commented on pull request #20679: [FLINK-28738][table-planner] Adds a user doc about the determinism in streaming

2022-09-18 Thread GitBox
lincoln-lil commented on PR #20679: URL: https://github.com/apache/flink/pull/20679#issuecomment-1250475895 @godfreyhe multiple runs always failed in irrelevant connector cases, the last one is https://issues.apache.org/jira/browse/FLINK-29315 -- This is an automated message from the

[GitHub] [flink-web] HuangXingBo commented on a diff in pull request #569: Release Flink 1.14.6

2022-09-18 Thread GitBox
HuangXingBo commented on code in PR #569: URL: https://github.com/apache/flink-web/pull/569#discussion_r973821044 ## _posts/2022-09-08-release-1.14.6.md: ## @@ -0,0 +1,105 @@ +--- +layout: post +title: "Apache Flink 1.14.6 Release Announcement" +date: 2022-09-08T00:00:00.000Z

[GitHub] [flink] xuyangzhong commented on pull request #20823: [FLINK-29280][table-planner] fix join hints could not be propagated in subquery

2022-09-18 Thread GitBox
xuyangzhong commented on PR #20823: URL: https://github.com/apache/flink/pull/20823#issuecomment-1250466188 The failed case is caused by https://issues.apache.org/jira/browse/FLINK-29315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (FLINK-29315) HDFSTest#testBlobServerRecovery fails on CI

2022-09-18 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606387#comment-17606387 ] xuyang commented on FLINK-29315:

[GitHub] [flink-ml] yunfengzhou-hub commented on a diff in pull request #155: [FLINK-29318] Add Transformer for PolynomialExpansion

2022-09-18 Thread GitBox
yunfengzhou-hub commented on code in PR #155: URL: https://github.com/apache/flink-ml/pull/155#discussion_r973815348 ## flink-ml-lib/src/test/java/org/apache/flink/ml/feature/PolynomialExpansionTest.java: ## @@ -20,7 +20,7 @@ Review Comment: Let's add back the

[GitHub] [flink] lincoln-lil commented on pull request #20800: [FLINK-28850][table-planner] Support table alias in LOOKUP hint

2022-09-18 Thread GitBox
lincoln-lil commented on PR #20800: URL: https://github.com/apache/flink/pull/20800#issuecomment-1250441016 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] lincoln-lil commented on pull request #20800: [FLINK-28850][table-planner] Support table alias in LOOKUP hint

2022-09-18 Thread GitBox
lincoln-lil commented on PR #20800: URL: https://github.com/apache/flink/pull/20800#issuecomment-1250440721 Succeed in pipeline: https://dev.azure.com/lincoln86xy/lincoln86xy/_build/results?buildId=304=results -- This is an automated message from the Apache Git Service. To

[GitHub] [flink-ml] yunfengzhou-hub commented on pull request #155: [FLINK-29318] Add Transformer for PolynomialExpansion

2022-09-18 Thread GitBox
yunfengzhou-hub commented on PR #155: URL: https://github.com/apache/flink-ml/pull/155#issuecomment-1250437078 Hi @weibozhao , could you please refine the description of this PR, as what we have done in other algorithms' PRs? -- This is an automated message from the Apache Git Service.

[GitHub] [flink-ml] yunfengzhou-hub commented on pull request #156: [FLINK-29323] Refine Transformer for VectorAssembler

2022-09-18 Thread GitBox
yunfengzhou-hub commented on PR #156: URL: https://github.com/apache/flink-ml/pull/156#issuecomment-1250436451 Hi @weibozhao , could you please refine the description and JavaDocs of this PR, illustrating why do we need to add the `size` parameter to VectorAssembler? What additional

[GitHub] [flink] bzhaoopenstack commented on pull request #20668: [WIP][FLINK-29055][k8s] add K8S options for excluding the buildin decorators

2022-09-18 Thread GitBox
bzhaoopenstack commented on PR #20668: URL: https://github.com/apache/flink/pull/20668#issuecomment-1250434206 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-29244) Add metric lastMaterializationDuration to ChangelogMaterializationMetricGroup

2022-09-18 Thread Feifan Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606379#comment-17606379 ] Feifan Wang commented on FLINK-29244: - Hi [~yuanmei] , how do you think about this ? > Add metric

[GitHub] [flink-statefun] fransking opened a new pull request, #317: FLINK-27934 - Improving inefficient deserialization/serialization of state variables within a batch

2022-09-18 Thread GitBox
fransking opened a new pull request, #317: URL: https://github.com/apache/flink-statefun/pull/317 Avoiding reserialisation unless the state object has actually changed and maintaining a deserialised backing property to avoid multiple deserialisations within a batch -- This is an

[GitHub] [flink-statefun] fransking closed pull request #315: FLINK-27934 - Inefficient deserialization/serialization of state variables within a batch

2022-09-18 Thread GitBox
fransking closed pull request #315: FLINK-27934 - Inefficient deserialization/serialization of state variables within a batch URL: https://github.com/apache/flink-statefun/pull/315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink-kubernetes-operator] gauravmiglanid11 commented on pull request #360: [FLINK-29165][docs] update docs to create and delete deployment via code

2022-09-18 Thread GitBox
gauravmiglanid11 commented on PR #360: URL: https://github.com/apache/flink-kubernetes-operator/pull/360#issuecomment-1250380177 Hi @morhidi , changes done, please review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink-kubernetes-operator] gauravmiglanid11 commented on a diff in pull request #360: [FLINK-29165][docs] update docs to create and delete deployment via code

2022-09-18 Thread GitBox
gauravmiglanid11 commented on code in PR #360: URL: https://github.com/apache/flink-kubernetes-operator/pull/360#discussion_r973770361 ## examples/kubernetes-client-examples/src/main/java/org/apache/flink/examples/Basic.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-29261) Consider using FAIL_ON_UNKNOWN_PROPERTIES=false in the Operator

2022-09-18 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606342#comment-17606342 ] Gyula Fora commented on FLINK-29261: I think this would be a reasonable improvement as the correct

[jira] [Commented] (FLINK-29199) Support blue-green deployment type

2022-09-18 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606341#comment-17606341 ] Gyula Fora commented on FLINK-29199: This is something that could be built on top of the current

[jira] [Commented] (FLINK-29199) Support blue-green deployment type

2022-09-18 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606340#comment-17606340 ] Gyula Fora commented on FLINK-29199: Also this will be quite tricky to implement with the current

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #370: [FLINK-29288] Make it possible to use job jars in the system classpath

2022-09-18 Thread GitBox
gyfora commented on PR #370: URL: https://github.com/apache/flink-kubernetes-operator/pull/370#issuecomment-1250366042 > Re: [CI failure](https://github.com/apache/flink-kubernetes-operator/actions/runs/3069970323/jobs/4972514311), it looks like the Maven step completed successfully

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #370: [FLINK-29288] Make it possible to use job jars in the system classpath

2022-09-18 Thread GitBox
gyfora commented on code in PR #370: URL: https://github.com/apache/flink-kubernetes-operator/pull/370#discussion_r973760343 ## flink-kubernetes-standalone/src/main/java/org/apache/flink/kubernetes/operator/kubeclient/parameters/StandaloneKubernetesJobManagerParameters.java:

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #370: [FLINK-29288] Make it possible to use job jars in the system classpath

2022-09-18 Thread GitBox
gyfora commented on code in PR #370: URL: https://github.com/apache/flink-kubernetes-operator/pull/370#discussion_r973754287 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultValidator.java: ## @@ -180,10 +180,6 @@ private

[GitHub] [flink-kubernetes-operator] sap1ens commented on pull request #370: [FLINK-29288] Make it possible to use job jars in the system classpath

2022-09-18 Thread GitBox
sap1ens commented on PR #370: URL: https://github.com/apache/flink-kubernetes-operator/pull/370#issuecomment-1250355459 Re: [CI failure](https://github.com/apache/flink-kubernetes-operator/actions/runs/3069970323/jobs/4972514311), it looks like the Maven step completed successfully

[GitHub] [flink-kubernetes-operator] sap1ens commented on pull request #370: [FLINK-29288] Make it possible to use job jars in the system classpath

2022-09-18 Thread GitBox
sap1ens commented on PR #370: URL: https://github.com/apache/flink-kubernetes-operator/pull/370#issuecomment-1250355101 > If I understand it correctly this would in theory also solve https://issues.apache.org/jira/browse/FLINK-29144 as a side effect :) In a way yes, you can place

[GitHub] [flink-kubernetes-operator] sap1ens commented on pull request #370: [FLINK-29288] Make it possible to use job jars in the system classpath

2022-09-18 Thread GitBox
sap1ens commented on PR #370: URL: https://github.com/apache/flink-kubernetes-operator/pull/370#issuecomment-1250354948 > Also this does not address the SessionJobs as we discussed in the Slack thread with @jeesmon. Yes, but aside from providing the "no-op" jar, which I thought is

[GitHub] [flink-kubernetes-operator] sap1ens commented on a diff in pull request #370: [FLINK-29288] Make it possible to use job jars in the system classpath

2022-09-18 Thread GitBox
sap1ens commented on code in PR #370: URL: https://github.com/apache/flink-kubernetes-operator/pull/370#discussion_r973753540 ## flink-kubernetes-standalone/src/main/java/org/apache/flink/kubernetes/operator/kubeclient/parameters/StandaloneKubernetesJobManagerParameters.java:

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #370: [FLINK-29288] Make it possible to use job jars in the system classpath

2022-09-18 Thread GitBox
gyfora commented on code in PR #370: URL: https://github.com/apache/flink-kubernetes-operator/pull/370#discussion_r973734058 ## flink-kubernetes-standalone/src/main/java/org/apache/flink/kubernetes/operator/kubeclient/parameters/StandaloneKubernetesJobManagerParameters.java:

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #370: [FLINK-29288] Make it possible to use job jars in the system classpath

2022-09-18 Thread GitBox
gyfora commented on PR #370: URL: https://github.com/apache/flink-kubernetes-operator/pull/370#issuecomment-1250325337 If I understand it correctly this would in theory also solve https://issues.apache.org/jira/browse/FLINK-29144 as a side effect :) -- This is an automated message from

[GitHub] [flink] ganlute commented on pull request #20542: [FLINK-28910][Connectors/hbase]Fix potential data deletion while updating HBase rows

2022-09-18 Thread GitBox
ganlute commented on PR #20542: URL: https://github.com/apache/flink/pull/20542#issuecomment-1250315262 The failure of CI seems to have nothing to do with pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] ganlute closed pull request #20851: [WIP][FLINK-28910][Connectors/hbase]Fix potential data deletion while updating HBase rows

2022-09-18 Thread GitBox
ganlute closed pull request #20851: [WIP][FLINK-28910][Connectors/hbase]Fix potential data deletion while updating HBase rows URL: https://github.com/apache/flink/pull/20851 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] lincoln-lil commented on pull request #20679: [FLINK-28738][table-planner] Adds a user doc about the determinism in streaming

2022-09-18 Thread GitBox
lincoln-lil commented on PR #20679: URL: https://github.com/apache/flink/pull/20679#issuecomment-1250290239 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Closed] (FLINK-16332) Support un-ordered mode for async lookup join

2022-09-18 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-16332. --- Resolution: Fixed > Support un-ordered mode for async lookup join >

[jira] [Closed] (FLINK-18871) Non-deterministic function could break retract mechanism

2022-09-18 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-18871. --- Fix Version/s: 1.16.0 Resolution: Fixed The non-deterministic function exists in changelog

[jira] [Closed] (FLINK-24412) retract stream join on topN error

2022-09-18 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-24412. --- Fix Version/s: 1.16.0 Resolution: Fixed > retract stream join on topN error >

[GitHub] [flink] lincoln-lil commented on pull request #20679: [FLINK-28738][table-planner] Adds a user doc about the determinism in streaming

2022-09-18 Thread GitBox
lincoln-lil commented on PR #20679: URL: https://github.com/apache/flink/pull/20679#issuecomment-1250244597 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Closed] (FLINK-29283) Remove hardcoded apiVersion from operator unit test

2022-09-18 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-29283. -- Resolution: Won't Fix > Remove hardcoded apiVersion from operator unit test >

[GitHub] [flink-kubernetes-operator] gyfora closed pull request #367: [FLINK-29283] Remove hardcoded apiVersion from operator unit test

2022-09-18 Thread GitBox
gyfora closed pull request #367: [FLINK-29283] Remove hardcoded apiVersion from operator unit test URL: https://github.com/apache/flink-kubernetes-operator/pull/367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #367: [FLINK-29283] Remove hardcoded apiVersion from operator unit test

2022-09-18 Thread GitBox
gyfora commented on PR #367: URL: https://github.com/apache/flink-kubernetes-operator/pull/367#issuecomment-1250236032 I am closing this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] tisonkun commented on a diff in pull request #20584: [FLINK-26182][Connector/pulsar] Create a e2e tests for Pulsar sink.

2022-09-18 Thread GitBox
tisonkun commented on code in PR #20584: URL: https://github.com/apache/flink/pull/20584#discussion_r973693195 ## flink-end-to-end-tests/flink-end-to-end-tests-pulsar/src/test/java/org/apache/flink/tests/util/pulsar/PulsarSourceUnorderedE2ECase.java: ## @@ -19,21 +19,26 @@

[GitHub] [flink] godfreyhe commented on pull request #20679: [FLINK-28738][table-planner] Adds a user doc about the determinism in streaming

2022-09-18 Thread GitBox
godfreyhe commented on PR #20679: URL: https://github.com/apache/flink/pull/20679#issuecomment-1250228642 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-kubernetes-operator] gaborgsomogyi commented on a diff in pull request #369: [FLINK-29256] Add docs for k8s operator webhook

2022-09-18 Thread GitBox
gaborgsomogyi commented on code in PR #369: URL: https://github.com/apache/flink-kubernetes-operator/pull/369#discussion_r973666366 ## docs/content/docs/concepts/architecture.md: ## @@ -63,3 +63,18 @@ The Operator manages the lifecycle of Flink resources. The following chart