[jira] [Closed] (FLINK-29385) AddColumn in flink table store should check the duplicate field names

2022-09-21 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-29385. Fix Version/s: table-store-0.3.0 table-store-0.2.1 Resolution: Fixed mas

[GitHub] [flink-table-store] JingsongLi merged pull request #302: [FLINK-29385] Verify duplicate column names for AddColumn

2022-09-21 Thread GitBox
JingsongLi merged PR #302: URL: https://github.com/apache/flink-table-store/pull/302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [flink] RyanSkraba commented on pull request #20805: [FLINK-29198][test] Fail after maximum RetryOnException

2022-09-21 Thread GitBox
RyanSkraba commented on PR #20805: URL: https://github.com/apache/flink/pull/20805#issuecomment-1254602564 > Thanks for the contribution. I think it would be great to have a test here confirming that the change fixes the issue Thanks Sergey, especially for the collaboration! This was

[jira] [Updated] (FLINK-29380) Two streams union, watermark error, not the minimum value

2022-09-21 Thread xiechenling (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiechenling updated FLINK-29380: Attachment: screenshot-2.png > Two streams union, watermark error, not the minimum value > ---

[jira] [Updated] (FLINK-29380) Two streams union, watermark error, not the minimum value

2022-09-21 Thread xiechenling (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiechenling updated FLINK-29380: Description: Two streams union, watermark error, not the minimum value, connect operator  waterma

[jira] [Updated] (FLINK-29380) Two streams union, watermark error, not the minimum value

2022-09-21 Thread xiechenling (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiechenling updated FLINK-29380: Description: Two streams union, watermark error, not the minimum value, connect operator  waterma

[GitHub] [flink-table-store] zjureel commented on pull request #302: [FLINK-29385] Verify duplicate column names for AddColumn

2022-09-21 Thread GitBox
zjureel commented on PR #302: URL: https://github.com/apache/flink-table-store/pull/302#issuecomment-1254600956 Thanks @JingsongLi @SteNicholas I have updated the codes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Updated] (FLINK-29380) Two streams union, watermark error, not the minimum value

2022-09-21 Thread xiechenling (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiechenling updated FLINK-29380: Description: Two streams union, watermark error, not the minimum value, connect operator  waterma

[jira] [Updated] (FLINK-29380) Two streams union, watermark error, not the minimum value

2022-09-21 Thread xiechenling (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiechenling updated FLINK-29380: Attachment: screenshot-1.png > Two streams union, watermark error, not the minimum value > ---

[jira] [Commented] (FLINK-29349) Use state ttl instead of timer to clean up state in proctime unbounded over aggregate

2022-09-21 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608100#comment-17608100 ] lincoln lee commented on FLINK-29349: - [~lsy] I took a look at the FLINK-22956, ther

[GitHub] [flink-table-store] zjureel commented on a diff in pull request #302: [FLINK-29385] Verify duplicate column names for AddColumn

2022-09-21 Thread GitBox
zjureel commented on code in PR #302: URL: https://github.com/apache/flink-table-store/pull/302#discussion_r977248865 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/schema/SchemaManager.java: ## @@ -173,6 +174,15 @@ public TableSchema commitChanges(Lis

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #301: [FLINK-29367] FileStoreCommitImpl also checks for conflicts when committing append changes

2022-09-21 Thread GitBox
JingsongLi commented on code in PR #301: URL: https://github.com/apache/flink-table-store/pull/301#discussion_r977245473 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreCommitImpl.java: ## @@ -182,26 +187,61 @@ public void commit(Mani

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #301: [FLINK-29367] FileStoreCommitImpl also checks for conflicts when committing append changes

2022-09-21 Thread GitBox
JingsongLi commented on code in PR #301: URL: https://github.com/apache/flink-table-store/pull/301#discussion_r977242850 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreCommitImpl.java: ## @@ -479,32 +526,39 @@ private boolean tryComm

[GitHub] [flink] lsyldliu commented on pull request #20246: [FLINK-28074][table-planner] show statistics details for DESCRIBE EXTENDED

2022-09-21 Thread GitBox
lsyldliu commented on PR #20246: URL: https://github.com/apache/flink/pull/20246#issuecomment-1254579074 Thanks for your contribution, I will take a look as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] wanglijie95 commented on pull request #20867: [FLINK-29372] Add suffix to all options that conflict with YAML

2022-09-21 Thread GitBox
wanglijie95 commented on PR #20867: URL: https://github.com/apache/flink/pull/20867#issuecomment-1254576835 Following configuration options are missing: `kubernetes.jobmanager.cpu` `kubernetes.jobmanager.cpu.limit-factor` `kubernetes.taskmanager.cpu` `kubernetes.taskmanager.cpu.limit-fa

[GitHub] [flink] flinkbot commented on pull request #20879: Using a new image to debug CI

2022-09-21 Thread GitBox
flinkbot commented on PR #20879: URL: https://github.com/apache/flink/pull/20879#issuecomment-1254570892 ## CI report: * 2d13d9a1ee7e775bed2a47d4037159e587efc090 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #302: [FLINK-29385] Verify duplicate column names for AddColumn

2022-09-21 Thread GitBox
JingsongLi commented on code in PR #302: URL: https://github.com/apache/flink-table-store/pull/302#discussion_r977230937 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/schema/SchemaManager.java: ## @@ -173,6 +174,15 @@ public TableSchema commitChanges(

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #302: [FLINK-29385] Verify duplicate column names for AddColumn

2022-09-21 Thread GitBox
SteNicholas commented on code in PR #302: URL: https://github.com/apache/flink-table-store/pull/302#discussion_r977219669 ## flink-table-store-core/src/test/java/org/apache/flink/table/store/table/SchemaEvolutionTest.java: ## @@ -120,6 +122,28 @@ public void testAddField() throw

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #302: [FLINK-29385] Verify duplicate column names for AddColumn

2022-09-21 Thread GitBox
SteNicholas commented on code in PR #302: URL: https://github.com/apache/flink-table-store/pull/302#discussion_r977218529 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/schema/SchemaManager.java: ## @@ -173,6 +174,15 @@ public TableSchema commitChanges

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #302: [FLINK-29385] Verify duplicate column names for AddColumn

2022-09-21 Thread GitBox
SteNicholas commented on code in PR #302: URL: https://github.com/apache/flink-table-store/pull/302#discussion_r977217137 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/schema/SchemaManager.java: ## @@ -173,6 +174,15 @@ public TableSchema commitChanges

[GitHub] [flink-kubernetes-operator] sap1ens commented on a diff in pull request #370: [FLINK-29288] Make it possible to use job jars in the system classpath

2022-09-21 Thread GitBox
sap1ens commented on code in PR #370: URL: https://github.com/apache/flink-kubernetes-operator/pull/370#discussion_r977209625 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultValidator.java: ## @@ -180,10 +180,6 @@ private Option

[jira] [Commented] (FLINK-13703) AvroTypeInfo requires objects to be strict POJOs (mutable, with setters)

2022-09-21 Thread Andrei Leib (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608063#comment-17608063 ] Andrei Leib commented on FLINK-13703: - Just hit this issue as well when setting  {co

[GitHub] [flink] flinkbot commented on pull request #20878: [FLINK-29228][hive] Align the schema of the HiveServer2 getMetadata with JDBC

2022-09-21 Thread GitBox
flinkbot commented on PR #20878: URL: https://github.com/apache/flink/pull/20878#issuecomment-1254480559 ## CI report: * 4a7c35a242f47b6345a2ab25bb1480741a9a2ee4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #157: [FLINK-28906] Support windowing in AgglomerativeClustering

2022-09-21 Thread GitBox
lindong28 commented on code in PR #157: URL: https://github.com/apache/flink-ml/pull/157#discussion_r977119140 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/window/WindowUtils.java: ## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[jira] [Assigned] (FLINK-29385) AddColumn in flink table store should check the duplicate field names

2022-09-21 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee reassigned FLINK-29385: Assignee: Shammon > AddColumn in flink table store should check the duplicate field names

[GitHub] [flink] fsk119 opened a new pull request, #20878: [FLINK-29228][hive] Align the schema of the HiveServer2 getMetadata with JDBC

2022-09-21 Thread GitBox
fsk119 opened a new pull request, #20878: URL: https://github.com/apache/flink/pull/20878 Cherry pick fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[jira] [Updated] (FLINK-29385) AddColumn in flink table store should check the duplicate field names

2022-09-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29385: --- Labels: pull-request-available (was: ) > AddColumn in flink table store should check the du

[GitHub] [flink-table-store] zjureel opened a new pull request, #302: [FLINK-29385] Verify duplicate column names for AddColumn

2022-09-21 Thread GitBox
zjureel opened a new pull request, #302: URL: https://github.com/apache/flink-table-store/pull/302 When we execute AddColumn ddl, we should check whether the column name is exist. Otherwise, the ddl will be successful and the job reads this table will create source of flink store table fail

[GitHub] [flink] fsk119 closed pull request #20790: [FLINK-29228][hive] Align the schema of the HiveServer2 getMetadata with JDBC

2022-09-21 Thread GitBox
fsk119 closed pull request #20790: [FLINK-29228][hive] Align the schema of the HiveServer2 getMetadata with JDBC URL: https://github.com/apache/flink/pull/20790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Commented] (FLINK-29349) Use state ttl instead of timer to clean up state in proctime unbounded over aggregate

2022-09-21 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608056#comment-17608056 ] dalongliu commented on FLINK-29349: --- This is duplicated with FLINK-22956? > Use state

[jira] [Commented] (FLINK-6573) Flink MongoDB Connector

2022-09-21 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-6573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608051#comment-17608051 ] Leonard Xu commented on FLINK-6573: --- I've assigned this ticket to [~jiabao.sun] as he h

[jira] [Assigned] (FLINK-6573) Flink MongoDB Connector

2022-09-21 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-6573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-6573: - Assignee: Jiabao Sun (was: ZhuoYu Chen) > Flink MongoDB Connector > --- > >

[jira] [Comment Edited] (FLINK-27101) Periodically break the chain of incremental checkpoint (trigger checkpoints via REST API)

2022-09-21 Thread Jiale Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606485#comment-17606485 ] Jiale Tan edited comment on FLINK-27101 at 9/22/22 3:12 AM:

[jira] [Comment Edited] (FLINK-27101) Periodically break the chain of incremental checkpoint (trigger checkpoints via REST API)

2022-09-21 Thread Jiale Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606485#comment-17606485 ] Jiale Tan edited comment on FLINK-27101 at 9/22/22 3:11 AM:

[jira] [Commented] (FLINK-29384) snakeyaml version 1.30 in flink-kubernetes-operator-1.2-SNAPSHOT-shaded.jar has vulnerabilities

2022-09-21 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608044#comment-17608044 ] Yang Wang commented on FLINK-29384: --- The {{org.yaml:snakeyaml:jar:1.30}} is introduces

[GitHub] [flink] leletan commented on pull request #20852: [FLINK-27101][checkpointing][rest] Add restful API to trigger checkpoints

2022-09-21 Thread GitBox
leletan commented on PR #20852: URL: https://github.com/apache/flink/pull/20852#issuecomment-1254461989 @pnowojski @zentol Addressed the code comments (at least I thought I did) and generated the docs. Please take a look whenever you have time. Thanks! -- This is an automated message from

[jira] [Created] (FLINK-29385) AddColumn in flink table store should check the duplicate field names

2022-09-21 Thread Shammon (Jira)
Shammon created FLINK-29385: --- Summary: AddColumn in flink table store should check the duplicate field names Key: FLINK-29385 URL: https://issues.apache.org/jira/browse/FLINK-29385 Project: Flink

[GitHub] [flink] fsk119 commented on a diff in pull request #20790: [FLINK-29228][hive] Align the schema of the HiveServer2 getMetadata with JDBC

2022-09-21 Thread GitBox
fsk119 commented on code in PR #20790: URL: https://github.com/apache/flink/pull/20790#discussion_r977139059 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/endpoint/hive/HiveServer2EndpointITCase.java: ## @@ -572,6 +595,107 @@ public void testGetIn

[GitHub] [flink] Sxnan commented on pull request #20862: [FLINK-29339][runtime] JobMasterPartitionTracker returns future to avoid blocking main thread

2022-09-21 Thread GitBox
Sxnan commented on PR #20862: URL: https://github.com/apache/flink/pull/20862#issuecomment-125163 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (FLINK-29329) Checkpoint can not be triggered if encountering OOM

2022-09-21 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608037#comment-17608037 ] Yun Tang commented on FLINK-29329: -- I think the problem of not triggering the checkpoin

[jira] [Updated] (FLINK-29367) Avoid manifest corruption for incorrect checkpoint recovery

2022-09-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29367: --- Labels: pull-request-available (was: ) > Avoid manifest corruption for incorrect checkpoint

[GitHub] [flink-table-store] tsreaper opened a new pull request, #301: [FLINK-29367] FileStoreCommitImpl also checks for conflicts when committing append changes

2022-09-21 Thread GitBox
tsreaper opened a new pull request, #301: URL: https://github.com/apache/flink-table-store/pull/301 When the job runs to checkpoint N, if the user recovers from an old checkpoint (such as checkpoint N-5), the sink of the current FTS will cause a manifest corruption because duplicate files m

[GitHub] [flink] wuchong commented on a diff in pull request #20653: [FLINK-29020][docs] add document for CTAS feature

2022-09-21 Thread GitBox
wuchong commented on code in PR #20653: URL: https://github.com/apache/flink/pull/20653#discussion_r976628561 ## docs/content/docs/dev/table/sql/create.md: ## @@ -513,6 +516,48 @@ If you provide no like options, `INCLUDING ALL OVERWRITING OPTIONS` will be used **NOTE** The `

[GitHub] [flink] lsyldliu commented on pull request #20869: [FLINK-29219][table] Fix CREATE TABLE AS statement blocks SQL client's execution

2022-09-21 Thread GitBox
lsyldliu commented on PR #20869: URL: https://github.com/apache/flink/pull/20869#issuecomment-1254386573 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] flinkbot commented on pull request #20877: [hotfix] Make doc ide_setup.md format better for code formatting

2022-09-21 Thread GitBox
flinkbot commented on PR #20877: URL: https://github.com/apache/flink/pull/20877#issuecomment-1254372949 ## CI report: * acffaacb43a79c5a22771e076e52af94bfa7b94c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] liuml07 opened a new pull request, #20877: [hotfix] Make doc ide_setup.md format better for code formatting

2022-09-21 Thread GitBox
liuml07 opened a new pull request, #20877: URL: https://github.com/apache/flink/pull/20877 ## What is the purpose of the change Make doc file ide_setup.md format better after e48abd38 ### Before: https://user-images.githubusercontent.com/159186/191633961-1cd7f135-

[GitHub] [flink] flinkbot commented on pull request #20876: [hotfix][docs] Fix typo in Kinesis Connector docs.

2022-09-21 Thread GitBox
flinkbot commented on PR #20876: URL: https://github.com/apache/flink/pull/20876#issuecomment-1254277324 ## CI report: * 417ffb9e3b582ebc1c5741d04876f1ab33ab4b61 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] afedulov opened a new pull request, #20876: [hotfix][docs] Fix typo in Kinesis Connector docs.

2022-09-21 Thread GitBox
afedulov opened a new pull request, #20876: URL: https://github.com/apache/flink/pull/20876 This is a trivial docs fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[jira] [Commented] (FLINK-18647) How to handle processing time timers with bounded input

2022-09-21 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607948#comment-17607948 ] Piotr Nowojski commented on FLINK-18647: [~dkapoor1], is there some other ticket

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #375: [FLINK-29327] remove operator config from job runtime config before d…

2022-09-21 Thread GitBox
gyfora commented on code in PR #375: URL: https://github.com/apache/flink-kubernetes-operator/pull/375#discussion_r976892681 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java: ## @@ -182,7 +184,13 @@ public JobID s

[GitHub] [flink-kubernetes-operator] HuangZhenQiu commented on a diff in pull request #375: [FLINK-29327] remove operator config from job runtime config before d…

2022-09-21 Thread GitBox
HuangZhenQiu commented on code in PR #375: URL: https://github.com/apache/flink-kubernetes-operator/pull/375#discussion_r976868309 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java: ## @@ -165,7 +165,8 @@ public vo

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #370: [FLINK-29288] Make it possible to use job jars in the system classpath

2022-09-21 Thread GitBox
gyfora commented on code in PR #370: URL: https://github.com/apache/flink-kubernetes-operator/pull/370#discussion_r976840850 ## flink-kubernetes-standalone/src/main/java/org/apache/flink/kubernetes/operator/kubeclient/parameters/StandaloneKubernetesJobManagerParameters.java: ##

[jira] [Created] (FLINK-29384) snakeyaml version 1.30 in flink-kubernetes-operator-1.2-SNAPSHOT-shaded.jar has vulnerabilities

2022-09-21 Thread James Busche (Jira)
James Busche created FLINK-29384: Summary: snakeyaml version 1.30 in flink-kubernetes-operator-1.2-SNAPSHOT-shaded.jar has vulnerabilities Key: FLINK-29384 URL: https://issues.apache.org/jira/browse/FLINK-29384

[jira] [Comment Edited] (FLINK-18647) How to handle processing time timers with bounded input

2022-09-21 Thread Divye Kapoor (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607914#comment-17607914 ] Divye Kapoor edited comment on FLINK-18647 at 9/21/22 5:48 PM: ---

[jira] [Comment Edited] (FLINK-18647) How to handle processing time timers with bounded input

2022-09-21 Thread Divye Kapoor (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607914#comment-17607914 ] Divye Kapoor edited comment on FLINK-18647 at 9/21/22 5:47 PM: ---

[jira] [Comment Edited] (FLINK-18647) How to handle processing time timers with bounded input

2022-09-21 Thread Divye Kapoor (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607914#comment-17607914 ] Divye Kapoor edited comment on FLINK-18647 at 9/21/22 5:46 PM: ---

[jira] [Commented] (FLINK-18647) How to handle processing time timers with bounded input

2022-09-21 Thread Divye Kapoor (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607914#comment-17607914 ] Divye Kapoor commented on FLINK-18647: -- Since this is an improvement ticket that co

[jira] [Commented] (FLINK-18647) How to handle processing time timers with bounded input

2022-09-21 Thread Divye Kapoor (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607907#comment-17607907 ] Divye Kapoor commented on FLINK-18647: -- [~pnowojski] – if the only implementation w

[GitHub] [flink] HuangZhenQiu commented on a diff in pull request #20875: (FLINK-29363) allow fully redirection in web dashboard

2022-09-21 Thread GitBox
HuangZhenQiu commented on code in PR #20875: URL: https://github.com/apache/flink/pull/20875#discussion_r976801184 ## flink-runtime-web/web-dashboard/src/app/app.interceptor.ts: ## @@ -39,6 +46,16 @@ export class AppInterceptor implements HttpInterceptor { return next.han

[GitHub] [flink-kubernetes-operator] usamj commented on a diff in pull request #370: [FLINK-29288] Make it possible to use job jars in the system classpath

2022-09-21 Thread GitBox
usamj commented on code in PR #370: URL: https://github.com/apache/flink-kubernetes-operator/pull/370#discussion_r976786813 ## flink-kubernetes-standalone/src/main/java/org/apache/flink/kubernetes/operator/kubeclient/parameters/StandaloneKubernetesJobManagerParameters.java: ##

[jira] [Updated] (FLINK-14896) Kinesis connector doesn't shade jackson dependency

2022-09-21 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-14896: -- Release Note: Shade and relocate transitive Jackson dependencies of {{flink-connector-kinesis}

[jira] [Updated] (FLINK-14896) Kinesis connector doesn't shade jackson dependency

2022-09-21 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-14896: -- Fix Version/s: 1.17.0 > Kinesis connector doesn't shade jackson dependency > -

[jira] [Updated] (FLINK-14896) Kinesis connector doesn't shade jackson dependency

2022-09-21 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-14896: -- Affects Version/s: 1.15.2 > Kinesis connector doesn't shade jackson dependency > -

[jira] [Assigned] (FLINK-14896) Kinesis connector doesn't shade jackson dependency

2022-09-21 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer reassigned FLINK-14896: - Assignee: Danny Cranmer > Kinesis connector doesn't shade jackson dependency >

[GitHub] [flink] gaborgsomogyi commented on a diff in pull request #20875: (FLINK-29363) allow fully redirection in web dashboard

2022-09-21 Thread GitBox
gaborgsomogyi commented on code in PR #20875: URL: https://github.com/apache/flink/pull/20875#discussion_r976740976 ## flink-runtime-web/web-dashboard/src/app/app.interceptor.ts: ## @@ -39,6 +46,16 @@ export class AppInterceptor implements HttpInterceptor { return next.ha

[GitHub] [flink-kubernetes-operator] sap1ens commented on a diff in pull request #370: [FLINK-29288] Make it possible to use job jars in the system classpath

2022-09-21 Thread GitBox
sap1ens commented on code in PR #370: URL: https://github.com/apache/flink-kubernetes-operator/pull/370#discussion_r976723478 ## flink-kubernetes-standalone/src/main/java/org/apache/flink/kubernetes/operator/kubeclient/parameters/StandaloneKubernetesJobManagerParameters.java: #

[jira] [Commented] (FLINK-29363) Allow web ui to fully redirect to other page

2022-09-21 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607848#comment-17607848 ] Gabor Somogyi commented on FLINK-29363: --- I've had a deeper look at this issue and

[jira] [Commented] (FLINK-29370) Protobuf in flink-sql-protobuf is not shaded

2022-09-21 Thread Suhan Mao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607841#comment-17607841 ] Suhan Mao commented on FLINK-29370: --- [~libenchao]  What about removing all com.google.

[jira] [Updated] (FLINK-29383) Add additionalPrinterColumns definition (PrinterColumn annotation) for some status fields

2022-09-21 Thread Xin Hao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xin Hao updated FLINK-29383: Summary: Add additionalPrinterColumns definition (PrinterColumn annotation) for some status fields (was:

[jira] [Updated] (FLINK-29383) Add additionalPrinterColumns definition for some status fields

2022-09-21 Thread Xin Hao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xin Hao updated FLINK-29383: Summary: Add additionalPrinterColumns definition for some status fields (was: Add additionalPrinterColumn

[jira] [Created] (FLINK-29383) Add additionalPrinterColumns for some status fields

2022-09-21 Thread Xin Hao (Jira)
Xin Hao created FLINK-29383: --- Summary: Add additionalPrinterColumns for some status fields Key: FLINK-29383 URL: https://issues.apache.org/jira/browse/FLINK-29383 Project: Flink Issue Type: Improve

[GitHub] [flink-kubernetes-operator] haoxins opened a new pull request, #378: Add PrinterColumn annotation for status fields

2022-09-21 Thread GitBox
haoxins opened a new pull request, #378: URL: https://github.com/apache/flink-kubernetes-operator/pull/378 ## What is the purpose of the change *(For example: This pull request adds a new feature to periodically create and maintain savepoints through the `FlinkDeployment` cust

[jira] [Commented] (FLINK-29363) Allow web ui to fully redirect to other page

2022-09-21 Thread Zhenqiu Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607823#comment-17607823 ] Zhenqiu Huang commented on FLINK-29363: --- Yes, our scenarios is exactly the same as

[GitHub] [flink] flinkbot commented on pull request #20875: (FLINK-29363) allow fully redirection in web dashboard

2022-09-21 Thread GitBox
flinkbot commented on PR #20875: URL: https://github.com/apache/flink/pull/20875#issuecomment-1253876906 ## CI report: * 4a8f9f9f850c33780f9f0d306cd8d3842b67658e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-29363) Allow web ui to fully redirect to other page

2022-09-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29363: --- Labels: pull-request-available (was: ) > Allow web ui to fully redirect to other page > ---

[GitHub] [flink] HuangZhenQiu opened a new pull request, #20875: (FLINK-29363) allow fully redirection in web dashboard

2022-09-21 Thread GitBox
HuangZhenQiu opened a new pull request, #20875: URL: https://github.com/apache/flink/pull/20875 What is the purpose of the change allow fully redirection in web dashboard when response status code is MovedPermanently, TemporaryRedirect or SeeOther. Brief change log chang

[jira] [Closed] (FLINK-29152) Describe statement resutls is different from the Hive

2022-09-21 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-29152. --- Fix Version/s: 1.16.0 1.17.0 Assignee: luoyuxia Resolution: Fixed Fixed i

[GitHub] [flink] wuchong merged pull request #20789: [FLINK-29152][hive] fix inconsistent behavior with Hive for `desc table` in Hive dialect

2022-09-21 Thread GitBox
wuchong merged PR #20789: URL: https://github.com/apache/flink/pull/20789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

[jira] [Closed] (FLINK-29151) SHOW CREATE TABLE doesn't work for Hive dialect

2022-09-21 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-29151. --- Resolution: Fixed > SHOW CREATE TABLE doesn't work for Hive dialect > --

[jira] [Comment Edited] (FLINK-29151) SHOW CREATE TABLE doesn't work for Hive dialect

2022-09-21 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607566#comment-17607566 ] Jark Wu edited comment on FLINK-29151 at 9/21/22 3:09 PM: -- Fixe

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #313: [FLINK-27852][docs] OLM installation and development documentation

2022-09-21 Thread GitBox
gyfora commented on PR #313: URL: https://github.com/apache/flink-kubernetes-operator/pull/313#issuecomment-1253848089 Yes @tedhtchang please do that. If you could write a small proposal of the benefits and what it would mean with regards to maintenance, release process etc compared to wha

[jira] [Closed] (FLINK-28755) Error when switching from stateless to savepoint upgrade mode

2022-09-21 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-28755. -- Resolution: Fixed merged to main 1eca2c5e6a62bd9f1c9e752191f8a7477903d73c > Error when switching from

[GitHub] [flink] wuchong merged pull request #20866: [BP-1.16][FLINK-29152][FLINK-29152][hive] Backport to release-1.16

2022-09-21 Thread GitBox
wuchong merged PR #20866: URL: https://github.com/apache/flink/pull/20866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #376: [FLINK-28755] Fix error when switching from stateless to savepoint upgrade mode

2022-09-21 Thread GitBox
gyfora merged PR #376: URL: https://github.com/apache/flink-kubernetes-operator/pull/376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [flink] wuchong commented on pull request #20869: [FLINK-29219][table] Fix CREATE TABLE AS statement blocks SQL client's execution

2022-09-21 Thread GitBox
wuchong commented on PR #20869: URL: https://github.com/apache/flink/pull/20869#issuecomment-1253845113 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] wuchong commented on a diff in pull request #20653: [FLINK-29020][docs] add document for CTAS feature

2022-09-21 Thread GitBox
wuchong commented on code in PR #20653: URL: https://github.com/apache/flink/pull/20653#discussion_r976322033 ## docs/content/docs/dev/table/sql/create.md: ## @@ -513,6 +516,48 @@ If you provide no like options, `INCLUDING ALL OVERWRITING OPTIONS` will be used **NOTE** The `

[GitHub] [flink] snuyanzin commented on pull request #20805: [FLINK-29198][test] Fail after maximum RetryOnException

2022-09-21 Thread GitBox
snuyanzin commented on PR #20805: URL: https://github.com/apache/flink/pull/20805#issuecomment-1253826144 Thanks for the contribution. I think it would be great to have a test here confirming that the change fixes the issue -- This is an automated message from the Apache Git Service. T

[jira] [Updated] (FLINK-29373) DataStream to table not support BigDecimalTypeInfo

2022-09-21 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-29373: --- Affects Version/s: (was: 1.17.0) > DataStream to table not support BigDecimalTypeInfo >

[jira] [Commented] (FLINK-29373) DataStream to table not support BigDecimalTypeInfo

2022-09-21 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607791#comment-17607791 ] Martijn Visser commented on FLINK-29373: [~hk__lrzy] Which version of Flink are

[jira] [Assigned] (FLINK-26203) Support Table API in Pulsar Connector

2022-09-21 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-26203: -- Assignee: Yufei Zhang > Support Table API in Pulsar Connector > -

[jira] [Commented] (FLINK-26203) Support Table API in Pulsar Connector

2022-09-21 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607789#comment-17607789 ] Martijn Visser commented on FLINK-26203: [~syhily] Done. > Support Table API i

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #377: [FLINK-28979] add owner reference to flink deployment object

2022-09-21 Thread GitBox
gyfora commented on PR #377: URL: https://github.com/apache/flink-kubernetes-operator/pull/377#issuecomment-1253794569 Also since now we support standalone integration we should probably add the owner reference for both JM and TM deployments there. That should be part of the PR + so

[jira] [Closed] (FLINK-29278) BINARY type is not supported in table store

2022-09-21 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-29278. Assignee: Nicholas Jiang Resolution: Fixed master: 422ea6072b251b04041b6ca8a738316a30069aad

[jira] [Updated] (FLINK-29375) Move getSelfGateway into RpcService

2022-09-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29375: --- Labels: pull-request-available (was: ) > Move getSelfGateway into RpcService >

[GitHub] [flink] XComp commented on a diff in pull request #20870: [FLINK-29375][rpc] Move getSelfGateway() into RpcService

2022-09-21 Thread GitBox
XComp commented on code in PR #20870: URL: https://github.com/apache/flink/pull/20870#discussion_r976555879 ## flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcService.java: ## @@ -197,6 +197,20 @@ public int getPort() { return port;

[jira] [Commented] (FLINK-29382) Flink fails to start when created using quick guide for flink operator

2022-09-21 Thread Barisa (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607770#comment-17607770 ] Barisa commented on FLINK-29382: You are right, I'm not running on the minikube, I'm usi

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #377: [FLINK-28979] add owner reference to flink deployment object

2022-09-21 Thread GitBox
gyfora commented on PR #377: URL: https://github.com/apache/flink-kubernetes-operator/pull/377#issuecomment-1253749120 What I don't understand is how this would interact with the CR deletion process. Currently when the user deletes a Flink CR the operator itself cleans up the dependent res

[GitHub] [flink-kubernetes-operator] zezaeoh commented on pull request #377: [FLINK-28979] add owner reference to flink deployment object

2022-09-21 Thread GitBox
zezaeoh commented on PR #377: URL: https://github.com/apache/flink-kubernetes-operator/pull/377#issuecomment-1253728010 Hi there, thanks for comments! We can find out what an owner reference is, and what it can do in kubernetes in the following docs: * https://kubernetes.io/docs/

[jira] [Updated] (FLINK-29382) Flink fails to start when created using quick guide for flink operator

2022-09-21 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-29382: --- Affects Version/s: kubernetes-operator-1.1.0 (was: 1.15.2) > Flink fails

[jira] [Commented] (FLINK-29382) Flink fails to start when created using quick guide for flink operator

2022-09-21 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607757#comment-17607757 ] Gyula Fora commented on FLINK-29382: What environment are you running in? the quicks

  1   2   3   >