[GitHub] [flink] Myasuka commented on a diff in pull request #20860: [FLINK-29347] [runtime] Fix ByteStreamStateHandle#read return -1 when read count is 0

2022-09-22 Thread GitBox
Myasuka commented on code in PR #20860: URL: https://github.com/apache/flink/pull/20860#discussion_r978298212 ## flink-runtime/src/test/java/org/apache/flink/runtime/state/memory/ByteStreamStateHandleTest.java: ## @@ -172,4 +172,15 @@ public void testBulkReadINdexOutOfBounds() t

[GitHub] [flink] syhily commented on pull request #20886: [FLINK-26203][Connectors / Pulsar][docs] Introduce Flink Pulsar SQL Connector

2022-09-22 Thread GitBox
syhily commented on PR #20886: URL: https://github.com/apache/flink/pull/20886#issuecomment-1255857702 Thanks for your contribution. I'll review this ASAP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #377: [FLINK-28979] Add owner reference to flink deployment object

2022-09-22 Thread GitBox
gyfora commented on code in PR #377: URL: https://github.com/apache/flink-kubernetes-operator/pull/377#discussion_r978309410 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java: ## @@ -426,4

[GitHub] [flink] flinkbot commented on pull request #20890: [FLINK-29093][table] Fix InternalCompilerException in LookupJoinITCas…

2022-09-22 Thread GitBox
flinkbot commented on PR #20890: URL: https://github.com/apache/flink/pull/20890#issuecomment-1255849462 ## CI report: * 7e9d69912530982333b4833d83c06294d32aad80 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #377: [FLINK-28979] Add owner reference to flink deployment object

2022-09-22 Thread GitBox
gyfora commented on code in PR #377: URL: https://github.com/apache/flink-kubernetes-operator/pull/377#discussion_r978307344 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java: ## @@ -426,4

[GitHub] [flink] XComp commented on pull request #20870: [FLINK-29375][rpc] Move getSelfGateway() into RpcService

2022-09-22 Thread GitBox
XComp commented on PR #20870: URL: https://github.com/apache/flink/pull/20870#issuecomment-1255847688 > I'm not too sold on that particular diagram and tried to create a revision, but dear god these online UML renderers are horrible. :-D Yeah, the class diagram in general might not be

[jira] [Closed] (FLINK-29383) Add additionalPrinterColumns definition (PrinterColumn annotation) for some status fields

2022-09-22 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-29383. -- Fix Version/s: kubernetes-operator-1.2.0 Resolution: Fixed merged to main > Add additionalPrin

[jira] [Comment Edited] (FLINK-29383) Add additionalPrinterColumns definition (PrinterColumn annotation) for some status fields

2022-09-22 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608569#comment-17608569 ] Gyula Fora edited comment on FLINK-29383 at 9/23/22 6:36 AM: -

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #378: [FLINK-29383] Add PrinterColumn annotation for status fields

2022-09-22 Thread GitBox
gyfora merged PR #378: URL: https://github.com/apache/flink-kubernetes-operator/pull/378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [flink] SmirAlex opened a new pull request, #20890: [FLINK-29093][table] Fix InternalCompilerException in LookupJoinITCas…

2022-09-22 Thread GitBox
SmirAlex opened a new pull request, #20890: URL: https://github.com/apache/flink/pull/20890 ## What is the purpose of the change Fixed unstable test LookupJoinITCase with Full cache ## Brief change log - Avoided concurrent creation of `Projection` object fro

[jira] [Commented] (FLINK-29373) DataStream to table not support BigDecimalTypeInfo

2022-09-22 Thread hk__lrzy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608567#comment-17608567 ] hk__lrzy commented on FLINK-29373: -- [~lzljs3620320] can you show more detail about this

[jira] [Closed] (FLINK-29144) Enable multiple jar entries for jarURI

2022-09-22 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-29144. -- Resolution: Fixed Resolved by 8f53441a4978eeb38dc5ef229c179cc60598ce87 > Enable multiple jar entries

[jira] [Updated] (FLINK-28181) Add support in FlinkSessionJob to submit job using jar available in jobManager's classpath

2022-09-22 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-28181: --- Fix Version/s: kubernetes-operator-1.2.0 > Add support in FlinkSessionJob to submit job using jar av

[jira] [Updated] (FLINK-29144) Enable multiple jar entries for jarURI

2022-09-22 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-29144: --- Fix Version/s: kubernetes-operator-1.2.0 > Enable multiple jar entries for jarURI >

[jira] [Closed] (FLINK-28181) Add support in FlinkSessionJob to submit job using jar available in jobManager's classpath

2022-09-22 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-28181. -- Resolution: Fixed Resolved by 8f53441a4978eeb38dc5ef229c179cc60598ce87 > Add support in FlinkSessionJ

[jira] [Updated] (FLINK-29288) Can't start a job with a jar in the system classpath

2022-09-22 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-29288: --- Fix Version/s: kubernetes-operator-1.2.0 > Can't start a job with a jar in the system classpath > --

[jira] [Closed] (FLINK-29288) Can't start a job with a jar in the system classpath

2022-09-22 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-29288. -- Resolution: Fixed merged to main 8f53441a4978eeb38dc5ef229c179cc60598ce87 > Can't start a job with a

[GitHub] [flink] PatrickRen commented on a diff in pull request #20884: [FLINK-29389][docs] Update documentation of JDBC and HBase lookup table for new caching options

2022-09-22 Thread GitBox
PatrickRen commented on code in PR #20884: URL: https://github.com/apache/flink/pull/20884#discussion_r978302806 ## docs/content/docs/connectors/table/hbase.md: ## @@ -188,20 +188,48 @@ Connector Options Whether async lookup are enabled. If true, the lookup will be async.

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #370: [FLINK-29288] Make it possible to use job jars in the system classpath

2022-09-22 Thread GitBox
gyfora merged PR #370: URL: https://github.com/apache/flink-kubernetes-operator/pull/370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [flink] flinkbot commented on pull request #20889: [BP-1.16][FLINK-28890][table] Fix semantic of latestLoadTime in caching lookup function

2022-09-22 Thread GitBox
flinkbot commented on PR #20889: URL: https://github.com/apache/flink/pull/20889#issuecomment-1255840516 ## CI report: * c5c0cf0f99c3d23d388e0c24da4e726227ddd3bc UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] PatrickRen opened a new pull request, #20889: [BP-1.16][FLINK-28890][table] Fix semantic of latestLoadTime in caching lookup function

2022-09-22 Thread GitBox
PatrickRen opened a new pull request, #20889: URL: https://github.com/apache/flink/pull/20889 Unchanged backport of #20885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink-ml] yunfengzhou-hub commented on a diff in pull request #156: [FLINK-29323] Refine Transformer for VectorAssembler

2022-09-22 Thread GitBox
yunfengzhou-hub commented on code in PR #156: URL: https://github.com/apache/flink-ml/pull/156#discussion_r978291706 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssemblerParams.java: ## @@ -21,11 +21,31 @@ import org.apache.flink.ml.common.pa

[jira] [Commented] (FLINK-28890) Incorrect semantic of latestLoadTime in CachingLookupFunction and CachingAsyncLookupFunction

2022-09-22 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608559#comment-17608559 ] Qingsheng Ren commented on FLINK-28890: --- Fixed on master: 24c685a58ef72db4c64c90e3

[GitHub] [flink-connector-elasticsearch] liyubin117 commented on pull request #39: [FLINK-29042][Connectors/ElasticSearch] Support lookup join for es connector

2022-09-22 Thread GitBox
liyubin117 commented on PR #39: URL: https://github.com/apache/flink-connector-elasticsearch/pull/39#issuecomment-1255836068 @MartijnVisser Hi. Could you please give a review? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] PatrickRen merged pull request #20885: [FLINK-28890][table] Fix semantic of latestLoadTime in caching lookup function

2022-09-22 Thread GitBox
PatrickRen merged PR #20885: URL: https://github.com/apache/flink/pull/20885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[GitHub] [flink] PatrickRen commented on pull request #20885: [FLINK-28890][table] Fix semantic of latestLoadTime in caching lookup function

2022-09-22 Thread GitBox
PatrickRen commented on PR #20885: URL: https://github.com/apache/flink/pull/20885#issuecomment-1255835762 CI has passed on my own Azure pipeline: https://dev.azure.com/renqs/Apache%20Flink/_build/results?buildId=403&view=results -- This is an automated message from the Apache Git Service

[GitHub] [flink-ml] yunfengzhou-hub commented on a diff in pull request #157: [FLINK-28906] Support windowing in AgglomerativeClustering

2022-09-22 Thread GitBox
yunfengzhou-hub commented on code in PR #157: URL: https://github.com/apache/flink-ml/pull/157#discussion_r978288171 ## docs/content/docs/operators/clustering/agglomerativeclustering.md: ## @@ -49,15 +49,16 @@ format of the merging information is ### Parameters -| Key

[jira] [Commented] (FLINK-29315) HDFSTest#testBlobServerRecovery fails on CI

2022-09-22 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608552#comment-17608552 ] Yang Wang commented on FLINK-29315: --- [~chesnay] Do you have any other suggestions? I a

[GitHub] [flink] fredia commented on pull request #20860: [FLINK-29347] [runtime] Fix ByteStreamStateHandle#read return -1 when read count is 0

2022-09-22 Thread GitBox
fredia commented on PR #20860: URL: https://github.com/apache/flink/pull/20860#issuecomment-1255821002 @Shenjiaqi Thanks for this PR, LGTM. Could you please add the ticket id and module name `[FLINK-29347] [runtime]` to the commit message? @Myasuka Would you like to take a look?

[GitHub] [flink] ijuma commented on pull request #20526: [FLINK-28060][kafka] Bump Kafka to 3.2.1

2022-09-22 Thread GitBox
ijuma commented on PR #20526: URL: https://github.com/apache/flink/pull/20526#issuecomment-1255795806 Fyi, Kafka 3.2.3 was released. We recommend upgrading to that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [flink] Tartarus0zm closed pull request #20858: [FLINK-29219][table]fix CREATE TABLE AS statement blocks SQL client's execution

2022-09-22 Thread GitBox
Tartarus0zm closed pull request #20858: [FLINK-29219][table]fix CREATE TABLE AS statement blocks SQL client's execution URL: https://github.com/apache/flink/pull/20858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [flink] Tartarus0zm commented on pull request #20858: [FLINK-29219][table]fix CREATE TABLE AS statement blocks SQL client's execution

2022-09-22 Thread GitBox
Tartarus0zm commented on PR #20858: URL: https://github.com/apache/flink/pull/20858#issuecomment-1255770862 @lsyldliu ok, thanks for your work -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] lsyldliu commented on a diff in pull request #20884: [FLINK-29389][docs] Update documentation of JDBC and HBase lookup table for new caching options

2022-09-22 Thread GitBox
lsyldliu commented on code in PR #20884: URL: https://github.com/apache/flink/pull/20884#discussion_r978244951 ## docs/content/docs/connectors/table/hbase.md: ## @@ -188,20 +188,48 @@ Connector Options Whether async lookup are enabled. If true, the lookup will be async.

[GitHub] [flink] lsyldliu commented on a diff in pull request #20884: [FLINK-29389][docs] Update documentation of JDBC and HBase lookup table for new caching options

2022-09-22 Thread GitBox
lsyldliu commented on code in PR #20884: URL: https://github.com/apache/flink/pull/20884#discussion_r978244951 ## docs/content/docs/connectors/table/hbase.md: ## @@ -188,20 +188,48 @@ Connector Options Whether async lookup are enabled. If true, the lookup will be async.

[GitHub] [flink] lsyldliu commented on a diff in pull request #20884: [FLINK-29389][docs] Update documentation of JDBC and HBase lookup table for new caching options

2022-09-22 Thread GitBox
lsyldliu commented on code in PR #20884: URL: https://github.com/apache/flink/pull/20884#discussion_r978244951 ## docs/content/docs/connectors/table/hbase.md: ## @@ -188,20 +188,48 @@ Connector Options Whether async lookup are enabled. If true, the lookup will be async.

[jira] [Comment Edited] (FLINK-29315) HDFSTest#testBlobServerRecovery fails on CI

2022-09-22 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608486#comment-17608486 ] Qingsheng Ren edited comment on FLINK-29315 at 9/23/22 3:20 AM: --

[jira] [Commented] (FLINK-29315) HDFSTest#testBlobServerRecovery fails on CI

2022-09-22 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608486#comment-17608486 ] Qingsheng Ren commented on FLINK-29315: --- [https://dev.azure.com/apache-flink/apach

[jira] [Commented] (FLINK-29315) HDFSTest#testBlobServerRecovery fails on CI

2022-09-22 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608487#comment-17608487 ] Qingsheng Ren commented on FLINK-29315: --- [https://dev.azure.com/apache-flink/apach

[jira] (FLINK-29315) HDFSTest#testBlobServerRecovery fails on CI

2022-09-22 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29315 ] Qingsheng Ren deleted comment on FLINK-29315: --- was (Author: renqs): [https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=41259&view=logs&j=4eda0b4a-bd0d-521a-0916-8285b9b

[GitHub] [flink] PatrickRen commented on a diff in pull request #20884: [FLINK-29389][docs] Update documentation of JDBC and HBase lookup table for new caching options

2022-09-22 Thread GitBox
PatrickRen commented on code in PR #20884: URL: https://github.com/apache/flink/pull/20884#discussion_r978237058 ## docs/content/docs/connectors/table/hbase.md: ## @@ -188,20 +188,48 @@ Connector Options Whether async lookup are enabled. If true, the lookup will be async.

[GitHub] [flink] PatrickRen commented on a diff in pull request #20884: [FLINK-29389][docs] Update documentation of JDBC and HBase lookup table for new caching options

2022-09-22 Thread GitBox
PatrickRen commented on code in PR #20884: URL: https://github.com/apache/flink/pull/20884#discussion_r978232542 ## docs/content/docs/connectors/table/jdbc.md: ## @@ -211,30 +211,48 @@ Connector Options https://jdbc.postgresql.org/documentation/head/query.html#query-with-

[jira] [Commented] (FLINK-29373) DataStream to table not support BigDecimalTypeInfo

2022-09-22 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608478#comment-17608478 ] Jingsong Lee commented on FLINK-29373: -- {code:java} /** * Converter from {@link Ty

[jira] [Commented] (FLINK-29349) Use state ttl instead of timer to clean up state in proctime unbounded over aggregate

2022-09-22 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608479#comment-17608479 ] Jingsong Lee commented on FLINK-29349: -- [~lincoln.86xy] yes, you can > Use state t

[jira] [Updated] (FLINK-29042) Support lookup join for es connector

2022-09-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29042: --- Labels: pull-request-available (was: ) > Support lookup join for es connector > ---

[GitHub] [flink-connector-elasticsearch] boring-cyborg[bot] commented on pull request #39: [FLINK-29042][Connectors/ElasticSearch] Support lookup join for es connector

2022-09-22 Thread GitBox
boring-cyborg[bot] commented on PR #39: URL: https://github.com/apache/flink-connector-elasticsearch/pull/39#issuecomment-1255746950 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- T

[GitHub] [flink-connector-elasticsearch] liyubin117 opened a new pull request, #39: [FLINK-29042][Connectors/ElasticSearch] Support lookup join for es connector

2022-09-22 Thread GitBox
liyubin117 opened a new pull request, #39: URL: https://github.com/apache/flink-connector-elasticsearch/pull/39 Now es connector could only be used as a sink, but in many business scenarios, we treat es as a index database, we should support to make it lookupable in flink. -- This is an

[GitHub] [flink] yuzelin commented on a diff in pull request #20887: [FLINK-29229][hive] Fix ObjectStore leak when different users has dif…

2022-09-22 Thread GitBox
yuzelin commented on code in PR #20887: URL: https://github.com/apache/flink/pull/20887#discussion_r978214084 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/endpoint/hive/HiveServer2Endpoint.java: ## @@ -296,22 +296,27 @@ public TOpenSessionResp Op

[jira] [Commented] (FLINK-29315) HDFSTest#testBlobServerRecovery fails on CI

2022-09-22 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608471#comment-17608471 ] Huang Xingbo commented on FLINK-29315: -- I think it may be very difficult to find th

[GitHub] [flink] wuchong commented on pull request #20653: [FLINK-29020][docs] add document for CTAS feature

2022-09-22 Thread GitBox
wuchong commented on PR #20653: URL: https://github.com/apache/flink/pull/20653#issuecomment-1255730398 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] wuchong commented on pull request #20869: [FLINK-29219][table] Fix CREATE TABLE AS statement blocks SQL client's execution

2022-09-22 Thread GitBox
wuchong commented on PR #20869: URL: https://github.com/apache/flink/pull/20869#issuecomment-1255730305 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] wuchong commented on pull request #20880: [FLINK-29219][table] Fix CREATE TABLE AS statement blocks SQL client's execution

2022-09-22 Thread GitBox
wuchong commented on PR #20880: URL: https://github.com/apache/flink/pull/20880#issuecomment-1255730186 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-29400) Default Value of env.log.max in documentation is incorrect

2022-09-22 Thread Hang HOU (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608467#comment-17608467 ] Hang HOU commented on FLINK-29400: -- Hi ,if no more modify like "env.log.max" in conf/fl

[GitHub] [flink-web] HuangXingBo commented on a diff in pull request #569: Release Flink 1.14.6

2022-09-22 Thread GitBox
HuangXingBo commented on code in PR #569: URL: https://github.com/apache/flink-web/pull/569#discussion_r978215248 ## _posts/2022-09-08-release-1.14.6.md: ## @@ -0,0 +1,105 @@ +--- +layout: post +title: "Apache Flink 1.14.6 Release Announcement" +date: 2022-09-08T00:00:00.000Z

[jira] [Commented] (FLINK-18346) Support partition pruning for lookup table source

2022-09-22 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608466#comment-17608466 ] Jingsong Lee commented on FLINK-18346: -- cc: [~godfreyhe] > Support partition prun

[GitHub] [flink] yuzelin closed pull request #20861: [FLINK-29274][hive] Fix unstable tests in HiveServer2EndpointITCase

2022-09-22 Thread GitBox
yuzelin closed pull request #20861: [FLINK-29274][hive] Fix unstable tests in HiveServer2EndpointITCase URL: https://github.com/apache/flink/pull/20861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [flink] lsyldliu commented on pull request #20858: [FLINK-29219][table]fix CREATE TABLE AS statement blocks SQL client's execution

2022-09-22 Thread GitBox
lsyldliu commented on PR #20858: URL: https://github.com/apache/flink/pull/20858#issuecomment-1255719282 @Tartarus0zm close this pr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [flink] lsyldliu commented on a diff in pull request #20884: [FLINK-29389][docs] Update documentation of JDBC and HBase lookup table for new caching options

2022-09-22 Thread GitBox
lsyldliu commented on code in PR #20884: URL: https://github.com/apache/flink/pull/20884#discussion_r978203393 ## docs/content/docs/connectors/table/jdbc.md: ## @@ -211,30 +211,48 @@ Connector Options https://jdbc.postgresql.org/documentation/head/query.html#query-with-cu

[GitHub] [flink] luoyuxia commented on pull request #20883: [WIP] validate for https://github.com/apache/flink/pull/20882

2022-09-22 Thread GitBox
luoyuxia commented on PR #20883: URL: https://github.com/apache/flink/pull/20883#issuecomment-1255702462 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink-kubernetes-operator] zezaeoh commented on pull request #377: [FLINK-28979] add owner reference to flink deployment object

2022-09-22 Thread GitBox
zezaeoh commented on PR #377: URL: https://github.com/apache/flink-kubernetes-operator/pull/377#issuecomment-1255669662 It looks like e2e test failed because of connection time out from maven repo 😢 Could you give me a one more try? @gyfora ![image](https://user-images.githubus

[GitHub] [flink] zentol commented on pull request #20870: [FLINK-29375][rpc] Move getSelfGateway() into RpcService

2022-09-22 Thread GitBox
zentol commented on PR #20870: URL: https://github.com/apache/flink/pull/20870#issuecomment-1255654652 > I came up with another diagram (see [gist](https://gist.github.com/XComp/1ee7e935e38209afd774cd7d23af0833)) that visualizes the relationships between the different classes of the RPC sys

[jira] [Updated] (FLINK-29340) ResourceManagerTest#testProcessResourceRequirementsWhenRecoveryFinished prone to race condition

2022-09-22 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-29340: - Priority: Minor (was: Major) > ResourceManagerTest#testProcessResourceRequirementsWhenR

[jira] [Closed] (FLINK-29340) ResourceManagerTest#testProcessResourceRequirementsWhenRecoveryFinished prone to race condition

2022-09-22 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-29340. Fix Version/s: 1.17.0 Resolution: Fixed master: a54b2a8674e4df6345968e538636a796011

[GitHub] [flink] zentol merged pull request #20871: [FLINK-29340][coordination][tests] Avoid selfGateway implementation d…

2022-09-22 Thread GitBox
zentol merged PR #20871: URL: https://github.com/apache/flink/pull/20871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Comment Edited] (FLINK-29397) Race condition in StreamTask can lead to NPE if changelog is disabled

2022-09-22 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608399#comment-17608399 ] Chesnay Schepler edited comment on FLINK-29397 at 9/22/22 11:17 PM: --

[jira] [Closed] (FLINK-29397) Race condition in StreamTask can lead to NPE if changelog is disabled

2022-09-22 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-29397. Resolution: Fixed > Race condition in StreamTask can lead to NPE if changelog is disabled

[jira] [Comment Edited] (FLINK-29397) Race condition in StreamTask can lead to NPE if changelog is disabled

2022-09-22 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608399#comment-17608399 ] Chesnay Schepler edited comment on FLINK-29397 at 9/22/22 11:14 PM: --

[jira] [Comment Edited] (FLINK-29378) Misleading logging in Execution for failed state trannsitions

2022-09-22 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608264#comment-17608264 ] Chesnay Schepler edited comment on FLINK-29378 at 9/22/22 11:14 PM: --

[jira] [Closed] (FLINK-29378) Misleading logging in Execution for failed state trannsitions

2022-09-22 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-29378. Resolution: Fixed > Misleading logging in Execution for failed state trannsitions > --

[jira] [Created] (FLINK-29400) Default Value of env.log.max in documentation is incorrect

2022-09-22 Thread Dhruv Patel (Jira)
Dhruv Patel created FLINK-29400: --- Summary: Default Value of env.log.max in documentation is incorrect Key: FLINK-29400 URL: https://issues.apache.org/jira/browse/FLINK-29400 Project: Flink Issu

[jira] [Created] (FLINK-29399) TableITCase is unstable

2022-09-22 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-29399: Summary: TableITCase is unstable Key: FLINK-29399 URL: https://issues.apache.org/jira/browse/FLINK-29399 Project: Flink Issue Type: Bug Com

[jira] [Closed] (FLINK-29393) Upgrade Kubernetes operator examples to use the latest Flink base image

2022-09-22 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-29393. -- Resolution: Fixed merged to main 66987fb9b4d6f7a315024cff27dac12886b1ee88 > Upgrade Kubernetes operat

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #381: [FLINK-29393] Upgrade Kubernetes operator examples to use 1.15.2 Flink base image

2022-09-22 Thread GitBox
gyfora merged PR #381: URL: https://github.com/apache/flink-kubernetes-operator/pull/381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[jira] [Closed] (FLINK-28966) Check backward compatibility against both 1.1.0 and 1.0.0 (all released versions)

2022-09-22 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-28966. -- Resolution: Fixed merged to main f41025da98d21c4e8404b6554e9c3d6a6ce0a4fb > Check backward compatibil

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #380: [FLINK-28966] Check backward compatibility against both 1.1.0 and 1.0…

2022-09-22 Thread GitBox
gyfora merged PR #380: URL: https://github.com/apache/flink-kubernetes-operator/pull/380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[jira] [Commented] (FLINK-29398) Utilize Rack Awareness in Flink Consumer

2022-09-22 Thread Jeremy DeGroot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608412#comment-17608412 ] Jeremy DeGroot commented on FLINK-29398: I'll provide a little further justifica

[jira] [Created] (FLINK-29398) Utilize Rack Awareness in Flink Consumer

2022-09-22 Thread Jeremy DeGroot (Jira)
Jeremy DeGroot created FLINK-29398: -- Summary: Utilize Rack Awareness in Flink Consumer Key: FLINK-29398 URL: https://issues.apache.org/jira/browse/FLINK-29398 Project: Flink Issue Type: Impr

[jira] [Updated] (FLINK-29364) Root cause of Exceptions thrown in the SourceReader start() method gets "swallowed".

2022-09-22 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov updated FLINK-29364: -- Description: If an exception is thrown in the {_}SourceReader{_}'s _start()_ method, i

[jira] [Commented] (FLINK-29397) Race condition in StreamTask can lead to NPE if changelog is disabled

2022-09-22 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608399#comment-17608399 ] Chesnay Schepler commented on FLINK-29397: -- master: 162db046e1c63e4610393d14cd9

[GitHub] [flink] zentol merged pull request #20888: [FLINK-29397][runtime] Check if changelog provider is null

2022-09-22 Thread GitBox
zentol merged PR #20888: URL: https://github.com/apache/flink/pull/20888 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Updated] (FLINK-29397) Race condition in StreamTask can lead to NPE if changelog is disabled

2022-09-22 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-29397: - Affects Version/s: 1.15.0 (was: 1.16.0) > Race condition in S

[jira] [Updated] (FLINK-29397) Race condition in StreamTask can lead to NPE if changelog is disabled

2022-09-22 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-29397: - Fix Version/s: 1.15.3 > Race condition in StreamTask can lead to NPE if changelog is dis

[jira] [Updated] (FLINK-29394) Flink k8s operator observe Flink job restart count

2022-09-22 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-29394: --- Affects Version/s: kubernetes-operator-1.1.0 (was: 1.15.2) > Flink k8s op

[jira] [Updated] (FLINK-29394) Flink k8s operator observe Flink job restart count

2022-09-22 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-29394: --- Issue Type: New Feature (was: Improvement) > Flink k8s operator observe Flink job restart count > -

[GitHub] [flink-kubernetes-operator] HuangZhenQiu commented on a diff in pull request #375: [FLINK-29327][operator] remove operator config from job runtime config before d…

2022-09-22 Thread GitBox
HuangZhenQiu commented on code in PR #375: URL: https://github.com/apache/flink-kubernetes-operator/pull/375#discussion_r977872055 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java: ## @@ -624,7 +626,7 @@ protected

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #378: [FLINK-29383] Add PrinterColumn annotation for status fields

2022-09-22 Thread GitBox
gyfora commented on PR #378: URL: https://github.com/apache/flink-kubernetes-operator/pull/378#issuecomment-1255253489 > No objections. How would we accommodate another request that prefers some different columns though :) We could then start to prioritize some fields and limit it to

[GitHub] [flink-kubernetes-operator] gaborgsomogyi commented on a diff in pull request #381: [FLINK-29393] Upgrade Kubernetes operator examples to use 1.15.2 Flink base image

2022-09-22 Thread GitBox
gaborgsomogyi commented on code in PR #381: URL: https://github.com/apache/flink-kubernetes-operator/pull/381#discussion_r977845730 ## examples/flink-sql-runner-example/Dockerfile: ## @@ -16,7 +16,7 @@ # limitations under the License.

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #381: [FLINK-29393] Upgrade Kubernetes operator examples to use 1.15.2 Flink base image

2022-09-22 Thread GitBox
gyfora commented on code in PR #381: URL: https://github.com/apache/flink-kubernetes-operator/pull/381#discussion_r977844254 ## examples/flink-sql-runner-example/Dockerfile: ## @@ -16,7 +16,7 @@ # limitations under the License. ###

[GitHub] [flink-kubernetes-operator] tweise commented on pull request #378: [FLINK-29383] Add PrinterColumn annotation for status fields

2022-09-22 Thread GitBox
tweise commented on PR #378: URL: https://github.com/apache/flink-kubernetes-operator/pull/378#issuecomment-1255242895 No objections. How would we accommodate another request that prefers some different columns though :) -- This is an automated message from the Apache Git Service. To res

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #370: [FLINK-29288] Make it possible to use job jars in the system classpath

2022-09-22 Thread GitBox
gyfora commented on PR #370: URL: https://github.com/apache/flink-kubernetes-operator/pull/370#issuecomment-1255241160 Thank you for the great work @sap1ens , I will merge this once the CI passes! -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #375: [FLINK-29327][operator] remove operator config from job runtime config before d…

2022-09-22 Thread GitBox
gyfora commented on code in PR #375: URL: https://github.com/apache/flink-kubernetes-operator/pull/375#discussion_r977837521 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java: ## @@ -666,7 +668,7 @@ private JarRunR

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #378: [FLINK-29383] Add PrinterColumn annotation for status fields

2022-09-22 Thread GitBox
gyfora commented on PR #378: URL: https://github.com/apache/flink-kubernetes-operator/pull/378#issuecomment-1255232775 @tweise any objections against merging this based on the additional input? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink-kubernetes-operator] tedhtchang closed pull request #313: [FLINK-27852][docs] OLM installation and development documentation

2022-09-22 Thread GitBox
tedhtchang closed pull request #313: [FLINK-27852][docs] OLM installation and development documentation URL: https://github.com/apache/flink-kubernetes-operator/pull/313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [flink-kubernetes-operator] sap1ens commented on pull request #370: [FLINK-29288] Make it possible to use job jars in the system classpath

2022-09-22 Thread GitBox
sap1ens commented on PR #370: URL: https://github.com/apache/flink-kubernetes-operator/pull/370#issuecomment-1255216631 @gyfora I squashed the commits, this is ready to be merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [flink-kubernetes-operator] sap1ens commented on a diff in pull request #370: [FLINK-29288] Make it possible to use job jars in the system classpath

2022-09-22 Thread GitBox
sap1ens commented on code in PR #370: URL: https://github.com/apache/flink-kubernetes-operator/pull/370#discussion_r977817257 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultValidator.java: ## @@ -180,10 +180,6 @@ private Option

[GitHub] [flink-kubernetes-operator] gaborgsomogyi commented on pull request #381: [FLINK-29393] Upgrade Kubernetes operator examples to use 1.15.2 Flink base image

2022-09-22 Thread GitBox
gaborgsomogyi commented on PR #381: URL: https://github.com/apache/flink-kubernetes-operator/pull/381#issuecomment-1255195133 cc @gyfora -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [flink-kubernetes-operator] gaborgsomogyi opened a new pull request, #381: [FLINK-29393] Upgrade Kubernetes operator examples to use 1.15.2 Flink base image

2022-09-22 Thread GitBox
gaborgsomogyi opened a new pull request, #381: URL: https://github.com/apache/flink-kubernetes-operator/pull/381 ## What is the purpose of the change There were several places where 1.15.1 was hardcoded. In this PR I've changed them to the latest 1.15.2. ## Brief change log

[jira] [Updated] (FLINK-29393) Upgrade Kubernetes operator examples to use the latest Flink base image

2022-09-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29393: --- Labels: pull-request-available (was: ) > Upgrade Kubernetes operator examples to use the la

[GitHub] [flink-kubernetes-operator] HuangZhenQiu commented on a diff in pull request #375: [FLINK-29327][operator] remove operator config from job runtime config before d…

2022-09-22 Thread GitBox
HuangZhenQiu commented on code in PR #375: URL: https://github.com/apache/flink-kubernetes-operator/pull/375#discussion_r977795734 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java: ## @@ -182,7 +184,13 @@ public J

[GitHub] [flink] afedulov commented on pull request #20865: [FLINK-14896][connectors/kinesis] Shade and relocate Jackson dependen…

2022-09-22 Thread GitBox
afedulov commented on PR #20865: URL: https://github.com/apache/flink/pull/20865#issuecomment-1255169612 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] HuangZhenQiu commented on a diff in pull request #20875: [FLINK-29363][runtime-web] allow fully redirection in web dashboard

2022-09-22 Thread GitBox
HuangZhenQiu commented on code in PR #20875: URL: https://github.com/apache/flink/pull/20875#discussion_r976801184 ## flink-runtime-web/web-dashboard/src/app/app.interceptor.ts: ## @@ -39,6 +46,16 @@ export class AppInterceptor implements HttpInterceptor { return next.han

  1   2   3   >