[GitHub] [flink] snuyanzin commented on a diff in pull request #20850: [FLINK-20873][Table SQl/API] Update to calcite 1.27

2022-10-11 Thread GitBox
snuyanzin commented on code in PR #20850: URL: https://github.com/apache/flink/pull/20850#discussion_r992790858 ## flink-table/flink-sql-parser-hive/pom.xml: ## @@ -56,6 +56,12 @@ under the License. guava ${guava.version}

[GitHub] [flink] snuyanzin commented on a diff in pull request #20850: [FLINK-20873][Table SQl/API] Update to calcite 1.27

2022-10-11 Thread GitBox
snuyanzin commented on code in PR #20850: URL: https://github.com/apache/flink/pull/20850#discussion_r992790858 ## flink-table/flink-sql-parser-hive/pom.xml: ## @@ -56,6 +56,12 @@ under the License. guava ${guava.version}

[GitHub] [flink] luoyuxia commented on pull request #20907: Flink 29337 hive3

2022-10-11 Thread GitBox
luoyuxia commented on PR #20907: URL: https://github.com/apache/flink/pull/20907#issuecomment-1275678633 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink-ml] yunfengzhou-hub commented on a diff in pull request #160: [FLINK-29434] Add AlgoOperator for Splitter

2022-10-11 Thread GitBox
yunfengzhou-hub commented on code in PR #160: URL: https://github.com/apache/flink-ml/pull/160#discussion_r993058402 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/splitter/Splitter.java: ## @@ -0,0 +1,111 @@ +/* Review Comment: In order to align the functionality

[GitHub] [flink] twalthr commented on a diff in pull request #20850: [FLINK-20873][Table SQl/API] Update to calcite 1.27

2022-10-11 Thread GitBox
twalthr commented on code in PR #20850: URL: https://github.com/apache/flink/pull/20850#discussion_r992266138 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/batch/sql/join/NestedLoopSemiAntiJoinTest.xml: ## @@ -673,8 +673,8 @@ Calc(sele

[GitHub] [flink] twalthr commented on a diff in pull request #20850: [FLINK-20873][Table SQl/API] Update to calcite 1.27

2022-10-11 Thread GitBox
twalthr commented on code in PR #20850: URL: https://github.com/apache/flink/pull/20850#discussion_r993052648 ## flink-table/flink-table-planner/pom.xml: ## @@ -127,22 +127,22 @@ under the License. ${calcite.version}

[GitHub] [flink] twalthr commented on a diff in pull request #20850: [FLINK-20873][Table SQl/API] Update to calcite 1.27

2022-10-11 Thread GitBox
twalthr commented on code in PR #20850: URL: https://github.com/apache/flink/pull/20850#discussion_r993051603 ## flink-table/flink-sql-parser/pom.xml: ## @@ -193,6 +204,10 @@ under the License. org.apiguardian Review Comment: It would

[GitHub] [flink-kubernetes-operator] haoxins commented on pull request #399: [FLINK-29581] Trigger warning event for session job reconciliation exception

2022-10-11 Thread GitBox
haoxins commented on PR #399: URL: https://github.com/apache/flink-kubernetes-operator/pull/399#issuecomment-1275662962 > Can you please add a test case for this? will do -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] luoyuxia commented on pull request #20907: Flink 29337 hive3

2022-10-11 Thread GitBox
luoyuxia commented on PR #20907: URL: https://github.com/apache/flink/pull/20907#issuecomment-1275653694 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Created] (FLINK-29591) Add built-in UDFs to convert between arrays and vectors

2022-10-11 Thread Yunfeng Zhou (Jira)
Yunfeng Zhou created FLINK-29591: Summary: Add built-in UDFs to convert between arrays and vectors Key: FLINK-29591 URL: https://issues.apache.org/jira/browse/FLINK-29591 Project: Flink Issue

[jira] [Commented] (FLINK-29492) Kafka exactly-once sink causes OutOfMemoryError

2022-10-11 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616207#comment-17616207 ] Qingsheng Ren commented on FLINK-29492: --- Thanks [~ruanhang1993] . I've assign the

[jira] [Commented] (FLINK-29006) PulsarSourceITCase failed with Could not acquire the minimum required resources.

2022-10-11 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616205#comment-17616205 ] Yufan Sheng commented on FLINK-29006: - [~hxb] I think we can close this issue if no

[jira] [Assigned] (FLINK-29492) Kafka exactly-once sink causes OutOfMemoryError

2022-10-11 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren reassigned FLINK-29492: - Assignee: Hang Ruan > Kafka exactly-once sink causes OutOfMemoryError > ---

[jira] [Commented] (FLINK-3033) Redis Source Connector

2022-10-11 Thread waywtdcc (Jira)
[ https://issues.apache.org/jira/browse/FLINK-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616199#comment-17616199 ] waywtdcc commented on FLINK-3033: - [~pramod] Hello, where is the Redis connector you wrot

[jira] [Commented] (FLINK-28229) Introduce Source API alternatives for StreamExecutionEnvironment#fromCollection() methods

2022-10-11 Thread Tigran Manasyan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616198#comment-17616198 ] Tigran Manasyan commented on FLINK-28229: - Hello, [~martijnvisser] ! I have impl

[jira] [Comment Edited] (FLINK-28049) Introduce FLIP-208 functionality to stop Source based on consumed records

2022-10-11 Thread Sergey Troshkov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616187#comment-17616187 ] Sergey Troshkov edited comment on FLINK-28049 at 10/12/22 5:13 AM: ---

[jira] [Commented] (FLINK-28049) Introduce FLIP-208 functionality to stop Source based on consumed records

2022-10-11 Thread Sergey Troshkov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616187#comment-17616187 ] Sergey Troshkov commented on FLINK-28049: - Thank you! > Introduce FLIP-208 func

[GitHub] [flink] hehuiyuan commented on pull request #21011: [FLINK-29333][TABLE]Support the tableconfig object get configuration infos from flink-conf.yaml file

2022-10-11 Thread GitBox
hehuiyuan commented on PR #21011: URL: https://github.com/apache/flink/pull/21011#issuecomment-1275590651 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Closed] (FLINK-25409) Add cache metric to LookupFunction

2022-10-11 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren closed FLINK-25409. - Resolution: Fixed > Add cache metric to LookupFunction > -- > >

[GitHub] [flink-table-store] JingsongLi commented on pull request #313: [FLINK-27958] Compare batch maxKey to reduce comparisons in SortMergeReader

2022-10-11 Thread GitBox
JingsongLi commented on PR #313: URL: https://github.com/apache/flink-table-store/pull/313#issuecomment-1275570471 Hi @zjureel can you do some benchmark to verify the improvement? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [flink-table-store] JingsongLi commented on pull request #313: [FLINK-27958] Compare batch maxKey to reduce comparisons in SortMergeReader

2022-10-11 Thread GitBox
JingsongLi commented on PR #313: URL: https://github.com/apache/flink-table-store/pull/313#issuecomment-1275570123 CC: @tsreaper -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [flink-table-store] JingsongLi commented on pull request #305: [FLINK-28256] Move the write and prepareCommit logic of AbstractTableWrite to FileStoreWrite

2022-10-11 Thread GitBox
JingsongLi commented on PR #305: URL: https://github.com/apache/flink-table-store/pull/305#issuecomment-1275569659 Thanks for the update, just left one minor comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[jira] [Resolved] (FLINK-28618) Cannot use hive.dialect on master

2022-10-11 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia resolved FLINK-28618. -- Resolution: Fixed Close it since I haven't reproduced this problem using  master branch. Feel free to

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #305: [FLINK-28256] Move the write and prepareCommit logic of AbstractTableWrite to FileStoreWrite

2022-10-11 Thread GitBox
JingsongLi commented on code in PR #305: URL: https://github.com/apache/flink-table-store/pull/305#discussion_r992981418 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/table/sink/WriteFunction.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [flink] flinkbot commented on pull request #21026: [FLINK-29590][hive] fix literal issue in Hive dialect

2022-10-11 Thread GitBox
flinkbot commented on PR #21026: URL: https://github.com/apache/flink/pull/21026#issuecomment-1275560087 ## CI report: * b35021c3135509cbcb1a33f30180ffc2626f19b2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-29590) Fix literal issue in HiveDialect

2022-10-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29590: --- Labels: pull-request-available (was: ) > Fix literal issue in HiveDialect > ---

[GitHub] [flink] luoyuxia opened a new pull request, #21026: [FLINK-29590][hive] fix literal issue in Hive dialect

2022-10-11 Thread GitBox
luoyuxia opened a new pull request, #21026: URL: https://github.com/apache/flink/pull/21026 ## What is the purpose of the change To fix the thrown excpetion with literal in Hive dialect. 1: some folded constant like `Double.NAN` and no-primitive type  can't be convert into calc

[jira] [Commented] (FLINK-29492) Kafka exactly-once sink causes OutOfMemoryError

2022-10-11 Thread Hang Ruan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616169#comment-17616169 ] Hang Ruan commented on FLINK-29492: --- I am interested in this bug. Maybe I could help t

[GitHub] [flink] zoltar9264 commented on pull request #20965: [FLINK-29244][state/changelog] Add metric lastMaterializationDuration…

2022-10-11 Thread GitBox
zoltar9264 commented on PR #20965: URL: https://github.com/apache/flink/pull/20965#issuecomment-1275551163 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [flink] zoltar9264 commented on pull request #20975: [FLINK-29526][state/changelog] fix java doc mistake in SequenceNumber…

2022-10-11 Thread GitBox
zoltar9264 commented on PR #20975: URL: https://github.com/apache/flink/pull/20975#issuecomment-1275550883 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Commented] (FLINK-28786) Cannot run PyFlink 1.16 on MacOS with M1 chip

2022-10-11 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616165#comment-17616165 ] Ran Tao commented on FLINK-28786: - [~grimsby] Yes, you are right. when i change to conda

[GitHub] [flink] luoyuxia commented on pull request #20855: [FLINK-29337][hive] Fix fail to query non-hive table in Hive dialect

2022-10-11 Thread GitBox
luoyuxia commented on PR #20855: URL: https://github.com/apache/flink/pull/20855#issuecomment-1275532530 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-25343) HBaseConnectorITCase.testTableSourceSinkWithDDL fail on azure

2022-10-11 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616152#comment-17616152 ] Xingbo Huang commented on FLINK-25343: -- https://dev.azure.com/apache-flink/apache-f

[GitHub] [flink] HuangXingBo commented on pull request #20920: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2022-10-11 Thread GitBox
HuangXingBo commented on PR #20920: URL: https://github.com/apache/flink/pull/20920#issuecomment-1275520470 cc @PatrickRen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-29405) InputFormatCacheLoaderTest is unstable

2022-10-11 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616151#comment-17616151 ] Xingbo Huang commented on FLINK-29405: -- https://dev.azure.com/apache-flink/apache-f

[GitHub] [flink] HuangXingBo commented on pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2022-10-11 Thread GitBox
HuangXingBo commented on PR #20919: URL: https://github.com/apache/flink/pull/20919#issuecomment-1275520363 cc @PatrickRen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink-ml] weibozhao commented on a diff in pull request #156: [FLINK-29323] Refine Transformer for VectorAssembler

2022-10-11 Thread GitBox
weibozhao commented on code in PR #156: URL: https://github.com/apache/flink-ml/pull/156#discussion_r992921852 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssembler.java: ## @@ -47,10 +47,15 @@ /** * A Transformer which combines a given l

[GitHub] [flink-table-store] JingsongLi commented on pull request #314: [FLINK-28128] Add e2e test for spark reader

2022-10-11 Thread GitBox
JingsongLi commented on PR #314: URL: https://github.com/apache/flink-table-store/pull/314#issuecomment-1275519030 Thanks @zjureel , I just left one minor comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #314: [FLINK-28128] Add e2e test for spark reader

2022-10-11 Thread GitBox
JingsongLi commented on code in PR #314: URL: https://github.com/apache/flink-table-store/pull/314#discussion_r992939690 ## flink-table-store-e2e-tests/src/test/java/org/apache/flink/table/store/tests/SparkE2eTest.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Softwar

[jira] [Updated] (FLINK-29590) Fix literal issue in HiveDialect

2022-10-11 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-29590: - Description: in FLINK-26474, we try to fold constant, but it brings a issue that the folded constant li

[jira] [Commented] (FLINK-29572) Flink Task Manager skip loopback interface for resource manager registration

2022-10-11 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616142#comment-17616142 ] Xintong Song commented on FLINK-29572: -- After looking into this a bit more, I think

[GitHub] [flink-ml] weibozhao commented on a diff in pull request #156: [FLINK-29323] Refine Transformer for VectorAssembler

2022-10-11 Thread GitBox
weibozhao commented on code in PR #156: URL: https://github.com/apache/flink-ml/pull/156#discussion_r992921852 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssembler.java: ## @@ -47,10 +47,15 @@ /** * A Transformer which combines a given l

[jira] [Updated] (FLINK-29590) Fix literal issue in HiveDialect

2022-10-11 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-29590: - Description: in FLINK-26474, we try to fold constant, but it may bring a issue that the folded constant

[GitHub] [flink] libenchao commented on pull request #20140: [Flink 16024][Connector][JDBC] Support FilterPushdown

2022-10-11 Thread GitBox
libenchao commented on PR #20140: URL: https://github.com/apache/flink/pull/20140#issuecomment-1275500147 @qingwei91 Thanks for the updating, I'll review this PR in a few days. > I didn't implement additional operators like IN and BETWEEN because I am quite busy of late. Given they c

[GitHub] [flink-ml] weibozhao commented on a diff in pull request #156: [FLINK-29323] Refine Transformer for VectorAssembler

2022-10-11 Thread GitBox
weibozhao commented on code in PR #156: URL: https://github.com/apache/flink-ml/pull/156#discussion_r992921852 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssembler.java: ## @@ -47,10 +47,15 @@ /** * A Transformer which combines a given l

[jira] [Commented] (FLINK-29557) The SinkOperator's OutputFormat function is not recognized

2022-10-11 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616135#comment-17616135 ] Aitozi commented on FLINK-29557: Anyone can help confirm this issue ? > The SinkOperat

[jira] [Updated] (FLINK-29590) Fix literal issue for HiveDialect

2022-10-11 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-29590: - Summary: Fix literal issue for HiveDialect (was: Fix constant fold issue for HiveDialect) > Fix litera

[jira] [Updated] (FLINK-29590) Fix constant fold issue for HiveDialect

2022-10-11 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-29590: - Description: in FLINK-26474, we try to fold constant, but it may bring a issue that the folded constant

[jira] [Updated] (FLINK-29590) Fix literal issue in HiveDialect

2022-10-11 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-29590: - Summary: Fix literal issue in HiveDialect (was: Fix literal issue for HiveDialect) > Fix literal issue

[jira] [Created] (FLINK-29590) Fix constant fold issue for HiveDialect

2022-10-11 Thread luoyuxia (Jira)
luoyuxia created FLINK-29590: Summary: Fix constant fold issue for HiveDialect Key: FLINK-29590 URL: https://issues.apache.org/jira/browse/FLINK-29590 Project: Flink Issue Type: Bug Com

[GitHub] [flink] czy006 commented on pull request #21012: [FLINK-29543] Jar Run Rest Handler Support Flink Configuration

2022-10-11 Thread GitBox
czy006 commented on PR #21012: URL: https://github.com/apache/flink/pull/21012#issuecomment-1275495467 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [flink] zoucao commented on pull request #19250: [FLINK-26726][connector][hive]Hive enumerators do not assign splits to unregistered (failed) readers.

2022-10-11 Thread GitBox
zoucao commented on PR #19250: URL: https://github.com/apache/flink/pull/19250#issuecomment-1275491596 > @zoucao Thanks for updating. Could you please open the same pr to release-1.16/1.15/1.14? @wuchong Could you please help merge? Yes, I will do the bp soon. -- This is an automat

[GitHub] [flink] RocMarshal commented on a diff in pull request #20989: [FLINK-29548][flink-test-utils] Remove deprecated class files of the 'flink-test-utils' module.

2022-10-11 Thread GitBox
RocMarshal commented on code in PR #20989: URL: https://github.com/apache/flink/pull/20989#discussion_r992912891 ## flink-table/flink-table-api-scala/src/main/scala/org/apache/flink/table/api/ImplicitExpressionConversions.scala: ## @@ -496,16 +496,16 @@ trait ImplicitExpressionC

[GitHub] [flink] RocMarshal commented on a diff in pull request #20989: [FLINK-29548][flink-test-utils] Remove deprecated class files of the 'flink-test-utils' module.

2022-10-11 Thread GitBox
RocMarshal commented on code in PR #20989: URL: https://github.com/apache/flink/pull/20989#discussion_r992911391 ## flink-table/flink-table-api-scala/src/main/scala/org/apache/flink/table/api/ImplicitExpressionConversions.scala: ## @@ -496,16 +496,16 @@ trait ImplicitExpressionC

[GitHub] [flink-ml] yunfengzhou-hub commented on a diff in pull request #156: [FLINK-29323] Refine Transformer for VectorAssembler

2022-10-11 Thread GitBox
yunfengzhou-hub commented on code in PR #156: URL: https://github.com/apache/flink-ml/pull/156#discussion_r992901815 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorassembler/VectorAssemblerParams.java: ## @@ -21,11 +21,29 @@ import org.apache.flink.ml.common.pa

[jira] [Updated] (FLINK-26726) Remove the unregistered task from readersAwaitingSplit

2022-10-11 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-26726: - Issue Type: Bug (was: Improvement) > Remove the unregistered task from readersAwaitingSplit >

[GitHub] [flink] luoyuxia commented on pull request #20855: [FLINK-29337][hive] Fix fail to query non-hive table in Hive dialect

2022-10-11 Thread GitBox
luoyuxia commented on PR #20855: URL: https://github.com/apache/flink/pull/20855#issuecomment-1275467486 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] luoyuxia closed pull request #20883: [WIP] validate for https://github.com/apache/flink/pull/20882

2022-10-11 Thread GitBox
luoyuxia closed pull request #20883: [WIP] validate for https://github.com/apache/flink/pull/20882 URL: https://github.com/apache/flink/pull/20883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (FLINK-29585) Migrate TableSchema to Schema for Hive connector

2022-10-11 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616111#comment-17616111 ] luoyuxia commented on FLINK-29585: -- Sure.  [~jark] Could you please assign this ticket

[jira] [Closed] (FLINK-29495) PulsarSinkE2ECase hang

2022-10-11 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen closed FLINK-29495. - Fix Version/s: 1.16.0 1.17.0 1.15.3 Assignee: Martijn Viss

[GitHub] [flink] Cyberness commented on pull request #20257: [FLINK-24943][Connectors / Kinesis] Explicitly create KryoSerializer for SequenceNumber class in Kinesis Consumer

2022-10-11 Thread GitBox
Cyberness commented on PR #20257: URL: https://github.com/apache/flink/pull/20257#issuecomment-1275379856 > The code changes look good. Recognise that we specify a KryoSerializer instead of making the SequenceNumber a POJO to maintain backwards compatibility. Given that we are changing the

[GitHub] [flink] hlteoh37 commented on pull request #20257: [FLINK-24943][Connectors / Kinesis] Explicitly create KryoSerializer for SequenceNumber class in Kinesis Consumer

2022-10-11 Thread GitBox
hlteoh37 commented on PR #20257: URL: https://github.com/apache/flink/pull/20257#issuecomment-1275342620 The code changes look good. Recognise that we specify a KryoSerializer instead of making the SequenceNumber a POJO to maintain backwards compatibility. Given that we are changing the sta

[GitHub] [flink] snuyanzin commented on pull request #20410: [FLINK-28768][tests][testinfrastructure] Update junit to 5.9.1

2022-10-11 Thread GitBox
snuyanzin commented on PR #20410: URL: https://github.com/apache/flink/pull/20410#issuecomment-1275339899 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] snuyanzin commented on a diff in pull request #20850: [FLINK-20873][Table SQl/API] Update to calcite 1.27

2022-10-11 Thread GitBox
snuyanzin commented on code in PR #20850: URL: https://github.com/apache/flink/pull/20850#discussion_r992793159 ## flink-table/flink-sql-parser/pom.xml: ## @@ -193,6 +204,10 @@ under the License. org.apiguardian Review Comment: I've ju

[GitHub] [flink] snuyanzin commented on a diff in pull request #20850: [FLINK-20873][Table SQl/API] Update to calcite 1.27

2022-10-11 Thread GitBox
snuyanzin commented on code in PR #20850: URL: https://github.com/apache/flink/pull/20850#discussion_r992793159 ## flink-table/flink-sql-parser/pom.xml: ## @@ -193,6 +204,10 @@ under the License. org.apiguardian Review Comment: I've ju

[GitHub] [flink] snuyanzin commented on a diff in pull request #20850: [FLINK-20873][Table SQl/API] Update to calcite 1.27

2022-10-11 Thread GitBox
snuyanzin commented on code in PR #20850: URL: https://github.com/apache/flink/pull/20850#discussion_r992790858 ## flink-table/flink-sql-parser-hive/pom.xml: ## @@ -56,6 +56,12 @@ under the License. guava ${guava.version}

[jira] [Updated] (FLINK-29589) Data Loss in Sink GlobalCommitter during Task Manager recovery

2022-10-11 Thread Krzysztof Chmielewski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krzysztof Chmielewski updated FLINK-29589: -- Description: Flink's Sink architecture with global committer seems to be vulne

[jira] [Updated] (FLINK-29589) Data Loss in Sink GlobalCommitter during Task Manager recovery

2022-10-11 Thread Krzysztof Chmielewski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krzysztof Chmielewski updated FLINK-29589: -- Description: Flink's Sink architecture with global committer seems to be vulne

[jira] [Updated] (FLINK-29589) Data Loss in Sink GlobalCommitter during Task Manager recovery

2022-10-11 Thread Krzysztof Chmielewski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krzysztof Chmielewski updated FLINK-29589: -- Description: Flink's Sink architecture with global committer seems to be vulne

[jira] [Commented] (FLINK-29589) Data Loss in Sink GlobalCommitter during Task Manager recovery

2022-10-11 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616076#comment-17616076 ] Martijn Visser commented on FLINK-29589: If there's indeed a reproducible case w

[jira] [Updated] (FLINK-29589) Data Loss in Sink GlobalCommitter during Task Manager recovery

2022-10-11 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-29589: --- Priority: Blocker (was: Major) > Data Loss in Sink GlobalCommitter during Task Manager reco

[jira] [Updated] (FLINK-29589) Data Loss in Sink GlobalCommitter during Task Manager recovery

2022-10-11 Thread Krzysztof Chmielewski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krzysztof Chmielewski updated FLINK-29589: -- Description: Flink's Sink architecture with global committer seems to be vulne

[jira] [Updated] (FLINK-29589) Data Loss in Sink GlobalCommitter during Task Manager recovery

2022-10-11 Thread Krzysztof Chmielewski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krzysztof Chmielewski updated FLINK-29589: -- Description: Flink's Sink architecture with global committer seems to be vulne

[jira] [Updated] (FLINK-29589) Data Loss in Sink GlobalCommitter during Task Manager recovery

2022-10-11 Thread Krzysztof Chmielewski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krzysztof Chmielewski updated FLINK-29589: -- Description: Flink's Sink architecture with global committer seems to be vulne

[jira] [Created] (FLINK-29589) Data Loss in Sink GlobalCommitter during Task Manager recovery

2022-10-11 Thread Krzysztof Chmielewski (Jira)
Krzysztof Chmielewski created FLINK-29589: - Summary: Data Loss in Sink GlobalCommitter during Task Manager recovery Key: FLINK-29589 URL: https://issues.apache.org/jira/browse/FLINK-29589 Proj

[jira] [Updated] (FLINK-29589) Data Loss in Sink GlobalCommitter during Task Manager recovery

2022-10-11 Thread Krzysztof Chmielewski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krzysztof Chmielewski updated FLINK-29589: -- Description: Flink's Sink's architecture with global committer seems to be vul

[GitHub] [flink] hlteoh37 commented on pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2022-10-11 Thread GitBox
hlteoh37 commented on PR #14737: URL: https://github.com/apache/flink/pull/14737#issuecomment-1275238559 @MartijnVisser @dannycranmer Have picked it up here: https://issues.apache.org/jira/browse/FLINK-29574 -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [flink] kristoffSC commented on pull request #21025: [DRAFT] Flink 1.14 data loss sink global committer

2022-10-11 Thread GitBox
kristoffSC commented on PR #21025: URL: https://github.com/apache/flink/pull/21025#issuecomment-1275215995 wrong target branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [flink] kristoffSC closed pull request #21025: [DRAFT] Flink 1.14 data loss sink global committer

2022-10-11 Thread GitBox
kristoffSC closed pull request #21025: [DRAFT] Flink 1.14 data loss sink global committer URL: https://github.com/apache/flink/pull/21025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] kristoffSC opened a new pull request, #21025: [DRAFT] Flink 1.14 data loss sink global committer

2022-10-11 Thread GitBox
kristoffSC opened a new pull request, #21025: URL: https://github.com/apache/flink/pull/21025 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[GitHub] [flink] qingwei91 commented on pull request #20140: [Flink 16024][Connector][JDBC] Support FilterPushdown

2022-10-11 Thread GitBox
qingwei91 commented on PR #20140: URL: https://github.com/apache/flink/pull/20140#issuecomment-1275195142 Hi @libenchao I finally got around and implemented your suggestion. Do you mind to take a look again? I didn't implement additional operators like IN and BETWEEN because I am qui

[jira] [Commented] (FLINK-29588) Add Flink Version and Application Version to Savepoint properties

2022-10-11 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616044#comment-17616044 ] Gyula Fora commented on FLINK-29588: We don't really have a concept of application v

[jira] [Commented] (FLINK-29588) Add Flink Version and Application Version to Savepoint properties

2022-10-11 Thread Clara Xiong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616041#comment-17616041 ] Clara Xiong commented on FLINK-29588: - appVersion is the application version of the

[GitHub] [flink] XComp commented on a diff in pull request #21019: [FLINK-29576][runtime] Adds concurrency support to JobVertex#addOperatorCoordinator

2022-10-11 Thread GitBox
XComp commented on code in PR #21019: URL: https://github.com/apache/flink/pull/21019#discussion_r992679151 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java: ## @@ -841,6 +842,12 @@ private StreamConfig createJobVertex(In

[jira] [Updated] (FLINK-29588) Add Flink Version and Application Version to Savepoint properties

2022-10-11 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-29588: --- Affects Version/s: (was: kubernetes-operator-1.2.0) > Add Flink Version and Application Version

[jira] [Commented] (FLINK-29588) Add Flink Version and Application Version to Savepoint properties

2022-10-11 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616020#comment-17616020 ] Gyula Fora commented on FLINK-29588: Since savepoints are compatible across version

[jira] [Commented] (FLINK-29588) Add Flink Version and Application Version to Savepoint properties

2022-10-11 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616018#comment-17616018 ] Gyula Fora commented on FLINK-29588: What do you mean by appVersion here? > Add Fli

[GitHub] [flink] flinkbot commented on pull request #21024: Unpin cloudpickle

2022-10-11 Thread GitBox
flinkbot commented on PR #21024: URL: https://github.com/apache/flink/pull/21024#issuecomment-1275081315 ## CI report: * 2196926d20b5bd63f416355928bc4c76d0bfa205 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-29495) PulsarSinkE2ECase hang

2022-10-11 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616011#comment-17616011 ] Martijn Visser commented on FLINK-29495: Tests alsof disabled for/via: release-

[GitHub] [flink] MartijnVisser merged pull request #21017: [FLINK-29495][BP 1.15][Connector/Pulsar] Refactor Pulsar tests for disabling tests on Java 11

2022-10-11 Thread GitBox
MartijnVisser merged PR #21017: URL: https://github.com/apache/flink/pull/21017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

[GitHub] [flink] MartijnVisser merged pull request #21018: [FLINK-29495][BP 1.16][Connector/Pulsar] Refactor Pulsar tests for disabling tests on Java 11

2022-10-11 Thread GitBox
MartijnVisser merged PR #21018: URL: https://github.com/apache/flink/pull/21018 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

[GitHub] [flink] kosigz opened a new pull request, #21024: Unpin cloudpickle

2022-10-11 Thread GitBox
kosigz opened a new pull request, #21024: URL: https://github.com/apache/flink/pull/21024 The current version of cloudpickle has a bug in that locally / interactively defined classes with `@property` cannot be serialized. This makes it more difficult for MLP team to demo E2E flows. htt

[GitHub] [flink] leletan commented on pull request #20852: [FLINK-27101][checkpointing][rest] Add restful API to trigger checkpoints

2022-10-11 Thread GitBox
leletan commented on PR #20852: URL: https://github.com/apache/flink/pull/20852#issuecomment-1275067537 @zentol I see I have a lot of style issues and thanks for pointing them out. I am wondering if you have a doc / pointer for those style rules so I won't make those mistakes in the future.

[GitHub] [flink] leletan commented on a diff in pull request #20852: [FLINK-27101][checkpointing][rest] Add restful API to trigger checkpoints

2022-10-11 Thread GitBox
leletan commented on code in PR #20852: URL: https://github.com/apache/flink/pull/20852#discussion_r992626495 ## flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/checkpoints/CheckpointTriggerHandlersTest.java: ## @@ -0,0 +1,349 @@ +/* + * Licensed to the Apa

[GitHub] [flink] leletan commented on a diff in pull request #20852: [FLINK-27101][checkpointing][rest] Add restful API to trigger checkpoints

2022-10-11 Thread GitBox
leletan commented on code in PR #20852: URL: https://github.com/apache/flink/pull/20852#discussion_r992624496 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointTriggerStatusHeaders.java: ## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache

[jira] [Created] (FLINK-29588) Add Flink Version and Application Version to Savepoint properties

2022-10-11 Thread Clara Xiong (Jira)
Clara Xiong created FLINK-29588: --- Summary: Add Flink Version and Application Version to Savepoint properties Key: FLINK-29588 URL: https://issues.apache.org/jira/browse/FLINK-29588 Project: Flink

[jira] [Comment Edited] (FLINK-22243) Reactive Mode parallelism changes are not shown in the job graph visualization in the UI

2022-10-11 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17613317#comment-17613317 ] Dawid Wysakowicz edited comment on FLINK-22243 at 10/11/22 5:19 PM: --

[GitHub] [flink] dawidwys merged pull request #21021: [FLINK-22243] Remove adaptive scheduler Web UI limitation from docs

2022-10-11 Thread GitBox
dawidwys merged PR #21021: URL: https://github.com/apache/flink/pull/21021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[GitHub] [flink] snuyanzin commented on a diff in pull request #20850: [FLINK-20873][Table SQl/API] Update to calcite 1.27

2022-10-11 Thread GitBox
snuyanzin commented on code in PR #20850: URL: https://github.com/apache/flink/pull/20850#discussion_r992562130 ## flink-table/flink-table-planner/pom.xml: ## @@ -127,22 +127,22 @@ under the License. ${calcite.version}

[GitHub] [flink] snuyanzin commented on a diff in pull request #20850: [FLINK-20873][Table SQl/API] Update to calcite 1.27

2022-10-11 Thread GitBox
snuyanzin commented on code in PR #20850: URL: https://github.com/apache/flink/pull/20850#discussion_r992562130 ## flink-table/flink-table-planner/pom.xml: ## @@ -127,22 +127,22 @@ under the License. ${calcite.version}

  1   2   3   4   >