[GitHub] [flink] cuibo01 commented on pull request #20910: [FLINK-29435]SecurityConfiguration supports dynamic configuration

2022-10-22 Thread GitBox
cuibo01 commented on PR #20910: URL: https://github.com/apache/flink/pull/20910#issuecomment-1287993948 @xintongsong Thanks for your review :), and i have updated the pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [flink] zoltar9264 commented on pull request #20965: [FLINK-29244][state/changelog] Add metric lastMaterializationDuration…

2022-10-22 Thread GitBox
zoltar9264 commented on PR #20965: URL: https://github.com/apache/flink/pull/20965#issuecomment-1287992922 Thanks @fredia , I think your opinion makes sense, I will update the pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [flink] snuyanzin commented on pull request #19870: [FLINK-27882][tests][table] Migrate flink-scala to JUnit5

2022-10-22 Thread GitBox
snuyanzin commented on PR #19870: URL: https://github.com/apache/flink/pull/19870#issuecomment-1287866219 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[jira] [Commented] (FLINK-25993) Option to disable Kryo.setRegistrationRequired(false)

2022-10-22 Thread Shane Bishop (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622644#comment-17622644 ] Shane Bishop commented on FLINK-25993: -- Hi [~galenwarren], I at least would certain

[jira] [Commented] (FLINK-29677) DROP CATALOG statement does not reset current catalog

2022-10-22 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622637#comment-17622637 ] Shengkai Fang commented on FLINK-29677: --- Merged into the master: 271ef7b7dfac195b4

[GitHub] [flink] fsk119 closed pull request #21097: [FLINK-29677] DROP CATALOG statement does not reset current catalog

2022-10-22 Thread GitBox
fsk119 closed pull request #21097: [FLINK-29677] DROP CATALOG statement does not reset current catalog URL: https://github.com/apache/flink/pull/21097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] flinkbot commented on pull request #21131: [FLINK-29730][checkpoint] Simplify the ChannelStateWriteRequestDispatcherImpl due to not supported concurrent unaligned checkpoint

2022-10-22 Thread GitBox
flinkbot commented on PR #21131: URL: https://github.com/apache/flink/pull/21131#issuecomment-1287808423 ## CI report: * 347b50aa5e162df1e244a4ecd4a9a35be7078879 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-29730) Simplify the ChannelStateWriteRequestDispatcherImpl due to not supported concurrent unaligned checkpoint

2022-10-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29730: --- Labels: pull-request-available (was: ) > Simplify the ChannelStateWriteRequestDispatcherImp

[GitHub] [flink] 1996fanrui opened a new pull request, #21131: [FLINK-29730][checkpoint] Simplify the ChannelStateWriteRequestDispatcherImpl due to not supported concurrent unaligned checkpoint

2022-10-22 Thread GitBox
1996fanrui opened a new pull request, #21131: URL: https://github.com/apache/flink/pull/21131 ## What is the purpose of the change Simplify the ChannelStateWriteRequestDispatcherImpl due to not supported concurrent unaligned checkpoint ## Brief change log The `Map write

[jira] [Created] (FLINK-29730) Simplify the ChannelStateWriteRequestDispatcherImpl due to not supported concurrent unaligned checkpoint

2022-10-22 Thread fanrui (Jira)
fanrui created FLINK-29730: -- Summary: Simplify the ChannelStateWriteRequestDispatcherImpl due to not supported concurrent unaligned checkpoint Key: FLINK-29730 URL: https://issues.apache.org/jira/browse/FLINK-29730

[GitHub] [flink] cuibo01 commented on pull request #20910: [FLINK-29435]SecurityConfiguration supports dynamic configuration

2022-10-22 Thread GitBox
cuibo01 commented on PR #20910: URL: https://github.com/apache/flink/pull/20910#issuecomment-1287792113 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] snuyanzin commented on pull request #19870: [FLINK-27882][tests][table] Migrate flink-scala to JUnit5

2022-10-22 Thread GitBox
snuyanzin commented on PR #19870: URL: https://github.com/apache/flink/pull/19870#issuecomment-1287784708 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [flink-kubernetes-operator] bgeng777 commented on pull request #408: Added improvements on the flink python example Dockerfile

2022-10-22 Thread GitBox
bgeng777 commented on PR #408: URL: https://github.com/apache/flink-kubernetes-operator/pull/408#issuecomment-1287770774 Thanks for the pr. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (FLINK-29529) Update flink version in flink-python-example of flink k8s operator

2022-10-22 Thread Sriram Ganesh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622610#comment-17622610 ] Sriram Ganesh commented on FLINK-29529: --- [~bgeng777]/[~gyfora] - https://github.c

[GitHub] [flink-kubernetes-operator] rgsriram opened a new pull request, #408: Added improvements on the flink python example Dockerfile

2022-10-22 Thread GitBox
rgsriram opened a new pull request, #408: URL: https://github.com/apache/flink-kubernetes-operator/pull/408 ## What is the purpose of the change *Added improvements in the dockerfile for the python example. This change decouples the tight binding with flink minor version in the docker

[GitHub] [flink] Myasuka commented on a diff in pull request #20689: [FLINK-28984][runtime] Fix the problem that FsCheckpointStateOutputStream is not being released normally

2022-10-22 Thread GitBox
Myasuka commented on code in PR #20689: URL: https://github.com/apache/flink/pull/20689#discussion_r1002442542 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsCheckpointStreamFactory.java: ## @@ -454,6 +460,14 @@ private void createStream() throws IOEx

[GitHub] [flink] flinkbot commented on pull request #21130: [FLINK-29729][format] including properties from flink-conf.yaml during creating ParquetReader

2022-10-22 Thread GitBox
flinkbot commented on PR #21130: URL: https://github.com/apache/flink/pull/21130#issuecomment-1287707921 ## CI report: * 99cf90c6f21bec5a717dc874464959fe974a7d66 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-29729) Support including the configured properties from flink-conf.yaml during create ParquetReader

2022-10-22 Thread Zhiping Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhiping Wu updated FLINK-29729: --- Description: Hi, I'm thinking if we can include the configured properties from flink-conf.yaml duri

[jira] [Updated] (FLINK-29729) Support including the configured properties from flink-conf.yaml during create ParquetReader

2022-10-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29729: --- Labels: pull-request-available (was: ) > Support including the configured properties from f

[GitHub] [flink] stayrascal opened a new pull request, #21130: [FLINK-29729][format] including properties from flink-conf.yaml during creating ParquetReader

2022-10-22 Thread GitBox
stayrascal opened a new pull request, #21130: URL: https://github.com/apache/flink/pull/21130 …g create ParquetReader ## What is the purpose of the change This pull request is trying to including the properties configured in `flink-conf.yaml` during create ParquetReader, wh

[jira] [Created] (FLINK-29729) Support including the configured properties from flink-conf.yaml during create ParquetReader

2022-10-22 Thread Zhiping Wu (Jira)
Zhiping Wu created FLINK-29729: -- Summary: Support including the configured properties from flink-conf.yaml during create ParquetReader Key: FLINK-29729 URL: https://issues.apache.org/jira/browse/FLINK-29729

[GitHub] [flink] snuyanzin commented on pull request #19870: [FLINK-27882][tests][table] Migrate flink-scala to JUnit5

2022-10-22 Thread GitBox
snuyanzin commented on PR #19870: URL: https://github.com/apache/flink/pull/19870#issuecomment-1287695686 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [flink] snuyanzin commented on pull request #19870: [FLINK-27882][tests][table] Migrate flink-scala to JUnit5

2022-10-22 Thread GitBox
snuyanzin commented on PR #19870: URL: https://github.com/apache/flink/pull/19870#issuecomment-1287673623 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[jira] [Updated] (FLINK-29713) Kubernetes operator should restart failed jobs

2022-10-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29713: --- Labels: pull-request-available (was: ) > Kubernetes operator should restart failed jobs > -

[GitHub] [flink-kubernetes-operator] pvary opened a new pull request, #407: [FLINK-29713] Kubernetes operator should restart failed jobs

2022-10-22 Thread GitBox
pvary opened a new pull request, #407: URL: https://github.com/apache/flink-kubernetes-operator/pull/407 ## What is the purpose of the change It would be good to have the possibility to restart the Flink Application if it goes to `FAILED` state. This could be used to restart, and r

[GitHub] [flink-connector-dynamodb] nirtsruya commented on a diff in pull request #1: [FLINK-24229][Connectors][DynamoDB] - Add AWS DynamoDB connector

2022-10-22 Thread GitBox
nirtsruya commented on code in PR #1: URL: https://github.com/apache/flink-connector-dynamodb/pull/1#discussion_r1002392190 ## flink-connector-dynamodb/src/main/java/org/apache/flink/streaming/connectors/dynamodb/sink/DynamoDbWriteRequest.java: ## @@ -0,0 +1,97 @@ +/* + * Licen

[GitHub] [flink-connector-dynamodb] nirtsruya commented on a diff in pull request #1: [FLINK-24229][Connectors][DynamoDB] - Add AWS DynamoDB connector

2022-10-22 Thread GitBox
nirtsruya commented on code in PR #1: URL: https://github.com/apache/flink-connector-dynamodb/pull/1#discussion_r1002387162 ## flink-connector-dynamodb/src/main/java/org/apache/flink/streaming/connectors/dynamodb/sink/DynamoDbWriteRequestType.java: ## @@ -0,0 +1,35 @@ +/* + * L