[jira] [Commented] (FLINK-29711) Topic notification not present in metadata after 60000 ms.

2022-10-24 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623589#comment-17623589 ] Mason Chen commented on FLINK-29711: Hi, I did a quick pass over the source code. Ca

[jira] [Commented] (FLINK-16073) Translate "State & Fault Tolerance" pages into Chinese

2022-10-24 Thread fuping.wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623587#comment-17623587 ] fuping.wang commented on FLINK-16073: - Hi [~knaufk] , I want to fix it, please assig

[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #330: [FLINK-29736] Abstract a table interface for both data and metadata tables

2022-10-24 Thread GitBox
LadyForest commented on code in PR #330: URL: https://github.com/apache/flink-table-store/pull/330#discussion_r1004061771 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/catalog/Catalog.java: ## @@ -116,7 +117,7 @@ void dropDatabase(String name, boolean

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #21132: [FLINK-29134][metrics] Do not repeatedly add useless metric updating tasks to avoid wasting resources

2022-10-24 Thread GitBox
TanYuxin-tyx commented on code in PR #21132: URL: https://github.com/apache/flink/pull/21132#discussion_r1004059827 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricFetcherImpl.java: ## @@ -148,102 +156,106 @@ private void fetchMetrics()

[GitHub] [flink] Shenjiaqi commented on pull request #20860: [FLINK-29347] [runtime] Fix ByteStreamStateHandle#read return -1 when read count is 0

2022-10-24 Thread GitBox
Shenjiaqi commented on PR #20860: URL: https://github.com/apache/flink/pull/20860#issuecomment-1290049377 > * @flinkbot run azure @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] Myasuka commented on pull request #20965: [FLINK-29244][state/changelog] Add metric lastMaterializationDuration…

2022-10-24 Thread GitBox
Myasuka commented on PR #20965: URL: https://github.com/apache/flink/pull/20965#issuecomment-1290046759 It is really strange as the broken CI should be resolved in FLINK-29315 . @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the messag

[jira] [Commented] (FLINK-29315) HDFSTest#testBlobServerRecovery fails on CI

2022-10-24 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623583#comment-17623583 ] Yun Tang commented on FLINK-29315: -- It looks like the problem happened again https://d

[GitHub] [flink] flinkbot commented on pull request #21146: [FLINK-29750][connector-jdbc] Improve PostgresCatalog#listTables() by reusing resources

2022-10-24 Thread GitBox
flinkbot commented on PR #21146: URL: https://github.com/apache/flink/pull/21146#issuecomment-1290043531 ## CI report: * 57b8bd46b9f2236d8b7f3598577f090c7127db24 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] liuml07 commented on pull request #21146: [FLINK-29750][connector-jdbc] Improve PostgresCatalog#listTables() by…

2022-10-24 Thread GitBox
liuml07 commented on PR #21146: URL: https://github.com/apache/flink/pull/21146#issuecomment-1290039818 CC @RocMarshal @twalthr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[jira] [Updated] (FLINK-29750) Improve PostgresCatalog#listTables() by reusing resources

2022-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29750: --- Labels: pull-request-available (was: ) > Improve PostgresCatalog#listTables() by reusing re

[GitHub] [flink] liuml07 opened a new pull request, #21146: [FLINK-29750][connector-jdbc] Improve PostgresCatalog#listTables() by…

2022-10-24 Thread GitBox
liuml07 opened a new pull request, #21146: URL: https://github.com/apache/flink/pull/21146 … reusing resources ## What is the purpose of the change Currently the PostgresCatalog#listTables() creates a new connection and prepared statement for every schema and table when

[jira] [Created] (FLINK-29751) Migrate SQL Client Local Mode to use sql gateway

2022-10-24 Thread yuzelin (Jira)
yuzelin created FLINK-29751: --- Summary: Migrate SQL Client Local Mode to use sql gateway Key: FLINK-29751 URL: https://issues.apache.org/jira/browse/FLINK-29751 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-29750) Improve PostgresCatalog#listTables() by reusing resources

2022-10-24 Thread Mingliang Liu (Jira)
Mingliang Liu created FLINK-29750: - Summary: Improve PostgresCatalog#listTables() by reusing resources Key: FLINK-29750 URL: https://issues.apache.org/jira/browse/FLINK-29750 Project: Flink I

[GitHub] [flink] flinkbot commented on pull request #21145: [FLINK-29749][client] flink info commands support dynamic properties.

2022-10-24 Thread GitBox
flinkbot commented on PR #21145: URL: https://github.com/apache/flink/pull/21145#issuecomment-1290034018 ## CI report: * ceaf394f70ef7d44529b24d684c0e7ef409d53b9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] jiangjiguang commented on pull request #20830: [FLINK-29271]Change to byte array from bytebuffer to improve performance and compatible direct byte buffers

2022-10-24 Thread GitBox
jiangjiguang commented on PR #20830: URL: https://github.com/apache/flink/pull/20830#issuecomment-1290030142 @luoyuxia I have rebased the master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [flink-ml] yunfengzhou-hub commented on a diff in pull request #162: [FLINK-29593] Add QuantileSummary to help calculate approximate quant…

2022-10-24 Thread GitBox
yunfengzhou-hub commented on code in PR #162: URL: https://github.com/apache/flink-ml/pull/162#discussion_r1003968316 ## flink-ml-core/src/main/java/org/apache/flink/ml/util/QuantileSummary.java: ## @@ -0,0 +1,391 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Updated] (FLINK-29749) flink info command support dynamic properties

2022-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29749: --- Labels: pull-request-available (was: ) > flink info command support dynamic properties > --

[jira] [Updated] (FLINK-29677) Prevent dropping the current catalog

2022-10-24 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-29677: - Fix Version/s: 1.17.0 1.16.1 > Prevent dropping the current catalog > ---

[GitHub] [flink-ml] yunfengzhou-hub commented on a diff in pull request #162: [FLINK-29593] Add QuantileSummary to help calculate approximate quant…

2022-10-24 Thread GitBox
yunfengzhou-hub commented on code in PR #162: URL: https://github.com/apache/flink-ml/pull/162#discussion_r1003965917 ## flink-ml-core/src/main/java/org/apache/flink/ml/util/QuantileSummary.java: ## @@ -0,0 +1,391 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [flink] jiangjiguang commented on a diff in pull request #20830: [FLINK-29271]Change to byte array from bytebuffer to improve performance and compatible direct byte buffers

2022-10-24 Thread GitBox
jiangjiguang commented on code in PR #20830: URL: https://github.com/apache/flink/pull/20830#discussion_r1004038649 ## flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/vector/reader/RunLengthDecoder.java: ## @@ -265,8 +265,16 @@ void readNextGroup() {

[GitHub] [flink] liuyongvs opened a new pull request, #21145: [FLINK-29749][client] flink info commands support dynamic properties.

2022-10-24 Thread GitBox
liuyongvs opened a new pull request, #21145: URL: https://github.com/apache/flink/pull/21145 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[jira] [Created] (FLINK-29749) flink info command support dynamic properties

2022-10-24 Thread jackylau (Jira)
jackylau created FLINK-29749: Summary: flink info command support dynamic properties Key: FLINK-29749 URL: https://issues.apache.org/jira/browse/FLINK-29749 Project: Flink Issue Type: Bug Aff

[GitHub] [flink] flinkbot commented on pull request #21144: [FLINK-29747] refactor: module-based app to standalone components

2022-10-24 Thread GitBox
flinkbot commented on PR #21144: URL: https://github.com/apache/flink/pull/21144#issuecomment-1290004035 ## CI report: * aa898fd31f50a69d8bad471df434fb02ab0f28fa UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-29711) Topic notification not present in metadata after 60000 ms.

2022-10-24 Thread Durgesh Mishra (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623561#comment-17623561 ] Durgesh Mishra commented on FLINK-29711: [~martijnvisser]  and [~mason6345]  Can

[jira] [Updated] (FLINK-29747) [UI] Refactor runtime web from module-based to standalone components

2022-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29747: --- Labels: pull-request-available (was: ) > [UI] Refactor runtime web from module-based to sta

[GitHub] [flink] yangjunhan opened a new pull request, #21144: [FLINK-29747] refactor: module-based app to standalone components

2022-10-24 Thread GitBox
yangjunhan opened a new pull request, #21144: URL: https://github.com/apache/flink/pull/21144 ## What is the purpose of the change FLINK-29747 ## Brief change log Refactor module-based app to standalone components with lazy loading. ## Verifying this ch

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #328: [FLINK-29714] Merge TableWrite and TableCompact into one interface

2022-10-24 Thread GitBox
JingsongLi commented on code in PR #328: URL: https://github.com/apache/flink-table-store/pull/328#discussion_r1004006577 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/MergeTreeWriter.java: ## @@ -137,6 +137,11 @@ public void write(KeyValue

[GitHub] [flink] xintongsong commented on pull request #20910: [FLINK-29435]SecurityConfiguration supports dynamic configuration

2022-10-24 Thread GitBox
xintongsong commented on PR #20910: URL: https://github.com/apache/flink/pull/20910#issuecomment-1289993309 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [flink] xintongsong commented on a diff in pull request #21132: [FLINK-29134][metrics] Do not repeatedly add useless metric updating tasks to avoid wasting resources

2022-10-24 Thread GitBox
xintongsong commented on code in PR #21132: URL: https://github.com/apache/flink/pull/21132#discussion_r1004004779 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricFetcherImpl.java: ## @@ -148,102 +156,106 @@ private void fetchMetrics() {

[jira] [Assigned] (FLINK-29609) Clean up jobmanager deployment on suspend after recording savepoint info

2022-10-24 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-29609: -- Assignee: Sriram Ganesh > Clean up jobmanager deployment on suspend after recording savepoint

[jira] [Commented] (FLINK-29609) Clean up jobmanager deployment on suspend after recording savepoint info

2022-10-24 Thread Sriram Ganesh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623554#comment-17623554 ] Sriram Ganesh commented on FLINK-29609: --- [~gyfora] - Please assign this to me. >

[GitHub] [flink] TanYuxin-tyx commented on pull request #21132: [FLINK-29134][metrics] Do not repeatedly add useless metric updating tasks to avoid wasting resources

2022-10-24 Thread GitBox
TanYuxin-tyx commented on PR #21132: URL: https://github.com/apache/flink/pull/21132#issuecomment-1289958870 @xintongsong @reswqa Thanks for reviewing the change. I have addressed the comments. Could you take a look again? -- This is an automated message from the Apache Git Service. To re

[GitHub] [flink] flinkbot commented on pull request #21143: [hotfix] Fix some typo in HiveOptions.

2022-10-24 Thread GitBox
flinkbot commented on PR #21143: URL: https://github.com/apache/flink/pull/21143#issuecomment-1289954801 ## CI report: * a1c7b649082670669fdb9af042171c744e48e8b8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #21132: [FLINK-29134][metrics] Do not repeatedly add useless metric updating tasks to avoid wasting resources

2022-10-24 Thread GitBox
TanYuxin-tyx commented on code in PR #21132: URL: https://github.com/apache/flink/pull/21132#discussion_r1003979797 ## flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricFetcherTest.java: ## @@ -263,7 +220,151 @@ public void testShortUpdateInt

[GitHub] [flink] reswqa commented on pull request #21143: [hotfix] Fix some typo in HiveOptions.

2022-10-24 Thread GitBox
reswqa commented on PR #21143: URL: https://github.com/apache/flink/pull/21143#issuecomment-1289950821 cc @luoyuxia -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [flink] reswqa opened a new pull request, #21143: [hotfix] Fix some typo in HiveOptions.

2022-10-24 Thread GitBox
reswqa opened a new pull request, #21143: URL: https://github.com/apache/flink/pull/21143 ## What is the purpose of the change *Fix some typo in HiveOptions.* ## Brief change log - *Using `withDescription` instead of `withDeprecatedKeys` for some config options.*

[GitHub] [flink] flinkbot commented on pull request #21142: [FLINK-29737][Table] Support DataGen on waveform function.

2022-10-24 Thread GitBox
flinkbot commented on PR #21142: URL: https://github.com/apache/flink/pull/21142#issuecomment-1289946308 ## CI report: * 000fb8030dc23459a3669eb62b54a58691641d06 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-29737) Support DataGen on waveform function

2022-10-24 Thread chenzihao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623546#comment-17623546 ] chenzihao commented on FLINK-29737: --- [~fsk119] Thanks for your reply. I have opened th

[jira] [Updated] (FLINK-29737) Support DataGen on waveform function

2022-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29737: --- Labels: pull-request-available (was: ) > Support DataGen on waveform function > ---

[GitHub] [flink] chenzihao5 opened a new pull request, #21142: [FLINK-29737][Table] Support DataGen on waveform function.

2022-10-24 Thread GitBox
chenzihao5 opened a new pull request, #21142: URL: https://github.com/apache/flink/pull/21142 ## What is the purpose of the change Support DataGen on waveform function. ## Brief change log - add three parameters: - waveform-function-enabled: Apply the wavefor

[jira] [Updated] (FLINK-29745) Split reader/writer factory for compaction in MergeTreeTest

2022-10-24 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-29745: - Fix Version/s: table-store-0.3.0 (was: shammon) > Split reader/writer fac

[jira] [Assigned] (FLINK-29745) Split reader/writer factory for compaction in MergeTreeTest

2022-10-24 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee reassigned FLINK-29745: Assignee: Shammon > Split reader/writer factory for compaction in MergeTreeTest > ---

[jira] [Closed] (FLINK-29745) Split reader/writer factory for compaction in MergeTreeTest

2022-10-24 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-29745. Fix Version/s: shammon Resolution: Fixed master: 537e8cf4b3733d93720381c65b30024870ece533

[GitHub] [flink-table-store] JingsongLi merged pull request #331: [FLINK-29745] Use independent reader/writer factory for compaction in MergeTreeTest

2022-10-24 Thread GitBox
JingsongLi merged PR #331: URL: https://github.com/apache/flink-table-store/pull/331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [flink] cuibo01 commented on pull request #20910: [FLINK-29435]SecurityConfiguration supports dynamic configuration

2022-10-24 Thread GitBox
cuibo01 commented on PR #20910: URL: https://github.com/apache/flink/pull/20910#issuecomment-1289929840 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Created] (FLINK-29748) Expose the optimize phase in the connector context

2022-10-24 Thread Aitozi (Jira)
Aitozi created FLINK-29748: -- Summary: Expose the optimize phase in the connector context Key: FLINK-29748 URL: https://issues.apache.org/jira/browse/FLINK-29748 Project: Flink Issue Type: Improvemen

[GitHub] [flink-ml] yunfengzhou-hub commented on a diff in pull request #160: [FLINK-29434] Add AlgoOperator for Splitter

2022-10-24 Thread GitBox
yunfengzhou-hub commented on code in PR #160: URL: https://github.com/apache/flink-ml/pull/160#discussion_r1003935113 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/randomsplitter/RandomSplitterParams.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software F

[GitHub] [flink] reswqa commented on a diff in pull request #21132: [FLINK-29134][metrics] Do not repeatedly add useless metric updating tasks to avoid wasting resources

2022-10-24 Thread GitBox
reswqa commented on code in PR #21132: URL: https://github.com/apache/flink/pull/21132#discussion_r1003944639 ## flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricFetcherTest.java: ## @@ -43,120 +43,77 @@ import org.junit.Test; Review Comme

[GitHub] [flink] flinkbot commented on pull request #21141: [FLINK-29742][sql-gateway] Support completing statement in SqlGatewayService.

2022-10-24 Thread GitBox
flinkbot commented on PR #21141: URL: https://github.com/apache/flink/pull/21141#issuecomment-1289913250 ## CI report: * 45299902af8abdcc2da247f590416cf657cb9988 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] yuzelin commented on pull request #21133: [FLINK-29732][sql-gateway] support configuring session with SQL statement.

2022-10-24 Thread GitBox
yuzelin commented on PR #21133: URL: https://github.com/apache/flink/pull/21133#issuecomment-1289910411 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-29742) Support completing statement in SqlGatewayService.

2022-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29742: --- Labels: pull-request-available (was: ) > Support completing statement in SqlGatewayService.

[GitHub] [flink] yuzelin opened a new pull request, #21141: [FLINK-29742] Support completing statement in SqlGatewayService.

2022-10-24 Thread GitBox
yuzelin opened a new pull request, #21141: URL: https://github.com/apache/flink/pull/21141 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on

[GitHub] [flink] luoyuxia commented on pull request #20830: [FLINK-29271]Change to byte array from bytebuffer to improve performance and compatible direct byte buffers

2022-10-24 Thread GitBox
luoyuxia commented on PR #20830: URL: https://github.com/apache/flink/pull/20830#issuecomment-1289904570 @jiangjiguang Also, could you please help rebase the master? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Created] (FLINK-29747) [UI] Refactor runtime web from module-based to standalone components

2022-10-24 Thread Junhan Yang (Jira)
Junhan Yang created FLINK-29747: --- Summary: [UI] Refactor runtime web from module-based to standalone components Key: FLINK-29747 URL: https://issues.apache.org/jira/browse/FLINK-29747 Project: Flink

[GitHub] [flink] luoyuxia commented on a diff in pull request #20830: [FLINK-29271]Change to byte array from bytebuffer to improve performance and compatible direct byte buffers

2022-10-24 Thread GitBox
luoyuxia commented on code in PR #20830: URL: https://github.com/apache/flink/pull/20830#discussion_r1003945031 ## flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/vector/reader/RunLengthDecoder.java: ## @@ -265,8 +265,16 @@ void readNextGroup() {

[GitHub] [flink] luoyuxia commented on a diff in pull request #20830: [FLINK-29271]Change to byte array from bytebuffer to improve performance and compatible direct byte buffers

2022-10-24 Thread GitBox
luoyuxia commented on code in PR #20830: URL: https://github.com/apache/flink/pull/20830#discussion_r1003942184 ## flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/vector/reader/RunLengthDecoder.java: ## @@ -265,8 +265,16 @@ void readNextGroup() {

[GitHub] [flink] reswqa commented on pull request #21137: [FLINK-29234][runtime] JobMasterServiceLeadershipRunner handle leader event in a separate executor to avoid dead lock

2022-10-24 Thread GitBox
reswqa commented on PR #21137: URL: https://github.com/apache/flink/pull/21137#issuecomment-1289898634 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[jira] [Updated] (FLINK-29745) Split reader/writer factory for compaction in MergeTreeTest

2022-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29745: --- Labels: pull-request-available (was: ) > Split reader/writer factory for compaction in Merg

[GitHub] [flink-table-store] zjureel opened a new pull request, #331: [FLINK-29745] Use independent reader/writer factory for compaction in MergeTreeTest

2022-10-24 Thread GitBox
zjureel opened a new pull request, #331: URL: https://github.com/apache/flink-table-store/pull/331 Use independent reader/writer factory for compaction in `MergeTreeTest`, otherwise, there may be concurrency problems in the test case -- This is an automated message from the Apache Git Ser

[GitHub] [flink] czy006 commented on a diff in pull request #21012: [FLINK-29543] Jar Run Rest Handler Support Flink Configuration

2022-10-24 Thread GitBox
czy006 commented on code in PR #21012: URL: https://github.com/apache/flink/pull/21012#discussion_r1003931113 ## flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarHandlerParameterTest.java: ## @@ -211,6 +218,37 @@ void testProvideJobId() throws Exce

[jira] [Closed] (FLINK-20732) Implement Pulsar Sink on extend Sink API (FLIP-191)

2022-10-24 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen closed FLINK-20732. - Resolution: Fixed > Implement Pulsar Sink on extend Sink API (FLIP-191) > --

[jira] [Updated] (FLINK-26027) Add FLIP-33 metrics to new PulsarSink

2022-10-24 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen updated FLINK-26027: -- Parent: (was: FLINK-20732) Issue Type: Improvement (was: Sub-task) > Add FLIP-33 metrics

[GitHub] [flink-table-store] zjureel commented on pull request #326: [FLINK-29702] Add micro benchmarks module and merge tree reader/writer benchmarks

2022-10-24 Thread GitBox
zjureel commented on PR #326: URL: https://github.com/apache/flink-table-store/pull/326#issuecomment-1289880133 Hi @JingsongLi I have split the reader/writer factory for compaction in the micro benchmarks and fix the concurrency problem, please review again, thanks -- This is an automate

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #162: [FLINK-29593] Add QuantileSummary to help calculate approximate quant…

2022-10-24 Thread GitBox
zhipeng93 commented on code in PR #162: URL: https://github.com/apache/flink-ml/pull/162#discussion_r1003924160 ## flink-ml-core/src/main/java/org/apache/flink/ml/util/QuantileSummary.java: ## @@ -0,0 +1,359 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [flink] libenchao commented on a diff in pull request #20140: [Flink 16024][Connector][JDBC] Support FilterPushdown

2022-10-24 Thread GitBox
libenchao commented on code in PR #20140: URL: https://github.com/apache/flink/pull/20140#discussion_r1003920728 ## flink-connectors/flink-connector-jdbc/src/test/resources/org/apache/flink/connector/jdbc/table/JdbcTablePlanTest.xml: ## @@ -51,4 +51,22 @@ TableSourceScan(table=[

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #162: [FLINK-29593] Add QuantileSummary to help calculate approximate quant…

2022-10-24 Thread GitBox
zhipeng93 commented on code in PR #162: URL: https://github.com/apache/flink-ml/pull/162#discussion_r1003921280 ## flink-ml-core/src/main/java/org/apache/flink/ml/util/QuantileSummary.java: ## @@ -0,0 +1,359 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #162: [FLINK-29593] Add QuantileSummary to help calculate approximate quant…

2022-10-24 Thread GitBox
zhipeng93 commented on code in PR #162: URL: https://github.com/apache/flink-ml/pull/162#discussion_r1003921280 ## flink-ml-core/src/main/java/org/apache/flink/ml/util/QuantileSummary.java: ## @@ -0,0 +1,359 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[jira] [Commented] (FLINK-29737) Support DataGen on waveform function

2022-10-24 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623501#comment-17623501 ] Shengkai Fang commented on FLINK-29737: --- Thanks for your idea. Could you share the

[jira] [Updated] (FLINK-29217) CoordinatorEventsToStreamOperatorRecipientExactlyOnceITCase.testConcurrentCheckpoint failed with AssertionFailedError

2022-10-24 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-29217: - Fix Version/s: 1.16.1 (was: 1.16.0) > CoordinatorEventsToStreamOperatorRe

[GitHub] [flink-web] godfreyhe commented on a diff in pull request #574: Announcement blogpost for the 1.16 release

2022-10-24 Thread GitBox
godfreyhe commented on code in PR #574: URL: https://github.com/apache/flink-web/pull/574#discussion_r1003917397 ## _posts/2022-10-15-1.16-announcement.md: ## @@ -0,0 +1,402 @@ +--- +layout: post +title: "Announcing the Release of Apache Flink 1.16" +subtitle: "" +date: 2022-10

[jira] [Closed] (FLINK-28914) Could not find any factories that implement

2022-10-24 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang closed FLINK-28914. - Resolution: Fixed > Could not find any factories that implement > --

[jira] [Commented] (FLINK-27773) Introduce the E2E tests for SQL Gateway

2022-10-24 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623496#comment-17623496 ] Shengkai Fang commented on FLINK-27773: --- [~martijnvisser] It has been implemented

[jira] [Updated] (FLINK-27773) Introduce the E2E tests for SQL Gateway

2022-10-24 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang updated FLINK-27773: -- Fix Version/s: 1.16.0 > Introduce the E2E tests for SQL Gateway > ---

[jira] [Assigned] (FLINK-29732) Support configuring session with SQL statement

2022-10-24 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang reassigned FLINK-29732: - Assignee: yuzelin > Support configuring session with SQL statement > --

[GitHub] [flink-web] godfreyhe commented on a diff in pull request #574: Announcement blogpost for the 1.16 release

2022-10-24 Thread GitBox
godfreyhe commented on code in PR #574: URL: https://github.com/apache/flink-web/pull/574#discussion_r1003914702 ## _posts/2022-10-15-1.16-announcement.md: ## @@ -0,0 +1,402 @@ +--- +layout: post +title: "Announcing the Release of Apache Flink 1.16" +subtitle: "" +date: 2022-10

[GitHub] [flink-kubernetes-operator] morhidi closed pull request #372: [FLINK-29261] Use FAIL_ON_UNKNOWN_PROPERTIES=false in ReconciliationUtils

2022-10-24 Thread GitBox
morhidi closed pull request #372: [FLINK-29261] Use FAIL_ON_UNKNOWN_PROPERTIES=false in ReconciliationUtils URL: https://github.com/apache/flink-kubernetes-operator/pull/372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #410: Added the CRD compatability check to kubernetes operator 1.2.0

2022-10-24 Thread GitBox
morhidi commented on PR #410: URL: https://github.com/apache/flink-kubernetes-operator/pull/410#issuecomment-1289856878 +1 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[jira] [Created] (FLINK-29746) Add workflow in github for micro benchmarks

2022-10-24 Thread Shammon (Jira)
Shammon created FLINK-29746: --- Summary: Add workflow in github for micro benchmarks Key: FLINK-29746 URL: https://issues.apache.org/jira/browse/FLINK-29746 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-29692) Support early/late fires for Windowing TVFs

2022-10-24 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623481#comment-17623481 ] Benchao Li commented on FLINK-29692: {quote}'Early fire' would periodically sent int

[jira] [Created] (FLINK-29745) Split reader/writer factory for compaction in MergeTreeTest

2022-10-24 Thread Shammon (Jira)
Shammon created FLINK-29745: --- Summary: Split reader/writer factory for compaction in MergeTreeTest Key: FLINK-29745 URL: https://issues.apache.org/jira/browse/FLINK-29745 Project: Flink Issue Type

[jira] [Updated] (FLINK-29744) Throw DeploymentFailedException on ImagePullBackOff

2022-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29744: --- Labels: pull-request-available (was: ) > Throw DeploymentFailedException on ImagePullBackOf

[GitHub] [flink-kubernetes-operator] morhidi opened a new pull request, #411: [FLINK-29744] Throw DeploymentFailedException on ImagePullBackOff

2022-10-24 Thread GitBox
morhidi opened a new pull request, #411: URL: https://github.com/apache/flink-kubernetes-operator/pull/411 ## What is the purpose of the change Handle cases when pod is unable to pull images. (a.k.a `ImagePullBackOff`) ## Brief change log Code is already handling `CrashLo

[GitHub] [flink] RocMarshal commented on pull request #20990: [FLINK-29050][JUnit5 Migration] Module: flink-hadoop-compatibility

2022-10-24 Thread GitBox
RocMarshal commented on PR #20990: URL: https://github.com/apache/flink/pull/20990#issuecomment-1289823623 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Updated] (FLINK-29744) Throw DeploymentFailedException on ImagePullBackOff

2022-10-24 Thread Matyas Orhidi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matyas Orhidi updated FLINK-29744: -- Affects Version/s: kubernetes-operator-1.3.0 > Throw DeploymentFailedException on ImagePullBac

[jira] [Updated] (FLINK-29744) Throw DeploymentFailedException on ImagePullBackOff

2022-10-24 Thread Matyas Orhidi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matyas Orhidi updated FLINK-29744: -- Component/s: Kubernetes Operator > Throw DeploymentFailedException on ImagePullBackOff > -

[jira] [Created] (FLINK-29744) Throw DeploymentFailedException on ImagePullBackOff

2022-10-24 Thread Matyas Orhidi (Jira)
Matyas Orhidi created FLINK-29744: - Summary: Throw DeploymentFailedException on ImagePullBackOff Key: FLINK-29744 URL: https://issues.apache.org/jira/browse/FLINK-29744 Project: Flink Issue T

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #409: [FLINK-29708] Convert CR Error field to JSON with enriched exception …

2022-10-24 Thread GitBox
morhidi commented on PR #409: URL: https://github.com/apache/flink-kubernetes-operator/pull/409#issuecomment-1289657005 > @morhidi > > Thanks for the feedback and sharing your test result: > > > It resulted in an string, that might not be a valid JSON: > > I will do some

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #409: [FLINK-29708] Convert CR Error field to JSON with enriched exception …

2022-10-24 Thread GitBox
morhidi commented on PR #409: URL: https://github.com/apache/flink-kubernetes-operator/pull/409#issuecomment-1289654405 > @morhidi > > Thanks for the feedback and sharing your test result: > > > It resulted in an string, that might not be a valid JSON: > > I will do some

[GitHub] [flink-kubernetes-operator] darenwkt commented on pull request #409: [FLINK-29708] Convert CR Error field to JSON with enriched exception …

2022-10-24 Thread GitBox
darenwkt commented on PR #409: URL: https://github.com/apache/flink-kubernetes-operator/pull/409#issuecomment-1289640460 @morhidi Thanks for the feedback and sharing your test result: >It resulted in an string, that might not be a valid JSON: I will do some testing on t

[GitHub] [flink-kubernetes-operator] darenwkt commented on a diff in pull request #409: [FLINK-29708] Convert CR Error field to JSON with enriched exception …

2022-10-24 Thread GitBox
darenwkt commented on code in PR #409: URL: https://github.com/apache/flink-kubernetes-operator/pull/409#discussion_r1003776097 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkResourceExceptionUtils.java: ## @@ -0,0 +1,118 @@ +/* + * L

[GitHub] [flink-kubernetes-operator] darenwkt commented on a diff in pull request #409: [FLINK-29708] Convert CR Error field to JSON with enriched exception …

2022-10-24 Thread GitBox
darenwkt commented on code in PR #409: URL: https://github.com/apache/flink-kubernetes-operator/pull/409#discussion_r1003775892 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkResourceExceptionUtils.java: ## @@ -0,0 +1,118 @@ +/* + * L

[GitHub] [flink-kubernetes-operator] darenwkt commented on a diff in pull request #409: [FLINK-29708] Convert CR Error field to JSON with enriched exception …

2022-10-24 Thread GitBox
darenwkt commented on code in PR #409: URL: https://github.com/apache/flink-kubernetes-operator/pull/409#discussion_r1003775450 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkResourceExceptionUtils.java: ## @@ -0,0 +1,118 @@ +/* + * L

[GitHub] [flink-kubernetes-operator] darenwkt commented on a diff in pull request #409: [FLINK-29708] Convert CR Error field to JSON with enriched exception …

2022-10-24 Thread GitBox
darenwkt commented on code in PR #409: URL: https://github.com/apache/flink-kubernetes-operator/pull/409#discussion_r1003775090 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkResourceExceptionUtils.java: ## @@ -0,0 +1,118 @@ +/* + * L

[GitHub] [flink-kubernetes-operator] darenwkt commented on a diff in pull request #409: [FLINK-29708] Convert CR Error field to JSON with enriched exception …

2022-10-24 Thread GitBox
darenwkt commented on code in PR #409: URL: https://github.com/apache/flink-kubernetes-operator/pull/409#discussion_r1003773876 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/crd/spec/AbstractFlinkSpec.java: ## @@ -57,6 +57,9 @@ public abstract

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #409: [FLINK-29708] Convert CR Error field to JSON with enriched exception …

2022-10-24 Thread GitBox
morhidi commented on PR #409: URL: https://github.com/apache/flink-kubernetes-operator/pull/409#issuecomment-1289601914 Another thing that I found is the structure of the stacktrace probably too verbose: ```{ "type": "org.apache.flink.kubernetes.operator.exception.Reconciliatio

[jira] [Comment Edited] (FLINK-29235) CVE-2022-25857 on flink-shaded

2022-10-24 Thread Sergio Sainz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623369#comment-17623369 ] Sergio Sainz edited comment on FLINK-29235 at 10/24/22 7:45 PM: --

[jira] [Comment Edited] (FLINK-29235) CVE-2022-25857 on flink-shaded

2022-10-24 Thread Sergio Sainz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623369#comment-17623369 ] Sergio Sainz edited comment on FLINK-29235 at 10/24/22 7:45 PM: --

[jira] [Commented] (FLINK-29235) CVE-2022-25857 on flink-shaded

2022-10-24 Thread Sergio Sainz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623369#comment-17623369 ] Sergio Sainz commented on FLINK-29235: -- Hello [~chesnay]  Noticed the flink-shaded

[GitHub] [flink] qingwei91 commented on pull request #20140: [Flink 16024][Connector][JDBC] Support FilterPushdown

2022-10-24 Thread GitBox
qingwei91 commented on PR #20140: URL: https://github.com/apache/flink/pull/20140#issuecomment-1289455651 Hi @libenchao , thank you very much for your review 👍 I've addressed all of your concern. On the TablePlanTest, do you mind to check if that's how it supposed to work? I don't th

[jira] [Closed] (FLINK-29529) Update flink version in flink-python-example of flink k8s operator

2022-10-24 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-29529. -- Resolution: Fixed merged to main a978375daeefbf23b548aab940a7ad3c366aa661 > Update flink version in f

  1   2   3   >