[jira] [Assigned] (FLINK-30219) Fetch results api in sql gateway return error result.

2022-11-26 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-30219: -- Assignee: Aiden Gong > Fetch results api in sql gateway return error result. >

[GitHub] [flink] wanglijie95 commented on pull request #20097: [FLINK-28284][Connectors/Jdbc] Add JdbcSink with new format

2022-11-26 Thread GitBox
wanglijie95 commented on PR #20097: URL: https://github.com/apache/flink/pull/20097#issuecomment-1328158004 Hi @eskabetxe, thanks for your reply. 1. I think the purpose of providing three sink interfaces(Sink, StatefulSink, TwoPhaseCommittingSink) is to facilitate developers/users to

[GitHub] [flink] klion26 closed pull request #20903: [FLINK-29402][state backends] Add RocksDB options for DirectIO reads …

2022-11-26 Thread GitBox
klion26 closed pull request #20903: [FLINK-29402][state backends] Add RocksDB options for DirectIO reads … URL: https://github.com/apache/flink/pull/20903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] Myasuka commented on a diff in pull request #21362: [FLINK-29430] Add sanity check when setCurrentKeyGroupIndex

2022-11-26 Thread GitBox
Myasuka commented on code in PR #21362: URL: https://github.com/apache/flink/pull/21362#discussion_r1032801916 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/InternalKeyContextImpl.java: ## @@ -72,6 +73,10 @@ public void setCurrentKey(@Nonnull K currentKey)

[jira] [Commented] (FLINK-30158) [Flink SQL][Protobuf] NullPointerException when querying Kafka topic using repeated or map attributes

2022-11-26 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639340#comment-17639340 ] Benchao Li commented on FLINK-30158: [~jamesmcguirepro] Currently Protobuf format requires users to

[GitHub] [flink] 1996fanrui commented on a diff in pull request #20137: Just for CI

2022-11-26 Thread GitBox
1996fanrui commented on code in PR #20137: URL: https://github.com/apache/flink/pull/20137#discussion_r1032795523 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequestExecutorImpl.java: ## @@ -125,11 +162,72 @@ public void start()

[GitHub] [flink] 1996fanrui commented on a diff in pull request #20137: Just for CI

2022-11-26 Thread GitBox
1996fanrui commented on code in PR #20137: URL: https://github.com/apache/flink/pull/20137#discussion_r1032794990 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequestExecutorImpl.java: ## @@ -51,27 +64,46 @@ class

[GitHub] [flink] flinkbot commented on pull request #21402: Name defination suggestion for this doc

2022-11-26 Thread GitBox
flinkbot commented on PR #21402: URL: https://github.com/apache/flink/pull/21402#issuecomment-1328035844 ## CI report: * 615b75b423f1a2f30b0666cb380e3d6563e50250 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] HarryUlysses opened a new pull request, #21402: Name defination suggestion for this doc

2022-11-26 Thread GitBox
HarryUlysses opened a new pull request, #21402: URL: https://github.com/apache/flink/pull/21402 We should keep name of variable defination style as same. On this doc, you use for azure adls gen2 storage container name. However, you add more charactor $ for storage name($). I think it is

[GitHub] [flink-connector-hbase] ferenc-csaky commented on a diff in pull request #1: [FLINK-30062][Connectors/HBase] Externalize the existing connector code as is

2022-11-26 Thread GitBox
ferenc-csaky commented on code in PR #1: URL: https://github.com/apache/flink-connector-hbase/pull/1#discussion_r1032778467 ## flink-connector-hbase-2.2/pom.xml: ## @@ -0,0 +1,431 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [flink-connector-hbase] ferenc-csaky commented on pull request #1: [FLINK-30062][Connectors/HBase] Externalize the existing connector code as is

2022-11-26 Thread GitBox
ferenc-csaky commented on PR #1: URL: https://github.com/apache/flink-connector-hbase/pull/1#issuecomment-1328032879 Messed up the rebase first time, so this one got closed cause the init commit was on the top. That is fixed now and the comments added also addressed, pls. check #2. --

[GitHub] [flink-connector-hbase] ferenc-csaky opened a new pull request, #2: [FLINK-30062][Connectors/HBase] Adapt connector code to external repo

2022-11-26 Thread GitBox
ferenc-csaky opened a new pull request, #2: URL: https://github.com/apache/flink-connector-hbase/pull/2 I moved the business code as is. Some changes were made: * Maven dependency structure. I tried to move common things under `dependencyManagement` to use the same version. * I

[GitHub] [flink-connector-hbase] ferenc-csaky closed pull request #1: [FLINK-30062][Connectors/HBase] Externalize the existing connector code as is

2022-11-26 Thread GitBox
ferenc-csaky closed pull request #1: [FLINK-30062][Connectors/HBase] Externalize the existing connector code as is URL: https://github.com/apache/flink-connector-hbase/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] flinkbot commented on pull request #21401: [FLINK-29718][table] Supports hive sum function by native implementation

2022-11-26 Thread GitBox
flinkbot commented on PR #21401: URL: https://github.com/apache/flink/pull/21401#issuecomment-1328018740 ## CI report: * f8760a5a19f8a7acf6e6718648a2afd3b1977fb6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-29718) Supports hive sum function by native implementation

2022-11-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29718: --- Labels: pull-request-available (was: ) > Supports hive sum function by native

[GitHub] [flink] lsyldliu opened a new pull request, #21401: [FLINK-29718][table] Supports hive sum function by native implementation

2022-11-26 Thread GitBox
lsyldliu opened a new pull request, #21401: URL: https://github.com/apache/flink/pull/21401 ## What is the purpose of the change Supports hive sum function by native implementation ## Brief change log - *Supports hive sum function by native implementation*

[jira] [Created] (FLINK-30221) Fix the bug of sum(try_cast(string as bigint)) return null when partial elements can't convert to bigint

2022-11-26 Thread dalongliu (Jira)
dalongliu created FLINK-30221: - Summary: Fix the bug of sum(try_cast(string as bigint)) return null when partial elements can't convert to bigint Key: FLINK-30221 URL:

[jira] [Created] (FLINK-30220) Hide user credentials in Flink SQL JDBC connector

2022-11-26 Thread Jun Qin (Jira)
Jun Qin created FLINK-30220: --- Summary: Hide user credentials in Flink SQL JDBC connector Key: FLINK-30220 URL: https://issues.apache.org/jira/browse/FLINK-30220 Project: Flink Issue Type:

[jira] [Updated] (FLINK-30220) Secure user credentials in Flink SQL JDBC connector

2022-11-26 Thread Jun Qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Qin updated FLINK-30220: Summary: Secure user credentials in Flink SQL JDBC connector (was: Hide user credentials in Flink SQL

[GitHub] [flink] flinkbot commented on pull request #21400: [FLINK-30219] Fetch results api in sql gateway return error result

2022-11-26 Thread GitBox
flinkbot commented on PR #21400: URL: https://github.com/apache/flink/pull/21400#issuecomment-1328004247 ## CI report: * ea65940d6768d658b74a63243db6dac077e975a9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30219) Fetch results api in sql gateway return error result.

2022-11-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30219: --- Labels: pull-request-available (was: ) > Fetch results api in sql gateway return error

[GitHub] [flink] GOODBOY008 opened a new pull request, #21400: [FLINK-30219] Fetch results api in sql gateway return error result

2022-11-26 Thread GitBox
GOODBOY008 opened a new pull request, #21400: URL: https://github.com/apache/flink/pull/21400 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring

[GitHub] [flink] gaborgsomogyi commented on pull request #20875: [FLINK-29363][runtime-web] allow fully redirection in web dashboard

2022-11-26 Thread GitBox
gaborgsomogyi commented on PR #20875: URL: https://github.com/apache/flink/pull/20875#issuecomment-1328003317 @rmetzger now it's all green and good to go :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL