[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #464: [FLINK-30268] HA metadata and other cluster submission related errors should not throw DeploymentFailedException

2022-12-03 Thread GitBox
morhidi commented on PR #464: URL: https://github.com/apache/flink-kubernetes-operator/pull/464#issuecomment-1336324416 > > @pvary please also rebase it to the latest containing @gaborgsomogyi's e2e changes > > @morhidi: I am not sure I understand this comment. You might refer to my

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #458: [FLINK-27852] Add OLM bundle generator

2022-12-03 Thread GitBox
morhidi commented on PR #458: URL: https://github.com/apache/flink-kubernetes-operator/pull/458#issuecomment-1336323557 > Hi @morhidi I can't find a mac os w/ m1 right now. If you have one could you run the new ./generate-olm-bundle.sh script and see if this what we want? It works on

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #458: [FLINK-27852] Add OLM bundle generator

2022-12-03 Thread GitBox
morhidi commented on PR #458: URL: https://github.com/apache/flink-kubernetes-operator/pull/458#issuecomment-1336323496 We should add the generated folders to .gitignore: ``` 1.3.0/ cat/ crds/ helm/ ``` Maybe it's even better to put these behind a

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #458: [FLINK-27852] Add OLM bundle generator

2022-12-03 Thread GitBox
morhidi commented on PR #458: URL: https://github.com/apache/flink-kubernetes-operator/pull/458#issuecomment-1336322881 Hi @tedhtchang this looks better now however I guess this was unintentional: ``` + docker push docker.io/tedhtchang/flink-op-bundle:1.3.0 The push refers to reposi

[GitHub] [flink-kubernetes-operator] tedhtchang commented on pull request #458: [FLINK-27852] Add OLM bundle generator

2022-12-03 Thread GitBox
tedhtchang commented on PR #458: URL: https://github.com/apache/flink-kubernetes-operator/pull/458#issuecomment-1336310902 Hi @morhidi I can't find a mac os w/ m1 right now. If you have one could you run the new ./generate-olm-bundle.sh script and see if this what we want? -- This is an

[GitHub] [flink] hdulay commented on a diff in pull request #21436: [FLINK-30093] [formats] Protobuf Timestamp Compile Error

2022-12-03 Thread GitBox
hdulay commented on code in PR #21436: URL: https://github.com/apache/flink/pull/21436#discussion_r1038878760 ## flink-formats/flink-protobuf/src/test/java/org/apache/flink/formats/protobuf/Pb3ToRowTest.java: ## @@ -85,6 +88,8 @@ public void testDeserialization() throws Exceptio

[GitHub] [flink] hdulay commented on a diff in pull request #21436: [FLINK-30093] [formats] Protobuf Timestamp Compile Error

2022-12-03 Thread GitBox
hdulay commented on code in PR #21436: URL: https://github.com/apache/flink/pull/21436#discussion_r1038877290 ## flink-formats/flink-protobuf/src/main/java/org/apache/flink/formats/protobuf/util/PbFormatUtils.java: ## @@ -34,6 +35,15 @@ public static String getFullJavaName(Descr

[jira] [Updated] (FLINK-29908) Externalize and configure E2E tests

2022-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29908: --- Labels: pull-request-available (was: ) > Externalize and configure E2E tests >

[GitHub] [flink-connector-aws] dannycranmer opened a new pull request, #34: [[FLINK-29908] Externalize and configure E2E tests for Firehose/Kinesis connectors

2022-12-03 Thread GitBox
dannycranmer opened a new pull request, #34: URL: https://github.com/apache/flink-connector-aws/pull/34 TODO -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Assigned] (FLINK-29908) Externalize and configure E2E tests

2022-12-03 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer reassigned FLINK-29908: - Assignee: Danny Cranmer > Externalize and configure E2E tests > ---

[GitHub] [flink-connector-aws] dependabot[bot] opened a new pull request, #33: Bump protobuf-java from 3.11.4 to 3.16.3

2022-12-03 Thread GitBox
dependabot[bot] opened a new pull request, #33: URL: https://github.com/apache/flink-connector-aws/pull/33 Bumps [protobuf-java](https://github.com/protocolbuffers/protobuf) from 3.11.4 to 3.16.3. Release notes Sourced from https://github.com/protocolbuffers/protobuf/releases";>pro

[jira] [Commented] (FLINK-29907) Externalize AWS connectors from Flink core

2022-12-03 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642893#comment-17642893 ] Danny Cranmer commented on FLINK-29907: --- Merged commit [{{aa10d88}}|https://githu

[GitHub] [flink-connector-aws] dannycranmer merged pull request #32: [FLINK-29907][Connectors/AWS] Externalize KDS/KDF and AWS base from Flink repo

2022-12-03 Thread GitBox
dannycranmer merged PR #32: URL: https://github.com/apache/flink-connector-aws/pull/32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [flink-kubernetes-operator] tweise opened a new pull request, #469: [FLINK-29109] Generate random jobId for stateless upgrade mode irrespective of Flink version

2022-12-03 Thread GitBox
tweise opened a new pull request, #469: URL: https://github.com/apache/flink-kubernetes-operator/pull/469 ## What is the purpose of the change * Previously the logic to assign jobId to avoid checkpoint path collision was applied for Flink versions >= 1.16. Since even with the newer ve

[jira] [Commented] (FLINK-29109) Checkpoint path conflict with stateless upgrade mode

2022-12-03 Thread Thomas Weise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642849#comment-17642849 ] Thomas Weise commented on FLINK-29109: -- [~gyfora] thanks for catching this. Because

[jira] [Commented] (FLINK-30116) Don't Show Env Vars in Web UI

2022-12-03 Thread ConradJam (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642834#comment-17642834 ] ConradJam commented on FLINK-30116: --- I was wondering does the name *ConfigurationInfo*

[GitHub] [flink] flinkbot commented on pull request #21448: [FLINK-30116][rest] Don't Show Env Vars in Web UI

2022-12-03 Thread GitBox
flinkbot commented on PR #21448: URL: https://github.com/apache/flink/pull/21448#issuecomment-1336157830 ## CI report: * 96d75ad08ec4c2030423ee59a403a5a9185b5afa UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30116) Don't Show Env Vars in Web UI

2022-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30116: --- Labels: pull-request-available (was: ) > Don't Show Env Vars in Web UI > --

[GitHub] [flink] czy006 opened a new pull request, #21448: [FLINK-30116][rest] Don't Show Env Vars in Web UI

2022-12-03 Thread GitBox
czy006 opened a new pull request, #21448: URL: https://github.com/apache/flink/pull/21448 ## What is the purpose of the change Remove REST APIs for the environmental information. ## Brief change log - remove JobManagerEnvironmentHandler - remove JobManagerJobEnvironmen

[GitHub] [flink] flinkbot commented on pull request #21447: [FLINK-30185] Provide the flame graph to the subtask level

2022-12-03 Thread GitBox
flinkbot commented on PR #21447: URL: https://github.com/apache/flink/pull/21447#issuecomment-1336126337 ## CI report: * b8b928d7e32faab538d2d81d2087df5ced006efc UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30185) Provide the flame graph to the subtask level

2022-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30185: --- Labels: pull-request-available (was: ) > Provide the flame graph to the subtask level > ---

[GitHub] [flink] 1996fanrui opened a new pull request, #21447: [FLINK-30185] Provide the flame graph to the subtask level

2022-12-03 Thread GitBox
1996fanrui opened a new pull request, #21447: URL: https://github.com/apache/flink/pull/21447 ## What is the purpose of the change Provide the flame graph to the subtask level ## Brief change log - [FLINK-30185][rest][refactor] Change the cache key of flame graph info fr

[jira] [Updated] (FLINK-30282) Logical type ROW lost inner field's nullability after convert to RelDataType

2022-12-03 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-30282: -- Description: h3. Issue History This is not a new issue, FLINK-13604 has tracked it before, and FLINK-

[GitHub] [flink] akalash commented on pull request #21440: [FLINK-28766][tests] Safe iterate over checkpoint files in order to avoid exception during parallel savepoint deletion

2022-12-03 Thread GitBox
akalash commented on PR #21440: URL: https://github.com/apache/flink/pull/21440#issuecomment-1336114629 @pnowojski , tests are green -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c