[jira] [Commented] (FLINK-30360) A null pointer exception is thrown when data is written to the HBase table using the specified column name

2022-12-20 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649817#comment-17649817 ] Martijn Visser commented on FLINK-30360: [~wjc920] I don't know HBase that well,

[jira] [Reopened] (FLINK-28185) "Invalid negative offset" when using OffsetsInitializer.timestamp(.)

2022-12-20 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reopened FLINK-28185: Re-opening so a backport to 1.16 can be added > "Invalid negative offset" when using OffsetsI

[GitHub] [flink-connector-rabbitmq] MartijnVisser commented on pull request #4: [FLINK-30417] [Connectors/ RabbitMQ] add "RabbitMQ" to rabbit error while creating the channel

2022-12-20 Thread GitBox
MartijnVisser commented on PR #4: URL: https://github.com/apache/flink-connector-rabbitmq/pull/4#issuecomment-1359531946 @smulikHakipod Please follow https://flink.apache.org/contributing/how-to-contribute.html next time, specifically for your commit message layout. -- This is an autom

[GitHub] [flink-connector-rabbitmq] boring-cyborg[bot] commented on pull request #4: [FLINK-30417] [Connectors/ RabbitMQ] add "RabbitMQ" to rabbit error while creating the channel

2022-12-20 Thread GitBox
boring-cyborg[bot] commented on PR #4: URL: https://github.com/apache/flink-connector-rabbitmq/pull/4#issuecomment-1359532519 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink-connector-rabbitmq] MartijnVisser merged pull request #4: [FLINK-30417] [Connectors/ RabbitMQ] add "RabbitMQ" to rabbit error while creating the channel

2022-12-20 Thread GitBox
MartijnVisser merged PR #4: URL: https://github.com/apache/flink-connector-rabbitmq/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[jira] [Closed] (FLINK-30417) RabbitMQ error is not clear

2022-12-20 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-30417. -- Fix Version/s: rabbitmq-3.0.1 Resolution: Fixed Fixed in main: 967f713257bf7e933c04808c

[GitHub] [flink] MartijnVisser merged pull request #21495: [hotfix][misprint] Remove duplicate word `version`

2022-12-20 Thread GitBox
MartijnVisser merged PR #21495: URL: https://github.com/apache/flink/pull/21495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

[GitHub] [flink] MartijnVisser commented on pull request #21254: Update docker.md

2022-12-20 Thread GitBox
MartijnVisser commented on PR #21254: URL: https://github.com/apache/flink/pull/21254#issuecomment-1359547294 > Is there a desire within the Flink team to ensure that PyFlink achieves similar uptake and robustness as PySpark? I think any open source community strives to improve their

[GitHub] [flink] GOODBOY008 commented on a diff in pull request #21481: [FLINK-30357][doc] Wrong link in connector/jdbc doc.

2022-12-20 Thread GitBox
GOODBOY008 commented on code in PR #21481: URL: https://github.com/apache/flink/pull/21481#discussion_r1053433401 ## docs/content.zh/docs/connectors/table/jdbc.md: ## @@ -672,12 +672,6 @@ Flink 支持连接到多个使用方言(dialect)的数据库,如 MySQL、O DECIMAL(20, 0) - - B

[jira] [Commented] (FLINK-27640) Flink not compiling, flink-connector-hive_2.12 is missing jhyde pentaho-aggdesigner-algorithm:jar:5.1.5-jhyde

2022-12-20 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649828#comment-17649828 ] Martijn Visser commented on FLINK-27640: [~luoyuxia] Do you know if this package

[GitHub] [flink] MartijnVisser commented on a diff in pull request #21481: [FLINK-30357][doc] Wrong link in connector/jdbc doc.

2022-12-20 Thread GitBox
MartijnVisser commented on code in PR #21481: URL: https://github.com/apache/flink/pull/21481#discussion_r1053436057 ## docs/content.zh/docs/connectors/table/jdbc.md: ## @@ -672,12 +672,6 @@ Flink 支持连接到多个使用方言(dialect)的数据库,如 MySQL、O DECIMAL(20, 0) - -

[GitHub] [flink] GOODBOY008 commented on a diff in pull request #21481: [FLINK-30357][doc] Wrong link in connector/jdbc doc.

2022-12-20 Thread GitBox
GOODBOY008 commented on code in PR #21481: URL: https://github.com/apache/flink/pull/21481#discussion_r1053441739 ## docs/content.zh/docs/connectors/table/jdbc.md: ## @@ -672,12 +672,6 @@ Flink 支持连接到多个使用方言(dialect)的数据库,如 MySQL、O DECIMAL(20, 0) - - B

[GitHub] [flink-kubernetes-operator] mxm opened a new pull request, #492: Start stabilization period only after job goes into RUNNING

2022-12-20 Thread GitBox
mxm opened a new pull request, #492: URL: https://github.com/apache/flink-kubernetes-operator/pull/492 We were tracking the stabilization period from the job start time which can greatly vary from the time the job goes into RUNNING state. This can result in no stabilization period at all le

[GitHub] [flink-connector-jdbc] wanglijie95 commented on pull request #2: [FLINK-28284] Add JdbcSink with new format

2022-12-20 Thread GitBox
wanglijie95 commented on PR #2: URL: https://github.com/apache/flink-connector-jdbc/pull/2#issuecomment-1359578023 @MartijnVisser @eskabetxe Yes, I think it(expose ExecutionConfig or isObjectReuseEnabled) is a blocker to the migration. The jdbc sink needs to decide whether to buffer the co

[GitHub] [flink-kubernetes-operator] mxm commented on pull request #492: [FLINK-30463] Start stabilization period only after job goes into RUNNING

2022-12-20 Thread GitBox
mxm commented on PR #492: URL: https://github.com/apache/flink-kubernetes-operator/pull/492#issuecomment-1359586067 Note: I need to tag the commit with the correct JIRA on merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[jira] [Updated] (FLINK-30463) Stabilization period starts before job goes into RUNNING

2022-12-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30463: --- Labels: pull-request-available (was: ) > Stabilization period starts before job goes into R

[GitHub] [flink-connector-elasticsearch] reswqa commented on pull request #50: [FLINK-30359][es] flink-sql-connector-elasticsearch6's jar should luding the dependency of com.carrotsearch:hppc

2022-12-20 Thread GitBox
reswqa commented on PR #50: URL: https://github.com/apache/flink-connector-elasticsearch/pull/50#issuecomment-1359591588 @MartijnVisser Thanks for the review, I have relocation the dependency of `com.carrotsearch.hppc` and rebase this commit . It seems that first-time contributors need a m

[jira] [Updated] (FLINK-30455) Avoid "cleaning" of java.lang.String in ClosureCleaner

2022-12-20 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-30455: --- Component/s: API / Core > Avoid "cleaning" of java.lang.String in ClosureCleaner > -

[GitHub] [flink] rmetzger commented on pull request #21532: FLINK-30455 [core] Excluding java.lang.String and primitive types from closure cleaning

2022-12-20 Thread GitBox
rmetzger commented on PR #21532: URL: https://github.com/apache/flink/pull/21532#issuecomment-1359609287 Thanks a lot for opening a PR. It would be nice to have a Unit test for this change in the `ClosureCleanerTest` which fails on Java 17 (because of the reflective access), but succeeds af

[GitHub] [flink-connector-jdbc] eskabetxe opened a new pull request, #12: [FLINK-27940] Migrate tests to junit5

2022-12-20 Thread GitBox
eskabetxe opened a new pull request, #12: URL: https://github.com/apache/flink-connector-jdbc/pull/12 All tests migrated to Junit5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[jira] [Updated] (FLINK-27940) [JUnit5 Migration] Module: flink-connector-jdbc

2022-12-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27940: --- Labels: pull-request-available starter (was: starter) > [JUnit5 Migration] Module: flink-co

[GitHub] [flink] rmetzger commented on pull request #21532: FLINK-30455 [core] Excluding java.lang.String and primitive types from closure cleaning

2022-12-20 Thread GitBox
rmetzger commented on PR #21532: URL: https://github.com/apache/flink/pull/21532#issuecomment-1359614383 The commit message doesn't adhere to Flink's commit message pattern. It needs to be `[FLINK-30455] Excluding java.lang.String and primitive types ...` (e.g. Jira Id in brackets) -

[GitHub] [flink-connector-jdbc] eskabetxe commented on a diff in pull request #12: [FLINK-27940] Migrate tests to junit5

2022-12-20 Thread GitBox
eskabetxe commented on code in PR #12: URL: https://github.com/apache/flink-connector-jdbc/pull/12#discussion_r1053484871 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/xa/JdbcXaSinkMigrationTest.java: ## @@ -77,7 +79,8 @@ public JdbcXaSinkMigrationTest(F

[GitHub] [flink] rmetzger commented on a diff in pull request #21531: FLINK-30454 [runtime] Fixing visibility issue for SizeGauge.SizeSupplier

2022-12-20 Thread GitBox
rmetzger commented on code in PR #21531: URL: https://github.com/apache/flink/pull/21531#discussion_r1053490585 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/FileSystemJobResultStore.java: ## @@ -207,7 +207,7 @@ public Set getDirtyResultsInternal() thr

[GitHub] [flink] gunnarmorling commented on a diff in pull request #21531: FLINK-30454 [runtime] Fixing visibility issue for SizeGauge.SizeSupplier

2022-12-20 Thread GitBox
gunnarmorling commented on code in PR #21531: URL: https://github.com/apache/flink/pull/21531#discussion_r1053500731 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/FileSystemJobResultStore.java: ## @@ -207,7 +207,7 @@ public Set getDirtyResultsInternal(

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #492: [FLINK-30463] Start stabilization period only after job goes into RUNNING

2022-12-20 Thread GitBox
gyfora commented on code in PR #492: URL: https://github.com/apache/flink-kubernetes-operator/pull/492#discussion_r1053501498 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingExecutor.java: ## @@ -121,13 +122,22 @@ public boolean

[jira] [Updated] (FLINK-30456) OLM Bundle Description Version Problems

2022-12-20 Thread Ted Chang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Chang updated FLINK-30456: -- Attachment: image-2022-12-20-08-21-02-597.png > OLM Bundle Description Version Problems >

[jira] [Commented] (FLINK-30456) OLM Bundle Description Version Problems

2022-12-20 Thread Ted Chang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649882#comment-17649882 ] Ted Chang commented on FLINK-30456: --- Hi Jim,  could you also fix the LINKS showing n/a

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #491: [FLINK-30456] Fixing Version and provider in OLM Description

2022-12-20 Thread GitBox
gyfora commented on code in PR #491: URL: https://github.com/apache/flink-kubernetes-operator/pull/491#discussion_r1053512772 ## tools/olm/docker-entry.sh: ## @@ -102,6 +96,10 @@ generate_olm_bundle() { yq ea -i ".spec.replaces = \"${PACKAGE_NAME}.v${PREVIOUS_BUNDLE_VERSION}

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #490: [backport][FLINK-30437][FLINK-30408] Harden HA meta check to avoid state loss

2022-12-20 Thread GitBox
gyfora merged PR #490: URL: https://github.com/apache/flink-kubernetes-operator/pull/490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[jira] [Updated] (FLINK-30437) State incompatibility issue might cause state loss

2022-12-20 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-30437: --- Fix Version/s: kubernetes-operator-1.3.1 > State incompatibility issue might cause state loss >

[jira] [Commented] (FLINK-30437) State incompatibility issue might cause state loss

2022-12-20 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649890#comment-17649890 ] Gyula Fora commented on FLINK-30437: merged to release-1.3 4e583a0faa0991c61b37ecd9b

[jira] [Updated] (FLINK-30408) Add unit test for HA metadata check logic

2022-12-20 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-30408: --- Fix Version/s: kubernetes-operator-1.3.1 > Add unit test for HA metadata check logic > -

[jira] [Commented] (FLINK-30408) Add unit test for HA metadata check logic

2022-12-20 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649891#comment-17649891 ] Gyula Fora commented on FLINK-30408: merged to release-1.3 4e583a0faa0991c61b37ecd9b

[jira] [Closed] (FLINK-30244) When task using udf/udtf with jni, on k8s session the old TM will shut down and create new TM or the task will fail

2022-12-20 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-30244. -- Resolution: Abandoned > When task using udf/udtf with jni, on k8s session the old TM will shut down >

[jira] [Created] (FLINK-30466) Detect ineffective scaling operations

2022-12-20 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-30466: -- Summary: Detect ineffective scaling operations Key: FLINK-30466 URL: https://issues.apache.org/jira/browse/FLINK-30466 Project: Flink Issue Type: New Feature

[GitHub] [flink-connector-jdbc] eskabetxe commented on a diff in pull request #8: [FLINK-14102] Introduce DB2Dialect.

2022-12-20 Thread GitBox
eskabetxe commented on code in PR #8: URL: https://github.com/apache/flink-connector-jdbc/pull/8#discussion_r1053513698 ## flink-connector-jdbc/pom.xml: ## @@ -195,6 +203,14 @@ under the License. test + +

[GitHub] [flink] hlteoh37 opened a new pull request, #21538: [FLINK-24386] Guard JobMaster against exceptions from starting the Op…

2022-12-20 Thread GitBox
hlteoh37 opened a new pull request, #21538: URL: https://github.com/apache/flink/pull/21538 …eratorCoordinator ## What is the purpose of the change * Improve the stability of the JobMaster when OperatorCoordinator throws an Exception upon start(). Instead of restarting the entire J

[jira] [Updated] (FLINK-24386) JobMaster should guard against exceptions from OperatorCoordinator

2022-12-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24386: --- Labels: pull-request-available (was: ) > JobMaster should guard against exceptions from Ope

[GitHub] [flink] flinkbot commented on pull request #21538: [FLINK-24386] Guard JobMaster against exceptions from starting the Op…

2022-12-20 Thread GitBox
flinkbot commented on PR #21538: URL: https://github.com/apache/flink/pull/21538#issuecomment-1359782359 ## CI report: * 0f68db2a53d68bb850f6cd0ac285075e144f38ab UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Comment Edited] (FLINK-30456) OLM Bundle Description Version Problems

2022-12-20 Thread Ted Chang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649882#comment-17649882 ] Ted Chang edited comment on FLINK-30456 at 12/20/22 5:36 PM: -

[GitHub] [flink] mbalassi commented on pull request #21511: Delegation token framework refactoring

2022-12-20 Thread GitBox
mbalassi commented on PR #21511: URL: https://github.com/apache/flink/pull/21511#issuecomment-1359896458 Will merge this later today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] mas-chen opened a new pull request, #21539: [FLINK-30409][Runtime / Metrics] Return a new metric group when creating closed metric g…

2022-12-20 Thread GitBox
mas-chen opened a new pull request, #21539: URL: https://github.com/apache/flink/pull/21539 …roup ## What is the purpose of the change The addGroup returns new a metric group if the metric group is already closed, so that implementations can recreate metrics. ##

[jira] [Updated] (FLINK-30409) Support reopening closed metric groups

2022-12-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30409: --- Labels: pull-request-available (was: ) > Support reopening closed metric groups > -

[GitHub] [flink] flinkbot commented on pull request #21539: [FLINK-30409][Runtime / Metrics] Return a new metric group when creating closed metric g…

2022-12-20 Thread GitBox
flinkbot commented on PR #21539: URL: https://github.com/apache/flink/pull/21539#issuecomment-1359996492 ## CI report: * c8b29b3dac1540467927bb6ff50e43e50ec44df1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-table-store] Gerrrr commented on a diff in pull request #443: [FLINK-30458] Refactor Table Store Documentation

2022-12-20 Thread GitBox
Ge commented on code in PR #443: URL: https://github.com/apache/flink-table-store/pull/443#discussion_r1053657989 ## docs/content/docs/features/table-types.md: ## @@ -0,0 +1,142 @@ +--- +title: "Table Types" +weight: 1 +type: docs +aliases: +- /features/table-types.html +---

[GitHub] [flink-table-store] Gerrrr commented on a diff in pull request #443: [FLINK-30458] Refactor Table Store Documentation

2022-12-20 Thread GitBox
Ge commented on code in PR #443: URL: https://github.com/apache/flink-table-store/pull/443#discussion_r1053671570 ## docs/content/docs/sql-api/writing-tables.md: ## @@ -0,0 +1,79 @@ +--- +title: "Writing Tables" +weight: 4 +type: docs +aliases: +- /sql-api/writing-tables.htm

[GitHub] [flink] mbalassi merged pull request #21511: Delegation token framework refactoring

2022-12-20 Thread GitBox
mbalassi merged PR #21511: URL: https://github.com/apache/flink/pull/21511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[GitHub] [flink-kubernetes-operator] jbusche commented on a diff in pull request #491: [FLINK-30456] Fixing Version and provider in OLM Description

2022-12-20 Thread GitBox
jbusche commented on code in PR #491: URL: https://github.com/apache/flink-kubernetes-operator/pull/491#discussion_r1053777424 ## tools/olm/docker-entry.sh: ## @@ -102,6 +96,10 @@ generate_olm_bundle() { yq ea -i ".spec.replaces = \"${PACKAGE_NAME}.v${PREVIOUS_BUNDLE_VERSION

[GitHub] [flink-kubernetes-operator] jbusche commented on pull request #491: [FLINK-30456] Fixing Version and provider in OLM Description

2022-12-20 Thread GitBox
jbusche commented on PR #491: URL: https://github.com/apache/flink-kubernetes-operator/pull/491#issuecomment-1360368627 OK, let me test this one on my OpenShift cluster, will post results here -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [flink-table-store] Gerrrr commented on a diff in pull request #443: [FLINK-30458] Refactor Table Store Documentation

2022-12-20 Thread GitBox
Ge commented on code in PR #443: URL: https://github.com/apache/flink-table-store/pull/443#discussion_r1053789276 ## docs/content/docs/features/table-types.md: ## @@ -0,0 +1,142 @@ +--- +title: "Table Types" +weight: 1 +type: docs +aliases: +- /features/table-types.html +---

[GitHub] [flink-kubernetes-operator] jbusche commented on pull request #491: [FLINK-30456] Fixing Version and provider in OLM Description

2022-12-20 Thread GitBox
jbusche commented on PR #491: URL: https://github.com/apache/flink-kubernetes-operator/pull/491#issuecomment-1360379235 It's looking good - it added the links as expected, and is matching on the versions nicely. Deployed well: ``` oc get pods NAME

[jira] [Commented] (FLINK-30409) Support reopening closed metric groups

2022-12-20 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650008#comment-17650008 ] Mason Chen commented on FLINK-30409: [~xtsong] Thanks for assigning me the ticket. T

[GitHub] [flink-kubernetes-operator] tedhtchang commented on a diff in pull request #491: [FLINK-30456] Fixing Version and provider in OLM Description

2022-12-20 Thread GitBox
tedhtchang commented on code in PR #491: URL: https://github.com/apache/flink-kubernetes-operator/pull/491#discussion_r1053794906 ## tools/olm/docker-entry.sh: ## @@ -102,6 +96,10 @@ generate_olm_bundle() { yq ea -i ".spec.replaces = \"${PACKAGE_NAME}.v${PREVIOUS_BUNDLE_VERS

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #487: [FLINK-30411] Validate empty JmSpec and TmSpec

2022-12-20 Thread GitBox
morhidi commented on PR #487: URL: https://github.com/apache/flink-kubernetes-operator/pull/487#issuecomment-1360392616 @gyfora how do you think we should fix this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #491: [FLINK-30456] Fixing Version and provider in OLM Description

2022-12-20 Thread GitBox
morhidi commented on PR #491: URL: https://github.com/apache/flink-kubernetes-operator/pull/491#issuecomment-1360393927 +1 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [flink-kubernetes-operator] tedhtchang commented on pull request #491: [FLINK-30456] Fixing Version and provider in OLM Description

2022-12-20 Thread GitBox
tedhtchang commented on PR #491: URL: https://github.com/apache/flink-kubernetes-operator/pull/491#issuecomment-1360404403 Tested on Kubernetes. LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #489: [FLINK-30406] Detect when jobmanager never started

2022-12-20 Thread GitBox
morhidi commented on code in PR #489: URL: https://github.com/apache/flink-kubernetes-operator/pull/489#discussion_r1053822550 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconcilerUpgradeModeTest.java: ## @@

[GitHub] [flink-ml] vacaly commented on a diff in pull request #192: [FLINK-30451] Add Estimator and Transformer for Swing

2022-12-20 Thread GitBox
vacaly commented on code in PR #192: URL: https://github.com/apache/flink-ml/pull/192#discussion_r1053881373 ## flink-ml-lib/src/main/java/org/apache/flink/ml/recommendation/Swing.java: ## @@ -0,0 +1,407 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

[GitHub] [flink-ml] vacaly commented on a diff in pull request #192: [FLINK-30451] Add Estimator and Transformer for Swing

2022-12-20 Thread GitBox
vacaly commented on code in PR #192: URL: https://github.com/apache/flink-ml/pull/192#discussion_r1053881499 ## flink-ml-lib/src/main/java/org/apache/flink/ml/recommendation/Swing.java: ## @@ -0,0 +1,407 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

[GitHub] [flink-ml] vacaly commented on a diff in pull request #192: [FLINK-30451] Add Estimator and Transformer for Swing

2022-12-20 Thread GitBox
vacaly commented on code in PR #192: URL: https://github.com/apache/flink-ml/pull/192#discussion_r1053890313 ## flink-ml-lib/src/main/java/org/apache/flink/ml/recommendation/Swing.java: ## @@ -0,0 +1,407 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

[jira] [Closed] (FLINK-30369) Fix FlinkFilterJoinRule push wrong filters to another side while join type is left/right outer join

2022-12-20 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yunhong Zheng closed FLINK-30369. - Resolution: Not A Bug > Fix FlinkFilterJoinRule push wrong filters to another side while join ty

[jira] [Created] (FLINK-30467) Improve the accuracy of estimating the row count of LocalHashAgg to make more two-phase HashAgg operators effective

2022-12-20 Thread Yunhong Zheng (Jira)
Yunhong Zheng created FLINK-30467: - Summary: Improve the accuracy of estimating the row count of LocalHashAgg to make more two-phase HashAgg operators effective Key: FLINK-30467 URL: https://issues.apache.org/jir

[GitHub] [flink-ml] vacaly commented on a diff in pull request #192: [FLINK-30451] Add Estimator and Transformer for Swing

2022-12-20 Thread GitBox
vacaly commented on code in PR #192: URL: https://github.com/apache/flink-ml/pull/192#discussion_r1053893147 ## flink-ml-lib/src/main/java/org/apache/flink/ml/recommendation/SwingModel.java: ## @@ -0,0 +1,251 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [flink] dianfu commented on pull request #21254: Update docker.md

2022-12-20 Thread GitBox
dianfu commented on PR #21254: URL: https://github.com/apache/flink/pull/21254#issuecomment-1360669458 Sorry for late response. I have missed this PR. The PR LGTM and I guess it should be caused by the bump of fastavro version which is introduced in https://issues.apache.org/jira/browse/FLI

[jira] [Commented] (FLINK-27640) Flink not compiling, flink-connector-hive_2.12 is missing jhyde pentaho-aggdesigner-algorithm:jar:5.1.5-jhyde

2022-12-20 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650050#comment-17650050 ] luoyuxia commented on FLINK-27640: -- I think it can safely be excluded since org.pentah

[GitHub] [flink] dianfu closed pull request #21254: Update docker.md

2022-12-20 Thread GitBox
dianfu closed pull request #21254: Update docker.md URL: https://github.com/apache/flink/pull/21254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issu

[GitHub] [flink] lincoln-lil commented on a diff in pull request #21219: [FLINK-29849][table-planner] Fix event time temporal join on an upsert source may produce incorrect execution plan

2022-12-20 Thread GitBox
lincoln-lil commented on code in PR #21219: URL: https://github.com/apache/flink/pull/21219#discussion_r1053906856 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/EventTimeTemporalJoinRewriteRule.java: ## @@ -0,0 +1,477 @@ +/* +

[GitHub] [flink-connector-jdbc] wanglijie95 commented on pull request #12: [FLINK-27940] Migrate tests to junit5

2022-12-20 Thread GitBox
wanglijie95 commented on PR #12: URL: https://github.com/apache/flink-connector-jdbc/pull/12#issuecomment-1360686642 @eskabetxe Please feel free to take it. I will assign it to you. And I can help to review this pr :) -- This is an automated message from the Apache Git Service. To respon

[jira] [Assigned] (FLINK-27940) [JUnit5 Migration] Module: flink-connector-jdbc

2022-12-20 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijie Wang reassigned FLINK-27940: -- Assignee: João Boto (was: Lijie Wang) > [JUnit5 Migration] Module: flink-connector-jdbc > --

[GitHub] [flink] xintongsong commented on a diff in pull request #21447: [FLINK-30185] Provide the flame graph to the subtask level

2022-12-20 Thread GitBox
xintongsong commented on code in PR #21447: URL: https://github.com/apache/flink/pull/21447#discussion_r1053911284 ## flink-runtime/src/main/java/org/apache/flink/runtime/messages/ThreadInfoSample.java: ## @@ -32,25 +36,33 @@ */ public class ThreadInfoSample implements Serial

[GitHub] [flink-kubernetes-operator] tweise commented on a diff in pull request #489: [FLINK-30406] Detect when jobmanager never started

2022-12-20 Thread GitBox
tweise commented on code in PR #489: URL: https://github.com/apache/flink-kubernetes-operator/pull/489#discussion_r1053912124 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java: ## @@ -116,9

[GitHub] [flink-ml] vacaly commented on a diff in pull request #192: [FLINK-30451] Add Estimator and Transformer for Swing

2022-12-20 Thread GitBox
vacaly commented on code in PR #192: URL: https://github.com/apache/flink-ml/pull/192#discussion_r1053913128 ## flink-ml-lib/src/main/java/org/apache/flink/ml/recommendation/Swing.java: ## @@ -0,0 +1,407 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

[GitHub] [flink] 1996fanrui commented on a diff in pull request #21447: [FLINK-30185] Provide the flame graph to the subtask level

2022-12-20 Thread GitBox
1996fanrui commented on code in PR #21447: URL: https://github.com/apache/flink/pull/21447#discussion_r1053913594 ## flink-runtime/src/main/java/org/apache/flink/runtime/messages/ThreadInfoSample.java: ## @@ -32,25 +36,33 @@ */ public class ThreadInfoSample implements Seriali

[GitHub] [flink] xintongsong commented on a diff in pull request #21347: [FLINK-29640][Client/Job Submission]Enhance the function configured by execution.shutdown-on-attached-exi…

2022-12-20 Thread GitBox
xintongsong commented on code in PR #21347: URL: https://github.com/apache/flink/pull/21347#discussion_r1053913714 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobClientHeartbeatHandler.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] fsk119 commented on pull request #21187: [FLINK-27837][sql-gateway] Support statement set in the SQL Gateway

2022-12-20 Thread GitBox
fsk119 commented on PR #21187: URL: https://github.com/apache/flink/pull/21187#issuecomment-1360718894 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [flink] xintongsong commented on a diff in pull request #21347: [FLINK-29640][Client/Job Submission]Enhance the function configured by execution.shutdown-on-attached-exi…

2022-12-20 Thread GitBox
xintongsong commented on code in PR #21347: URL: https://github.com/apache/flink/pull/21347#discussion_r1053915899 ## flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java: ## @@ -1344,6 +1344,13 @@ public CompletableFuture> listCompletedClusterDatas

[GitHub] [flink] chucheng92 commented on pull request #21464: [FLINK-30334][runtime] Fix SourceCoordinator#handleRequestSplitEvent hasNoMoreSplits check not consider the hybridsource situation

2022-12-20 Thread GitBox
chucheng92 commented on PR #21464: URL: https://github.com/apache/flink/pull/21464#issuecomment-1360734949 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Comment Edited] (FLINK-27640) Flink not compiling, flink-connector-hive_2.12 is missing jhyde pentaho-aggdesigner-algorithm:jar:5.1.5-jhyde

2022-12-20 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650050#comment-17650050 ] luoyuxia edited comment on FLINK-27640 at 12/21/22 2:41 AM:

[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #443: [FLINK-30458] Refactor Table Store Documentation

2022-12-20 Thread GitBox
tsreaper commented on code in PR #443: URL: https://github.com/apache/flink-table-store/pull/443#discussion_r1053932615 ## docs/content/docs/features/table-types.md: ## @@ -0,0 +1,142 @@ +--- +title: "Table Types" +weight: 1 +type: docs +aliases: +- /features/table-types.html +-

[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #443: [FLINK-30458] Refactor Table Store Documentation

2022-12-20 Thread GitBox
tsreaper commented on code in PR #443: URL: https://github.com/apache/flink-table-store/pull/443#discussion_r1053934087 ## docs/content/docs/maintenance-actions/write-performance.md: ## @@ -0,0 +1,118 @@ +--- +title: "Write Performance" +weight: 1 +type: docs +aliases: +- /maint

[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #443: [FLINK-30458] Refactor Table Store Documentation

2022-12-20 Thread GitBox
tsreaper commented on code in PR #443: URL: https://github.com/apache/flink-table-store/pull/443#discussion_r1053934427 ## docs/content/docs/sql-api/writing-tables.md: ## @@ -0,0 +1,79 @@ +--- +title: "Writing Tables" +weight: 4 +type: docs +aliases: +- /sql-api/writing-tables.h

[jira] (FLINK-15325) Input location preference which affects task distribution may make certain job performance worse

2022-12-20 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15325 ] Zhu Zhu deleted comment on FLINK-15325: - was (Author: flink-jira-bot): I am the [Flink Jira Bot|https://github.com/apache/flink-jira-bot/] and I help the community manage its development. I see

[jira] (FLINK-15325) Input location preference which affects task distribution may make certain job performance worse

2022-12-20 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15325 ] Zhu Zhu deleted comment on FLINK-15325: - was (Author: flink-jira-bot): This major issue is unassigned and itself and all of its Sub-Tasks have not been updated for 30 days. So, it has been label

[jira] (FLINK-15325) Input location preference which affects task distribution may make certain job performance worse

2022-12-20 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15325 ] Zhu Zhu deleted comment on FLINK-15325: - was (Author: flink-jira-bot): This issue was labeled "stale-minor" 7 days ago and has not received any updates so it is being deprioritized. If this tick

[jira] (FLINK-15325) Input location preference which affects task distribution may make certain job performance worse

2022-12-20 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15325 ] Zhu Zhu deleted comment on FLINK-15325: - was (Author: flink-jira-bot): This issue was labeled "stale-major" 7 ago and has not received any updates so it is being deprioritized. If this ticket is

[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #443: [FLINK-30458] Refactor Table Store Documentation

2022-12-20 Thread GitBox
tsreaper commented on code in PR #443: URL: https://github.com/apache/flink-table-store/pull/443#discussion_r1053934969 ## docs/content/docs/sql-api/writing-tables.md: ## @@ -0,0 +1,79 @@ +--- +title: "Writing Tables" +weight: 4 +type: docs +aliases: +- /sql-api/writing-tables.h

[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #443: [FLINK-30458] Refactor Table Store Documentation

2022-12-20 Thread GitBox
tsreaper commented on code in PR #443: URL: https://github.com/apache/flink-table-store/pull/443#discussion_r1053935750 ## docs/content/docs/features/table-types.md: ## @@ -0,0 +1,142 @@ +--- +title: "Table Types" +weight: 1 +type: docs +aliases: +- /features/table-types.html +-

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #191: [FLINK-30401] Add Estimator and Transformer for MinHashLSH

2022-12-20 Thread GitBox
zhipeng93 commented on code in PR #191: URL: https://github.com/apache/flink-ml/pull/191#discussion_r1053903196 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/lsh/LSH.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

[GitHub] [flink] fsk119 merged pull request #21433: [hotfix][table-planner] Fix inconsistent test data for temporal join

2022-12-20 Thread GitBox
fsk119 merged PR #21433: URL: https://github.com/apache/flink/pull/21433 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[GitHub] [flink-ml] Fanoid commented on a diff in pull request #192: [FLINK-30451] Add Estimator and Transformer for Swing

2022-12-20 Thread GitBox
Fanoid commented on code in PR #192: URL: https://github.com/apache/flink-ml/pull/192#discussion_r1053957894 ## flink-ml-lib/src/main/java/org/apache/flink/ml/recommendation/Swing.java: ## @@ -0,0 +1,407 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

[GitHub] [flink-ml] Fanoid commented on a diff in pull request #192: [FLINK-30451] Add Estimator and Transformer for Swing

2022-12-20 Thread GitBox
Fanoid commented on code in PR #192: URL: https://github.com/apache/flink-ml/pull/192#discussion_r1053958500 ## flink-ml-lib/src/main/java/org/apache/flink/ml/recommendation/Swing.java: ## @@ -0,0 +1,407 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

[GitHub] [flink-ml] Fanoid commented on a diff in pull request #192: [FLINK-30451] Add Estimator and Transformer for Swing

2022-12-20 Thread GitBox
Fanoid commented on code in PR #192: URL: https://github.com/apache/flink-ml/pull/192#discussion_r1053958500 ## flink-ml-lib/src/main/java/org/apache/flink/ml/recommendation/Swing.java: ## @@ -0,0 +1,407 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

[GitHub] [flink] xintongsong commented on a diff in pull request #21496: [FLINK-29869][ResourceManager] make ResourceAllocator declarative.

2022-12-20 Thread GitBox
xintongsong commented on code in PR #21496: URL: https://github.com/apache/flink/pull/21496#discussion_r1053928976 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/active/ActiveResourceManager.java: ## @@ -206,15 +220,29 @@ protected Optional getWorkerNod

[GitHub] [flink-ml] vacaly commented on a diff in pull request #192: [FLINK-30451] Add Estimator and Transformer for Swing

2022-12-20 Thread GitBox
vacaly commented on code in PR #192: URL: https://github.com/apache/flink-ml/pull/192#discussion_r1053974995 ## flink-ml-lib/src/main/java/org/apache/flink/ml/recommendation/SwingModelData.java: ## @@ -0,0 +1,106 @@ +package org.apache.flink.ml.recommendation; + +import org.apac

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #489: [FLINK-30406] Detect when jobmanager never started

2022-12-20 Thread GitBox
gyfora commented on code in PR #489: URL: https://github.com/apache/flink-kubernetes-operator/pull/489#discussion_r1053989089 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconcilerUpgradeModeTest.java: ## @@ -

[jira] [Created] (FLINK-30468) The SortOrder of BusyRatio should be descend by default

2022-12-20 Thread Rui Fan (Jira)
Rui Fan created FLINK-30468: --- Summary: The SortOrder of BusyRatio should be descend by default Key: FLINK-30468 URL: https://issues.apache.org/jira/browse/FLINK-30468 Project: Flink Issue Type: Bug

[GitHub] [flink] 1996fanrui opened a new pull request, #21540: [FLINK-30468][web] Change the SortOrder of BusyRatio to descend by default

2022-12-20 Thread GitBox
1996fanrui opened a new pull request, #21540: URL: https://github.com/apache/flink/pull/21540 ## What is the purpose of the change Currently, the sort order is ascend by default, it should be descend. The most busy subtask should be displayed on top. ## Brief change log

[jira] [Updated] (FLINK-30468) The SortOrder of BusyRatio should be descend by default

2022-12-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30468: --- Labels: pull-request-available (was: ) > The SortOrder of BusyRatio should be descend by de

[GitHub] [flink] 1996fanrui commented on pull request #21540: [FLINK-30468][web] Change the SortOrder of BusyRatio to descend by default

2022-12-20 Thread GitBox
1996fanrui commented on PR #21540: URL: https://github.com/apache/flink/pull/21540#issuecomment-1360874693 After this PR: 1. The SortOrder of BusyRatio will be the desc by default. https://user-images.githubusercontent.com/38427477/208828005-d902a419-a197-4e55-be00-0b086cf89436

<    1   2   3   >