[jira] [Commented] (FLINK-30641) docs_404_check fail

2023-01-11 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675850#comment-17675850 ] Danny Cranmer commented on FLINK-30641: --- Yes will fix asap > docs_404_check fail

[jira] [Assigned] (FLINK-30641) docs_404_check fail

2023-01-11 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer reassigned FLINK-30641: - Assignee: Danny Cranmer > docs_404_check fail > --- > >

[GitHub] [flink] xintongsong commented on a diff in pull request #21620: [FLINK-30473][network] Optimize the InputGate network memory management for TaskManager

2023-01-11 Thread GitBox
xintongsong commented on code in PR #21620: URL: https://github.com/apache/flink/pull/21620#discussion_r1067771354 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGateFactory.java: ## @@ -75,7 +84,9 @@ public class SingleInputGate

[jira] [Commented] (FLINK-30601) Omit "setKeyContextElement" call for non-keyed stream/operators to improve performance

2023-01-11 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675846#comment-17675846 ] Lijie Wang commented on FLINK-30601: As discussed in [PR21621|https://github.com/apa

[GitHub] [flink] MartijnVisser merged pull request #21632: [hotfix] [docs] Fix minor typo in flink-architecture docs

2023-01-11 Thread GitBox
MartijnVisser merged PR #21632: URL: https://github.com/apache/flink/pull/21632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

[jira] [Commented] (FLINK-30624) Performance regression in stateBackends.FS / FS_ASYNC / MEMORY on 05.01.2023

2023-01-11 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675844#comment-17675844 ] Martijn Visser commented on FLINK-30624: Thank you for picking this up! > Perfo

[jira] [Commented] (FLINK-30641) docs_404_check fail

2023-01-11 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675843#comment-17675843 ] Martijn Visser commented on FLINK-30641: [~danny.cranmer] It looks like this is

[jira] [Commented] (FLINK-30641) docs_404_check fail

2023-01-11 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675842#comment-17675842 ] Lijie Wang commented on FLINK-30641: https://dev.azure.com/apache-flink/apache-flink

[jira] [Updated] (FLINK-30641) docs_404_check fail

2023-01-11 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-30641: --- Component/s: Build System > docs_404_check fail > --- > > Ke

[jira] [Updated] (FLINK-30641) docs_404_check fail

2023-01-11 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-30641: --- Priority: Blocker (was: Major) > docs_404_check fail > --- > >

[jira] [Created] (FLINK-30641) docs_404_check fail

2023-01-11 Thread Lijie Wang (Jira)
Lijie Wang created FLINK-30641: -- Summary: docs_404_check fail Key: FLINK-30641 URL: https://issues.apache.org/jira/browse/FLINK-30641 Project: Flink Issue Type: Bug Reporter: Lijie W

[GitHub] [flink] link3280 commented on pull request #21581: [FLINK-30538][SQL gateway/client] Improve error handling of stop job operation

2023-01-11 Thread GitBox
link3280 commented on PR #21581: URL: https://github.com/apache/flink/pull/21581#issuecomment-1379901326 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] link3280 commented on pull request #21582: [FLINK-28655][SQL gateway] Support show jobs operation in SqlGateway

2023-01-11 Thread GitBox
link3280 commented on PR #21582: URL: https://github.com/apache/flink/pull/21582#issuecomment-1379900760 Thanks a lot! @LadyForest @fsk119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [flink] link3280 commented on pull request #21581: [FLINK-30538][SQL gateway/client] Improve error handling of stop job operation

2023-01-11 Thread GitBox
link3280 commented on PR #21581: URL: https://github.com/apache/flink/pull/21581#issuecomment-1379901076 CI ran into https://issues.apache.org/jira/browse/FLINK-30328. Re-run CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (FLINK-30640) Unstable test in CliClientITCase

2023-01-11 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675837#comment-17675837 ] luoyuxia commented on FLINK-30640: -- It happens  {code:java} CREATE TABLE foo as select

[GitHub] [flink] yuzelin commented on pull request #21502: [FLINK-29950] Refactor ResultSet to an interface

2023-01-11 Thread GitBox
yuzelin commented on PR #21502: URL: https://github.com/apache/flink/pull/21502#issuecomment-1379883129 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Created] (FLINK-30640) Unstable test in CliClientITCase

2023-01-11 Thread yuzelin (Jira)
yuzelin created FLINK-30640: --- Summary: Unstable test in CliClientITCase Key: FLINK-30640 URL: https://issues.apache.org/jira/browse/FLINK-30640 Project: Flink Issue Type: Bug Components:

[GitHub] [flink] zhuzhurk commented on pull request #21621: [FLINK-30601][runtime] Omit "setKeyContextElement" call for non-keyed stream/operators to improve performance

2023-01-11 Thread GitBox
zhuzhurk commented on PR #21621: URL: https://github.com/apache/flink/pull/21621#issuecomment-1379880157 Sorry that we missed something, that it changes the `@PublicEvolving` `AbstractStreamOperator` to implement an `@Internal` `KeyContextHandler`. This is not correct. I had an offli

[GitHub] [flink-table-store] zhangjun0x01 commented on a diff in pull request #471: [FLINK-30608] support rename table

2023-01-11 Thread GitBox
zhangjun0x01 commented on code in PR #471: URL: https://github.com/apache/flink-table-store/pull/471#discussion_r1067751874 ## flink-table-store-hive/flink-table-store-hive-catalog/src/test/java/org/apache/flink/table/store/hive/HiveCatalogITCase.java: ## @@ -276,6 +279,36 @@ pu

[jira] [Closed] (FLINK-28655) Support show jobs statement in SqlGatewayService

2023-01-11 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang closed FLINK-28655. - Fix Version/s: 1.17.0 Resolution: Implemented Merged into master: f1770892c5b8bce408093fc

[jira] [Assigned] (FLINK-28655) Support show jobs statement in SqlGatewayService

2023-01-11 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang reassigned FLINK-28655: - Assignee: Paul Lin > Support show jobs statement in SqlGatewayService > ---

[GitHub] [flink] reswqa commented on a diff in pull request #21603: [FLINK-30332] HsFileDataIndex supports caching and spilling index entry

2023-01-11 Thread GitBox
reswqa commented on code in PR #21603: URL: https://github.com/apache/flink/pull/21603#discussion_r1067743909 ## flink-core/src/main/java/org/apache/flink/configuration/NettyShuffleEnvironmentOptions.java: ## @@ -270,6 +270,24 @@ public class NettyShuffleEnvironmentOptions {

[GitHub] [flink] fsk119 merged pull request #21582: [FLINK-28655][SQL gateway] Support show jobs operation in SqlGateway

2023-01-11 Thread GitBox
fsk119 merged PR #21582: URL: https://github.com/apache/flink/pull/21582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[GitHub] [flink] fsk119 commented on a diff in pull request #21640: [FLINK-19883][table] Support "IF EXISTS" in DDL for ALTER TABLE

2023-01-11 Thread GitBox
fsk119 commented on code in PR #21640: URL: https://github.com/apache/flink/pull/21640#discussion_r1067731513 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/SqlToOperationConverter.java: ## @@ -480,6 +481,9 @@ private Operation convert

[GitHub] [flink] LadyForest commented on pull request #21582: [FLINK-28655][SQL gateway] Support show jobs operation in SqlGateway

2023-01-11 Thread GitBox
LadyForest commented on PR #21582: URL: https://github.com/apache/flink/pull/21582#issuecomment-1379863608 Thanks for the update; looks good to me too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [flink] yuzelin commented on pull request #21502: [FLINK-29950] Refactor ResultSet to an interface

2023-01-11 Thread GitBox
yuzelin commented on PR #21502: URL: https://github.com/apache/flink/pull/21502#issuecomment-1379830165 > @yuzelin I add a commit to improve some codes. Could you take a look? LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink] fsk119 commented on pull request #21502: [FLINK-29950] Refactor ResultSet to an interface

2023-01-11 Thread GitBox
fsk119 commented on PR #21502: URL: https://github.com/apache/flink/pull/21502#issuecomment-1379827990 @yuzelin I add a commit to improve some codes. Could you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #475: [FLINK-30620] Table Store Hive catalog supports specifying custom Hive metastore client

2023-01-11 Thread GitBox
tsreaper commented on code in PR #475: URL: https://github.com/apache/flink-table-store/pull/475#discussion_r1067702513 ## docs/content/docs/how-to/creating-catalogs.md: ## @@ -31,6 +31,8 @@ Table Store catalogs currently support two types of metastores: * `filesystem` metasto

[GitHub] [flink] flinkbot commented on pull request #21653: [FLINK-27640][Connector/Hive][SQL Client] Exclude Pentaho dependency

2023-01-11 Thread GitBox
flinkbot commented on PR #21653: URL: https://github.com/apache/flink/pull/21653#issuecomment-1379796470 ## CI report: * 7837002efcc8e4ea8d55f99517d043dce9d14700 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #475: [FLINK-30620] Table Store Hive catalog supports specifying custom Hive metastore client

2023-01-11 Thread GitBox
JingsongLi commented on code in PR #475: URL: https://github.com/apache/flink-table-store/pull/475#discussion_r1067684753 ## flink-table-store-hive/flink-table-store-hive-catalog/src/main/java/org/apache/flink/table/store/hive/HiveCatalog.java: ## @@ -408,12 +411,16 @@ private L

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #475: [FLINK-30620] Table Store Hive catalog supports specifying custom Hive metastore client

2023-01-11 Thread GitBox
JingsongLi commented on code in PR #475: URL: https://github.com/apache/flink-table-store/pull/475#discussion_r1067684246 ## docs/content/docs/how-to/creating-catalogs.md: ## @@ -31,6 +31,8 @@ Table Store catalogs currently support two types of metastores: * `filesystem` metas

[GitHub] [flink] chenqin commented on pull request #21653: [FLINK-27640][Connector/Hive][SQL Client] Exclude Pentaho dependency

2023-01-11 Thread GitBox
chenqin commented on PR #21653: URL: https://github.com/apache/flink/pull/21653#issuecomment-1379793620 @MartijnVisser please help review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [flink] chenqin opened a new pull request, #21653: [FLINK-27640][Connector/Hive][SQL Client] Exclude Pentaho dependency

2023-01-11 Thread GitBox
chenqin opened a new pull request, #21653: URL: https://github.com/apache/flink/pull/21653 ## What is the purpose of the change - exclude unused package causing maven 3.8.6 build failure ## Brief change log - exclude unused package causing maven 3.8.6 build failure

[jira] [Commented] (FLINK-30624) Performance regression in stateBackends.FS / FS_ASYNC / MEMORY on 05.01.2023

2023-01-11 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675801#comment-17675801 ] Lijie Wang commented on FLINK-30624: [~masteryhx] I 'll take a look. > Performance

[jira] [Updated] (FLINK-30637) In linux-aarch64 environment, using “is” judgment to match the window type of overwindow have returned incorrect matching results

2023-01-11 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xin Chen updated FLINK-30637: - Description: In  linux-arch64 environment, “window_type is OverWindow.ROW_UNBOUNDED_FOLLOWING” in  in t

[jira] [Closed] (FLINK-20988) Various resource allocation improvements for active resource managers

2023-01-11 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song closed FLINK-20988. Resolution: Done > Various resource allocation improvements for active resource managers > ---

[jira] [Closed] (FLINK-18229) Pending worker requests should be properly cleared

2023-01-11 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song closed FLINK-18229. Resolution: Done master (1.17): f611ea8cb5deddb42429df2c99f0c68d7382e9bd > Pending worker request

[GitHub] [flink] xintongsong closed pull request #21565: [FLINK-18229][ResourceManager] Support cancel pending workers if no longer needed.

2023-01-11 Thread GitBox
xintongsong closed pull request #21565: [FLINK-18229][ResourceManager] Support cancel pending workers if no longer needed. URL: https://github.com/apache/flink/pull/21565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[jira] [Comment Edited] (FLINK-30624) Performance regression in stateBackends.FS / FS_ASYNC / MEMORY on 05.01.2023

2023-01-11 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675791#comment-17675791 ] Hangxiang Yu edited comment on FLINK-30624 at 1/12/23 3:08 AM: ---

[jira] [Comment Edited] (FLINK-30624) Performance regression in stateBackends.FS / FS_ASYNC / MEMORY on 05.01.2023

2023-01-11 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675791#comment-17675791 ] Hangxiang Yu edited comment on FLINK-30624 at 1/12/23 3:08 AM: ---

[jira] [Comment Edited] (FLINK-30624) Performance regression in stateBackends.FS / FS_ASYNC / MEMORY on 05.01.2023

2023-01-11 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675791#comment-17675791 ] Hangxiang Yu edited comment on FLINK-30624 at 1/12/23 3:07 AM: ---

[jira] [Commented] (FLINK-30624) Performance regression in stateBackends.FS / FS_ASYNC / MEMORY on 05.01.2023

2023-01-11 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675791#comment-17675791 ] Hangxiang Yu commented on FLINK-30624: -- I guess the regression is caused by FLINK-3

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #471: [FLINK-30608] support rename table

2023-01-11 Thread GitBox
JingsongLi commented on code in PR #471: URL: https://github.com/apache/flink-table-store/pull/471#discussion_r1067644795 ## flink-table-store-hive/flink-table-store-hive-catalog/src/test/java/org/apache/flink/table/store/hive/HiveCatalogITCase.java: ## @@ -276,6 +279,36 @@ publ

[GitHub] [flink] yuchuanchen commented on a diff in pull request #21563: [FLINK-19889][connectors/hive/filesystem][format/parquet] Supports nested projection pushdown for filesystem connector of colum

2023-01-11 Thread GitBox
yuchuanchen commented on code in PR #21563: URL: https://github.com/apache/flink/pull/21563#discussion_r1067641230 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableSourceITCase.java: ## @@ -447,6 +447,51 @@ public void testProjecti

[jira] [Commented] (FLINK-30168) PyFlink Deserialization Error with Object Array

2023-01-11 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675779#comment-17675779 ] Dian Fu commented on FLINK-30168: - [~yunfengzhou] Thanks a lot (y) > PyFlink Deserializ

[GitHub] [flink] swuferhong commented on a diff in pull request #20822: [FLINK-25447][table-planner] Fix batch query cannot generate plan when a sorted view into multi sinks

2023-01-11 Thread GitBox
swuferhong commented on code in PR #20822: URL: https://github.com/apache/flink/pull/20822#discussion_r1067632577 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/schema/IntermediateRelTable.scala: ## @@ -54,4 +55,19 @@ class IntermediateRelT

[jira] [Comment Edited] (FLINK-30419) Allow tuning of transaction timeout

2023-01-11 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675774#comment-17675774 ] Jingsong Lee edited comment on FLINK-30419 at 1/12/23 2:03 AM: ---

[jira] [Comment Edited] (FLINK-30419) Allow tuning of transaction timeout

2023-01-11 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675774#comment-17675774 ] Jingsong Lee edited comment on FLINK-30419 at 1/12/23 2:03 AM: ---

[jira] [Commented] (FLINK-30419) Allow tuning of transaction timeout

2023-01-11 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675774#comment-17675774 ] Jingsong Lee commented on FLINK-30419: -- CC [~renqs] > Allow tuning of transaction

[jira] [Commented] (FLINK-30419) Allow tuning of transaction timeout

2023-01-11 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675773#comment-17675773 ] Jingsong Lee commented on FLINK-30419: -- [~Ge] Nice investigation! > It would b

[GitHub] [flink] swuferhong commented on a diff in pull request #20822: [FLINK-25447][table-planner] Fix batch query cannot generate plan when a sorted view into multi sinks

2023-01-11 Thread GitBox
swuferhong commented on code in PR #20822: URL: https://github.com/apache/flink/pull/20822#discussion_r1067630694 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/metadata/FlinkRelMdDistribution.scala: ## @@ -87,6 +87,10 @@ class FlinkRelMdDi

[GitHub] [flink] yuchuanchen commented on a diff in pull request #21563: [FLINK-19889][connectors/hive/filesystem][format/parquet] Supports nested projection pushdown for filesystem connector of colum

2023-01-11 Thread GitBox
yuchuanchen commented on code in PR #21563: URL: https://github.com/apache/flink/pull/21563#discussion_r1067625428 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java: ## @@ -282,12 +296,37 @@ public void applyDynamicFilte

[jira] [Commented] (FLINK-30168) PyFlink Deserialization Error with Object Array

2023-01-11 Thread Yunfeng Zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675771#comment-17675771 ] Yunfeng Zhou commented on FLINK-30168: -- Thanks for the reminding. Here are the code

[GitHub] [flink] yuchuanchen commented on a diff in pull request #21563: [FLINK-19889][connectors/hive/filesystem][format/parquet] Supports nested projection pushdown for filesystem connector of colum

2023-01-11 Thread GitBox
yuchuanchen commented on code in PR #21563: URL: https://github.com/apache/flink/pull/21563#discussion_r1067621995 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/FileSystemTableSource.java: ## @@ -340,7 +342,17 @@ public void applyP

[jira] [Commented] (FLINK-30419) Allow tuning of transaction timeout

2023-01-11 Thread Alex Sorokoumov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675768#comment-17675768 ] Alex Sorokoumov commented on FLINK-30419: - Thank you for the feedback [~lzljs362

[GitHub] [flink] yuchuanchen commented on a diff in pull request #21563: [FLINK-19889][connectors/hive/filesystem][format/parquet] Supports nested projection pushdown for filesystem connector of colum

2023-01-11 Thread GitBox
yuchuanchen commented on code in PR #21563: URL: https://github.com/apache/flink/pull/21563#discussion_r1067613269 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableSourceITCase.java: ## @@ -447,6 +447,51 @@ public void testProjecti

[GitHub] [flink] hlteoh37 commented on pull request #20257: [FLINK-24943][Connectors / Kinesis] Explicitly create KryoSerializer for SequenceNumber class in Kinesis Consumer

2023-01-11 Thread GitBox
hlteoh37 commented on PR #20257: URL: https://github.com/apache/flink/pull/20257#issuecomment-1379661435 We have now moved the consumer here https://github.com/apache/flink-connector-aws -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] Cyberness commented on pull request #20257: [FLINK-24943][Connectors / Kinesis] Explicitly create KryoSerializer for SequenceNumber class in Kinesis Consumer

2023-01-11 Thread GitBox
Cyberness commented on PR #20257: URL: https://github.com/apache/flink/pull/20257#issuecomment-1379570234 Does it still make sense to work on merging this change considering [FLINK-30557](https://github.com/apache/flink/pull/21600)? -- This is an automated message from the Apache Git Serv

[jira] [Resolved] (FLINK-30375) SqlClient leaks flink-table-planner jar under /tmp

2023-01-11 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer resolved FLINK-30375. --- Resolution: Fixed > SqlClient leaks flink-table-planner jar under /tmp > ---

[jira] [Commented] (FLINK-30375) SqlClient leaks flink-table-planner jar under /tmp

2023-01-11 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675720#comment-17675720 ] Danny Cranmer commented on FLINK-30375: --- Merged commit [{{086f13a}}|https://githu

[GitHub] [flink] dannycranmer merged pull request #21512: [FLINK-30375][hotfix]sql-client leaks flink-table-planner jar in /tmp

2023-01-11 Thread GitBox
dannycranmer merged PR #21512: URL: https://github.com/apache/flink/pull/21512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

[GitHub] [flink] dannycranmer commented on pull request #21512: [FLINK-30375][hotfix]sql-client leaks flink-table-planner jar in /tmp

2023-01-11 Thread GitBox
dannycranmer commented on PR #21512: URL: https://github.com/apache/flink/pull/21512#issuecomment-1379472454 The commit message does not need `hotfix` if you have a Jira, will rewrite on merge -- This is an automated message from the Apache Git Service. To respond to the message, please l

[jira] [Updated] (FLINK-30375) SqlClient leaks flink-table-planner jar under /tmp

2023-01-11 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-30375: -- Fix Version/s: 1.17.0 > SqlClient leaks flink-table-planner jar under /tmp > -

[jira] [Commented] (FLINK-30618) flink-connector-pulsar not retrievable from Apache's Snapshot Maven repository

2023-01-11 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675714#comment-17675714 ] Yufan Sheng commented on FLINK-30618: - [~martijnvisser] I found that the Pulsar's {{

[jira] [Comment Edited] (FLINK-30609) Add ephemeral storage to CRD

2023-01-11 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675675#comment-17675675 ] Mason Chen edited comment on FLINK-30609 at 1/11/23 6:49 PM: -

[jira] [Commented] (FLINK-30609) Add ephemeral storage to CRD

2023-01-11 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675675#comment-17675675 ] Mason Chen commented on FLINK-30609: +1 as well to make configuring it easier > Add

[jira] [Commented] (FLINK-18356) flink-table-planner Exit code 137 returned from process

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675657#comment-17675657 ] Matthias Pohl commented on FLINK-18356: --- Not sure whether you did this already but

[GitHub] [flink] wanglijie95 commented on pull request #21626: [FLINK-30604][runtime] Remove the limitation that parallelism decided by adaptive batch scheduler is always a power of two

2023-01-11 Thread GitBox
wanglijie95 commented on PR #21626: URL: https://github.com/apache/flink/pull/21626#issuecomment-1379132765 @zhuzhurk Thanks for review. I 've addressed your comment, please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink] RyanSkraba commented on a diff in pull request #21648: [FLINK-30636] [docs]: Typo fix; 'to to' -> 'to'

2023-01-11 Thread GitBox
RyanSkraba commented on code in PR #21648: URL: https://github.com/apache/flink/pull/21648#discussion_r1067215558 ## flink-runtime/src/main/java/org/apache/flink/runtime/execution/Environment.java: ## @@ -186,7 +186,7 @@ public interface Environment { TaskKvStateRegistry ge

[GitHub] [flink] flinkbot commented on pull request #21652: [FLINK-30633][Connectors/AWS] Update AWS SDKv2 to v2.19.14 for 1.16

2023-01-11 Thread GitBox
flinkbot commented on PR #21652: URL: https://github.com/apache/flink/pull/21652#issuecomment-1379086390 ## CI report: * 33bcb8cf3a805408a07c7684e6e9d6f51f1d3308 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #21651: [FLINK-30633][Connectors/AWS] Update AWS SDKv2 to v2.19.14 for 1.15

2023-01-11 Thread GitBox
flinkbot commented on PR #21651: URL: https://github.com/apache/flink/pull/21651#issuecomment-1379086078 ## CI report: * 415e1e5bc573ea5748ea4e3db12c0aa5a8bd58da UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #21650: [FLINK-30633][Connectors/AWS] Update AWS SDKv2 to v2.19.14 for Flink 1.17

2023-01-11 Thread GitBox
flinkbot commented on PR #21650: URL: https://github.com/apache/flink/pull/21650#issuecomment-1379085758 ## CI report: * fe606d5ac87d3a35e7b0b90bda2a7380e64321f5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Reopened] (FLINK-27640) Flink not compiling, flink-connector-hive_2.12 is missing jhyde pentaho-aggdesigner-algorithm:jar:5.1.5-jhyde

2023-01-11 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reopened FLINK-27640: Re-opening because pentaho still appears in the dependency tree, probably an exclusion was mi

[jira] [Commented] (FLINK-30618) flink-connector-pulsar not retrievable from Apache's Snapshot Maven repository

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675641#comment-17675641 ] Matthias Pohl commented on FLINK-30618: --- Ok, after looking into the AzureCI cachin

[GitHub] [flink] dannycranmer opened a new pull request, #21652: [FLINK-30633][Connectors/AWS] Update AWS SDKv2 to v2.19.14 for 1.16

2023-01-11 Thread GitBox
dannycranmer opened a new pull request, #21652: URL: https://github.com/apache/flink/pull/21652 ## What is the purpose of the change Update AWS SDKv2 to v2.19.14 ## Brief change log - Update AWS SDKv2 to v2.19.14 - Update NOTICE files ## Verifying this change

[jira] [Comment Edited] (FLINK-30618) flink-connector-pulsar not retrievable from Apache's Snapshot Maven repository

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17672280#comment-17672280 ] Matthias Pohl edited comment on FLINK-30618 at 1/11/23 4:21 PM: --

[GitHub] [flink] lsyldliu commented on a diff in pull request #21586: [FLINK-30542][table-runtime] Introduce adaptive hash aggregate to adaptively determine whether local hash aggregate is required at

2023-01-11 Thread GitBox
lsyldliu commented on code in PR #21586: URL: https://github.com/apache/flink/pull/21586#discussion_r1067180556 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/GenerateUtils.scala: ## @@ -611,6 +611,32 @@ object GenerateUtils { gen

[GitHub] [flink] dannycranmer opened a new pull request, #21651: [FLINK-30633][Connectors/AWS] Update AWS SDKv2 to v2.19.14 for 1.15

2023-01-11 Thread GitBox
dannycranmer opened a new pull request, #21651: URL: https://github.com/apache/flink/pull/21651 ## What is the purpose of the change Update AWS SDKv2 to v2.19.14 ## Brief change log - Update AWS SDKv2 to v2.19.14 - Update NOTICE files ## Verifying this change

[jira] [Updated] (FLINK-30633) Update AWS SDKv2 to v2.19.14

2023-01-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30633: --- Labels: pull-request-available (was: ) > Update AWS SDKv2 to v2.19.14 > ---

[GitHub] [flink] dannycranmer opened a new pull request, #21650: [FLINK-30633][Connectors/AWS] Update AWS SDKv2 to v2.19.14 for Flink 1.17

2023-01-11 Thread GitBox
dannycranmer opened a new pull request, #21650: URL: https://github.com/apache/flink/pull/21650 ## What is the purpose of the change Update AWS SDKv2 to v2.19.14 ## Brief change log - Update AWS SDKv2 to v2.19.14 ## Verifying this change This change is a tri

[jira] [Updated] (FLINK-30638) Operator doesn't forward allowNonRestoredState flag

2023-01-11 Thread Alexis Sarda-Espinosa (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexis Sarda-Espinosa updated FLINK-30638: -- Priority: Minor (was: Critical) > Operator doesn't forward allowNonRestoredSt

[jira] [Commented] (FLINK-30638) Operator doesn't forward allowNonRestoredState flag

2023-01-11 Thread Alexis Sarda-Espinosa (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675635#comment-17675635 ] Alexis Sarda-Espinosa commented on FLINK-30638: --- All right, thanks. I unde

[GitHub] [flink] lsyldliu commented on a diff in pull request #21608: [FLINK-29721][hive] Supports native hive min function for hive dialect

2023-01-11 Thread GitBox
lsyldliu commented on code in PR #21608: URL: https://github.com/apache/flink/pull/21608#discussion_r1067164508 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/module/hive/HiveModule.java: ## @@ -81,6 +82,18 @@ public class HiveModule implements Mod

[GitHub] [flink] lsyldliu commented on pull request #21621: [FLINK-30601][runtime] Omit "setKeyContextElement" call for non-keyed stream/operators to improve performance

2023-01-11 Thread GitBox
lsyldliu commented on PR #21621: URL: https://github.com/apache/flink/pull/21621#issuecomment-1378997835 Thanks for the PR. LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[jira] [Commented] (FLINK-30638) Operator doesn't forward allowNonRestoredState flag

2023-01-11 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675628#comment-17675628 ] Gyula Fora commented on FLINK-30638: Yes, you could do that and that will work. Or y

[GitHub] [flink] lsyldliu commented on pull request #21629: [FLINK-30579][hive] Introducing cofigurable option to enable hive native function

2023-01-11 Thread GitBox
lsyldliu commented on PR #21629: URL: https://github.com/apache/flink/pull/21629#issuecomment-1378972197 @luoyuxia Thanks for review, I've address your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (FLINK-30638) Operator doesn't forward allowNonRestoredState flag

2023-01-11 Thread Alexis Sarda-Espinosa (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675626#comment-17675626 ] Alexis Sarda-Espinosa commented on FLINK-30638: --- I see. Do you know if thi

[GitHub] [flink] lsyldliu commented on a diff in pull request #21629: [FLINK-30579][hive] Introducing cofigurable option to enable hive native function

2023-01-11 Thread GitBox
lsyldliu commented on code in PR #21629: URL: https://github.com/apache/flink/pull/21629#discussion_r1067137848 ## flink-table/flink-sql-gateway-api/src/main/java/org/apache/flink/table/gateway/api/session/FunctionCreator.java: ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache

[jira] [Created] (FLINK-30639) Publish SBOM for externalized connectors

2023-01-11 Thread Jira
Márton Balassi created FLINK-30639: -- Summary: Publish SBOM for externalized connectors Key: FLINK-30639 URL: https://issues.apache.org/jira/browse/FLINK-30639 Project: Flink Issue Type: Sub-

[jira] [Commented] (FLINK-30638) Operator doesn't forward allowNonRestoredState flag

2023-01-11 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675618#comment-17675618 ] Gyula Fora commented on FLINK-30638: Yes, we set the right configuration but allowNo

[GitHub] [flink] lincoln-lil commented on pull request #21641: [FLINK-30006][table-planner](do not merge) Make all pure dynamic functions non-deterministic in streaming mode to avoid wrong plans

2023-01-11 Thread GitBox
lincoln-lil commented on PR #21641: URL: https://github.com/apache/flink/pull/21641#issuecomment-1378911392 @XComp thank you very much for the warm tips!I'll try it later : ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[jira] [Commented] (FLINK-30638) Operator doesn't forward allowNonRestoredState flag

2023-01-11 Thread Alexis Sarda-Espinosa (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675616#comment-17675616 ] Alexis Sarda-Espinosa commented on FLINK-30638: --- When you say the flag is

[GitHub] [flink] lsyldliu commented on a diff in pull request #21629: [FLINK-30579][hive] Introducing cofigurable option to enable hive native function

2023-01-11 Thread GitBox
lsyldliu commented on code in PR #21629: URL: https://github.com/apache/flink/pull/21629#discussion_r1067108838 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveSumAggFunction.java: ## @@ -125,10 +126,16 @@ private DataType initRes

[GitHub] [flink] flinkbot commented on pull request #21649: [FLINK-30637] [Python] Try to replace 'is' with '==' to ensure matching the window type of overwindow correctly

2023-01-11 Thread GitBox
flinkbot commented on PR #21649: URL: https://github.com/apache/flink/pull/21649#issuecomment-1378889919 ## CI report: * 6b9de752d2f4bb951c7411b449b4892578bad93e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] lincoln-lil commented on a diff in pull request #21546: [FLINK-30477][datastream] Fix AsyncWaitOperator that not properly blocking retries when timeout occurs

2023-01-11 Thread GitBox
lincoln-lil commented on code in PR #21546: URL: https://github.com/apache/flink/pull/21546#discussion_r1067076982 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/async/AsyncWaitOperator.java: ## @@ -443,33 +445,53 @@ public RetryableResultHandlerD

[jira] [Commented] (FLINK-18356) flink-table-planner Exit code 137 returned from process

2023-01-11 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675609#comment-17675609 ] Yunhong Zheng commented on FLINK-18356: --- Hi, [~martijnvisser] and all. [~godfrey] 

[jira] [Commented] (FLINK-29427) LookupJoinITCase failed with classloader problem

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675605#comment-17675605 ] Matthias Pohl commented on FLINK-29427: --- [~renqs] is planning to pick up on that o

[jira] [Commented] (FLINK-30108) ZooKeeperLeaderElectionConnectionHandlingTest.testLoseLeadershipOnLostConnectionIfTolerateSuspendedConnectionsIsEnabled times out

2023-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675603#comment-17675603 ] Matthias Pohl commented on FLINK-30108: --- yes, I thought the same. It might be some

[jira] [Updated] (FLINK-18356) flink-table-planner Exit code 137 returned from process

2023-01-11 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yunhong Zheng updated FLINK-18356: -- Attachment: image-2023-01-11-22-21-57-784.png > flink-table-planner Exit code 137 returned fro

[jira] [Updated] (FLINK-18356) flink-table-planner Exit code 137 returned from process

2023-01-11 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yunhong Zheng updated FLINK-18356: -- Attachment: image-2023-01-11-22-22-32-124.png > flink-table-planner Exit code 137 returned fro

  1   2   3   >