[GitHub] [flink] fsk119 commented on a diff in pull request #21665: [FLINK-30675][sql-client] Decompose query result print from Executor

2023-01-16 Thread GitBox
fsk119 commented on code in PR #21665: URL: https://github.com/apache/flink/pull/21665#discussion_r1071869840 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliView.java: ## @@ -361,25 +364,52 @@ protected int getHeight() { return height

[GitHub] [flink] fsk119 commented on a diff in pull request #21665: [FLINK-30675][sql-client] Decompose query result print from Executor

2023-01-16 Thread GitBox
fsk119 commented on code in PR #21665: URL: https://github.com/apache/flink/pull/21665#discussion_r1071869134 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/result/CollectResultBase.java: ## @@ -29,23 +29,28 @@ /** A result that work

[GitHub] [flink] 1996fanrui commented on pull request #21690: [FLINK-30623][runtime][bug] The canEmitBatchOfRecords should check recordWriter and changelogWriterAvailabilityProvider are available

2023-01-16 Thread GitBox
1996fanrui commented on PR #21690: URL: https://github.com/apache/flink/pull/21690#issuecomment-1384981749 > Hi @1996fanrui, yes I agree we should use Supplier canEmitBatchOfRecords. > > I believe `canEmitBatchOfRecords` can be passed to `SourceOperator` similar to how `mailboxHasMail

[jira] [Closed] (FLINK-30710) Fix invalid field id for nested type in spark catalog

2023-01-16 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-30710. Fix Version/s: table-store-0.4.0 Assignee: Shammon Resolution: Fixed master: 6fb52

[GitHub] [flink] luoyuxia commented on a diff in pull request #21676: [FLINK-30662][table] Planner supports delete

2023-01-16 Thread GitBox
luoyuxia commented on code in PR #21676: URL: https://github.com/apache/flink/pull/21676#discussion_r1071864297 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/batch/sql/DeleteTableITCase.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the A

[GitHub] [flink-table-store] JingsongLi merged pull request #486: [FLINK-30710] Fix invalid field id for nested type in spark catalog

2023-01-16 Thread GitBox
JingsongLi merged PR #486: URL: https://github.com/apache/flink-table-store/pull/486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[jira] [Assigned] (FLINK-30711) Support dropping partition via Flink action

2023-01-16 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee reassigned FLINK-30711: Assignee: yuzelin > Support dropping partition via Flink action > ---

[GitHub] [flink] fsk119 commented on a diff in pull request #21665: [FLINK-30675][sql-client] Decompose query result print from Executor

2023-01-16 Thread GitBox
fsk119 commented on code in PR #21665: URL: https://github.com/apache/flink/pull/21665#discussion_r1071859452 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java: ## @@ -75,15 +69,13 @@ public class LocalExecutor implement

[GitHub] [flink] xuyangzhong commented on a diff in pull request #21665: [FLINK-30675][sql-client] Decompose query result print from Executor

2023-01-16 Thread GitBox
xuyangzhong commented on code in PR #21665: URL: https://github.com/apache/flink/pull/21665#discussion_r1071820866 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/ResultDescriptor.java: ## @@ -20,46 +20,66 @@ import org.apache.flink.api.com

[GitHub] [flink] HuangXingBo closed pull request #21380: [FLINK-30169][python][doc] Adds switcher.json file

2023-01-16 Thread GitBox
HuangXingBo closed pull request #21380: [FLINK-30169][python][doc] Adds switcher.json file URL: https://github.com/apache/flink/pull/21380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[jira] [Commented] (FLINK-30508) CliClientITCase.testSqlStatements failed with output not matched with expected

2023-01-16 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677640#comment-17677640 ] Shengkai Fang commented on FLINK-30508: --- Sorry for the late response. I will take

[jira] [Assigned] (FLINK-30508) CliClientITCase.testSqlStatements failed with output not matched with expected

2023-01-16 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang reassigned FLINK-30508: - Assignee: Shengkai Fang > CliClientITCase.testSqlStatements failed with output not matc

[jira] [Resolved] (FLINK-30637) In linux-aarch64 environment, using “is” judgment to match the window type of overwindow have returned incorrect matching results

2023-01-16 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huang Xingbo resolved FLINK-30637. -- Fix Version/s: 1.16.1 1.15.4 Assignee: Xin Chen Resolution:

[GitHub] [flink] flinkbot commented on pull request #21701: [FLINK-30128][doc][azure-fs] Update documentation for streaming file …

2023-01-16 Thread GitBox
flinkbot commented on PR #21701: URL: https://github.com/apache/flink/pull/21701#issuecomment-1384930283 ## CI report: * 44ccbc37c1235fa9459baf9f3eb86c6c4a7d1668 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-29421) Support python 3.10

2023-01-16 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huang Xingbo updated FLINK-29421: - Fix Version/s: 1.17.0 > Support python 3.10 > --- > > Key: FLINK

[jira] [Assigned] (FLINK-29421) Support python 3.10

2023-01-16 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huang Xingbo reassigned FLINK-29421: Assignee: Huang Xingbo > Support python 3.10 > --- > > Ke

[GitHub] [flink] xintongsong opened a new pull request, #21701: [FLINK-30128][doc][azure-fs] Update documentation for streaming file …

2023-01-16 Thread GitBox
xintongsong opened a new pull request, #21701: URL: https://github.com/apache/flink/pull/21701 …sink ABFS support. ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way w

[GitHub] [flink] HuangXingBo closed pull request #21649: [FLINK-30637] [Python] Try to replace 'is' with '==' to ensure matching the window type of overwindow correctly

2023-01-16 Thread GitBox
HuangXingBo closed pull request #21649: [FLINK-30637] [Python] Try to replace 'is' with '==' to ensure matching the window type of overwindow correctly URL: https://github.com/apache/flink/pull/21649 -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [flink] flinkbot commented on pull request #21700: [FLINK-30677][Test] Fix unstable SqlGatewayServiceStatementITCase.testFlinkSqlStatements

2023-01-16 Thread GitBox
flinkbot commented on PR #21700: URL: https://github.com/apache/flink/pull/21700#issuecomment-1384918983 ## CI report: * 602ab508ca70bbe63c0dc47cd16c78925a8cc0b5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #21699: [FLINK-29421][python] Support python 3.10

2023-01-16 Thread GitBox
flinkbot commented on PR #21699: URL: https://github.com/apache/flink/pull/21699#issuecomment-1384918897 ## CI report: * cd5e2c478e213f32b4031d46ca15829548aff8fe UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] link3280 commented on pull request #21700: [FLINK-30677][Test] Fix unstable SqlGatewayServiceStatementITCase.testFlinkSqlStatements

2023-01-16 Thread GitBox
link3280 commented on PR #21700: URL: https://github.com/apache/flink/pull/21700#issuecomment-1384918159 cc @XComp @fsk119 @yuzelin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[jira] [Updated] (FLINK-30677) SqlGatewayServiceStatementITCase.testFlinkSqlStatements fails

2023-01-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30677: --- Labels: pull-request-available test-stability (was: test-stability) > SqlGatewayServiceStat

[GitHub] [flink] link3280 opened a new pull request, #21700: [FLINK-30677][Test] Fix unstable SqlGatewayServiceStatementITCase.testFlinkSqlStatements

2023-01-16 Thread GitBox
link3280 opened a new pull request, #21700: URL: https://github.com/apache/flink/pull/21700 ## What is the purpose of the change SqlGatewayServiceStatementITCase.testFlinkSqlStatements may fail due to `java.util.NoSuchElementException`. The cause is unsecured access to iterators in t

[jira] [Updated] (FLINK-29421) Support python 3.10

2023-01-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29421: --- Labels: pull-request-available (was: ) > Support python 3.10 > --- > >

[GitHub] [flink] HuangXingBo opened a new pull request, #21699: [FLINK-29421][python] Support python 3.10

2023-01-16 Thread GitBox
HuangXingBo opened a new pull request, #21699: URL: https://github.com/apache/flink/pull/21699 ## Contribution Checklist ## What is the purpose of the change *This pull request will support python 3.10* ## Brief change log - *Update `pemja` to `0.3.0`* -

[GitHub] [flink] flinkbot commented on pull request #21698: [FLINK-30665][table] Planner supports row-level update

2023-01-16 Thread GitBox
flinkbot commented on PR #21698: URL: https://github.com/apache/flink/pull/21698#issuecomment-1384915235 ## CI report: * 863dbb9c5013c425b4dd998b5a5092b7ccd8316e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30712) Update network memory configuration docs

2023-01-16 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan updated FLINK-30712: -- Description: After [FLINK-30469|https://issues.apache.org/jira/browse/FLINK-30469], the network memor

[jira] [Assigned] (FLINK-30712) Update network memory configuration docs

2023-01-16 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan reassigned FLINK-30712: - Assignee: Yuxin Tan > Update network memory configuration docs > -

[jira] [Created] (FLINK-30712) Update network memory configuration docs

2023-01-16 Thread Yuxin Tan (Jira)
Yuxin Tan created FLINK-30712: - Summary: Update network memory configuration docs Key: FLINK-30712 URL: https://issues.apache.org/jira/browse/FLINK-30712 Project: Flink Issue Type: Improvement

[jira] [Updated] (FLINK-30665) Add implementation for Update

2023-01-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30665: --- Labels: pull-request-available (was: ) > Add implementation for Update > --

[GitHub] [flink] luoyuxia opened a new pull request, #21698: [FLINK-30665][table] Planner supports row-level update

2023-01-16 Thread GitBox
luoyuxia opened a new pull request, #21698: URL: https://github.com/apache/flink/pull/21698 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them o

[jira] [Created] (FLINK-30711) Support dropping partition via Flink action

2023-01-16 Thread yuzelin (Jira)
yuzelin created FLINK-30711: --- Summary: Support dropping partition via Flink action Key: FLINK-30711 URL: https://issues.apache.org/jira/browse/FLINK-30711 Project: Flink Issue Type: New Feature

[GitHub] [flink] lindong28 commented on pull request #21690: [FLINK-30623][runtime][bug] The canEmitBatchOfRecords should check recordWriter and changelogWriterAvailabilityProvider are available

2023-01-16 Thread GitBox
lindong28 commented on PR #21690: URL: https://github.com/apache/flink/pull/21690#issuecomment-1384903316 Hi @1996fanrui, yes I agree we should use Supplier canEmitBatchOfRecords. I believe `canEmitBatchOfRecords` can be passed to `SourceOperator` similar to how `mailboxHasMail ` is

[jira] [Commented] (FLINK-30533) SourceOperator#emitNext() should push records to DataOutput in a while loop

2023-01-16 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677629#comment-17677629 ] Yun Tang commented on FLINK-30533: -- [~lindong] Thanks for the feedback and we can see t

[jira] [Reopened] (FLINK-29351) Enable input buffer floating for blocking shuffle

2023-01-16 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song reopened FLINK-29351: -- > Enable input buffer floating for blocking shuffle >

[jira] [Commented] (FLINK-30601) Omit "setKeyContextElement" call for non-keyed stream/operators to improve performance

2023-01-16 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677626#comment-17677626 ] Lijie Wang commented on FLINK-30601: Done via master 4e3cd986cd4304c699d5c7d368ffd6e

[jira] [Closed] (FLINK-29351) Enable input buffer floating for blocking shuffle

2023-01-16 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song closed FLINK-29351. Fix Version/s: (was: 1.17.0) Resolution: Won't Do Subsumed by FLIP-266 (FLINK-30469).

[jira] [Closed] (FLINK-29351) Enable input buffer floating for blocking shuffle

2023-01-16 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song closed FLINK-29351. Resolution: Resolved > Enable input buffer floating for blocking shuffle > ---

[jira] [Closed] (FLINK-30601) Omit "setKeyContextElement" call for non-keyed stream/operators to improve performance

2023-01-16 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijie Wang closed FLINK-30601. -- Resolution: Done > Omit "setKeyContextElement" call for non-keyed stream/operators to improve > perfo

[GitHub] [flink] wanglijie95 closed pull request #21621: [FLINK-30601][runtime] Omit "setKeyContextElement" call for non-keyed stream/operators to improve performance

2023-01-16 Thread GitBox
wanglijie95 closed pull request #21621: [FLINK-30601][runtime] Omit "setKeyContextElement" call for non-keyed stream/operators to improve performance URL: https://github.com/apache/flink/pull/21621 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] 1996fanrui commented on pull request #21690: [FLINK-30623][runtime][bug] The canEmitBatchOfRecords should check recordWriter and changelogWriterAvailabilityProvider are available

2023-01-16 Thread GitBox
1996fanrui commented on PR #21690: URL: https://github.com/apache/flink/pull/21690#issuecomment-1384889755 Hi @lindong28 , thanks for your quick feedback. I want to check with you the first question: No matter which class canEmitBatchOfRecords is added to, we should use `Supplier can

[jira] [Reopened] (FLINK-30469) FLIP-266: Simplify network memory configurations for TaskManager

2023-01-16 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song reopened FLINK-30469: -- > FLIP-266: Simplify network memory configurations for TaskManager > -

[jira] [Closed] (FLINK-30469) FLIP-266: Simplify network memory configurations for TaskManager

2023-01-16 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song closed FLINK-30469. Fix Version/s: 1.17.0 Release Note: The default value of `taskmanager.memory.network.max` has

[jira] [Assigned] (FLINK-30709) NetworkInput#emitNext() should push records to DataOutput in a while loop

2023-01-16 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin reassigned FLINK-30709: Assignee: Rui Fan > NetworkInput#emitNext() should push records to DataOutput in a while loop > -

[GitHub] [flink-table-store] zjureel commented on a diff in pull request #486: [FLINK-30710] Fix invalid field id for nested type in spark catalog

2023-01-16 Thread GitBox
zjureel commented on code in PR #486: URL: https://github.com/apache/flink-table-store/pull/486#discussion_r1071773731 ## flink-table-store-spark/src/test/java/org/apache/flink/table/store/spark/SparkReadITCase.java: ## @@ -487,4 +487,23 @@ private void innerTestNestedTypeFilte

[jira] [Comment Edited] (FLINK-30533) SourceOperator#emitNext() should push records to DataOutput in a while loop

2023-01-16 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677607#comment-17677607 ] Rui Fan edited comment on FLINK-30533 at 1/17/23 6:07 AM: -- Hi [

[GitHub] [flink] lindong28 commented on pull request #21690: [FLINK-30623][runtime][bug] The canEmitBatchOfRecords should check recordWriter and changelogWriterAvailabilityProvider are available

2023-01-16 Thread GitBox
lindong28 commented on PR #21690: URL: https://github.com/apache/flink/pull/21690#issuecomment-1384878158 Hi @1996fanrui, thanks for the explanation. Regarding the 1st point mentioned above, yes `canEmitBatchOfRecords()` is related to emit int the sense that it mangaes the "control fl

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #486: [FLINK-30710] Fix invalid field id for nested type in spark catalog

2023-01-16 Thread GitBox
JingsongLi commented on code in PR #486: URL: https://github.com/apache/flink-table-store/pull/486#discussion_r1071768327 ## flink-table-store-spark/src/test/java/org/apache/flink/table/store/spark/SparkReadITCase.java: ## @@ -487,4 +487,23 @@ private void innerTestNestedTypeFi

[jira] [Commented] (FLINK-30577) OpenShift FlinkSessionJob artifact write error on non-default namespaces

2023-01-16 Thread James Busche (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677617#comment-17677617 ] James Busche commented on FLINK-30577: -- I hadn't heard back from [~tagarr] to see i

[jira] [Updated] (FLINK-30710) Fix invalid field id for nested type in spark catalog

2023-01-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30710: --- Labels: pull-request-available (was: ) > Fix invalid field id for nested type in spark cata

[GitHub] [flink-table-store] zjureel opened a new pull request, #486: [FLINK-30710] Fix invalid field id for nested type in spark catalog

2023-01-16 Thread GitBox
zjureel opened a new pull request, #486: URL: https://github.com/apache/flink-table-store/pull/486 Fix invalid field ind for nested type in spark ddl -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (FLINK-30533) SourceOperator#emitNext() should push records to DataOutput in a while loop

2023-01-16 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677612#comment-17677612 ] Dong Lin commented on FLINK-30533: -- Hi [~yunta], I run the benchmark again without and

[jira] [Created] (FLINK-30710) Fix invalid field id for nested type in spark catalog

2023-01-16 Thread Shammon (Jira)
Shammon created FLINK-30710: --- Summary: Fix invalid field id for nested type in spark catalog Key: FLINK-30710 URL: https://issues.apache.org/jira/browse/FLINK-30710 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-30533) SourceOperator#emitNext() should push records to DataOutput in a while loop

2023-01-16 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677607#comment-17677607 ] Rui Fan commented on FLINK-30533: - Hi [~lindong] [~pnowojski] , thanks for your contribu

[GitHub] [flink] 1996fanrui commented on pull request #21690: [FLINK-30623][runtime][bug] The canEmitBatchOfRecords should check recordWriter and changelogWriterAvailabilityProvider are available

2023-01-16 Thread GitBox
1996fanrui commented on PR #21690: URL: https://github.com/apache/flink/pull/21690#issuecomment-1384851783 Hi @lindong28 , thanks a lot for your review and discuss here. > Could you explain what is the benefit for this refactor? As I understand, there are two reasons for adding

[GitHub] [flink] flinkbot commented on pull request #21697: [FLINK-30709][runtime] NetworkInput#emitNext() should push records to DataOutput within a while loop

2023-01-16 Thread GitBox
flinkbot commented on PR #21697: URL: https://github.com/apache/flink/pull/21697#issuecomment-1384847007 ## CI report: * 328510c28779d64fa249c33f6a1014fb7c7f6ddf UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30709) NetworkInput#emitNext() should push records to DataOutput in a while loop

2023-01-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30709: --- Labels: pull-request-available (was: ) > NetworkInput#emitNext() should push records to Dat

[GitHub] [flink] 1996fanrui opened a new pull request, #21697: [FLINK-30709][runtime] NetworkInput#emitNext() should push records to DataOutput within a while loop

2023-01-16 Thread GitBox
1996fanrui opened a new pull request, #21697: URL: https://github.com/apache/flink/pull/21697 ## What is the purpose of the change Improve Flink performance by reducing the average depth of the call stack needed to produce a record for NetworkInput. ## Brief change log N

[jira] [Created] (FLINK-30709) NetworkInput#emitNext() should push records to DataOutput in a while loop

2023-01-16 Thread Rui Fan (Jira)
Rui Fan created FLINK-30709: --- Summary: NetworkInput#emitNext() should push records to DataOutput in a while loop Key: FLINK-30709 URL: https://issues.apache.org/jira/browse/FLINK-30709 Project: Flink

[GitHub] [flink] lsyldliu commented on a diff in pull request #21257: [FLINK-29879][filesystem] introduce operators for merging files in batch mode.

2023-01-16 Thread GitBox
lsyldliu commented on code in PR #21257: URL: https://github.com/apache/flink/pull/21257#discussion_r1071672649 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/batch/compact/BatchCompactCoordinator.java: ## @@ -0,0 +1,153 @@ +/* + *

[GitHub] [flink] lsyldliu commented on pull request #21629: [FLINK-30579][hive] Introducing cofigurable option to enable hive native function

2023-01-16 Thread GitBox
lsyldliu commented on PR #21629: URL: https://github.com/apache/flink/pull/21629#issuecomment-1384812979 @fsk119 Thanks for reviewing, the test has been added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [flink] SinBex commented on pull request #21695: [FLINK-30707][runtime] Let speculative execution take input data amount into account when detecting slow tasks.

2023-01-16 Thread GitBox
SinBex commented on PR #21695: URL: https://github.com/apache/flink/pull/21695#issuecomment-1384800940 @zhuzhurk Hi, Can u help me to review it? thanks a lot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [flink] flinkbot commented on pull request #21696: [FLINK-30257] fix SqlClientITCase#testMatchRecognize

2023-01-16 Thread GitBox
flinkbot commented on PR #21696: URL: https://github.com/apache/flink/pull/21696#issuecomment-1384800345 ## CI report: * c4b7c8b36c49c1ad95efe1e3af6bdfdbd210506d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #21695: [FLINK-30707][runtime] Let speculative execution take input data amount into account when detecting slow tasks.

2023-01-16 Thread GitBox
flinkbot commented on PR #21695: URL: https://github.com/apache/flink/pull/21695#issuecomment-1384800296 ## CI report: * b491f2cb53a69bedfadca4c3e3b10a5d7cf89cc8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-30257) SqlClientITCase#testMatchRecognize failed

2023-01-16 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677587#comment-17677587 ] Wencong Liu commented on FLINK-30257: - Thanks [~martijnvisser], I've opened a pull r

[jira] [Updated] (FLINK-30257) SqlClientITCase#testMatchRecognize failed

2023-01-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30257: --- Labels: pull-request-available test-stability (was: test-stability) > SqlClientITCase#testM

[jira] [Updated] (FLINK-30707) Let speculative execution take input data amount into account when detecting slow tasks

2023-01-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30707: --- Labels: pull-request-available (was: ) > Let speculative execution take input data amount i

[GitHub] [flink] WencongLiu opened a new pull request, #21696: [FLINK-30257] fix SqlClientITCase#testMatchRecognize

2023-01-16 Thread GitBox
WencongLiu opened a new pull request, #21696: URL: https://github.com/apache/flink/pull/21696 ## What is the purpose of the change *fix SqlClientITCase#testMatchRecognize* ## Brief change log - *make verifyNumberOfResultRecords wait until get the expected nu

[GitHub] [flink] SinBex opened a new pull request, #21695: [FLINK-30707][runtime] Let speculative execution take input data amount into account when detecting slow tasks.

2023-01-16 Thread GitBox
SinBex opened a new pull request, #21695: URL: https://github.com/apache/flink/pull/21695 ## What is the purpose of the change The default slowTaskDetector in speculative execution is based on execution time now, if the data amount allocated to each subtask is uneven, time-bas

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #484: [FLINK-30516] Introduce files table in table store

2023-01-16 Thread GitBox
JingsongLi commented on code in PR #484: URL: https://github.com/apache/flink-table-store/pull/484#discussion_r1071702317 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/CoreOptions.java: ## @@ -401,6 +401,12 @@ public class CoreOptions implements Serializab

[GitHub] [flink] lincoln-lil commented on a diff in pull request #21676: [FLINK-30662][table] Planner supports delete

2023-01-16 Thread GitBox
lincoln-lil commented on code in PR #21676: URL: https://github.com/apache/flink/pull/21676#discussion_r1071693761 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/SqlToOperationConverter.java: ## @@ -1492,6 +1500,41 @@ private Operation

[jira] [Updated] (FLINK-30707) Let speculative execution take input data amount into account when detecting slow tasks

2023-01-16 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-30707: Summary: Let speculative execution take input data amount into account when detecting slow tasks (was: Le

[jira] [Commented] (FLINK-30707) Let speculative execution takes input data amount into account when detecting slow tasks

2023-01-16 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677584#comment-17677584 ] Zhu Zhu commented on FLINK-30707: - Thanks for the proposal! [~xiasun] I have assigned yo

[jira] [Assigned] (FLINK-30707) Let speculative execution takes input data amount into account when detecting slow tasks

2023-01-16 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu reassigned FLINK-30707: --- Assignee: xingbe > Let speculative execution takes input data amount into account when detecting >

[GitHub] [flink] fsk119 commented on a diff in pull request #21677: [FLINK-30693][sql-gateway] Introduce RowFormat to SQL Gateway

2023-01-16 Thread GitBox
fsk119 commented on code in PR #21677: URL: https://github.com/apache/flink/pull/21677#discussion_r1070749450 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/rest/handler/statement/FetchResultsHandler.java: ## @@ -63,17 +70,27 @@ protected Completab

[GitHub] [flink] luoyuxia commented on a diff in pull request #21257: [FLINK-29879][filesystem] introduce operators for merging files in batch mode.

2023-01-16 Thread GitBox
luoyuxia commented on code in PR #21257: URL: https://github.com/apache/flink/pull/21257#discussion_r1071700619 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/batch/compact/BatchCompactOperator.java: ## @@ -0,0 +1,145 @@ +/* + * Lic

[jira] [Created] (FLINK-30708) Typo problem of the doc `Determinism In Continuous Queries`

2023-01-16 Thread Jie Han (Jira)
Jie Han created FLINK-30708: --- Summary: Typo problem of the doc `Determinism In Continuous Queries` Key: FLINK-30708 URL: https://issues.apache.org/jira/browse/FLINK-30708 Project: Flink Issue Type

[GitHub] [flink] reswqa commented on pull request #21553: [FLINK-30492][doc] fix incorrect dependency artifactId in hive overview.

2023-01-16 Thread GitBox
reswqa commented on PR #21553: URL: https://github.com/apache/flink/pull/21553#issuecomment-1384778651 @ZhongFuCheng3y In fact, the pull request has been closed because @MartijnVisser doesn't think it needs to be fixed. -- This is an automated message from the Apache Git Service. To respo

[jira] [Commented] (FLINK-30707) Let speculative execution takes input data amount into account when detecting slow tasks

2023-01-16 Thread xingbe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677583#comment-17677583 ] xingbe commented on FLINK-30707: [~zhuzh] Could you please assign this ticket to me? Tha

[GitHub] [flink] luoyuxia commented on a diff in pull request #21257: [FLINK-29879][filesystem] introduce operators for merging files in batch mode.

2023-01-16 Thread GitBox
luoyuxia commented on code in PR #21257: URL: https://github.com/apache/flink/pull/21257#discussion_r1071697576 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/batch/compact/BatchCompactOperator.java: ## @@ -0,0 +1,145 @@ +/* + * Lic

[jira] [Updated] (FLINK-30707) Let speculative execution takes input data amount into account when detecting slow tasks

2023-01-16 Thread xingbe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xingbe updated FLINK-30707: --- Summary: Let speculative execution takes input data amount into account when detecting slow tasks (was: Let

[jira] [Updated] (FLINK-30695) Support to set parallelism for compact operator according to the number of files in AQE.

2023-01-16 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-30695: - Description: In current design for compact files in Hive sink, there's a coordinator operator that coll

[jira] [Created] (FLINK-30707) Let speculative execution takes input number bytes into account when detecting slow tasks

2023-01-16 Thread xingbe (Jira)
xingbe created FLINK-30707: -- Summary: Let speculative execution takes input number bytes into account when detecting slow tasks Key: FLINK-30707 URL: https://issues.apache.org/jira/browse/FLINK-30707 Project

[GitHub] [flink] gj199575 commented on pull request #20467: [FLINK-28825][k8s] Add K8S pod scheduler into Kubernetes options

2023-01-16 Thread GitBox
gj199575 commented on PR #20467: URL: https://github.com/apache/flink/pull/20467#issuecomment-1384771917 I have a question. which mode the code worked for ? flink on k8s session 、 flink on k8s per-job、 flink on k8s application or flink on k8s native? thank you -- This i

[GitHub] [flink] gj199575 commented on pull request #20467: [FLINK-28825][k8s] Add K8S pod scheduler into Kubernetes options

2023-01-16 Thread GitBox
gj199575 commented on PR #20467: URL: https://github.com/apache/flink/pull/20467#issuecomment-1384771055 I hava a question. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] luoyuxia commented on pull request #21257: [FLINK-29879][filesystem] introduce operators for merging files in batch mode.

2023-01-16 Thread GitBox
luoyuxia commented on PR #21257: URL: https://github.com/apache/flink/pull/21257#issuecomment-1384765248 @lsyldliu Thanks for your reviewing. I have addressed your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (FLINK-30431) JDBC Connector fails to reestablish the lost DB connection.

2023-01-16 Thread Sai Nadendla (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677580#comment-17677580 ] Sai Nadendla commented on FLINK-30431: -- Hi [~jiabao.sun], Great to see the quick PR

[jira] [Closed] (FLINK-30469) FLIP-266: Simplify network memory configurations for TaskManager

2023-01-16 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan closed FLINK-30469. - > FLIP-266: Simplify network memory configurations for TaskManager > ---

[jira] (FLINK-30469) FLIP-266: Simplify network memory configurations for TaskManager

2023-01-16 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30469 ] Yuxin Tan deleted comment on FLINK-30469: --- was (Author: tanyuxin): master (1.17): ae8de97ef2acc798dae34ad2096ece8886bcf308 > FLIP-266: Simplify network memory configurations for TaskManager >

[jira] [Resolved] (FLINK-30469) FLIP-266: Simplify network memory configurations for TaskManager

2023-01-16 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan resolved FLINK-30469. --- Resolution: Resolved master (1.17): ae8de97ef2acc798dae34ad2096ece8886bcf308 > FLIP-266: Simplify n

[GitHub] [flink] TanYuxin-tyx closed pull request #21618: [FLINK-30472][network] Modify the default value of the max network memory config option

2023-01-16 Thread GitBox
TanYuxin-tyx closed pull request #21618: [FLINK-30472][network] Modify the default value of the max network memory config option URL: https://github.com/apache/flink/pull/21618 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] TanYuxin-tyx commented on pull request #21618: [FLINK-30472][network] Modify the default value of the max network memory config option

2023-01-16 Thread GitBox
TanYuxin-tyx commented on PR #21618: URL: https://github.com/apache/flink/pull/21618#issuecomment-1384758099 The pr is reviewed at https://github.com/apache/flink/pull/21620. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] TanYuxin-tyx commented on pull request #21612: [FLINK-30471][network] Optimize the enriching network memory process in SsgNetworkMemoryCalculationUtils

2023-01-16 Thread GitBox
TanYuxin-tyx commented on PR #21612: URL: https://github.com/apache/flink/pull/21612#issuecomment-1384757668 The pr is reviewed at https://github.com/apache/flink/pull/21620. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #21612: [FLINK-30471][network] Optimize the enriching network memory process in SsgNetworkMemoryCalculationUtils

2023-01-16 Thread GitBox
TanYuxin-tyx commented on code in PR #21612: URL: https://github.com/apache/flink/pull/21612#discussion_r1071682166 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SsgNetworkMemoryCalculationUtils.java: ## @@ -93,28 +93,27 @@ public static void enrichNetworkMem

[GitHub] [flink] TanYuxin-tyx closed pull request #21612: [FLINK-30471][network] Optimize the enriching network memory process in SsgNetworkMemoryCalculationUtils

2023-01-16 Thread GitBox
TanYuxin-tyx closed pull request #21612: [FLINK-30471][network] Optimize the enriching network memory process in SsgNetworkMemoryCalculationUtils URL: https://github.com/apache/flink/pull/21612 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Closed] (FLINK-30472) Modify the default value of the max network memory config option

2023-01-16 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song closed FLINK-30472. Fix Version/s: 1.17.0 Resolution: Done master (1.17): afdf4a73e43f2e6f5b2dd984aa3471f32658f

[jira] [Closed] (FLINK-30471) Optimize the enriching network memory process in SsgNetworkMemoryCalculationUtils

2023-01-16 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song closed FLINK-30471. Fix Version/s: 1.17.0 Resolution: Done master (1.17): fc7defb14d11e270d539ee0d80a2076ae55a4

[jira] [Closed] (FLINK-30473) Optimize the InputGate network memory management for TaskManager

2023-01-16 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song closed FLINK-30473. Fix Version/s: 1.17.0 Resolution: Done master (1.17): ae8de97ef2acc798dae34ad2096ece8886bcf

[jira] [Commented] (FLINK-30659) move flink-sql-parser-hive to flink-connector-hive-parent

2023-01-16 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677571#comment-17677571 ] dalongliu commented on FLINK-30659: --- I think this module should be dropped directly, h

[GitHub] [flink] xintongsong closed pull request #21620: [FLINK-30473][network] Optimize the InputGate network memory management for TaskManager

2023-01-16 Thread GitBox
xintongsong closed pull request #21620: [FLINK-30473][network] Optimize the InputGate network memory management for TaskManager URL: https://github.com/apache/flink/pull/21620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

  1   2   3   4   >