[jira] [Updated] (FLINK-30730) StringIndexer cannot handle null values correctly when training

2023-01-18 Thread Fan Hong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fan Hong updated FLINK-30730: - Description: When training data contains null values, StringIndexer throws a exception. The reason is t

[jira] [Created] (FLINK-30731) Translate "Set Operations" page of "Querys" into Chinese

2023-01-18 Thread chenhaiyang (Jira)
chenhaiyang created FLINK-30731: --- Summary: Translate "Set Operations" page of "Querys" into Chinese Key: FLINK-30731 URL: https://issues.apache.org/jira/browse/FLINK-30731 Project: Flink Issue

[GitHub] [flink] gaborgsomogyi commented on a diff in pull request #21705: [FLINK-30713][k8s] Add Hadoop related k8s decorators exclude possibility

2023-01-18 Thread GitBox
gaborgsomogyi commented on code in PR #21705: URL: https://github.com/apache/flink/pull/21705#discussion_r1073208380 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java: ## @@ -485,6 +485,18 @@ public class KubernetesConfigOpt

[GitHub] [flink] NightRunner opened a new pull request, #21713: [FLINK-30731][docs]Translate "Set Operations" page of "Querys" into C…

2023-01-18 Thread GitBox
NightRunner opened a new pull request, #21713: URL: https://github.com/apache/flink/pull/21713 Page "Application Development"/"Table API&SQL"/"SQL"/"Queries"/Set Operations translate to chinese. ## What is the purpose of the change Translate /dev/table/sql/queries/set-ops.md

[jira] [Updated] (FLINK-30731) Translate "Set Operations" page of "Querys" into Chinese

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30731: --- Labels: pull-request-available (was: ) > Translate "Set Operations" page of "Querys" into C

[jira] [Commented] (FLINK-30731) Translate "Set Operations" page of "Querys" into Chinese

2023-01-18 Thread chenhaiyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678121#comment-17678121 ] chenhaiyang commented on FLINK-30731: - Hi [~jark] ,The pull request for this issue h

[GitHub] [flink] flinkbot commented on pull request #21713: [FLINK-30731][docs]Translate "Set Operations" page of "Querys" into C…

2023-01-18 Thread GitBox
flinkbot commented on PR #21713: URL: https://github.com/apache/flink/pull/21713#issuecomment-1386654627 ## CI report: * 2a0581b5a83803e5c8658908e99200cffc89d168 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30730) StringIndexer cannot handle null values correctly

2023-01-18 Thread Fan Hong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fan Hong updated FLINK-30730: - Summary: StringIndexer cannot handle null values correctly (was: StringIndexer cannot handle null value

[GitHub] [flink] Myasuka commented on pull request #20049: [FLINK-28046][connectors] Mark SourceFunction interface as @Deprecated

2023-01-18 Thread GitBox
Myasuka commented on PR #20049: URL: https://github.com/apache/flink/pull/20049#issuecomment-1386662086 @afedulov since FLIP-238 had been resolved, shall we continue this work and make it done in flink-1.17 release? -- This is an automated message from the Apache Git Service. To respond t

[jira] [Updated] (FLINK-30730) StringIndexer cannot handle null values correctly

2023-01-18 Thread Fan Hong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fan Hong updated FLINK-30730: - Description: When training data contains null values, StringIndexer throws a exception. The reason is t

[GitHub] [flink] pnowojski commented on pull request #21690: [FLINK-30623][runtime][bug] The canEmitBatchOfRecords should check recordWriter and changelogWriterAvailabilityProvider are available

2023-01-18 Thread GitBox
pnowojski commented on PR #21690: URL: https://github.com/apache/flink/pull/21690#issuecomment-1386685819 > The other thing that looks strange if I take a step back, is that we now have to different while (true) loops. One in the MailboxProcessor#runMailboxLoop the other in SourceOperator a

[GitHub] [flink] lincoln-lil commented on a diff in pull request #21683: [FLINK-30672][table] Support 'EXPLAIN PLAN_ADVICE' statement

2023-01-18 Thread GitBox
lincoln-lil commented on code in PR #21683: URL: https://github.com/apache/flink/pull/21683#discussion_r1073038341 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/analyze/FlinkStreamPlanAnalyzers.scala: ## @@ -0,0 +1,33 @@ +/* + * Licensed to the

[jira] [Assigned] (FLINK-27716) Add Python API docs in ML

2023-01-18 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huang Xingbo reassigned FLINK-27716: Assignee: Jiang Xin > Add Python API docs in ML > - > >

[jira] [Created] (FLINK-30732) "Running HA (hashmap, sync) end-to-end test" failed with exit code 1

2023-01-18 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-30732: - Summary: "Running HA (hashmap, sync) end-to-end test" failed with exit code 1 Key: FLINK-30732 URL: https://issues.apache.org/jira/browse/FLINK-30732 Project: Flink

[GitHub] [flink] Myasuka opened a new pull request, #21714: [FLINK-30724][docs] Update kafka-per-partition watermark to new source

2023-01-18 Thread GitBox
Myasuka opened a new pull request, #21714: URL: https://github.com/apache/flink/pull/21714 ## What is the purpose of the change Update the doc of kafka-per-partition watermark to the new source. ## Brief change log Update the doc of kafka-per-partition watermark to th

[jira] [Updated] (FLINK-30724) Update doc of kafka per-partition watermark to FLIP-27 source

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30724: --- Labels: pull-request-available (was: ) > Update doc of kafka per-partition watermark to FLI

[jira] [Updated] (FLINK-30732) "Running HA (hashmap, sync) end-to-end test" failed with exit code 1

2023-01-18 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-30732: -- Attachment: FLINK-30732.tar.gz > "Running HA (hashmap, sync) end-to-end test" failed with exit

[jira] [Commented] (FLINK-30732) "Running HA (hashmap, sync) end-to-end test" failed with exit code 1

2023-01-18 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678129#comment-17678129 ] Matthias Pohl commented on FLINK-30732: --- I attached the logs for the build mention

[GitHub] [flink] SinBex commented on a diff in pull request #21634: [FLINK-30480][runtime] Add benchmarks for adaptive batch scheduler.

2023-01-18 Thread GitBox
SinBex commented on code in PR #21634: URL: https://github.com/apache/flink/pull/21634#discussion_r1073254764 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/benchmark/failover/RestartTasksInBatchJobBenchmarkTest.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to th

[GitHub] [flink] SinBex commented on a diff in pull request #21634: [FLINK-30480][runtime] Add benchmarks for adaptive batch scheduler.

2023-01-18 Thread GitBox
SinBex commented on code in PR #21634: URL: https://github.com/apache/flink/pull/21634#discussion_r1073256359 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/benchmark/scheduling/InitSchedulingStrategyBenchmark.java: ## @@ -20,20 +20,28 @@ import org.apache.

[jira] [Commented] (FLINK-30732) "Running HA (hashmap, sync) end-to-end test" failed with exit code 1

2023-01-18 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678132#comment-17678132 ] Matthias Pohl commented on FLINK-30732: --- I'm linking FLINK-23210 as related becaus

[jira] [Updated] (FLINK-30732) "Running HA (hashmap, sync) end-to-end test" failed with exit code 1

2023-01-18 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-30732: -- Labels: test-stability (was: ) > "Running HA (hashmap, sync) end-to-end test" failed with exi

[GitHub] [flink] flinkbot commented on pull request #21714: [FLINK-30724][docs] Update kafka-per-partition watermark to new source

2023-01-18 Thread GitBox
flinkbot commented on PR #21714: URL: https://github.com/apache/flink/pull/21714#issuecomment-1386704806 ## CI report: * 1f241186a3371722253a181729375342bcb7f1e7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-30733) The AzureCI Slack bot does not list all failed builds in the Slack channel

2023-01-18 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-30733: - Summary: The AzureCI Slack bot does not list all failed builds in the Slack channel Key: FLINK-30733 URL: https://issues.apache.org/jira/browse/FLINK-30733 Project:

[GitHub] [flink] SinBex commented on a diff in pull request #21634: [FLINK-30480][runtime] Add benchmarks for adaptive batch scheduler.

2023-01-18 Thread GitBox
SinBex commented on code in PR #21634: URL: https://github.com/apache/flink/pull/21634#discussion_r1073262413 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/benchmark/scheduling/InitSchedulingStrategyBenchmarkTest.java: ## @@ -44,4 +46,20 @@ public void initSc

[GitHub] [flink] lincoln-lil commented on a diff in pull request #21683: [FLINK-30672][table] Support 'EXPLAIN PLAN_ADVICE' statement

2023-01-18 Thread GitBox
lincoln-lil commented on code in PR #21683: URL: https://github.com/apache/flink/pull/21683#discussion_r1073264039 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/physical/stream/TwoStageOptimizedAggregateRule.scala: ## @@ -59,11 +59,1

[GitHub] [flink-connector-pulsar] XComp commented on a diff in pull request #17: [FLINK-30657] Remove Shared and Key_Shared related tests in Pulsar connector

2023-01-18 Thread GitBox
XComp commented on code in PR #17: URL: https://github.com/apache/flink-connector-pulsar/pull/17#discussion_r1073266310 ## flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/source/enumerator/assigner/SharedSplitAssignerTest.java: ## @@ -1,121 +0,0 @@ -/* -

[GitHub] [flink] luoyuxia commented on a diff in pull request #21601: [FLINK-27920][hive] Supports native avg function for hive dialect

2023-01-18 Thread GitBox
luoyuxia commented on code in PR #21601: URL: https://github.com/apache/flink/pull/21601#discussion_r1073260992 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveAverageAggFunction.java: ## @@ -0,0 +1,207 @@ +/* + * Licensed to the

[GitHub] [flink-connector-elasticsearch] MartijnVisser commented on pull request #51: [BP-3.0][FLINK-30359][es] flink-sql-connector-elasticsearch6's jar should including the dependency of com.carrotse

2023-01-18 Thread GitBox
MartijnVisser commented on PR #51: URL: https://github.com/apache/flink-connector-elasticsearch/pull/51#issuecomment-1386716971 @reswqa Can you push an additional commit to see if the CI starts? -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [flink-table-store] zjureel commented on pull request #426: [FLINK-30323] Support table statistics in table store

2023-01-18 Thread GitBox
zjureel commented on PR #426: URL: https://github.com/apache/flink-table-store/pull/426#issuecomment-1386728578 Hi @JingsongLi I have rebase from master for this PR, could you help to review again when you get time? THX -- This is an automated message from the Apache Git Service. To res

[GitHub] [flink] lincoln-lil commented on a diff in pull request #21683: [FLINK-30672][table] Support 'EXPLAIN PLAN_ADVICE' statement

2023-01-18 Thread GitBox
lincoln-lil commented on code in PR #21683: URL: https://github.com/apache/flink/pull/21683#discussion_r1073281001 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/analyze/NonDeterministicUpdateAnalyzer.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to

[GitHub] [flink] ferenc-csaky commented on pull request #16927: [FLINK-18592][Connectors/FileSystem] StreamingFileSink fails due to truncating HDFS file failure

2023-01-18 Thread GitBox
ferenc-csaky commented on PR #16927: URL: https://github.com/apache/flink/pull/16927#issuecomment-1386739768 > @thebalu Thanks for reaching out. I didn't get this PR merged because the community has no capacity to review it, especially since this PR is hard to test. I would revisit it and m

[GitHub] [flink] 1996fanrui commented on pull request #21690: [FLINK-30623][runtime][bug] The canEmitBatchOfRecords should check recordWriter and changelogWriterAvailabilityProvider are available

2023-01-18 Thread GitBox
1996fanrui commented on PR #21690: URL: https://github.com/apache/flink/pull/21690#issuecomment-1386744572 I saw the `PushingAsyncDataInput#emitNext` and `SourceReader#pollNext` returns the `InputStatus`. It's similar to `DataOutput#emitRecord`. So sounds good to me, +1 for `DataOutput#emit

[GitHub] [flink] SinBex commented on a diff in pull request #21634: [FLINK-30480][runtime] Add benchmarks for adaptive batch scheduler.

2023-01-18 Thread GitBox
SinBex commented on code in PR #21634: URL: https://github.com/apache/flink/pull/21634#discussion_r1073294808 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/benchmark/scheduling/StartSchedulingInBatchJobBenchmarkTest.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed

[GitHub] [flink] SinBex commented on a diff in pull request #21634: [FLINK-30480][runtime] Add benchmarks for adaptive batch scheduler.

2023-01-18 Thread GitBox
SinBex commented on code in PR #21634: URL: https://github.com/apache/flink/pull/21634#discussion_r1073294808 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/benchmark/scheduling/StartSchedulingInBatchJobBenchmarkTest.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed

[GitHub] [flink-training] zentol commented on a diff in pull request #51: [FLINK-30717][ci] Migrate to GitHub Actions

2023-01-18 Thread GitBox
zentol commented on code in PR #51: URL: https://github.com/apache/flink-training/pull/51#discussion_r1073306239 ## .github/workflows/ci.yml: ## @@ -0,0 +1,41 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOT

[GitHub] [flink-training] zentol commented on a diff in pull request #51: [FLINK-30717][ci] Migrate to GitHub Actions

2023-01-18 Thread GitBox
zentol commented on code in PR #51: URL: https://github.com/apache/flink-training/pull/51#discussion_r1073306501 ## .github/workflows/ci.yml: ## @@ -0,0 +1,41 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOT

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-01-18 Thread GitBox
echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1073306704 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/split/CassandraSplit.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-30577) OpenShift FlinkSessionJob artifact write error on non-default namespaces

2023-01-18 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678164#comment-17678164 ] Gyula Fora commented on FLINK-30577: Target 1.4.0 feature freeze is early February 

[GitHub] [flink] lindong28 commented on pull request #21690: [FLINK-30623][runtime][bug] The canEmitBatchOfRecords should check recordWriter and changelogWriterAvailabilityProvider are available

2023-01-18 Thread GitBox
lindong28 commented on PR #21690: URL: https://github.com/apache/flink/pull/21690#issuecomment-1386777544 Hmm... if we add the method `boolean DataOutput#emitRecord(...)`, can you explain what Java Doc we should use to explain the semantics of the returned boolean value? Intuitively,

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-01-18 Thread GitBox
echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1073329519 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/split/RingRange.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-30721) The confluent schema registry is not compatible with Apicurio schema registry

2023-01-18 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-30721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678174#comment-17678174 ] Pedro Mázala commented on FLINK-30721: -- Gotcha [~martijnvisser]. We can remove this

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-01-18 Thread GitBox
echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1073332349 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/split/RingRange.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the

[GitHub] [flink] lindong28 commented on pull request #21690: [FLINK-30623][runtime][bug] The canEmitBatchOfRecords should check recordWriter and changelogWriterAvailabilityProvider are available

2023-01-18 Thread GitBox
lindong28 commented on PR #21690: URL: https://github.com/apache/flink/pull/21690#issuecomment-1386793709 Thanks for the detailed explanation @pnowojski :) Let me provides comments below. > It would be strange for me that in order to fully implement this interface and use it as it's

[jira] [Created] (FLINK-30734) KBinsDiscretizer handles Double.NaN incorrectly

2023-01-18 Thread Fan Hong (Jira)
Fan Hong created FLINK-30734: Summary: KBinsDiscretizer handles Double.NaN incorrectly Key: FLINK-30734 URL: https://issues.apache.org/jira/browse/FLINK-30734 Project: Flink Issue Type: Bug

[jira] [Updated] (FLINK-30734) KBinsDiscretizer handles Double.NaN incorrectly

2023-01-18 Thread Fan Hong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fan Hong updated FLINK-30734: - Affects Version/s: ml-2.1.0 > KBinsDiscretizer handles Double.NaN incorrectly >

[GitHub] [flink] luoyuxia commented on a diff in pull request #21668: [FLINK-30679][HIVE]Can not load the data of hive dim table when project-push-down is introduced

2023-01-18 Thread GitBox
luoyuxia commented on code in PR #21668: URL: https://github.com/apache/flink/pull/21668#discussion_r1073328257 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveLookupJoinITCase.java: ## @@ -378,6 +378,31 @@ public void testLookupJoinW

[GitHub] [flink] luoyuxia commented on a diff in pull request #21668: [FLINK-30679][HIVE]Can not load the data of hive dim table when project-push-down is introduced

2023-01-18 Thread GitBox
luoyuxia commented on code in PR #21668: URL: https://github.com/apache/flink/pull/21668#discussion_r1073351578 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveLookupJoinITCase.java: ## @@ -378,6 +378,31 @@ public void testLookupJoinW

[GitHub] [flink-shaded] MartijnVisser commented on pull request #118: [FLINK-30232][Build/Shaded] Include all platforms incl ARM64 while shading Netty

2023-01-18 Thread GitBox
MartijnVisser commented on PR #118: URL: https://github.com/apache/flink-shaded/pull/118#issuecomment-1386822470 > The same streamlining should be applied to the dynamic tcnative module We can't do that for the dynamic tcnative module, per https://github.com/apache/flink-shaded/blob/m

[jira] [Created] (FLINK-30735) Translate "Top-N" page of "Querys" into Chinese

2023-01-18 Thread chenhaiyang (Jira)
chenhaiyang created FLINK-30735: --- Summary: Translate "Top-N" page of "Querys" into Chinese Key: FLINK-30735 URL: https://issues.apache.org/jira/browse/FLINK-30735 Project: Flink Issue Type: Sub

[GitHub] [flink] NightRunner opened a new pull request, #21715: [FLINK-30735][docs]Translate "Top-N" page of "Querys" into Chinese

2023-01-18 Thread GitBox
NightRunner opened a new pull request, #21715: URL: https://github.com/apache/flink/pull/21715 Translate "Top-N" page of "Querys" into Chinese ## What is the purpose of the change Translate /dev/table/sql/queries/topn.md ## Brief change log Translate /dev/table/sql

[jira] [Updated] (FLINK-30735) Translate "Top-N" page of "Querys" into Chinese

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30735: --- Labels: pull-request-available (was: ) > Translate "Top-N" page of "Querys" into Chinese >

[GitHub] [flink] lincoln-lil commented on a diff in pull request #21676: [FLINK-30662][table] Planner supports delete

2023-01-18 Thread GitBox
lincoln-lil commented on code in PR #21676: URL: https://github.com/apache/flink/pull/21676#discussion_r1073356514 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/batch/sql/RowLevelDeleteTest.java: ## @@ -53,24 +57,37 @@ public RowLevelDelet

[jira] [Commented] (FLINK-30735) Translate "Top-N" page of "Querys" into Chinese

2023-01-18 Thread chenhaiyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678177#comment-17678177 ] chenhaiyang commented on FLINK-30735: - Hi [~jark] ,The pull request for this issue h

[jira] [Resolved] (FLINK-16850) Make flink-benchmark align with different releases of Flink

2023-01-18 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang resolved FLINK-16850. -- Fix Version/s: 1.17.0 Resolution: Fixed Already updated the description of the "Major release"

[jira] [Updated] (FLINK-29945) Supports to submit SQL to a embedded SQL Gateway in the SQL Client

2023-01-18 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang updated FLINK-29945: -- Summary: Supports to submit SQL to a embedded SQL Gateway in the SQL Client (was: Refactor ‘E

[jira] [Commented] (FLINK-27518) Refactor migration tests to support version update automatically

2023-01-18 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678182#comment-17678182 ] Yun Gao commented on FLINK-27518: - Sorry for it takes more time than I thought to finish

[GitHub] [flink] flinkbot commented on pull request #21715: [FLINK-30735][docs]Translate "Top-N" page of "Querys" into Chinese

2023-01-18 Thread GitBox
flinkbot commented on PR #21715: URL: https://github.com/apache/flink/pull/21715#issuecomment-1386834992 ## CI report: * a873402a8c42d531f9467ae3824fe40444a78ab7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-connector-cassandra] echauchot commented on pull request #3: [FLINK-26822] Add Cassandra Source

2023-01-18 Thread GitBox
echauchot commented on PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#issuecomment-1386836888 @zentol I did not author the `RingRange` and `SplitsGenerator` classes. I got them from the `Apache Beam` Cassandra connector. I agree, some notions need clarification. I'l

[GitHub] [flink] pnowojski commented on pull request #21690: [FLINK-30623][runtime][bug] The canEmitBatchOfRecords should check recordWriter and changelogWriterAvailabilityProvider are available

2023-01-18 Thread GitBox
pnowojski commented on PR #21690: URL: https://github.com/apache/flink/pull/21690#issuecomment-1386850790 > If it's ok, ReaderOutput#collect and RecordEmitter#emitRecord should return a boolean as well. And the loop will be moved from SourceOperator#emitNext to SourceReader#pollNext.

[GitHub] [flink] pnowojski commented on a diff in pull request #21690: [FLINK-30623][runtime][bug] The canEmitBatchOfRecords should check recordWriter and changelogWriterAvailabilityProvider are avail

2023-01-18 Thread GitBox
pnowojski commented on code in PR #21690: URL: https://github.com/apache/flink/pull/21690#discussion_r1073379125 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java: ## @@ -993,7 +997,7 @@ public MailboxExecutorFactory getMailboxExecuto

[GitHub] [flink-kubernetes-operator] haoxins opened a new pull request, #506: fix md style

2023-01-18 Thread GitBox
haoxins opened a new pull request, #506: URL: https://github.com/apache/flink-kubernetes-operator/pull/506 just docs style issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[jira] [Commented] (FLINK-30709) NetworkInput#emitNext() should push records to DataOutput in a while loop

2023-01-18 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678190#comment-17678190 ] Piotr Nowojski commented on FLINK-30709: Thanks for following up on my comment!

[GitHub] [flink] pnowojski commented on pull request #21697: [FLINK-30709][runtime] NetworkInput#emitNext() should push records to DataOutput within a while loop

2023-01-18 Thread GitBox
pnowojski commented on PR #21697: URL: https://github.com/apache/flink/pull/21697#issuecomment-1386861784 Generally speaking change looks good to me, but let's wait for the FLINK-30623 to be merged first. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [flink-benchmarks] zentol commented on a diff in pull request #64: [FLINK-30717][ci] Migrate to GitHub Actions

2023-01-18 Thread GitBox
zentol commented on code in PR #64: URL: https://github.com/apache/flink-benchmarks/pull/64#discussion_r1073395171 ## .github/workflows/ci.yml: ## @@ -0,0 +1,50 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the N

[GitHub] [flink] Tartarus0zm opened a new pull request, #21716: [FLINK-29720][hive] Supports hive average function by native implemetatoin

2023-01-18 Thread GitBox
Tartarus0zm opened a new pull request, #21716: URL: https://github.com/apache/flink/pull/21716 ## What is the purpose of the change Supports native hive avg function for hive dialect. ## Brief change log * Supports native hive avg function for hive dialect

[GitHub] [flink-benchmarks] zentol commented on a diff in pull request #64: [FLINK-30717][ci] Migrate to GitHub Actions

2023-01-18 Thread GitBox
zentol commented on code in PR #64: URL: https://github.com/apache/flink-benchmarks/pull/64#discussion_r1073395171 ## .github/workflows/ci.yml: ## @@ -0,0 +1,50 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the N

[jira] [Updated] (FLINK-29720) Supports hive average function by native implemetatoin

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29720: --- Labels: pull-request-available (was: ) > Supports hive average function by native implemeta

[GitHub] [flink] XComp commented on a diff in pull request #21691: [FLINK-30678][tests] Use random port

2023-01-18 Thread GitBox
XComp commented on code in PR #21691: URL: https://github.com/apache/flink/pull/21691#discussion_r1073310290 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyPartitionRequestClientTest.java: ## @@ -55,11 +54,12 @@ /** Tests for {@link NettyPartition

[GitHub] [flink] Tartarus0zm commented on pull request #21716: [FLINK-29720][hive] Supports hive average function by native implemetatoin

2023-01-18 Thread GitBox
Tartarus0zm commented on PR #21716: URL: https://github.com/apache/flink/pull/21716#issuecomment-1386878941 @lsyldliu @luoyuxia @godfreyhe @beyond1920 hello, please take a look, if you have time, thanks -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [flink] fsk119 opened a new pull request, #21717: [FLINK-29945][sql-client] Supports to submit SQL to a embedded SQL Ga…

2023-01-18 Thread GitBox
fsk119 opened a new pull request, #21717: URL: https://github.com/apache/flink/pull/21717 …teway in the SQL Client ## What is the purpose of the change *After rework, the SQL Client uses the SQL Gateway as the base.* ## Brief change log *(for example:)*

[jira] [Updated] (FLINK-29945) Supports to submit SQL to a embedded SQL Gateway in the SQL Client

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29945: --- Labels: pull-request-available (was: ) > Supports to submit SQL to a embedded SQL Gateway i

[GitHub] [flink] flinkbot commented on pull request #21716: [FLINK-29720][hive] Supports hive average function by native implemetatoin

2023-01-18 Thread GitBox
flinkbot commented on PR #21716: URL: https://github.com/apache/flink/pull/21716#issuecomment-1386884113 ## CI report: * cfd591214819cd58522892e9b9f8ea3076c5e8e0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #21717: [FLINK-29945][sql-client] Supports to submit SQL to a embedded SQL Ga…

2023-01-18 Thread GitBox
flinkbot commented on PR #21717: URL: https://github.com/apache/flink/pull/21717#issuecomment-1386884294 ## CI report: * 54ca159e9f1709684b216e6836ae5f409be92a5b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] lsyldliu commented on pull request #21605: [FLINK-29722][hive] Supports native hive max function for hive dialect

2023-01-18 Thread GitBox
lsyldliu commented on PR #21605: URL: https://github.com/apache/flink/pull/21605#issuecomment-1386886860 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] fsk119 commented on pull request #21700: [FLINK-30677][Test] Fix unstable SqlGatewayServiceStatementITCase.testFlinkSqlStatements

2023-01-18 Thread GitBox
fsk119 commented on PR #21700: URL: https://github.com/apache/flink/pull/21700#issuecomment-1386893525 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] Tartarus0zm commented on pull request #21716: [FLINK-29720][hive] Supports hive average function by native implemetatoin

2023-01-18 Thread GitBox
Tartarus0zm commented on PR #21716: URL: https://github.com/apache/flink/pull/21716#issuecomment-1386899952 Repeated with https://github.com/apache/flink/pull/21601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [flink] Tartarus0zm closed pull request #21716: [FLINK-29720][hive] Supports hive average function by native implemetatoin

2023-01-18 Thread GitBox
Tartarus0zm closed pull request #21716: [FLINK-29720][hive] Supports hive average function by native implemetatoin URL: https://github.com/apache/flink/pull/21716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [flink] 1996fanrui commented on pull request #21690: [FLINK-30623][runtime][bug] The canEmitBatchOfRecords should check recordWriter and changelogWriterAvailabilityProvider are available

2023-01-18 Thread GitBox
1996fanrui commented on PR #21690: URL: https://github.com/apache/flink/pull/21690#issuecomment-1386900013 >> If it's ok, ReaderOutput#collect and RecordEmitter#emitRecord should return a boolean as well. And the loop will be moved from SourceOperator#emitNext to SourceReader#pollNext. >

[GitHub] [flink] 1996fanrui commented on a diff in pull request #21690: [FLINK-30623][runtime][bug] The canEmitBatchOfRecords should check recordWriter and changelogWriterAvailabilityProvider are avai

2023-01-18 Thread GitBox
1996fanrui commented on code in PR #21690: URL: https://github.com/apache/flink/pull/21690#discussion_r1073416193 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java: ## @@ -993,7 +997,7 @@ public MailboxExecutorFactory getMailboxExecut

[jira] [Commented] (FLINK-30703) PulsarOrderedPartitionSplitReaderTest>PulsarPartitionSplitReaderTestBase.consumeMessageCreatedBeforeHandleSplitsChangesAndResetToEarliestPosition fails

2023-01-18 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678204#comment-17678204 ] Matthias Pohl commented on FLINK-30703: --- {quote}quoted text{quote}Matthias Pohl It

[jira] [Comment Edited] (FLINK-30703) PulsarOrderedPartitionSplitReaderTest>PulsarPartitionSplitReaderTestBase.consumeMessageCreatedBeforeHandleSplitsChangesAndResetToEarliestPosition fails

2023-01-18 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678204#comment-17678204 ] Matthias Pohl edited comment on FLINK-30703 at 1/18/23 11:58 AM: -

[GitHub] [flink] lindong28 commented on pull request #21690: [FLINK-30623][runtime][bug] The canEmitBatchOfRecords should check recordWriter and changelogWriterAvailabilityProvider are available

2023-01-18 Thread GitBox
lindong28 commented on PR #21690: URL: https://github.com/apache/flink/pull/21690#issuecomment-1386947530 ``` Returns true if caller can call this method more times within a single invocation of the `PushingAsyncDataInput#emitNext` method. Otherwise returned value false means the cal

[jira] [Created] (FLINK-30736) Exclude generated sources from checkstyle

2023-01-18 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-30736: Summary: Exclude generated sources from checkstyle Key: FLINK-30736 URL: https://issues.apache.org/jira/browse/FLINK-30736 Project: Flink Issue Type:

[GitHub] [flink] lincoln-lil commented on a diff in pull request #21676: [FLINK-30662][table] Planner supports delete

2023-01-18 Thread GitBox
lincoln-lil commented on code in PR #21676: URL: https://github.com/apache/flink/pull/21676#discussion_r1073455685 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/DeletePushDownUtils.java: ## @@ -0,0 +1,283 @@ +/* + * Licensed to the Ap

[GitHub] [flink] lincoln-lil commented on a diff in pull request #21676: [FLINK-30662][table] Planner supports delete

2023-01-18 Thread GitBox
lincoln-lil commented on code in PR #21676: URL: https://github.com/apache/flink/pull/21676#discussion_r1071900617 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java: ## @@ -780,6 +784,7 @@ public CompiledPlan compileP

[jira] [Updated] (FLINK-30736) Exclude generated sources from checkstyle

2023-01-18 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-30736: - Component/s: Connector / Parent > Exclude generated sources from checkstyle > --

[jira] [Created] (FLINK-30737) Setup

2023-01-18 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-30737: Summary: Setup Key: FLINK-30737 URL: https://issues.apache.org/jira/browse/FLINK-30737 Project: Flink Issue Type: Technical Debt Reporter

[jira] [Assigned] (FLINK-30737) Setup basic CI

2023-01-18 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-30737: Assignee: Chesnay Schepler > Setup basic CI > -- > >

[jira] [Updated] (FLINK-30737) Setup basic CI

2023-01-18 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-30737: - Component/s: Connector / Parent > Setup basic CI > -- > > Ke

[jira] [Updated] (FLINK-30737) Setup basic CI

2023-01-18 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-30737: - Summary: Setup basic CI (was: Setup) > Setup basic CI > -- > >

[jira] [Updated] (FLINK-30737) Setup basic CI

2023-01-18 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-30737: - Fix Version/s: connector-parent-1.0 > Setup basic CI > -- > >

[GitHub] [flink] lincoln-lil commented on a diff in pull request #21676: [FLINK-30662][table] Planner supports delete

2023-01-18 Thread GitBox
lincoln-lil commented on code in PR #21676: URL: https://github.com/apache/flink/pull/21676#discussion_r1073356514 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/batch/sql/RowLevelDeleteTest.java: ## @@ -53,24 +57,37 @@ public RowLevelDelet

[GitHub] [flink] lincoln-lil commented on a diff in pull request #21676: [FLINK-30662][table] Planner supports delete

2023-01-18 Thread GitBox
lincoln-lil commented on code in PR #21676: URL: https://github.com/apache/flink/pull/21676#discussion_r1073455685 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/DeletePushDownUtils.java: ## @@ -0,0 +1,283 @@ +/* + * Licensed to the Ap

[GitHub] [flink] lincoln-lil commented on a diff in pull request #21676: [FLINK-30662][table] Planner supports delete

2023-01-18 Thread GitBox
lincoln-lil commented on code in PR #21676: URL: https://github.com/apache/flink/pull/21676#discussion_r1073465880 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/DeletePushDownUtils.java: ## @@ -0,0 +1,283 @@ +/* + * Licensed to the Ap

[GitHub] [flink-connector-shared-utils] zentol merged pull request #2: [FLINK-30578][build] Publish SBOM for externalized connectors

2023-01-18 Thread GitBox
zentol merged PR #2: URL: https://github.com/apache/flink-connector-shared-utils/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Updated] (FLINK-30639) Publish SBOM for externalized connectors

2023-01-18 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-30639: - Fix Version/s: connector-parent-1.0 > Publish SBOM for externalized connectors > ---

[jira] [Commented] (FLINK-30639) Publish SBOM for externalized connectors

2023-01-18 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678215#comment-17678215 ] Chesnay Schepler commented on FLINK-30639: -- connector-parent: aa659f7694d2e50df

[jira] [Created] (FLINK-30738) Disable verbose mode

2023-01-18 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-30738: Summary: Disable verbose mode Key: FLINK-30738 URL: https://issues.apache.org/jira/browse/FLINK-30738 Project: Flink Issue Type: Sub-task C

[jira] [Created] (FLINK-30739) SqlGatewayRestEndpointStatementITCase failed with NullPointer

2023-01-18 Thread Yun Tang (Jira)
Yun Tang created FLINK-30739: Summary: SqlGatewayRestEndpointStatementITCase failed with NullPointer Key: FLINK-30739 URL: https://issues.apache.org/jira/browse/FLINK-30739 Project: Flink Issue

  1   2   3   4   >