[GitHub] [flink] wuchong merged pull request #21731: [FLINK-30679][hive]Fix IndexOutOfBoundsException for Hive lookup join when column pushdown to Hive lookup table source

2023-01-29 Thread via GitHub
wuchong merged PR #21731: URL: https://github.com/apache/flink/pull/21731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

[jira] [Commented] (FLINK-30727) JoinReorderITCase.testBushyTreeJoinReorder failed due to IOException

2023-01-29 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681928#comment-17681928 ] Matthias Pohl commented on FLINK-30727: --- https://dev.azure.com/apache-flink/apache

[GitHub] [flink] LadyForest commented on a diff in pull request #21771: [FLINK-30692][sql-client] Introduce SingleSessionManager to support REMOVE JAR syntax

2023-01-29 Thread via GitHub
LadyForest commented on code in PR #21771: URL: https://github.com/apache/flink/pull/21771#discussion_r1090258934 ## flink-table/flink-sql-client/src/test/resources/sql/function.q: ## @@ -218,10 +218,9 @@ org.apache.flink.table.api.ValidationException: Alter temporary catalog f

[GitHub] [flink] LadyForest commented on a diff in pull request #21771: [FLINK-30692][sql-client] Introduce SingleSessionManager to support REMOVE JAR syntax

2023-01-29 Thread via GitHub
LadyForest commented on code in PR #21771: URL: https://github.com/apache/flink/pull/21771#discussion_r1090258318 ## flink-table/flink-sql-client/src/test/resources/sql/set.q: ## @@ -118,14 +118,13 @@ SELECT hive_add_one(1); Received a total of 1 row !ok -# TODO: support thi

[jira] [Commented] (FLINK-30792) clean up not uploaded state changes after materialization complete

2023-01-29 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681924#comment-17681924 ] Hangxiang Yu commented on FLINK-30792: -- IIUC, notuploaded will be truncated after m

[jira] [Commented] (FLINK-28440) EventTimeWindowCheckpointingITCase failed with restore

2023-01-29 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681922#comment-17681922 ] Yuan Mei commented on FLINK-28440: -- [~Yanfei Lei] will take a look first. If it cannot

[jira] [Commented] (FLINK-29427) LookupJoinITCase failed with classloader problem

2023-01-29 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681923#comment-17681923 ] lincoln lee commented on FLINK-29427: - https://dev.azure.com/apache-flink/apache-fli

[jira] [Assigned] (FLINK-28440) EventTimeWindowCheckpointingITCase failed with restore

2023-01-29 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuan Mei reassigned FLINK-28440: Assignee: Yanfei Lei (was: Yuan Mei) > EventTimeWindowCheckpointingITCase failed with restore >

[GitHub] [flink] luoyuxia commented on pull request #21775: [FLINK-29878][hive] Include libfb303 to fix fail to use flink-sql-connector-hive-3.1.3

2023-01-29 Thread via GitHub
luoyuxia commented on PR #21775: URL: https://github.com/apache/flink/pull/21775#issuecomment-1408117432 @PatrickRen Thanks for your reviewing and advice. I'll consider to add the e2e test for hvie connector. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] PatrickRen merged pull request #21775: [FLINK-29878][hive] Include libfb303 to fix fail to use flink-sql-connector-hive-3.1.3

2023-01-29 Thread via GitHub
PatrickRen merged PR #21775: URL: https://github.com/apache/flink/pull/21775 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[GitHub] [flink] LadyForest commented on a diff in pull request #21771: [FLINK-30692][sql-client] Introduce SingleSessionManager to support REMOVE JAR syntax

2023-01-29 Thread via GitHub
LadyForest commented on code in PR #21771: URL: https://github.com/apache/flink/pull/21771#discussion_r1090161462 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/session/SessionManagerImpl.java: ## @@ -0,0 +1,218 @@ +/* + * Licensed to the A

[GitHub] [flink] LadyForest commented on a diff in pull request #21771: [FLINK-30692][sql-client] Introduce SingleSessionManager to support REMOVE JAR syntax

2023-01-29 Thread via GitHub
LadyForest commented on code in PR #21771: URL: https://github.com/apache/flink/pull/21771#discussion_r1090161462 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/session/SessionManagerImpl.java: ## @@ -0,0 +1,218 @@ +/* + * Licensed to the A

[GitHub] [flink] lincoln-lil commented on pull request #21698: [FLINK-30665][table] Planner supports row-level update

2023-01-29 Thread via GitHub
lincoln-lil commented on PR #21698: URL: https://github.com/apache/flink/pull/21698#issuecomment-1408086690 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[jira] [Commented] (FLINK-30807) State Processor API - Overwrite Support for Savepoints

2023-01-29 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681910#comment-17681910 ] Hangxiang Yu commented on FLINK-30807: -- It's a bit strange to descirbe whether a sa

[jira] [Commented] (FLINK-30729) AggregateITCase generates stacktraces of IllegalStateExceptions in Maven output but doesn't fail

2023-01-29 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681908#comment-17681908 ] Yanfei Lei commented on FLINK-30729: Sorry for the late reply, I'll take a look.  >

[jira] [Commented] (FLINK-30807) State Processor API - Overwrite Support for Savepoints

2023-01-29 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681904#comment-17681904 ] Yanfei Lei commented on FLINK-30807: Hi [~rionmonster], I think it's a good idea to

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #199: [demo-only] Refactor modules

2023-01-29 Thread via GitHub
lindong28 commented on code in PR #199: URL: https://github.com/apache/flink-ml/pull/199#discussion_r1090214298 ## flink-ml-servable-core/pom.xml: ## @@ -0,0 +1,74 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #199: [demo-only] Refactor modules

2023-01-29 Thread via GitHub
lindong28 commented on code in PR #199: URL: https://github.com/apache/flink-ml/pull/199#discussion_r1090214298 ## flink-ml-servable-core/pom.xml: ## @@ -0,0 +1,74 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #199: [demo-only] Refactor modules

2023-01-29 Thread via GitHub
lindong28 commented on code in PR #199: URL: https://github.com/apache/flink-ml/pull/199#discussion_r1090214298 ## flink-ml-servable-core/pom.xml: ## @@ -0,0 +1,74 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:

[GitHub] [flink] hehuiyuan commented on pull request #21731: [FLINK-30679][hive]Fix IndexOutOfBoundsException for Hive lookup join when column pushdown to Hive lookup table source

2023-01-29 Thread via GitHub
hehuiyuan commented on PR #21731: URL: https://github.com/apache/flink/pull/21731#issuecomment-1408060344 Hi @luoyuxia , passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [flink-training] alpinegizmo commented on pull request #55: Module1 Changes

2023-01-29 Thread via GitHub
alpinegizmo commented on PR #55: URL: https://github.com/apache/flink-training/pull/55#issuecomment-1408004164 Thank you for your contribution. However, we don't want the exercises to work out-of-the-box. Solutions are provided if you want to see how to satisfy each use case. The purp

[GitHub] [flink-training] alpinegizmo closed pull request #55: Module1 Changes

2023-01-29 Thread via GitHub
alpinegizmo closed pull request #55: Module1 Changes URL: https://github.com/apache/flink-training/pull/55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [flink-training] alpinegizmo closed pull request #52: FLK-828: Flink Level 1 - Module 1 Training

2023-01-29 Thread via GitHub
alpinegizmo closed pull request #52: FLK-828: Flink Level 1 - Module 1 Training URL: https://github.com/apache/flink-training/pull/52 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [flink-training] alpinegizmo commented on pull request #52: FLK-828: Flink Level 1 - Module 1 Training

2023-01-29 Thread via GitHub
alpinegizmo commented on PR #52: URL: https://github.com/apache/flink-training/pull/52#issuecomment-1408003735 Thank you for your contribution. However, we don't want the exercises to work out-of-the-box. Solutions are provided if you want to see how to satisfy each use case. The purp

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21779: [FLINK-30624][runtime] Introduce a new HeapPriorityQueue for StatusWatermarkValve to avoid affecting the performance of memory sta

2023-01-29 Thread via GitHub
zhuzhurk commented on code in PR #21779: URL: https://github.com/apache/flink/pull/21779#discussion_r1090163123 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/watermarkstatus/HeapPriorityQueue.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache So

[GitHub] [flink] Aitozi commented on pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

2023-01-29 Thread via GitHub
Aitozi commented on PR #21522: URL: https://github.com/apache/flink/pull/21522#issuecomment-1407970282 @luoyuxia thanks for your review, I will take a look and fix your comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] flinkbot commented on pull request #21781: [BP-1.16][FLINK-30567][hive] Fix wrong behavior for insert overwrite with Hive dialect when the table contains uppercase character

2023-01-29 Thread via GitHub
flinkbot commented on PR #21781: URL: https://github.com/apache/flink/pull/21781#issuecomment-1407966117 ## CI report: * 4c05f7b8761ea114c23a03ec1fc026e49400ac5a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-ml] Mrmachiner commented on a diff in pull request #28: [FLINK-24556] Add Estimator and Transformer for logistic regression

2023-01-29 Thread via GitHub
Mrmachiner commented on code in PR #28: URL: https://github.com/apache/flink-ml/pull/28#discussion_r1090156990 ## flink-ml-lib/src/main/java/org/apache/flink/ml/classification/linear/LogisticRegression.java: ## @@ -0,0 +1,653 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [flink] luoyuxia commented on pull request #21781: [BP-1.16][FLINK-30567][hive] Fix wrong behavior for insert overwrite with Hive dialect when the table contains uppercase character

2023-01-29 Thread via GitHub
luoyuxia commented on PR #21781: URL: https://github.com/apache/flink/pull/21781#issuecomment-1407961800 Let's wait the ci pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [flink] luoyuxia opened a new pull request, #21781: [BP-1.16][FLINK-30567][hive] Fix wrong behavior for insert overwrite with Hive dialect when the table contains uppercase character

2023-01-29 Thread via GitHub
luoyuxia opened a new pull request, #21781: URL: https://github.com/apache/flink/pull/21781 ## What is the purpose of the change Backport of #21602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [flink] luoyuxia commented on pull request #21698: [FLINK-30665][table] Planner supports row-level update

2023-01-29 Thread via GitHub
luoyuxia commented on PR #21698: URL: https://github.com/apache/flink/pull/21698#issuecomment-1407954960 @lincoln-lil Thanks for reviewing. Now I move the test for the statements that neither belong to DDL nor DML to `SqlOtherOperationConverterTest` -- This is an automated message from t

[jira] [Updated] (FLINK-30567) Wrong insert overwrite behavior when the table contains uppercase character with Hive dialect

2023-01-29 Thread Jing Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhang updated FLINK-30567: --- Description: If use hive dialect, the data would be wrong if we rerun the following job multiple ta

[GitHub] [flink] flinkbot commented on pull request #21780: [FLINK-30685][runtime] Support mark the transformations whose parallelism is infected by the input transformation

2023-01-29 Thread via GitHub
flinkbot commented on PR #21780: URL: https://github.com/apache/flink/pull/21780#issuecomment-1407947621 ## CI report: * dfe78c6c66f56ca84de0e346ccba21647289595c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] luoyuxia commented on pull request #21698: [FLINK-30665][table] Planner supports row-level update

2023-01-29 Thread via GitHub
luoyuxia commented on PR #21698: URL: https://github.com/apache/flink/pull/21698#issuecomment-1407946635 > @luoyuxia thanks for your update! I have a minor comment for the test splitting: although there is no strict guideline on how to classify various sql commands, it is clearly inappropri

[jira] [Commented] (FLINK-30567) Wrong insert overwrite behavior when the table contains uppercase character with Hive dialect

2023-01-29 Thread Jing Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681879#comment-17681879 ] Jing Zhang commented on FLINK-30567: [~luoyuxia] Since the bug is introduced since 1

[jira] [Updated] (FLINK-30567) Wrong insert overwrite behavior when the table contains uppercase character with Hive dialect

2023-01-29 Thread Jing Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhang updated FLINK-30567: --- Affects Version/s: (was: 1.16.2) > Wrong insert overwrite behavior when the table contains uppe

[jira] [Updated] (FLINK-30567) Wrong insert overwrite behavior when the table contains uppercase character with Hive dialect

2023-01-29 Thread Jing Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhang updated FLINK-30567: --- Fix Version/s: 1.17 Affects Version/s: 1.16.0 1.16.1

[jira] [Resolved] (FLINK-30567) Wrong insert overwrite behavior when the table contains uppercase character with Hive dialect

2023-01-29 Thread Jing Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhang resolved FLINK-30567. Assignee: luoyuxia Resolution: Fixed > Wrong insert overwrite behavior when the table conta

[jira] [Commented] (FLINK-30567) Wrong insert overwrite behavior when the table contains uppercase character with Hive dialect

2023-01-29 Thread Jing Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681877#comment-17681877 ] Jing Zhang commented on FLINK-30567: Fixed in master: 06dc85aa67d7abb9e44102544588ea

[GitHub] [flink] beyond1920 merged pull request #21602: [FLINK-30567][hive] Fix wrong behavior for insert overwrite with Hive dialect when the table contains uppercase character

2023-01-29 Thread via GitHub
beyond1920 merged PR #21602: URL: https://github.com/apache/flink/pull/21602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[GitHub] [flink] JunRuiLee commented on pull request #21780: [FLINK-30685][runtime] Support mark the transformations whose parallelism is infected by the input transformation

2023-01-29 Thread via GitHub
JunRuiLee commented on PR #21780: URL: https://github.com/apache/flink/pull/21780#issuecomment-1407940541 @zhuzhurk Could you help to review this pr? Thanks a lot! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[jira] [Updated] (FLINK-30685) Support mark the transformations whose parallelism is infected by the input transformation

2023-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30685: --- Labels: pull-request-available (was: ) > Support mark the transformations whose parallelism

[GitHub] [flink] JunRuiLee opened a new pull request, #21780: [FLINK-30685][runtime] Support mark the transformations whose parallelism is infected by the input transformation

2023-01-29 Thread via GitHub
JunRuiLee opened a new pull request, #21780: URL: https://github.com/apache/flink/pull/21780 ## What is the purpose of the change In order to chain operators together as much as possible, many downstream operators will use the parallelism of upstream input operators in the tab

[GitHub] [flink] luoyuxia commented on pull request #21703: [FLINK-29880][hive] Introduce auto compaction for Hive sink in batch mode

2023-01-29 Thread via GitHub
luoyuxia commented on PR #21703: URL: https://github.com/apache/flink/pull/21703#issuecomment-1407938579 @lsyldliu Thanks for reviewing. I have addressed your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [flink-ml] Fanoid commented on a diff in pull request #199: [demo-only] Refactor modules

2023-01-29 Thread via GitHub
Fanoid commented on code in PR #199: URL: https://github.com/apache/flink-ml/pull/199#discussion_r1090141977 ## flink-ml-servable-core/pom.xml: ## @@ -0,0 +1,74 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:sch

[GitHub] [flink] luoyuxia commented on a diff in pull request #21703: [FLINK-29880][hive] Introduce auto compaction for Hive sink in batch mode

2023-01-29 Thread via GitHub
luoyuxia commented on code in PR #21703: URL: https://github.com/apache/flink/pull/21703#discussion_r1090136470 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableCompactSinkITCase.java: ## @@ -0,0 +1,209 @@ +/* + * Licensed to the A

[GitHub] [flink] luoyuxia commented on pull request #21731: [FLINK-30679][hive]Fix IndexOutOfBoundsException for Hive lookup join when column pushdown to Hive lookup table source

2023-01-29 Thread via GitHub
luoyuxia commented on PR #21731: URL: https://github.com/apache/flink/pull/21731#issuecomment-1407917191 @hehuiyuan If the ci pass, please ping me. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [flink] luoyuxia commented on pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

2023-01-29 Thread via GitHub
luoyuxia commented on PR #21522: URL: https://github.com/apache/flink/pull/21522#issuecomment-1407916255 @Aitozi FYI. About one year ago, I also review a pr of migrate TableSchema to Schema, https://github.com/fapaul/flink/commit/f8af0e9b4756924e18febbd99e95336c07877131 but the author m

[jira] [Updated] (FLINK-30820) Support varchar and char for spark in table store

2023-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30820: --- Labels: pull-request-available (was: ) > Support varchar and char for spark in table store

[GitHub] [flink] luoyuxia commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

2023-01-29 Thread via GitHub
luoyuxia commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1090119274 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSink.java: ## @@ -558,14 +559,14 @@ private HadoopFileSystemFactory fs

[GitHub] [flink-table-store] zjureel opened a new pull request, #490: [FLINK-30820] Support varchar/char in spark

2023-01-29 Thread via GitHub
zjureel opened a new pull request, #490: URL: https://github.com/apache/flink-table-store/pull/490 Support varchar/char in spark -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[jira] [Commented] (FLINK-30821) The optimized exec plan generated by OverAggregateTest#testDiffPartitionKeysWithDiffOrderKeys2 in the case of all-blocking is not as expected

2023-01-29 Thread Junrui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681853#comment-17681853 ] Junrui Li commented on FLINK-30821: --- cc [~zhuzh] [~godfrey]  > The optimized exec pla

[GitHub] [flink] JunRuiLee commented on a diff in pull request #21672: [FLINK-30683][runtime] Make adaptive batch scheduler as the default batch scheduler

2023-01-29 Thread via GitHub
JunRuiLee commented on code in PR #21672: URL: https://github.com/apache/flink/pull/21672#discussion_r1090132553 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/batch/sql/agg/OverAggregateTest.xml: ## @@ -71,17 +75,21 @@ LogicalProject(E

[jira] [Commented] (FLINK-29125) Placeholder in Apache Flink Web Frontend to display some "tags" to distinguish between frontends of different clusters

2023-01-29 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681852#comment-17681852 ] Xintong Song commented on FLINK-29125: -- Actually, I'm not entirely sure whether thi

[jira] [Updated] (FLINK-30821) The optimized exec plan generated by OverAggregateTest#testDiffPartitionKeysWithDiffOrderKeys2 in the case of all-blocking is not as expected

2023-01-29 Thread Junrui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junrui Li updated FLINK-30821: -- Description: The optimized exec plan generated by OverAggregateTest#testDiffPartitionKeysWithDiffOrde

[jira] [Created] (FLINK-30821) The optimized exec plan generated by OverAggregateTest#testDiffPartitionKeysWithDiffOrderKeys2 in the case of all-blocking is not as expected

2023-01-29 Thread Junrui Li (Jira)
Junrui Li created FLINK-30821: - Summary: The optimized exec plan generated by OverAggregateTest#testDiffPartitionKeysWithDiffOrderKeys2 in the case of all-blocking is not as expected Key: FLINK-30821 URL: https://iss

[jira] [Resolved] (FLINK-30816) Fix Sql Client always uses the packaged highests version to connect to gateway

2023-01-29 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang resolved FLINK-30816. --- Resolution: Implemented Merged into master: cc6315a3e82c570e631684793d08ca9cb5403521 > Fix

[jira] [Closed] (FLINK-30816) Fix Sql Client always uses the packaged highests version to connect to gateway

2023-01-29 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang closed FLINK-30816. - > Fix Sql Client always uses the packaged highests version to connect to gateway > -

[GitHub] [flink] fsk119 closed pull request #21776: [FLINK-30816][sql-client] Fix SQL Client always uses the highest packaged version to connect to gateway

2023-01-29 Thread via GitHub
fsk119 closed pull request #21776: [FLINK-30816][sql-client] Fix SQL Client always uses the highest packaged version to connect to gateway URL: https://github.com/apache/flink/pull/21776 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[jira] [Commented] (FLINK-29125) Placeholder in Apache Flink Web Frontend to display some "tags" to distinguish between frontends of different clusters

2023-01-29 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681848#comment-17681848 ] Xintong Song commented on FLINK-29125: -- Sorry for joining the discussion late. I t

[GitHub] [flink-ml] vacaly commented on a diff in pull request #192: [FLINK-30451] Add Estimator and Transformer for Swing

2023-01-29 Thread via GitHub
vacaly commented on code in PR #192: URL: https://github.com/apache/flink-ml/pull/192#discussion_r1090127528 ## flink-ml-lib/src/main/java/org/apache/flink/ml/recommendation/swing/Swing.java: ## @@ -0,0 +1,444 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #199: [demo-only] Refactor modules

2023-01-29 Thread via GitHub
lindong28 commented on code in PR #199: URL: https://github.com/apache/flink-ml/pull/199#discussion_r1090125842 ## flink-ml-servable-core/pom.xml: ## @@ -0,0 +1,74 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:

[GitHub] [flink] JunRuiLee commented on pull request #21772: [FLINK-30684][runtime] Use the default parallelism as a flag for vertices that can automatically derive parallelism.

2023-01-29 Thread via GitHub
JunRuiLee commented on PR #21772: URL: https://github.com/apache/flink/pull/21772#issuecomment-1407899106 @zhuzhurk I have addressed all comments, please take a look, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [flink] lsyldliu commented on a diff in pull request #21703: [FLINK-29880][hive] Introduce auto compaction for Hive sink in batch mode

2023-01-29 Thread via GitHub
lsyldliu commented on code in PR #21703: URL: https://github.com/apache/flink/pull/21703#discussion_r1090124175 ## docs/content.zh/docs/connectors/table/hive/hive_read_write.md: ## @@ -528,6 +528,69 @@ INSERT INTO TABLE fact_tz PARTITION (day, hour) select 1, '2022-8-8', '14';

[GitHub] [flink-ml] Fanoid commented on a diff in pull request #199: [demo-only] Refactor modules

2023-01-29 Thread via GitHub
Fanoid commented on code in PR #199: URL: https://github.com/apache/flink-ml/pull/199#discussion_r1090122715 ## flink-ml-servable-core/pom.xml: ## @@ -0,0 +1,74 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:sch

[GitHub] [flink-training] ness-swathigottumukkala closed pull request #54: Module1 changes

2023-01-29 Thread via GitHub
ness-swathigottumukkala closed pull request #54: Module1 changes URL: https://github.com/apache/flink-training/pull/54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [flink-training] ness-swathigottumukkala closed pull request #53: Changes for the flink training exercises module 1

2023-01-29 Thread via GitHub
ness-swathigottumukkala closed pull request #53: Changes for the flink training exercises module 1 URL: https://github.com/apache/flink-training/pull/53 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] godfreyhe commented on a diff in pull request #21672: [FLINK-30683][runtime] Make adaptive batch scheduler as the default batch scheduler

2023-01-29 Thread via GitHub
godfreyhe commented on code in PR #21672: URL: https://github.com/apache/flink/pull/21672#discussion_r1090118956 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/batch/sql/agg/OverAggregateTest.xml: ## @@ -71,17 +75,21 @@ LogicalProject(E

[GitHub] [flink] fsk119 commented on a diff in pull request #21776: [FLINK-30816][sql-client] Fix SQL Client always uses the highest packaged version to connect to gateway

2023-01-29 Thread via GitHub
fsk119 commented on code in PR #21776: URL: https://github.com/apache/flink/pull/21776#discussion_r1090118401 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/ExecutorImpl.java: ## @@ -429,4 +453,46 @@ private CompletableFuture closeOperationA

[jira] [Commented] (FLINK-30770) OUTER join generates partial results

2023-01-29 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681831#comment-17681831 ] lincoln lee commented on FLINK-30770: - AFAIK, this behavior is by design for now. Bo

[GitHub] [flink] zoltar9264 commented on a diff in pull request #21679: [FLINK-30561][state/changelog] fix changelog local cache file not found

2023-01-29 Thread via GitHub
zoltar9264 commented on code in PR #21679: URL: https://github.com/apache/flink/pull/21679#discussion_r1090117476 ## flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStreamHandleReaderWithCache.java: ## @@ -161,23 +161,28 @@ private FileInputStream

[GitHub] [flink] fsk119 commented on pull request #21776: [FLINK-30816][sql-client] Fix SQL Client always uses the highest packaged version to connect to gateway

2023-01-29 Thread via GitHub
fsk119 commented on PR #21776: URL: https://github.com/apache/flink/pull/21776#issuecomment-1407881956 In my private pipeline, all tests pass. https://dev.azure.com/1059623455/Flink/_build/results?buildId=518&view=results -- This is an automated message from the Apache Git Service

[jira] [Created] (FLINK-30820) Support varchar and char for spark in table store

2023-01-29 Thread Shammon (Jira)
Shammon created FLINK-30820: --- Summary: Support varchar and char for spark in table store Key: FLINK-30820 URL: https://issues.apache.org/jira/browse/FLINK-30820 Project: Flink Issue Type: Improveme

[GitHub] [flink] fsk119 commented on pull request #21776: [FLINK-30816][sql-client] Fix SQL Client always uses the highest packaged version to connect to gateway

2023-01-29 Thread via GitHub
fsk119 commented on PR #21776: URL: https://github.com/apache/flink/pull/21776#issuecomment-1407881373 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [flink-training] ness-swathigottumukkala opened a new pull request, #53: Changes for the flink training exercises module 1

2023-01-29 Thread via GitHub
ness-swathigottumukkala opened a new pull request, #53: URL: https://github.com/apache/flink-training/pull/53 ProcessFunction and Timers (Long Ride Alerts) module 1 training eercise changes -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink] lsyldliu commented on a diff in pull request #21601: [FLINK-29720][hive] Supports native avg function for hive dialect

2023-01-29 Thread via GitHub
lsyldliu commented on code in PR #21601: URL: https://github.com/apache/flink/pull/21601#discussion_r1090116744 ## docs/content.zh/docs/connectors/table/hive/hive_functions.md: ## @@ -73,6 +73,31 @@ Some Hive built-in functions in older versions have [thread safety issues](http

[GitHub] [flink] godfreyhe commented on a diff in pull request #21672: [FLINK-30683][runtime] Make adaptive batch scheduler as the default batch scheduler

2023-01-29 Thread via GitHub
godfreyhe commented on code in PR #21672: URL: https://github.com/apache/flink/pull/21672#discussion_r1090115984 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/batch/sql/DagOptimizationTest.xml: ## @@ -273,7 +273,7 @@ Calc(select=[a AS

[jira] [Closed] (FLINK-30814) The parallelism&maxParallelism of sort after a global partitioning is not forced to be 1

2023-01-29 Thread Godfrey He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Godfrey He closed FLINK-30814. -- Resolution: Fixed Fixed in 1.17.0: 916ff76b61a0bfa8283d52be53cd33e317d0d550 > The parallelism&maxPara

[GitHub] [flink] godfreyhe closed pull request #21777: [FLINK-30814][table-planner] Fix maxParallelism is not forced to 1 after global partitioner

2023-01-29 Thread via GitHub
godfreyhe closed pull request #21777: [FLINK-30814][table-planner] Fix maxParallelism is not forced to 1 after global partitioner URL: https://github.com/apache/flink/pull/21777 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (FLINK-28596) Support writing arrays to postgres array columns in Flink SQL JDBC connector

2023-01-29 Thread Bobby Richard (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681823#comment-17681823 ] Bobby Richard commented on FLINK-28596: --- [~martijnvisser] Sorry I completely forgo

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21672: [FLINK-30683][runtime] Make adaptive batch scheduler as the default batch scheduler

2023-01-29 Thread via GitHub
zhuzhurk commented on code in PR #21672: URL: https://github.com/apache/flink/pull/21672#discussion_r1090097778 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/batch/sql/MultipleInputCreationTest.scala: ## @@ -355,5 +355,5 @@ object Multiple

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21672: [FLINK-30683][runtime] Make adaptive batch scheduler as the default batch scheduler

2023-01-29 Thread via GitHub
zhuzhurk commented on code in PR #21672: URL: https://github.com/apache/flink/pull/21672#discussion_r1090097606 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/batch/sql/DynamicFilteringITCase.java: ## @@ -48,9 +48,7 @@ public class Dynami

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21672: [FLINK-30683][runtime] Make adaptive batch scheduler as the default batch scheduler

2023-01-29 Thread via GitHub
zhuzhurk commented on code in PR #21672: URL: https://github.com/apache/flink/pull/21672#discussion_r1090097326 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/batch/sql/join/LookupJoinTest.xml: ## @@ -663,7 +663,7 @@ Calc(select=[EXPR$0

[GitHub] [flink] flinkbot commented on pull request #21779: [FLINK-30624][runtime] Introduce a new HeapPriorityQueue for StatusWatermarkValve to avoid affecting the performance of memory state backend

2023-01-29 Thread via GitHub
flinkbot commented on PR #21779: URL: https://github.com/apache/flink/pull/21779#issuecomment-1407830658 ## CI report: * 6e6778861bcdf4fc6b19f3f978f764190575cc21 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30624) Performance regression in stateBackends.FS / FS_ASYNC / MEMORY on 05.01.2023

2023-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30624: --- Labels: pull-request-available (was: ) > Performance regression in stateBackends.FS / FS_AS

[GitHub] [flink] wanglijie95 opened a new pull request, #21779: [FLINK-30624][runtime] Introduce a new HeapPriorityQueue for StatusWatermarkValve to avoid affecting the performance of memory state bac

2023-01-29 Thread via GitHub
wanglijie95 opened a new pull request, #21779: URL: https://github.com/apache/flink/pull/21779 ## What is the purpose of the change Fix the performance regression described in FLINK-30624. ``` before this fix: Benchmark (stateBackend) Mode Cnt

[jira] [Updated] (FLINK-30561) ChangelogStreamHandleReaderWithCache cause FileNotFoundException

2023-01-29 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-30561: -- Fix Version/s: 1.17.0 1.16.1 > ChangelogStreamHandleReaderWithCache

[jira] [Assigned] (FLINK-30561) ChangelogStreamHandleReaderWithCache cause FileNotFoundException

2023-01-29 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan reassigned FLINK-30561: - Assignee: Feifan Wang > ChangelogStreamHandleReaderWithCache cause FileNotFound

[jira] [Updated] (FLINK-30561) ChangelogStreamHandleReaderWithCache cause FileNotFoundException

2023-01-29 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-30561: -- Affects Version/s: 1.17.0 > ChangelogStreamHandleReaderWithCache cause FileNotFoundExc

[GitHub] [flink] JunRuiLee commented on pull request #21672: [FLINK-30683][runtime] Make adaptive batch scheduler as the default batch scheduler

2023-01-29 Thread via GitHub
JunRuiLee commented on PR #21672: URL: https://github.com/apache/flink/pull/21672#issuecomment-1407762903 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-25920) Allow receiving updates of CommittableSummary

2023-01-29 Thread Jun Qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681793#comment-17681793 ] Jun Qin commented on FLINK-25920: - >From what I can see, this still happens in 1.15.3: {

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21772: [FLINK-30684][runtime] Use the default parallelism as a flag for vertices that can automatically derive parallelism.

2023-01-29 Thread via GitHub
zhuzhurk commented on code in PR #21772: URL: https://github.com/apache/flink/pull/21772#discussion_r1089997741 ## flink-core/src/main/java/org/apache/flink/api/dag/Transformation.java: ## @@ -111,6 +112,8 @@ // This is used to assign a unique ID to every Transformation

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21679: [FLINK-30561][state/changelog] fix changelog local cache file not found

2023-01-29 Thread via GitHub
rkhachatryan commented on code in PR #21679: URL: https://github.com/apache/flink/pull/21679#discussion_r1090006907 ## flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStreamHandleReaderWithCache.java: ## @@ -161,23 +161,28 @@ private FileInputStrea

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21679: [FLINK-30561][state/changelog] fix changelog local cache file not found

2023-01-29 Thread via GitHub
rkhachatryan commented on code in PR #21679: URL: https://github.com/apache/flink/pull/21679#discussion_r1090006907 ## flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStreamHandleReaderWithCache.java: ## @@ -161,23 +161,28 @@ private FileInputStrea

[GitHub] [flink] swuferhong commented on pull request #21724: [FLINK-30727][table-planner] Fix JoinReorderITCaseBase.testBushyTreeJoinReorder failed

2023-01-29 Thread via GitHub
swuferhong commented on PR #21724: URL: https://github.com/apache/flink/pull/21724#issuecomment-1407710475 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [flink] afedulov commented on pull request #20049: [FLINK-28046][connectors] Mark SourceFunction interface as @Deprecated

2023-01-29 Thread via GitHub
afedulov commented on PR #20049: URL: https://github.com/apache/flink/pull/20049#issuecomment-1407709550 @MartijnVisser unfortunately CI did not capture all failures caused by our strict checks for deprecated APIs in `flink-examples` at once. Now that the original sources listed in [FLI

[jira] [Comment Edited] (FLINK-30624) Performance regression in stateBackends.FS / FS_ASYNC / MEMORY on 05.01.2023

2023-01-29 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681756#comment-17681756 ] Lijie Wang edited comment on FLINK-30624 at 1/29/23 3:51 PM: -

[jira] [Comment Edited] (FLINK-30624) Performance regression in stateBackends.FS / FS_ASYNC / MEMORY on 05.01.2023

2023-01-29 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681756#comment-17681756 ] Lijie Wang edited comment on FLINK-30624 at 1/29/23 3:49 PM: -

[jira] [Comment Edited] (FLINK-30624) Performance regression in stateBackends.FS / FS_ASYNC / MEMORY on 05.01.2023

2023-01-29 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681756#comment-17681756 ] Lijie Wang edited comment on FLINK-30624 at 1/29/23 3:43 PM: -

[jira] [Commented] (FLINK-30624) Performance regression in stateBackends.FS / FS_ASYNC / MEMORY on 05.01.2023

2023-01-29 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681756#comment-17681756 ] Lijie Wang commented on FLINK-30624: After an offline discussion with [~zhuzh], we b

  1   2   >