[jira] [Commented] (FLINK-18356) flink-table-planner Exit code 137 returned from process

2023-02-06 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685114#comment-17685114 ] Matthias Pohl commented on FLINK-18356: ---

[jira] [Commented] (FLINK-30757) Ugrade busybox version to a pinned version for operator

2023-02-06 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685113#comment-17685113 ] Gabor Somogyi commented on FLINK-30757: --- Happy to see contributors :) > Ugrade busybox version to

[GitHub] [flink] flinkbot commented on pull request #21878: [FLINK-30817] Fix ClassCastException in TestValuesTableFactory

2023-02-06 Thread via GitHub
flinkbot commented on PR #21878: URL: https://github.com/apache/flink/pull/21878#issuecomment-1420315623 ## CI report: * 79a8d0a6e81453cc5b8a19f47d8fb1601e760e34 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21801: [FLINK-30838][doc] Update documentation about the AdaptiveBatchScheduler

2023-02-06 Thread via GitHub
zhuzhurk commented on code in PR #21801: URL: https://github.com/apache/flink/pull/21801#discussion_r1098265457 ## docs/content/docs/deployment/speculative_execution.md: ## @@ -52,15 +52,14 @@ in near future. DataStream API is now the recommended low level API to develop F

[GitHub] [flink] flinkbot commented on pull request #21877: [FLINK-30925][docs] Add docs about SQL Client remote mode

2023-02-06 Thread via GitHub
flinkbot commented on PR #21877: URL: https://github.com/apache/flink/pull/21877#issuecomment-1420310015 ## CI report: * 3c5f0d0e9ff27ddeb952bc505d3f5cf9f328de17 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21801: [FLINK-30838][doc] Update documentation about the AdaptiveBatchScheduler

2023-02-06 Thread via GitHub
zhuzhurk commented on code in PR #21801: URL: https://github.com/apache/flink/pull/21801#discussion_r1098263375 ## docs/content/docs/deployment/elastic_scaling.md: ## @@ -161,30 +161,28 @@ The Adaptive Batch Scheduler can automatically decide parallelisms of operators To

[jira] [Updated] (FLINK-30934) Refactor ComputedColumnAndWatermarkTableITCase to get rid of managed table

2023-02-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30934: --- Labels: pull-request-available (was: ) > Refactor ComputedColumnAndWatermarkTableITCase to

[GitHub] [flink-table-store] yuzelin opened a new pull request, #506: [FLINK-30934] Refactor ComputedColumnAndWatermarkTableITCase to get rid of managed table

2023-02-06 Thread via GitHub
yuzelin opened a new pull request, #506: URL: https://github.com/apache/flink-table-store/pull/506 Main changes: 1. Refactor `ComputedColumnAndWatermarkTableITCase`. 2. Clean test util classes. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] shuiqiangchen commented on pull request #21878: [FLINK-30817] Fix ClassCastException in TestValuesTableFactory

2023-02-06 Thread via GitHub
shuiqiangchen commented on PR #21878: URL: https://github.com/apache/flink/pull/21878#issuecomment-1420308108 Hi, @luoyuxia Could you please help review the PR. This PR is a simple bug fix, so currently there is test case for it. If it's necessary, I will add one. What do you think? --

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #205: [FLINK-30730] Fix null values handling in StringIndexer and StringIndexerModel

2023-02-06 Thread via GitHub
zhipeng93 commented on code in PR #205: URL: https://github.com/apache/flink-ml/pull/205#discussion_r1098259151 ## flink-ml-lib/src/test/java/org/apache/flink/ml/feature/stringindexer/StringIndexerTest.java: ## @@ -53,6 +55,9 @@ public class StringIndexerTest extends

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #205: [FLINK-30730] Fix null values handling in StringIndexer and StringIndexerModel

2023-02-06 Thread via GitHub
zhipeng93 commented on code in PR #205: URL: https://github.com/apache/flink-ml/pull/205#discussion_r1098259151 ## flink-ml-lib/src/test/java/org/apache/flink/ml/feature/stringindexer/StringIndexerTest.java: ## @@ -53,6 +55,9 @@ public class StringIndexerTest extends

[jira] [Updated] (FLINK-30817) ClassCastException in TestValuesTableFactory.TestValuesScanTableSourceWithoutProjectionPushDown

2023-02-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30817: --- Labels: pull-request-available (was: ) > ClassCastException in >

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #205: [FLINK-30730] Fix null values handling in StringIndexer and StringIndexerModel

2023-02-06 Thread via GitHub
zhipeng93 commented on code in PR #205: URL: https://github.com/apache/flink-ml/pull/205#discussion_r1098259151 ## flink-ml-lib/src/test/java/org/apache/flink/ml/feature/stringindexer/StringIndexerTest.java: ## @@ -53,6 +55,9 @@ public class StringIndexerTest extends

[GitHub] [flink] shuiqiangchen opened a new pull request, #21878: [FLINK-30817] Fix ClassCastException in TestValuesTableFactory

2023-02-06 Thread via GitHub
shuiqiangchen opened a new pull request, #21878: URL: https://github.com/apache/flink/pull/21878 ## What is the purpose of the change * Fix the wrong class cast in TestValuesTableFactory.TestValuesScanTableSourceWithoutProjectionPushDown* ## Brief change log

[GitHub] [flink] lincoln-lil commented on pull request #21507: [FLINK-30386] Fix the issue that column constraint lacks primary key not enforced check

2023-02-06 Thread via GitHub
lincoln-lil commented on PR #21507: URL: https://github.com/apache/flink/pull/21507#issuecomment-1420303452 @LadyForest could you also create a backport pr for 1.16? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Updated] (FLINK-30386) Column constraint lacks primary key not enforced check

2023-02-06 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-30386: Fix Version/s: 1.17.0 > Column constraint lacks primary key not enforced check >

[jira] [Closed] (FLINK-30386) Column constraint lacks primary key not enforced check

2023-02-06 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-30386. --- Resolution: Fixed fixed in master: e69e6514d0b901eb03f1a8bfc499680d076248c9 > Column constraint

[jira] [Updated] (FLINK-30925) Add docs for the SQL Client gateway mode

2023-02-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30925: --- Labels: pull-request-available (was: ) > Add docs for the SQL Client gateway mode >

[GitHub] [flink] lincoln-lil merged pull request #21507: [FLINK-30386] Fix the issue that column constraint lacks primary key not enforced check

2023-02-06 Thread via GitHub
lincoln-lil merged PR #21507: URL: https://github.com/apache/flink/pull/21507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] fsk119 opened a new pull request, #21877: [FLINK-30925][docs] Add docs about SQL Client remote mode

2023-02-06 Thread via GitHub
fsk119 opened a new pull request, #21877: URL: https://github.com/apache/flink/pull/21877 ## What is the purpose of the change *Add docs about the SQL Client remote mode and update sql-gateway open api.* -- This is an automated message from the Apache Git

[jira] [Assigned] (FLINK-30757) Ugrade busybox version to a pinned version for operator

2023-02-06 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-30757: -- Assignee: Shipeng Xie > Ugrade busybox version to a pinned version for operator >

[jira] [Assigned] (FLINK-30757) Ugrade busybox version to a pinned version for operator

2023-02-06 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-30757: -- Assignee: (was: Shipeng Xie) > Ugrade busybox version to a pinned version for operator >

[jira] [Assigned] (FLINK-30757) Ugrade busybox version to a pinned version for operator

2023-02-06 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-30757: -- Assignee: Shipeng Xie > Ugrade busybox version to a pinned version for operator >

[jira] [Commented] (FLINK-30757) Ugrade busybox version to a pinned version for operator

2023-02-06 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685081#comment-17685081 ] Gyula Fora commented on FLINK-30757: Of course, go ahead:) > Ugrade busybox version to a pinned

[jira] [Created] (FLINK-30934) Refactor ComputedColumnAndWatermarkTableITCase to get rid of managed table

2023-02-06 Thread yuzelin (Jira)
yuzelin created FLINK-30934: --- Summary: Refactor ComputedColumnAndWatermarkTableITCase to get rid of managed table Key: FLINK-30934 URL: https://issues.apache.org/jira/browse/FLINK-30934 Project: Flink

[jira] [Updated] (FLINK-30933) Result of join inside iterationBody loses max watermark

2023-02-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30933: --- Labels: pull-request-available (was: ) > Result of join inside iterationBody loses max

[GitHub] [flink-ml] zhipeng93 opened a new pull request, #206: [FLINK-30933] Fix missing max watermark when executing join in iteration body

2023-02-06 Thread via GitHub
zhipeng93 opened a new pull request, #206: URL: https://github.com/apache/flink-ml/pull/206 …ion body ## What is the purpose of the change Currently, when executing join for bounded input streams in a perround iteration body, there exist two problems: - The program

[jira] [Commented] (FLINK-22793) HybridSource Table Implementation

2023-02-06 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685078#comment-17685078 ] Ran Tao commented on FLINK-22793: - [~martijnvisser] [~thw]  hi, martijn, Thomas.  This feature has been

[jira] [Closed] (FLINK-30493) FLIP 273: Improve the Catalog API to Support ALTER TABLE syntax

2023-02-06 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang closed FLINK-30493. - Resolution: Implemented > FLIP 273: Improve the Catalog API to Support ALTER TABLE syntax >

[jira] [Commented] (FLINK-30757) Ugrade busybox version to a pinned version for operator

2023-02-06 Thread Shipeng Xie (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685076#comment-17685076 ] Shipeng Xie commented on FLINK-30757: - Hi [~gaborgsomogyi] [~gyfora] , I am using the Flink k8s

[GitHub] [flink] JunRuiLee commented on pull request #21801: [FLINK-30838][doc] Update documentation about the AdaptiveBatchScheduler

2023-02-06 Thread via GitHub
JunRuiLee commented on PR #21801: URL: https://github.com/apache/flink/pull/21801#issuecomment-1420275735 @zhuzhurk Thanks for CR and I've addressed all comments, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Updated] (FLINK-30933) Result of join inside iterationBody loses max watermark

2023-02-06 Thread Zhipeng Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhipeng Zhang updated FLINK-30933: -- Description: Currently if we execute a join inside an iteration body, the following program

[jira] [Commented] (FLINK-25813) TableITCase.testCollectWithClose failed on azure

2023-02-06 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685066#comment-17685066 ] Caizhi Weng commented on FLINK-25813: - Hi [~mapohl]. Sorry for this late reply as I've almost

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21801: [FLINK-30838][doc] Update documentation about the AdaptiveBatchScheduler

2023-02-06 Thread via GitHub
zhuzhurk commented on code in PR #21801: URL: https://github.com/apache/flink/pull/21801#discussion_r1098203733 ## docs/content.zh/docs/deployment/elastic_scaling.md: ## @@ -159,30 +159,27 @@ Adaptive Batch Scheduler 是一种可以自动推导每个算子并行度的批 使用 Adaptive Batch Scheduler

[jira] [Assigned] (FLINK-30933) Result of join inside iterationBody loses max watermark

2023-02-06 Thread Zhipeng Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhipeng Zhang reassigned FLINK-30933: - Assignee: Zhipeng Zhang > Result of join inside iterationBody loses max watermark >

[jira] [Created] (FLINK-30933) Result of join inside iterationBody loses max watermark

2023-02-06 Thread Zhipeng Zhang (Jira)
Zhipeng Zhang created FLINK-30933: - Summary: Result of join inside iterationBody loses max watermark Key: FLINK-30933 URL: https://issues.apache.org/jira/browse/FLINK-30933 Project: Flink

[GitHub] [flink] lsyldliu commented on a diff in pull request #21789: [FLINK-30824][hive] Add document for option table.exec.hive.native-agg-function.enabled

2023-02-06 Thread via GitHub
lsyldliu commented on code in PR #21789: URL: https://github.com/apache/flink/pull/21789#discussion_r1098208433 ## docs/content.zh/docs/connectors/table/hive/hive_functions.md: ## @@ -73,6 +73,34 @@ Some Hive built-in functions in older versions have [thread safety

[GitHub] [flink] luoyuxia commented on pull request #21149: [FLINK-29527][formats/parquet] Make unknownFieldsIndices work for single ParquetReader

2023-02-06 Thread via GitHub
luoyuxia commented on PR #21149: URL: https://github.com/apache/flink/pull/21149#issuecomment-1420190347 @saLeox Thanks for your investigation. Won't it means it'll be more reasonable that we also introuce a option for that? @Tartarus0zm I'm a little of curious about why your company

[jira] [Commented] (FLINK-30843) Add Notifier For Autoscaler

2023-02-06 Thread Gaurav Miglani (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685055#comment-17685055 ] Gaurav Miglani commented on FLINK-30843: Ok, will do it and raise PR > Add Notifier For

[jira] [Closed] (FLINK-30648) [Umbrella]FLIP-282 Introduce Delete/Update API

2023-02-06 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-30648. --- Resolution: Fixed > [Umbrella]FLIP-282 Introduce Delete/Update API >

[jira] [Closed] (FLINK-30666) Add document for Delete/Update API

2023-02-06 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-30666. --- Resolution: Fixed fixed in master: f3608f4277e47b76d59a5ec99c21947aea8cde5b > Add document for

[jira] [Commented] (FLINK-30920) K8 cluster autoscaler | exclude operator ids from scaler

2023-02-06 Thread Gaurav Miglani (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685052#comment-17685052 ] Gaurav Miglani commented on FLINK-30920: yes you are right, but in our cases, load came

[GitHub] [flink] lincoln-lil merged pull request #21863: [FLINK-30666][doc] Add document for Delete/Update API

2023-02-06 Thread via GitHub
lincoln-lil merged PR #21863: URL: https://github.com/apache/flink/pull/21863 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-benchmarks] fredia commented on pull request #63: [FLINK-27571][benchmark] Recognize 'less is better' benchmarks in regression detection script

2023-02-06 Thread via GitHub
fredia commented on PR #63: URL: https://github.com/apache/flink-benchmarks/pull/63#issuecomment-1420181992 Right, the reports that have been generated before correcting the `units_title` are still treated as `less is better`. Thanks for your information, regenerating past reports by

[jira] [Commented] (FLINK-30908) Fatal error in ResourceManager caused YARNSessionFIFOSecuredITCase.testDetachedMode to fail

2023-02-06 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685045#comment-17685045 ] Yang Wang commented on FLINK-30908: --- +1 for Xintong's analysis and proposal. YARN-5999 introduced a

[GitHub] [flink] luoyuxia commented on a diff in pull request #21663: [FLINK-30559][Planner] Fix unexpected multiple type inference issue

2023-02-06 Thread via GitHub
luoyuxia commented on code in PR #21663: URL: https://github.com/apache/flink/pull/21663#discussion_r1098148881 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/type/NumericOrDefaultReturnTypeInference.java: ## @@ -56,11 +55,7 @@ public

[GitHub] [flink] luoyuxia commented on a diff in pull request #21663: [FLINK-30559][Planner] Fix unexpected multiple type inference issue

2023-02-06 Thread via GitHub
luoyuxia commented on code in PR #21663: URL: https://github.com/apache/flink/pull/21663#discussion_r1098148881 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/type/NumericOrDefaultReturnTypeInference.java: ## @@ -56,11 +55,7 @@ public

[GitHub] [flink] luoyuxia commented on a diff in pull request #21663: [FLINK-30559][Planner] Fix unexpected multiple type inference issue

2023-02-06 Thread via GitHub
luoyuxia commented on code in PR #21663: URL: https://github.com/apache/flink/pull/21663#discussion_r1098146682 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/type/NumericOrDefaultReturnTypeInference.java: ## @@ -56,11 +55,7 @@ public

[GitHub] [flink] luoyuxia commented on a diff in pull request #21663: [FLINK-30559][Planner] Fix unexpected multiple type inference issue

2023-02-06 Thread via GitHub
luoyuxia commented on code in PR #21663: URL: https://github.com/apache/flink/pull/21663#discussion_r1098146682 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/type/NumericOrDefaultReturnTypeInference.java: ## @@ -56,11 +55,7 @@ public

[GitHub] [flink] luoyuxia commented on a diff in pull request #21663: [FLINK-30559][Planner] Fix unexpected multiple type inference issue

2023-02-06 Thread via GitHub
luoyuxia commented on code in PR #21663: URL: https://github.com/apache/flink/pull/21663#discussion_r1098146682 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/type/NumericOrDefaultReturnTypeInference.java: ## @@ -56,11 +55,7 @@ public

[jira] [Updated] (FLINK-30908) Fatal error in ResourceManager caused YARNSessionFIFOSecuredITCase.testDetachedMode to fail

2023-02-06 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song updated FLINK-30908: - Priority: Critical (was: Blocker) > Fatal error in ResourceManager caused >

[jira] [Commented] (FLINK-30908) Fatal error in ResourceManager caused YARNSessionFIFOSecuredITCase.testDetachedMode to fail

2023-02-06 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685040#comment-17685040 ] Xintong Song commented on FLINK-30908: -- After looking more into the logs and Hadoop codes, we

[jira] [Comment Edited] (FLINK-30929) Add helpful message when ElasticsearchSink.Builder.build() throws an IllegalArgumentException.

2023-02-06 Thread Kenny Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685029#comment-17685029 ] Kenny Wu edited comment on FLINK-30929 at 2/7/23 3:36 AM: -- [~martijnvisser] I

[jira] [Commented] (FLINK-30734) KBinsDiscretizer handles Double.NaN incorrectly

2023-02-06 Thread Fan Hong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685034#comment-17685034 ] Fan Hong commented on FLINK-30734: -- Sklearn has a discussion about this feature: [1]  SparkML already

[jira] [Closed] (FLINK-30929) Add helpful message when ElasticsearchSink.Builder.build() throws an IllegalArgumentException.

2023-02-06 Thread Kenny Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kenny Wu closed FLINK-30929. Fix Version/s: 1.15.0 Resolution: Fixed > Add helpful message when

[jira] [Resolved] (FLINK-30916) RocksDBStateUploaderTest.testUploadedSstCanBeCleanedUp failed with assertion

2023-02-06 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuan Mei resolved FLINK-30916. -- Resolution: Duplicate > RocksDBStateUploaderTest.testUploadedSstCanBeCleanedUp failed with assertion

[jira] [Commented] (FLINK-30916) RocksDBStateUploaderTest.testUploadedSstCanBeCleanedUp failed with assertion

2023-02-06 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685033#comment-17685033 ] Yuan Mei commented on FLINK-30916: -- Resolved in FLINK-30461 >

[jira] [Resolved] (FLINK-30461) Some rocksdb sst files will remain forever

2023-02-06 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuan Mei resolved FLINK-30461. -- Release Note: clean-up left-over rocksdb ssts in the shared scope introduced in FLINK-11008 (Flink

[jira] [Commented] (FLINK-30929) Add helpful message when ElasticsearchSink.Builder.build() throws an IllegalArgumentException.

2023-02-06 Thread Kenny Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685029#comment-17685029 ] Kenny Wu commented on FLINK-30929: -- [~martijnvisser] I have checked the latest version. The case has

[jira] [Comment Edited] (FLINK-30461) Some rocksdb sst files will remain forever

2023-02-06 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685023#comment-17685023 ] Yuan Mei edited comment on FLINK-30461 at 2/7/23 3:19 AM: -- Thanks [~fanrui] for

[jira] [Comment Edited] (FLINK-30461) Some rocksdb sst files will remain forever

2023-02-06 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685023#comment-17685023 ] Yuan Mei edited comment on FLINK-30461 at 2/7/23 3:18 AM: -- Thanks [~fanrui] for

[jira] [Commented] (FLINK-30461) Some rocksdb sst files will remain forever

2023-02-06 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685023#comment-17685023 ] Yuan Mei commented on FLINK-30461: -- Thanks [~fanrui] for the fix and [~yanfei] for discussion and

[GitHub] [flink] curcur merged pull request #21855: [bp-1.15][FLINK-30461][checkpoint] Fix the bug that the shared files will remain forever after the rocksdb incremental checkpoint exception

2023-02-06 Thread via GitHub
curcur merged PR #21855: URL: https://github.com/apache/flink/pull/21855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] curcur merged pull request #21853: [bp-1.16][FLINK-30461][checkpoint] Fix the bug that the shared files will remain forever after the rocksdb incremental checkpoint exception

2023-02-06 Thread via GitHub
curcur merged PR #21853: URL: https://github.com/apache/flink/pull/21853 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] curcur commented on pull request #21853: [bp-1.16][FLINK-30461][checkpoint] Fix the bug that the shared files will remain forever after the rocksdb incremental checkpoint exception

2023-02-06 Thread via GitHub
curcur commented on PR #21853: URL: https://github.com/apache/flink/pull/21853#issuecomment-1420134053 Thanks for the fix! @1996fanrui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] curcur merged pull request #21859: [FLINK-30916][checkpoint] Set the number of rocksdb uploader threads to 1 to solve the unstable bug of unit test

2023-02-06 Thread via GitHub
curcur merged PR #21859: URL: https://github.com/apache/flink/pull/21859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-30730) StringIndexer cannot handle null values correctly

2023-02-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30730: --- Labels: pull-request-available (was: ) > StringIndexer cannot handle null values correctly

[GitHub] [flink] curcur commented on pull request #21859: [FLINK-30916][checkpoint] Set the number of rocksdb uploader threads to 1 to solve the unstable bug of unit test

2023-02-06 Thread via GitHub
curcur commented on PR #21859: URL: https://github.com/apache/flink/pull/21859#issuecomment-1420132426 Thanks @1996fanrui! I think you are right, 1.17 branch has not been cut yet! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink-ml] Fanoid opened a new pull request, #205: [FLINK-30730] Fix null values handling in StringIndexer and StringIndexerModel

2023-02-06 Thread via GitHub
Fanoid opened a new pull request, #205: URL: https://github.com/apache/flink-ml/pull/205 ## What is the purpose of the change This PR fixes null values handling in StringIndexer and StringIndexerModel. ## Brief change log - Skip null values in training, and handle null

[GitHub] [flink] zhuzhurk commented on pull request #21854: [FLINK-30901][runtime] Fix the jobVertex's parallelismConfigured is incorrect when chaining with source operators

2023-02-06 Thread via GitHub
zhuzhurk commented on PR #21854: URL: https://github.com/apache/flink/pull/21854#issuecomment-1420124649 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] leonardBang commented on a diff in pull request #21875: [FLINK-30921][ci] Adds sed command for updating the sources

2023-02-06 Thread via GitHub
leonardBang commented on code in PR #21875: URL: https://github.com/apache/flink/pull/21875#discussion_r1098124530 ## tools/azure-pipelines/uploading_watchdog.sh: ## @@ -27,6 +27,9 @@ if [ -z "$HERE" ] ; then exit 1 fi +sudo sed -i

[GitHub] [flink] zhuzhurk commented on pull request #21857: [FLINK-30903][runtime] Fix the max parallelism used in adaptive batch scheduler doesn't fallbacks to default parallelism

2023-02-06 Thread via GitHub
zhuzhurk commented on PR #21857: URL: https://github.com/apache/flink/pull/21857#issuecomment-1420124614 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-30921) Too many CI failed due to "Could not connect to azure.archive.ubuntu.com"

2023-02-06 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685020#comment-17685020 ] Leonard Xu commented on FLINK-30921: I downgrade the issue priority to Critical as it's an

[jira] [Updated] (FLINK-30921) Too many CI failed due to "Could not connect to azure.archive.ubuntu.com"

2023-02-06 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-30921: --- Priority: Critical (was: Blocker) > Too many CI failed due to "Could not connect to

[GitHub] [flink] luoyuxia commented on a diff in pull request #21789: [FLINK-30824][hive] Add document for option table.exec.hive.native-agg-function.enabled

2023-02-06 Thread via GitHub
luoyuxia commented on code in PR #21789: URL: https://github.com/apache/flink/pull/21789#discussion_r1098118684 ## docs/content.zh/docs/connectors/table/hive/hive_functions.md: ## @@ -73,6 +73,34 @@ Some Hive built-in functions in older versions have [thread safety

[GitHub] [flink] luoyuxia commented on a diff in pull request #21789: [FLINK-30824][hive] Add document for option table.exec.hive.native-agg-function.enabled

2023-02-06 Thread via GitHub
luoyuxia commented on code in PR #21789: URL: https://github.com/apache/flink/pull/21789#discussion_r1098118684 ## docs/content.zh/docs/connectors/table/hive/hive_functions.md: ## @@ -73,6 +73,34 @@ Some Hive built-in functions in older versions have [thread safety

[GitHub] [flink] leonardBang merged pull request #21845: [hotfix][flink-core][doc] add javadoc to improve the code readability

2023-02-06 Thread via GitHub
leonardBang merged PR #21845: URL: https://github.com/apache/flink/pull/21845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (FLINK-30811) Fix sql gateway can not stop job correctly

2023-02-06 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang closed FLINK-30811. - Resolution: Fixed Merged into master: bbd5a7876eb1542ff89f05f5f5d82bb8bd41b7bd > Fix sql

[jira] [Updated] (FLINK-30833) TestMetricGroup supports being closed

2023-02-06 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mason Chen updated FLINK-30833: --- Description: For testing purposes, closing a metric group is required to verify logic that

[jira] [Updated] (FLINK-30833) TestMetricGroup supports being closed

2023-02-06 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mason Chen updated FLINK-30833: --- Summary: TestMetricGroup supports being closed (was: MetricListener supports closing metric

[jira] [Commented] (FLINK-30833) MetricListener supports closing metric groups

2023-02-06 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685012#comment-17685012 ] Mason Chen commented on FLINK-30833: For context, I was writing a connector that depends on closing

[GitHub] [flink] fsk119 closed pull request #21802: [FLINK-30811][sql-gateway] Fix SqlGateway cannot stop job correctly

2023-02-06 Thread via GitHub
fsk119 closed pull request #21802: [FLINK-30811][sql-gateway] Fix SqlGateway cannot stop job correctly URL: https://github.com/apache/flink/pull/21802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] fsk119 commented on pull request #21802: [FLINK-30811][sql-gateway] Fix SqlGateway cannot stop job correctly

2023-02-06 Thread via GitHub
fsk119 commented on PR #21802: URL: https://github.com/apache/flink/pull/21802#issuecomment-1420104729 All tests pass in my private pipeline: https://dev.azure.com/1059623455/Flink/_build/results?buildId=544=results Merging... -- This is an automated message from the Apache Git

[jira] [Updated] (FLINK-30932) Enabling producer metrics for KafkaSink is not documented

2023-02-06 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mason Chen updated FLINK-30932: --- Description: Users can enable producer metrics by setting `register.producer.metrics` to True. We

[jira] [Commented] (FLINK-30921) Too many CI failed due to "Could not connect to azure.archive.ubuntu.com"

2023-02-06 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685006#comment-17685006 ] Rui Fan commented on FLINK-30921: - I see it's recovered, the new CI is green. > Too many CI failed due

[jira] [Assigned] (FLINK-30864) Optional pattern at the start of a group pattern not working

2023-02-06 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu reassigned FLINK-30864: --- Assignee: Juntao Hu > Optional pattern at the start of a group pattern not working >

[jira] [Created] (FLINK-30932) Enabling producer metrics for KafkaSink is not documented

2023-02-06 Thread Mason Chen (Jira)
Mason Chen created FLINK-30932: -- Summary: Enabling producer metrics for KafkaSink is not documented Key: FLINK-30932 URL: https://issues.apache.org/jira/browse/FLINK-30932 Project: Flink Issue

[jira] [Comment Edited] (FLINK-29825) Improve benchmark stability

2023-02-06 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684999#comment-17684999 ] Dong Lin edited comment on FLINK-29825 at 2/7/23 2:15 AM: -- [~pnowojski] I think

[jira] [Commented] (FLINK-30886) Content area is too narrow to show all content

2023-02-06 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685000#comment-17685000 ] Xingbo Huang commented on FLINK-30886: -- T he content that is too long needs to be viewed by

[jira] [Updated] (FLINK-30886) Content area is too narrow to show all content

2023-02-06 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-30886: - Attachment: image-2023-02-07-10-12-09-237.png > Content area is too narrow to show all content

[jira] [Commented] (FLINK-29825) Improve benchmark stability

2023-02-06 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684999#comment-17684999 ] Dong Lin commented on FLINK-29825: -- [~pnowojski] I think one drawback with your proposal is that it is

[GitHub] [flink] lsyldliu commented on pull request #21789: [FLINK-30824][hive] Add document for option table.exec.hive.native-agg-function.enabled

2023-02-06 Thread via GitHub
lsyldliu commented on PR #21789: URL: https://github.com/apache/flink/pull/21789#issuecomment-1420065801 @luoyuxia Thanks for reviewing, I've addressed the comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink] LadyForest commented on pull request #21507: [FLINK-30386] Fix the issue that column constraint lacks primary key not enforced check

2023-02-06 Thread via GitHub
LadyForest commented on PR #21507: URL: https://github.com/apache/flink/pull/21507#issuecomment-1420061832 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] LadyForest commented on pull request #21802: [FLINK-30811][sql-gateway] Fix SqlGateway cannot stop job correctly

2023-02-06 Thread via GitHub
LadyForest commented on PR #21802: URL: https://github.com/apache/flink/pull/21802#issuecomment-1420061162 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] luoyuxia commented on pull request #21863: [FLINK-30666][doc] Add document for Delete/Update API

2023-02-06 Thread via GitHub
luoyuxia commented on PR #21863: URL: https://github.com/apache/flink/pull/21863#issuecomment-1420059618 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] 1996fanrui commented on pull request #21859: [FLINK-30916][checkpoint] Set the number of rocksdb uploader threads to 1 to solve the unstable bug of unit test

2023-02-06 Thread via GitHub
1996fanrui commented on PR #21859: URL: https://github.com/apache/flink/pull/21859#issuecomment-1420052321 Hi @curcur , all PRs of FLINK-30461 and FLINK-30916 are green. Please help take a look, thanks~ https://github.com/apache/flink/pull/21853

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #203: [FLINK-30688][followup] Disable Kryo fallback in Flink ML tests

2023-02-06 Thread via GitHub
jiangxin369 commented on code in PR #203: URL: https://github.com/apache/flink-ml/pull/203#discussion_r1097419512 ## flink-ml-lib/src/main/java/org/apache/flink/ml/common/util/quantile/QuantileSummary.java: ## @@ -395,12 +400,14 @@ public QueryResult(int index, long

[GitHub] [flink-kubernetes-operator] mbalassi commented on pull request #524: [FLINK-30405] Add ResourceLifecycleStatus to CommonStatus and printer column

2023-02-06 Thread via GitHub
mbalassi commented on PR #524: URL: https://github.com/apache/flink-kubernetes-operator/pull/524#issuecomment-1420013054 I will take a look during CET work hours to help wrap this up for 1.4.0. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] flinkbot commented on pull request #21876: [FLINK-30088][doc] Flink Doc(zh version) has misspelled words

2023-02-06 Thread via GitHub
flinkbot commented on PR #21876: URL: https://github.com/apache/flink/pull/21876#issuecomment-1420010916 ## CI report: * 438895abd0c11a4fce6d451ad01977cf91ab726d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] paul8263 opened a new pull request, #21876: [FLINK-30088][doc] Flink Doc(zh version) has misspelled words

2023-02-06 Thread via GitHub
paul8263 opened a new pull request, #21876: URL: https://github.com/apache/flink/pull/21876 ## What is the purpose of the change Fix typos in Flink doc (Chinese version). ## Brief change log - docs/content.zh/docs/dev/datastream/overview.md ## Verifying

  1   2   3   4   5   >