[jira] [Created] (FLINK-31223) sql-client.sh fails to start with ssl enabled

2023-02-24 Thread macdoor615 (Jira)
macdoor615 created FLINK-31223: -- Summary: sql-client.sh fails to start with ssl enabled Key: FLINK-31223 URL: https://issues.apache.org/jira/browse/FLINK-31223 Project: Flink Issue Type: Bug

[GitHub] [flink] flinkbot commented on pull request #22021: [Hotfix] typo hotfix in TestingDispatcher

2023-02-24 Thread via GitHub
flinkbot commented on PR #22021: URL: https://github.com/apache/flink/pull/22021#issuecomment-1445009374 ## CI report: * 4202649dba573712f33c552efb26505abefb337d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] xuzifu666 commented on pull request #22021: [Hotfix] typo hotfix in TestingDispatcher

2023-02-24 Thread via GitHub
xuzifu666 commented on PR #22021: URL: https://github.com/apache/flink/pull/22021#issuecomment-1445008817 @zentol the method never be used,hotfix the TestingDispatcher with remove it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] xuzifu666 opened a new pull request, #22021: [Hotfix] typo hotfix in TestingDispatcher

2023-02-24 Thread via GitHub
xuzifu666 opened a new pull request, #22021: URL: https://github.com/apache/flink/pull/22021 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[GitHub] [flink] gaborgsomogyi commented on pull request #22009: [FLINK-31109][yarn] Support Hadoop proxy user when delegation token f…

2023-02-24 Thread via GitHub
gaborgsomogyi commented on PR #22009: URL: https://github.com/apache/flink/pull/22009#issuecomment-1445007082 @MartijnVisser everything is green so good to go from.my side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] flinkbot commented on pull request #22020: [FLINK-31222] Remove usage of deprecated ConverterUtils.toApplicationId.

2023-02-24 Thread via GitHub
flinkbot commented on PR #22020: URL: https://github.com/apache/flink/pull/22020#issuecomment-1444987349 ## CI report: * 4b7d8dcf55db34003ac5296887facfc6e5a8ce48 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31222) Remove usage of deprecated ConverterUtils.toApplicationId

2023-02-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31222: --- Labels: pull-request-available (was: ) > Remove usage of deprecated

[GitHub] [flink] slfan1989 opened a new pull request, #22020: [FLINK-31222] Remove usage of deprecated ConverterUtils.toApplicationId.

2023-02-24 Thread via GitHub
slfan1989 opened a new pull request, #22020: URL: https://github.com/apache/flink/pull/22020 ## What is the purpose of the change JIRA: FLINK-31222. Remove usage of deprecated ConverterUtils.toApplicationId. When reading the code, I found that we use

[jira] [Created] (FLINK-31222) Remove usage of deprecated ConverterUtils.toApplicationId

2023-02-24 Thread Shilun Fan (Jira)
Shilun Fan created FLINK-31222: -- Summary: Remove usage of deprecated ConverterUtils.toApplicationId Key: FLINK-31222 URL: https://issues.apache.org/jira/browse/FLINK-31222 Project: Flink Issue

[GitHub] [flink] JunRuiLee commented on pull request #21943: [FLINK-31077][runtime] Mark pending checkpoint onCompletionPromise complete only after the completed checkpoint is added to the store.

2023-02-24 Thread via GitHub
JunRuiLee commented on PR #21943: URL: https://github.com/apache/flink/pull/21943#issuecomment-1444984134 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-31212) Data lost on interval left join with window group

2023-02-24 Thread Lyn Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lyn Zhang updated FLINK-31212: -- Summary: Data lost on interval left join with window group (was: Data lost if window group after

[GitHub] [flink] 1996fanrui commented on a diff in pull request #21999: [FLINK-29816][streaming] Fix the bug that StreamTask doesn't handle exception during restoring

2023-02-24 Thread via GitHub
1996fanrui commented on code in PR #21999: URL: https://github.com/apache/flink/pull/21999#discussion_r1117858061 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java: ## @@ -362,30 +358,35 @@ private void

[GitHub] [flink] 1996fanrui commented on a diff in pull request #21999: [FLINK-29816][streaming] Fix the bug that StreamTask doesn't handle exception during restoring

2023-02-24 Thread via GitHub
1996fanrui commented on code in PR #21999: URL: https://github.com/apache/flink/pull/21999#discussion_r1117858061 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java: ## @@ -362,30 +358,35 @@ private void

[GitHub] [flink] 1996fanrui commented on a diff in pull request #21999: [FLINK-29816][streaming] Fix the bug that StreamTask doesn't handle exception during restoring

2023-02-24 Thread via GitHub
1996fanrui commented on code in PR #21999: URL: https://github.com/apache/flink/pull/21999#discussion_r1117858061 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java: ## @@ -362,30 +358,35 @@ private void

[GitHub] [flink] 1996fanrui commented on a diff in pull request #21999: [FLINK-29816][streaming] Fix the bug that StreamTask doesn't handle exception during restoring

2023-02-24 Thread via GitHub
1996fanrui commented on code in PR #21999: URL: https://github.com/apache/flink/pull/21999#discussion_r1117222444 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java: ## @@ -362,30 +358,35 @@ private void

[GitHub] [flink] RocMarshal commented on a diff in pull request #21999: [FLINK-29816][streaming] Fix the bug that StreamTask doesn't handle exception during restoring

2023-02-24 Thread via GitHub
RocMarshal commented on code in PR #21999: URL: https://github.com/apache/flink/pull/21999#discussion_r1117840988 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java: ## @@ -362,30 +358,35 @@ private void

[GitHub] [flink] RocMarshal commented on a diff in pull request #21999: [FLINK-29816][streaming] Fix the bug that StreamTask doesn't handle exception during restoring

2023-02-24 Thread via GitHub
RocMarshal commented on code in PR #21999: URL: https://github.com/apache/flink/pull/21999#discussion_r1117840988 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java: ## @@ -362,30 +358,35 @@ private void

[GitHub] [flink] snuyanzin commented on pull request #22017: [BP-1.17][FLINK-31142][Table SQL/Client] Catch TokenMgrError in SqlCommandParserImpl#scan

2023-02-24 Thread via GitHub
snuyanzin commented on PR #22017: URL: https://github.com/apache/flink/pull/22017#issuecomment-1444782448 @reswqa this is just a backport to 1.17. Since you reviewed it at https://github.com/apache/flink/pull/22007, could you please have a look here? -- This is an automated message from

[GitHub] [flink] snuyanzin commented on a diff in pull request #21993: [FLINK-31166][table] Fix array_contains does not support null argumen…

2023-02-24 Thread via GitHub
snuyanzin commented on code in PR #21993: URL: https://github.com/apache/flink/pull/21993#discussion_r1117821456 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ArrayElementArgumentTypeStrategy.java: ## @@ -31,24 +31,28 @@

[jira] [Commented] (FLINK-31142) Some queries lead to abrupt sql client close

2023-02-24 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693366#comment-17693366 ] Sergey Nuyanzin commented on FLINK-31142: - Merged to master:

[GitHub] [flink] flinkbot commented on pull request #22019: [FLINK-31221] Fix Typo in YarnConfigOptions.

2023-02-24 Thread via GitHub
flinkbot commented on PR #22019: URL: https://github.com/apache/flink/pull/22019#issuecomment-1444576741 ## CI report: * 830cda0aa78f44f17c0e2e05e3f91657bb9863e7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] slfan1989 commented on pull request #22019: [FLINK-31221] Fix Typo in YarnConfigOptions.

2023-02-24 Thread via GitHub
slfan1989 commented on PR #22019: URL: https://github.com/apache/flink/pull/22019#issuecomment-1444573260 After I found this typo problem, I checked all the codes under moudle(flink-yarn), only this typo. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (FLINK-31221) Fix Typo in YarnConfigOptions

2023-02-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31221: --- Labels: pull-request-available (was: ) > Fix Typo in YarnConfigOptions >

[GitHub] [flink] slfan1989 opened a new pull request, #22019: [FLINK-31221] Fix Typo in YarnConfigOptions.

2023-02-24 Thread via GitHub
slfan1989 opened a new pull request, #22019: URL: https://github.com/apache/flink/pull/22019 ## What is the purpose of the change JIRA: FLINK-31221. Fix Typo in YarnConfigOptions. I found a typo in YarnConfigOptions, I will fix it ## Brief change log Fix Typo

[jira] [Created] (FLINK-31221) Fix Typo in YarnConfigOptions

2023-02-24 Thread Shilun Fan (Jira)
Shilun Fan created FLINK-31221: -- Summary: Fix Typo in YarnConfigOptions Key: FLINK-31221 URL: https://issues.apache.org/jira/browse/FLINK-31221 Project: Flink Issue Type: Improvement

[jira] [Updated] (FLINK-31216) Update kryo to current

2023-02-24 Thread Morey Straus (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Morey Straus updated FLINK-31216: - Description: kryo 2.24 is several years out of date and has a [deserialization

[jira] [Commented] (FLINK-22793) HybridSource Table Implementation

2023-02-24 Thread Thomas Weise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693339#comment-17693339 ] Thomas Weise commented on FLINK-22793: -- [~nicholasjiang] thanks for the confirmation! >

[jira] [Assigned] (FLINK-22793) HybridSource Table Implementation

2023-02-24 Thread Thomas Weise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Weise reassigned FLINK-22793: Assignee: Ran Tao (was: Nicholas Jiang) > HybridSource Table Implementation >

[jira] [Commented] (FLINK-22793) HybridSource Table Implementation

2023-02-24 Thread Nicholas Jiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693322#comment-17693322 ] Nicholas Jiang commented on FLINK-22793: [~thw] , of course could assign to [~lemonjing]. >

[jira] [Commented] (FLINK-31040) Looping pattern notFollowedBy at end missing an element

2023-02-24 Thread Nicholas Jiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693321#comment-17693321 ] Nicholas Jiang commented on FLINK-31040: [~Juntao Hu], [~martijnvisser], thanks for the

[GitHub] [flink] flinkbot commented on pull request #22018: [docs][hotfix] correct label in config configuration

2023-02-24 Thread via GitHub
flinkbot commented on PR #22018: URL: https://github.com/apache/flink/pull/22018#issuecomment-1444277820 ## CI report: * 3e076d84d04b65e4a7fb6bfffe60b70643951629 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] Samrat002 opened a new pull request, #22018: [docs][hotfix] correct label in config configuration

2023-02-24 Thread via GitHub
Samrat002 opened a new pull request, #22018: URL: https://github.com/apache/flink/pull/22018 ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / no) no - The public API, i.e., is any

[jira] [Created] (FLINK-31220) Replace Pod with PodTemplateSpec for the pod template properties

2023-02-24 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-31220: -- Summary: Replace Pod with PodTemplateSpec for the pod template properties Key: FLINK-31220 URL: https://issues.apache.org/jira/browse/FLINK-31220 Project: Flink

[jira] [Commented] (FLINK-31066) Release Testing: Verify FLINK-29932 Upgrade Calcite to 1.29.0

2023-02-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693275#comment-17693275 ] Matthias Pohl commented on FLINK-31066: --- I should have remembered that the backwards compatibility

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-24 Thread via GitHub
rkhachatryan commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1117292622 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/StateSizeEstimates.java: ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-24 Thread via GitHub
rkhachatryan commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1117292622 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/StateSizeEstimates.java: ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache

[GitHub] [flink] twalthr commented on a diff in pull request #19623: [FLINK-27471][table] Add ARRAY_DISTINCT function

2023-02-24 Thread via GitHub
twalthr commented on code in PR #19623: URL: https://github.com/apache/flink/pull/19623#discussion_r1117290234 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayDistinctFunction.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to

[GitHub] [flink] twalthr commented on a diff in pull request #19623: [FLINK-27471][table] Add ARRAY_DISTINCT function

2023-02-24 Thread via GitHub
twalthr commented on code in PR #19623: URL: https://github.com/apache/flink/pull/19623#discussion_r1117290234 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayDistinctFunction.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to

[GitHub] [flink] twalthr commented on a diff in pull request #19623: [FLINK-27471][table] Add ARRAY_DISTINCT function

2023-02-24 Thread via GitHub
twalthr commented on code in PR #19623: URL: https://github.com/apache/flink/pull/19623#discussion_r1117286705 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayDistinctFunction.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to

[GitHub] [flink] venkata91 commented on a diff in pull request #22009: [FLINK-31109][yarn] Support Hadoop proxy user when delegation token f…

2023-02-24 Thread via GitHub
venkata91 commented on code in PR #22009: URL: https://github.com/apache/flink/pull/22009#discussion_r1117272256 ## flink-runtime/src/test/java/org/apache/flink/runtime/security/token/hadoop/KerberosLoginProviderITCase.java: ## @@ -57,7 +58,7 @@ public void

[jira] [Commented] (FLINK-31207) Supports high order function like other engine

2023-02-24 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693263#comment-17693263 ] Timo Walther commented on FLINK-31207: -- [~jackylau] I would propose to make this a top-level issue.

[jira] [Created] (FLINK-31219) Add support for canary resources

2023-02-24 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-31219: -- Summary: Add support for canary resources Key: FLINK-31219 URL: https://issues.apache.org/jira/browse/FLINK-31219 Project: Flink Issue Type: New Feature

[GitHub] [flink] venkata91 commented on a diff in pull request #22009: [FLINK-31109][yarn] Support Hadoop proxy user when delegation token f…

2023-02-24 Thread via GitHub
venkata91 commented on code in PR #22009: URL: https://github.com/apache/flink/pull/22009#discussion_r1117217398 ## flink-runtime/src/main/java/org/apache/flink/runtime/security/modules/HadoopModule.java: ## @@ -70,10 +71,22 @@ public void install() throws

[jira] [Created] (FLINK-31218) Improve health probe to recognize informers already failed at start

2023-02-24 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-31218: -- Summary: Improve health probe to recognize informers already failed at start Key: FLINK-31218 URL: https://issues.apache.org/jira/browse/FLINK-31218 Project: Flink

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-24 Thread via GitHub
rkhachatryan commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1117237527 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/AllocationsInfo.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache

[GitHub] [flink] 1996fanrui commented on pull request #21999: [FLINK-29816][streaming] Fix the bug that StreamTask doesn't handle exception during restoring

2023-02-24 Thread via GitHub
1996fanrui commented on PR #21999: URL: https://github.com/apache/flink/pull/21999#issuecomment-1443901443 And please squash all review commits to the first commit after addressed all comments, thanks~ -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] dmvk commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-24 Thread via GitHub
dmvk commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1117232460 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java: ## @@ -784,7 +788,7 @@ public ArchivedExecutionGraph

[GitHub] [flink] dmvk commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-24 Thread via GitHub
dmvk commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1117232018 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/WaitingForResources.java: ## @@ -65,17 +69,18 @@ class WaitingForResources implements State,

[GitHub] [flink] twalthr commented on a diff in pull request #21500: [FLINK-27995][table] Upgrade Janino version to 3.1.9

2023-02-24 Thread via GitHub
twalthr commented on code in PR #21500: URL: https://github.com/apache/flink/pull/21500#discussion_r1117229017 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/CodeGenUtils.scala: ## @@ -1020,16 +1021,19 @@ object CodeGenUtils { }

[GitHub] [flink] dmvk commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-24 Thread via GitHub
dmvk commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1117230371 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java: ## @@ -978,8 +983,8 @@ public CreatingExecutionGraph.AssignmentResult

[GitHub] [flink] 1996fanrui commented on a diff in pull request #21999: [FLINK-29816][streaming] Fix the bug that StreamTask doesn't handle exception during restoring

2023-02-24 Thread via GitHub
1996fanrui commented on code in PR #21999: URL: https://github.com/apache/flink/pull/21999#discussion_r1117225403 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java: ## @@ -1103,35 +1143,41 @@ private void

[GitHub] [flink] 1996fanrui commented on a diff in pull request #21999: [FLINK-29816][streaming] Fix the bug that StreamTask doesn't handle exception during restoring

2023-02-24 Thread via GitHub
1996fanrui commented on code in PR #21999: URL: https://github.com/apache/flink/pull/21999#discussion_r1117222444 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java: ## @@ -362,30 +358,35 @@ private void

[GitHub] [flink] dmvk commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-24 Thread via GitHub
dmvk commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1117221334 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/StateSizeEstimates.java: ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] dmvk commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-24 Thread via GitHub
dmvk commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1117220303 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/DefaultSlotAssigner.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] 1996fanrui commented on a diff in pull request #21999: [FLINK-29816][streaming] Fix the bug that StreamTask doesn't handle exception during restoring

2023-02-24 Thread via GitHub
1996fanrui commented on code in PR #21999: URL: https://github.com/apache/flink/pull/21999#discussion_r1117218805 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java: ## @@ -362,30 +358,35 @@ private void

[GitHub] [flink] venkata91 commented on a diff in pull request #22009: [FLINK-31109][yarn] Support Hadoop proxy user when delegation token f…

2023-02-24 Thread via GitHub
venkata91 commented on code in PR #22009: URL: https://github.com/apache/flink/pull/22009#discussion_r1117217398 ## flink-runtime/src/main/java/org/apache/flink/runtime/security/modules/HadoopModule.java: ## @@ -70,10 +71,22 @@ public void install() throws

[GitHub] [flink] venkata91 commented on a diff in pull request #22009: [FLINK-31109][yarn] Support Hadoop proxy user when delegation token f…

2023-02-24 Thread via GitHub
venkata91 commented on code in PR #22009: URL: https://github.com/apache/flink/pull/22009#discussion_r1117217398 ## flink-runtime/src/main/java/org/apache/flink/runtime/security/modules/HadoopModule.java: ## @@ -70,10 +71,22 @@ public void install() throws

[GitHub] [flink] dmvk commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-24 Thread via GitHub
dmvk commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1117216690 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/AllocationsInfo.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] dmvk commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-24 Thread via GitHub
dmvk commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1117209507 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/StateLocalitySlotAssigner.java: ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache

[GitHub] [flink] dmvk commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-24 Thread via GitHub
dmvk commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1117208355 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/StateSizeEstimates.java: ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] dmvk commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-24 Thread via GitHub
dmvk commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1117202797 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/StateSizeEstimates.java: ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] dmvk commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-24 Thread via GitHub
dmvk commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1117189073 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/StateLocalitySlotAssigner.java: ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache

[GitHub] [flink] dmvk commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-24 Thread via GitHub
dmvk commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1117187236 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/StateLocalitySlotAssigner.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache

[GitHub] [flink-web] mxm commented on a diff in pull request #613: Kubernetes Operator 1.4.0 blogpost

2023-02-24 Thread via GitHub
mxm commented on code in PR #613: URL: https://github.com/apache/flink-web/pull/613#discussion_r1117121658 ## docs/content/posts/2023-02-27-release-kubernetes-operator-1.4.0.md: ## @@ -0,0 +1,77 @@ +--- +title: "Apache Flink Kubernetes Operator 1.4.0 Release Announcement"

[jira] [Created] (FLINK-31217) Update netty to current

2023-02-24 Thread Morey Straus (Jira)
Morey Straus created FLINK-31217: Summary: Update netty to current Key: FLINK-31217 URL: https://issues.apache.org/jira/browse/FLINK-31217 Project: Flink Issue Type: Technical Debt

[jira] [Created] (FLINK-31216) Update kryo to current

2023-02-24 Thread Morey Straus (Jira)
Morey Straus created FLINK-31216: Summary: Update kryo to current Key: FLINK-31216 URL: https://issues.apache.org/jira/browse/FLINK-31216 Project: Flink Issue Type: Technical Debt

[jira] [Created] (FLINK-31215) Backpropagate processing rate limits from non-scalable bottlenecks to upstream operators

2023-02-24 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-31215: -- Summary: Backpropagate processing rate limits from non-scalable bottlenecks to upstream operators Key: FLINK-31215 URL: https://issues.apache.org/jira/browse/FLINK-31215

[jira] [Assigned] (FLINK-30571) Compute scale parallelism based on observed scalability

2023-02-24 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-30571: -- Assignee: (was: Gyula Fora) > Compute scale parallelism based on observed scalability >

[GitHub] [flink] Samrat002 commented on a diff in pull request #21770: [FLINK-30277][python]Allow PYTHONPATH of Python Worker configurable

2023-02-24 Thread via GitHub
Samrat002 commented on code in PR #21770: URL: https://github.com/apache/flink/pull/21770#discussion_r1117029594 ## flink-python/src/main/java/org/apache/flink/python/PythonOptions.java: ## @@ -122,6 +122,19 @@ public class PythonOptions { +

[jira] [Created] (FLINK-31214) Add support for new command line option -py.pythonpath

2023-02-24 Thread Samrat Deb (Jira)
Samrat Deb created FLINK-31214: -- Summary: Add support for new command line option -py.pythonpath Key: FLINK-31214 URL: https://issues.apache.org/jira/browse/FLINK-31214 Project: Flink Issue

[GitHub] [flink] Samrat002 commented on a diff in pull request #21770: [FLINK-30277][python]Allow PYTHONPATH of Python Worker configurable

2023-02-24 Thread via GitHub
Samrat002 commented on code in PR #21770: URL: https://github.com/apache/flink/pull/21770#discussion_r1117029594 ## flink-python/src/main/java/org/apache/flink/python/PythonOptions.java: ## @@ -122,6 +122,19 @@ public class PythonOptions { +

[GitHub] [flink] chucheng92 commented on pull request #21904: [FLINK-30935][connectors/kafka] Add Kafka serializers deserialize check when using SimpleVersionedSerializer

2023-02-24 Thread via GitHub
chucheng92 commented on PR #21904: URL: https://github.com/apache/flink/pull/21904#issuecomment-1443789397 hi @twalthr Timo, can u help me to review it? it's a small improvement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink-kubernetes-operator] gauravmiglanid11 commented on a diff in pull request #533: [FLINK-30920] [AutoScaler] adds exclude vertex ids for autoscaler to ignore for evaluation and scaling

2023-02-24 Thread via GitHub
gauravmiglanid11 commented on code in PR #533: URL: https://github.com/apache/flink-kubernetes-operator/pull/533#discussion_r1117117865 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingExecutor.java: ## @@ -222,19

[GitHub] [flink-kubernetes-operator] mxm commented on a diff in pull request #533: [FLINK-30920] [AutoScaler] adds exclude vertex ids for autoscaler to ignore for evaluation and scaling

2023-02-24 Thread via GitHub
mxm commented on code in PR #533: URL: https://github.com/apache/flink-kubernetes-operator/pull/533#discussion_r1117086633 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingExecutor.java: ## @@ -222,19 +223,30 @@

[GitHub] [flink] RocMarshal commented on a diff in pull request #21999: [FLINK-29816][streaming] Fix the bug that StreamTask doesn't handle exception during restoring

2023-02-24 Thread via GitHub
RocMarshal commented on code in PR #21999: URL: https://github.com/apache/flink/pull/21999#discussion_r1117078618 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java: ## @@ -362,30 +358,35 @@ private void

[jira] [Commented] (FLINK-31066) Release Testing: Verify FLINK-29932 Upgrade Calcite to 1.29.0

2023-02-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693216#comment-17693216 ] Matthias Pohl commented on FLINK-31066: --- I ran the sample code (once compiled with Flink

[GitHub] [flink] snuyanzin commented on a diff in pull request #21993: [FLINK-31166][table] Fix array_contains does not support null argumen…

2023-02-24 Thread via GitHub
snuyanzin commented on code in PR #21993: URL: https://github.com/apache/flink/pull/21993#discussion_r1117070060 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificInputTypeStrategies.java: ## @@ -71,7 +71,11 @@ public

[jira] [Updated] (FLINK-31066) Release Testing: Verify FLINK-29932 Upgrade Calcite to 1.29.0

2023-02-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-31066: -- Attachment: SavepointReleaseTesting.java > Release Testing: Verify FLINK-29932 Upgrade

[GitHub] [flink] RocMarshal commented on a diff in pull request #21999: [FLINK-29816][streaming] Fix the bug that StreamTask doesn't handle exception during restoring

2023-02-24 Thread via GitHub
RocMarshal commented on code in PR #21999: URL: https://github.com/apache/flink/pull/21999#discussion_r1117066514 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java: ## @@ -1103,35 +1143,41 @@ private void

[jira] [Comment Edited] (FLINK-31066) Release Testing: Verify FLINK-29932 Upgrade Calcite to 1.29.0

2023-02-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693212#comment-17693212 ] Matthias Pohl edited comment on FLINK-31066 at 2/24/23 2:15 PM: I

[jira] [Commented] (FLINK-31066) Release Testing: Verify FLINK-29932 Upgrade Calcite to 1.29.0

2023-02-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693212#comment-17693212 ] Matthias Pohl commented on FLINK-31066: --- I attached the job to this Jira issue that I could use to

[GitHub] [flink] RocMarshal commented on a diff in pull request #21999: [FLINK-29816][streaming] Fix the bug that StreamTask doesn't handle exception during restoring

2023-02-24 Thread via GitHub
RocMarshal commented on code in PR #21999: URL: https://github.com/apache/flink/pull/21999#discussion_r1117060917 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java: ## @@ -1182,13 +1228,13 @@ public void testThreadInvariants()

[GitHub] [flink] RocMarshal commented on a diff in pull request #21999: [FLINK-29816][streaming] Fix the bug that StreamTask doesn't handle exception during restoring

2023-02-24 Thread via GitHub
RocMarshal commented on code in PR #21999: URL: https://github.com/apache/flink/pull/21999#discussion_r1117058961 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java: ## @@ -1103,35 +1143,41 @@ private void

[GitHub] [flink] Samrat002 commented on a diff in pull request #21770: [FLINK-30277][python]Allow PYTHONPATH of Python Worker configurable

2023-02-24 Thread via GitHub
Samrat002 commented on code in PR #21770: URL: https://github.com/apache/flink/pull/21770#discussion_r1117042392 ## docs/layouts/shortcodes/generated/execution_config_configuration.html: ## @@ -15,7 +15,7 @@ The max number of async i/o operation that the async

[jira] [Assigned] (FLINK-12451) [Bitwise Functions] Add BIT_XOR function supported in Table API and SQL

2023-02-24 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-12451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-12451: -- Assignee: Ran Tao > [Bitwise Functions] Add BIT_XOR function supported in Table API

[GitHub] [flink] Samrat002 commented on a diff in pull request #21770: [FLINK-30277][python]Allow PYTHONPATH of Python Worker configurable

2023-02-24 Thread via GitHub
Samrat002 commented on code in PR #21770: URL: https://github.com/apache/flink/pull/21770#discussion_r1117031077 ## flink-python/src/main/java/org/apache/flink/python/env/PythonDependencyInfo.java: ## @@ -100,13 +104,32 @@ public PythonDependencyInfo( @Nullable

[GitHub] [flink] Samrat002 commented on a diff in pull request #21770: [FLINK-30277][python]Allow PYTHONPATH of Python Worker configurable

2023-02-24 Thread via GitHub
Samrat002 commented on code in PR #21770: URL: https://github.com/apache/flink/pull/21770#discussion_r1117029594 ## flink-python/src/main/java/org/apache/flink/python/PythonOptions.java: ## @@ -122,6 +122,19 @@ public class PythonOptions { +

[GitHub] [flink] Samrat002 commented on a diff in pull request #21770: [FLINK-30277][python]Allow PYTHONPATH of Python Worker configurable

2023-02-24 Thread via GitHub
Samrat002 commented on code in PR #21770: URL: https://github.com/apache/flink/pull/21770#discussion_r1117029166 ## docs/static/generated/rest_v1_dispatcher.yml: ## @@ -6,7 +6,7 @@ info: license: name: Apache 2.0 url:

[jira] [Created] (FLINK-31213) Aggregation merge engine supports retract inputs

2023-02-24 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-31213: Summary: Aggregation merge engine supports retract inputs Key: FLINK-31213 URL: https://issues.apache.org/jira/browse/FLINK-31213 Project: Flink Issue Type:

[GitHub] [flink] zentol commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-24 Thread via GitHub
zentol commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1117002036 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/StateLocalitySlotAssigner.java: ## @@ -157,13 +165,21 @@ public Map calculateScore(

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-24 Thread via GitHub
rkhachatryan commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1116992436 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/AllocationsInfo.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache

[GitHub] [flink] RocMarshal commented on a diff in pull request #21999: [FLINK-29816][streaming] Fix the bug that StreamTask doesn't handle exception during restoring

2023-02-24 Thread via GitHub
RocMarshal commented on code in PR #21999: URL: https://github.com/apache/flink/pull/21999#discussion_r1116991198 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java: ## @@ -945,12 +982,15 @@ public void

[GitHub] [flink] flinkbot commented on pull request #22017: [BP-1.17][FLINK-31142][Table SQL/Client] Catch TokenMgrError in SqlCommandParserImpl#scan

2023-02-24 Thread via GitHub
flinkbot commented on PR #22017: URL: https://github.com/apache/flink/pull/22017#issuecomment-1443653369 ## CI report: * d9a32ec908f18c5b1f6dc79f51f61e0d5f275657 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] liuyongvs commented on a diff in pull request #21993: [FLINK-31166][table] Fix array_contains does not support null argumen…

2023-02-24 Thread via GitHub
liuyongvs commented on code in PR #21993: URL: https://github.com/apache/flink/pull/21993#discussion_r1116965989 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificInputTypeStrategies.java: ## @@ -71,7 +71,11 @@ public

[GitHub] [flink] snuyanzin opened a new pull request, #22017: [BP-1.17][FLINK-31142][Table SQL/Client] Catch TokenMgrError in SqlCommandParserImpl#scan

2023-02-24 Thread via GitHub
snuyanzin opened a new pull request, #22017: URL: https://github.com/apache/flink/pull/22017 This is 1.17 backport of https://github.com/apache/flink/pull/22007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-24 Thread via GitHub
rkhachatryan commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1116959052 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/StateLocalitySlotAssigner.java: ## @@ -157,13 +165,21 @@ public Map

[GitHub] [flink] flinkbot commented on pull request #22016: [FLINK-31174][doc] fix inconsistent data format between Learn-Flink Doc and flink-training-repo

2023-02-24 Thread via GitHub
flinkbot commented on PR #22016: URL: https://github.com/apache/flink/pull/22016#issuecomment-1443641876 ## CI report: * 8adeac4636d28c86512f53b09de689830fc3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-3117) Storm Tick Tuples are not supported

2023-02-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-3117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-3117: -- Labels: pull-request-available (was: ) > Storm Tick Tuples are not supported >

[GitHub] [flink] ChenZhongPu opened a new pull request, #22016: [FLINK-3117][doc] fix inconsistent data format between Learn-Flink Doc and flink-training-repo

2023-02-24 Thread via GitHub
ChenZhongPu opened a new pull request, #22016: URL: https://github.com/apache/flink/pull/22016 Due to the previous [pr](https://github.com/apache/flink-training/pull/36) in which the data format of `TaxiRide` is changed, there is an inconsistency in [Data Pipelines &

[GitHub] [flink] snuyanzin merged pull request #22007: [FLINK-31142][Table SQL/Client] Catch TokenMgrError in SqlCommandParserImpl#scan

2023-02-24 Thread via GitHub
snuyanzin merged PR #22007: URL: https://github.com/apache/flink/pull/22007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   3   >